From patchwork Fri Mar 31 09:25:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77696 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp440097vqo; Fri, 31 Mar 2023 02:50:48 -0700 (PDT) X-Google-Smtp-Source: AKy350bJZCczXT3b1qEdLhAtR/1IgXatrAtvT4OApaETxKZ5JInPmaflp8hgvdA9XLjiDr+1kq7j X-Received: by 2002:a17:90b:3b81:b0:23d:1a5c:ff3d with SMTP id pc1-20020a17090b3b8100b0023d1a5cff3dmr30112630pjb.37.1680256247758; Fri, 31 Mar 2023 02:50:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680256247; cv=none; d=google.com; s=arc-20160816; b=GBOf1o4PnJRr7v/pO7d/8zxcyMiMG9YfrT5Wq4oR1rVRlOuvM5mK+FUrGucR9qCQcq a2MiB539uJAI9e6Sir0iNwAOgN+YL9/9j2FTNqkC/VlNPsdXxUcvoCd9LhZsNCO0AC8z 5alfe/d77G32fi50WN2X4UQy27OjVZNG4QjuqqDRgQiE4aswuMJCcPgKtpzIQzzkoGYk eaWGKA3YBT/RiBI2byhFLMSJw4ClqHlmZ0l4Fk9sTBibZy7Xj5SG9zmzBO2WochVcR90 cuorAwKp6eyyPTY607xDffdQGzjTyMN14t5MkEZB+WFvCR0eg34cMgSLOJuOs91m6lXq p0xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ghq2h0ZeRDl+V3bJy8nchnHJ51NBt4LLEjW9F1Zs4Ds=; b=MymR6Xl4MVDP6mHfEJQY/4zpXv1xCm/nXXm4yhF5IYdz71TkvrnfKARs6oS6IifzVK ujlzjIpt2lGiEneLR5oHaQDVKDhqjX+NBg3eFdCZQLXhNrWe3oBXiWwxJR0dhMTOnjBP ltXGb0tQFwiE+kW4oTqBFEhlHZKcVV+73rfHfg7SGjVwmncxZBseDVH+oCe6cxXYzJsy 26Jl3cnFBpqVWgDnyI9zvRzIdE/iKwavMyRI/fWSv4Pdqih9gc4ZFL2b9HmdysoHJTk9 6OPcgMTtTzcz5ojTxH4QEJfufv++26M1Zi/dam00ipclif1TB2q1d62bzIHJQhYmAInT 3ANw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XgdsOUyL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ei23-20020a17090ae55700b00225c475b3d2si6216107pjb.55.2023.03.31.02.50.36; Fri, 31 Mar 2023 02:50:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XgdsOUyL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231584AbjCaJ0Y (ORCPT + 99 others); Fri, 31 Mar 2023 05:26:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231233AbjCaJ0V (ORCPT ); Fri, 31 Mar 2023 05:26:21 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CB2F46BF for ; Fri, 31 Mar 2023 02:26:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8A5DECE2E04 for ; Fri, 31 Mar 2023 09:26:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C3E0C4339C; Fri, 31 Mar 2023 09:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254776; bh=JZf0svDcEcGog0NsSz5cUzUNXsqZCcAN5I+gmpPDgzg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XgdsOUyLaKZBHIvB9GPVLk4X9CeQ4pHXp0fBiu28DVZBvm43qBKIVCFL/sdqsJECq M6EbfJ6qLZvvrwd0m97u25a66HakrZhKSyhJwVb48M5K3Bhqo9uS/rCyoc9CfZ2pBQ NP2Ei7jihGLSnvmdd49aH6AjEpDiArG+97ca2E2XQ8UHA1xXBDTxMyDg0kr7ockqzZ OKV8BB64V/G2tKuBK3YQELLfvtgjvf+ON2XVZnRjZs6f64TVvNJYc3/zgMgSz85GiB GhFWGxCl3fq4/F6H6fKnQNwKm0Q14hOIh3eVxjyWNGqP9LWgeHDeiZBG0VSU9HTzu1 pnljvPt9fz31A== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 01/19] drm/i915/i915_scatterlist: Fix kerneldoc formatting issue - missing '@' Date: Fri, 31 Mar 2023 10:25:49 +0100 Message-Id: <20230331092607.700644-2-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761876375099920158?= X-GMAIL-MSGID: =?utf-8?q?1761876375099920158?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/i915_scatterlist.c:62: warning: Function parameter or member 'size' not described in 'i915_refct_sgt_init' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/i915_scatterlist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_scatterlist.c b/drivers/gpu/drm/i915/i915_scatterlist.c index 7c7a86921b1c7..e93d2538f2988 100644 --- a/drivers/gpu/drm/i915/i915_scatterlist.c +++ b/drivers/gpu/drm/i915/i915_scatterlist.c @@ -56,7 +56,7 @@ static const struct i915_refct_sgt_ops rsgt_ops = { /** * i915_refct_sgt_init - Initialize a struct i915_refct_sgt with default ops * @rsgt: The struct i915_refct_sgt to initialize. - * size: The size of the underlying memory buffer. + * @size: The size of the underlying memory buffer. */ void i915_refct_sgt_init(struct i915_refct_sgt *rsgt, size_t size) { From patchwork Fri Mar 31 09:25:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77703 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp441203vqo; Fri, 31 Mar 2023 02:53:32 -0700 (PDT) X-Google-Smtp-Source: AKy350ZIsSt85FA2lJJ0uSANBnTS5hFaiduCbpkxCMordhLV/JBFTDnlBNYbk0GP/VBKOdx4RfvS X-Received: by 2002:a17:906:2f96:b0:932:8cd:1021 with SMTP id w22-20020a1709062f9600b0093208cd1021mr26052974eji.33.1680256411936; Fri, 31 Mar 2023 02:53:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680256411; cv=none; d=google.com; s=arc-20160816; b=02dK+b2XXywizlGeKDtSXs0Yo2UOQAdfAZ3Hv9cAIb6MnLAioghxl/Dfdk9iIJ9WKs dDRNm0Q4WvgV0yyIF5lcCULiOotPh/8lIi2GtkwTn7KH5fM7z8rPaUx0puuPQJ80IfCg RcglAnYia1tEfqzNmP4Nx1Ol+ff20jnzX3Hjd0yqXNWBtOKWPUdHf/85KWpnSOb+m8jY iQEl1ccTH0iaOM+HkGTN0qpOMMlIRx2hgAp5pd6HpFfxn9cDuEz+3ASiXVp+V7qNgN5h Iu0YBHONe+fiPoyOVxktDijKCQu6T1jwhtdO7LGPKG58vzDs+mZuesJV2bjZc1hDDN42 rsyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JXY9ewmm5TLeopP6iNd+SNwHFpqWW2wMSFy3X74X3Zw=; b=NNG1DTWDTRlRQllCQhE3ATBknTSu9eR3NguXHXIoOqJUBY6/thNIfZWB9ZB1DjhkyE 79ZzeHvxYlJPtu6c5xYpFLKkR6CDZ/WV4pIcynydMyDW4utSNTW1no5BBryVHiYeqwkn UDFGJ5C6kQQxr4P2EZJmGajESkAlctAfC7NTZgGdvvc6I2GNdmt/QJQoJM91TQbwPgYH JzhVsm5UBPn6qpKuWeeG86ieTa5CXO58tVvhACP6KEV2MEYcMY1cUyPzGwFyLVQAAXxC KJJHELCW6Uq7nNYXWg0PQe76c4LvS1QvacPGWvA0RXMdEXV0FKmq/9hZbogpa1HCstP8 Dkag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nxD+CR5W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p4-20020a170906228400b009334be3d5fcsi1727822eja.296.2023.03.31.02.53.08; Fri, 31 Mar 2023 02:53:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nxD+CR5W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231745AbjCaJ03 (ORCPT + 99 others); Fri, 31 Mar 2023 05:26:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231365AbjCaJ0W (ORCPT ); Fri, 31 Mar 2023 05:26:22 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 194AE1D2C2 for ; Fri, 31 Mar 2023 02:26:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9574FB82DAC for ; Fri, 31 Mar 2023 09:26:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1833FC4339E; Fri, 31 Mar 2023 09:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254779; bh=JNGe4Stkfx4U8PEelqzPaQWET75d/oi6wGG9GBuzGjg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nxD+CR5W+M4FMA4u7Hve2K2JQHHfpYrFTxcrzo1+D3s9MFvxrft5XY2qstmWV0U9b Dcihw64MldAHjYk5Nu4uAVf1bD0M+vHq8MjU9fFglHhvT3juY9hxLJP6J1mNK+Lpiq bRYgOkTu73CBFuOtEJKjmVsZTQfaJuaap1FntnI8LO14tvm9hxT/e4r9YDeBmRGSb+ tdXfN3XV/IZVyIYAXTp4UEVQgqHuRrP9KOFV8uEbsgKZ8zeoKRZ0f7Knn7Sgyr+6a/ tIyR7WqeSSP+Asl/BYPWoGv60k9WGCg/Aeak+jN7+o5Mer9rfEVJLgX/HOAs4Ck4o+ Re9zsLs21/OgQ== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 02/19] drm/i915/intel_region_ttm: Provide missing description for 'offset' param Date: Fri, 31 Mar 2023 10:25:50 +0100 Message-Id: <20230331092607.700644-3-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761876547118877582?= X-GMAIL-MSGID: =?utf-8?q?1761876547118877582?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/intel_region_ttm.c:201: warning: Function parameter or member 'offset' not described in 'intel_region_ttm_resource_alloc' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/intel_region_ttm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_region_ttm.c b/drivers/gpu/drm/i915/intel_region_ttm.c index b7fbd5abb42a5..bf6097e7433d5 100644 --- a/drivers/gpu/drm/i915/intel_region_ttm.c +++ b/drivers/gpu/drm/i915/intel_region_ttm.c @@ -181,6 +181,7 @@ intel_region_ttm_resource_to_rsgt(struct intel_memory_region *mem, /** * intel_region_ttm_resource_alloc - Allocate memory resources from a region * @mem: The memory region, + * @offset: BO offset * @size: The requested size in bytes * @flags: Allocation flags * From patchwork Fri Mar 31 09:25:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77664 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp430814vqo; Fri, 31 Mar 2023 02:28:15 -0700 (PDT) X-Google-Smtp-Source: AKy350YuviJ/QWeC+m33PBYlghl4fs+HGdYvAV2Ls1yXFeyd0RodyC84m3Dfn8usNZ2Gz6Up+3gl X-Received: by 2002:a17:906:aad0:b0:932:365a:969a with SMTP id kt16-20020a170906aad000b00932365a969amr27675739ejb.8.1680254894837; Fri, 31 Mar 2023 02:28:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680254894; cv=none; d=google.com; s=arc-20160816; b=teJGq8Yv+fZ27J6QANgjM1Nj6uQOCjS/StMTMTtovhDG/4zWHpINJP+NuxqDeBVPav 04R6JValMYgg4Ag42X/Od3hayYl8NF98n43vhWZfAUdX1ZUONrjUsQ/2Pk4kY/cYfNhw UjaHlBHdwtK4XOmxqaQDF4xp1aK93dlsWy4KVP/AITUHrX1IPM1NlYZSRUr45xpW/j5l Z18rHyhz4eAU1wnosrgcdPT4umAqq/h2xr2TLbfn78GfC66KxKoBiusW6IgpzL2jdG/4 hzBzTdxVfqEoIkbdZdtTNU0/HKPLtDAU6wFDUrSCRyBSQGfqJIBiKUXXr8650IuS6eet 9xIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=X5eJSkJklu0cJjyI63EHEpoPmasJKeyqePWzvpqguJw=; b=fUzdVX0+iCeUYuF1Kn/3c05fxdkcA3MxBNkw6MUy7jk2X1RKIY9w1ILSd4oxnmLH+R KfpQYmnqgAWTCvTtY8N2rkHxvFVwZ6Oc26g3BMbTGKH45Jdt0JA1wSNH2rZp5PtjDbmg n/3FvYn32Be33/Sp9XYCbpHWPo7M7LIatXga0nnByM0X3rdC+MWDC8Dt7sbew/P5vkaX nDzvcEDm5261ahlpbkSoMCzomM9GKpHdXsE5gxK23JTPKFafMr9q2rPILPGOj6BrLUh/ hi3Hn/3FrZmeLGn+pqxRxn85OfOdBC8z6G5qku55aVZD8nQvSIiIwAeAvcUoKdm8JMD6 Rxlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dAZXFCbK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ot7-20020a170906ccc700b00923c54e9ad0si1425387ejb.585.2023.03.31.02.27.51; Fri, 31 Mar 2023 02:28:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dAZXFCbK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231786AbjCaJ0b (ORCPT + 99 others); Fri, 31 Mar 2023 05:26:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231616AbjCaJ01 (ORCPT ); Fri, 31 Mar 2023 05:26:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBAAF1CB89 for ; Fri, 31 Mar 2023 02:26:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7089B62649 for ; Fri, 31 Mar 2023 09:26:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1DFFC4339C; Fri, 31 Mar 2023 09:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254781; bh=Xj4WyozKPmZtTN1kClJTBi/X5tfzwvcxXXrKvf/WUhE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dAZXFCbKCx3fKL0doDoVVk5L6sJXUiM+NHgn9vejM8I7z7I0QiyJMRnBXSMO/GJJp tAJn9X7SwrcuHi0CWHJGVdad+YwKNqZS6jRDaiIdAGOiJ8r2NJDZRU51HoTZvGx2l5 nd/DvOqnztIsmLzrKXVA2FxmEUE7FA6UkmYPQy6230mBRIikOOJ5FnWpGpZdREATr8 pOhWgFxK13pM9pdTb40qb72FZY4Efp53sy9K2nt/VbfsGRcAMyjyWlQN1RzSpcWHzp gM7o0R32UFbBwBS6Q3NRgj9FKi8sVLgpUa0LU2lZlnJIjrFVHQ7OEop/9+1el27VDz epdoO575oQg4g== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Jerome Glisse , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 03/19] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move() Date: Fri, 31 Mar 2023 10:25:51 +0100 Message-Id: <20230331092607.700644-4-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761874956585677749?= X-GMAIL-MSGID: =?utf-8?q?1761874956585677749?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_bo_move’: drivers/gpu/drm/radeon/radeon_ttm.c:201:27: warning: variable ‘rbo’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter Cc: Jerome Glisse Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_ttm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index 2220cdf6a3f68..0ea430ee52569 100644 --- a/drivers/gpu/drm/radeon/radeon_ttm.c +++ b/drivers/gpu/drm/radeon/radeon_ttm.c @@ -198,7 +198,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict, { struct ttm_resource *old_mem = bo->resource; struct radeon_device *rdev; - struct radeon_bo *rbo; int r; if (new_mem->mem_type == TTM_PL_TT) { @@ -211,7 +210,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict, if (r) return r; - rbo = container_of(bo, struct radeon_bo, tbo); rdev = radeon_get_rdev(bo->bdev); if (!old_mem || (old_mem->mem_type == TTM_PL_SYSTEM && bo->ttm == NULL)) { From patchwork Fri Mar 31 09:25:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77699 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp440598vqo; Fri, 31 Mar 2023 02:51:59 -0700 (PDT) X-Google-Smtp-Source: AKy350Yk/U9/sW0PeYmEA65oDCvXhb4fnUOkav5wKBd5Z2unN+Gry9HkJn0RlL/dgG5YErpYufz3 X-Received: by 2002:a17:907:2175:b0:920:7a99:dcd4 with SMTP id rl21-20020a170907217500b009207a99dcd4mr26520205ejb.62.1680256319161; Fri, 31 Mar 2023 02:51:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680256319; cv=none; d=google.com; s=arc-20160816; b=JlYt3nJoGERPms/x2xhGc1SfOGWRzHcVDECD6G+PmR4dXG/c1PkVI//l2MoEKI29HE 5i84Ge+hGWblZiRDloy8/M0NJJrt9QmwoTcx46RtKxjFDYkeEWqjJQT2nCOyiq1LK7ob +YQFcgn48jnwv07ztQ+XDsVk+ZKaS8LZE27bB5Ly+Y2aLem6FWFhN/4EyC3dMIFYXrKh VLap8E3id0p3qV4f4apDESmQBfv9DzWVg466J3WInU/6yE3BdKrZ5kXTRXzQFrSE0WnZ fvTpgmI8lwm9qD8TCJ7ztvGhrlHhbgasWganowuxIiFskPqfu/4UlH5AmETa67i7EUMO F7tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QwFsPxEhcruZEO95PfXVrcF4kc9D850xq+sJtapfobc=; b=fyztS/TaiUDFque4zBkvwbuUnl3lyAXJdbxJstJST0ayyuT2OKplEIvaB8TyladP5r k5uNnOB7VomO0gyNjyWzj6w6a58RMR3WzxuUMQ5LrGZhk74s6601bSSN3+thVkyyC3aA diNkQeVC/4k3cHHL+vSOy6FMyEM6mkXGxpawQjeu0Ea06fx/evnnB1QqfeV/C7CBS/x2 HGgnF+6WkHqhtN9qSZHk7iAHcV2DC6fP+A92tsYnl19Kep9/3hLribT8y7ZXHLSN+dzF 0uOTV9mEDm1a3rwGaLI8YR6QcmeHSw7/78mCZvt9NrQtvcmvlCMWw1GRFky4d9AfWINn 1WPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QfTjoBeS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k23-20020aa7d8d7000000b004acb37caea9si1679947eds.344.2023.03.31.02.51.35; Fri, 31 Mar 2023 02:51:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QfTjoBeS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231997AbjCaJ0q (ORCPT + 99 others); Fri, 31 Mar 2023 05:26:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231759AbjCaJ0a (ORCPT ); Fri, 31 Mar 2023 05:26:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2088C1D902 for ; Fri, 31 Mar 2023 02:26:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AF93BB82DAF for ; Fri, 31 Mar 2023 09:26:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 514EEC433EF; Fri, 31 Mar 2023 09:26:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254784; bh=TRYSMYkXks9q3GSP+rY54wBe6rlqoIbNXHmoR55KP+A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QfTjoBeSVRz6N27mcOkAv5LA/MVWqsH0d1zmQmcsuuwyb4YU9RGjd31eVeQB/YAfB +6FK9GNc2T3I4jj510Nx1R+EFu7iKO+HFBJd/Tcndv3C3ns+K2EhZbj8VEgAfiyDFr h7QzGIZHIBP7JDINi7BJlg5Ij4UMemIeOqkgH9SQLMUzYiBO/IHQPG6TxuffMIaywB 8ziNYiQxweDizvG0jBB47zAgCrI1ROgNsgp7AYDcSMr9pwQ4b+H4wkCj9iS/KLbR4F 7lEfCR3WYqlYR60BXPSZ7LxYt//kkFFoMyTTC4ZyYq4BPQrsOugK3OPicOHUykXjLN NIeywdUEbvJJw== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 04/19] drm/i915/display/intel_display_debugfs: Fix incorrect param naming for 'intel_connector' Date: Fri, 31 Mar 2023 10:25:52 +0100 Message-Id: <20230331092607.700644-5-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761876450298940672?= X-GMAIL-MSGID: =?utf-8?q?1761876450298940672?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/display/intel_display_debugfs.c:1668: warning: Function parameter or member 'intel_connector' not described in 'intel_connector_debugfs_add' drivers/gpu/drm/i915/display/intel_display_debugfs.c:1668: warning: Excess function parameter 'connector' description in 'intel_connector_debugfs_add' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c index d5715ccc37f0e..195b6cb379ad1 100644 --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c @@ -1395,7 +1395,7 @@ DEFINE_SHOW_ATTRIBUTE(intel_crtc_pipe); /** * intel_connector_debugfs_add - add i915 specific connector debugfs files - * @connector: pointer to a registered drm_connector + * @intel_connector: pointer to a registered drm_connector * * Cleanup will be done by drm_connector_unregister() through a call to * drm_debugfs_connector_remove(). From patchwork Fri Mar 31 09:25:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77665 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp430920vqo; Fri, 31 Mar 2023 02:28:32 -0700 (PDT) X-Google-Smtp-Source: AKy350YUggzLQBLenUs00g9g4CxE9TRlxcXcIGKC6EVmJZ5vRbYIxfqj8jbbESt8dWTIe/yWJU5z X-Received: by 2002:a05:6402:4da:b0:4fa:b302:84d9 with SMTP id n26-20020a05640204da00b004fab30284d9mr24902095edw.14.1680254912006; Fri, 31 Mar 2023 02:28:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680254911; cv=none; d=google.com; s=arc-20160816; b=W1kXNSc+eC07ofoMmdo2IL9Ud2dJQxEiGkBf6kf9rNxhB4vdbEspVvhfrsJpqvYwjc z4nWo5W01EzM/HlOHTTNNDBIKUCRENIfqaes1ZsBPA0R2J6cO8Jf0QsDuPxuVFddM0Fj EIzI9CBTPXH2dLOCNAtgrNU0WULXiNAbTR0qPkquVBIPNnYwWLKnZZQfRGjA7vcPV1mk OLFeC1T6tepNNaTK+Qgln5SS4xC7BhIzIdWpmrqmSrzJYKBEH0LksIGioJxDX/IHjMkj KGjIq06pLSzUzVa9A5tpM+ikuZX4yoXi0pGNBeNcKPBsvkorgJjb1qUzNlrGEoICjDtm GdOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sLqob5+bzfVEzdYN5+uhOyDfMTjrq4M8V4JopvO36/g=; b=nlSu3WgnyTT+IK8AiXK77TikAx0ghjIHMXpAPCHBIwJH7cS4KqQxQCOhSH8IHaZ88/ M5GpHXxCJubXqcgc2qZczIoq5FJQTGvGMFstGqwJNH1jEEzCKFxiLrtgg8EKnliR1O86 46KsU8imTEb92uB93xej8dwoGOFs7JCUi32yXehBDxEROOjp/rT3QF+JFPYpQBkeONEs 7yE4jejzP3cz2CpRSRJBAuSQZHRnH63RVXWRAuTOG+GSeQ/jLAx4Z74AA3Ci3cJfePy3 LDwlj31L+txP0UWMpwJ3PsgTQF2p53v5RJjVjSSswHrGfUrxDjXAN/lBxzqhQh6ScMd+ ZYQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JBMBGg+5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i26-20020aa7dd1a000000b004fce4843227si1658113edv.328.2023.03.31.02.28.07; Fri, 31 Mar 2023 02:28:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JBMBGg+5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232090AbjCaJ0t (ORCPT + 99 others); Fri, 31 Mar 2023 05:26:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231876AbjCaJ0l (ORCPT ); Fri, 31 Mar 2023 05:26:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33EFD1D920 for ; Fri, 31 Mar 2023 02:26:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A2A6B62656 for ; Fri, 31 Mar 2023 09:26:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6210C4339B; Fri, 31 Mar 2023 09:26:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254787; bh=iistdlhu4w0I2/CmfXzNavb5iLcbcIHzclr1yyY04LY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JBMBGg+5x+5/0/DDfOyE9fcIfl8eW49WC8vHHiuIxCpHZ8AlQcsYvLvnF0oBX1rSP su3kCXz60f/Vl9BYBRbifih+ckCQEXeEOytJt+NAZB45DvfPhf2wvzQcb6p82MJakt XFSe9scn3arsz1P3U1VOdx9TNL/oHBAPuGRwP2lIgeWWW9Gkl+fKR75gweWnq17sGM vIc5IlWso2dNzS2GsVcc/CAaYpZaJQpImT9619XZza+FXFuGWmHcfIBPPOuWpDzrzm niA0QPM1aLNsab9MPvUVlPWkEnmfDElmFkpBX53QtMY7IVRsww96aGevm7097/wu/7 rhXyeGgzrLWsA== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 05/19] drm/i915/gt/intel_engine_cs: Fix a couple of incorrectly named functions Date: Fri, 31 Mar 2023 10:25:53 +0100 Message-Id: <20230331092607.700644-6-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761874974506746909?= X-GMAIL-MSGID: =?utf-8?q?1761874974506746909?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gt/intel_engine_cs.c:1324: warning: expecting prototype for intel_engines_init_common(). Prototype was for engine_init_common() instead drivers/gpu/drm/i915/gt/intel_engine_cs.c:1406: warning: expecting prototype for intel_engines_cleanup_common(). Prototype was for intel_engine_cleanup_common() instead Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c index 2966aed422239..03c5e3df0a7e0 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c @@ -1429,7 +1429,7 @@ create_kernel_context(struct intel_engine_cs *engine) } /** - * intel_engines_init_common - initialize cengine state which might require hw access + * engine_init_common - initialize cengine state which might require hw access * @engine: Engine to initialize. * * Initializes @engine@ structure members shared between legacy and execlists @@ -1515,8 +1515,8 @@ int intel_engines_init(struct intel_gt *gt) } /** - * intel_engines_cleanup_common - cleans up the engine state created by - * the common initiailizers. + * intel_engine_cleanup_common - cleans up the engine state created by + * the common initiailizers. * @engine: Engine to cleanup. * * This cleans up everything created by the common helpers. From patchwork Fri Mar 31 09:25:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77690 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp439266vqo; Fri, 31 Mar 2023 02:48:39 -0700 (PDT) X-Google-Smtp-Source: AKy350ZQO5OpyrhJWUQEqYEhaIuXxK8EG4lggKmlHsydQJKVJ6LgReg8Gcp+Sl5YDKCmnV9GYLO8 X-Received: by 2002:a62:1dcc:0:b0:62d:c382:1384 with SMTP id d195-20020a621dcc000000b0062dc3821384mr6277219pfd.5.1680256119678; Fri, 31 Mar 2023 02:48:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680256119; cv=none; d=google.com; s=arc-20160816; b=ZV6VMSTtBvO44iXxdaWtYOkZ1kaBxfv6tOhrs6zOx8OHEJtdEGVUnujrQE0fWm57NW LxzFQrqErRyRGqljCuo0BMFUZP+cl/warrCUQbSiNO8UiFPOucmvIfMESJM6bzbj8GwJ 984f2gnVJAiJ/jInQQUnP2ZiGoY1pfZvJQXDasL4oczWHObnaR0EtJ8dEIdcfq2/d5R4 IorNYhdugTJpUexdqYxmZyo3xHrAfmbKw8HriUIMYeIfm2pVM/Iah2NJHiEsXm/nN0IA MMdP6OXUXGFbbS17iU1FXihHu2bQ6WEreeiTHjjMSUA25VUB78PqhrokdF5mpoiPR2HA 3RZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=g2ULKx4aUVYGpH9d3VVQxyilOVP8GMZ1gUQKNIF+9VM=; b=WDArC5Y7MVipAGjeYenFWysxJW0v+vfzzBrhmY61GEpdGLEuLGM/c1tUII5FVUSt20 j9tUuZ4ZeqD8mtZDwCUHWe059x3wE027bbgDpYOH4hSqZgXWD7hvjyCndor/YIGd6+55 zr31LoDFsVl5GMFYrhZsG76aWEe1rb/G2S8f92F7YrKvOJyh1oeJgcvbSBv7l2+wSUiI qs8OdrTIYACY3T7WnpXI4bpGiY0slcwVvot3Eq/vcmW/u+QyL1AnPiW1QMdMmnnu00No EJEGdaUCQZ5c3FyC8bdVLG5csIbaMKMVZaw74renLPi/CzvRsWL1VAI5GJNY9y04GPUL adgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oALhkUyV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a20-20020aa795b4000000b00625637c1699si2088450pfk.34.2023.03.31.02.48.27; Fri, 31 Mar 2023 02:48:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oALhkUyV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231846AbjCaJ1A (ORCPT + 99 others); Fri, 31 Mar 2023 05:27:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231417AbjCaJ0p (ORCPT ); Fri, 31 Mar 2023 05:26:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E73921EFC0 for ; Fri, 31 Mar 2023 02:26:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 39DBC62656 for ; Fri, 31 Mar 2023 09:26:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82BC2C433EF; Fri, 31 Mar 2023 09:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254789; bh=KiXF3LYVu3KrlWgglMJh8IlNjIF1YPLM2PZ/FiGHP9U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oALhkUyVSDBvPDldu6mPEnFEqxUY6av6K0MJOpSnZ7IZtnV2CgenCiwHuLPHu7vPb yYma2Q42wt7oakc2RS2bFT3fnkVtvkZ+HaKfhrJBsj2AygNx6uK0mDeTtQbHjrAsS5 O158zgxJb28qq/ger5SZbZeR+PhJZNBcbKwANJIlm9eYTzlQaB7qjBGkY/rGkngmtX +g0thBRH0RufBJG/VJ08tA7h+6E3SkbJkLmGj9RLk9j78EKi5YZjgs18QV0+DhSW78 03Z/k0JSwl9tAHxh2MyyhgvEBD7m5G2h+wZIGkm9pZ9mBhNmxiS65LjUpMK+sP4QkV zTw9KQxHKjFGg== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 06/19] drm/i915/gt/intel_rps: Demote a kerneldoc abuse for ips_ping_for_i915_load() Date: Fri, 31 Mar 2023 10:25:54 +0100 Message-Id: <20230331092607.700644-7-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761876241058686983?= X-GMAIL-MSGID: =?utf-8?q?1761876241058686983?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gt/intel_rps.c:2646: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gt/intel_rps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c index e97c52c90689a..301359b500a3e 100644 --- a/drivers/gpu/drm/i915/gt/intel_rps.c +++ b/drivers/gpu/drm/i915/gt/intel_rps.c @@ -2646,7 +2646,7 @@ bool rps_read_mask_mmio(struct intel_rps *rps, static struct drm_i915_private __rcu *ips_mchdev; -/** +/* * Tells the intel_ips driver that the i915 driver is now loaded, if * IPS got loaded first. * From patchwork Fri Mar 31 09:25:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77675 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp436684vqo; Fri, 31 Mar 2023 02:42:38 -0700 (PDT) X-Google-Smtp-Source: AKy350aBMkr6bv9gfBHMn9GvqHFPn8NIGZnma9GTRxOuRqvZKQqtEZWvvkhNF/NEmqpLsjL1A/T0 X-Received: by 2002:aa7:c2d4:0:b0:502:7d3f:ced1 with SMTP id m20-20020aa7c2d4000000b005027d3fced1mr1488636edp.25.1680255757906; Fri, 31 Mar 2023 02:42:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680255757; cv=none; d=google.com; s=arc-20160816; b=sat1CQbLs0RnXToaairIZqtUXJRWtYfMxeiMk9Qf02IH+S25sZnfHOBsLqyNj43lFw B2VGWqNPJ5YlT5rykUgU6beM5ZTRPhML28bNjaJ55R2FI5rJ39ceVXX9fqQwdjd+6Ulg DAmSwn3KZDPeHHtrbXsHP0wsRkQmZ78bJZ4QENX7mFaNRKTJ99zU/W5cgoO+7Oeqc8jB jMDS0xw59frQ9A5bSGd0Dot7FWTHw9Bqo6WeJst9QHLI1h8Aei/eroq5mx0os75Ys8Rk ipeKyir3GZr8QCdT3BE7S59GvAzORp90yOBsQVCTGmUR4Sbqg8KoDOSHoZKSTgQ/9tGP RWIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=g6ZegWMYwtjlfn2Z0AKNF2CiXV/YVW2OmJZPPk2bHbU=; b=1Kz5gv+I0jmoHFpFX2tRUVIvp6vaa3A0xo+FgiAxt/ywi24+8s9Cm7dfPO0uVKwoA0 sOc37CnG1PptROOorzWRwwwGwLQYMaHUQ2NzUJtuEPTUazUduLqvGGrNGUpnzwMdHstC XAEzOUz3cIUXS93xtOpxZFSkZagX+lrWa6OQNYvl5iKIHwibnRpAkusnsy7vhXAs6z2q nDQNvKc3mZzB4/FwaHw64WcR4LTX3QaLAnA0wkxWK5pGJ4wdj0jqcb4rmLr/FiPx+8bZ cKcqgkuF2t/VWPz0VnlhRaKACko+FNdzWG53FufHc/KuOP3QstChTxBaOINt83naIaHt kpTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=j3gsDsoV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c21-20020aa7c995000000b004c5248cbebfsi1700529edt.101.2023.03.31.02.42.14; Fri, 31 Mar 2023 02:42:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=j3gsDsoV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232080AbjCaJ1F (ORCPT + 99 others); Fri, 31 Mar 2023 05:27:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232089AbjCaJ0s (ORCPT ); Fri, 31 Mar 2023 05:26:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02C5B1E73C for ; Fri, 31 Mar 2023 02:26:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0A2D56265A for ; Fri, 31 Mar 2023 09:26:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 219BBC4339B; Fri, 31 Mar 2023 09:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254792; bh=ta2pbVKeW086ExcAdggWjg7nNpPFLKl54oJMSC9ka1Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j3gsDsoVQRjqVXWT3xex2OuYoYat0CyfY2hZdt9DGVD0jmEecHiZC8mlheKaXzyMK 4J/M6Wb2D0GdWJqYSGnAGzax9sa39rCsWw6XB8PaXvmVDGfcGHNSxE5DnzyLKXI8B3 j4KuBztziW1CycbQiFYbMPSuSKXVX4TqHNr2R/PhrLT5SK/JZgpSvXmX8FMEEyzxqd HgkdDrOoDsnanNom9Qu58oID52zl2K3/BNeoQWP/ogQvgktk2mKgCZHpn/0uDCR4J0 p5SG9phpT0uqF29qnfcNMZAxun/JuUG6uwJFhgKG4XR30IOs6pK1CT/dN4wqM0FJlY /O25w0TrzyFdQ== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Matthew Auld , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 07/19] drm/i915/gem/i915_gem_create: Provide the function names for proper kerneldoc headers Date: Fri, 31 Mar 2023 10:25:55 +0100 Message-Id: <20230331092607.700644-8-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761875862006184647?= X-GMAIL-MSGID: =?utf-8?q?1761875862006184647?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_create.c:147: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/i915/gem/i915_gem_create.c:218: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/i915/gem/i915_gem_create.c:402: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Matthew Auld Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_create.c b/drivers/gpu/drm/i915/gem/i915_gem_create.c index e76c9703680ef..4270575f88908 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_create.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_create.c @@ -144,7 +144,8 @@ __i915_gem_object_create_user_ext(struct drm_i915_private *i915, u64 size, } /** - * Creates a new object using the same path as DRM_I915_GEM_CREATE_EXT + * __i915_gem_object_create_user - Creates a new object using the same path as + * DRM_I915_GEM_CREATE_EXT * @i915: i915 private * @size: size of the buffer, in bytes * @placements: possible placement regions, in priority order @@ -215,7 +216,7 @@ i915_gem_dumb_create(struct drm_file *file, } /** - * Creates a new mm object and returns a handle to it. + * i915_gem_create_ioctl - Creates a new mm object and returns a handle to it. * @dev: drm device pointer * @data: ioctl data blob * @file: drm file pointer @@ -399,7 +400,7 @@ static const i915_user_extension_fn create_extensions[] = { }; /** - * Creates a new mm object and returns a handle to it. + * i915_gem_create_ext_ioct - Creates a new mm object and returns a handle to it. * @dev: drm device pointer * @data: ioctl data blob * @file: drm file pointer From patchwork Fri Mar 31 09:25:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77666 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp431073vqo; Fri, 31 Mar 2023 02:28:59 -0700 (PDT) X-Google-Smtp-Source: AKy350ZXwYGRoqCIev/OZdSO1tXzyF/RUAAheXA48YGQgXqJEG1/jBRZAWu9JqbnKsPEiH3SRmBY X-Received: by 2002:a17:907:2099:b0:8b0:ad0b:7ab8 with SMTP id pv25-20020a170907209900b008b0ad0b7ab8mr26240551ejb.14.1680254939040; Fri, 31 Mar 2023 02:28:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680254939; cv=none; d=google.com; s=arc-20160816; b=Y9duXnTPCVHw+H2EV3or6H6mOFAayDvCi7PdESZAzSofl+iwAmGOX22UtygSqnhFzZ epwqc9Rm2bLyYa2A3CD504xaw1GY3n2kAcjsSqvRWRe2es2VgCMIL4cCzj72aaW3c4xZ 3CVthwrIsgfroc1hwPcpa38XRtovgFrQc0zWINOXKd9rUZ1v1Mrq0Mm8Gq9Xf7c1dtA0 WZKMPaCaX6MJZfwc58uCorhhR5aSXEhPjL+5+ZjkOqt5iUkPAhIMO/O+3tr+LeaSE6JY pKHAhUtDuEyirpayxO68L7HYpd2PyrM33dP/XNhx1y+DZg+sO8PZxnFYr+KWhOhFUnE+ 31+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=haJHcUDdvMTGcNOdcx7QEm2HiMz4o8wvcqDjpD3ANK0=; b=KKKpRdBH3L2RFHWJiZZ3TA8UXpw4FS61LqFO6TsAugUhRcTko6wCZGJKz7C12jHa7f QHZ/p27KvFrJeDZFraN52upZO5ZlavZ5n7QpilPGj9MFEv0T71V27VWJwH0YPm6/PWzv k5Hp7TKUL3BcD3zHvSH4mU8nYs9IZ40gqKdq5iMROIb2nEqvcHoUetBUe7nYN2d6eqiQ B5PXSO4XPmUpwHM2Md5dbjTf4ulnumOiMFYkeHWXKtbyQPSn6MTjBlr8Vdpbxg2w1te3 jwUE0iFgX4tL+iyaJuBIm5vFXYk7UGm2NUorg+mqd32ru4DWspnPEQnab46DxYkufwM5 toaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UWGJNuqr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d11-20020a056402078b00b004fd236f945csi1554942edy.63.2023.03.31.02.28.35; Fri, 31 Mar 2023 02:28:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UWGJNuqr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232132AbjCaJ12 (ORCPT + 99 others); Fri, 31 Mar 2023 05:27:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231874AbjCaJ1C (ORCPT ); Fri, 31 Mar 2023 05:27:02 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 289701BF54 for ; Fri, 31 Mar 2023 02:26:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A6963CE2E04 for ; Fri, 31 Mar 2023 09:26:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E241FC433D2; Fri, 31 Mar 2023 09:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254795; bh=ngC/W6NnsF+/WMMI/twPoOWsX6vUYeGknc0YjZdw5Pw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UWGJNuqrC4qenXiXXTKsAZBAHi0NuRJ93rb+421/6cAQMW52yplSH773ZCxdG2idt jDBm6HevZ7/qjEPw5IwpyvVb8E3u9sCFjWELkjFC+d1Onmbll2P5Hb7druUp/3KHn9 fpGeMEzgq5SCTUsJgxExlLwRhNXlgIzZIXOA1A3nbNXIn0oLcmcB13UIstJV6qBKBv wNnUfMqbYw3zk/ubSDGR6p936NQ+sq67AOV0FS9zljl2KsW62vDtpwAlhzWxu2j42S VWLZRpQo7wBebjtmCLS8OGmaPOcsqHtex+QwzFg1WXQzklUuNGeMLpA42avvJ5e/JG 0SyQVkl+kQ6Wg== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 08/19] drm/i915/gem/i915_gem_domain: Provide function names to complete proper kerneldoc Date: Fri, 31 Mar 2023 10:25:56 +0100 Message-Id: <20230331092607.700644-9-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761875002988661281?= X-GMAIL-MSGID: =?utf-8?q?1761875002988661281?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_domain.c:119: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/i915/gem/i915_gem_domain.c:180: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/i915/gem/i915_gem_domain.c:265: warning: expecting prototype for Changes the cache(). Prototype was for i915_gem_object_set_cache_level() instead drivers/gpu/drm/i915/gem/i915_gem_domain.c:470: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/i915/gem/i915_gem_domain.c:514: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gem/i915_gem_domain.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_domain.c b/drivers/gpu/drm/i915/gem/i915_gem_domain.c index 497de40b8e688..d2d5a24301b25 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_domain.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_domain.c @@ -116,7 +116,8 @@ void i915_gem_object_flush_if_display_locked(struct drm_i915_gem_object *obj) } /** - * Moves a single object to the WC read, and possibly write domain. + * i915_gem_object_set_to_wc_domain - Moves a single object to the WC read, and + * possibly write domain. * @obj: object to act on * @write: ask for write access or read only * @@ -177,7 +178,8 @@ i915_gem_object_set_to_wc_domain(struct drm_i915_gem_object *obj, bool write) } /** - * Moves a single object to the GTT read, and possibly write domain. + * i915_gem_object_set_to_gtt_domain - Moves a single object to the GTT read, + * and possibly write domain. * @obj: object to act on * @write: ask for write access or read only * @@ -246,7 +248,7 @@ i915_gem_object_set_to_gtt_domain(struct drm_i915_gem_object *obj, bool write) } /** - * Changes the cache-level of an object across all VMA. + * i915_gem_object_set_cache_level - Changes the cache-level of an object across all VMA. * @obj: object to act on * @cache_level: new cache level to set for the object * @@ -467,7 +469,8 @@ i915_gem_object_pin_to_display_plane(struct drm_i915_gem_object *obj, } /** - * Moves a single object to the CPU read, and possibly write domain. + * i915_gem_object_set_to_cpu_domain - Moves a single object to the CPU read, + * and possibly write domain. * @obj: object to act on * @write: requesting write or read-only access * @@ -511,7 +514,8 @@ i915_gem_object_set_to_cpu_domain(struct drm_i915_gem_object *obj, bool write) } /** - * Called when user space prepares to use an object with the CPU, either + * i915_gem_set_domain_ioctl - Called when user space prepares to use an + * object with the CPU, either * through the mmap ioctl's mapping or a GTT mapping. * @dev: drm device * @data: ioctl data blob From patchwork Fri Mar 31 09:25:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77686 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp438086vqo; Fri, 31 Mar 2023 02:46:01 -0700 (PDT) X-Google-Smtp-Source: AKy350YmHHk3iferCKugXNfrUKXowQs+I63ObPnVqLtyJi+bJ5b39wrxWGua3SO+mns0d7D9DK7I X-Received: by 2002:a05:6402:349:b0:4c6:10a7:c422 with SMTP id r9-20020a056402034900b004c610a7c422mr27513016edw.18.1680255961583; Fri, 31 Mar 2023 02:46:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680255961; cv=none; d=google.com; s=arc-20160816; b=JaZdqJjmhji1xXIeb5vfqGVThOUHw5M7ppvoz1sJB1VVRlzTZFie9NBnV69DrbuZ/f 6ZKw8K0cbuJcnAc3i5ZZo6Oq9cghXViTjw0FJs0rgOvO0DlWssSnqBZLs9zSFcKzykdC VOF2dJUhN0QBX9wWeAc2rhb85XuF/zH/jWcGYPlOGMwM4RTbpbasRhZMz9t2QijKpVXm 7eWBfiDGCvC3fqqh+r2Tn9sQb/A800C88Gi7NFkQJSEQtQ04l1tU/aV/y9guq9oadTvL D0IRR6LRRs2yzoqZ6fSJZZUCwrUNejQ4wBrp7taTsH7N/E3Bi2xNKgqQgnL/lOckd6wL CHUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eGN+vAn9IuTSSZUZjgG64++Dzv1aQLIQLJHRdS6nZBM=; b=fWc4ROZ0HfW9Ll20Y3/wigicjdCJ+VSeR5YXKcUbWC+OieJdc2/UxSgb57CU2N+yBW +MqyxVbO9VaVrH2tOvBccOs5wk6C6lqUMCy1oBI5gTM33eZVX58LfGnCDbsn4tR8rQTn MVJq6mVvWvHWIjFQYzQO0KEmEY44OUcQADwI/7grBSdvdm+cB7QiZ9UE7VYCR3GgPopl yLyTp2ZyREH3Xv4W/NN5zDGFW4g0RLpAHgz6KMN7xqhoBGdONEiIK0k0N/cxIsKGfHCb YPnCfQs8rY2hFLy1dsZHD+7MmJTrrlXX/8mstGPQyXfl/P48KSWvmmNXbNICkEWtH/Mv 6mQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u2FrI2GD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q21-20020a056402041500b004ff8ffb32eesi892407edv.572.2023.03.31.02.45.38; Fri, 31 Mar 2023 02:46:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u2FrI2GD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232042AbjCaJ1V (ORCPT + 99 others); Fri, 31 Mar 2023 05:27:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232140AbjCaJ1B (ORCPT ); Fri, 31 Mar 2023 05:27:01 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DC861CBAE for ; Fri, 31 Mar 2023 02:26:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 62D8AB82D11 for ; Fri, 31 Mar 2023 09:26:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82150C433A1; Fri, 31 Mar 2023 09:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254798; bh=1cJ849/Y655d3Cb+y4U813eDvHxJLRQhrfBbI04u3JI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u2FrI2GDCbfxdaThBYcHpadx5mw4ANv3v1h3AUQRzdIrV74965dYmT6+82pyQ6JLS 54vJRFPcOfE2iZnLVXDPrBe9Z4ihfJnNlr/z1GbsWRPjJRZ9IYc1BDZrZqSAY5pYNL LKyLcGLPG9QzLnhiCAJCynbmztgaTRxq7ZNvtsJ6A1fyb3KZ8n3c4JkgW4NWaqkwpL Jld92PKIVOgd9tBx+6DZBLNBKLp6DU6THQtFKUPLwUY9d9dYEZbHOi/ZblaEIWNi1q fbg1mRNy17MCU4ttDSFZsM5hfdelZiJrpzH0cAWladERoHHjwKksW1SDnU5r7T4wx0 7+u6H3r92/8Xg== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Matthew Auld , Nirmoy Das , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 09/19] drm/i915/gem/i915_gem_ttm_pm: Provide a couple of missing descriptions for 'flags' and remove some superfluous ones Date: Fri, 31 Mar 2023 10:25:57 +0100 Message-Id: <20230331092607.700644-10-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761876074900043169?= X-GMAIL-MSGID: =?utf-8?q?1761876074900043169?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:156: warning: Function parameter or member 'flags' not described in 'i915_ttm_backup_region' drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:156: warning: Excess function parameter 'allow_gpu' description in 'i915_ttm_backup_region' drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:156: warning: Excess function parameter 'backup_pinned' description in 'i915_ttm_backup_region' drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:223: warning: Function parameter or member 'flags' not described in 'i915_ttm_restore_region' drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:223: warning: Excess function parameter 'allow_gpu' description in 'i915_ttm_restore_region' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Matthew Auld Cc: Nirmoy Das Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c index dfe39c8e74d8a..ad649523d5e0b 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c @@ -144,8 +144,7 @@ void i915_ttm_recover_region(struct intel_memory_region *mr) /** * i915_ttm_backup_region - Back up all objects of a region to smem. * @mr: The memory region - * @allow_gpu: Whether to allow the gpu blitter for this backup. - * @backup_pinned: Backup also pinned objects. + * @flags: TTM backup flags * * Loops over all objects of a region and either evicts them if they are * evictable or backs them up using a backup object if they are pinned. @@ -212,7 +211,7 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply, /** * i915_ttm_restore_region - Restore backed-up objects of a region from smem. * @mr: The memory region - * @allow_gpu: Whether to allow the gpu blitter to recover. + * @flags: TTM backup flags * * Loops over all objects of a region and if they are backed-up, restores * them from smem. From patchwork Fri Mar 31 09:25:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77682 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp437478vqo; Fri, 31 Mar 2023 02:44:41 -0700 (PDT) X-Google-Smtp-Source: AKy350Y85yTbRWIM9plYbVpoLuaBkBROHTYF+SBw2qdUwDkkxIKdDsw7isBI8qYTEfu/XhHWZYnq X-Received: by 2002:a17:906:cf89:b0:87b:d3f3:dcf3 with SMTP id um9-20020a170906cf8900b0087bd3f3dcf3mr26703066ejb.35.1680255881607; Fri, 31 Mar 2023 02:44:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680255881; cv=none; d=google.com; s=arc-20160816; b=t6+BglLkt7RhH4DFwdFuoNml+Izpw6OIroYuXqZWFOH7peIB6ey3eK6C0VEq07emyA tooMRlf5qBYIA6fGI8VieieO5Nn3zJMU+2e2wMc+UJ7+AEd+3TGjT1fKq+mXLOWcfeAF akdHx04ySZzxdRub5id5XX1s2wO6d76C9iRDWpSywkgK8LFNIy0rR0PV5MYHNlnDtyOB ZB9W8DxIysVLWraY6rPoGZrbfot2URfu9zebbQKsGW4NuDKZbx0fM6+jMmjyWGDe0I2E o3mzo7xncMzNHN7q+1lHedOq49qzQ3X0g+X03WqX6N5dEvDCMFAp5qmQrGfLnaIyidCP +8oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ghhbr3dGzG3wREXxMrOIkHUzvLcodj6uTB1ayVIv2ms=; b=HaN+03vWUBc1Cahrj8UVhLZ8ACGu8ILgbdBpg2NqjCdwD4/Pp5Ers8zj9mEHom99EB h1IDzW53IGPpW+9a5GgbtFVuFTc2q4UwyRP4D9/oMuIcNnD/ElWjrpqZQFK639CfFBrN aOe45HgR6W6LHZasHpDz1gnEJY/o623HXxTE99ooTqP3nrIN0wCXR+Bz7cXoXOxMM7jp DzYdfmmJSb/DAf2yXUAOQ/hSKKf72zGY83lRmVrT2jsnp7IMsvwAHtWuFwpKqHPbLGXz CsOK9FbwNJciWzijFdpX/iYPwOGC0HV75KQMAr+Wwo7KhLsM9LUX3jwbgGV6jKQVlpVZ UwGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HMOUvqSF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne21-20020a1709077b9500b00947abb7007asi1290145ejc.914.2023.03.31.02.44.18; Fri, 31 Mar 2023 02:44:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HMOUvqSF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232063AbjCaJ1X (ORCPT + 99 others); Fri, 31 Mar 2023 05:27:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232143AbjCaJ1C (ORCPT ); Fri, 31 Mar 2023 05:27:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C2A21A975; Fri, 31 Mar 2023 02:26:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1FDA36265E; Fri, 31 Mar 2023 09:26:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78591C4339B; Fri, 31 Mar 2023 09:26:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254801; bh=qE4hn7zYZUo3qbgZnQ+ZnfMoG9qxdOCoGyG59h+a2iI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HMOUvqSFkkL8phRrpkrGaaVnaZAeEib8Rpcx16VtW/ll+GjB/7y0qvIF/0Fl9Rbf8 cTlRDGAnWRHRBH4CUYdoEl6e7QHLTHKAHO2spvPQiqKCXKy/FF5hvYFH1m8jzKf8sp 12ZEpJgY5wIo5FggwySBJ55M7yENduSFgEnM//E2b1+/A2WXyhUvRIpDt3puvtM5MF MYU77ZRNuRAGcKUBf8P7HIjKZR5e4EaSYlxb1xboeDJUGyrgzKEpeXJSp8XsY5nmoc fGhN8pUw5KbyJtHmSqJSM2lGUnOzh5u+Iug9o3onO+LQVpMxD43AvO2ilS1Yx948ym W7AHFjMZRaODA== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , Matthew Auld , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 10/19] drm/i915/gem/i915_gem_ttm: Demote half-filled kerneldoc Date: Fri, 31 Mar 2023 10:25:58 +0100 Message-Id: <20230331092607.700644-11-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761875990932342483?= X-GMAIL-MSGID: =?utf-8?q?1761875990932342483?= Hopefully someone knowledgable will follow-up to complete it. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1292: warning: Function parameter or member 'offset' not described in '__i915_gem_ttm_object_init' drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1292: warning: Function parameter or member 'page_size' not described in '__i915_gem_ttm_object_init' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: Matthew Auld Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c index 341b94672abcb..9227f8146a583 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c @@ -1274,7 +1274,7 @@ void i915_ttm_bo_destroy(struct ttm_buffer_object *bo) } } -/** +/* * __i915_gem_ttm_object_init - Initialize a ttm-backed i915 gem object * @mem: The initial memory region for the object. * @obj: The gem object. From patchwork Fri Mar 31 09:25:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77685 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp437757vqo; Fri, 31 Mar 2023 02:45:18 -0700 (PDT) X-Google-Smtp-Source: AKy350Y+Ef8ZKMU/FMp72QVL0eoyNXpjgcgzR/a/p1FUkpY/AtX/2c5943gFBkZbxqlMImf8PDPZ X-Received: by 2002:a17:906:1685:b0:930:660d:8f92 with SMTP id s5-20020a170906168500b00930660d8f92mr27735465ejd.52.1680255917787; Fri, 31 Mar 2023 02:45:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680255917; cv=none; d=google.com; s=arc-20160816; b=yXzHBb0Khmgcf/zekC3ltWfSOZUFSYF/8voGfgpkS1lBcK+wTtxsxM/lRg/9pU02uU nlM1zOJZuYAP6kbZxJBiRNvSpYTc2gNj9IvM6vXdDxoGRzEpakJPh1mjDc4nsEUBh5Xg VPf9mUW63r22CYGudouQQlMzG5Hgxmx5xtKnKiN58XieR3rMiPdyPB4DUg1S6e25JO48 wZCiv43qxToJHEfxf8+RMS28DrZZFfmdMDLQhIx614uhshEAQOObaQMRne0TdYS2ivIe SVFivGgK3k9P0yfoq/fL+Oi62Xt+ceP0RgmszOTSN09EHOJCXBcUBaz3NvJovXd4zu6p vCUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0uAAYtqXt3MnoiCL67C+5fOEBKMGWwDXX6ZR16VNRPg=; b=gXeMh6SmTwE3QM3iSFuGaqlQE9H6sX0LmpEhS1/2N3zAjAiUhb6kELNJ5V4WLavmNe 2M2kgV44RH2gJyPSRJgUhcu8/2k9DAKHK6yZCLi88hv8+MDBDF51atOv3Di6f97Ab57I 0cSyyZ02kczfDqqZXSz2o305zDtPuBaceg/thlwr5OF/MONUVsSS5qNcoJN4pYKMSI/m N/9q/m1vpk+PceYKZdm1XTyJrTwSk41pedq0X2IpcS9OUZYIBVlSI82gPCh1dRYXhg/1 V//3ck3BPIZnNZDAR9WM/qFSJohhYIeMaHQCn+4+iIVfLASxVwSy81it/z7rnx/1DLdE m30w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dzBRFbow; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bo21-20020a170906d05500b0092f3407f862si859417ejb.428.2023.03.31.02.44.54; Fri, 31 Mar 2023 02:45:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dzBRFbow; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232152AbjCaJ1b (ORCPT + 99 others); Fri, 31 Mar 2023 05:27:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231698AbjCaJ1H (ORCPT ); Fri, 31 Mar 2023 05:27:07 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 252061D2FC; Fri, 31 Mar 2023 02:26:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1AAC2B82DB3; Fri, 31 Mar 2023 09:26:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05B61C4339E; Fri, 31 Mar 2023 09:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254804; bh=zuwKMJNqTDoHBJoWH8QH3yXQEHwpZC6+8Slwblrz11M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dzBRFbowGUW/YExXI2jTQQk/JtNvslenNW0Y4g0oY2Dk6yMfna/AhJ0nRE8VSsS+3 PYWM9WyB+QL7TZ/0nfbfiIAHK53Q5l1qd2BolEBM4l6XaL26ixqrOzMRpF1C60ZEC/ umXpAj7gPpWGyMqN/FdC907acxLU3FNGj5QRZySmOGhvw0WUGaQW5sooG6ClxbOsMQ P4lIpdMnyh1AKrCvBhDFrd5vMqY7Z/1NV2GNnAhBYfZlpGGDQMcbiYPGnLOU0OuYmc YMFmUiDYTg8RvB8RkPeGnOoVxFTY8fkrLil7jOF093eJ5BTgmLjYn+P9+CSTeeUulc mKn+attwDlEdA== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 11/19] drm/i915/gem/i915_gem_ttm_move: Provide a couple of missing descriptions for 'num_pages' and 'ctx' Date: Fri, 31 Mar 2023 10:25:59 +0100 Message-Id: <20230331092607.700644-12-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761876029509928273?= X-GMAIL-MSGID: =?utf-8?q?1761876029509928273?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c:272: warning: Function parameter or member 'num_pages' not described in 'i915_ttm_memcpy_arg' drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c:569: warning: Function parameter or member 'ctx' not described in 'i915_ttm_move' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c index d030182ca1764..dd188dfcc423e 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c @@ -253,6 +253,7 @@ static struct dma_fence *i915_ttm_accel_move(struct ttm_buffer_object *bo, * @_src_iter: Storage space for the source kmap iterator. * @dst_iter: Pointer to the destination kmap iterator. * @src_iter: Pointer to the source kmap iterator. + * @num_pages: Number of pages * @clear: Whether to clear instead of copy. * @src_rsgt: Refcounted scatter-gather list of source memory. * @dst_rsgt: Refcounted scatter-gather list of destination memory. @@ -557,6 +558,8 @@ __i915_ttm_move(struct ttm_buffer_object *bo, * i915_ttm_move - The TTM move callback used by i915. * @bo: The buffer object. * @evict: Whether this is an eviction. + * @ctx: Pointer to a struct ttm_operation_ctx indicating how the waits should be + * performed if waiting * @dst_mem: The destination ttm resource. * @hop: If we need multihop, what temporary memory type to move to. * From patchwork Fri Mar 31 09:26:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77689 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp438464vqo; Fri, 31 Mar 2023 02:46:47 -0700 (PDT) X-Google-Smtp-Source: AKy350bPT8Wnsu0G3wKgNRUUgvxlC01GRNgVxtpygr7YVFDMxQUuj+tF8dlw8O/VOxBAJWy7y4nB X-Received: by 2002:a05:6402:20b:b0:4fe:ddf:8d8c with SMTP id t11-20020a056402020b00b004fe0ddf8d8cmr24184562edv.13.1680256007328; Fri, 31 Mar 2023 02:46:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680256007; cv=none; d=google.com; s=arc-20160816; b=Y5sIC8xhHzLcrT5Fb55kpik13/K5ws/WORMTNXFWtMCumY9DwatI98b/slN4O6gZfA HuOVrQKM5NyFiRJt3HtPAE3/wDjnw3w+WFCVBTrIAOo/qwIzx753IjYuyG0TFMQyIki0 em5vQq9E3iqnA5VGB4k1vfM2kwdF6lX02xeJ2WQ67XXE5c9AzB97hYcPrEwSETsNAk5K dZSedS7IjQfOLCAzBp3DkDJcPQhJnFny69I9d59Ek5YVAwSXytcoP20vlAUc/gCoGtiH PIuWODq/ohtBrYxY3gpNAga9khSd0R1I7Ohgm8AH2sCOEVbhhqUd5M7yBbhDHBtAmnMh VzBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=++4Hac3HSH0NPMV0EAvHF+5HieWjGDVGBi6RdiST7bw=; b=cXF1gYf5CxeBDXPgwwUmXgRb0xCbaNK8/Ncv3twa8Ie2ZNhQ1YoLu0BTgnLEhcEDRv S5/Dia0NRAKVsTE4S6BdmajwE3pCX09l9+g3fFywgJSHEIZoe7clRKKy/I5sTG6U22VF V+SqYVe7ELEjnn3mIanzvt8pgX3GiavBa0wwzRGp7QqCvr84UQlXV2sbADpIc+s0NODc 8vrhUY4DNSQnEtaXwGkaL01y5p6ixBqorjyKcyJ6402FkWbUUGuPeprs2CBlrG3sKaog xg2hrtC3Yi9ExVXLjm9JhMSzXibUXLc8695lq7XLE3ToLR0v9HCeqzPVW9P3f0zLMkhr wY0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vDS8Yn2p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q21-20020a056402041500b004ff8ffb32eesi892407edv.572.2023.03.31.02.46.24; Fri, 31 Mar 2023 02:46:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vDS8Yn2p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230400AbjCaJ1k (ORCPT + 99 others); Fri, 31 Mar 2023 05:27:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230240AbjCaJ1P (ORCPT ); Fri, 31 Mar 2023 05:27:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EACC21E70A; Fri, 31 Mar 2023 02:26:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A8A45B82DB4; Fri, 31 Mar 2023 09:26:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56981C433D2; Fri, 31 Mar 2023 09:26:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254808; bh=r5fKy7MNhH7WvIHl7tsH50Rr1NXN1GtPNTehilUeT48=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vDS8Yn2pSVeuQBmaB8f1DwbAVhzhZF9HxT+M3EzlgbyrEoPsPn4xDEpKOO/s9FYu8 b7QndHG5T6MTXL2VI1lL2uvOUiQfx7Vpt/hvVpfXK3XoKnJT2O+kfYj/pbeq/WO2+q ozxEsrOgsxmdxXZjEatn5QXbtkAh9aQxCnZ2PmsbYo8x7Eij9i1brW5omIQZlU+2nC 26lu12CzGPnEY7zfz9xs20xUDXYAhEsOhT66IsbYnsciyZyS57vwOnp37JfreRCNwV /vOoCDLTCO3S8mWs47FhhrH9WbfnzV9Lr/PCvLAiSMk0yxdgltPtn1RNov73Hsv2Rr zl4p1and8/Jjg== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , Chris Wilson , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 12/19] drm/i915/gem/i915_gem_wait: Provide function name to validate the kerneldoc header Date: Fri, 31 Mar 2023 10:26:00 +0100 Message-Id: <20230331092607.700644-13-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761876123423439728?= X-GMAIL-MSGID: =?utf-8?q?1761876123423439728?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_wait.c:164: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: Chris Wilson Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index e6e01c2a74a65..4a33ad2d122bd 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c @@ -161,7 +161,7 @@ i915_gem_object_wait_priority(struct drm_i915_gem_object *obj, } /** - * Waits for rendering to the object to be completed + * i915_gem_object_wait - Waits for rendering to the object to be completed * @obj: i915 gem object * @flags: how to wait (under a lock, for all rendering or just for writes etc) * @timeout: how long to wait From patchwork Fri Mar 31 09:26:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77671 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp436561vqo; Fri, 31 Mar 2023 02:42:19 -0700 (PDT) X-Google-Smtp-Source: AKy350bk0Sf9+UxT11VsvZJXWI4rVb+s92/UtYFfMu1hCSTmKmO6BUOZIjCEaQ1djhH4LiMzZUS0 X-Received: by 2002:a17:907:d047:b0:945:2f54:5eae with SMTP id vb7-20020a170907d04700b009452f545eaemr15638832ejc.77.1680255739095; Fri, 31 Mar 2023 02:42:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680255739; cv=none; d=google.com; s=arc-20160816; b=aWHA8dE+MnfSTPhKmaOPr+PFf0AGd4YMTukW4tsRSM6anZtNbqpAfFjSNq/3Dl4E7K 3xRl5xhUC/k0uUQDrafrwLKN+cTyoIdtReoZ47xXn6AYAfFyhJqchap5vRj0f/EZPaE7 iWuoDkluVIrKVay5mQX/XZZTuYvYCEAt1T9Ao/BNSnX+CF6mqGq1GOlJO7czpsK3MtZk xsE9piSU0szUDM5PwmYXe5ikF4hXtGEvn8y1nUwBW8wGASAEY/hO+CspMQYyDFCRdBbt yx3SLHXbXeloIEzTLkmDNjXtZx0DDjhV8/4sQPZY7+M+SFywlBKuGD9BKPMK4pXxx5ld 2mLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2PDYQppd/GonfhBeByQnabP4PTnyHMR4ouob2IrYDbE=; b=wp1gWUuoB2rCcDkp4++TIYfFJDUGAxLK9inQpbbTxfVqCvN0ZmRkE0OVOpgmFUHiIW u6Le2Gwevdnr41JDycea8jVbAONtzy+oVWnLA68GXh2gOyBPySZIU3PLgZMJ2kjgKtkU DngFtRJXyT7YwRWuOqWn+3VYZG8jhnH1OMFb0iHv6KX7F9lKOi+qRd/YTGKB7RqfEeNZ hdmtm4wlPE2SVcGLxpjHPMwVm7j3YUWIkPjAsuTEoDb0BmpY4yYfjdmQM5BTe83ga6rt ptAPUxbIN3QRII/Vnf8+1rHvipeY0Z5CAt16ieKEMk5GXpvpBvLowsOdHu92cnxX5qng 1d8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SkUG3+i1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v20-20020a1709061dd400b008deaca3a01csi1384970ejh.221.2023.03.31.02.41.55; Fri, 31 Mar 2023 02:42:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SkUG3+i1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232180AbjCaJ2L (ORCPT + 99 others); Fri, 31 Mar 2023 05:28:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230505AbjCaJ1r (ORCPT ); Fri, 31 Mar 2023 05:27:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2AFF1CBAE; Fri, 31 Mar 2023 02:27:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A358762668; Fri, 31 Mar 2023 09:26:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3188C433EF; Fri, 31 Mar 2023 09:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254812; bh=Br+vno0fyLfK0vDswtuXDu7r0uipb+c1SKUt2eq3Kbw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SkUG3+i1jOY+ZEq6u8LzdDURgEfUOlF4Z7UiHPMkVapNIeNGaMOyzsrIzdkCEmx0W 3nA24C0K7BqYIC9ZqtAHfsTRVFi3iTF0HKxSJOEMgVmy7ca6Tiax8sX13sQoOqwyy2 I1zhwSuIKil8isuOeF4SrJDxDZvyXBVUfXSvamyNZyyO1UhbcKgCJlhnvivt1buAKL /zTPC6+rLWaRpQWPLTtxTW+fYTH6o1x4fbuWuE77rKyweF1tf3fx000sHfczmMBI3s KZNAiwpypQvIa5QkLy+df8VMnGfvHHiA1yd96VZwgVvQPTJ0CEVoYgiZKY+KTK4orD xXg0CZqn+Ko/w== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , Matthew Auld , Nirmoy Das , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 13/19] drm/i915/gem/i915_gem_object: Demote non-kerneldoc header with no param descriptions Date: Fri, 31 Mar 2023 10:26:01 +0100 Message-Id: <20230331092607.700644-14-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761875841850278823?= X-GMAIL-MSGID: =?utf-8?q?1761875841850278823?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_object.c:887: warning: Function parameter or member 'obj' not described in 'i915_gem_object_has_unknown_state' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: Matthew Auld Cc: Nirmoy Das Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c index e6d4efde4fc51..4666bb82f312c 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c @@ -875,7 +875,7 @@ int i915_gem_object_wait_moving_fence(struct drm_i915_gem_object *obj, return ret < 0 ? ret : 0; } -/** +/* * i915_gem_object_has_unknown_state - Return true if the object backing pages are * in an unknown_state. This means that userspace must NEVER be allowed to touch * the pages, with either the GPU or CPU. From patchwork Fri Mar 31 09:26:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77688 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp438140vqo; Fri, 31 Mar 2023 02:46:09 -0700 (PDT) X-Google-Smtp-Source: AKy350aMv4GkTPdDAb+tvv/ref13XDPelzEm5ZH2PfwqHeUdkIJWLoHmzjHOAPhcko/mlNTdJEEf X-Received: by 2002:aa7:c554:0:b0:502:2148:298c with SMTP id s20-20020aa7c554000000b005022148298cmr25416698edr.19.1680255969640; Fri, 31 Mar 2023 02:46:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680255969; cv=none; d=google.com; s=arc-20160816; b=MEXUIlnX07W1Hpmj317AzzEjW7S9CRbop3X159PUmB/1U6l0go/5+iIOYysmBVo/2f X9Qafi4enFlMq1Mh91L4uNE4WlEbfSnoSEqxA2B1CdjxcEumZvxlLePtCmOcSxyik6vw L9QeJRJGl975nZkCh6gaVCbu3xKj2Qezkev7lLRGLSdh1fA8KPTIS2OvLvgLE3IUJVnp 3YT5SpP4yrZiyveEaKdzNErWkruFFEWA0tZZg2AtzZhl1QmkYJW1pn4iDI9qgbc+1eDn litHpAkRCS5eUh3hZCCBijFoTh0FwfqqsoSPCNLk4QHoQI9Cb7bV5T+1cszg/+egATG+ zRcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2pdxFI+kF7UBDMSXFTGtx+yzSb/JD9e8owTm5hqCy+0=; b=RuOwUqXH7zOm/oFvBm6NMwpwh5jn+w+rIgZ/P03dJwXZqWAPBRcbMtnyo8WhQEFW04 3KPga4CCq8M1nthSE+ABTNa5pxoN6xHk0wrNRGJkg0yVrVUT6/RiTyhZ6Rd1B/2+5vXp 4KAi83SoPKahlsA8dSiOGWRsXjghh6buaO6MqI9AjxTPp76CiisvdEAiPlcQYCyMQ6IG V69HmCqxsqIoEygAyrELIFqG0ncLcH3ELejJ1dfBGNIaAMm/XzYoLiNf3vqf/ziMhqX8 PcXr913Q7kdtsRL/AGdMswq+C0sfD07nIH/mkigEQmLH0ae/Pb1+YljL603NJKwWiiI2 91rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eOBqcE0m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s11-20020aa7d78b000000b005021f2d55a0si1741919edq.679.2023.03.31.02.45.46; Fri, 31 Mar 2023 02:46:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eOBqcE0m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232016AbjCaJ2I (ORCPT + 99 others); Fri, 31 Mar 2023 05:28:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231905AbjCaJ1r (ORCPT ); Fri, 31 Mar 2023 05:27:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED0B41D2C4 for ; Fri, 31 Mar 2023 02:27:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6B95062656 for ; Fri, 31 Mar 2023 09:26:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84951C4339B; Fri, 31 Mar 2023 09:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254814; bh=8AGKbu3+LbNahQA9+BV8cpQ9XSnkvlPrI5KbjVo54Ak=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eOBqcE0mA4J73g2ftWRNsZm8U23TaA9r3zmLGid83WDxH83+j6lZmu6iTDkz+1Ixp edyH7ctvVVfYJLJWhtOWkFab3tPyj22/KkSY9B3QX6TQWBdtrko2Wh7YbFuAkBGON4 RfAr1UYWHGhDhx7foA032phVxjc5VnLXR7JHaFp8oIJRJPL6h4aDYF2U6+RpID3P9w neQ+BgnjrTjI5jg/DD4POag6DK0uUpvVhLqciOVk3pywVqTr6p6BUJKj9v/iTXtB/9 mv4TcglI+DcH7TxABC97+keY4Q4zc/AU0I7YpXbqjJa8Yc9g5QzerI+QD9LVvburH0 4XVFCk8T3LRLQ== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Eric Anholt , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 14/19] drm/i915/i915_gem: Provide function names to complete the expected kerneldoc format Date: Fri, 31 Mar 2023 10:26:02 +0100 Message-Id: <20230331092607.700644-15-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761876083465966019?= X-GMAIL-MSGID: =?utf-8?q?1761876083465966019?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/i915_gem.c:447: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/i915/i915_gem.c:536: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/i915/i915_gem.c:726: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/i915/i915_gem.c:811: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 35950fa914068..6a00d13db2893 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -444,7 +444,7 @@ i915_gem_gtt_pread(struct drm_i915_gem_object *obj, } /** - * Reads data from the object referenced by handle. + * i915_gem_pread_ioctl - Reads data from the object referenced by handle. * @dev: drm device pointer * @data: ioctl data blob * @file: drm file pointer @@ -533,7 +533,7 @@ ggtt_write(struct io_mapping *mapping, } /** - * This is the fast pwrite path, where we copy the data directly from the + * i915_gem_gtt_pwrite_fast - This is the fast pwrite path, where we copy the data directly from the * user into the GTT, uncached. * @obj: i915 GEM object * @args: pwrite arguments structure @@ -723,7 +723,7 @@ i915_gem_shmem_pwrite(struct drm_i915_gem_object *obj, } /** - * Writes data to the object referenced by handle. + * i915_gem_pwrite_ioctl - Writes data to the object referenced by handle. * @dev: drm device * @data: ioctl data blob * @file: drm file @@ -808,7 +808,7 @@ i915_gem_pwrite_ioctl(struct drm_device *dev, void *data, } /** - * Called when user space has done writes to this buffer + * i915_gem_sw_finish_ioct - Called when user space has done writes to this buffer * @dev: drm device * @data: ioctl data blob * @file: drm file From patchwork Fri Mar 31 09:26:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77702 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp441131vqo; Fri, 31 Mar 2023 02:53:19 -0700 (PDT) X-Google-Smtp-Source: AK7set8utJdX+KMEnpN6/t44M3qhjEuAXDCDGAzKCAuvnHfFQkWXi2f7vv9LFHrfYIl9V4Xm12wo X-Received: by 2002:a05:6a20:c426:b0:d3:9c13:606 with SMTP id en38-20020a056a20c42600b000d39c130606mr22419844pzb.47.1680256399564; Fri, 31 Mar 2023 02:53:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680256399; cv=none; d=google.com; s=arc-20160816; b=GGPSf8TQvFa3kdb4+98aTJTyCtmpZYvICyrNG1FOlNgIicNwyh+r2fjWxEPPfwIWLQ ybGdyCPepEYLAgbeDsZmmYOrx/1uBTGiFEjtUeFYhZooylLeEqLCMO7h/5JwEnjqgF0O NEIS8BWsXdrQaUFPFpbVUs4T6jThEDGqRJ5aCJXKjYDv203yBJFbGctIBOPQ4+I95z5j 9g0SJtwOMgdbs4Pk+5gN7IlTvxe6fJXht/Ed6ApruYHhpjV5nBSTkJiNVst6m9QyvUpZ WEd9GTuPO97L11zKBc+E6o4TdKHc0tLRsK//nE3qcRCoSq++CoApkeL4YrbhBp3Pmrlz qo+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HQO72XhNdUlzjF7HEpKmp0V7lDWYPi9YzAFeWOSJabQ=; b=JArw1j05SKv4fc6Z/55+pYEX6AAIFc/R1D5+OYC5DE1Ul8M+znZmB4MvLuO+Rr2ttn ysX4K3XgWEHrrYVOQNBw7G3GLBuXYk1bvC+u95I5/MY+9WYrFmVdPEaLxd+u50EXTKFB eN/HnAmmOxWAwdlCWiw7aKcz1a/Luz2B32MZ/OneAwy63uNJXQec1kIglD1dTY1VAnPV 5g+T4vmgXTUsopZraNVQ70xlW5LPgsq2pWHjVr3ikDd8iV7k/qqs5X5VBP7gtVx2pUDE k7IdraR+/TcNXJAG3i3UNzyoXPlF2h2T9M1gKwWhXMNE4ArEhlwHyw7z6DHeNjzBeDwH NuOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="g0/zehYx"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h23-20020aa796d7000000b0059b98e82de3si2058813pfq.314.2023.03.31.02.53.07; Fri, 31 Mar 2023 02:53:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="g0/zehYx"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232120AbjCaJ1t (ORCPT + 99 others); Fri, 31 Mar 2023 05:27:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232116AbjCaJ11 (ORCPT ); Fri, 31 Mar 2023 05:27:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17AB51D2CA for ; Fri, 31 Mar 2023 02:26:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 641026265D for ; Fri, 31 Mar 2023 09:26:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F4F3C433AC; Fri, 31 Mar 2023 09:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254817; bh=DLZvhHUJ/JE8d6JXndY4m3tbaZLUBedML7g5WEPqris=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g0/zehYxxV3SbpzaffON9X72YYC2yukFZ647Xi8QonnyadaEdVwQsjKjWg/DRuybW atCIEBbwf0/lwec+xCjnLJQdYPk6aXbDBAW9nypopJNGJi142Wuphh0ddOcQULUJ3V YBdXaKN66zNjzxFoxpIl+m9V3ne4zmLMQYq2PKTQQ73hEcS93bTvVE0mYPsxknGTgl hMcqQCjcCysAZy0IFdBAgroW7Pgh2ZFksOFqcmWYYnzJXdg/HDRWVMWa5tuK8Y+tR+ oVhgUBjDDaKXSxYuJ2ApjKNX8P3Tt/wYCjok16hBujvAZopSorVg5GC0HVkxtcE1o+ s2HG9KGMc+hJg== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , John Harrison , Matt Roper , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 15/19] drm/i915/gt/uc/intel_guc_hwconfig: Demote a few non-conforming kerneldoc headers Date: Fri, 31 Mar 2023 10:26:03 +0100 Message-Id: <20230331092607.700644-16-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761876534405046618?= X-GMAIL-MSGID: =?utf-8?q?1761876534405046618?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:112: warning: Function parameter or member 'gt' not described in 'guc_hwconfig_init' drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:112: warning: expecting prototype for intel_guc_hwconfig_init(). Prototype was for guc_hwconfig_init() instead drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:145: warning: Function parameter or member 'gt' not described in 'intel_gt_init_hwconfig' drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:158: warning: Function parameter or member 'gt' not described in 'intel_gt_fini_hwconfig' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: John Harrison Cc: Matt Roper Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c index 4781fccc2687d..852bea0208ce4 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c @@ -102,7 +102,7 @@ static bool has_table(struct drm_i915_private *i915) return false; } -/** +/* * intel_guc_hwconfig_init - Initialize the HWConfig * * Retrieve the HWConfig table from the GuC and save it locally. @@ -136,7 +136,7 @@ static int guc_hwconfig_init(struct intel_gt *gt) return 0; } -/** +/* * intel_gt_init_hwconfig - Initialize the HWConfig if available * * Retrieve the HWConfig table if available on the current platform. @@ -149,7 +149,7 @@ int intel_gt_init_hwconfig(struct intel_gt *gt) return guc_hwconfig_init(gt); } -/** +/* * intel_gt_fini_hwconfig - Finalize the HWConfig * * Free up the memory allocation holding the table. From patchwork Fri Mar 31 09:26:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77674 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp436635vqo; Fri, 31 Mar 2023 02:42:31 -0700 (PDT) X-Google-Smtp-Source: AKy350b3DDQE6ek/3rqN3GkaQAGSUBVQchNxmlj9yiSdZbyF7QP2S/c55ezfYONVaQSbFQi8rsTu X-Received: by 2002:a05:6402:20d:b0:4fa:c17d:8fdd with SMTP id t13-20020a056402020d00b004fac17d8fddmr23220342edv.34.1680255750923; Fri, 31 Mar 2023 02:42:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680255750; cv=none; d=google.com; s=arc-20160816; b=FVd2/Cl6oJOz7lGO1//4m2OJIBSurmc/VkNSU3AkbKISbiFhjiS0GWO4BaNL3iaukN CV01z9pn7PKS9aUQRUac+D8HdqvEfdMD+H6XdymgU4HlYumBQH1LCkoudhCka8Fs9e+6 rHT/niGO7OT1YgI/DSGVVIGFob6aBylwJE0GQk0DLLibn8t7ChXaUNdarJtVN0UteH82 B2ZJAvk791dC/78UnqAOquw+y6wgZBj4rCHPmF0paw4urXwhxLpvrL/2thaL0YgSm4fK bU8sJjCmKu8PgCoePavWDcB+sghQDHLtWYfKCzuvuorz2OTzu1wOSH69pPuArR0Oeh2B Qk4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ukOLMCbQoTlXICNK3mRwoumJkZpRMgxYB74W1hUl2aE=; b=LgS5JhiuTHNgvIXdFT+nGB1dAdN9OWWmVpEtoe4sQgqeT5+rCHOb0NThLYAJ2FeOlo 5mdVJm8xeX9TgyLC6ScUdWFpHwD8jWsBVUGfk0z4Uecxz5NwOiuL8TqkXS4AAqkWGZbu uBkyhQDJ/6t7l2JSu9WcN5nSpOYo6q3G6SI6buboLW7hVOKUlVDtkif4LW+h9aBiBDUD giYC6cx7W6TNiVMYCuW9DL4OEioFIE3YamlLuS3oHPFi7Jl1KQUlBm0ZukwWikHxUcav rZyd1SdVB7vbhBPfJKur44KCeEZXk4YnRS7WDHEsOE/fzvZ5P5pAjJnXyNv06huXfVlR IuTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GXZqS0n3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e15-20020a50ec8f000000b00500748a37b9si192131edr.249.2023.03.31.02.42.07; Fri, 31 Mar 2023 02:42:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GXZqS0n3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232187AbjCaJ1x (ORCPT + 99 others); Fri, 31 Mar 2023 05:27:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232137AbjCaJ13 (ORCPT ); Fri, 31 Mar 2023 05:27:29 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0D611EFE0; Fri, 31 Mar 2023 02:27:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5D1EAB82DAF; Fri, 31 Mar 2023 09:27:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49991C433D2; Fri, 31 Mar 2023 09:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254821; bh=jDg9+LbHBtf4EjDGettNNrjuuWGpis85RdG5aiSWD5I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GXZqS0n3DzEGbnhm/VuFgz81qhHhbB8LYxa+QNGAK8aCAKZfMDsCONopQkz8C59WJ g+wiN/k7a9am8lJiu10gLlcLLq0pkMCDKLjQUF9kQV0/UzS6ZgKXtvMjql8GREQSDj JLo/9iiWbrsgQvqctkGbq4tBXdPctKCLSWoKS7w3/uO3PUHxqYSQvycxPNZIa4dQhe ETiYPunbpUdXC1m0XmEaMVB4f1zGu8ws65dTCpINbY9ntnfw+Kmw5iIWHAZGE0U+Rh /HgCOd+PyR8UBGJPb2K5PUtZV95W4tDsGUbWREGq14UCvHYGepF2JwZpMrlSLkVwu6 P1tN1uJeoFwmA== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 16/19] drm/i915/i915_vma: Provide one missing param and demote another non-kerneldoc header Date: Fri, 31 Mar 2023 10:26:04 +0100 Message-Id: <20230331092607.700644-17-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761875854476490924?= X-GMAIL-MSGID: =?utf-8?q?1761875854476490924?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/i915_vma.c:756: warning: Function parameter or member 'ww' not described in 'i915_vma_insert' drivers/gpu/drm/i915/i915_vma.c:1744: warning: Function parameter or member 'vma' not described in 'i915_vma_destroy_locked' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/i915_vma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c index f51fd9fd4c89c..20a44788999e5 100644 --- a/drivers/gpu/drm/i915/i915_vma.c +++ b/drivers/gpu/drm/i915/i915_vma.c @@ -739,6 +739,7 @@ bool i915_gem_valid_gtt_space(struct i915_vma *vma, unsigned long color) /** * i915_vma_insert - finds a slot for the vma in its address space * @vma: the vma + * @ww: An optional struct i915_gem_ww_ctx * @size: requested size in bytes (can be larger than the VMA) * @alignment: required alignment * @flags: mask of PIN_* flags to use @@ -1714,7 +1715,7 @@ static void release_references(struct i915_vma *vma, struct intel_gt *gt, i915_vma_free(vma); } -/** +/* * i915_vma_destroy_locked - Remove all weak reference to the vma and put * the initial reference. * From patchwork Fri Mar 31 09:26:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77673 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp436608vqo; Fri, 31 Mar 2023 02:42:27 -0700 (PDT) X-Google-Smtp-Source: AKy350Ye9o6ZaguS8v5WCsXkzlWy80hbC/KIq2u+u6UdvYqQ/APXZq57JZQGX2qfFSLgQvkDApqi X-Received: by 2002:a17:906:5fd9:b0:930:d17b:959b with SMTP id k25-20020a1709065fd900b00930d17b959bmr28458307ejv.22.1680255747358; Fri, 31 Mar 2023 02:42:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680255747; cv=none; d=google.com; s=arc-20160816; b=eBPK3Pl71ZPyjobj5guNO0+n6saX7sPUiVtnZklyRvyIeQiRvLlboawBeAlPh5ohLV 9ZnyfdfMtIamU/bRsNANl7oQVxiDTL8hCL77qOBUs2oy1kKYd8DcPOE/7Ecx6g0jiFgF zM9nsPqkwnqUy2EZ5Q3Mz/6bzG38gfxxf9lm71HEqXSMoMHf11ehOKMwcu4jeCP4hZg+ CnwHKqixZRY9gPY6A8ZTHLMa68/EpQ0B9j3utsbStsPm5xx9Vswielct5aZWaWY1ALDI lgbGCrIcw6nC9ApiE61qgSBg9BH7hMyuZFUMbdv87lYz9VQihpRKlxZaNVVOoCMw+m7S 5RUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TkuxjwNbn/reo3hf9x6R/oEIhfGKGMc0GVA6o7e6zOM=; b=QJBsZhSXWTJRTRgHWwciXVuUWLBFsXBCPzcbcPzeBHJqMWB0GDlLK6e3IYPpDlgeJk 2HFQyHF4nCW7sMb0dRhwIhVkYC/dESg6143pA7J37CH/HNIh4MJtNCHMWBEYdDqhZWG3 DKruoJFaFA86FU1zMNr8JD0sga+JUurJFdt1nW/XDeovAVTV77hgyZhQJkTRx5BInecP WJAQomKcQNkQ210AIJCIUZc5/dYhfx8BDjyB1pd4CfyxGt+bPMivs+wWyUCGsIMGuCx7 hr1q0vzjOFU2GDefR8NYrSLLOLzsQ6WuwRllPq0M2Ae7sTWXuZfqDujlkYQEhsjgOcDI 2Q8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gCzBoIum; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gq25-20020a170906e25900b0093b053a6655si1695085ejb.34.2023.03.31.02.42.04; Fri, 31 Mar 2023 02:42:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gCzBoIum; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232107AbjCaJ14 (ORCPT + 99 others); Fri, 31 Mar 2023 05:27:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232145AbjCaJ1a (ORCPT ); Fri, 31 Mar 2023 05:27:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 040621EFC3 for ; Fri, 31 Mar 2023 02:27:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3219BB82DBA for ; Fri, 31 Mar 2023 09:27:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D8DDC4339C; Fri, 31 Mar 2023 09:27:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254823; bh=XRTu35ZdFafbPJyWFWpW6/BJvUu4jTdjrS1uNGlsFd4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gCzBoIumvl2CYBRlyFq0DAw31z7YCmbHwo/1nXRhYpAR9r3721pGR3X8lSHIVlT+Q PlW/pCxm58t52C9YDeusnUX4HToQQJ7kJvpEBw32CSFfZWkNSXRj8rwzYYasASxQm1 4BO2ZiwuRCUQokL+TPMUkXBR9s8K2NNZkGN61QKRxkR1niK09Q1ZF2BJTieRwQ7JMW EpJxnksA6/iaXiIoszEovLASYgnySjbS0tITJamYXbWno99Ikdhx1qK86kbpgtY/Rs YsJW6eZoxFn0o5KXVXXi9U5ESc4Z3jFz9wxWwuj1tRs+GQql8DXFNW0t4XtWVVH5Bl Mz+bXgqZB9tHA== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Imre Deak , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 17/19] drm/i915/display/intel_display_power: Fix incorrectly documented function __intel_display_power_put_async() Date: Fri, 31 Mar 2023 10:26:05 +0100 Message-Id: <20230331092607.700644-18-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761875850391526415?= X-GMAIL-MSGID: =?utf-8?q?1761875850391526415?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/display/intel_display_power.c:712: warning: expecting prototype for intel_display_power_put_async(). Prototype was for __intel_display_power_put_async() instead Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Imre Deak Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c index f86060195987c..7d1e492b6bfb5 100644 --- a/drivers/gpu/drm/i915/display/intel_display_power.c +++ b/drivers/gpu/drm/i915/display/intel_display_power.c @@ -697,7 +697,7 @@ intel_display_power_put_async_work(struct work_struct *work) } /** - * intel_display_power_put_async - release a power domain reference asynchronously + * __intel_display_power_put_async - release a power domain reference asynchronously * @i915: i915 device instance * @domain: power domain to reference * @wakeref: wakeref acquired for the reference that is being released From patchwork Fri Mar 31 09:26:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77698 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp440310vqo; Fri, 31 Mar 2023 02:51:19 -0700 (PDT) X-Google-Smtp-Source: AKy350bXeTc+w+MPq4riT8KzfnDuRdDRJ80AzE4wXq4re87hQiBwvNsd4oVwInD/iaJ7titg9QLk X-Received: by 2002:a17:907:6d24:b0:93e:9362:75fa with SMTP id sa36-20020a1709076d2400b0093e936275famr31056654ejc.47.1680256279119; Fri, 31 Mar 2023 02:51:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680256279; cv=none; d=google.com; s=arc-20160816; b=UQwCsQoERXTZ7kEjQxcosh9pZd7RRG0FrceN2nU3KJ2JtRGYGKtwj68ZFp4v9ljqo6 cZjTRK+7Lan989SRYiJgE5ASnBrOi0XVSVcSUCWPgkQlpBo9SSOuP1XqKc0ylCKKDfox hcPtz1TecDhCgrdviqFrIsGkuLfEeybdIEqgSCxpgMVFiydmfL+52gvybjLHxa5c1/M7 DVLaa215cZGFxykC9okQ91ZrdLts1FHdI5qWtRi/IWL4o16IKKY4/3YEiLnA4epLUjJE IQJqnO85V1xQjD2ZKJtxI2baDknTO8sKQRpoyCBaZRdh9ecSVg5LokcEz2l6cMJ9+45v u/HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MyAWqjjNWnKBRf/7WmYyp1275R7HFMAJzxJnHDV4zZM=; b=pzdhVAw68mQF2gHE5cxW4nEBlnkU0X7R+7ZK8xNhmL/kAdf18BSzJC/DKDqctALF5f rNzU/MwTF4f9/ciD2Aab9N1UPLU6ECXOkJIXpnbc7/SzM+pxFmxfIUu1wPGQUvVN4gDD eQVOi4jB5stLMEvnnAbKj0RHDMbE0/g6Lz4CRGUiDFL7ZFOahub6CZBCRNkBNzhPfbX0 +XbdpSqA4mU6Vz60OCc0pSukxM713aQ20G5nU/mgqWaA+kLPFOAI5JlaEuiV8ZYsoSLE 0ZsO9EYIdOFPkqdJbLPEQHJcardLTVgPU5DnpnGfS4aOBm3JLgyVYM+nB3msipUB80aQ psvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dsTJ8rRV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g23-20020a17090670d700b009227ddac2b7si1504906ejk.434.2023.03.31.02.50.56; Fri, 31 Mar 2023 02:51:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dsTJ8rRV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231905AbjCaJ22 (ORCPT + 99 others); Fri, 31 Mar 2023 05:28:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232207AbjCaJ2I (ORCPT ); Fri, 31 Mar 2023 05:28:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D7F220331; Fri, 31 Mar 2023 02:27:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AEA6562660; Fri, 31 Mar 2023 09:27:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68DD6C433D2; Fri, 31 Mar 2023 09:27:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254827; bh=h8C/nCvQ95GrVt3vhY71TCmgTeCG4/uxqnWpxM7dCvc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dsTJ8rRVglkyMZumINEy8WnEYodYuNEhZ7bk1k65j6hRSt6A+H6HSIvwtd10Q7Pew mDw2gtHjx/Wcbcjzbkz+E4al5QovbvJmBTGuowMkfOeT3uswymaaryDuad3rt3skik 5V5Bbv3qYCq7vivephtUFBGWG86wnCgaWebo/0f/p2rqGeM9esEDofWzKN7G+RpviI uGVW/qs5y+ADztJb7OtXuw83KGVnks7D3LZENOEVzA8BLUVYaq3VNB0jjOaOb5xHKz KUcG4WeYIOei20QDLzRmfFPg48kD4AHMaklv91+4SWntbuAwafm2Tk9Hkn2rRjV4B2 yMfi7F7+H4KBw== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Sumit Semwal , Stanley Yang , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 18/19] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers Date: Fri, 31 Mar 2023 10:26:06 +0100 Message-Id: <20230331092607.700644-19-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761876408171180300?= X-GMAIL-MSGID: =?utf-8?q?1761876408171180300?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'job' not described in 'sdma_v6_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'flags' not described in 'sdma_v6_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:945: warning: Function parameter or member 'timeout' not described in 'sdma_v6_0_ring_test_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1124: warning: Function parameter or member 'ring' not described in 'sdma_v6_0_ring_pad_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'vmid' not described in 'sdma_v6_0_ring_emit_vm_flush' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'pd_addr' not described in 'sdma_v6_0_ring_emit_vm_flush' Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: Stanley Yang Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c index 40e6b22daa226..efea4ef30a787 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c @@ -233,7 +233,7 @@ static void sdma_v6_0_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count) amdgpu_ring_write(ring, ring->funcs->nop); } -/** +/* * sdma_v6_0_ring_emit_ib - Schedule an IB on the DMA engine * * @ring: amdgpu ring pointer @@ -933,7 +933,7 @@ static int sdma_v6_0_ring_test_ring(struct amdgpu_ring *ring) return r; } -/** +/* * sdma_v6_0_ring_test_ib - test an IB on the DMA engine * * @ring: amdgpu_ring structure holding ring information @@ -1114,7 +1114,7 @@ static void sdma_v6_0_vm_set_pte_pde(struct amdgpu_ib *ib, ib->ptr[ib->length_dw++] = count - 1; /* number of entries */ } -/** +/* * sdma_v6_0_ring_pad_ib - pad the IB * @ib: indirect buffer to fill with padding * @@ -1162,7 +1162,7 @@ static void sdma_v6_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring) SDMA_PKT_POLL_REGMEM_DW5_INTERVAL(4)); /* retry count, poll interval */ } -/** +/* * sdma_v6_0_ring_emit_vm_flush - vm flush using sDMA * * @ring: amdgpu_ring pointer From patchwork Fri Mar 31 09:26:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 77667 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp431522vqo; Fri, 31 Mar 2023 02:30:10 -0700 (PDT) X-Google-Smtp-Source: AKy350bGhlF9klF/7LYe775opHe8L++CTJV1NJ8cDev4pfQsrptuILpMJlEILpFsyyK1eYmi29SR X-Received: by 2002:a17:907:1c1e:b0:939:e928:5323 with SMTP id nc30-20020a1709071c1e00b00939e9285323mr34993244ejc.54.1680255010149; Fri, 31 Mar 2023 02:30:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680255010; cv=none; d=google.com; s=arc-20160816; b=UGkj69y86M/wkED4cIooVZgXo7jMHi8EMm0eRHihQ93TUqsI3CHfjOn/BGFjJ0hosc 7ko8ScBJ7eU/BBeZhifiVHMWXmVXEHlJ25RkJ6xl5dTtstZGm9r5YCLoVTmaLWFtSWf4 iK5YkKEYObBIbelmYC+3CYgA1t8k2hxp7gN18cNIJL4H0mgiD1JdvLINgVhWc7skv+vf gLHKuYqJ+GuP5UIsxgJQdVWVlGIPoCkoKQ7j6VgtwHPAKzTgrDwnx50FoKaVC3KfLVwK 6uVQ+PxDAeO2D4x59h+o/tQKCGWJ12V5WWXIW1MTfolTWUQU7p/FlRoCZX3nOmpBEXC0 YSVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eSGYLCV7kVQGx4q8gOIUJdmwAW4dzS6pdp1PJPzistA=; b=QgSlv7eOSKufZZGvo4oy7bak6ajUw1z9jdPZXxBslsid7MsL3H9JH1SrGiu3fM/g3v uAf2801u89Nf9nFZhbpcag8xwz/bg2MKJMazplcRAT/5AQeciz6VGy6b9b5kahJACW6P LqnVy+Y4G1AQ1RVMBShHSho8peJQ7ZQIqYQNy4qgpfSt1cum742SL/sWkgcedRWTkdj6 hSraEWGWYhZ+xWas8yVrJy4HvXj9Yia35g784MLIifbA8H+nim9E9OLboTuQ6TsBeOU1 65WPtc6Fg213YW3xVoZ/m6LiXiVXlNgRD8AcWDAMlPalplhImoyZV/K43CSN2TVlnp72 HcAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WWWE2lUs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hf11-20020a1709072c4b00b0092bfbe8e4adsi1666631ejc.238.2023.03.31.02.29.45; Fri, 31 Mar 2023 02:30:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WWWE2lUs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232214AbjCaJ2h (ORCPT + 99 others); Fri, 31 Mar 2023 05:28:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231698AbjCaJ2T (ORCPT ); Fri, 31 Mar 2023 05:28:19 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D34B146BF for ; Fri, 31 Mar 2023 02:27:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 99F56CE2E04 for ; Fri, 31 Mar 2023 09:27:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9099DC433A0; Fri, 31 Mar 2023 09:27:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254829; bh=q94izLl3IZgGvkKrUY20PN7lYkSiE2LwGs8Cj3mJZ74=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WWWE2lUsVb8TTMqOUSSf9JvM1P043iDZAbpWP4lDy9c2SbmizGgxIatWILrD2r+Jw VRlIVW9z3L3Jf9R//bIt92G80do478ZWtZ4Z2wdqmQq0+EAemK7uAoGpNJuk4C9CwK q51jc8bJ/aKQYT507TmrORLBmMTKKIA85L8VK2Gs8rD+E0VC55h11lEzGIO26XlwBT UOA2ybn4v6hx6dZ1QgP9KGQAJPQ9WbGHx0TCrO8p3KM1aX7XY+G4jn8VZPFhA4sRhV 8dDEBXpDaGVDQnk+yaOaRc2NxClQWpYz85+UeOLcI/c2vxnWK8uq/JISgeRbP6DKIt 1TDOlovDJ9CmA== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 19/19] drm/i915/display/intel_wm: Fix a little doc-rot in intel_update_watermarks() Date: Fri, 31 Mar 2023 10:26:07 +0100 Message-Id: <20230331092607.700644-20-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761875077203443356?= X-GMAIL-MSGID: =?utf-8?q?1761875077203443356?= Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/display/intel_wm.c:46: warning: Function parameter or member 'i915' not described in 'intel_update_watermarks' drivers/gpu/drm/i915/display/intel_wm.c:46: warning: Excess function parameter 'dev_priv' description in 'intel_update_watermarks' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: "Ville Syrjälä" Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/display/intel_wm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_wm.c b/drivers/gpu/drm/i915/display/intel_wm.c index bb99179cd5fd1..b615449e70b47 100644 --- a/drivers/gpu/drm/i915/display/intel_wm.c +++ b/drivers/gpu/drm/i915/display/intel_wm.c @@ -11,7 +11,7 @@ /** * intel_update_watermarks - update FIFO watermark values based on current modes - * @dev_priv: i915 device + * @i915: i915 device * * Calculate watermark values for the various WM regs based on current mode * and plane configuration.