From patchwork Fri Mar 31 07:55:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 77614 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp404994vqo; Fri, 31 Mar 2023 01:27:45 -0700 (PDT) X-Google-Smtp-Source: AKy350Z4m5aTOn+lYlsf8jnjtVv2CgrQ8O/IwYmSDlTpgm6s170zHY7gEwhDpOAa6gTCp07yRu+U X-Received: by 2002:a17:90b:1d11:b0:23d:1bf6:5c74 with SMTP id on17-20020a17090b1d1100b0023d1bf65c74mr28922441pjb.41.1680251265618; Fri, 31 Mar 2023 01:27:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680251265; cv=none; d=google.com; s=arc-20160816; b=GImdy6CxiYa2eOtPYVayoLbprDbQpW//9QNoQcnIgHD5o6BD0foc2Rf6P0zPmyyWuc VJ0MgF1mbrnnl6cqX8RGHsFbw+zJdIiKCdW0NMcvcAcAg/3N+lglimoMHLD5da88/Zk/ WvuwU2XTjGhtZ01xEf1ciBUQppLTN4Jygcnl2tWBheiMYqtA5foiPq1xyuMwKfVIe1ol A+6OkqPYOoR4C2vCIas0kbz4//knAxykY6qB4jRLuH+Ij6dYI2vIcKPNb82Oz++6Kh3Y li/4IIZLwOdPtfGNLsO/9LJxS/JnzIOj3w9N3OH9eAKGYNsp3usw5v7c7cDpLFyeqnDB XbcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=W3Ek26nrzl3UKrimrfr8cAR4ovM1N7qm9ikaPoF0+U0=; b=Ev75AM05+0yQqysAj1Blnnc51rifvO67RvwydsrM/b74Il4QPPYiV/rvg4H3CbRicn Vma9uZqK0+Qn3BewTHesEP0NFyOrPpAQAWf688WemdV8ShtGSVu3p3tkpqQVlvzhMGYF WAR0kwdYoVUP7HKdoB6cyZNrz0XRKvS4MmAvdNzArri8nDtQdcr/msWa3sSLQ/YnHw8k MyAFDPITrq5Vml0eZR21RO8w1wxvLDTdm0m2QQ95Cr2wOhU01b+KhVfytX6zpU6rPYs+ a3dtS9RN5EYvEJ3MD78Qr1stoOLzIYruBXY2Rqh2bi72HvFRlW1XKoJN3rmqZ60OVEW+ cgeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=d8pzU7fa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gc24-20020a17090b311800b0023f064f20c7si1434323pjb.168.2023.03.31.01.27.33; Fri, 31 Mar 2023 01:27:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=d8pzU7fa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230375AbjCaHzz (ORCPT + 99 others); Fri, 31 Mar 2023 03:55:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230355AbjCaHzi (ORCPT ); Fri, 31 Mar 2023 03:55:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9E0F210D; Fri, 31 Mar 2023 00:55:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4F347B82C86; Fri, 31 Mar 2023 07:55:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48275C433EF; Fri, 31 Mar 2023 07:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680249335; bh=56tCHTmfZ4Dl+rN8BVNsQISShX6kyMqKc5AH+7Uj+7g=; h=From:To:Cc:Subject:Date:From; b=d8pzU7fa4a0MPZNqdYvhn1SagoTH0CwCH7N8LJtri3bFQikdL7Vvu9xx2rrXkUE8K vU0x4c3bYnhwVYAYv83Mof1cNZnA06zAQDz5Em2fw6YWEX/nrWWIDgdRNUNEsWoLsV 9vZWuM0OQf8J7YOEk76ygBfPhdg28jf1uIVMWKrWqLDGLw6dGf8e/dQfU1g4MxVoyI 3vqWXTp9oOXcCnf36dprPxkCSO/EnKpfgxqdbns6EDqx1ix2qubNpUI/IxnDmhh2S9 NejpCa24KedXER0ZZ8uKhdwK7kV00+Tqa3MKAUzhdxqs4jri4QTBBNG2bqMJPHRBQq PPDj4R1NemEDg== From: Arnd Bergmann To: Bjorn Helgaas , Saeed Mahameed Cc: Arnd Bergmann , Thomas Gleixner , Dan Williams , Marc Zyngier , Kevin Tian , Ira Weiny , Shay Drory , Jacob Keller , Eli Cohen , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] PCI/MSI: provide dummy pci_msix_can_alloc_dyn() helper Date: Fri, 31 Mar 2023 09:55:04 +0200 Message-Id: <20230331075528.1300270-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761871151474322533?= X-GMAIL-MSGID: =?utf-8?q?1761871151474322533?= From: Arnd Bergmann A change in mlx5 caused a build failure when PCI_MSI is disabled: drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c: In function 'irq_release': drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c:148:31: error: implicit declaration of function 'pci_msix_can_alloc_dyn' [-Werror=implicit-function-declaration] 148 | if (irq->map.index && pci_msix_can_alloc_dyn(pool->dev->pdev)) | ^~~~~~~~~~~~~~~~~~~~~~ All the related functions already have a dummy version that does nothing in this configuration, but pci_msix_can_alloc_dyn() does not, so add one. Fixes: fb0a6a268dcd ("net/mlx5: Provide external API for allocating vectors") Fixes: 34026364df8e ("PCI/MSI: Provide post-enable dynamic allocation interfaces for MSI-X") Signed-off-by: Arnd Bergmann --- include/linux/pci.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/linux/pci.h b/include/linux/pci.h index b50e5c79f7e3..f69f7939331e 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1624,6 +1624,11 @@ pci_alloc_irq_vectors(struct pci_dev *dev, unsigned int min_vecs, flags, NULL); } +static inline bool pci_msix_can_alloc_dyn(struct pci_dev *dev) +{ + return false; +} + static inline struct msi_map pci_msix_alloc_irq_at(struct pci_dev *dev, unsigned int index, const struct irq_affinity_desc *affdesc) {