From patchwork Fri Mar 31 07:19:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wenyao Hai X-Patchwork-Id: 77578 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp379635vqo; Fri, 31 Mar 2023 00:26:28 -0700 (PDT) X-Google-Smtp-Source: AKy350b5zEKwDSGw1uGX3qlbVIAQyVXtS8DRYjSyAcGQbfi0ca904d+RLPsWM/08NEdRHKSeP0bt X-Received: by 2002:a05:6402:8d6:b0:502:2953:8ecb with SMTP id d22-20020a05640208d600b0050229538ecbmr21635330edz.13.1680247587885; Fri, 31 Mar 2023 00:26:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680247587; cv=none; d=google.com; s=arc-20160816; b=MkuSpb17M2buPXmI2M659ViKgJQi0SRkGbb281/ZvWaZMrWLCydmFjFPkHsw5eVgFD HPB60tIC+U046qBo+FsJfEy8ufvMs2MhP8vNAi2FeYfEGxGEkJzKALWJ6AppwzjUemto pM85Qxer7w8dxcU/6DosgDypwPpOV/elhwraZQWEXqzi3SiC/IS0cM3+4xKCOd6IfKyf GP74W4QvAUP7pz/ER6943kmkiChusMhQqV3r3spb/q1yF1O2AAPHghmx0CrPQg+/Lrer iyUHOoeLY5+UlatuWG4LQWBO+M8etaOPHuShXvJE0sXxRenCY8m5cdvLs3rA3lvS8H4c 3REw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from; bh=UfuEfvJ8w77z5aVXo59LcjCMwgjqLbkUgCsCVP1pcdk=; b=rRKS8wq+/Im19o0WCYU+Mfu3g4IKJGymqopzYZWsetyCzkvBXDQJndzgZGDFcFVwEa IZDtR6aOMUhyyGjNF8WhJWkIf6sNQHbIz8zDbtv1lH1/MMEDJK17wJmF6CymoFtCjFZa aI9tXn3SmYqeRbhVNiPE8RhumpnGv9zgFnFznamzY4fzGmXeXJ34lTO5TxBSBo1PnF7G M+527xEYpwB1DT48cmnf4o7/HBYiZslJd4meptL+5On4JzVo0/3ZPugvf4SDx+rSkcdC KDqmc3tjQZAf8vJD8dB2UVPbZVeA0NWmtJA5orPaJESudRYgQaYSr8UK4z7gy0bbrb0b b2MA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f8-20020a056402004800b004ab162a8415si1491508edu.283.2023.03.31.00.26.02; Fri, 31 Mar 2023 00:26:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231165AbjCaHWF (ORCPT + 99 others); Fri, 31 Mar 2023 03:22:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231150AbjCaHVo (ORCPT ); Fri, 31 Mar 2023 03:21:44 -0400 Received: from smtpbguseast3.qq.com (smtpbguseast3.qq.com [54.243.244.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43FD2B452; Fri, 31 Mar 2023 00:21:20 -0700 (PDT) X-QQ-mid: bizesmtp74t1680247178tcdee271 Received: from localhost.localdomain ( [1.202.39.170]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 31 Mar 2023 15:19:31 +0800 (CST) X-QQ-SSF: 0140000000200060B000B00A0000000 X-QQ-FEAT: D2GZf6M6C/jlCu3/AMN9d6oIe3zyaLioIiwPBB090rgmjvvB9Jy286/N5MFQe zbL7NB2hgZ51D4JDk446U0fIXM+dEg4ctDOgRo8CYp7Hap+ukhbvXZ5ZgWL0NBcqgJYTslN E7VgkwZqjct44CWnE9iyGtpIezkHAU9uUCztfVRbCnHzt4D8CU1M/FiazL8I6647zNa1gEB fF0H2Ns8fsHCfSL1LfsiZMUdjmTdcRrDMRQSg23+7zTVY7cZA1RgljuUwZvvDzZ7zbvBNxT i/AeNmLLOfXtrWEMZ1LGSDvlyvNgpNuU+Hmt/nKI96cx/9my9UoLQmyDbeYVf7bARvAMc6i 22WdvbOAdvW8nz2daYxUSPrzAXKj9lFdJV5flg+6gaPYH06fsVdr0DzTnOg4g== X-QQ-GoodBg: 2 X-BIZMAIL-ID: 10139367410288235300 From: Wenyao Hai To: seanjc@google.com, pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Cc: x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Wenyao Hai Subject: [PATCH] KVM: VMX: Reduce redundant call and simplify code Date: Fri, 31 Mar 2023 15:19:29 +0800 Message-Id: <20230331071929.102070-1-haiwenyao@uniontech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybglogicsvr:qybglogicsvr2 X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761867295082636812?= X-GMAIL-MSGID: =?utf-8?q?1761867295082636812?= Use vcpu->arch.pat = data instead of kvm_set_msr_common() to simplify code, avoid redundant judgements. Signed-off-by: Wenyao Hai --- arch/x86/kvm/vmx/vmx.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index d2d6e1b6c788..abeeea21c8ef 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -2320,12 +2320,10 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) get_vmcs12(vcpu)->vm_exit_controls & VM_EXIT_SAVE_IA32_PAT) get_vmcs12(vcpu)->guest_ia32_pat = data; - if (vmcs_config.vmentry_ctrl & VM_ENTRY_LOAD_IA32_PAT) { + if (vmcs_config.vmentry_ctrl & VM_ENTRY_LOAD_IA32_PAT) vmcs_write64(GUEST_IA32_PAT, data); - vcpu->arch.pat = data; - break; - } - ret = kvm_set_msr_common(vcpu, msr_info); + + vcpu->arch.pat = data; break; case MSR_IA32_MCG_EXT_CTL: if ((!msr_info->host_initiated &&