From patchwork Thu Mar 30 06:52:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hermes Zhang X-Patchwork-Id: 76912 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp926239vqo; Thu, 30 Mar 2023 00:00:23 -0700 (PDT) X-Google-Smtp-Source: AKy350YsoVWFT+ow1HnXVGyu+e09/qBw5IUOoIxGPmXgphYIF/HCZq5L8ZFrGNsPbrXTKxNT4w79 X-Received: by 2002:aa7:dc10:0:b0:4bd:94b9:b8a8 with SMTP id b16-20020aa7dc10000000b004bd94b9b8a8mr20915727edu.26.1680159623100; Thu, 30 Mar 2023 00:00:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680159623; cv=none; d=google.com; s=arc-20160816; b=WkwQ0bQrYMBBf7m3wGI0faST6wqhArk80rzLO/EZtA2zBsGxzSDA+ygbJe4NRtpaYv DLbWM+zjwyfE19xpI5KC5RppXxb7pSUmcrwxFltbIjebjipQ1UB/YrebF6COBVK+ccsX 2VRV5Hf7LGQqddgoytzvrrCDlMLOQPaAz0B/97Jy18+3q5TtpEL47NMnZAuGZDLQyH5H VgySP5wsW3GGsDigowFC/uvytUVTn+L9YB7G3DuBt+qQbto468l0DF52fAa7njMSZjHo wIzYiXqm6vKYAExSTg+MlQ2iwAUGGZA+JVuDQhoWNtIYgdax/qXJ+V4oVxGaDBRSDEuQ je+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=GUkfkVjjfUh4Vh4vq6xCLs2XptKtdvQVMMQaabfQcpw=; b=aEYxckRnnr26+nZRHNJE5covIKc54hKtZ7ibWM5R8nmnq31I5hiV3YoUBtvSyXDuYO KUR2SH6AOdWYuuMHDW1ddMLDGr6cioSyprX6Wx3Ts2OeuKJiwRgOBDjV5om3YvjVAQ4E Urv4xYNQ2HThRc0lV9RYUIBHNdCDmejqe03kLxfaoNAzXNorfZZBmJbYgJ7EE49+q/Vk RICrqsemhNt6LQ+iaPVBfznyiplQcvDiiLtOCMtFPQw+xYHhsHYHdEpBKGIdRfiNdD8o LutdRi5Hpe8n8BQpyZhIFVXnMV1CQYz/O4M3iTccFWS4pHd+Lc1rxnGjEdA7rVzG+mai 8aew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@axis.com header.s=axis-central1 header.b=aIJEA355; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=axis.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e16-20020aa7d7d0000000b00501db4ea3e9si23232285eds.173.2023.03.29.23.59.58; Thu, 30 Mar 2023 00:00:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@axis.com header.s=axis-central1 header.b=aIJEA355; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=axis.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230330AbjC3GwQ (ORCPT + 99 others); Thu, 30 Mar 2023 02:52:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbjC3GwP (ORCPT ); Thu, 30 Mar 2023 02:52:15 -0400 Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AB4F19F; Wed, 29 Mar 2023 23:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1680159132; x=1711695132; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=GUkfkVjjfUh4Vh4vq6xCLs2XptKtdvQVMMQaabfQcpw=; b=aIJEA355ewMBlrdd6tYZHwXR0/rhkVhONW9NGBGusTo/lZs+Q/mH2xmz tywP9/xi0/R/ovzo+C49aJ2ZacV4obyswiLOyaX3zSfb/eqoTrYmvcKM5 nU/XTf0WFjnvne+lVCoO6yIR9FrrYprb0VzY203fwSIVGZGe8lkygZQYO pKAWJv1Koc/xnZQpHJ7CvYOAOiSO6yqL0jtUl82DpfJalFA4DnmzvlAfY kj19x6nsyvOF/qRfNJVgy2/7Qe7gU0ArfvMvgZqW1E7wPkKjvXC69dvxG JIeaPc4guMXveDnzMw0IIK+T0d4qvG4E6gLk06oJ7kdzRVnf4JI71HnHi Q==; From: Hermes Zhang To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Andrew Davis CC: , , Hermes Zhang , , Subject: [PATCH v4 1/2] dt-bindings: power: supply: bq256xx: Add ti,no-thermistor property Date: Thu, 30 Mar 2023 14:52:01 +0800 Message-ID: <20230330065202.1349948-1-chenhuiz@axis.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761775057001834449?= X-GMAIL-MSGID: =?utf-8?q?1761775057001834449?= Add a new property ti,no-thermistor to indicate that no thermistor is connected to the TS pin of the chip. Signed-off-by: Hermes Zhang --- Notes: v2: change property name to ti,no-thermistor v3: drop "|" in property description v4: rebase bq256xx_charger.c .../bindings/power/supply/bq256xx.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml index 82f382a7ffb3..4fe9c3705265 100644 --- a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml +++ b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml @@ -68,11 +68,29 @@ properties: Interrupt sends an active low, 256 μs pulse to host to report the charger device status and faults. + ti,no-thermistor: + type: boolean + description: Indicates that no thermistor is connected to the TS pin + required: - compatible - reg - monitored-battery +allOf: + - if: + properties: + compatible: + contains: + enum: + - ti,bq25600 + - ti,bq25601 + - ti,bq25600d + - ti,bq25601d + then: + properties: + ti,no-thermistor: false + additionalProperties: false examples: From patchwork Thu Mar 30 06:52:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hermes Zhang X-Patchwork-Id: 76915 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp928007vqo; Thu, 30 Mar 2023 00:03:10 -0700 (PDT) X-Google-Smtp-Source: AK7set9YdNkFNexZO45AVauzPW5n7SeBMcVvu+yf60RNuckEAoxbn6MIdvbw61QputBAJx1qSGSp X-Received: by 2002:a17:90a:17a9:b0:23f:452c:7a4f with SMTP id q38-20020a17090a17a900b0023f452c7a4fmr23305013pja.46.1680159789966; Thu, 30 Mar 2023 00:03:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680159789; cv=none; d=google.com; s=arc-20160816; b=P+fB0maH7V28LIn+1S/XhQ2NAmCA5F1jbJ8GYpeEIkWYzYDkUhz8Ghz7KY+GOEN+eD t9zWbrj/kbYiPb7CZHKrcyr1nOqRlnr3n+TzHrNU1UtxJoLubrfsE+1ycDQHHZnsZWCT CS33M3JKkieT/RmpEqS07kGrbZr6tC4cu3k4BIJr8fjRneCXUMthCx0uoDJKQodGXcCV idHDHMMR7RDdLbefTo+VLEippcMED9hwULvzd/NolVBGR4wrpRTBQh3xWwHUB2PF5zmM DcuL+rxlFuS506YsnE/bZ87N2wTzwv0EtSPopzmHpNgH1Yx4xkvLCiU4vgOF12JQrE3S 0I8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZGwDi9vdqenA8v1hs18pq0t6/pkvrSLHzz1lIj+FiAM=; b=zVdzCctPM8X1T7N7+tbDZ02rLdWYGwH5AJUslvgcq+LGMI7lJmL5biQRIvsq7QGirW lloVHuWlIr1QpopIvsH5u3Lc+jtcVbwLVG3Bz9L9VzwZwvKV8x2ItXGZf0hUfqx6RBsM D4t2A0VmmyNBDodEoh0OuSkWMWjQqcoeqMpGA3UNA654bi+jiuT2fUMem8so0VkoEGiL BGIZdpgW+0WdekqsoU6saB8NWKAjYiU7RhoR59YvdZaLqa3o50QWU+1nZkC/DigwOUgl O7U71e1Q2E7Fx2LHH+7W3mzbH2ubCSF0NYF+/0Od9dp3BmINB5pp096rzmiCJlqBrmBc Q5hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@axis.com header.s=axis-central1 header.b=I7soVhsw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=axis.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mm9-20020a17090b358900b00234ba949302si3292125pjb.91.2023.03.30.00.02.56; Thu, 30 Mar 2023 00:03:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@axis.com header.s=axis-central1 header.b=I7soVhsw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=axis.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230347AbjC3GwU (ORCPT + 99 others); Thu, 30 Mar 2023 02:52:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230336AbjC3GwR (ORCPT ); Thu, 30 Mar 2023 02:52:17 -0400 Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D175469A; Wed, 29 Mar 2023 23:52:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1680159136; x=1711695136; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZGwDi9vdqenA8v1hs18pq0t6/pkvrSLHzz1lIj+FiAM=; b=I7soVhswVSj1OXedTcql0VujMhG5bMXZ9tNqQsaTsxqOlWbkkKBeHWQv V4mNWgW5rzmOoq11NHyl0wubjtfTjo+LliEiqex6gQk7Pzgjq6iJCQCv3 7dJWbztD86tG4hHip+JKyz5vKQ/QVoZ5aTXEnhUvk8h/R5URTMK5usPI3 urARzrcznTGvpcV2hvN2HVYDYoZPHIv0RrIeK5cKVcCnV0GzA9bzX175j U4zNuR+hn5l2vZUNjlcrPHPMHYcLIOp0tWfU2bnhoH+TgIqxqNHKnuXNF YvAHn+gcc8W7acoy6Jd2TxHZbWRHKXDYaC9aFWbYZgYPGoa6JsAvXDeoa w==; From: Hermes Zhang To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Andrew Davis CC: , , Hermes Zhang , , Subject: [PATCH v4 2/2] power: supply: bq256xx: Apply TS_IGNORE from devicetree Date: Thu, 30 Mar 2023 14:52:02 +0800 Message-ID: <20230330065202.1349948-2-chenhuiz@axis.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230330065202.1349948-1-chenhuiz@axis.com> References: <20230330065202.1349948-1-chenhuiz@axis.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761775231828853063?= X-GMAIL-MSGID: =?utf-8?q?1761775231828853063?= TS_IGNORE is default off in bq256xx chip. For some HW which doesn't have the NTC, we need to set TS_IGNORE to 1 to make the charge work. The new "ti,no-thermistor" is introduced to toggle it. Signed-off-by: Hermes Zhang --- Notes: v2: change property name to ti,no-thermistor v3: drop "|" in property description v4: rebase bq256xx_charger.c drivers/power/supply/bq256xx_charger.c | 28 ++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/power/supply/bq256xx_charger.c b/drivers/power/supply/bq256xx_charger.c index 9cf4936440c9..cacaae1d559b 100644 --- a/drivers/power/supply/bq256xx_charger.c +++ b/drivers/power/supply/bq256xx_charger.c @@ -41,6 +41,9 @@ #define BQ256XX_IINDPM_MAX_uA 3200000 #define BQ256XX_IINDPM_DEF_uA 2400000 +#define BQ256XX_TS_IGNORE BIT(6) +#define BQ256XX_TS_IGNORE_SHIFT 6 + #define BQ256XX_VINDPM_MASK GENMASK(3, 0) #define BQ256XX_VINDPM_STEP_uV 100000 #define BQ256XX_VINDPM_OFFSET_uV 3900000 @@ -156,6 +159,7 @@ * @vindpm: input voltage limit * @ichg_max: maximum fast charge current * @vbatreg_max: maximum charge voltage + * @ts_ignore: TS_IGNORE flag */ struct bq256xx_init_data { u32 ichg; @@ -166,6 +170,7 @@ struct bq256xx_init_data { u32 vindpm; u32 ichg_max; u32 vbatreg_max; + bool ts_ignore; }; /** @@ -263,6 +268,7 @@ struct bq256xx_device { * @bq256xx_set_iprechg: pointer to instance specific set_iprechg function * @bq256xx_set_vindpm: pointer to instance specific set_vindpm function * @bq256xx_set_charge_type: pointer to instance specific set_charge_type function + * @bq256xx_set_ts_ignore: pointer to instance specific set_ts_ignore function * * @bq256xx_def_ichg: default ichg value in microamps * @bq256xx_def_iindpm: default iindpm value in microamps @@ -295,6 +301,7 @@ struct bq256xx_chip_info { int (*bq256xx_set_iprechg)(struct bq256xx_device *bq, int iprechg); int (*bq256xx_set_vindpm)(struct bq256xx_device *bq, int vindpm); int (*bq256xx_set_charge_type)(struct bq256xx_device *bq, int type); + int (*bq256xx_set_ts_ignore)(struct bq256xx_device *bq, bool ts_ignore); int bq256xx_def_ichg; int bq256xx_def_iindpm; @@ -696,6 +703,12 @@ static int bq25601d_set_chrg_volt(struct bq256xx_device *bq, int vbatreg) BQ256XX_VBATREG_BIT_SHIFT); } +static int bq256xx_set_ts_ignore(struct bq256xx_device *bq, bool ts_ignore) +{ + return regmap_update_bits(bq->regmap, BQ256XX_INPUT_CURRENT_LIMIT, + BQ256XX_TS_IGNORE, (ts_ignore ? 1 : 0) << BQ256XX_TS_IGNORE_SHIFT); +} + static int bq256xx_get_prechrg_curr(struct bq256xx_device *bq) { unsigned int prechg_and_term_curr_lim; @@ -1312,6 +1325,7 @@ static const struct bq256xx_chip_info bq256xx_chip_info_tbl[] = { .bq256xx_get_iterm = bq256xx_get_term_curr, .bq256xx_get_iprechg = bq256xx_get_prechrg_curr, .bq256xx_get_vindpm = bq256xx_get_input_volt_lim, + .bq256xx_set_ts_ignore = NULL, .bq256xx_set_ichg = bq256xx_set_ichg_curr, .bq256xx_set_iindpm = bq256xx_set_input_curr_lim, @@ -1351,6 +1365,7 @@ static const struct bq256xx_chip_info bq256xx_chip_info_tbl[] = { .bq256xx_set_iprechg = bq256xx_set_prechrg_curr, .bq256xx_set_vindpm = bq256xx_set_input_volt_lim, .bq256xx_set_charge_type = bq256xx_set_charge_type, + .bq256xx_set_ts_ignore = NULL, .bq256xx_def_ichg = BQ2560X_ICHG_DEF_uA, .bq256xx_def_iindpm = BQ256XX_IINDPM_DEF_uA, @@ -1382,6 +1397,7 @@ static const struct bq256xx_chip_info bq256xx_chip_info_tbl[] = { .bq256xx_set_iprechg = bq256xx_set_prechrg_curr, .bq256xx_set_vindpm = bq256xx_set_input_volt_lim, .bq256xx_set_charge_type = bq256xx_set_charge_type, + .bq256xx_set_ts_ignore = NULL, .bq256xx_def_ichg = BQ2560X_ICHG_DEF_uA, .bq256xx_def_iindpm = BQ256XX_IINDPM_DEF_uA, @@ -1413,6 +1429,7 @@ static const struct bq256xx_chip_info bq256xx_chip_info_tbl[] = { .bq256xx_set_iprechg = bq256xx_set_prechrg_curr, .bq256xx_set_vindpm = bq256xx_set_input_volt_lim, .bq256xx_set_charge_type = bq256xx_set_charge_type, + .bq256xx_set_ts_ignore = NULL, .bq256xx_def_ichg = BQ2560X_ICHG_DEF_uA, .bq256xx_def_iindpm = BQ256XX_IINDPM_DEF_uA, @@ -1444,6 +1461,7 @@ static const struct bq256xx_chip_info bq256xx_chip_info_tbl[] = { .bq256xx_set_iprechg = bq256xx_set_prechrg_curr, .bq256xx_set_vindpm = bq256xx_set_input_volt_lim, .bq256xx_set_charge_type = bq256xx_set_charge_type, + .bq256xx_set_ts_ignore = bq256xx_set_ts_ignore, .bq256xx_def_ichg = BQ25611D_ICHG_DEF_uA, .bq256xx_def_iindpm = BQ256XX_IINDPM_DEF_uA, @@ -1475,6 +1493,7 @@ static const struct bq256xx_chip_info bq256xx_chip_info_tbl[] = { .bq256xx_set_iprechg = bq25618_619_set_prechrg_curr, .bq256xx_set_vindpm = bq256xx_set_input_volt_lim, .bq256xx_set_charge_type = bq256xx_set_charge_type, + .bq256xx_set_ts_ignore = bq256xx_set_ts_ignore, .bq256xx_def_ichg = BQ25618_ICHG_DEF_uA, .bq256xx_def_iindpm = BQ256XX_IINDPM_DEF_uA, @@ -1506,6 +1525,7 @@ static const struct bq256xx_chip_info bq256xx_chip_info_tbl[] = { .bq256xx_set_iprechg = bq25618_619_set_prechrg_curr, .bq256xx_set_vindpm = bq256xx_set_input_volt_lim, .bq256xx_set_charge_type = bq256xx_set_charge_type, + .bq256xx_set_ts_ignore = bq256xx_set_ts_ignore, .bq256xx_def_ichg = BQ25618_ICHG_DEF_uA, .bq256xx_def_iindpm = BQ256XX_IINDPM_DEF_uA, @@ -1622,6 +1642,12 @@ static int bq256xx_hw_init(struct bq256xx_device *bq) if (ret) return ret; + if (bq->chip_info->bq256xx_set_ts_ignore) { + ret = bq->chip_info->bq256xx_set_ts_ignore(bq, bq->init_data.ts_ignore); + if (ret) + return ret; + } + power_supply_put_battery_info(bq->charger, bat_info); return 0; @@ -1656,6 +1682,8 @@ static int bq256xx_parse_dt(struct bq256xx_device *bq, if (ret) bq->init_data.iindpm = bq->chip_info->bq256xx_def_iindpm; + bq->init_data.ts_ignore = device_property_read_bool(bq->dev, "ti,no-thermistor"); + return 0; }