From patchwork Thu Oct 20 09:20:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: cuijinpeng666@gmail.com X-Patchwork-Id: 6078 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp152573wrs; Thu, 20 Oct 2022 02:25:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM76xLKjbbLrSh6XihM+CX3EKTgf/78PEkR33pfSJTDJpqCJ/xvWtsOVFT4HJTUis5ym1GXS X-Received: by 2002:a17:907:5cb:b0:791:96ec:f436 with SMTP id wg11-20020a17090705cb00b0079196ecf436mr10564868ejb.100.1666257944113; Thu, 20 Oct 2022 02:25:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666257944; cv=none; d=google.com; s=arc-20160816; b=mtF1h5lHvncGJqDOifs05Pj6lW0Q3PGPS6nxvAE0zx7kCDobDbJjz9eSgkwj1Il07n T45DQ8fJtRwkZAcvAcFzdGGlTtz/124xwJFYBOph5r2fR6jqn2ZltFZ2hA1Hl8rjXMSl l1cMXDQQYxZ7o9avbK7HpGWZPgojR1CrgH1Dzz6KyUAw+uhGSb30R8sywslb1dxJJT43 iFLPYy04KzBC4ybTwjX3+Le2vTpVkq23t5qRUvBvCa8zMRcwjhfClSWipFy0Lyg/EPw5 d7PmFOjNOIAmW44ESbjbpGPMPiXby7IPCizlfa2o5Qtp21nJkuFovSGYMI0QPtZcuQCD HQug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=lE6Lj+s17AGERDULG36HKSoQs/IM2VqC9skcKKUuohw=; b=R+cn6wd23Lms8eFHl75OjqBrpxQsJ6FjdTtkgf+wZ9/DEASgA1SustO+MZx6fxwym+ rLXf7o9ui6GqHv/HAeRhBoCKoCFMSWQCGVk12+pU5OGRTWZfdzYT4+DCyE3fdG/odwMR f6IV9HpF2tWG5M6EgCTF42Zpqhxip+4bFYUaZyc/ZVwfdEL4/TUlFp51gmtTv2eaIwiR a89nciAU/KwkvB3K5M9Bzh55nEzw8fAyt6FN1PctHEjYeAY9xUjAw5mqCzf5ouGYpmLC S25CESW62b2G7rSaZ6f5v+8E7Amhc49znBC+YWB6N0bkI2oBU4G/lG2YvSoTEk3fTjKL R1Cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=aXTQ2ssE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r16-20020a05640251d000b0045da52f303csi11451925edd.213.2022.10.20.02.25.17; Thu, 20 Oct 2022 02:25:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=aXTQ2ssE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229972AbiJTJU5 (ORCPT + 99 others); Thu, 20 Oct 2022 05:20:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbiJTJUw (ORCPT ); Thu, 20 Oct 2022 05:20:52 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3816FF26E; Thu, 20 Oct 2022 02:20:51 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id bh13so18677999pgb.4; Thu, 20 Oct 2022 02:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lE6Lj+s17AGERDULG36HKSoQs/IM2VqC9skcKKUuohw=; b=aXTQ2ssE/G9Hp/de0VbcCT7sbCyrpcl9D4nMOGtl5M3e/VUGGXchqs4l9xKck2/A9O STarcVVTRh5No7i6GvHCI+klzbNUajy0zm00X4SYiZETuouOcfqICG9muRsRCH+oSe59 lwkRYUIWnaHgXm48hbzKF0VKWYcwQ85ykUBKWr3kwAd1GIE7en+rxmwh4BSb6oqECZGB UrylPxWKQSb6nOpgXi3zgVnREEYh4EhvbakhGV6+ldNbYAy4S8lV4wqgZpdIr07G6g/C dhqW/Ye27MpwoZB23afPtVJ0LAU8ZnEGNo4Bt+0FITU+3V3VykerLHoOoHSnspQEPZL2 psrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lE6Lj+s17AGERDULG36HKSoQs/IM2VqC9skcKKUuohw=; b=SXrHn8AD7dYFmIVydKSXHXtXtKxhB5V8PCpbAWgIbS0e8cJ7THbD+6jMC/RE4SN9eH Ud7/AiWK4aD761MnZPsg2XqGfCq7gGIy5v1wN4W7AVPdU7wBmP2/g9zNVq5DnjD/1APP HG26LiWA5e3joBnbd4ZekM0Fl8hWu3I9a93WyxDqpK+BTdRmPAR7NI41wR7BC9gqFSFO UbqhvfpFgnQrg3CmaJTxX72FSyMFG/3oSVY7/pLVoHEbgDF0pc8PhK4CKQdr6RF2rfKY bko2C35u4dqZGEKBrwr+nJrU3zX6sc47BcQB57IxDtGfQjUytlt2jkdTGXQBjySrPf33 4/Tg== X-Gm-Message-State: ACrzQf00JnxUTeL6Keg9QXT2FW5iYeTJfGKVTKPayyn1KnRozcodSXPl fztTZ9d5RobbGo4ahZGlGuQ= X-Received: by 2002:a63:2b41:0:b0:46e:9364:eb07 with SMTP id r62-20020a632b41000000b0046e9364eb07mr2850156pgr.46.1666257650692; Thu, 20 Oct 2022 02:20:50 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id p189-20020a625bc6000000b00562e9f636e0sm13353704pfb.10.2022.10.20.02.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 02:20:49 -0700 (PDT) From: cuijinpeng666@gmail.com X-Google-Original-From: cui.jinpeng2@zte.com.cn To: akpm@linux-foundation.org, liushixin2@huawei.com, deller@gmx.de, cui.jinpeng2@zte.com.cn Cc: guoren@kernel.org, wangkefeng.wang@huawei.com, jakobkoschel@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Zeal Robot Subject: [PATCH linux-next] fs/proc/kcore.c: Use strscpy() instead of strlcpy() Date: Thu, 20 Oct 2022 09:20:44 +0000 Message-Id: <20221020092044.399139-1-cui.jinpeng2@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747198090439401826?= X-GMAIL-MSGID: =?utf-8?q?1747198090439401826?= From: Jinpeng Cui The implementation of strscpy() is more robust and safer. Reported-by: Zeal Robot Signed-off-by: Jinpeng Cui --- fs/proc/kcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c index 71157ee35c1a..47b9ac9229dd 100644 --- a/fs/proc/kcore.c +++ b/fs/proc/kcore.c @@ -421,7 +421,7 @@ read_kcore(struct file *file, char __user *buffer, size_t buflen, loff_t *fpos) char *notes; size_t i = 0; - strlcpy(prpsinfo.pr_psargs, saved_command_line, + strscpy(prpsinfo.pr_psargs, saved_command_line, sizeof(prpsinfo.pr_psargs)); notes = kzalloc(notes_len, GFP_KERNEL);