From patchwork Thu Mar 23 12:29:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhruva Gole X-Patchwork-Id: 74050 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2884041wrt; Thu, 23 Mar 2023 05:36:22 -0700 (PDT) X-Google-Smtp-Source: AK7set+LIaSJkBBNGZA5DUHvgywprJ0iQUU7ebOYIaHdUk9T6Ej0yRncugm67keMzMDzgWyEI9CM X-Received: by 2002:a17:906:5a81:b0:932:217c:b85d with SMTP id l1-20020a1709065a8100b00932217cb85dmr9756072ejq.37.1679574982459; Thu, 23 Mar 2023 05:36:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679574982; cv=none; d=google.com; s=arc-20160816; b=D6X2sMW9asV8XwUArsd6afP8B9sWMcLBipHVGWmtpGaJ2sKtGsC54e3XwB4Tc9AgHv aByQdLw4JkicCJ6vkD73woUQNs6pyO58jgVVs7GIObqZOyDo97b8yETTkpFoeu0VnBPL w/nT34n6FYYLjR0dx9EXFKswN+sjLk2tuc+RBxuicrfThZwSD0gjEtFBet5n67Bz07l1 U9Chm+Kx7CY6Lw6mQVqDbhBCir9EnMGq5jN1XsIx4WkbHxw3YjYLXZGkguN0Iw6m4dZY jcN3/6EDPOF9D74gozcHulAgj+NzKTbtxDRbvujh249ptQ+HZ4zah4JTF3kPXiqLeGxG Ab/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=WBtmHvLCnXFwimXJYXKj87tMDRRpgcs5A8ej9EYRbcw=; b=vMWSF1kO2GWfVNX/o+uAK1K7Ioh4Gj0d5C3ObobWxw2Z9VxyXQ2lrprj+nAn6UVOlR m9aZAbU8KfEQKkqHWIXua0GnvBp9NLDYxuzOMadKQIj5iCET068CoUhuwniEnpVWzFU4 kJqdkjqVMC2tvgzoLKJ0+NSGbrkQ8fiHfhdpysy2+UFGV28Pe7lqAY2B5mGZxYoGJfJH uosgri298TC+NJUGze7Z8YzNE7ZbBtVoKfIAeJpNM/UBhV3HsuG4XmL4BKeky+N6CgxW E7xQzgteEkKxDu3mQCySU0njTOSYs5ASrz5G4vKQV7gZzYE/Du4utxl+rtywqGQmk0xl Loag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Daf6nrkj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s16-20020a056402015000b00501d18f4652si9080678edu.501.2023.03.23.05.35.59; Thu, 23 Mar 2023 05:36:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Daf6nrkj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231254AbjCWM3t (ORCPT + 99 others); Thu, 23 Mar 2023 08:29:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230216AbjCWM3r (ORCPT ); Thu, 23 Mar 2023 08:29:47 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66856868B; Thu, 23 Mar 2023 05:29:44 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32NCTfn5129015; Thu, 23 Mar 2023 07:29:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1679574581; bh=WBtmHvLCnXFwimXJYXKj87tMDRRpgcs5A8ej9EYRbcw=; h=From:To:CC:Subject:Date; b=Daf6nrkjTVha6r2zrZ8D7JAq9IT5+ZVwIsW4AVEK16LcophOYeNO34mvWXZxgbxF7 zCzhq7w1fAw/g8xvkOU2hI0Evnadw2Z+fkawrikWqVsvMUZO9/sG9uiJOxs/Klq5kv 6P9Svc3j9Mmv5LQc/K06iO0fx3QnErazY2JdWdvE= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32NCTfU1031374 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Mar 2023 07:29:41 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 23 Mar 2023 07:29:41 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 23 Mar 2023 07:29:41 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32NCTeVY010812; Thu, 23 Mar 2023 07:29:40 -0500 From: Dhruva Gole To: Keerthy CC: Vibhore Vardhan , Dhruva Gole , Tony Lindgren , Vignesh , Linus Walleij , Bartosz Golaszewski , , , Devarsh Thakkar Subject: [RFC PATCH 1/2] gpio: davinci: Do not clear the bank intr enable bit in save_context Date: Thu, 23 Mar 2023 17:59:09 +0530 Message-ID: <20230323122910.991148-1-d-gole@ti.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761162016908383081?= X-GMAIL-MSGID: =?utf-8?q?1761162016908383081?= The interrupt enable bits might be set if we want to use the GPIO as wakeup source. Clearing this will mean disabling of interrupts in the GPIO banks that we may want to wakeup from. Thus remove the line that was clearing this bit from the driver's save context function. Fixes: 0651a730924b ("gpio: davinci: Add support for system suspend/resume PM") Cc: Devarsh Thakkar Signed-off-by: Dhruva Gole Reviewed-by: Linus Walleij Acked-by: Keerthy --- drivers/gpio/gpio-davinci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index 7fc83057990a..d7595b39e8c4 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -639,9 +639,6 @@ static void davinci_gpio_save_context(struct davinci_gpio_controller *chips, context->set_falling = readl_relaxed(&g->set_falling); } - /* Clear Bank interrupt enable bit */ - writel_relaxed(0, base + BINTEN); - /* Clear all interrupt status registers */ writel_relaxed(GENMASK(31, 0), &g->intstat); } From patchwork Thu Mar 23 12:29:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhruva Gole X-Patchwork-Id: 74049 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2883180wrt; Thu, 23 Mar 2023 05:34:21 -0700 (PDT) X-Google-Smtp-Source: AK7set+CoZ6PNvM+wwwn/1KylG35mrJp07Lsr/18kf0Q1pfsdkKVp3BLeZlKkUhzvw2EmD6NkHWO X-Received: by 2002:aa7:d317:0:b0:4fb:5795:b7e0 with SMTP id p23-20020aa7d317000000b004fb5795b7e0mr9675025edq.31.1679574861123; Thu, 23 Mar 2023 05:34:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679574861; cv=none; d=google.com; s=arc-20160816; b=yVpgxKr0PAbxaJ2lMR3/6b9QZ/gQ+xlHck7BwZnqow4fXB+GJwTIjmpvcaY36xhK27 q9j+lb8+4BbbuFDgqyO+lMaONJlZl9yrpG6BqVQos5xu0iuVots6w6MgLb2Wt0tCqJMP ywQxcADzU9ZrI5xS6rQ7y9u3btRiSHBHNUfsDzhqY1AyaQpnLeoqo2spjFUcLQW2yt/a yMGo8uBA9RljxEJYBPS+Z8TNq1qhNIFuu26kmMml9bMzxkbD+UVnPLkaKZ9u6nYvPOJE TkRMNG2p0ARr3jrPQ25GIdpHhvFYnlwnKyGAagyfnLyos+4v2YDrix14b5AkA38Wo1S0 dM1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jfAz3nNZtnM8wt/Xe8+Ol2GrO9qEEqrh7IFYH6+9tvI=; b=Eq9agZigEgcdPh9clyVcMNT+uv97zhCKQgiVCro5P8b8pNuV/VuLcJbyNHdegy5cBR 0KADdgMza81svyvhTiDF3hU+VtsZEIQMkb7TQK/jJCL050l9/lwAPDucsa3802NIA1uA O8Z+Cerz3cG7IiAMQU0CMD4gTbB4DFw9ZfGyq5C8A4wyUhRdJIcrhtOW9ylYTl/VH3lq yQMW3UFYmhDnsG8XyO/gdr2SLFs2goSLkwZOYFHI+b9Op8wfq/8xx+hfNNar/cwHtr/b A6F/hxuZk/P8tzltA46rE6KRI8InVDBnRe/HBRUgCCZpFaO1snqOhXZizpkjYVLJvx7a YeMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=F4Npmk6X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m14-20020a1709062b8e00b00924513630a6si15927743ejg.387.2023.03.23.05.33.57; Thu, 23 Mar 2023 05:34:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=F4Npmk6X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231363AbjCWM3y (ORCPT + 99 others); Thu, 23 Mar 2023 08:29:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231357AbjCWM3v (ORCPT ); Thu, 23 Mar 2023 08:29:51 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AB0386B6; Thu, 23 Mar 2023 05:29:47 -0700 (PDT) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32NCTjRY129022; Thu, 23 Mar 2023 07:29:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1679574585; bh=jfAz3nNZtnM8wt/Xe8+Ol2GrO9qEEqrh7IFYH6+9tvI=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=F4Npmk6XB15R4qhvjoMrOsFj1MLYc5fT2eYdcJXhvxjU1PvnRxBi9DZ7FK6YcOO38 5lYLSRZ6J13inonE9vkRHgUxX3dDYuk1Ao65MYd5pAFMya7sVGxGU1QYEIhHGyyrKQ hogZhsoUSmTrNozxThZt2N2RyeZQWnidRnK1NcyI= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32NCTj6W038925 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Mar 2023 07:29:45 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 23 Mar 2023 07:29:45 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 23 Mar 2023 07:29:45 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32NCTicN019249; Thu, 23 Mar 2023 07:29:44 -0500 From: Dhruva Gole To: Keerthy CC: Vibhore Vardhan , Dhruva Gole , Tony Lindgren , Vignesh , Linus Walleij , Bartosz Golaszewski , , Subject: [RFC PATCH 2/2] gpio: davinci: Add irq chip flag to skip set wake Date: Thu, 23 Mar 2023 17:59:10 +0530 Message-ID: <20230323122910.991148-2-d-gole@ti.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230323122910.991148-1-d-gole@ti.com> References: <20230323122910.991148-1-d-gole@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761161889539529754?= X-GMAIL-MSGID: =?utf-8?q?1761161889539529754?= Add the IRQCHIP_SKIP_SET_WAKE flag since there are no special IRQ Wake bits that can be set to enable wakeup IRQ. Fixes: 3d9edf09d452 ("[ARM] 4457/2: davinci: GPIO support") Signed-off-by: Dhruva Gole Reviewed-by: Linus Walleij --- drivers/gpio/gpio-davinci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index d7595b39e8c4..aaaf61dc2632 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -322,7 +322,7 @@ static struct irq_chip gpio_irqchip = { .irq_enable = gpio_irq_enable, .irq_disable = gpio_irq_disable, .irq_set_type = gpio_irq_type, - .flags = IRQCHIP_SET_TYPE_MASKED, + .flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SET_WAKE, }; static void gpio_irq_handler(struct irq_desc *desc)