From patchwork Thu Mar 23 08:59:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhruva Gole X-Patchwork-Id: 73909 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2800397wrt; Thu, 23 Mar 2023 02:09:34 -0700 (PDT) X-Google-Smtp-Source: AK7set+YsChRV5iefZnk9NMMTaxhDKI9ShPiK8gfjck4ZjyOF64QZsT1WQghyiQJf3bxDiskAbMr X-Received: by 2002:aa7:9890:0:b0:5a8:b07b:82dc with SMTP id r16-20020aa79890000000b005a8b07b82dcmr5783238pfl.0.1679562573711; Thu, 23 Mar 2023 02:09:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679562573; cv=none; d=google.com; s=arc-20160816; b=LTTpTb5G1qv9dj05H/Dwg816najyZ2AyZB+a1WIv0XwOwmDOD9znSb9zOieGtX/nuF sxeEnDxw8ehzMshB66EyJ3dbHFcVs5RaineeWIaqBeLCckmKL74mqMKMbF3Dvs6h3EBA zyRxZtzR9su0B/NGXATtks7oNmlVxv/rbe6OZLYUcqCmuJsWkUdXKfLCECJGcqEtZySU JbDDZw+5igssfKM+QNck/MYW/ZOjqQI0X13kLFxuU04u/sW7llD6PjpHG2D5T9BPLa+V 8PYh6hFQzVgDj/KzHa/UzR3WKt+C3rvAm5sDOd5HSQSnWGy3VbXsy2MXX+YUt8d0GYBG xHqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=vlYds6UzcqS+9v3/F0rZRe6bOfqsdIBTaQvZgdI4u2c=; b=aj51YEWCdQhmvq7UQQCBBNxGVDAvMenZkn597WLns+0GGAKQE/jOz8wISknNXB1gVp 9YbMTN84CQdir4qw9FpG3T4nqVZg7gzbvdFiJ8FhrMJv3qzIuBKvSk8Ez0uGQvpw/F8y GsijKR0fSNKA3fE+3QbHIC/DRbt+KNazZoFMzmep+l/0y0S1fheogNccUFqF1d05YwNQ Piauf/0xfgaTdwrifJ+KiVxRm7zEP+I+cZ4KCO+4n31uKBBVplCpU3Y/Ce+w3cgJ/qjP Gm1Ok4/rUEudzTJcPy2BYknDQss6oFUD+krmjCVMSufIW5jjPMfeOuVJkXAp7/IiBMjQ tHmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=VZzlWKVt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t22-20020a635f16000000b0050fa785a426si7424102pgb.634.2023.03.23.02.09.21; Thu, 23 Mar 2023 02:09:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=VZzlWKVt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231145AbjCWI74 (ORCPT + 99 others); Thu, 23 Mar 2023 04:59:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231446AbjCWI7u (ORCPT ); Thu, 23 Mar 2023 04:59:50 -0400 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5B0830E7; Thu, 23 Mar 2023 01:59:48 -0700 (PDT) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32N8xbdD061805; Thu, 23 Mar 2023 03:59:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1679561977; bh=vlYds6UzcqS+9v3/F0rZRe6bOfqsdIBTaQvZgdI4u2c=; h=From:To:CC:Subject:Date; b=VZzlWKVtDleJwYwUM/AAXdhAttqEKsPJONO/Pk6KYeak4XUDgUxzk76eATipmkx+w xvTsheHkZMrbkFu0DQgjOXMCxQ3mtoVJkjZo7wkeBtrVhpgmKWgiTKS09ua27wtaYI FKqhI9mihd5k91HXgPkMu9LPQjzDtmHO1jZSpO+g= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32N8xbQZ049521 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Mar 2023 03:59:37 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 23 Mar 2023 03:59:37 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 23 Mar 2023 03:59:37 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32N8xZlr027625; Thu, 23 Mar 2023 03:59:36 -0500 From: Dhruva Gole To: Alexandre Belloni CC: Vibhore Vardhan , Dhruva Gole , , Alessandro Zummo , , Nishanth Menon Subject: [PATCH V2] rtc: k3: handle errors while enabling wake irq Date: Thu, 23 Mar 2023 14:29:04 +0530 Message-ID: <20230323085904.957999-1-d-gole@ti.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761149004981645001?= X-GMAIL-MSGID: =?utf-8?q?1761149004981645001?= Due to the potential failure of enable_irq_wake(), it would be better to return error if it fails. Fixes: b09d633575e5 ("rtc: Introduce ti-k3-rtc") Cc: Nishanth Menon Signed-off-by: Dhruva Gole --- Changelog: Address the comments from Alexandre Belloni V1 link: https://lore.kernel.org/linux-rtc/20230323081942.951542-1-d-gole@ti.com drivers/rtc/rtc-ti-k3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ti-k3.c b/drivers/rtc/rtc-ti-k3.c index ba23163cc042..0d90fe923355 100644 --- a/drivers/rtc/rtc-ti-k3.c +++ b/drivers/rtc/rtc-ti-k3.c @@ -632,7 +632,8 @@ static int __maybe_unused ti_k3_rtc_suspend(struct device *dev) struct ti_k3_rtc *priv = dev_get_drvdata(dev); if (device_may_wakeup(dev)) - enable_irq_wake(priv->irq); + return enable_irq_wake(priv->irq); + return 0; }