From patchwork Wed Mar 22 14:39:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73467 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2377868wrt; Wed, 22 Mar 2023 07:40:48 -0700 (PDT) X-Google-Smtp-Source: AK7set/GrcZR2Lmy3eWUbmhnARCM8o4/gC3PXkQY3JMOx+l1IJOmYPMHOtwbDvv0o9dXESdsBt6B X-Received: by 2002:a17:906:494c:b0:933:44ef:851e with SMTP id f12-20020a170906494c00b0093344ef851emr8057293ejt.55.1679496047966; Wed, 22 Mar 2023 07:40:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679496047; cv=none; d=google.com; s=arc-20160816; b=TabeSYjTM084BUjZWK/im+kkByQTf5U+5GuLG+dQTlnyfUZoW96LgXlpL3M5sZZ9v+ ZOmLkviSPRj/S8MuiBS3Jpwi16Orqh94zWghC4vCNduckyiJDp6OQ3rU4B3J900efo7T sOfCEdo9lVPDUtiOj0GhD6NImXlRCW8oz44EfZCho8nMuG+xx3O4SfYhu/WC7FWL7trW SzcBeQKKVHTOvf9uzmYEBstVJab6bKnK6F+Hco6h8DuEDY2pEPIO70aG5ilVRnTa/5d9 xd4SHSSrizlUCi7f5kgp3h5oCpGrdvSd4H80QY4+OZB3Ko//E4IQsaMUwjTpy9CU57Pp bPEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wG0mcpYshfKekVXsT16WXN6VVc0cNvViQHidRMGPiYE=; b=UQV9KQzu3eXon74erw9YJj/91gxbV/6NjmbLjJAakAL3KGDf+gfYaPWvtllGkY4yno CnLLcDtExzZjqMxSNPzU5j0yYLgdEmfufQSPy2gqx4BDHhl9b4wnMNcxl2Fdbutzy3Ur xlGrNj42Ns0Pw9jD+XFXFRx6FeYLCx4Zo4/aFwMuuOGZuDMgaDoTXrQ4o0wvL6KPqm3N OrBkgrZrdBSMHTJJYSWYB1oYzOnhXE6eE8PS0AKTaPY+9hxyDsmZTkbkj4oEPVv2srib y1shX8V97asry0C7Ek2e7Np+r/3ZSmvpO2ot+fqb84PMq24MhKlUrMoBZYG7Xsp0k3KG T2cA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=UF41KvIo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c10-20020a170906170a00b00930913ad9d1si14631124eje.132.2023.03.22.07.40.24; Wed, 22 Mar 2023 07:40:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=UF41KvIo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231590AbjCVOj3 (ORCPT + 99 others); Wed, 22 Mar 2023 10:39:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230381AbjCVOjX (ORCPT ); Wed, 22 Mar 2023 10:39:23 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD70F3347A for ; Wed, 22 Mar 2023 07:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495962; x=1711031962; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TkCkoVN5YuqKJoNk1l2F8kUlVp9keQi4zBudYIi2MhU=; b=UF41KvIoEY+0kbZSVUk9o+T37X/265H7/9qNZVmrYUc0iKbgBJGQkVrY 1d05wjUWEr5RZsReD3/n7YFd2Ol1H13KryT3/qR/ltGtQHOQiCb1ADeaV /qMdSGokGr/6So0UbAW3kc5La4g7ZvTJggn0HFJSB2xzSx5mpIyEp9muK +Wk+qJQC0NjmVH3GzG/wpR0Vpjhu1i/QvvqF3bK79LFbdf0Au3f04Kmj0 NQ+Yr1NhWaHAne0MWF8LXgzd+lKGfUQi0MqXA2VK2GHU5F2lH+elqu8oM jnmRZwLRXyGe2QrXxXOxqhQfy+DUBeH9C3RmQ1UK9jYFwBzU/5HxQnnqg Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="327609288" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="327609288" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="792579428" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="792579428" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 22 Mar 2023 07:39:20 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 9C5E581; Wed, 22 Mar 2023 16:40:06 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 01/14] extcon: Fix kernel doc of property fields to avoid warnings Date: Wed, 22 Mar 2023 16:39:52 +0200 Message-Id: <20230322144005.40368-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761079247941035300?= X-GMAIL-MSGID: =?utf-8?q?1761079247941035300?= Kernel documentation has to be synchronized with a code, otherwise the validator is not happy: Function parameter or member 'usb_propval' not described in 'extcon_cable' Function parameter or member 'chg_propval' not described in 'extcon_cable' Function parameter or member 'jack_propval' not described in 'extcon_cable' Function parameter or member 'disp_propval' not described in 'extcon_cable' Describe the fields added in the past. Fixes: 067c1652e7a7 ("extcon: Add the support for extcon property according to extcon type") Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 3997b39680b7..1bc2639704c2 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -206,6 +206,10 @@ static const struct __extcon_info { * @attr_name: "name" sysfs entry * @attr_state: "state" sysfs entry * @attrs: the array pointing to attr_name and attr_state for attr_g + * @usb_propval: the array of USB connector properties + * @chg_propval: the array of charger connector properties + * @jack_propval: the array of jack connector properties + * @disp_propval: the array of display connector properties */ struct extcon_cable { struct extcon_dev *edev; From patchwork Wed Mar 22 14:39:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73476 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2382898wrt; Wed, 22 Mar 2023 07:51:24 -0700 (PDT) X-Google-Smtp-Source: AK7set9wg+ze5Rb5tvtZX4OFTSWFqOIB92ktc5z1APGLVLaYDYahhkQyPWxXFnq7Qa23ysBu6oe7 X-Received: by 2002:a17:906:b08:b0:8f0:143d:ee34 with SMTP id u8-20020a1709060b0800b008f0143dee34mr2652581ejg.1.1679496684032; Wed, 22 Mar 2023 07:51:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679496684; cv=none; d=google.com; s=arc-20160816; b=K9t5buIVYLlzng5lnsD/gBgoS+2s5wYi/V2oZpcErSla+lRMlM7hGNRmfS5OxVFzN+ 3xJuXgSDNxjUoL5rpMDWdxtvIvSiscZeePWmu8tuQbrA+KLyzJdFa++O33CoopACg6F+ 1mXVcOz0hELlSSyNTdwnAUx+germ6GnUoCopfD0z7utprGxbVZUkESPPWlDYcnG3SQHC DWPPyJAqDMQVCD6xUoyyZW1Q2rSPjrY8kLmjyogLfqWT6qK+6NkhAMvEIedaIWK9di1/ xlZ/2zVnwRHZ8vGmdM1cmCVMklsA1KgU11GrGkHioDhQn4jEQjSS4zZGLyX3Q9HyCvNo 7wFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CxBle8Pz4dTNMW90FuF/5avt4JQSt1qFlHkYMy158i8=; b=FMGE3WVkIcvL7CgdxaZV6kGXp+/36jdmcEpkRGk72knPfH7o+2PFOjbpfz/+vwcSld xAvwMAcLbDubBKKUmrU5607/DHzX2VlfU1iJ4mQVyny0wihN8nAUEiS9ljtL5elTm1fW OZKsBoad/v4EPhPXmpmglVBPX76N9pBUeS4/TB0vrpby/3/REcRHf2R5+A/kSmuz48AQ qbv9c6Eu4V5ACL17GX/OS/qSM+lMGgzKCYzvITdEL3PX4e9pRn5fvYpyGlpYtVt81egb L15RRTnja77zo1eAMnhjNDnRrBEt4HeNNjXaWbSL4CCqyKY0M6887gyvXyuC/I4Pinwh JjGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iJs+32hq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gy19-20020a170906f25300b00925de8df75asi14992573ejb.75.2023.03.22.07.51.01; Wed, 22 Mar 2023 07:51:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iJs+32hq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231616AbjCVOjf (ORCPT + 99 others); Wed, 22 Mar 2023 10:39:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231395AbjCVOjY (ORCPT ); Wed, 22 Mar 2023 10:39:24 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA08231E19 for ; Wed, 22 Mar 2023 07:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495963; x=1711031963; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AVd04bvZvtiru6UczXNHsDReJQuNasVR+P+brwfuTWw=; b=iJs+32hqHLHVe/Q0/iv6EsW/Qg2zi5zP26kth/g0+ihLppYZxnki0TVn GG2WFf80ESKMtXNyqAktLZiyujYf+jlYEb2KHf+EMsPy38dVqtxJWmHeI C9DhoFep4XKJBgcY/Gxr8UEp82QaPZY1/aQl4Zgu9W07gOkuHjPJY9Bbe o1/1JkzxHOH/VZ5URlaC1Yffx6fwmq9hG5ijQHGe75uPnjp5fXGC+KKIC k8JIm028OjTjQNnfCSHUqoYYCeSeIu4f2EHIJf7iS45OSJIJFDyuzSZQY RNwHdZSp2CXLDqbRq9CdOgktM4QZq5U52pdQyLby+Qcjb+YEpJ+4yJ/hb w==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="327609290" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="327609290" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="792579429" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="792579429" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 22 Mar 2023 07:39:20 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id A3E0E4FF; Wed, 22 Mar 2023 16:40:06 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 02/14] extcon: Fix kernel doc of property capability fields to avoid warnings Date: Wed, 22 Mar 2023 16:39:53 +0200 Message-Id: <20230322144005.40368-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761079914915515346?= X-GMAIL-MSGID: =?utf-8?q?1761079914915515346?= Kernel documentation has to be synchronized with a code, otherwise the validator is not happy: Function parameter or member 'usb_bits' not described in 'extcon_cable' Function parameter or member 'chg_bits' not described in 'extcon_cable' Function parameter or member 'jack_bits' not described in 'extcon_cable' Function parameter or member 'disp_bits' not described in 'extcon_cable' Describe the fields added in the past. Fixes: ceaa98f442cf ("extcon: Add the support for the capability of each property") Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 1bc2639704c2..79006ab5334b 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -210,6 +210,10 @@ static const struct __extcon_info { * @chg_propval: the array of charger connector properties * @jack_propval: the array of jack connector properties * @disp_propval: the array of display connector properties + * @usb_bits: the bit array of the USB connector property capabilities + * @chg_bits: the bit array of the charger connector property capabilities + * @jack_bits: the bit array of the jack connector property capabilities + * @disp_bits: the bit array of the display connector property capabilities */ struct extcon_cable { struct extcon_dev *edev; From patchwork Wed Mar 22 14:39:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73482 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2386023wrt; Wed, 22 Mar 2023 07:58:38 -0700 (PDT) X-Google-Smtp-Source: AK7set8XQu6mgbselbbU6EVEZskaqF1NwVr020gWa+Y6WlHMJLgFUI74PFu7AUCizqQZQZtOwWvs X-Received: by 2002:a17:90b:17cb:b0:23f:5fe7:25a1 with SMTP id me11-20020a17090b17cb00b0023f5fe725a1mr4113959pjb.13.1679497118049; Wed, 22 Mar 2023 07:58:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679497118; cv=none; d=google.com; s=arc-20160816; b=SqRrC2N2Fmfa543hmFk+rXeUjiBqUQZylMaHuN0gIpDBcSaSJGKkDQ0am22inXx10w IdsQ0MTG4aXH/rIbqDPFsMC14c8eAnf/nzpntIX+hSu9RtjhWlMISKVDJ3Fg1fJYOdcU ksYbONa2FuINXk776Kf9bDhhOdnNEcaGizh0YN9ddOdhqYmaAWRv3PHbpcQOrLIBb5OO WkHfDeqyBCfMPi4oog3XrI0JgOIjQgAwYkrhQjpZNbSHx8uOJCHJfO8zlRlh6WzBfvre rdQJcYy4AzIqplYHgByadMVH31+ZqFaLFccuPXwQtzDBU1597h+tmrvXTiChKrno9xI+ ZzDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=aMmQ62p4BBlUVQpiIxe/v0jQKQCmk965OAC2WDedCEk=; b=Xci0iXWyMkotex2j1CVuvSi1KABiBvOzjRFqPulAzLr4uDXMceSUo+fUWu328SD5/e bNqBnZX1LGfNJqAJk5zBt5zeCywlUhh2GELbG+9PLNqcjrtLuTaW/TXoNKsfJf8yxK0+ TTutQwcGrOqaP/CmH1g+b3XLkvAYTAuCDqvv6G8Cqp4/a5AFtoGxqJjUfnonxHKt5GEg lxZ3efzyXgizfPlf4l7Jx/VFPykWyYhLI6OEgoUqfU26tyj3ZHksYCPUo1WHbr/ToEOI bMBaAB/5IvpKhELfPUYmsxCkkEKalsGsccFDY/2/0hK0rsO2DZeylRX8dApvcp9CCsEF ODYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=EB9yC3WM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g7-20020a17090ace8700b002336940f887si15291475pju.61.2023.03.22.07.58.24; Wed, 22 Mar 2023 07:58:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=EB9yC3WM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231599AbjCVOjc (ORCPT + 99 others); Wed, 22 Mar 2023 10:39:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231363AbjCVOjY (ORCPT ); Wed, 22 Mar 2023 10:39:24 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A5942A141 for ; Wed, 22 Mar 2023 07:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495963; x=1711031963; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=23K7sqqOvhEB00PQYCJm2SbhNF+B/eu/uGmGRWsjPHU=; b=EB9yC3WMVLvQ/9aXmcV93naILOMzB4Qwh54VB3bmqf7hWgn7w1oV7IIP AdyAf09k03ur3jT7NVdINV5R8OVMXvUjr9IjKdiSbqyV5XzKinq5e61+r CCMgMllyT94xvQslWMbxsS+aMroCqUYnn3ViCkHNs6CExX7hA3zutjMxO e9Vs1xHfrVwiVfXkuu29LDFjpcyb9cb2M3oXoxf+4jWSnx6Px843rt4/Y m7K1QERUQtV50j/NRKexYJfvCeN1NsEtJ8ajlVk+TjGsOt6Kfp8sPt9pG NUJD2RFM8kI2Ce4s1ChHFz13Y4/DOJY7gTLovReh4yCyaCbEjiCt3zJAe Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="327609289" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="327609289" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="792579427" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="792579427" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 22 Mar 2023 07:39:20 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id AB0C550A; Wed, 22 Mar 2023 16:40:06 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 03/14] extcon: Use DECLARE_BITMAP() to declare bit arrays Date: Wed, 22 Mar 2023 16:39:54 +0200 Message-Id: <20230322144005.40368-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761080370098461869?= X-GMAIL-MSGID: =?utf-8?q?1761080370098461869?= Bit arrays has a specific type helper for the declaration. Use it instead of homegronw equivalent. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 79006ab5334b..70e9755ba2bc 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -230,10 +230,10 @@ struct extcon_cable { union extcon_property_value jack_propval[EXTCON_PROP_JACK_CNT]; union extcon_property_value disp_propval[EXTCON_PROP_DISP_CNT]; - unsigned long usb_bits[BITS_TO_LONGS(EXTCON_PROP_USB_CNT)]; - unsigned long chg_bits[BITS_TO_LONGS(EXTCON_PROP_CHG_CNT)]; - unsigned long jack_bits[BITS_TO_LONGS(EXTCON_PROP_JACK_CNT)]; - unsigned long disp_bits[BITS_TO_LONGS(EXTCON_PROP_DISP_CNT)]; + DECLARE_BITMAP(usb_bits, EXTCON_PROP_USB_CNT); + DECLARE_BITMAP(chg_bits, EXTCON_PROP_CHG_CNT); + DECLARE_BITMAP(jack_bits, EXTCON_PROP_JACK_CNT); + DECLARE_BITMAP(disp_bits, EXTCON_PROP_DISP_CNT); }; static struct class *extcon_class; From patchwork Wed Mar 22 14:39:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73481 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2386022wrt; Wed, 22 Mar 2023 07:58:38 -0700 (PDT) X-Google-Smtp-Source: AKy350Zm8ce2/hojS8yJclVq3QfZgMSgV3hGPh5XNAuimvOzftcNHr7R33YsNgMyzJ20u2/2tXZy X-Received: by 2002:a17:902:d2d1:b0:1a1:cae6:cfd with SMTP id n17-20020a170902d2d100b001a1cae60cfdmr2339225plc.34.1679497117837; Wed, 22 Mar 2023 07:58:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679497117; cv=none; d=google.com; s=arc-20160816; b=fpu8o9zGaaxY5Qby1lxeMpBYiDdzVQLv3ErEeixf2QvhVdU/Gvdoe9u7oFqdDT0PDc P/URMEHJcPiVdo9j/Mk7HweDD1flsLB91z/4VEcOK0xteIVz+EUW1IvcT974hyQjuknQ OMf35UwQ7yGJ5KHCcnEQ0J2brdLiJ6w88v8an7MEYEJyk6yw7cQOFfHEzdJvrZcjS+dy KLgjMW215acSLNQCSpHa7Zk6GsxBTA75oD0PRfN+n7LE/cdxkOT6DmLboAClzn9C5wqf 1qiYI3Bo/7hXOPzxSwO3wcUSVoCarz3xdDNSbibdtgbxIYFpAdOIkezR45k6+zQtmkju FTGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iobMeeEFx9YRZfTmDLaOpjvsGiCBygOu3aATqRCEW8A=; b=s/6BLuz8XzxUwQ53oW1BqaXO8elqnjEwHb+4RHM3V6rhB6dOWJL4HKXB6n0F5MeZiT XVx3cWneZsf16SUxRYTQVap9LZI6eacMa52UYInf4U676HEU3U0AxVWOmAl9bkFuhYV5 IiDUnnor6mrvPCmUgP0vpkE625V57viU7AaNHkUth6cVM2LkbYxY94Wyz03wsXQ56ib4 iBo42Oxw+L20FO7OrfCdkrOhHHba1Kh860pKg9fY5OkNtD8nWCOt8++e3oW7PPs3IP4c lss0vqGp9JDvzf5bkA1Edb+JoogTshbEotzZ3V+RryiLrRD8ZY3D0PFvtQyV9+7CB4iq eFfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=loTAv2A+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jx5-20020a170903138500b001a1a6eb72aesi14763499plb.517.2023.03.22.07.58.24; Wed, 22 Mar 2023 07:58:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=loTAv2A+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231516AbjCVOj0 (ORCPT + 99 others); Wed, 22 Mar 2023 10:39:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231308AbjCVOjX (ORCPT ); Wed, 22 Mar 2023 10:39:23 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7797431E19 for ; Wed, 22 Mar 2023 07:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495962; x=1711031962; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kBAOit4snqoHUt4I0yuPk3ujQh2EhLlWYoA5K0fcvog=; b=loTAv2A+xpYkS1pHZbun5wqpCJoYTfmnu9OPP82zwvIXUWubuSp+rMx5 vG//0t9l4MPKVwV1XeRBmAdGZ0VGVGF0HMJAll/R7UbW9Bz4FWa6roSF5 6d743EkyTgcRtZSNj9XIETuP3757cv7dgulYTUYIKqdfWy3ugx4c16CM1 xvwvevpWN0jEZrXRV89eY+NuP71+XDlFo2w64y6CvqWyFoiUh7CWJj3Bj jpHvdC4GzpCTu71JvHt12DDgCczuznTfc5lgFK+pG1w4yy+T/upqcXdKI 7hatze5cP5+ZEY7fgn8/7ma5qlJakfB6KIKNHMb4HuNlkAZXWMpVtKJkG g==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="319622115" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="319622115" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="856116414" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="856116414" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 22 Mar 2023 07:39:20 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id B24C650B; Wed, 22 Mar 2023 16:40:06 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 04/14] extcon: use sysfs_emit() to instead of sprintf() Date: Wed, 22 Mar 2023 16:39:55 +0200 Message-Id: <20230322144005.40368-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761080370148966381?= X-GMAIL-MSGID: =?utf-8?q?1761080370148966381?= Follow the advice of the Documentation/filesystems/sysfs.rst that show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 70e9755ba2bc..ac84f4aafc69 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -370,12 +370,12 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr, struct extcon_dev *edev = dev_get_drvdata(dev); if (edev->max_supported == 0) - return sprintf(buf, "%u\n", edev->state); + return sysfs_emit(buf, "%u\n", edev->state); for (i = 0; i < edev->max_supported; i++) { - count += sprintf(buf + count, "%s=%d\n", - extcon_info[edev->supported_cable[i]].name, - !!(edev->state & BIT(i))); + count += sysfs_emit_at(buf, count, "%s=%d\n", + extcon_info[edev->supported_cable[i]].name, + !!(edev->state & BIT(i))); } return count; @@ -387,7 +387,7 @@ static ssize_t name_show(struct device *dev, struct device_attribute *attr, { struct extcon_dev *edev = dev_get_drvdata(dev); - return sprintf(buf, "%s\n", edev->name); + return sysfs_emit(buf, "%s\n", edev->name); } static DEVICE_ATTR_RO(name); @@ -398,8 +398,8 @@ static ssize_t cable_name_show(struct device *dev, attr_name); int i = cable->cable_index; - return sprintf(buf, "%s\n", - extcon_info[cable->edev->supported_cable[i]].name); + return sysfs_emit(buf, "%s\n", + extcon_info[cable->edev->supported_cable[i]].name); } static ssize_t cable_state_show(struct device *dev, @@ -410,8 +410,8 @@ static ssize_t cable_state_show(struct device *dev, int i = cable->cable_index; - return sprintf(buf, "%d\n", - extcon_get_state(cable->edev, cable->edev->supported_cable[i])); + return sysfs_emit(buf, "%d\n", + extcon_get_state(cable->edev, cable->edev->supported_cable[i])); } /** From patchwork Wed Mar 22 14:39:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73469 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2378740wrt; Wed, 22 Mar 2023 07:42:28 -0700 (PDT) X-Google-Smtp-Source: AK7set9TG1UDpPu6omSJhgFxWOX0Qfydwex2Wwwd9lluWaoHMogUQE8FnC9wGOAIY+oWWYw6nUMD X-Received: by 2002:a17:906:8517:b0:92f:e7e2:b7b3 with SMTP id i23-20020a170906851700b0092fe7e2b7b3mr7726908ejx.5.1679496148387; Wed, 22 Mar 2023 07:42:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679496148; cv=none; d=google.com; s=arc-20160816; b=rcCaSIXEgiBT/+DuM8e4uMZCs4tk3NtqTjExoBiko8ouVlmeokBTqhIfjt79gtnIek rbmpNGyjJoR6G3Z+8bZfC2yB+VtkN3PMFa+DckiOZtKp4FhoKfU3o64mI0EWxV0wsU6N hLpCYMLeFm6DXEZiWcsVKLI1XsJYrJ8NdYzXxy6gNAnpfiI00aBNtfOJozkRgj1TjxYd GT8Bt5vfh5+Z0BEyX/csVBjedy25pCF5TDgsJEWgTeR/EyDVlItcspdtZuI6YN3RoNwN ij6QeHVIJ//thcGT/d236ZMuiOMqbSd3bmuvYuB1KkkDxyMJL+8mj0wvrjDCNP4htWVo ngFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8NGkbPkrqgLWmyzslOPvcfQKMIO7Jd5mr+BL7tV4U9Y=; b=H9eWnEBTN4zmyJEq66/Mcx1BhZgKNgEa0Z9++qMVYC7vQ1jmGOYzL3MUe43j6cf4v2 PtMDXHN0wPAOcrQ0uinuvUqExNtNQIU7zNsZcodiXe+Tl/jcpF7ijdnDf4cwEg84FZse jnj4jusrXz06R8YONRmxWYZtCBR3Asf44DZAvDB9I2y8f0ciSPiCDELcA232SPtQIjlR 4T7zmDIA2BPjNmJHNAiIfk+4c9q5/ACNaHediZ3uSIzvMl+6VX3wYGFvatCyvbNVo3U5 G7SGfJB9jQYSsPGlfxmQ//P1V3GLrPq5XH5BMg1tApKWQgnjjVBipRREh00V1Bw916w3 9o/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jVCeYsQd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u22-20020a170906951600b0092a8aa23062si15128145ejx.571.2023.03.22.07.42.05; Wed, 22 Mar 2023 07:42:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jVCeYsQd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231659AbjCVOjm (ORCPT + 99 others); Wed, 22 Mar 2023 10:39:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231451AbjCVOjZ (ORCPT ); Wed, 22 Mar 2023 10:39:25 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C2063347A for ; Wed, 22 Mar 2023 07:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495964; x=1711031964; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8uevUwjjKvLYeP2DQKzLWRjw88ZIleN4K7KAE0RgZQM=; b=jVCeYsQd6kp9pDOZytt6GIqxERschcuuck54DFg0BTaiwwLHddxC8ZKl 0iwTX8JP4QWi7F3aciWtY3u1O7eU8sx9IdHxPdJL/CcJW2JyLK7wY9Msa cUAFu4xg+96ArNkm4AzOzzH8FzZLe94Xg7Ap7Hqhw4eLcsQAuQmcfVTnh 5ARKlmnthn0nFNf/2fzIrSEXmq8Ik/0NW1EMVJgHvfrxcJBpDNrfTeUtS TOjhlIF4HEP6p0VcBGd459jesKzfoqIT2qEamFiJEHrbnuNC1SiFJU5mx AOkNLKlSRUQQFnwU/783KHHVUcwTj1BEmCqvlucl9fB4Jxu01DLzqCM9c A==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="319622119" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="319622119" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="856116425" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="856116425" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 22 Mar 2023 07:39:22 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id B976F5A7; Wed, 22 Mar 2023 16:40:06 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 05/14] extcon: Amend kernel documentation of struct extcon_dev Date: Wed, 22 Mar 2023 16:39:56 +0200 Message-Id: <20230322144005.40368-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761079353002869998?= X-GMAIL-MSGID: =?utf-8?q?1761079353002869998?= First of all, the @lock description is missing. Add it. Second, correct the terminator value for the mutual exclusive cabling. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/extcon/extcon.h b/drivers/extcon/extcon.h index 93b5e0306966..15616446140d 100644 --- a/drivers/extcon/extcon.h +++ b/drivers/extcon/extcon.h @@ -13,8 +13,8 @@ * are disabled. * @mutually_exclusive: Array of mutually exclusive set of cables that cannot * be attached simultaneously. The array should be - * ending with NULL or be NULL (no mutually exclusive - * cables). For example, if it is { 0x7, 0x30, 0}, then, + * ending with 0 or be NULL (no mutually exclusive cables). + * For example, if it is {0x7, 0x30, 0}, then, * {0, 1}, {0, 1, 2}, {0, 2}, {1, 2}, or {4, 5} cannot * be attached simulataneously. {0x7, 0} is equivalent to * {0x3, 0x6, 0x5, 0}. If it is {0xFFFFFFFF, 0}, there @@ -27,7 +27,7 @@ * @nh: Notifier for the state change events from this extcon * @entry: To support list of extcon devices so that users can * search for extcon devices based on the extcon name. - * @lock: + * @lock: Protects device state and serialises device registration * @max_supported: Internal value to store the number of cables. * @extcon_dev_type: Device_type struct to provide attribute_groups * customized for each extcon device. From patchwork Wed Mar 22 14:39:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73478 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2384214wrt; Wed, 22 Mar 2023 07:54:35 -0700 (PDT) X-Google-Smtp-Source: AK7set8RLgshX55GE725jrPyqC6IVJ+F1mnHK6YswJI+CitMNn5yFYFvWHqasb6Pxssxv5o2RiM7 X-Received: by 2002:a17:90b:350a:b0:23f:7176:df36 with SMTP id ls10-20020a17090b350a00b0023f7176df36mr4242935pjb.13.1679496874748; Wed, 22 Mar 2023 07:54:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679496874; cv=none; d=google.com; s=arc-20160816; b=ppPc0ZowM/fQ5UMchh357Tr0qTnb8eBv6CgichPgs+gWQ8U3x9Bow26TLuRAR4i58E 61m9i/qvCleUm3B+5mMtimqRMMP2klvV1LYWjNXpT2KOxrYGJDV4atbGbAw4jPl+gEM6 U3OTY2USRN1onAZQY0QIG3ydnVr7BnRHmSlGXDN3K4/14z0MiFGGh4234sXJdxPcqLfE tj+3B7iMqi0TFrf+PQWH/gYq5F1taelQzrZrlAFT3L8CEHW/M7FsNchRSzY1ZOjICMD8 5k0gEn/yNO5cAGWU0qmCF7kMVl5eHol5XcrUtCapOBNE6FbO4qytc2nO67w/u5Nj8sSE ij8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fsciFlty20PbxlPCnUR8fW7k0aD6NrUN9era6wVY/jA=; b=BqVNy6Do8A0nKUzNSmMMPtCJXiYhc/LFZWKTliGhCttGP9Dt4NllC8aEZfsfpu/k2T R0At+ZsnRoHvD4i5bWLSo5+66H6hX+GOXoSEvBPAwHbLshQO7UeaeuIdvYvyVfindzY5 mKEy39JBKSZr/z/pIo0hVE5XLLjXbBUaa2KVclPdJFOEKSKk1Ep4GavB3SpMQAwMhhDS n4wMX0k4Da87XutRcXSZppuss6pW5oEnr4fY1rIxuDciCQw313XwH5bQcH8bwN4moXFI It68J2JWLHfSf2b+Px9S1CKJN9gy5NUmtof+jpitVnf+R8xtaiQJUTN07b61/QaOu/nK c9Qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="d4PDK/Nk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e10-20020a17090a7c4a00b0023f000be67dsi21137463pjl.13.2023.03.22.07.54.21; Wed, 22 Mar 2023 07:54:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="d4PDK/Nk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231627AbjCVOjh (ORCPT + 99 others); Wed, 22 Mar 2023 10:39:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbjCVOjZ (ORCPT ); Wed, 22 Mar 2023 10:39:25 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66EA32A141 for ; Wed, 22 Mar 2023 07:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495964; x=1711031964; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=d4qGUtkkw/1Zx3uos2jaj6d4j/Os0XO1Iz7gJZdoh0U=; b=d4PDK/NkVXq0TApvuKjTPvIgFZXH7HTkvPm9mh3jEyEekbAAfTEEOzOB xjTsA3X1Yb+vtbq8dJy/mhjfZ2gRxhIHZF75Hb25YBAGnx55kHkOKTPXf z+M0aLjXjS5ixCwvRty0aFbIG/3dIYd7A4jjW8jkW+tK0ufBkfU6oqmh+ pOCsneLOEgqRW8cda6TW4smM0/tqIXqtpbBMlmbl8FcxbXDx2ZgsFcUlj DNgpr3bmjrrohdXWBvdzOS2gr30zJaJw2iZ38BZ1U/YdjABLvkeUod8Es Ji6M4eTmDR9JP91dsx93UNiRPp6SqrgyeamR2+Qjuz1gMc5qHmOggVooJ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="327609300" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="327609300" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="792579431" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="792579431" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 22 Mar 2023 07:39:22 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id C092C638; Wed, 22 Mar 2023 16:40:06 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 06/14] extcon: Allow name to be assigned outside of the framework Date: Wed, 22 Mar 2023 16:39:57 +0200 Message-Id: <20230322144005.40368-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761080115077623950?= X-GMAIL-MSGID: =?utf-8?q?1761080115077623950?= The documentation states that name of the extcon can be assigned outside of the framework, however code does something different. Fix the code to be aligned with the documentation. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index ac84f4aafc69..14e66e21597f 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1269,10 +1269,10 @@ int extcon_dev_register(struct extcon_dev *edev) edev->dev.class = extcon_class; edev->dev.release = extcon_dev_release; - edev->name = dev_name(edev->dev.parent); - if (IS_ERR_OR_NULL(edev->name)) { - dev_err(&edev->dev, - "extcon device name is null\n"); + if (!edev->name) + edev->name = dev_name(edev->dev.parent); + if (!edev->name) { + dev_err(&edev->dev, "extcon device name is null\n"); return -EINVAL; } dev_set_name(&edev->dev, "extcon%lu", From patchwork Wed Mar 22 14:39:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73477 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2383028wrt; Wed, 22 Mar 2023 07:51:39 -0700 (PDT) X-Google-Smtp-Source: AK7set8+HGI4SHtFPOEAIaltDL8zt6IM9GMZWGH6Nlw91DSDkebx8MeyvyDLHWVXpUa0BJMvDi6s X-Received: by 2002:a17:906:2b85:b0:92e:fcc9:aa22 with SMTP id m5-20020a1709062b8500b0092efcc9aa22mr2281469ejg.37.1679496699244; Wed, 22 Mar 2023 07:51:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679496699; cv=none; d=google.com; s=arc-20160816; b=pOoOtX/hR9gx96bTlCiYAcLaIx8+3zPTH1K0rZOhM61KcTrhz+MAOglFiXHl1uNRNY KxXssl2r6ALkUidUH959SlE4zQQN+DD20dSptlKVNbqZRIjraCdRhgIv9ytHJ1ZKqeKt thS+1fs0vERMQJlCbpve+iCJ7XmxZ/u2mrnMpKLdFksvP7v4BmS1hRKaPhZ37+A/kgGB YN1O8n6/YvRWrOneH+Iuj+2LxpghbOYVO2Xuys+Q3BjK8ByTzWuSDLaIFaqt7WdKx2h4 q0izAjjKDcrAfwIs1iFreLBpFkHLttXSuhdvPNFI3fADETwr0y9psvDN7nAAgfzPGsla G9RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cchA4NSw0Z6iSaOxwzdCvIlM3QocONysQ9wdjiZdF4E=; b=Zd+2+RsTZB0Ovuv7qSqGqAMieyJn5xMbWUO2Gj4+l0tMh1p65Z27eCbcYtuvvPQ7Dj zJ1qzQtFeCZT15/l9oSQ7a/KhXG26YSy4i/nIqemmlfNCulcVxmmWEU6vYKr9dvAQAXA WzeFLNs5q+zUigl0DEFHSKNmatKbvSvc9htTKtAolDH7ARLpglwpKFpN5iWE7Hjfl4Ac O+xSL4IP23imiB+78NvcHPKC+ogtf/IsIt3zsZS58iz8Q1uJOYagn9cZo3KfwaKe9xbb UxjiC56VrDSBGc5TNAiI0Ej6lRUaDYRFeiaY6yse8DHy+Csc6/8Hbt1AawbZKgHJvbDN uQYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Rrj0Lom1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qb37-20020a1709077ea500b00932e8fe9cdasi10511707ejc.223.2023.03.22.07.51.16; Wed, 22 Mar 2023 07:51:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Rrj0Lom1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231608AbjCVOkF (ORCPT + 99 others); Wed, 22 Mar 2023 10:40:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231598AbjCVOjc (ORCPT ); Wed, 22 Mar 2023 10:39:32 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF7E75FA77 for ; Wed, 22 Mar 2023 07:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495966; x=1711031966; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ORQoLZf18v3gXDfH3BHmV5xqWMBNzteq8nwmowV0t7U=; b=Rrj0Lom1dUQX+g9uN5sc2dK2sm9MBMoTnpbb0NQAzQR3rQr2XRuN/jI4 t/P/6KGxY8EwZ1JIdgR2EUYPbNZYAoehAFYgnEVsn7uZQVoNgl3zeakcE d4ZcJaQengIH0eoeMf8Axr/ouzQfGAuZ9M4qsn0AjKGNe+LiGG1UNXvBG rZ61YXax5TAuoU+AlegkxVwUxGEQ3LDLa3cJVf7iCzcuAYqBVhx3tVHr9 0XbR59l/AvMBF/nqKmNaBygMAIf4wtaXpKHqlR5SVXV7ALtApY8nGQNr4 vYgug7sEdGZfrfrleOmioWFM3nQ/QViZR6rxyqoxC1Yktabln6EFaiZ1M w==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="319622132" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="319622132" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="856116429" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="856116429" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 22 Mar 2023 07:39:23 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id C9E437E5; Wed, 22 Mar 2023 16:40:06 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 07/14] extcon: Use unique number for the extcon device ID Date: Wed, 22 Mar 2023 16:39:58 +0200 Message-Id: <20230322144005.40368-8-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761079930697884467?= X-GMAIL-MSGID: =?utf-8?q?1761079930697884467?= The use of atomic variable is still racy when we do not control which device has been unregistered and there is a (theoretical) possibility of the overflow that may cause a duplicate extcon device ID number to be allocated next time a device is registered. Replace above mentioned approach by using IDA framework. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 15 ++++++++++++--- drivers/extcon/extcon.h | 2 ++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 14e66e21597f..0d261ec6c473 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -16,6 +16,7 @@ #include #include +#include #include #include #include @@ -238,6 +239,7 @@ struct extcon_cable { static struct class *extcon_class; +static DEFINE_IDA(extcon_dev_ids); static LIST_HEAD(extcon_dev_list); static DEFINE_MUTEX(extcon_dev_list_lock); @@ -1248,7 +1250,6 @@ static int extcon_alloc_groups(struct extcon_dev *edev) int extcon_dev_register(struct extcon_dev *edev) { int ret, index = 0; - static atomic_t edev_no = ATOMIC_INIT(-1); ret = create_extcon_class(); if (ret < 0) @@ -1275,8 +1276,14 @@ int extcon_dev_register(struct extcon_dev *edev) dev_err(&edev->dev, "extcon device name is null\n"); return -EINVAL; } - dev_set_name(&edev->dev, "extcon%lu", - (unsigned long)atomic_inc_return(&edev_no)); + + ret = ida_simple_get(&extcon_dev_ids, 0, INT_MAX, GFP_KERNEL); + if (ret < 0) + return ret; + + edev->id = ret; + + dev_set_name(&edev->dev, "extcon%d", edev->id); ret = extcon_alloc_cables(edev); if (ret < 0) @@ -1368,6 +1375,8 @@ void extcon_dev_unregister(struct extcon_dev *edev) return; } + ida_simple_remove(&extcon_dev_ids, edev->id); + device_unregister(&edev->dev); if (edev->mutually_exclusive && edev->max_supported) { diff --git a/drivers/extcon/extcon.h b/drivers/extcon/extcon.h index 15616446140d..877c0860e300 100644 --- a/drivers/extcon/extcon.h +++ b/drivers/extcon/extcon.h @@ -20,6 +20,7 @@ * {0x3, 0x6, 0x5, 0}. If it is {0xFFFFFFFF, 0}, there * can be no simultaneous connections. * @dev: Device of this extcon. + * @id: Unique device ID of this extcon. * @state: Attach/detach state of this extcon. Do not provide at * register-time. * @nh_all: Notifier for the state change events for all supported @@ -46,6 +47,7 @@ struct extcon_dev { /* Internal data. Please do not set. */ struct device dev; + int id; struct raw_notifier_head nh_all; struct raw_notifier_head *nh; struct list_head entry; From patchwork Wed Mar 22 14:39:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73468 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2378039wrt; Wed, 22 Mar 2023 07:41:04 -0700 (PDT) X-Google-Smtp-Source: AK7set+33gcKQK0ruixbeKgMtZnMLAgYz8Wu6cMajT3k2pb/LIt8md55QGyyaW7D1czJQ6nP1WTx X-Received: by 2002:aa7:cf8b:0:b0:4ad:7a9f:a9f0 with SMTP id z11-20020aa7cf8b000000b004ad7a9fa9f0mr7159496edx.22.1679496064600; Wed, 22 Mar 2023 07:41:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679496064; cv=none; d=google.com; s=arc-20160816; b=DwYXgTijkmSrRny9DhZmwHkLNtwCAunpU5rbFZWrGccLuJVZ/6/wu9O2eH24mUxccQ 68CACnGNhX1Turxot1O42nq9aNXTEhIufFN2OUycH1279nxEy16+I7ICPiWFu2NGyU2e 2XLbyKKP8U8PcgY8CnDK4mrfEwUn1EuBgh9XQ0groDXHfgkH3o1IVnT+EZwMIVUlq3hZ 8icnmoD9pN3xEcsjDtBelRUtQf/avBckwBBWcknUfabFeTeNMIoNPS/siYfdgnDaHqut 2CbIJ0mIfXI1+Y1lGIwEol35rtn84sb4TEfKczJkcKnTz5qXEk3ph6MvrY8iPWZUmkYh OHEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+R3v7bAg6fEFYkj85Mqjq1dH5D3g3MC7z13TrFJ5h9Q=; b=CWnrVPJzJW7k2X6ZvU26qpqHwneCduPBNbie/hMiHOxR8czifChwM6hi4/fcipNq6w wlIzpBD4kEp+y3qqGMe+Cq2Yt7g2bA/Lbgvkt8YEnqs2EjScYHgt22U6G1TggC/qPfYI 3WpKgTwW8YesIVJoELH6Aa/uOyPSJQYiM/zkL1Avfjg01rI7OGPPQnMfitRzle5gSk33 AC2Q6VuVhMZY9DmYlRI3S5IaNXZ5synwSPt2Nvowb524x48NEBAMi7/6lcW0ylEfO7ZA cRvw9bw6hWHXHnLD/JArJ5Ydyzlw26Tu0ycndL66sxD21nMzItYbZes0JjMcEMBvJPTE 6O+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="CIsnt/nm"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e21-20020a50fb95000000b004fb3426ea95si16631140edq.322.2023.03.22.07.40.41; Wed, 22 Mar 2023 07:41:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="CIsnt/nm"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231641AbjCVOjk (ORCPT + 99 others); Wed, 22 Mar 2023 10:39:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231422AbjCVOjZ (ORCPT ); Wed, 22 Mar 2023 10:39:25 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0C2F410AB for ; Wed, 22 Mar 2023 07:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495964; x=1711031964; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fDzjemeuLsru23paImIk8ffwUuduPpzCedRvBa6jMLo=; b=CIsnt/nm5+QJXCD9nc11q3cm7138lGOzoMnEbLnN22aZWxHTOan7ZDjs M0idP2ZoBF63gYNw6hln/xGZNcOLkny3vx2M+lB46sF60YAEFcIBYpSbn B4QE3TjJVCJ4wD0J8Hc/VVDA5lbo9qIatv1ESyKgSk5nv3Su+ryy72MMn VmDg71Km4tmsVsaXzXpf9NWR96zctRhQgeQogaE8oBFZugHz8mmeE8L5J JWCJP4s/Fr/hkMwJnRo0zZFySnB25cnA8W/kbeY5BRk/MHZBRk0cmm1GA beuxywqBbCW9ty9lRS7Q5bSmsDxjfAdx7GiX1h7XAjlhxE0yJ3/XUMMIr A==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="327609304" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="327609304" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="792579434" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="792579434" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 22 Mar 2023 07:39:22 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id CED2C3DD; Wed, 22 Mar 2023 16:40:06 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 08/14] extcon: Switch to use kasprintf_strarray() Date: Wed, 22 Mar 2023 16:39:59 +0200 Message-Id: <20230322144005.40368-9-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761079265458784182?= X-GMAIL-MSGID: =?utf-8?q?1761079265458784182?= Since we have a generic helper, switch the module to use it. No functional change intended. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 25 +++++++++++-------------- drivers/extcon/extcon.h | 1 + 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 0d261ec6c473..a63e7eef02fd 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include "extcon.h" @@ -1104,19 +1105,17 @@ static int extcon_alloc_cables(struct extcon_dev *edev) if (!edev->cables) return -ENOMEM; + edev->cable_names = kasprintf_strarray(GFP_KERNEL, "cable", edev->max_supported); + if (!edev->cable_names) { + kfree(edev->cables); + return -ENOMEM; + } + for (index = 0; index < edev->max_supported; index++) { cable = &edev->cables[index]; - str = kasprintf(GFP_KERNEL, "cable.%d", index); - if (!str) { - for (index--; index >= 0; index--) { - cable = &edev->cables[index]; - kfree(cable->attr_g.name); - } - - kfree(edev->cables); - return -ENOMEM; - } + str = edev->cable_names[index]; + strreplace(str, '-', '.'); cable->edev = edev; cable->cable_index = index; @@ -1341,8 +1340,7 @@ int extcon_dev_register(struct extcon_dev *edev) kfree(edev->attrs_muex); } err_alloc_muex: - for (index = 0; index < edev->max_supported; index++) - kfree(edev->cables[index].attr_g.name); + kfree_strarray(edev->cable_names, edev->max_supported); if (edev->max_supported) kfree(edev->cables); err_alloc_cables: @@ -1387,8 +1385,7 @@ void extcon_dev_unregister(struct extcon_dev *edev) kfree(edev->attrs_muex); } - for (index = 0; index < edev->max_supported; index++) - kfree(edev->cables[index].attr_g.name); + kfree_strarray(edev->cable_names, edev->max_supported); if (edev->max_supported) { kfree(edev->extcon_dev_type.groups); diff --git a/drivers/extcon/extcon.h b/drivers/extcon/extcon.h index 877c0860e300..5624f65ba17a 100644 --- a/drivers/extcon/extcon.h +++ b/drivers/extcon/extcon.h @@ -58,6 +58,7 @@ struct extcon_dev { /* /sys/class/extcon/.../cable.n/... */ struct device_type extcon_dev_type; struct extcon_cable *cables; + char **cable_names; /* /sys/class/extcon/.../mutually_exclusive/... */ struct attribute_group attr_g_muex; From patchwork Wed Mar 22 14:40:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73480 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2385686wrt; Wed, 22 Mar 2023 07:57:55 -0700 (PDT) X-Google-Smtp-Source: AK7set93JkTexzBBv60sqHt/8aKCSIzG7Ocyqvp5kpiPCSnvLadfBLtb92z4fgMB77LbtR2/Bxjw X-Received: by 2002:a17:902:e5d2:b0:1a1:956e:542f with SMTP id u18-20020a170902e5d200b001a1956e542fmr4329923plf.19.1679497074980; Wed, 22 Mar 2023 07:57:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679497074; cv=none; d=google.com; s=arc-20160816; b=awf6opGC9VHwteJFq8PmATgFnXKCnMKnxJbb9+h/5S+3XDFWFseCBolOo5xe7Ycvvj XgNA4hQZRiQYEgym0cfq/5XnCIo17RiPujXfDZsakZgRC2+9/wUoZ8JNF5/zg4dx+vXH UVM/kqE8JWKJqxU6ZycV8ockX1Uuvcz9olxmWqx0vlzsX9HHuziUDT33eA874Alycn57 C8GXAHxtX/xpvT/88XNaXQRGFjfQbuktlJDN0DR2kdZAywsiuBVnUZYKIg0s1AFSJT1C a4TPYB6QyiUhfrMj/Ay7ge4guQBEUcsYrPVIGmA8aFL6t4eV8GomBBTHAwsRsP47n3/Z IXHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GFuii4LK+PS1es5BlUpPnZswq1TNrIz0rvrhOg0mB5w=; b=Cb4qkQjwntiD92bMHWuZiJMrL09fqu9NXhjofBpwDI8LhFEBqcmgWMuPQFeOX+qrKe 1OGLFCa/Y1+0ESFCwWd3/wbIkIUB+JleSugVEWqIsznvlHAxJpfRyJM6Zb1SUmPynK7N VN5jHxL9gol6FmTB6bpXrZXV4TcELZ5YQH+A+tApUmfhLUABS++xPiTgzqZ9Qs4+0mVv j7IE86vhklCnI6IV4/wecXOM4X/xnDeFx2yI7pRmnSRC44qKC3jhopqrYu8MNvMZVgvh uqNkoTOrARCsrLXxV9DMsNsy247umuKZ7/MUOVxgFWRovykm64kebHUZr5oj8JScUF60 bFpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WTC5LQ6u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l11-20020a170903244b00b001a0403b77c9si18222156pls.42.2023.03.22.07.57.16; Wed, 22 Mar 2023 07:57:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WTC5LQ6u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231678AbjCVOjq (ORCPT + 99 others); Wed, 22 Mar 2023 10:39:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231515AbjCVOj0 (ORCPT ); Wed, 22 Mar 2023 10:39:26 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7B31457C6 for ; Wed, 22 Mar 2023 07:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495964; x=1711031964; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=N33rpjnGQ5ytOuxHzIh25HaIghid6HPaz5R86OU5umw=; b=WTC5LQ6u9ge+YN+DIcNShgymbnWsvNdtEw9GiVHte+8uBX/2q2WxSo5G nnLDpfaXTGtKl26N8p5OJBlQ8HVOPgE6dAQzTHN+WW5LzTIPyBdHjUEzm iMQF8PoU3KImUfQe3kjDGqFua0FwhVn4y6pdo0BR141jJVQovlIxBzfDu q6I1LqpJmBaUPSpTLjdwC1khnRFIZmrkl0GE+YAcZgccMiLOcemYrvAQV yVS2hkQiy8H1WsgrRJ2JFf32FzzTZZ+luPW/RXdimMLHqZu/McllacfIz p2VFO+s5rJwOFVz6bFI+5x0PMcxR2e9v63cnqni9J1bM+wBDQW/tgd0AW Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="319622124" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="319622124" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="856116427" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="856116427" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 22 Mar 2023 07:39:23 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id DE874942; Wed, 22 Mar 2023 16:40:06 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 09/14] extcon: Use device_match_of_node() helper Date: Wed, 22 Mar 2023 16:40:00 +0200 Message-Id: <20230322144005.40368-10-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761080324810027325?= X-GMAIL-MSGID: =?utf-8?q?1761080324810027325?= Instead of open coding, use device_match_of_node() helper. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index a63e7eef02fd..5cadbfc151e6 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1411,7 +1411,7 @@ struct extcon_dev *extcon_find_edev_by_node(struct device_node *node) mutex_lock(&extcon_dev_list_lock); list_for_each_entry(edev, &extcon_dev_list, entry) - if (edev->dev.parent && edev->dev.parent->of_node == node) + if (edev->dev.parent && device_match_of_node(edev->dev.parent, node)) goto out; edev = ERR_PTR(-EPROBE_DEFER); out: From patchwork Wed Mar 22 14:40:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73487 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2388833wrt; Wed, 22 Mar 2023 08:03:02 -0700 (PDT) X-Google-Smtp-Source: AK7set9DgTxxJXeM3Qxhos+UurkdCh3BxmWgM9nJFk83WdBE0sEfwZ5yz32SiMigu5VlDW0dmayy X-Received: by 2002:a62:2986:0:b0:5e6:14a9:b0c8 with SMTP id p128-20020a622986000000b005e614a9b0c8mr2406176pfp.32.1679497381941; Wed, 22 Mar 2023 08:03:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679497381; cv=none; d=google.com; s=arc-20160816; b=d7l4CTRk2ij5RqXFnc4v//d6tuvsjHCmBKHjQXGufpOYGUWI1oJPcGj0+tcO8gStO7 yIf3gBwoZ5RNh3BjPYqnjU2pF7K8dCrwWKwMLUAsOME9FnHBPAk2hDROVHnGjLzHHJVq dI6cvPHaljKU7WxfLnKRvztm8d3/f7r+TAJS8D78pzE+bOilmjI7mKXUGHIaTPXFfM6X +tt2Vbblj35xzn/tOXgacjs5eW4RollFo6NWUoH0HTS2nUftutt6fWrKt104m3rfpclN s03SH+D0KWSA6YUvmGzOCLfJTHUETxcIehckNHu0m/bhuZLK2HT8jq4EIJqVEzEyP/cY yX0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rxr4jDj5cYahu2Zgxpqj1s0vLFN49sU0zzxRIJpT5w8=; b=tvm1Jy0bHKyGoFb1oLzjjZ1OhQ8rxW+GZ1YdUjhwdU+hqRjYUBi9Sg7eOcdE+ZzQGD UfuagyX1WtRT4kFAxlFfhndanywgmbxqDdVOWuaxPArRrQ9GT+R+WzeBTlUXQ8ojJfEh JBQ/Y8dPh0dAROuy2K+mDNWDVVWqz1XKdfErDlmpEXp+UO2GXxTBbuHxQ0f17/+Zjzx3 bkXDXKMvp80uP8po2Uqc/LfwiFp5P5qVChSpH0EPJKx88PIoPb6RFjlg+ptF3AFadMSL fUQmcisBmM3Mce9ZR1C+C4pgWO6LeMOcA3qqbcL9emwp3KuB1nQi+JePCVGVBoO6lAO3 44Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BtBtGPs4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g21-20020a056a000b9500b00627e2692fb0si13052231pfj.16.2023.03.22.08.02.45; Wed, 22 Mar 2023 08:03:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BtBtGPs4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231743AbjCVOjw (ORCPT + 99 others); Wed, 22 Mar 2023 10:39:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231523AbjCVOj0 (ORCPT ); Wed, 22 Mar 2023 10:39:26 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F00EC51CAD for ; Wed, 22 Mar 2023 07:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495965; x=1711031965; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CBCCxTTZs2kCb/p6GUvHy/Ipc4yohpZu5RckL85FL+w=; b=BtBtGPs4sd8XAJa1/i4OUiCKPcb50n+ES0wsgzxtZ4rHVIbVvrEy/fFQ gLNfqal8bP0yjt6fBPlykacRnTtwDkVNjzhVLYWAkYhHRGB3xQQUVzsDJ hrt1UMohuWHwX2VONKn6QgmQjwrh23aJn0A/NFaN7CK0+/BA2u0IQBLHn 7sH0gS8GetdN04b7MtQmeYkDVjBx/wkst3Y/qD+nE7FrySS1iNmheoIgg YKZ0ne1L+LVgzE/Wa9mLd/uaMRNQj73HYyQsVUfyDLhZEKUiDILnYkj6p 5TQh13Awd8FnyzxzcfAQ4I0RdFWDx5GxkxQyaRhm9puFfmhG/z0AGLpoY g==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="327609306" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="327609306" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="792579435" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="792579435" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 22 Mar 2023 07:39:23 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id E3BC480A; Wed, 22 Mar 2023 16:40:06 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 10/14] extcon: use dev_of_node(dev) instead of dev->of_node Date: Wed, 22 Mar 2023 16:40:01 +0200 Message-Id: <20230322144005.40368-11-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761080647049498567?= X-GMAIL-MSGID: =?utf-8?q?1761080647049498567?= The dev_of_node function should be preferred. In the result we may drop unneeded NULL check of the pointer to the device object. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 5cadbfc151e6..32e96cb49067 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1429,21 +1429,17 @@ struct extcon_dev *extcon_find_edev_by_node(struct device_node *node) */ struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index) { - struct device_node *node; + struct device_node *node, *np = dev_of_node(dev); struct extcon_dev *edev; - if (!dev) - return ERR_PTR(-EINVAL); - - if (!dev->of_node) { + if (!np) { dev_dbg(dev, "device does not have a device node entry\n"); return ERR_PTR(-EINVAL); } - node = of_parse_phandle(dev->of_node, "extcon", index); + node = of_parse_phandle(np, "extcon", index); if (!node) { - dev_dbg(dev, "failed to get phandle in %pOF node\n", - dev->of_node); + dev_dbg(dev, "failed to get phandle in %pOF node\n", np); return ERR_PTR(-ENODEV); } From patchwork Wed Mar 22 14:40:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73485 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2388253wrt; Wed, 22 Mar 2023 08:02:16 -0700 (PDT) X-Google-Smtp-Source: AK7set8D143pNpuVC3r4/5dY0DPyxn6/u4RUz655tz3VSKaRsIxbREo2S+Cjr2yZW2ijlmMOW9ca X-Received: by 2002:a62:5542:0:b0:625:f983:3ddd with SMTP id j63-20020a625542000000b00625f9833dddmr3165320pfb.13.1679497335935; Wed, 22 Mar 2023 08:02:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679497335; cv=none; d=google.com; s=arc-20160816; b=vB7jHxqR/o6zo20z14x05zM9ZxC7D+UsuNDh+KljupR2YkOztzh4pBqYu1N/ozTRL3 FJ8yQkn1VwOgOOPZy0Eky6KVxoDYhKNvNsHm12lhnUJaFeXd2YHJb+zDEpY2lXFYrTYa evXpQKnfxQeLi/8ZNyTd6dbzSqlA2XfOX8BuXCllfM43AsgVw5I+M+yThzxVJKnXVydP sOQAfj3Y5TvPifxfO636xjHisPiCffweqO+t5h1xmXbqD9sMShGiAKrHoqDWqBDS4uru vEKlYgQ6WJytOA3oDgmrhrbfWNY4+8cMeFJ6DSOflSg+EaHQzvZOUuvZBNB9oDIiSJrk g9hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pZOkQbIqNGUGO+xUJweB/LDa/txykNJOU9ukuZ1HXg0=; b=EVEFjgkDApSvfBuhCr8JAFgH9KTELFVlWMx1k6Y2yGWjdQkIOrU8EI9DMr7Nb0ku8F o3cY6TRoOOa0tIAo22XmV7mZwGTatPRopK31+GAWpl56VjF1/mZz0zb8kzITIok0gbMA 3ots4dcXK6ZgS9HoBnFXhNtKIzxVohRrYjDRBvw5Gorb6eEtCkZ9J/pb6hYIP/nO1ZsF Ib1OI52kUeSDP2IWdrG8bJtHN2EYtSd78Ky02lHN62iNsg3Lr39CB154td0ZpbRM0+Nr AB9DKCiaoKY2Dh6hL5BI1sNqgW8w8Ua/+7HOjtxB967aBkxxtVHDgEaY1A7nBr11tvOr jIjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WLtfgnFv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q1-20020a056a00150100b00627debf9bd7si14491198pfu.233.2023.03.22.08.02.00; Wed, 22 Mar 2023 08:02:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WLtfgnFv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231547AbjCVOkC (ORCPT + 99 others); Wed, 22 Mar 2023 10:40:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231586AbjCVOj3 (ORCPT ); Wed, 22 Mar 2023 10:39:29 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F01E60417 for ; Wed, 22 Mar 2023 07:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495966; x=1711031966; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Nx51SpraYhWhakBAvwZOoAwXLoCLgSQssS6ASOeGoTw=; b=WLtfgnFvk61N0JK5V547On91RTdTA31k1wF8/e3Jg02z+E+9pI2/erlb ddtHevC4sNsdr5bkXNPjUEHFvxgBWoi+tiYKAittvbQ4QAHMChsvknlSf VQ/kb9UMqzEQEs7Cg5fqd7jNoHJZhS5ls0trZBC85jLvIhHVudHUlU0A3 t/d4mIitxyY4CaNtdG8sLlHsuBWVATgz8pDeZMAeZ+K6gPhaIQ8BUyo6z QdBYN23bWlXu/YPEUu5s565OtX3nr4+z5deG1tlo4XqQwo1KbH9RNH11f 5rKonsJERRpj8nu096/QlG6SWLdel8Xlh7KBAQAaJvVKrVq4PJHKyL1Dy g==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="319622135" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="319622135" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="856116431" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="856116431" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 22 Mar 2023 07:39:23 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id F2061A0D; Wed, 22 Mar 2023 16:40:06 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 11/14] extcon: Remove dup device name in the message and unneeded error check Date: Wed, 22 Mar 2023 16:40:02 +0200 Message-Id: <20230322144005.40368-12-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761080598788925190?= X-GMAIL-MSGID: =?utf-8?q?1761080598788925190?= The device name is already printed with dev_err(), no need to repeat. The device pointer itself is not supposed to be an error point, drop that check. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 32e96cb49067..0e04ea185c26 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1367,9 +1367,8 @@ void extcon_dev_unregister(struct extcon_dev *edev) list_del(&edev->entry); mutex_unlock(&extcon_dev_list_lock); - if (IS_ERR_OR_NULL(get_device(&edev->dev))) { - dev_err(&edev->dev, "Failed to unregister extcon_dev (%s)\n", - dev_name(&edev->dev)); + if (!get_device(&edev->dev)) { + dev_err(&edev->dev, "Failed to unregister extcon_dev\n"); return; } From patchwork Wed Mar 22 14:40:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73470 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2381819wrt; Wed, 22 Mar 2023 07:48:55 -0700 (PDT) X-Google-Smtp-Source: AK7set/ey/S++Q2RcLMLojqfQ1OCJxpNlCDY8RrPYJrqmvxT6mLnVelWLQ2QwapY7YyIDMGZdgjt X-Received: by 2002:a17:906:86d2:b0:933:444a:bbee with SMTP id j18-20020a17090686d200b00933444abbeemr7381744ejy.50.1679496535721; Wed, 22 Mar 2023 07:48:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679496535; cv=none; d=google.com; s=arc-20160816; b=gJ7alBLOaFo3P0jC57pqcSqQYWnTT/S3iylX/4Tf8TKEiI+lKay6Dziq6A6thP1/Co i4LDjsZQrqjo9/InuYWCCs/k9hZbpeu31EatJ6qW3vzcbIJoin78nLuKtwwTBZbbWxDR Nljz6pU9PmMKgAwPqMDs7awJo879iNVwk6nd8y7wIjkyhGx08QmTXJ3MppsCtvaUHClI /mMwuD0Qysn0SDwzuowUub5Guz1HEal2B6ahQeI6yq23lqEx+WwXMeIX8WEh7tDW3QLH DEEGji3KpgIoJlsCVSOC3DL3FC0T7iHoI5rOysFDLjbNFGcwwO7Qm54S5H8gVxIXYArr xmIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Hj6KVJaUBXCIad4JBKM+InWoEPk5fIMzKsSrMCFlY9k=; b=W6Bgv4NR28tq4bOabnb0AETcDV0cKqFxNlSA9vrzf53ojdJB2uT/QlJbCk9Nbvm/7c tWtJe2DwfL+CV/veXBxevEqKWtAE0g3iPQ8bBvPBtUD+fKh74CysW8os4C75adGXsWnl tRPeErp43nLGOYBztsFyPmAFSb+gLt/0ppRt1GBjkNFCiSEfIUt24ivPabyytF3a27/z +8JHd8GHybxX2/sqHvZ6rbqLbPqYOH+UY11ngQ/ZmKFxj4+c1nsAxESNgM7ETsHBIZNH ZPmcgVIEParyr2FJJ3muraulPOqK8uUN/OyoXwSu3lJGlNsUba0xYDFAAHQHoSWM+FZh T4Cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Tx2pAAeG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kx16-20020a170907775000b008c673be343dsi18354924ejc.612.2023.03.22.07.48.32; Wed, 22 Mar 2023 07:48:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Tx2pAAeG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231702AbjCVOjt (ORCPT + 99 others); Wed, 22 Mar 2023 10:39:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231531AbjCVOj0 (ORCPT ); Wed, 22 Mar 2023 10:39:26 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 530D6521ED for ; Wed, 22 Mar 2023 07:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495965; x=1711031965; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=XodOHskzLqB9GOrDUS/F5Kh8Lt/zUFltWrdOozMmc8c=; b=Tx2pAAeGQgygEUDmpnqScbs3EkjrnpC35XNYuL7aMZBU+771JiNo6G0U 2iupDvqhjbsFQ/JWqx8wngkuBQU7LhqkJCDUX9zIOByU3IPN4fyFotEi1 nEpPpSfC2v+SgA3BENqc6EjyJ3SeJAI8tfAthvHCN5/RgTIEH9s6w8KpR 8uKaicf8XtBM1o3uDo6YgBPQL7XcRTTKl1pUykedYy1yFeL5FrraIRkOQ /xeQoLZsKeyGZu1EFTOJAk2kkMRMolOh+LF560pfOLIazAIxQK0qQItCZ xFwtxsFyPKbQCjGnc4Y1Z3IjpZVLOYEZ0YbRI7IP0qXru+kKbzANoXOQQ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="327609307" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="327609307" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="792579436" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="792579436" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 22 Mar 2023 07:39:23 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 03630944; Wed, 22 Mar 2023 16:40:07 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 12/14] extcon: Use sizeof(*pointer) instead of sizeof(type) Date: Wed, 22 Mar 2023 16:40:03 +0200 Message-Id: <20230322144005.40368-13-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761079759383519724?= X-GMAIL-MSGID: =?utf-8?q?1761079759383519724?= It is preferred to use sizeof(*pointer) instead of sizeof(type). The type of the variable can change and one needs not change the former (unlike the latter). No functional change intended. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 0e04ea185c26..b3f038639cd6 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1099,9 +1099,7 @@ static int extcon_alloc_cables(struct extcon_dev *edev) if (!edev->max_supported) return 0; - edev->cables = kcalloc(edev->max_supported, - sizeof(struct extcon_cable), - GFP_KERNEL); + edev->cables = kcalloc(edev->max_supported, sizeof(*edev->cables), GFP_KERNEL); if (!edev->cables) return -ENOMEM; @@ -1160,14 +1158,12 @@ static int extcon_alloc_muex(struct extcon_dev *edev) for (index = 0; edev->mutually_exclusive[index]; index++) ; - edev->attrs_muex = kcalloc(index + 1, - sizeof(struct attribute *), + edev->attrs_muex = kcalloc(index + 1, sizeof(*edev->attrs_muex), GFP_KERNEL); if (!edev->attrs_muex) return -ENOMEM; - edev->d_attrs_muex = kcalloc(index, - sizeof(struct device_attribute), + edev->d_attrs_muex = kcalloc(index, sizeof(*edev->d_attrs_muex), GFP_KERNEL); if (!edev->d_attrs_muex) { kfree(edev->attrs_muex); @@ -1213,8 +1209,8 @@ static int extcon_alloc_groups(struct extcon_dev *edev) return 0; edev->extcon_dev_type.groups = kcalloc(edev->max_supported + 2, - sizeof(struct attribute_group *), - GFP_KERNEL); + sizeof(*edev->extcon_dev_type.groups), + GFP_KERNEL); if (!edev->extcon_dev_type.groups) return -ENOMEM; @@ -1298,8 +1294,7 @@ int extcon_dev_register(struct extcon_dev *edev) spin_lock_init(&edev->lock); if (edev->max_supported) { - edev->nh = kcalloc(edev->max_supported, sizeof(*edev->nh), - GFP_KERNEL); + edev->nh = kcalloc(edev->max_supported, sizeof(*edev->nh), GFP_KERNEL); if (!edev->nh) { ret = -ENOMEM; goto err_alloc_nh; From patchwork Wed Mar 22 14:40:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73479 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2384393wrt; Wed, 22 Mar 2023 07:54:58 -0700 (PDT) X-Google-Smtp-Source: AK7set8+gMCQLWFf8sBBhEO+duqZJ64DkuwZrIddvU9/iIrXtJw3CKpRdn0UpjeDWbw6SWJZ+0Ov X-Received: by 2002:a17:902:f548:b0:1a1:b238:d1ab with SMTP id h8-20020a170902f54800b001a1b238d1abmr3464162plf.69.1679496898604; Wed, 22 Mar 2023 07:54:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679496898; cv=none; d=google.com; s=arc-20160816; b=Ax+j4fzW3emQDKqc/nVski+IcToZEu82Mke6co+HlfE7IDXu/zj9cCINlUKlXe89AL xztql0XrX3UVeT8xfq6Nn/66atuZUkQyiO/pOmpYEmsYgOefvOXERl1pNlG9UyNFN16L 4VH2RN3tdJDYAFamNy4tR5uU2Tm903invxC8gpvq13XJUnWnk/bKZXTNEiaeBW+inEwQ 7yRGqxH5TCnGwXellijDd0BlNbTiBPipGguA6U1VI9qVOApEyb02snu0g3Ag4v8hO1gS ctD2qV+E090VmVXzk2OVRC+04udDfzmdgQYJpaDmpr+4CK5HFqaEt8VWohUoUIjENhBf ttmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SGiLeqHuw9hxmjqRqoh2WDTqMd6N0Pr4/Pdz6e/8Q3I=; b=r2k4o2xYwq5ZL936S0ycOuN/GguWW8JI6zZy0HtrcnYE3s8VrAD/ea8dO8JOD2CmDO wRfVmUCeC6pEpgkVsHRYJPsLaYQ4Vwn3dXWO24iJmjkXESBgYW+gqAxXyfh9j5ZEtxxC Kt5SBhQV7So60svad9qo59RhfltvGJORkXFwICvmtqWQHfaoi1chaStimz9Hlv2l/ho9 CwYMc48+R/KhFHTIvD9WF9Oy4A3LOin10sB5B5pt7xBmvW0IyePYTVN6x2bpW+SEnl2M i7YwoyZ9w4gqOcJGDs9CZKqf4sAO84oky/Rl0E4YEZ4xSZoX+Vt/vLY7FvuODUoJCvSm Qqaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YowXbGbE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i10-20020a63cd0a000000b00507281fb21fsi16255279pgg.557.2023.03.22.07.54.45; Wed, 22 Mar 2023 07:54:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YowXbGbE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231833AbjCVOj5 (ORCPT + 99 others); Wed, 22 Mar 2023 10:39:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231539AbjCVOj0 (ORCPT ); Wed, 22 Mar 2023 10:39:26 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE7B454C8D for ; Wed, 22 Mar 2023 07:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495965; x=1711031965; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=hoaAx9Ps+XUntb1eapTod1FMgNK7hAJfzIEXEA74T44=; b=YowXbGbEuwMX3f3a+dXoyeNhKZCY7RyzQ84gWM0B3rFMryNud0dY9XJD enltDkzUTVghWNzucsQ1nZZV9DXJTunY86/LCQAzZrPFssxp34j8BtYSP hprXPEsKev+DVovGO/SlklR0zO/7IcymTWTRbeTsSZvWDAYHM6256Ojf+ /mstvdtC3W7Siwh12wClIz8mL1zcldGBrabwD8h6LURdVEkudilGoFmVE ouhNNpuLp5edowb929o/ljdq9PH+4qxgMuod07GjqFQ+Let8X63LznfAe Zr08nYBufeFUct0RFY+usN+7ulDQVaC+YSGYyjGBWpYaPCc9N6yebTsdm g==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="319622128" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="319622128" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="856116428" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="856116428" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 22 Mar 2023 07:39:23 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 11EC0A53; Wed, 22 Mar 2023 16:40:07 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 13/14] extcon: Drop unneeded assignments Date: Wed, 22 Mar 2023 16:40:04 +0200 Message-Id: <20230322144005.40368-14-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761080139965270756?= X-GMAIL-MSGID: =?utf-8?q?1761080139965270756?= In one case the assignment is duplicative, in the other, it's better to move it into the loop — the user of it. Signed-off-by: Andy Shevchenko Acked-by: Chanwoo Choi --- drivers/extcon/extcon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index b3f038639cd6..edfa0450e605 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -246,7 +246,7 @@ static DEFINE_MUTEX(extcon_dev_list_lock); static int check_mutually_exclusive(struct extcon_dev *edev, u32 new_state) { - int i = 0; + int i; if (!edev->mutually_exclusive) return 0; @@ -1244,7 +1244,7 @@ static int extcon_alloc_groups(struct extcon_dev *edev) */ int extcon_dev_register(struct extcon_dev *edev) { - int ret, index = 0; + int ret, index; ret = create_extcon_class(); if (ret < 0) @@ -1253,7 +1253,7 @@ int extcon_dev_register(struct extcon_dev *edev) if (!edev || !edev->supported_cable) return -EINVAL; - for (; edev->supported_cable[index] != EXTCON_NONE; index++); + for (index = 0; edev->supported_cable[index] != EXTCON_NONE; index++); edev->max_supported = index; if (index > SUPPORTED_CABLE_MAX) { From patchwork Wed Mar 22 14:40:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73471 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2382008wrt; Wed, 22 Mar 2023 07:49:22 -0700 (PDT) X-Google-Smtp-Source: AK7set813QxPefX8yV3MAw6pVhshaoyVnpjurb+VNvZzvbDHhcLD/i7BYtoG04QiEKfb2UrZg4uM X-Received: by 2002:a17:906:c309:b0:932:da0d:96ac with SMTP id s9-20020a170906c30900b00932da0d96acmr6781966ejz.10.1679496562651; Wed, 22 Mar 2023 07:49:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679496562; cv=none; d=google.com; s=arc-20160816; b=Fvj8hLPwkb6wV657vwUUFquarCRyBtnoBGdvRrLmvtOX2PKNPZxnFPiZtzdq9PkMBl bFNsiUdV6V/B2opYLjI4CdbiBBTjCnJf08cXG8dXj3qTnTsvABby9cxKN01kRwLFI4JX Z8QVnx6Zdb/0t3NozPMpU0jwZc3cPGU4SnNIYrc/YrilFrI0Vg+yg1tnslbwCCUrL7nK qtW0QcWSGB99nrZbJFG85lHqd0dN/luNTJHsZYY6AvcXyI7oAWa9HfhgAyrhJvaaJnkx LYQYKD8Ui7XirVhLKGt6Trehu4rOX4PWG6B31hXV8wv6ihC3vBoPL3thtrkNq57ix2HN 0E5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6yfbHzPssHPoL9DiHarq5PV/wc1QHwbCO13Ib9SR9Os=; b=kdr9N1/6EfYDSuu8hWUpP/xj+elHHdNgQEXtIQQqtVzxqdZdPM3QUW04fAmmo5Ys5p E4uk7Px+nIA6eSzz9/5/gZVBf20zcVrAFwoHtrk/UsdLzzeuBE9zifXNugWXioGKY2IK CuZ5Z26W4Dc15FL809cEiWKuIGq/4dNUYCP3dF7IG44hH7rtXTK8rL7dCOgkq/4dH11h xvx4la15p90wXR3H7Zr6fcQT54gZyl2ni+PmSkxHz5WydoxuFsx/1ztdWPABLKcujJyr vbjNgp0El59slAh0z0Q1nnta3krLDVyWEhNyQvvor0GyamUk3jHu1jeSbk1gaV2iHq+e HWCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dH1tx7ZB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oz13-20020a1709077d8d00b00932eca9df07si15654967ejc.997.2023.03.22.07.48.59; Wed, 22 Mar 2023 07:49:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dH1tx7ZB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231859AbjCVOj7 (ORCPT + 99 others); Wed, 22 Mar 2023 10:39:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231560AbjCVOj2 (ORCPT ); Wed, 22 Mar 2023 10:39:28 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E5905FEAB for ; Wed, 22 Mar 2023 07:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495966; x=1711031966; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mmz2iv76okOwpVenPFn6EHP4R2cbAkp+w1ZBuPRcRrI=; b=dH1tx7ZBnq2ocjMA4zKKKcauKCfFH8/HAkCNBGktQ+hvVgIci7CZM8wj ro4I18u2BjVqcxFHLt33fjoJkLN9jbHkRHVD2UjN1aCzWhda4XcreuvjD DzhkAkAUSwbAJ00HuDXN30W4+ApgEnf5QEUT/pMdXCRAuB43Hhandf6gk 29ODE6UUbc3+IeuWDYsYGIo2V363zrf8laG7GbHw0Yb0YDdIU6trTAd2X V1pxrVmQooiusdk7l+4fnfJSCHezGePg27b61QJvBE3nWpQcwwE9OsOsE 0/4DMf9dYUlQTO5MafqNUC3naVHbQYosqIstiMp3N8lkZpV5g+AgzTTpC Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="319622131" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="319622131" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="856116430" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="856116430" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 22 Mar 2023 07:39:23 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 171C7A43; Wed, 22 Mar 2023 16:40:07 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 14/14] extcon: Use positive conditional in ternary operator Date: Wed, 22 Mar 2023 16:40:05 +0200 Message-Id: <20230322144005.40368-15-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761079787198408860?= X-GMAIL-MSGID: =?utf-8?q?1761079787198408860?= It's easier to parse by a human being the positive conditional. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index edfa0450e605..3e8522d522b4 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1466,7 +1466,7 @@ EXPORT_SYMBOL_GPL(extcon_get_edev_by_phandle); */ const char *extcon_get_edev_name(struct extcon_dev *edev) { - return !edev ? NULL : edev->name; + return edev ? edev->name : NULL; } EXPORT_SYMBOL_GPL(extcon_get_edev_name);