From patchwork Tue Mar 21 22:48:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 73102 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2048083wrt; Tue, 21 Mar 2023 15:48:15 -0700 (PDT) X-Google-Smtp-Source: AK7set8eS/5XTE6NEAA+ohU1Uh1NamLOEAEI3junfC9dSuGn6zOefYwzaz8ygEDsi0cZ3X15p+HW X-Received: by 2002:a17:906:5957:b0:92f:33ca:c9a3 with SMTP id g23-20020a170906595700b0092f33cac9a3mr5039884ejr.71.1679438895093; Tue, 21 Mar 2023 15:48:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679438895; cv=none; d=google.com; s=arc-20160816; b=hHf+rgkRbIDHdyWs8rty3y8a+XqN/G1ARmFkBr6XNwTuSVKR1GkMNa1OYkI1OGG9Mi m8xTtZX3oluo5qNcZXcSGVJDvl9ce+rVYqlsdFjENATSv8HZ9kBeTh0gbqdTpINBUC4M zgmd5d02ppGdOMkPRviEbRLoPLtRbQcCExoUXVGSjzpfrDjERL4+DOQOuHe97emF1Dnv ftSO2AbiPnJhBE1pK2Z0HyIOWxwuVyaV8c8o7Tat4bEpVrpbtyFnGjabBpQdlzMhVYi4 CrzOxgHAE3I53TPBcjzKyZgrYDlWu2kZK8DGMGhGgbN8B8cRWX5j6xMRCQIEfFB4kz1R cscg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=AVxNXnYPliFK5kf9hR6kEmYBAlrlXDXirb5EDXT6K9A=; b=pKUFDcI3KNg32gxg4C+PBs27tspwhCzbNuLSHVhtXBBgpC9VMT7E6smO+CVWGxGZua z6aN59BjAFocKr8BKG2396fHAYL1ENPZxc1mno6eX1Rm0lvQlE6SkRWvAZCZA+/TOUTC apKsfONLVXZwX3xUwGIhQzQ0RhGhYl4oVueLk9flzxFD9E8QjgqUEWxrmtYaTT6nbJBg /6q5h2l1nyHC3d4ALeyp66pxJG231cK1U/GnL7q+uuQ9yLkwziHgtiFz+g+TLnIORlr1 NylmAOob4cKBWSNJ1N+u2XJPmfO0tsa9upm/ouQJrGorJVILVyADzqqCHaYgJ/GCeCvV f2RA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="QnYz/rGf"; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id kv17-20020a17090778d100b00925bb64d9dcsi13173434ejc.448.2023.03.21.15.48.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 15:48:15 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="QnYz/rGf"; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 884FD385781F for ; Tue, 21 Mar 2023 22:48:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 884FD385781F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1679438893; bh=AVxNXnYPliFK5kf9hR6kEmYBAlrlXDXirb5EDXT6K9A=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=QnYz/rGfGNG8kO2aNosn6VTW6qV9nvoK7exat17AecDVFMeLuNPw4kBaOIu3g6Uz2 +vAKeLDnYiQV5b17QgQHoQ3rM0H8++UH0B3dfU6ce7Vt5OvoDgyNXM4e+yelQP5ajB av3cSZHTZ7qBaqJoEICAfcEjWTbqxZBQcK0k001E= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id 1A76C3858436 for ; Tue, 21 Mar 2023 22:48:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A76C3858436 Received: by mail-pj1-x1033.google.com with SMTP id h12-20020a17090aea8c00b0023d1311fab3so17431906pjz.1 for ; Tue, 21 Mar 2023 15:48:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679438884; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AVxNXnYPliFK5kf9hR6kEmYBAlrlXDXirb5EDXT6K9A=; b=3SHZnNBaF8Re7MD5VEVKWJUrY2SkxJV28jQ18l+/oLCIzogiHq8XCyWODshkHA39Rs qm6/QMfSviXLH4ejf0l2Mod57B+7HdyWrILgEI3sO8WzO3B2WTUhLykgAJX7HgXADerp JugnsnSpmJl+EisAC/0hvcq8dSYeWLB7EPu97jlEypO/EO0I/agBqGq5GEiThLNhNiHi MbQa4Kym9N9NIPSdPpYMehdXbbg3LVs4b9ukSLlJwv4ybD9gD4PyXlUOo2FOs3aRz8NX TibSJBefJ5Rz1lcbZehdjEZK1UrqapoOr/OUvrHkFHdGq3e2JarMkk4Keky0082FmeC8 1fJg== X-Gm-Message-State: AO0yUKU8+KfhcCuXPuV7WjeJSkdJhkviiFxtn8G9YpmHieodCNVKenoO vAFyioLY3N3OFA9zS6oMPs0NungIhgA= X-Received: by 2002:a17:902:c94b:b0:1a0:65d3:bae4 with SMTP id i11-20020a170902c94b00b001a065d3bae4mr768038pla.38.1679438883972; Tue, 21 Mar 2023 15:48:03 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id 12-20020a170902c10c00b001993a1fce7bsm9231692pli.196.2023.03.21.15.48.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 15:48:03 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 9B5CE114267F; Wed, 22 Mar 2023 09:18:01 +1030 (ACDT) Date: Wed, 22 Mar 2023 09:18:01 +1030 To: binutils@sourceware.org Subject: Sanity check coff-sh and coff-mcore sym string offset Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3035.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761019318870042506?= X-GMAIL-MSGID: =?utf-8?q?1761019318870042506?= * coff-mcore.c (coff_mcore_relocate_section): Sanity check sym string offset when setting up name for use by error messages. * coff-sh.c (sh_relocate_section): Likewise. diff --git a/bfd/coff-mcore.c b/bfd/coff-mcore.c index e360d5efe14..96a1c9d44bc 100644 --- a/bfd/coff-mcore.c +++ b/bfd/coff-mcore.c @@ -434,7 +434,13 @@ coff_mcore_relocate_section (bfd * output_bfd, my_name = "*unknown*"; else if ( sym->_n._n_n._n_zeroes == 0 && sym->_n._n_n._n_offset != 0) - my_name = obj_coff_strings (input_bfd) + sym->_n._n_n._n_offset; + { + if (sym->_n._n_n._n_offset < obj_coff_strings_len (input_bfd)) + my_name = (obj_coff_strings (input_bfd) + + sym->_n._n_n._n_offset); + else + my_name = "?"; + } else { strncpy (buf, sym->_n._n_name, SYMNMLEN); diff --git a/bfd/coff-sh.c b/bfd/coff-sh.c index 50e9043993b..14f502e3638 100644 --- a/bfd/coff-sh.c +++ b/bfd/coff-sh.c @@ -2866,7 +2866,12 @@ sh_relocate_section (bfd *output_bfd ATTRIBUTE_UNUSED, name = NULL; else if (sym->_n._n_n._n_zeroes == 0 && sym->_n._n_n._n_offset != 0) - name = obj_coff_strings (input_bfd) + sym->_n._n_n._n_offset; + { + if (sym->_n._n_n._n_offset < obj_coff_strings_len (input_bfd)) + name = obj_coff_strings (input_bfd) + sym->_n._n_n._n_offset; + else + name = "?"; + } else { strncpy (buf, sym->_n._n_name, SYMNMLEN);