From patchwork Mon Mar 20 14:54:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 72214 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp1288417wrt; Mon, 20 Mar 2023 08:46:50 -0700 (PDT) X-Google-Smtp-Source: AK7set+Vw4awvL3EZ3PPYtr7OIXUGst+QDniHV4oUTCw15Vgnm1kuG4leMuEvuFB8wf/nZWWpOS0 X-Received: by 2002:a05:6a20:66a4:b0:d9:3e8a:dc4b with SMTP id o36-20020a056a2066a400b000d93e8adc4bmr5313157pzh.28.1679327209674; Mon, 20 Mar 2023 08:46:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679327209; cv=none; d=google.com; s=arc-20160816; b=cvBmf9OmBhUlzoVpqavb9aEYZfWCJq8t0boQ7QTFQCRT0CTxE4WRUGKNiv8NrfkGPm kxR6X0zRq10ObfknK1Uz6nL9H8J3lH4bb09k/Xj5L16MGsc1zvoiTjic5+5NpeKtGMd2 bzWnQcHEqKVIC3cIatVa+sqm/aavM19rOz9+e0WOcnrDLbKkYssgk02ilejx0sTf/S3j TbHQ6BkLJnA2Bt/ljCASMvLZ/MJ7hSxZb8NXq67Mty+Q82fSV1NHVElngLQtJYwfJC7h CmIK1behNsqdsmR595yViTqc/Vs4KdmOtUSlvr2Q6m64uZ6Kua+VmGqDKis1wBURUSAs qKnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UhiCEuJBrKQI/J7v1hz+Q/uHyRgvSDl9Ip3pKONGe5A=; b=G1qKeEI3psidAn69HvNi2XvGl8rbqRAf+mCfwGJX079qfnszZU36MYnQ9dKOyV4PI7 TCSgXoo1KJ5AGo2ELey7y6pcIlkccrVyY4XuQdeytXe87GmKdc2xUelxJYLcJBx+JKIk lO4RoYTJXHxd3Bouchecyi6rEAIqfqfRkNIJWeryM+eJodl6Zms9Xfl+gl1jDM1oJfC/ qci7Gn0LIWhJYVMmKX7IUWErrGeYa5Z5Joc4MXKhlYVkhZ9ixEXGwpu8A1Pl2qmyC7H9 5n0q3VpJfX8P2RkkwQsI6h3+XwAcvYeWL9sPNQK+cN8jKtjgkDc7lQFM5FLJS91zxoMN BlMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FRZcPf5O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t126-20020a635f84000000b0050be565b856si10934500pgb.685.2023.03.20.08.46.26; Mon, 20 Mar 2023 08:46:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FRZcPf5O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233118AbjCTPco (ORCPT + 99 others); Mon, 20 Mar 2023 11:32:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232934AbjCTPcX (ORCPT ); Mon, 20 Mar 2023 11:32:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7A9E18A97; Mon, 20 Mar 2023 08:25:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B1DEA61598; Mon, 20 Mar 2023 15:25:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE609C4339B; Mon, 20 Mar 2023 15:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1679325907; bh=whCBsYSpfT8Fg3mVeUSV+UNbIi6U/xFKJGj1jZAxL8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FRZcPf5OXSSOo7YbKGvsO0hLcX+lfaSCxqW0D8WtQ6uC2AiNFnVZyCs2KWg+Cehca TexMr5Fw7XAAR2mNNuiUlYXYDSggBvnfYoPZ6bnwkX6ItOrZQD6p8PwCvV9Z6FhSnf BDbiNdkpzWQcAo3iJCVrphxa6ln26fWbPbQ95hLA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Roman Gushchin , Amit Sunil Dhamne , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 6.2 123/211] firmware: xilinx: dont make a sleepable memory allocation from an atomic context Date: Mon, 20 Mar 2023 15:54:18 +0100 Message-Id: <20230320145518.517445672@linuxfoundation.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230320145513.305686421@linuxfoundation.org> References: <20230320145513.305686421@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760902208027800699?= X-GMAIL-MSGID: =?utf-8?q?1760902208027800699?= From: Roman Gushchin commit 38ed310c22e7a0fc978b1f8292136a4a4a8b3051 upstream. The following issue was discovered using lockdep: [ 6.691371] BUG: sleeping function called from invalid context at include/linux/sched/mm.h:209 [ 6.694602] in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 1, name: swapper/0 [ 6.702431] 2 locks held by swapper/0/1: [ 6.706300] #0: ffffff8800f6f188 (&dev->mutex){....}-{3:3}, at: __device_driver_lock+0x4c/0x90 [ 6.714900] #1: ffffffc009a2abb8 (enable_lock){....}-{2:2}, at: clk_enable_lock+0x4c/0x140 [ 6.723156] irq event stamp: 304030 [ 6.726596] hardirqs last enabled at (304029): [] _raw_spin_unlock_irqrestore+0xc0/0xd0 [ 6.736142] hardirqs last disabled at (304030): [] clk_enable_lock+0xfc/0x140 [ 6.744742] softirqs last enabled at (303958): [] _stext+0x4f0/0x894 [ 6.752655] softirqs last disabled at (303951): [] irq_exit+0x238/0x280 [ 6.760744] CPU: 1 PID: 1 Comm: swapper/0 Tainted: G U 5.15.36 #2 [ 6.768048] Hardware name: xlnx,zynqmp (DT) [ 6.772179] Call trace: [ 6.774584] dump_backtrace+0x0/0x300 [ 6.778197] show_stack+0x18/0x30 [ 6.781465] dump_stack_lvl+0xb8/0xec [ 6.785077] dump_stack+0x1c/0x38 [ 6.788345] ___might_sleep+0x1a8/0x2a0 [ 6.792129] __might_sleep+0x6c/0xd0 [ 6.795655] kmem_cache_alloc_trace+0x270/0x3d0 [ 6.800127] do_feature_check_call+0x100/0x220 [ 6.804513] zynqmp_pm_invoke_fn+0x8c/0xb0 [ 6.808555] zynqmp_pm_clock_getstate+0x90/0xe0 [ 6.813027] zynqmp_pll_is_enabled+0x8c/0x120 [ 6.817327] zynqmp_pll_enable+0x38/0xc0 [ 6.821197] clk_core_enable+0x144/0x400 [ 6.825067] clk_core_enable+0xd4/0x400 [ 6.828851] clk_core_enable+0xd4/0x400 [ 6.832635] clk_core_enable+0xd4/0x400 [ 6.836419] clk_core_enable+0xd4/0x400 [ 6.840203] clk_core_enable+0xd4/0x400 [ 6.843987] clk_core_enable+0xd4/0x400 [ 6.847771] clk_core_enable+0xd4/0x400 [ 6.851555] clk_core_enable_lock+0x24/0x50 [ 6.855683] clk_enable+0x24/0x40 [ 6.858952] fclk_probe+0x84/0xf0 [ 6.862220] platform_probe+0x8c/0x110 [ 6.865918] really_probe+0x110/0x5f0 [ 6.869530] __driver_probe_device+0xcc/0x210 [ 6.873830] driver_probe_device+0x64/0x140 [ 6.877958] __driver_attach+0x114/0x1f0 [ 6.881828] bus_for_each_dev+0xe8/0x160 [ 6.885698] driver_attach+0x34/0x50 [ 6.889224] bus_add_driver+0x228/0x300 [ 6.893008] driver_register+0xc0/0x1e0 [ 6.896792] __platform_driver_register+0x44/0x60 [ 6.901436] fclk_driver_init+0x1c/0x28 [ 6.905220] do_one_initcall+0x104/0x590 [ 6.909091] kernel_init_freeable+0x254/0x2bc [ 6.913390] kernel_init+0x24/0x130 [ 6.916831] ret_from_fork+0x10/0x20 Fix it by passing the GFP_ATOMIC gfp flag for the corresponding memory allocation. Fixes: acfdd18591ea ("firmware: xilinx: Use hash-table for api feature check") Cc: stable Signed-off-by: Roman Gushchin Cc: Amit Sunil Dhamne Cc: Michal Simek Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Link: https://lore.kernel.org/r/20230308222602.123866-1-roman.gushchin@linux.dev Signed-off-by: Greg Kroah-Hartman --- drivers/firmware/xilinx/zynqmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/firmware/xilinx/zynqmp.c +++ b/drivers/firmware/xilinx/zynqmp.c @@ -206,7 +206,7 @@ static int do_feature_check_call(const u } /* Add new entry if not present */ - feature_data = kmalloc(sizeof(*feature_data), GFP_KERNEL); + feature_data = kmalloc(sizeof(*feature_data), GFP_ATOMIC); if (!feature_data) return -ENOMEM;