From patchwork Mon Mar 20 13:42:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abel Vesa X-Patchwork-Id: 72171 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp1231462wrt; Mon, 20 Mar 2023 06:59:51 -0700 (PDT) X-Google-Smtp-Source: AK7set9Jbq3Br4DMGot68X2maBf+EslM/TFkLblPBOPnHGlwKXQWw9FS2cklOlx/Tt6pvnc7Neib X-Received: by 2002:a17:902:dad1:b0:19f:36b1:c35 with SMTP id q17-20020a170902dad100b0019f36b10c35mr21554288plx.64.1679320791559; Mon, 20 Mar 2023 06:59:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679320791; cv=none; d=google.com; s=arc-20160816; b=kVyhSbw+z+RsrGqBCTRwKyTWFxhupJK1jvwmzEMvLPkO7aAbvvWv00QoerWvvnPQZf bPXbZb09VBxCY3BAuFmyBMRQ1JP8XziTdRR+Ghhqk+oBJkJpLgiJqB+Vflif7LW1I52K iP8usVTzr3ogzbRpBFI7RZoivH5DT5TGh23eXtNB42Xhg2FzkiamORuZnLQB7k82s0wG Zd7vKhznzwx2VitzDc2tOXMth1KQc/2jsZ1ic2bj1fpEs0HKp0dEfsBFmvLevzHuOC5Q 6QLMyilWhkVyYtLUi4oa0LbiHcOakR4LhVPfmmenAleyjXo7ab75CQz9aFahGLkgUKO3 GUJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wjKiN0F5wVydodH1DdUegjCL8bujRKxDngFdNV9Cs2c=; b=kTEvfl1NbUDrrCJePo+NRlkyYphETXDD3vziLahYDBpzOsCwZ+yGUPN/7mvdD26Ubl hb+TU6z58UqbQFuJkKBaEM1SLWvXl0vOiBO5/GgpL9qMNb3nhnUlCPGwcSrIgw+zohAz crju381mz7zSA++JqLOoWyncnuSdDNxAZzzmWhWKdQZzerXYrMK+M6uvybawwn1/7COa ck7c7RooAMsbypwOC3DkkIfz33Hbpl9wV71QNWsAUDyB2ZHk31t2qRvnWWh6gJEAgEyb j/MVNdaA4YxChbw6J3RJAOOZWrjCtsFBdVu6a+P7+Wg+FedTPSSLBdRY5pT4jReZIhdd rqgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CDVGNXBP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l9-20020a17090270c900b001a1ba07911bsi6201447plt.530.2023.03.20.06.59.36; Mon, 20 Mar 2023 06:59:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CDVGNXBP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231723AbjCTNmp (ORCPT + 99 others); Mon, 20 Mar 2023 09:42:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231287AbjCTNma (ORCPT ); Mon, 20 Mar 2023 09:42:30 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D82DBDC9 for ; Mon, 20 Mar 2023 06:42:27 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id eh3so46846060edb.11 for ; Mon, 20 Mar 2023 06:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679319745; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wjKiN0F5wVydodH1DdUegjCL8bujRKxDngFdNV9Cs2c=; b=CDVGNXBPBN3zdUl7FjlFIv2E0h2geCNhMI1PP8HGrSgTs+BJuRsvUQ8kKvW/9nHD6N ow11RnoeG6AyipGzzUF/lO2TgVbEawbgTLBNGTuFejZWb9xACrAOTxT0Pc+DyojUHoQj z6XSF+lwJMKFBd7D22ZkGy7V0IY7K+0c1K3HQzE2X+WVa7wCm1IXg4yUc2lPx8QODOc3 mS04vNuhq8CkG3cvPfStcuTLNmf7zvbJHoA98VNoLA4Ehm4wvwJ9NS5qSTVeudyu4MSB 3XpH2Aq0TssgKopj8KOSAqljUq6V79aGyWyrfVrfP4Q0Gl5ncE9tOmeL9rZtZSNVqcba ZPrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679319745; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wjKiN0F5wVydodH1DdUegjCL8bujRKxDngFdNV9Cs2c=; b=yxVH7C9dZXqTsTahZyaeuLu943NnwMx/vkiCzjpjiwyrEpjg37AT0j3csy+R5S2pok g0fEROZwQz9yqGZqYFHd+LfGm5zqbigcGyGvbWmF24Sk50BRCvwFisQFPw4Fcfjp+LYK s0mshy8BNoKwoKMSimP68p4yrfoK/s+Ls2E7pEAWnZAAwBX1Da9W1NYUvSK6g0RRefVx ANXu19FCqVEViZlRNtoAZp/YforsmuIfFQ3rT0nP8+WXd2nQphjCIm0I3CYho1LEe+M4 sG6DjF5oLtclWFDWdyxaSXAUmJ6PSc7vlSVWtVCKlJL8xW+xWZ/ds2SP4VKvkDwB1ZjQ XQUA== X-Gm-Message-State: AO0yUKW1mt2Y9HCKaqCuEABi/DhgF55XHjd9zzCe9GMcQ8B5Pp2RBcdI VVA6RcSibxnb+t/Zt9iO1BsXGg== X-Received: by 2002:a17:906:1e85:b0:931:1567:f84f with SMTP id e5-20020a1709061e8500b009311567f84fmr8266966ejj.4.1679319745664; Mon, 20 Mar 2023 06:42:25 -0700 (PDT) Received: from localhost.localdomain ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id u23-20020a170906409700b009334a6ef3e8sm2368602ejj.141.2023.03.20.06.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 06:42:25 -0700 (PDT) From: Abel Vesa To: "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Pavel Machek , Len Brown , Greg Kroah-Hartman , Bjorn Andersson , Andy Gross , Konrad Dybcio , Mike Turquette , Stephen Boyd , Saravana Kannan Cc: linux-pm@vger.kernel.org, Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, Doug Anderson , Matthias Kaehlcke Subject: [RFC PATCH v2 1/5] PM: domains: Allow power off queuing from providers Date: Mon, 20 Mar 2023 15:42:13 +0200 Message-Id: <20230320134217.1685781-2-abel.vesa@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230320134217.1685781-1-abel.vesa@linaro.org> References: <20230320134217.1685781-1-abel.vesa@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760895477998222405?= X-GMAIL-MSGID: =?utf-8?q?1760895477998222405?= In some cases, the providers might choose to refuse powering off some domains until all of the consumer have had a chance to probe, that is, until sync state callback has been called. Such providers might choose to disable such domains on their on, from the sync state callback. So, in order to do that, they need a way to queue up a power off request. Since the generic genpd already has such API, make that available to those providers. Signed-off-by: Abel Vesa --- drivers/base/power/domain.c | 3 ++- include/linux/pm_domain.h | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 32084e38b73d..97d4e2f2da91 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -649,10 +649,11 @@ static int _genpd_power_off(struct generic_pm_domain *genpd, bool timed) * Queue up the execution of genpd_power_off() unless it's already been done * before. */ -static void genpd_queue_power_off_work(struct generic_pm_domain *genpd) +void genpd_queue_power_off_work(struct generic_pm_domain *genpd) { queue_work(pm_wq, &genpd->power_off_work); } +EXPORT_SYMBOL_GPL(genpd_queue_power_off_work); /** * genpd_power_off - Remove power from a given PM domain. diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index f776fb93eaa0..f9729640f87e 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -231,6 +231,7 @@ int pm_genpd_remove_subdomain(struct generic_pm_domain *genpd, int pm_genpd_init(struct generic_pm_domain *genpd, struct dev_power_governor *gov, bool is_off); int pm_genpd_remove(struct generic_pm_domain *genpd); +void genpd_queue_power_off_work(struct generic_pm_domain *genpd); int dev_pm_genpd_set_performance_state(struct device *dev, unsigned int state); int dev_pm_genpd_add_notifier(struct device *dev, struct notifier_block *nb); int dev_pm_genpd_remove_notifier(struct device *dev); @@ -278,6 +279,11 @@ static inline int pm_genpd_remove(struct generic_pm_domain *genpd) return -EOPNOTSUPP; } +void genpd_queue_power_off_work(struct generic_pm_domain *genpd) +{ + return -EOPNOTSUPP; +} + static inline int dev_pm_genpd_set_performance_state(struct device *dev, unsigned int state) { From patchwork Mon Mar 20 13:42:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abel Vesa X-Patchwork-Id: 72168 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp1229682wrt; Mon, 20 Mar 2023 06:56:00 -0700 (PDT) X-Google-Smtp-Source: AK7set81buY5y8Je11tk95aRhpo1yMrIO4m+9xfKkfy6RPtjMy8mBpwa/+4Pij1e3WdgziugQ7xb X-Received: by 2002:a17:903:41c4:b0:19e:bc01:610e with SMTP id u4-20020a17090341c400b0019ebc01610emr23100452ple.33.1679320559777; Mon, 20 Mar 2023 06:55:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679320559; cv=none; d=google.com; s=arc-20160816; b=rpaaEMNhePl678pmr4IC7kwxBzOjXLBpQk4hncgJefp3Sq+UKPsbcr3sGYdJ4eWZh7 hvR5G0EWNIggYz4fBGQnIfNPYbVBEcH4+IpOnVJ0xKBAXdO/P1/LHbWi24ciwIcf1W3z kvJNGTIwM2y7MrmNe6zeKg71+C3HjpaV2nFMU4wLDHFTel5CArmPsnWAnxdzpTLgDc5a Z+XcXhhBaUSKc4SVRxgeQs9idOKCcQW2CQJEbbdVHj02ft/3uj1pSxtmrNxbVp9ka5dE SjUieA13fTtV7LXPH0kAwyBq/GCxwnqHrgyUJAG2xQHIrsMplCQbs17tB1zOGr4AIO50 Qvtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xQtrWDCM+22cQpzRRbVDJZjtR/eFtKTL53q6CUnjVrA=; b=Vua5nuSYKNz7i37DgiB6wLc3k9BjTyVzuvy/mWng13HjaS1zGWG1djVfuV0SxV0EGE Hg99MhpsBu93MsBKYabH4qMykQUS3+H3UEv8dLQl5yCgJdZ4OWoAKt0vNsEllHpZUM8c gle4UNJV56X5rGG6hZlvsnjTI3621jFfEE6ayblE4vPS6rZeGLahEZ8QQLNn4kpwEJJD o2Qu5Qiw6jD+R7DmEA2Wwd9928MyFJk6bGMtg/nuCj+sOWTLgqbj9ivC6X5HkGhcFoWd AU/+R6SJ5xDYJQi7I7y/wzwfL/ifCmL0+UVPCfEKnlYG7vxg8S2WURJNh0y75NDpZpoT wO1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m6WWdvyh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d5-20020a170902cec500b0019a7ef5e99fsi11575107plg.86.2023.03.20.06.55.43; Mon, 20 Mar 2023 06:55:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m6WWdvyh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231393AbjCTNmt (ORCPT + 99 others); Mon, 20 Mar 2023 09:42:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231443AbjCTNma (ORCPT ); Mon, 20 Mar 2023 09:42:30 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF7F9F742 for ; Mon, 20 Mar 2023 06:42:28 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id x3so46841183edb.10 for ; Mon, 20 Mar 2023 06:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679319747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xQtrWDCM+22cQpzRRbVDJZjtR/eFtKTL53q6CUnjVrA=; b=m6WWdvyhtAOPk/0OuJjnEg21hoMIbAVidJpiNn+dmHa6hrOTmwvVTWgmYoobYKk7bk YuXgKLPbT+avt/j0eZvscu00k3J1cPtSfbLKJ7kbnyCcGSGgVOh+yECsfSnJKybt4up8 kV/48kbVKfW8V7xGb9E0sW5ce44PrIUJVXiejhK4aTy/HZ/Bv8Vc+76SgxAEuYTqV5bq a8hciAQRZBC58PAUCewbgn8YnhSZwW1ZSq6P5VeUjicnDDbRkUs4NMKhXIxfqJUtXPL7 oSiNulSiYQll2eiuOheOcK904JTbsGuREE5VJTu16BWfiggbU5HS5zw9cQFyz41bo+me pPpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679319747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xQtrWDCM+22cQpzRRbVDJZjtR/eFtKTL53q6CUnjVrA=; b=iQjP0GeLhYw3HDu+lnvF3I4U0WIZZMZy+i5wtz5AXyG3kBC2POqcCV00qbziQnw8Jg rMvQN6PNAlhphXMeABkQHw0e4pK8wy6qfYrIAgxTeYJFkihSMt7T6z832MpK6dw/CJ5L jVixHas7IppHiIXMV1atmKdNjfoK012fYMp1FZO6oLeClxSTh6qHdmbbL8r44NUmFAlZ LfhxEQYwNXDIaN6GNuoloSWf2Ud9k+Z0zkhOnxa+9F46IcbVUAMVLjxJjN4tzawEcKYU U+1pBjLtasLqq5XOPhVoEd/fY9hGKiWpGKDYY98buBoz912R63lkgfJ/V9sFU4NwwYr2 tR4A== X-Gm-Message-State: AO0yUKV91UfMHWw1ajnOQaL67JhZmMTtm16Y2rQbx8izBitCe2Szb0eI G7vWiIjRLMCDoONTim5PTR60gQ== X-Received: by 2002:aa7:db83:0:b0:4fd:7f6f:3179 with SMTP id u3-20020aa7db83000000b004fd7f6f3179mr11830162edt.3.1679319747250; Mon, 20 Mar 2023 06:42:27 -0700 (PDT) Received: from localhost.localdomain ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id u23-20020a170906409700b009334a6ef3e8sm2368602ejj.141.2023.03.20.06.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 06:42:26 -0700 (PDT) From: Abel Vesa To: "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Pavel Machek , Len Brown , Greg Kroah-Hartman , Bjorn Andersson , Andy Gross , Konrad Dybcio , Mike Turquette , Stephen Boyd , Saravana Kannan Cc: linux-pm@vger.kernel.org, Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, Doug Anderson , Matthias Kaehlcke Subject: [RFC PATCH v2 2/5] soc: qcom: rpmhpd: Do proper power off when state synced Date: Mon, 20 Mar 2023 15:42:14 +0200 Message-Id: <20230320134217.1685781-3-abel.vesa@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230320134217.1685781-1-abel.vesa@linaro.org> References: <20230320134217.1685781-1-abel.vesa@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760895235395931420?= X-GMAIL-MSGID: =?utf-8?q?1760895235395931420?= Instead of aggregating different corner values on sync state callback, call the genpd API for queuing up the power off. This will also mark the domain as powered off in the debugfs genpd summary. Also, until sync state has been reached, return busy on power off request, in order to allow genpd core to know that the actual domain hasn't been powered of from the "disable unused" late initcall. Signed-off-by: Abel Vesa --- drivers/soc/qcom/rpmhpd.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c index f20e2a49a669..abd999c74783 100644 --- a/drivers/soc/qcom/rpmhpd.c +++ b/drivers/soc/qcom/rpmhpd.c @@ -649,8 +649,12 @@ static int rpmhpd_power_off(struct generic_pm_domain *domain) mutex_lock(&rpmhpd_lock); ret = rpmhpd_aggregate_corner(pd, 0); - if (!ret) - pd->enabled = false; + if (!ret) { + if (!pd->state_synced) + ret = -EBUSY; + else + pd->enabled = false; + } mutex_unlock(&rpmhpd_lock); @@ -810,10 +814,8 @@ static void rpmhpd_sync_state(struct device *dev) { const struct rpmhpd_desc *desc = of_device_get_match_data(dev); struct rpmhpd **rpmhpds = desc->rpmhpds; - unsigned int corner; struct rpmhpd *pd; unsigned int i; - int ret; mutex_lock(&rpmhpd_lock); for (i = 0; i < desc->num_pds; i++) { @@ -822,14 +824,7 @@ static void rpmhpd_sync_state(struct device *dev) continue; pd->state_synced = true; - if (pd->enabled) - corner = max(pd->corner, pd->enable_corner); - else - corner = 0; - - ret = rpmhpd_aggregate_corner(pd, corner); - if (ret) - dev_err(dev, "failed to sync %s\n", pd->res_name); + genpd_queue_power_off_work(&pd->pd); } mutex_unlock(&rpmhpd_lock); } From patchwork Mon Mar 20 13:42:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abel Vesa X-Patchwork-Id: 72169 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp1230383wrt; Mon, 20 Mar 2023 06:57:22 -0700 (PDT) X-Google-Smtp-Source: AK7set9txaFnP+DMsfIOOb/i2ksKONPQNMORhiMx/NGp0JvbiOBvXBPHp/0ZxSNmuyi2D7fRkCyS X-Received: by 2002:a17:903:4111:b0:19a:b6bf:1df6 with SMTP id r17-20020a170903411100b0019ab6bf1df6mr15211318pld.20.1679320641847; Mon, 20 Mar 2023 06:57:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679320641; cv=none; d=google.com; s=arc-20160816; b=x8jXyQHmoZFkKHVpxnpcUk3jiRJPrrWHi1SEE91vG9fbyyu5tG3LAmwB5bMI5qfqYo wQGdacoFyV8PT+rFmLbC/Z2wAuWmqM4eFXJXyMUEFT4W6YhWb3/Kec8gRtxB/bSHPmL+ gZ0Ov8WoYniqX/l0WnTOS3HlcG8/N/3eyzLYCPJ3KgRtsjMm//0EKvsRKbbmyE3kOdYS 5Bd34ApalYoisk42GERUDSKSJ23NGWTf012aauAXZ1mXxPqNAz/zX10V3uR2dCq/aXDw V8Ks+QP8kXzFLorChg+4JhTtKnSi5RdZXJNBUlY3+YzbImnHdooGndPx50h0sqmB84T0 OAYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HPUxYFnkGMoE5avSL4JFzjtLyBuUkiovE45vzPm5gIE=; b=Y/6c299RiBI/qhFdeMdqYtWcVtt9/DHFkzE9h/g4rPIFGu0jNE6Q8cOznQOow5WRa4 Pa1aBKaJU6UtKVTntsDRc1dKBYtmGBMolb2BUlicvulh4z3QTshCzTs92K+EoYV2imav obzZNUOabTOYslO8x3xiYnyKoLZH2lLf/w0O/m4SKPCWMFpJKYB8RLKEfEETv2tdqPvn 6jjzcqIy+ZqNjBakadHsefjFRSsTwpLWWEsVlz3wBuShiUkdrd27k1KRWOOC1t+KZltW 2+oifltZKXlU7Q9HCCkCBOFcH3A1QMWzPZx1A++I8DiTF9iH8IaCaj+FWVZY6yXOJtSr /jrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qDgGGZj4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o2-20020a63f142000000b004fb1c44a4d1si10145293pgk.212.2023.03.20.06.57.04; Mon, 20 Mar 2023 06:57:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qDgGGZj4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231772AbjCTNmx (ORCPT + 99 others); Mon, 20 Mar 2023 09:42:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231491AbjCTNmc (ORCPT ); Mon, 20 Mar 2023 09:42:32 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B76FCF97D for ; Mon, 20 Mar 2023 06:42:30 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id r11so46912239edd.5 for ; Mon, 20 Mar 2023 06:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679319749; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HPUxYFnkGMoE5avSL4JFzjtLyBuUkiovE45vzPm5gIE=; b=qDgGGZj4rTh9vnjkTHytvQnecNq3U/8RsnWgvn0sR57EYqL/Tk27hjcIYNMQMAfHcj Ly/dojV9xXN6PUxnU0zzDS4hqZ6OBxig+eFKGKlhvM9EJA92rLXvzCMFYbwAl1ZAwjZH BJ0JSiMmvmhHjUzIM6uiHD1xrCflH+W/dtwOlQSXt7+qMYN31DPIIlzuv7okpLvIrskM ioUKKh5/KOJhfNKWsQUeCvxtsp0VyOiJUBj6qgUzyeVuZhbLRgbGEYyiREU0ZERUHhn5 xBOiBXl1fkDQsFj9ggEELJ/W6bNs09FZcaJ3juwjNS2RGiEW/6KdfN2nOrSVkGJRZg1X Bj1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679319749; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HPUxYFnkGMoE5avSL4JFzjtLyBuUkiovE45vzPm5gIE=; b=v8Pu05rcJcyVp6MvatooIMT/38ebbo5FroLTZWT/7I7WIOaJkiKQXQcaQwUBKwQs8P g7A99DjyLyO3w8m4I4+WacFQp83u6qUxr6WDrhUycFqxoTeTggU1ODTNgnBN1Uy6u0Vr m/BJLabz9V3B3RpQuvTOzzQAvgPGUeDCmXoQ633v5b+IkTsjW7GsAizLvYuPVFpRq4ub s6lmiIrdncVDnkqrEKAa9CYmS0czaZbAKY2d4CeqGfVtx4m11od9IHOuLA5YCDOKP2Kk BfFeEs1TP3EfzS5CAtAGuTsuWm2/WPnXUV6dmXcFlr8Dg68S/YSrOLD0qp5ARmwZa26u N0pw== X-Gm-Message-State: AO0yUKXTsCuH++UDnyhoyMsIqfxjHJ6FcDtOlpTydfIIzzB5TOyUE2je qxmHHkEkaXQAwNOCJuKXZQyooQ== X-Received: by 2002:a17:906:1906:b0:925:1d1d:6825 with SMTP id a6-20020a170906190600b009251d1d6825mr9770894eje.42.1679319748816; Mon, 20 Mar 2023 06:42:28 -0700 (PDT) Received: from localhost.localdomain ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id u23-20020a170906409700b009334a6ef3e8sm2368602ejj.141.2023.03.20.06.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 06:42:28 -0700 (PDT) From: Abel Vesa To: "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Pavel Machek , Len Brown , Greg Kroah-Hartman , Bjorn Andersson , Andy Gross , Konrad Dybcio , Mike Turquette , Stephen Boyd , Saravana Kannan Cc: linux-pm@vger.kernel.org, Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, Doug Anderson , Matthias Kaehlcke Subject: [RFC PATCH v2 3/5] clk: qcom: gdsc: Avoid actual power off until sync state Date: Mon, 20 Mar 2023 15:42:15 +0200 Message-Id: <20230320134217.1685781-4-abel.vesa@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230320134217.1685781-1-abel.vesa@linaro.org> References: <20230320134217.1685781-1-abel.vesa@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760895321227086701?= X-GMAIL-MSGID: =?utf-8?q?1760895321227086701?= In case there is a sync state callback registered for a provider, do not actually power off any gdsc for that provider until sync state has been reached and return busy instead. Since the qcom_cc is private, add a helper that returns the gdsc_desc based on the device of the provider. Finally, add the generic gdsc sync state callback to be used by the platform specific providers. Signed-off-by: Abel Vesa --- drivers/clk/qcom/common.c | 19 +++++++++++++++++++ drivers/clk/qcom/common.h | 2 ++ drivers/clk/qcom/gdsc.c | 26 ++++++++++++++++++++++++++ drivers/clk/qcom/gdsc.h | 6 ++++++ 4 files changed, 53 insertions(+) diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c index 75f09e6e057e..d7fd1b170c1c 100644 --- a/drivers/clk/qcom/common.c +++ b/drivers/clk/qcom/common.c @@ -20,6 +20,7 @@ struct qcom_cc { struct qcom_reset_controller reset; struct clk_regmap **rclks; + struct gdsc_desc *scd; size_t num_rclks; }; @@ -234,6 +235,13 @@ static struct clk_hw *qcom_cc_clk_hw_get(struct of_phandle_args *clkspec, return cc->rclks[idx] ? &cc->rclks[idx]->hw : NULL; } +struct gdsc_desc *qcom_cc_get_gdsc_desc(struct device *dev) +{ + struct qcom_cc *cc = dev_get_drvdata(dev); + + return cc->scd; +} + int qcom_cc_really_probe(struct platform_device *pdev, const struct qcom_cc_desc *desc, struct regmap *regmap) { @@ -251,6 +259,8 @@ int qcom_cc_really_probe(struct platform_device *pdev, if (!cc) return -ENOMEM; + dev_set_drvdata(dev, cc); + reset = &cc->reset; reset->rcdev.of_node = dev->of_node; reset->rcdev.ops = &qcom_reset_ops; @@ -267,6 +277,9 @@ int qcom_cc_really_probe(struct platform_device *pdev, scd = devm_kzalloc(dev, sizeof(*scd), GFP_KERNEL); if (!scd) return -ENOMEM; + + cc->scd = scd; + scd->dev = dev; scd->scs = desc->gdscs; scd->num = desc->num_gdscs; @@ -319,6 +332,12 @@ int qcom_cc_probe(struct platform_device *pdev, const struct qcom_cc_desc *desc) } EXPORT_SYMBOL_GPL(qcom_cc_probe); +void qcom_cc_sync_state(struct device *dev) +{ + gdsc_sync_state(dev); +} +EXPORT_SYMBOL_GPL(qcom_cc_sync_state); + int qcom_cc_probe_by_index(struct platform_device *pdev, int index, const struct qcom_cc_desc *desc) { diff --git a/drivers/clk/qcom/common.h b/drivers/clk/qcom/common.h index 9c8f7b798d9f..1bea04da0a00 100644 --- a/drivers/clk/qcom/common.h +++ b/drivers/clk/qcom/common.h @@ -61,9 +61,11 @@ extern struct regmap *qcom_cc_map(struct platform_device *pdev, extern int qcom_cc_really_probe(struct platform_device *pdev, const struct qcom_cc_desc *desc, struct regmap *regmap); +extern struct gdsc_desc *qcom_cc_get_gdsc_desc(struct device *dev); extern int qcom_cc_probe(struct platform_device *pdev, const struct qcom_cc_desc *desc); extern int qcom_cc_probe_by_index(struct platform_device *pdev, int index, const struct qcom_cc_desc *desc); +extern void qcom_cc_sync_state(struct device *dev); #endif diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c index 5358e28122ab..af745907dc49 100644 --- a/drivers/clk/qcom/gdsc.c +++ b/drivers/clk/qcom/gdsc.c @@ -15,6 +15,8 @@ #include #include #include + +#include "common.h" #include "gdsc.h" #define PWR_ON_MASK BIT(31) @@ -319,6 +321,9 @@ static int gdsc_disable(struct generic_pm_domain *domain) struct gdsc *sc = domain_to_gdsc(domain); int ret; + if (!sc->state_synced) + return -EBUSY; + if (sc->pwrsts == PWRSTS_ON) return gdsc_assert_reset(sc); @@ -365,6 +370,7 @@ static int gdsc_disable(struct generic_pm_domain *domain) static int gdsc_init(struct gdsc *sc) { + struct device *dev = sc->dev; u32 mask, val; int on, ret; @@ -452,6 +458,9 @@ static int gdsc_init(struct gdsc *sc) if (!sc->pd.power_on) sc->pd.power_on = gdsc_enable; + if (!dev_has_sync_state(dev)) + sc->state_synced = true; + ret = pm_genpd_init(&sc->pd, NULL, !on); if (ret) goto err_disable_supply; @@ -496,6 +505,7 @@ int gdsc_register(struct gdsc_desc *desc, for (i = 0; i < num; i++) { if (!scs[i]) continue; + scs[i]->dev = dev; scs[i]->regmap = regmap; scs[i]->rcdev = rcdev; ret = gdsc_init(scs[i]); @@ -536,6 +546,22 @@ void gdsc_unregister(struct gdsc_desc *desc) of_genpd_del_provider(dev->of_node); } +void gdsc_sync_state(struct device *dev) +{ + struct gdsc_desc *scd = qcom_cc_get_gdsc_desc(dev); + struct gdsc **scs = scd->scs; + size_t num = scd->num; + int i; + + for (i = 0; i < num; i++) { + if (!scs[i]) + continue; + + scs[i]->state_synced = true; + genpd_queue_power_off_work(&scs[i]->pd); + } +} + /* * On SDM845+ the GPU GX domain is *almost* entirely controlled by the GMU * running in the CX domain so the CPU doesn't need to know anything about the diff --git a/drivers/clk/qcom/gdsc.h b/drivers/clk/qcom/gdsc.h index 803512688336..e1c902caecde 100644 --- a/drivers/clk/qcom/gdsc.h +++ b/drivers/clk/qcom/gdsc.h @@ -35,6 +35,7 @@ struct gdsc { struct generic_pm_domain pd; struct generic_pm_domain *parent; struct regmap *regmap; + struct device *dev; unsigned int gdscr; unsigned int collapse_ctrl; unsigned int collapse_mask; @@ -73,6 +74,8 @@ struct gdsc { const char *supply; struct regulator *rsupply; + + bool state_synced; }; struct gdsc_desc { @@ -86,6 +89,7 @@ int gdsc_register(struct gdsc_desc *desc, struct reset_controller_dev *, struct regmap *); void gdsc_unregister(struct gdsc_desc *desc); int gdsc_gx_do_nothing_enable(struct generic_pm_domain *domain); +void gdsc_sync_state(struct device *dev); #else static inline int gdsc_register(struct gdsc_desc *desc, struct reset_controller_dev *rcdev, @@ -94,6 +98,8 @@ static inline int gdsc_register(struct gdsc_desc *desc, return -ENOSYS; } +static inline void gdsc_sync_state(struct device *dev) { } + static inline void gdsc_unregister(struct gdsc_desc *desc) {}; #endif /* CONFIG_QCOM_GDSC */ #endif /* __QCOM_GDSC_H__ */ From patchwork Mon Mar 20 13:42:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abel Vesa X-Patchwork-Id: 72166 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp1227272wrt; Mon, 20 Mar 2023 06:50:46 -0700 (PDT) X-Google-Smtp-Source: AK7set+xtURTJhuw+wMHqmZz3oyA2gho8DJ8GxEUpzX8Em1CVL8FjRHtmjhnBeVDcjIuxb9GLnMM X-Received: by 2002:a05:6a20:be1e:b0:d7:28f8:6aca with SMTP id ge30-20020a056a20be1e00b000d728f86acamr13571886pzb.42.1679320245926; Mon, 20 Mar 2023 06:50:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679320245; cv=none; d=google.com; s=arc-20160816; b=oICeCb05D9nfl1jN34JoZ/O0qzpLPY7V+n5nvt8B0i6e+YHj9gHbsTPgaUwBR85+Nb xUzeCI31p2ZIuQiS0GSUetKkkuLM4FQhJtfY2oqPTctckHwaUpjqTphUuD7laGhzI3av e+j4X8KpV2OR7UTn5Y/FVunbqr7g/8rE0N5j80mB3rHK0SbHF412kirtFa0uqfXVHKne iJ+UMQCBMLm7pehCcnemnWKBwNkCHMG77K4B4+VAhK3ppNKx7oieEV8xBhB5CGYC/QQK MZir3olSWX88d4bUEW8MIOZdQeSMCDSej6XajN6WXcOlS2sKoHPyhskvu+4WVNwxrwku eT3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Htzjm9MSCo4/scEOmWkP20tbOGwc7n5xhdN8GyJQ6GQ=; b=Ry96gvuZBKyUetmrjfkRBYEXPIWGiMVzL83surr23WNbTyPF/wIVsEVpj4uSQwrILO VHNNY9GlstD5kNUO3t4lY7dYG0FfMmD1/2kkpHwBT12de/Kk1rWdE5nYu8JC0RYOD52T F6yxw0r6tnEVydxkxWhxFNvlyHxssccf2g8vE6P/xyMC5CTSdK9iFij0Mrx5si9LMkXs SiEpZUw0XOs85rZXipbQTKx273X0NWknHYK3aNGEgnU/cdDuErIpC/9JKCxcX/2fMXsA UqirXzQDgCU1tor/y/KEBvoMOZk3RvcoIgB+fgy6CFQSEuo3VGOjXIAiazGhSp/FSu5I HUrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bg8QBqEM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t4-20020a056a00138400b006272973b130si9235353pfg.297.2023.03.20.06.50.28; Mon, 20 Mar 2023 06:50:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bg8QBqEM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231234AbjCTNnO (ORCPT + 99 others); Mon, 20 Mar 2023 09:43:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231519AbjCTNmd (ORCPT ); Mon, 20 Mar 2023 09:42:33 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAC32FF17 for ; Mon, 20 Mar 2023 06:42:30 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id o12so46876923edb.9 for ; Mon, 20 Mar 2023 06:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679319750; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Htzjm9MSCo4/scEOmWkP20tbOGwc7n5xhdN8GyJQ6GQ=; b=bg8QBqEMCU2HBbMjnyK7G8pFNFhcaxlWlgPUkC1vmuTd98atUix3MIbBpG3lJAys+0 2OxXvRg04f1/Y4Zw8e3Vi2GHv7C9QlOn47ZCDI6ypkC2t9j4c/68f5X7HfJigdkdE4rU i6r/7Cch0fOo1xTP21OktKc1Onawn+Hn4+yuBsrBwgR0h8M9V2FtKPI82e3hKXiBAOs3 0pkDKbVru0PvsTBhhRiwHkOpn+cVCzsC1PdmFNoudWUAkN/Vby253U2/xMXn+Gzbg8yk ZxWg6fRkJz01IddW7B7uWGI0TLzKV5ppQJdre2FTgTZw29WSq37fGZgEi2MlHSxuctke Iqng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679319750; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Htzjm9MSCo4/scEOmWkP20tbOGwc7n5xhdN8GyJQ6GQ=; b=skyPMg/cUnz/F/IHLzBP9x2sOniZrHXIdbcFc68foV/EvJiGSekapa0/eXs3EmvqJ7 uQNmOD+bY3Li8XfF1IJ4rzR5tCTGT+NoL14pM8ZdM14M0WjzW4UxIZE5XD2LwBxMgD+S gzHQacFB4HyPDOd4kFdby+2ljDW/j5R9tbQA9ePza4VesdVgVJgHO6by7ff/2Ms4ptFB NnOkG2iSbjLc2mzr0GNcg2E7CbJilG0RkjLjyny8m3oUMatEhIvB5cX8qyITWlqdHj9X HCUAXB0axOjNcO6lgoVdVCvGl9k8F2AV1nbx70fMpS4+QxoOcEyfniYE23j/IUyZQ3s2 KCYQ== X-Gm-Message-State: AO0yUKUPJu3+RG+5DOxAVRavImzM3DVKiXzOtojW8kCM5Pa15mYPjbA6 dB38vWaREzrSHSo0kKcrOKyrzw== X-Received: by 2002:a17:906:13cb:b0:925:f542:1a3d with SMTP id g11-20020a17090613cb00b00925f5421a3dmr8999852ejc.25.1679319750345; Mon, 20 Mar 2023 06:42:30 -0700 (PDT) Received: from localhost.localdomain ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id u23-20020a170906409700b009334a6ef3e8sm2368602ejj.141.2023.03.20.06.42.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 06:42:29 -0700 (PDT) From: Abel Vesa To: "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Pavel Machek , Len Brown , Greg Kroah-Hartman , Bjorn Andersson , Andy Gross , Konrad Dybcio , Mike Turquette , Stephen Boyd , Saravana Kannan Cc: linux-pm@vger.kernel.org, Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, Doug Anderson , Matthias Kaehlcke Subject: [RFC PATCH v2 4/5] clk: qcom: Add sync state callback to all SC8280XP providers Date: Mon, 20 Mar 2023 15:42:16 +0200 Message-Id: <20230320134217.1685781-5-abel.vesa@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230320134217.1685781-1-abel.vesa@linaro.org> References: <20230320134217.1685781-1-abel.vesa@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760894906025873179?= X-GMAIL-MSGID: =?utf-8?q?1760894906025873179?= Now that we have support for sync state delayed disabling of unused power domains and a provided generic gdsc sync state callback, add it to all the providers related to the SC8280XP platform. Signed-off-by: Abel Vesa --- drivers/clk/qcom/dispcc-sc8280xp.c | 1 + drivers/clk/qcom/gcc-sc8280xp.c | 1 + drivers/clk/qcom/gpucc-sc8280xp.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c index 167470beb369..a64c396b9cc4 100644 --- a/drivers/clk/qcom/dispcc-sc8280xp.c +++ b/drivers/clk/qcom/dispcc-sc8280xp.c @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = { .driver = { .name = "disp_cc-sc8280xp", .of_match_table = disp_cc_sc8280xp_match_table, + .sync_state = qcom_cc_sync_state, }, }; diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c index b3198784e1c3..64d828ba07da 100644 --- a/drivers/clk/qcom/gcc-sc8280xp.c +++ b/drivers/clk/qcom/gcc-sc8280xp.c @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = { .driver = { .name = "gcc-sc8280xp", .of_match_table = gcc_sc8280xp_match_table, + .sync_state = qcom_cc_sync_state, }, }; diff --git a/drivers/clk/qcom/gpucc-sc8280xp.c b/drivers/clk/qcom/gpucc-sc8280xp.c index ea1e9505c335..46ca242ba427 100644 --- a/drivers/clk/qcom/gpucc-sc8280xp.c +++ b/drivers/clk/qcom/gpucc-sc8280xp.c @@ -453,6 +453,7 @@ static struct platform_driver gpu_cc_sc8280xp_driver = { .driver = { .name = "gpu_cc-sc8280xp", .of_match_table = gpu_cc_sc8280xp_match_table, + .sync_state = qcom_cc_sync_state, }, }; module_platform_driver(gpu_cc_sc8280xp_driver); From patchwork Mon Mar 20 13:42:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abel Vesa X-Patchwork-Id: 72165 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp1227092wrt; Mon, 20 Mar 2023 06:50:23 -0700 (PDT) X-Google-Smtp-Source: AK7set+s6Rwxw/5F9gNF52z837yK8WDsI661mBQknL37hG/VSYwBGMH72nw1vZrqJQNKy/kHXki5 X-Received: by 2002:a05:6a20:b55c:b0:cd:1a05:f4f4 with SMTP id ev28-20020a056a20b55c00b000cd1a05f4f4mr17106919pzb.19.1679320222981; Mon, 20 Mar 2023 06:50:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679320222; cv=none; d=google.com; s=arc-20160816; b=X4xO/g/FnH15uRd8eDKxhH8G3oDKnuZOm/YSFwzyJYVZBlJyYxtsEBpGntELkXL304 DTppkj1l1SUOPKEut63u/Q9XqJ74GSBdKUeZEezAVkokhgmaOohoayfptsYCN1A99PQI auUVdMmd9Why4TNAapFMh+9eX+tZT9P4u1FAJvX4N2jmaVDd8iLMH4oUTbLaA6jciF3X nssi/0M1PtFmc2WydVj/b7eaPyO5Y5KQZjg2KQxHsnI0YTO5c8AGXGIqpPxe0gqHtLzu /dOQSDdZ7gjsUqJNLd0K47O2crbcBMMZ2IY8OcawfUw15NwxkosJSqhNs2o6BdFFnvMc ifMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5bAvIgcdwvK6qGlX9/tkRQ+PgCIHsC6PUxID2XxtmJs=; b=p9gDgK9amHGk6Pk29KRLKHs3N+BavJmGEsP4M87ZIJ78eoRKOG4WnLNIN89aNQboo3 T2FMdaRFYKViNWMdn3YoTvuTt8iSpow7Z/ShcgzUk+uCpGTIdXe1xLtgLAQhgTCZMQ/u r3eHK12R7X44ufvcEGFFRMOCnQM9o1VI4xu1mTA3ihgX2Xw7CoMK7J4aUXhBKAFw8yDF jpaI92kOlNbRw/BJE5f5paoSXYUz7tTLlOMfeOWWWOVRS8XZ/FT335WKmOyaVDyOulA0 fa8nDSZUKGJr1hqiiCMVB60n9/uH7CZRLm7kZYxKvptdM1zuSWkY/kdxfJacaBb1O7SZ +T4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uQJkr15d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x24-20020a63db58000000b004d3cdf2aae7si10228142pgi.789.2023.03.20.06.50.08; Mon, 20 Mar 2023 06:50:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uQJkr15d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230203AbjCTNnD (ORCPT + 99 others); Mon, 20 Mar 2023 09:43:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231571AbjCTNme (ORCPT ); Mon, 20 Mar 2023 09:42:34 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 917ED10412 for ; Mon, 20 Mar 2023 06:42:32 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id cy23so46807784edb.12 for ; Mon, 20 Mar 2023 06:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679319752; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5bAvIgcdwvK6qGlX9/tkRQ+PgCIHsC6PUxID2XxtmJs=; b=uQJkr15djkVmBgXdKKgYT+9o9C75QiioeKW8Q5/wJYPZfxnhvse2/8a0DDverHAWLS V4MRks7KPnmb3/58MMbQeBZJCd+WBChFQ/qlPGj271EniIbqjMTbcFNtivNU+bjVjPo3 VJ8RMTBwR3qb8UntS5t8Mbw6a7v6pOYhS7hWQ322eXdq3ae0xeb281kDss612++wBbkl dFNiQ9tS/f7YmtYvC8fQTGYMgak7u2A8A0NWXOYfPEzqdzOVdoEsbBM1FOBolkv0PEJG 8F5nYdKwqjF2UqeqKa5HdYWamA+Adnph+EsOxTr0nRpV6i04HhKU+5xExxxro1quh0yR j/Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679319752; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5bAvIgcdwvK6qGlX9/tkRQ+PgCIHsC6PUxID2XxtmJs=; b=H8YnqF82/+enEqKkPi+UOAjV/F22V3rw+h0+LhpGdkzi65b4z73sfne2X5PgaLiaVA Q2XRLDYx0FxjxupCPPXJ1vFTsPza5TqgjBHeQYA2Vnx/OZh9oRjNRLkzIJSwslU529o+ YT/a4t90jWsX13ycInAsU8oXQm4Zae+xmIStXPdP4RMotnSb/3HLAbxXM62rdZxDg1j9 aDF6oy0lVn/1ZAcKFYYriNanuNDfyCYg+gaGlC9quIdFZHrS/T5Ov+yBo7c0LbYHBIez Pcu0lo+7oTSK3SR3pD6qghbMayogAHR2UZPAZwr1uzirgazo08MvrA2isutIXYzrWPlh BBeg== X-Gm-Message-State: AO0yUKVxFN5xheHKaM4l8qe7M5nZuFSVWA3KgT3CH3iZXh1rZEJzLhqS aWJU62luV6DScsDT94LTW2N+vw== X-Received: by 2002:a17:906:5015:b0:922:ae30:3c23 with SMTP id s21-20020a170906501500b00922ae303c23mr9566199ejj.18.1679319751913; Mon, 20 Mar 2023 06:42:31 -0700 (PDT) Received: from localhost.localdomain ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id u23-20020a170906409700b009334a6ef3e8sm2368602ejj.141.2023.03.20.06.42.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 06:42:31 -0700 (PDT) From: Abel Vesa To: "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Pavel Machek , Len Brown , Greg Kroah-Hartman , Bjorn Andersson , Andy Gross , Konrad Dybcio , Mike Turquette , Stephen Boyd , Saravana Kannan Cc: linux-pm@vger.kernel.org, Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, Doug Anderson , Matthias Kaehlcke Subject: [RFC PATCH v2 5/5] clk: qcom: Add sync state callback to all SM8450 providers Date: Mon, 20 Mar 2023 15:42:17 +0200 Message-Id: <20230320134217.1685781-6-abel.vesa@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230320134217.1685781-1-abel.vesa@linaro.org> References: <20230320134217.1685781-1-abel.vesa@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760894881864055262?= X-GMAIL-MSGID: =?utf-8?q?1760894881864055262?= Now that we have support for sync state delayed disabling of unused power domains and a provided generic gdsc sync state callback, add it to all the providers related to the SM8450 platform. Signed-off-by: Abel Vesa --- drivers/clk/qcom/camcc-sm8450.c | 1 + drivers/clk/qcom/dispcc-sm8450.c | 1 + drivers/clk/qcom/gcc-sm8450.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/clk/qcom/camcc-sm8450.c b/drivers/clk/qcom/camcc-sm8450.c index 51338a2884d2..b2c6109c7eba 100644 --- a/drivers/clk/qcom/camcc-sm8450.c +++ b/drivers/clk/qcom/camcc-sm8450.c @@ -2847,6 +2847,7 @@ static struct platform_driver cam_cc_sm8450_driver = { .driver = { .name = "camcc-sm8450", .of_match_table = cam_cc_sm8450_match_table, + .sync_state = qcom_cc_sync_state, }, }; diff --git a/drivers/clk/qcom/dispcc-sm8450.c b/drivers/clk/qcom/dispcc-sm8450.c index adbfd30bfc96..0ea719940a8e 100644 --- a/drivers/clk/qcom/dispcc-sm8450.c +++ b/drivers/clk/qcom/dispcc-sm8450.c @@ -1803,6 +1803,7 @@ static struct platform_driver disp_cc_sm8450_driver = { .driver = { .name = "disp_cc-sm8450", .of_match_table = disp_cc_sm8450_match_table, + .sync_state = qcom_cc_sync_state, }, }; diff --git a/drivers/clk/qcom/gcc-sm8450.c b/drivers/clk/qcom/gcc-sm8450.c index 84764cc3db4f..248709fb975e 100644 --- a/drivers/clk/qcom/gcc-sm8450.c +++ b/drivers/clk/qcom/gcc-sm8450.c @@ -3262,6 +3262,7 @@ static struct platform_driver gcc_sm8450_driver = { .driver = { .name = "gcc-sm8450", .of_match_table = gcc_sm8450_match_table, + .sync_state = qcom_cc_sync_state, }, };