From patchwork Thu Mar 16 15:17:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 70841 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp552518wrt; Thu, 16 Mar 2023 08:39:03 -0700 (PDT) X-Google-Smtp-Source: AK7set9R8GwpXrbnI7hxQPiusDrfaGLV6WghQxBF66xZVQdToYn1JnPADFn2rhrVFyCYhPzoI2D4 X-Received: by 2002:a05:6a20:1bdd:b0:cc:70e2:5b25 with SMTP id cv29-20020a056a201bdd00b000cc70e25b25mr3811800pzb.21.1678981143021; Thu, 16 Mar 2023 08:39:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678981142; cv=none; d=google.com; s=arc-20160816; b=i8uf+lju9/1z6RZvTrnpQv78WaZcLgPXRanXhhUK/dqmzbrQvc8Uo5QJRXVCcWTGAL 3Wl3/nVarVrMIN0hn9kuNDTsXWaPjoFqViGByKuYlC+LVprVLNZICTwHdtOzgVTvWLmX yXXfOLwqWkPwNn9Ko536kNVAlJE23VVbbg190jJ5C349n0A5QpUJ8XMljUhmBpfP92wL GKsRez65QClowa+Fix2q/4MafqfLE1kdWOFrDDse329kBLtlDAzFmFgt/udwTsBqh+LW XQFSw5f7eg/NNhmyGVVpA0ERGrFzsD/ZDFXVo1/wwCjle2FFtHeDVV3J1pZ2OqnPNNer CXJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=H4/Fi38q7E5qS/7J86Orolnyf62jTO1JC1vQ1ZYN2Zc=; b=tGKnu0c8rLPnV1nIkmuukYFotcGRR1Z+WdookK1lkQ5XgDtdjJMRxp671Ew1mDB9IN I7WqUmZshLZjdiQD45mb6ksQI71LoD316Y+b6xXuWYFWgJo1jV/4XNB3pNIluIZmb/sT pNJGDiVAVAQerpQJYs7wkh+tR3Oe4BAl6FwsQ33avXyrslOj2ocM7i/7fE3hM8qHmDGx 845NvvZHHzuZYcWeJ/o036f8dw+ORlubTn8Qnk5kVdtMEhGQOjyDSzHubfpVW6PKLW6F UJZ97iv9R8cW/BKQCRESIvBaamoHmBGrN4RtHWBQjFMnPphjppzuGolSD1U+Fc+mkIo6 7Cfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=V1WR2ojG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s64-20020a625e43000000b0062582703a2fsi6004283pfb.329.2023.03.16.08.38.50; Thu, 16 Mar 2023 08:39:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=V1WR2ojG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231341AbjCPPTP (ORCPT + 99 others); Thu, 16 Mar 2023 11:19:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230147AbjCPPTO (ORCPT ); Thu, 16 Mar 2023 11:19:14 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.215]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D8D262B29D; Thu, 16 Mar 2023 08:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=H4/Fi 38q7E5qS/7J86Orolnyf62jTO1JC1vQ1ZYN2Zc=; b=V1WR2ojGiu1UNzboarRI5 oQEBB3wRf3v6iH9f11uQzdQzALCTm0OLhYXoK00tGSn4MNvdaSGj2LOv6sSLeNmC FU1aYShhw4iBZz2FFWyft2OLspsd3KMqM5643euFdvFjUMHbJMWgekOspyPDg02J gXA2kFfOomqhtI04OyhbUU= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g5-1 (Coremail) with SMTP id _____wCHicYbMxNkoxocAQ--.17899S2; Thu, 16 Mar 2023 23:17:47 +0800 (CST) From: Zheng Wang To: davem@davemloft.net Cc: simon.horman@corigine.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, petrm@nvidia.com, thomas.lendacky@amd.com, wsa+renesas@sang-engineering.com, leon@kernel.org, shayagr@amazon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH v4] xirc2ps_cs: Fix use after free bug in xirc2ps_detach Date: Thu, 16 Mar 2023 23:17:45 +0800 Message-Id: <20230316151745.1557266-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wCHicYbMxNkoxocAQ--.17899S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7WrWxuF4xKrW5Aw4UGw1Dtrb_yoW8XF4DpF WUJay5Zr4DX3sIvw4xJFyUJF15Xa93K3yjgrZ3C3ySgrn8ArWqgry5tayjgFyxZrWkZF13 Ar1Y9ryxWFnrAFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0ziYLv_UUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiXAw0U1Xl59KrNgACst X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760539330824853507?= X-GMAIL-MSGID: =?utf-8?q?1760539330824853507?= In xirc2ps_probe, the local->tx_timeout_task was bounded with xirc2ps_tx_timeout_task. When timeout occurs, it will call xirc_tx_timeout->schedule_work to start the work. When we call xirc2ps_detach to remove the driver, there may be a sequence as follows: Stop responding to timeout tasks and complete scheduled tasks before cleanup in xirc2ps_detach, which will fix the problem. CPU0 CPU1 |xirc2ps_tx_timeout_task xirc2ps_detach | free_netdev | kfree(dev); | | | do_reset | //use dev Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Zheng Wang --- v4: - fix indentation error again v3: - fix indentation error suggested by Jakub Kicinski v2: - fix indentation error suggested by Simon Horman, and stop the timeout tasks suggested by Yunsheng Lin --- drivers/net/ethernet/xircom/xirc2ps_cs.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/xircom/xirc2ps_cs.c b/drivers/net/ethernet/xircom/xirc2ps_cs.c index 894e92ef415b..e04b3f7f2179 100644 --- a/drivers/net/ethernet/xircom/xirc2ps_cs.c +++ b/drivers/net/ethernet/xircom/xirc2ps_cs.c @@ -503,7 +503,12 @@ static void xirc2ps_detach(struct pcmcia_device *link) { struct net_device *dev = link->priv; + struct local_info *local = netdev_priv(dev); + netif_carrier_off(dev); + netif_tx_disable(dev); + cancel_work_sync(&local->tx_timeout_task); + dev_dbg(&link->dev, "detach\n"); unregister_netdev(dev);