From patchwork Thu Mar 16 10:20:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 70709 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp397893wrt; Thu, 16 Mar 2023 03:23:23 -0700 (PDT) X-Google-Smtp-Source: AK7set8Q8lhIH+DFa2xhKgcjMgsBxBTiq4aT6TApn7tFBH+l8m6q0/Bj/61ccNEPvc7RKs5R+XCz X-Received: by 2002:a62:1c84:0:b0:625:7300:5550 with SMTP id c126-20020a621c84000000b0062573005550mr2356197pfc.31.1678962202691; Thu, 16 Mar 2023 03:23:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678962202; cv=none; d=google.com; s=arc-20160816; b=GHdcexziMyKM/1hNe/Kj9VRqVcx7iFeE6OJotSydvGwnlIhw0l5nHP7SaKCZ1lZwRi dAYYJb/1zV7F41A3Ep/kkqCF/sVzNPLxQHMtie3YiIpOOdaI3c54rxwdBwWGejFYjPCy F3mjxtKxBPshJROMIArH+lDvyj7en1jUTI8WOHcO5pLL0qiLQZl1xMVr4kEdP0D7SUao ztCokU/+EpVDWROXNKPjFupbKnuf55rhQgf0xI3q/rTvs2WA7+OjDwM+qzMI5zN4jIl5 2yMWwKSjA8ErGpCjFddKSRvQr5u2IecRqRvEWNcHWiebptr5QkSj25OMjE1aw7cXSDIq gFUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8zV39akSKgTXnbIsuHdwXtYxXMFzl6o5v6caNUB0if4=; b=i2AjazeFHpuuyDljqAK1lSmOYI2bixo8k6XwMy2TfOw1l06+iceR8Vg/F1QdwsS2kW 1oixyMm+NHHqynurLGEMkggifsdDm/QP1DeMF5B/x4AiFyJGJCjeicfcxjyaxd9PMllq Kb4579qf35ReYNKlWG789hZkcDgf2xj2Qqg2mhauO7CY+cNSVW1xvI0UhPKt/Na6Fhja w0QCQeJ89dmJZMmlVwn3ktQn00eTiInCW4HVMEAv0tIsBPWGKXRJHPvOB3Xa2tbCHETo m6ny8EBwQE5ocNatBxGoMUQoJhWMoB0MXADJK8Depz9znRWU3+G502KmW4IWwkNJW7yr IWZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=RynW8u0D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h9-20020a631209000000b00502d81ecf19si7352879pgl.646.2023.03.16.03.23.07; Thu, 16 Mar 2023 03:23:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=RynW8u0D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230420AbjCPKVO (ORCPT + 99 others); Thu, 16 Mar 2023 06:21:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230480AbjCPKUz (ORCPT ); Thu, 16 Mar 2023 06:20:55 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBD6DB1A4A; Thu, 16 Mar 2023 03:20:48 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 28F90660309E; Thu, 16 Mar 2023 10:20:46 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678962046; bh=t6e55TKXpWDXs7rKf1rewUoc056XoaKTiofz8DN9RjM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RynW8u0Dr4ZczODzCd2SqpQk6l0qle1QQQKYJReaYbbgC/NiBVgsx8YY/z1d86idK f4IQC1dpbvJM61+JNY8IKP3oQ3PpwHoBs7UUqYHCj6Hf+mpHt16S/pCwrxDVGXPCQb 2CpXPfrQWFani4dmmdV1QUymIn8bWPeUP6lXbkml5nQ+M2RQaejKmWT8827i8yhght mM5Rc3MYdRtOp7i5UkB5BO7y3t40z1vH9I7tV5N3MeYSICkOyFEoBOcu1ZgiYofuTo 0K53H3tkpCB5WHdMIl6yQ8txBdOSaapyxAbhB24sRX3Q9svQ2dhqp7TneaTHHTbDLC oCABAxTCASlUQ== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v5 01/12] dt-bindings: gpu: mali-bifrost: Split out MediaTek power-domains variation Date: Thu, 16 Mar 2023 11:20:30 +0100 Message-Id: <20230316102041.210269-2-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> References: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760519470908887979?= X-GMAIL-MSGID: =?utf-8?q?1760519470908887979?= In preparation for adding new bindings for new MediaTek SoCs, split out the power-domains variation from the `else` in the current mediatek,mt8183-mali conditional. The sram-supply part is left in place to be disallowed for anything that is not compatible with "mediatek,mt8183-mali" as this regulator is MediaTek-specific and it is, and will ever be, used only for this specific string due to the addition of the mediatek-regulator-coupler driver. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Reviewed-by: Rob Herring --- .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 78964c140b46..7e110751353e 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -109,6 +109,9 @@ allOf: contains: const: amlogic,meson-g12a-mali then: + properties: + power-domains: + maxItems: 1 required: - resets - if: @@ -131,6 +134,8 @@ allOf: - const: gpu - const: bus - const: bus_ace + power-domains: + maxItems: 1 resets: minItems: 3 reset-names: @@ -164,8 +169,6 @@ allOf: - power-domain-names else: properties: - power-domains: - maxItems: 1 sram-supply: false - if: properties: @@ -180,6 +183,8 @@ allOf: items: - const: gpu - const: bus + power-domains: + maxItems: 1 required: - clock-names From patchwork Thu Mar 16 10:20:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 70723 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp403229wrt; Thu, 16 Mar 2023 03:37:08 -0700 (PDT) X-Google-Smtp-Source: AK7set+s9nJw6t2YIJba3tItveFLcSO911BFXurUVJ60pHiLjAZHn3PWhOgW50SU6dbbfp5mcbLX X-Received: by 2002:a17:90a:1a49:b0:23d:2d68:1d6a with SMTP id 9-20020a17090a1a4900b0023d2d681d6amr3546661pjl.37.1678963028037; Thu, 16 Mar 2023 03:37:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678963028; cv=none; d=google.com; s=arc-20160816; b=aBxa1C0HxIDdDWrIEBs/k3rXSxTxcdEr83ZGce1rBSGnZg60x9RMrggOFi48dXmrNW jQ89ZLSXe+8HyxQutVRImw7ydDOeX2rv5AbKSDsnpXUgRxG/QRVJ+QAdGcM1Pl23AHR9 q+hRIcjVqq+nkb4v/H5H2laV/9FN42kkDNito6P2iORpYOj3Ec7tpBPfBZqnB4+kLQ2w tb7osWCamKNVvO4Q84n5qf1HCGOdWEl8NUyOsYl2o6kGde++sCQP4ZRnHQo2rBbix6ZF Zn7olo8YCkPoCsvMT7N25fJ8YAnjm6Cf9pn/3vrlUIy7JFo9t+sJ2QSJs7o8alNVJrPX M9EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8i1b+In4P2ZDdE63oCFDs3nvPPETwQFuU0JBMLBGs0Q=; b=cg5ixmNIXCm9oMX2JxDA9kia0HHsmIce1qjMnUFsP/jTZAndc+Jk+RiioaZ+jiWhT/ qbkVSpjGv04AMxyFObFEATwHp/cNqo8cGcioK1aTq51Rmdd3GPtd5bU8vqub/M8P+YRk fALll9S+2ZKOQu4wLVhaGjvlVPPTKJTYUi4E2KvPGQ1b/KHN9/GgLpCu79W73l9SHN84 ZmMUFI7GbRvr7sRZ7B0DkitmPJ1eczOJ7kIW9cskuM705X3GV7NZw/rjpxGwBYKVrPoY KIQbSEwWlh4HiTUkMtUmu7skOVZ7WYVCFQcBnjc3KNenYmromSwIXeQbMoYNuYthZz+4 gEoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=XZDAjq3y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lr3-20020a17090b4b8300b0023d46505d83si5103956pjb.79.2023.03.16.03.36.53; Thu, 16 Mar 2023 03:37:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=XZDAjq3y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231173AbjCPKVU (ORCPT + 99 others); Thu, 16 Mar 2023 06:21:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230365AbjCPKU5 (ORCPT ); Thu, 16 Mar 2023 06:20:57 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65CA3BD4E0; Thu, 16 Mar 2023 03:20:49 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 110C8660309F; Thu, 16 Mar 2023 10:20:47 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678962047; bh=0AQ+gCHdVFTNhiJx165qPUL/6q3xPgjQ71jCDBHRJbM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XZDAjq3y2FnChbx/QaN5W8qWibNZXqFSx+bE4yxNo3mFhqkC7puUiGzFrqJ5720we v276dVUUfq1cEPXmL24DQ4EhnCiJsU25pvEEIvRp3r/vhHJbgczulchcoecA+QwABQ B1HOy+tPc/AkhUEuqiFocFMS+vZeq5umSPFkuuheU3xiOtZYibBpfGg/ajB8vdAruC 4R7RsK/EAaaGdSde/s04W54Jf6mYSi8f0QMZIPtMAI5KdYR2Pc6Yb27G3iEgE81+XC CySRPOBKTfHPlH+BVgy45OGeCYPm+Yxj95Ynox8lSxDadnVcD/twx2DodOuI9ckKhQ 2H7AMk+HJ9iqg== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v5 02/12] dt-bindings: gpu: mali-bifrost: Set power-domains maxItems to 5 Date: Thu, 16 Mar 2023 11:20:31 +0100 Message-Id: <20230316102041.210269-3-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> References: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760520336206475773?= X-GMAIL-MSGID: =?utf-8?q?1760520336206475773?= In preparation for adding (and fixing) power-domain-names and MediaTek MT8192 bindings, allow up to five items for power-domains. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 7e110751353e..5b7f1c9d2b30 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -63,7 +63,7 @@ properties: power-domains: minItems: 1 - maxItems: 3 + maxItems: 5 resets: minItems: 1 @@ -157,6 +157,7 @@ allOf: properties: power-domains: minItems: 3 + maxItems: 3 power-domain-names: items: - const: core0 From patchwork Thu Mar 16 10:20:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 70718 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp401718wrt; Thu, 16 Mar 2023 03:33:35 -0700 (PDT) X-Google-Smtp-Source: AK7set/XQbqcE64+EmlgreBBP8CrEKOVBhM2hVWKLR4BYF6ncK++m9Afjpy+2e0CP2N1cpK2nMVn X-Received: by 2002:a05:6a20:69a3:b0:d6:b1b5:98f9 with SMTP id t35-20020a056a2069a300b000d6b1b598f9mr3528867pzk.7.1678962814767; Thu, 16 Mar 2023 03:33:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678962814; cv=none; d=google.com; s=arc-20160816; b=LyDrGATZjIshlrR4NInLF2ANqaYZevUm8ng1Zb1P7hYYY5qhacXJHUJ30iogGoAZMd w4V6qidkRdTM8Grv99fl5gZhZF4JY81KNeh6PDST8fCKV7WWDMuIqm3lAIolPmvQalHU J2uIyJ0+4IBufzZ3Vprc2XWZBP8vzYKUyb+veSdUXMFhYMIMXvz6Fg+xxlOH5c/+M7nS n7ZlUuH2/W7STp9aNnEBvDvUDoW4ow49eACeFOrge6oEp2P+VBSBbICfdF5LLbzY4nTJ eP4TVwOOUO/2MgUro6mZOXWtfxxjz62iCpOQ0D1gxIf72JvnnAdN7SCeU322YxAfmnE3 ex0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=J9kJVsxcim4PLtHe23b8aBLEQQUlMpe/iSUKuiqOVtA=; b=OVey8URTgu+csilwXCM+A5BtDA+/ZSrdxppM2r8uC1cLvDwSStkqQqNCvF2NbBBwvf W5gvF93dBL2BN/L8nSBwt+iFMsTeCTydCd89TYAMyrKkwtY1bvP3ckcOonUsBVkYCIrk fVh+egvJipSfDTZzcowm+6Rp6Oxb2h/KdtpKG4nBK60qKrIUMgZ47XavD8tqh2iy32E1 wDnrDeJ0/f5KNh29VaiqRa5XLGzdtNS5gZ9rbZfOqVXbLNoWTBdue/RObGN1nU8ex4he km42XvGLE3WJxalVj5IqzGJFL9cB3c3Zj0GLg2f9PURN2owW85fM6said+VbeaF1wips Y37Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=kpuX2RQE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j2-20020a654282000000b004fb35911c7dsi7401690pgp.541.2023.03.16.03.33.20; Thu, 16 Mar 2023 03:33:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=kpuX2RQE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231193AbjCPKVY (ORCPT + 99 others); Thu, 16 Mar 2023 06:21:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230388AbjCPKVA (ORCPT ); Thu, 16 Mar 2023 06:21:00 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14386BD4FD; Thu, 16 Mar 2023 03:20:50 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id E845C66030A0; Thu, 16 Mar 2023 10:20:47 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678962048; bh=vym02gfUeFtMkZA43yUlFdqpHJiV8QIzeChJfzjI5R4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kpuX2RQEQblFvVlA7uJOEnSjVUFXexzWEE/YHcNPmudmm7wBcVbhDyeCcz0HytihH QYyQvyV1KUPfBuFYVRXjYBWitRc1/PDQVEoJ3NwwBdlagUZLljRznoSR9VBltb115K sSIb8uAvevtYftC68I6ie/HvBHpjGLp3GDzeN7VwZC6QKZwBs4Tt7akIlqvaMdGgYg 9wUqlcy4JrZGu5PCvcsn45YWj80jUHqUoSXEnH5CVmUYUyB+TJ0mXOdlNvGbaRPTqq i442BMbVucu3fEyfzp45+wMpBVdKbUA54NgVaZfU3/d60oaM7ykeJnezgsvJAa97lk 5ZmtnXLNoHEhA== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v5 03/12] dt-bindings: gpu: mali-bifrost: Fix power-domain-names validation Date: Thu, 16 Mar 2023 11:20:32 +0100 Message-Id: <20230316102041.210269-4-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> References: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760520112452619695?= X-GMAIL-MSGID: =?utf-8?q?1760520112452619695?= Commit ("dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183") incorrectly introduced power domain names for MT8183, causing validation issues. Add power-domain-names to the base schema, allowing a maximum of five elements; since platforms having a single power domain don't need any actual domain name, disallow that for each sub-schema. Fixes: a7a596cd3115 ("dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183") Signed-off-by: AngeloGioacchino Del Regno Tested-by: Chen-Yu Tsai Reviewed-by: Rob Herring --- .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 5b7f1c9d2b30..7c61524aae26 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -65,6 +65,10 @@ properties: minItems: 1 maxItems: 5 + power-domain-names: + minItems: 2 + maxItems: 5 + resets: minItems: 1 maxItems: 3 @@ -112,6 +116,7 @@ allOf: properties: power-domains: maxItems: 1 + power-domain-names: false required: - resets - if: @@ -136,6 +141,7 @@ allOf: - const: bus_ace power-domains: maxItems: 1 + power-domain-names: false resets: minItems: 3 reset-names: @@ -186,6 +192,7 @@ allOf: - const: bus power-domains: maxItems: 1 + power-domain-names: false required: - clock-names From patchwork Thu Mar 16 10:20:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 70724 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp403376wrt; Thu, 16 Mar 2023 03:37:22 -0700 (PDT) X-Google-Smtp-Source: AK7set9wlTH+2O7NM2/cCq/ZFAAgBqCkM91Cp051GnwvyYjI4IDRq7CSxv4bdGvpABpeV5vWigKS X-Received: by 2002:a05:6a20:a103:b0:cc:8a62:d0d4 with SMTP id q3-20020a056a20a10300b000cc8a62d0d4mr4193983pzk.38.1678963042483; Thu, 16 Mar 2023 03:37:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678963042; cv=none; d=google.com; s=arc-20160816; b=ouH2KFo2k6tY8bhSeA0huTVLHZVa5arSO9L7bS5zhsvxf6ScUDKMJAmPmK6Q+p+C40 zka07kbHg1PHGSHmVyyACHQ41w7vOBYmMEFvzU95NPR/YTNpmFmwdKeqEydmdvnK4lAy 2FmzuN0RtCN95vXReCDbZdi0+v39Ry+55+6I4tg4eLXTX02Da5ydr4ohLXnRMnQqNmIE zFoZewk2iU9XZljz9k4zt9Ozuxync2lBR275A3ki8L+2zzzd7G2exzDMsWUiuQplzjyv TEnuPeho8dbylnmrP07shycZo0V5MBXNDa7URtK7gD88zS27fwg490aMa8sEs2MRdUlq eq+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VcAdjh5SkJV5JpElKyKUhRrN/itFLCu0Et5coQQ/bpI=; b=qqqfdP7bVoa8B9tRTvtUy2sHFhm8Xt9LjhQeUyrbnh2hKKiZHaFEPotp1Lm4PRYB+Z a/Jizh43nspWH6Hp3c/kapTETrWUcP16rvAfMOuQmxhRzUU5a4A+rxNblaIE3L6kjSfO dhqRZHUxqzkRSTsz3ns+lEEhBM/I1n9CwGDRlDBeRKydPfauno+bgvEEI28/LWmAJsMr Qf9scY7lSnuZGe1g3MikpztnTtWq89EFuaIGz6jIDkZ2tiKskx+kkbSqyTHUY8ibj7FU bUjsVwB1HQB8tsI4reCLjLOd663af8P8k3NYtUNLXvxUCrjjakvrk9uiXQxJ241JHdWW g35Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=kaRZ4u7T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s72-20020a632c4b000000b0050bfb509db6si365854pgs.636.2023.03.16.03.37.07; Thu, 16 Mar 2023 03:37:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=kaRZ4u7T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230304AbjCPKV2 (ORCPT + 99 others); Thu, 16 Mar 2023 06:21:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230434AbjCPKVC (ORCPT ); Thu, 16 Mar 2023 06:21:02 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3206BDD00; Thu, 16 Mar 2023 03:20:52 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id CD3D966030A1; Thu, 16 Mar 2023 10:20:48 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678962049; bh=cvXpJ8LbxubJEtHvxk8Psw3/s85Oor+YdZdxHV1BvnA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kaRZ4u7T2R2eNSV5sEw9n2rokz8EIIh9g3ilN7C700K2R+bZ50POfJlz9WcqMNubk 7Km6JlWLgGcL7zZ13CMx4wVWRvFC+3vpXiXrW8e1Jo4i6nGcMsq0bsvUwBIeFlgOP9 pkMZSKHhW7xd0q7M1kJg8kJEqyVmhJ3ZZqlK+hdJnIbcx7gUT8RQisOeaCpBUTLzqt V0pFeyDva4lz2iqPUO9UDjOGZLZ0MHS85N+mnaDDtYh91CYuM5saXaaKynjHhZ3hSm ODxHBVVJIX76MhqWsS0pU+QVQS5q+Y1hysd2KmHVfcGfK+Ql+GB+kHCYOGOLzJ/ffp 9rLDEFBU0wAsQ== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v5 04/12] dt-bindings: gpu: mali-bifrost: Add sub-schema for MT8192's power domains Date: Thu, 16 Mar 2023 11:20:33 +0100 Message-Id: <20230316102041.210269-5-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> References: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760520351276690297?= X-GMAIL-MSGID: =?utf-8?q?1760520351276690297?= MediaTek MT8192 (and similar) needs five power domains for the Mali GPU and no sram-supply: change the binding to allow so by also introducing power-domain-names in the generic binding; while at it, also disallow the newly introduced power-domain-names for all non-MediaTek bindings. Fixes: 5d82e74a97c2 ("dt-bindings: Add compatible for Mali Valhall (JM)") Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Rob Herring Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai --- .../bindings/gpu/arm,mali-bifrost.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 7c61524aae26..9ede51427012 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -177,6 +177,25 @@ allOf: else: properties: sram-supply: false + - if: + properties: + compatible: + contains: + const: mediatek,mt8192-mali + then: + properties: + power-domains: + minItems: 5 + power-domain-names: + items: + - const: core0 + - const: core1 + - const: core2 + - const: core3 + - const: core4 + required: + - power-domains + - power-domain-names - if: properties: compatible: From patchwork Thu Mar 16 10:20:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 70710 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp398126wrt; Thu, 16 Mar 2023 03:24:02 -0700 (PDT) X-Google-Smtp-Source: AK7set/lpP8/TbdeaYokqMN5VqDhR1rzJCMoG/OtcRuQjPh2fsEIy0a2r7exfmo2SKr310L8hEeN X-Received: by 2002:a05:6a20:4fa3:b0:d7:47e8:59cc with SMTP id gh35-20020a056a204fa300b000d747e859ccmr33279pzb.35.1678962242349; Thu, 16 Mar 2023 03:24:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678962242; cv=none; d=google.com; s=arc-20160816; b=C1M91h0r9SFX35RTIOfpJ4qlZZOHacQHB1+9OPjRQ++ypTPv8o8sZ4a8I4OjQwchSf 2zjZeLnXPdV0JuEgZEVZda7s040vDHwxzRdPTpeJoN2htGN0w1qqW5/s2HnXO/FRbQOz 7m5jKDtEtRxoWzuTOca6HqT4kjti2SBPAZLrEBZM7sQpdVjlgmf1OavmVGTrmgny+w5h PMTj5Pw0iyUmC+BlP+ZA0Mbw0axtPWHcR9Ug1kQwoqzKh3O8I+XdYHlnY2rvj74bCala MKde9xVFXfvQ1tMT0NApcbJHmV+SU83sKCPYpabUkRchVDQgEIJ/00EiDFlqZWbHla+E S2Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=E5xmCUbRVRjoHxNgpHmC242eIB4ySoBdfF1Srx+Bzyk=; b=syAVEFVQJ0ygDZoQ2pZmI7pPBEWuO9pcgxHcU9v/VevsX7MxnmKDed3I0PN1JgRXS7 yUAclZttPXghGad8hPp3aXnHiGOhCsRPM1Fto2oStcY5sLI2qKddSanhBRzdwNWAqiEF wWI5Azwja7vX5uuCtYQm36s8PIJH9fe6MJjsS9MhbEMQqlLRn2PbhYd41XRwZcS1/QtS JCuCxSZGCngp3/cyjm0EhIASTvR2v0sNasqkqhObbtWXgaJ4rOObIBc2O9oipXEUDVlC UERNMO/V/JPq1O5NQAY17BVJDik8gosv+N9fUKOzNZEypWAWcCRmAzpye87LAe7wHAh3 Tdbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=RPzEZRk1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h9-20020a631209000000b00502d825633asi7367934pgl.639.2023.03.16.03.23.47; Thu, 16 Mar 2023 03:24:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=RPzEZRk1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231136AbjCPKVl (ORCPT + 99 others); Thu, 16 Mar 2023 06:21:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230510AbjCPKVK (ORCPT ); Thu, 16 Mar 2023 06:21:10 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06596BCB9C; Thu, 16 Mar 2023 03:20:56 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id B3C1566030A4; Thu, 16 Mar 2023 10:20:49 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678962050; bh=Ve/6iRm3WMPE1EojlHjL3TKtdXfDs4Ou+mT+OBRzwJc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RPzEZRk1nUidBfPOaouPRtWxnwWtq6OclMoT7GIZ8LRg4a/f0sCDMsBximrNRluAL vvLyYi39Q9YBaVPMZUqHsRVhdq42Fc0aUhKRWXvlx6oMOXxhTGRfOc86pF7Dlt/exl 0jyXG5HBHArpaz/fJh3eBF9mqI3T+GKWoH4Ekab2org7gjC9vePDLgG6iNDkEZmByM MK3m7x60UCGUAk7mrgr0PdyTnGww1wIOkVlthr5BoOEjiEO/EwvJuBqQsFZrwp2b56 Y51NImWYIBF1AYX2E1CSmNygH8rZkaghZC09ZlO3xB9djIMl4sVjs5Pnz0yBJEt9nV yt0wZqcNPlwgg== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v5 05/12] dt-bindings: gpu: mali-bifrost: Add new MT8183 compatible Date: Thu, 16 Mar 2023 11:20:34 +0100 Message-Id: <20230316102041.210269-6-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> References: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760519511922844866?= X-GMAIL-MSGID: =?utf-8?q?1760519511922844866?= Since new platform data was required in Panfrost for getting GPU DVFS finally working on MediaTek SoCs, add a new "mediatek,mt8183b-mali" compatible. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Rob Herring Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai --- .../bindings/gpu/arm,mali-bifrost.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 9ede51427012..63b993d5fd87 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -19,6 +19,7 @@ properties: - enum: - amlogic,meson-g12a-mali - mediatek,mt8183-mali + - mediatek,mt8183b-mali - realtek,rtd1619-mali - renesas,r9a07g044-mali - renesas,r9a07g054-mali @@ -177,6 +178,24 @@ allOf: else: properties: sram-supply: false + - if: + properties: + compatible: + contains: + const: mediatek,mt8183b-mali + then: + properties: + power-domains: + minItems: 3 + maxItems: 3 + power-domain-names: + items: + - const: core0 + - const: core1 + - const: core2 + required: + - power-domains + - power-domain-names - if: properties: compatible: From patchwork Thu Mar 16 10:20:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 70714 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp400413wrt; Thu, 16 Mar 2023 03:30:24 -0700 (PDT) X-Google-Smtp-Source: AK7set/TT8Y9CMSSUgQ/BbTGIP3JpcGuveE6yRiyRrF+WbjBqni+Lu4asBjtkELBoDpPTesX0PZ1 X-Received: by 2002:a17:902:dace:b0:1a1:97b5:c660 with SMTP id q14-20020a170902dace00b001a197b5c660mr906358plx.20.1678962624606; Thu, 16 Mar 2023 03:30:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678962624; cv=none; d=google.com; s=arc-20160816; b=a6GKF5y5HKyEITRPAAo+q3rD8jcmBGwzjhldpdWT7kZG7h3KVH8HvvV+H/hkwJ7aYG 6lAGeRQ0TPyNzxCsaXUGa52Q+fRDpuMK/1em7Q+fR4MswdVoguFhlMe07kADwqFPPwMH Thztl7IXbFPZeqZZYlY8J/E986cnmuqjpIPU2LXAtd7ZWlMA/KQ0FTRW1p4FFcGc+N+c UCX/6ZO1gofQIERvuhrv6Dnwi/yQeQhjhhwq3tlkN88mTBaX0IWBUK1aNIGuY5FNS10m FHeGTM56mzKJzL1kpD9xNcOw2xPSTpcWGp62Bgj7VnB9xWMQEyJmeWVo2FUiGwW134PB /h9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XS2y6CGN6DVpxAbUrW0cW/C8S3FCdAMdtsTDq7gPado=; b=Rz1GUrcczIoBxly9an8+VN4U09d8XldmrndUFd33I/ZPFuC1B+XEKwk/gD4xQBuaLQ aAjnQdx4Kx90Bqlw7UDqePsICxktKa8NbqddNxa7pHyIEAO/WN47HGDsMBBfAlWobi34 1h8nrDZPhxYkjIBEZcGiGpJWKPCAg7YpW7kpBJS/2frSJFW0r9ew1KfEIf0UyqmNngzE eL3/wvY9iFyfAD1rgBA/1n+v3lXX2YgHIUN+nlJd3booV3ZVvrV3XYvmkDE6kqOZ5jyx crhT1SxjLQHLOlmBzqdTYEG8kN5s6h/x9rI6+VF5bDLkIquqOUUKPBLydD8kEdxdEOo/ teHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=JJNsD8RR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kh12-20020a170903064c00b0019abec982d2si7701018plb.22.2023.03.16.03.30.08; Thu, 16 Mar 2023 03:30:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=JJNsD8RR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231307AbjCPKVq (ORCPT + 99 others); Thu, 16 Mar 2023 06:21:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230499AbjCPKVJ (ORCPT ); Thu, 16 Mar 2023 06:21:09 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D67941B322; Thu, 16 Mar 2023 03:20:56 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 96F2966030A2; Thu, 16 Mar 2023 10:20:50 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678962051; bh=uglCXCkWdTA8UQ8UzHMlW0QAy31JjzQ29lenVUc0QMI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JJNsD8RRoKeOsn+xdsXLRjM30aGTJrGpguskbdxgNVnCsVGyyi7RANKku2nXARYdJ bRb//ChxE+qethj+tRWNauzSzq6hM0ayC1iy5Obr94nrbR7x+ObttT948WqSRhgjZ6 +1BBu5QHYgbhZRMcnuBFnNHUc6KsQd45bQXajV23WPDqfvo1kGSCp1D7/BbQrKYYnd OzSLLzOYKozdGPaobdmDXcj0kBtLLoD6e7WoTiQjKZ+zDV6FQ4IzS2GynIBECnR8Yd RdkqzzN9s7uXq2JDe12OkX3aDfTMeYr8+dM61MLUuHz8Sn5PTC2iY3iqXmlp05qf03 MkQmD4/4vD4PA== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v5 06/12] dt-bindings: gpu: mali-bifrost: Add support for MediaTek MT8186 Date: Thu, 16 Mar 2023 11:20:35 +0100 Message-Id: <20230316102041.210269-7-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> References: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760519913166697930?= X-GMAIL-MSGID: =?utf-8?q?1760519913166697930?= MT8186 has a Mali-G52 MC2 2EE GPU (two cores): add a binding with two power domains (one per core) for it. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Reviewed-by: Rob Herring --- .../bindings/gpu/arm,mali-bifrost.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 63b993d5fd87..3d0d96913b1b 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -20,6 +20,7 @@ properties: - amlogic,meson-g12a-mali - mediatek,mt8183-mali - mediatek,mt8183b-mali + - mediatek,mt8186-mali - realtek,rtd1619-mali - renesas,r9a07g044-mali - renesas,r9a07g054-mali @@ -196,6 +197,23 @@ allOf: required: - power-domains - power-domain-names + - if: + properties: + compatible: + contains: + const: mediatek,mt8186-mali + then: + properties: + power-domains: + minItems: 2 + maxItems: 2 + power-domain-names: + items: + - const: core0 + - const: core1 + required: + - power-domains + - power-domain-names - if: properties: compatible: From patchwork Thu Mar 16 10:20:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 70726 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp403566wrt; Thu, 16 Mar 2023 03:37:52 -0700 (PDT) X-Google-Smtp-Source: AK7set9FlAOVYpehT0Z+WJ/IWQWN/xIRbMA75hB1UqcaewdOQp8Lu3M78ngFCZ1/3sbkZiwuhet3 X-Received: by 2002:a17:902:d488:b0:19e:2860:3ae8 with SMTP id c8-20020a170902d48800b0019e28603ae8mr3214662plg.33.1678963072495; Thu, 16 Mar 2023 03:37:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678963072; cv=none; d=google.com; s=arc-20160816; b=C0G/hMyD+iMf8OuE35uhzwyp1ah2nIRIan1RtoEqYG7Uwhzkt+WVFDohNi8olGYzKJ iUW6ZeqMbmTJYzJ2ydjpjYmKiwAofm5/dGysTM4lcGjqrhLDZJIRQCY+N63DCaXKxnet 8wk9Wd22Mvj0qBjf3rj8cxxl8j5jGp+YPoW90PKfmptGY4deyDfQeAmpcBA/fJrG8jy9 QkzFAPXz+RbPBvlIh5JGU0H2V1n99Xz0714bOcjCoxbUYiQPExDL4lqU+Gc4PEOLKol/ MPOpeoy2pM3GTbLRI7NCbaykj4kgjBfEAnQnxs4VAMzJjw9x5zHfizVrHnMTo/ZiwqYf 0CjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=giKtQTON/TdzLVpitntbmk6krA10Dtr2JBzVqO8dvVw=; b=x8DTANtvr9Bt5mfuf81OEiKviQ69y4RkfHxFsftfn6qPu1nrGucHJeJR/2ThzuemiW WjUDIZdsIZlHrD0Csr3WF0lAt2zXQrLScZWERNd1e5dP4kb0bbQVya/E0p7sr9A21Wau /UVTJdif9hTztPa1U92O9YKzq6Z/bW2f/d9B2TdlcNX00+fE5KTCmIjUQxYzmEJAy9Lg LL5blld0shD9hXxNgDvDapbOjjbJHU3IqIkWqREnX61LWGNHOUCZTCtZpR0rWeSid6Y8 qf5mXcbcSARdKMqZIVnjD2PpaDfTeQX4B6sh+wccZadc+Wieg/8UY9S80Fw4xLVBdQZv L+jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=PH0QDH67; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e18-20020a17090301d200b001a0767b58d4si5821120plh.81.2023.03.16.03.37.37; Thu, 16 Mar 2023 03:37:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=PH0QDH67; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231252AbjCPKVh (ORCPT + 99 others); Thu, 16 Mar 2023 06:21:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230517AbjCPKVJ (ORCPT ); Thu, 16 Mar 2023 06:21:09 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05B98149B9; Thu, 16 Mar 2023 03:20:56 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 7DF9466030A3; Thu, 16 Mar 2023 10:20:51 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678962052; bh=K9yinOJko6zzZkMe4qGeCS9OW1OYLujXAPuZpWyodhg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PH0QDH67wQD+cAv/qmvs91HIUbrel0QvgoAcHb3NbKlvwiMFxyZShkUgQQCuHLooI 5k/R79dq3TBk175tqXtAx6JGwCy+iIsly/SBouQctONXkNHQWqxxPgzDN6AVyrz/7b aXyIeupRe6nxRD70u2Xv23d2oOiGtcWYQNZtpWBqAJFoSOpJfZPIN5RKvZolsp1Kea ArxzsDFwwpcbddr1CSkAdD/QYSa926f/a67HSQpuPcUHMCsaCuFzICRarHa5a6qeIe d/d+1uw/yX7E/yTixPBVM+Bghyf7hhhlwhNUrpwqkxkdPCFN6rZM5OJA+pSw3jt8CS TvP7pN0VLbdhg== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v5 07/12] dt-bindings: gpu: mali-bifrost: Add compatible for MT8195 SoC Date: Thu, 16 Mar 2023 11:20:36 +0100 Message-Id: <20230316102041.210269-8-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> References: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760520382608398234?= X-GMAIL-MSGID: =?utf-8?q?1760520382608398234?= The MediaTek MT8195 SoC has a Mali G57 MC5 (Valhall-JM) and has the same number of power domains and requirements as MT8192 in terms of bindings. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Rob Herring Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 3d0d96913b1b..3eb9a4e95e92 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -27,6 +27,11 @@ properties: - rockchip,px30-mali - rockchip,rk3568-mali - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable + - items: + - enum: + - mediatek,mt8195-mali + - const: mediatek,mt8192-mali + - const: arm,mali-valhall-jm # Mali Valhall GPU model/revision is fully discoverable - items: - enum: - mediatek,mt8192-mali From patchwork Thu Mar 16 10:20:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 70721 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp402843wrt; Thu, 16 Mar 2023 03:36:21 -0700 (PDT) X-Google-Smtp-Source: AK7set/IgweIP+C4Al7L/txhuZchQ7ktSmVZLg3TIXq7EhNSRjUlgk58mOdZoFUPqPeBhZuhsqBN X-Received: by 2002:a05:6a20:548d:b0:d0:44ab:e68a with SMTP id i13-20020a056a20548d00b000d044abe68amr4248786pzk.38.1678962981189; Thu, 16 Mar 2023 03:36:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678962981; cv=none; d=google.com; s=arc-20160816; b=DA9qmdDnG6k5fuECjR3c4oGJbhwl52Pb21ydrwxVAiaETg6ZW0DF8rQ1HXkY0icAdI aepXUkgkvJE8dU4gsYbiCl0oH7jCUmjG0gDRaF5Eq4qTGfptxN3xPmPtsQYjRmT7d+yp bWvJ55RUvShykMSM9JLGpPyPEtfdC+WpgZpqNE0q/nf62TAQk6WImnwePdMWJp49HlMP NJMjxxdXODWxQ3RT7TUbmFnNoswz5NayD4wrSKdOVDAWNnhbYpbIXaQV8DQbF+wOV9SU iQIBTQp7J5/9/lcBR2+ookHNq97CTzfFGN4xFQM/L3PuSBZvQ9tQL4qdHfavllmWSghY j7zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/tOIXNwzcElpWNQFLLTxtelW7iGoZmYgQCOsMo7QEr8=; b=RmPUR3I/dvoU5XpNQDlA+ydJRx3WyRPbfCiy3WcyGIRRyeVo/PVISbfc+70ixZNTyy o9VMcJogZm0K7ni2Tq8Huz1+cjO/HQFiPa61U6FBLZyx/JGNf92HHRShVPLPNzhlsmJ6 Al0WRUAJ/eHDMe6lpL0WV40abp7tW0bO2KhTiVefbiMrofL97lyBWp+8ZH126MZfJrlW zLgY9uY9JGNLsk3gYf61SfJ5UnRWbr4Sr7dEyzVGWHaaBTwy5LhBFo/6/V8xFLKX1C4K nnqgCHw9q8e+7Ca7kylYDkofFtO/J1Lr9qMW9Pi/VniH2y8MxrFdw1Bi/sv/Ffe7jaMc Vbeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=en3zTI6J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x9-20020a655389000000b004faf0a78c50si7349679pgq.110.2023.03.16.03.36.04; Thu, 16 Mar 2023 03:36:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=en3zTI6J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230430AbjCPKVn (ORCPT + 99 others); Thu, 16 Mar 2023 06:21:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbjCPKVK (ORCPT ); Thu, 16 Mar 2023 06:21:10 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06116BCB9B; Thu, 16 Mar 2023 03:20:56 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 67A6066030A7; Thu, 16 Mar 2023 10:20:52 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678962053; bh=3GXafAdQmj7KJvnDtfsbN8H0g0sDtqhLZbndyfx7ewg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=en3zTI6JULuMGdA06Z2jl35WgPdA4yH3N2FqGUtRMZJtXhCSdQSV44iTOILb3qS+l 9PhbxcxSa+0zcDjwEKBEbo6nvU/tl639ddlwJ7ZCGn5Ep7Nd8JlmXQjWDakKl+XbgS p4+AvyVhiKHNnASdYmtVvHsKKzq/pWOEJJ/d2DXve/dLrNkmnUawtyWBWl2gFaQLpJ hNMMdpLl78ssCYXhKRx6js5Wr2FEfO6kCsnKyK3NA8T+ItFgttygCva+a0rW/lrdBa o0UbQXNvJPD+fIzHG7EWTMJVG1xnGo82OhVe90HK2tSlVtShT961P0mSuo+6/rbmo7 mBMcu7rW6Dclw== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v5 08/12] drm/panfrost: Increase MAX_PM_DOMAINS to 5 Date: Thu, 16 Mar 2023 11:20:37 +0100 Message-Id: <20230316102041.210269-9-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> References: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760520287104971521?= X-GMAIL-MSGID: =?utf-8?q?1760520287104971521?= From: Alyssa Rosenzweig Increase the MAX_PM_DOMAINS constant from 3 to 5, to support the extra power domains required by the Mali-G57 on the MT8192. Signed-off-by: Alyssa Rosenzweig Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai --- drivers/gpu/drm/panfrost/panfrost_device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/panfrost/panfrost_device.h index d9ba68cffb77..b0126b9fbadc 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.h +++ b/drivers/gpu/drm/panfrost/panfrost_device.h @@ -23,7 +23,7 @@ struct panfrost_job; struct panfrost_perfcnt; #define NUM_JOB_SLOTS 3 -#define MAX_PM_DOMAINS 3 +#define MAX_PM_DOMAINS 5 struct panfrost_features { u16 id; From patchwork Thu Mar 16 10:20:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 70711 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp398458wrt; Thu, 16 Mar 2023 03:24:58 -0700 (PDT) X-Google-Smtp-Source: AK7set+qq4239ESrWMw4TgFbviYzyglTXynQHQFnwseHS2P7LTG8Ls/kKxVpbC0EdjlmN9Aajegg X-Received: by 2002:a05:6a20:8f15:b0:d5:8a5:e61e with SMTP id b21-20020a056a208f1500b000d508a5e61emr4032819pzk.11.1678962298404; Thu, 16 Mar 2023 03:24:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678962298; cv=none; d=google.com; s=arc-20160816; b=TQIk/RRC5wdvfAFWFrTQnblRKhxQ1pZGPnkwNNiWaAKXfCbUcQA7YcMd3ursKBaqJm IjiPU+m6d3kz+RIQPNpFngBI/hlA0Qo75pYvUgTIzwExMu40tft3WnU5o3TQnVAeSgRH z1WadF/2Ez35XHtjr8XgAY5vK87h4vl8JaLjESxN252EG7/hw5xhIOX2t2r/29FppIQO gsYts4ufOBpEAXahqQcu5JFjA1WRminZZSotyfMIm/owmr+Ul/3VwcID/mnWbUhEMcdk VVzcdwXIuZ4n5WyDghe/+xpEC8QNMiNDg5XFB6SbdWHKQEPonLgYC58wqCYKD1zhADJ0 cRLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=x1+DhHjPcSJbA0eqqcLjb+ex/IqQCVdtTHn2Cytfl20=; b=QspU434p2Qps2d1GAcsS5d9M4Q2EBr3p6bv07RuzbK/ZNsDCXpweAMuqErM3qBK5VW If6g80f67RdOjsKteUJtmrieH3PUW7+ryfehiQggKoArWToYYUn4JZNLn5yFPlidPl2G Ns+EaayiLhZHHny5P/DL6T783oXj3cXQUrDzjTKZnR+ggE030akqov7PsaOxtLb+huCF d/57fCSSva71s/EFtyjSkvY4shEUu+lnYjXDTnf6e/K+k/JuGxd5l7CKPdIA72qPk1aW PaWqO+ZV0RFwprhcPEEuYXlh1fDbClGYRWqWj6NjUHPPmTA8u8vdSJrJTkDXaVltzzL1 ghRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=W8HjQ4jW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h9-20020a631209000000b00502d81ecf19si7352879pgl.646.2023.03.16.03.24.43; Thu, 16 Mar 2023 03:24:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=W8HjQ4jW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231316AbjCPKVu (ORCPT + 99 others); Thu, 16 Mar 2023 06:21:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230179AbjCPKVL (ORCPT ); Thu, 16 Mar 2023 06:21:11 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF593BBB3D; Thu, 16 Mar 2023 03:20:58 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4D4D966030A8; Thu, 16 Mar 2023 10:20:53 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678962054; bh=tqMhjHDqyf9W8dBe5zrV6xBWEsaXyIn78lwVXQZBTKI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W8HjQ4jWTnPPa1xbsH5ty3//pOcwvc6EEOM8oaoUH9B5Lsytcw8cka9PfoYvzeDKa HSbRn96OzlC2Izzc+T53S8M7LPqceVuullDRTaz+Q8fd8xlo53gjmnxR4XMpQco8ZQ azu+rKOc4Odp5mBAxTnXbSFUZbGfYnONPRuW6vl1efpZgHky+RD49KvC9pfeS6WR5h gIlwrtoKk2ouFNJlUJon9St7OmcifPL8toK50aRb04bxUqYLFFNCdWqK/3M1AfoinC 5shGEDTrupd8XVc90oS/JUuZTKasyJqMYsGp3HDCURwBEmm612z9O0d7er4lJNz5pq YuzoHIZ/k+IQg== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v5 09/12] drm/panfrost: Add the MT8192 GPU ID Date: Thu, 16 Mar 2023 11:20:38 +0100 Message-Id: <20230316102041.210269-10-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> References: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760519571131144753?= X-GMAIL-MSGID: =?utf-8?q?1760519571131144753?= From: Alyssa Rosenzweig MediaTek MT8192 has a Mali-G57 with a special GPU ID. Add its GPU ID, but treat it as otherwise identical to a standard Mali-G57. We do _not_ fix up the GPU ID here -- userspace needs to be aware of the special GPU ID, in case we find functional differences between MediaTek's implementation and the standard Mali-G57 down the line. Signed-off-by: Alyssa Rosenzweig Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai --- drivers/gpu/drm/panfrost/panfrost_gpu.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c index 6452e4e900dd..d28b99732dde 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c @@ -204,6 +204,14 @@ static const struct panfrost_model gpu_models[] = { GPU_MODEL(g57, 0x9001, GPU_REV(g57, 0, 0)), + + /* MediaTek MT8192 has a Mali-G57 with a different GPU ID from the + * standard. Arm's driver does not appear to handle this model. + * ChromeOS has a hack downstream for it. Treat it as equivalent to + * standard Mali-G57 for now. + */ + GPU_MODEL(g57, 0x9003, + GPU_REV(g57, 0, 0)), }; static void panfrost_gpu_init_features(struct panfrost_device *pfdev) From patchwork Thu Mar 16 10:20:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 70722 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp402907wrt; Thu, 16 Mar 2023 03:36:29 -0700 (PDT) X-Google-Smtp-Source: AK7set+WUkjaIi6cVk0aln9IlKTemIqNecr9zqr8V/1Ni9lLzcl4gG1DXIe+MyKTY5/eSuNYeD0+ X-Received: by 2002:a05:6a20:4c08:b0:d6:52a4:561a with SMTP id fm8-20020a056a204c0800b000d652a4561amr3083611pzb.52.1678962989239; Thu, 16 Mar 2023 03:36:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678962989; cv=none; d=google.com; s=arc-20160816; b=f8o9XTGlmm/llDXCs/6PwZ4pm/YSLeUAhDiA27N9BzPgaS+RDH+9/zby5471Jw1IKK 0NZ3ZhlMaIFbjQ9YYFy7T7SmQ1GW89EEEgmH4yFeENz020KY0pzPaf9qJ3IZcRbmhizi +/6qCzB5MiFKJLszPOYFSaGTAGvjnMMlZujrEvF3Frmy+sBKlq0f8caBZY33xkvNx/nz M97YXhqGJu42nQNMSc7nmlDEaH6GUB9xHK8a261Jz1CfT99odQWuJy6HULfyhI4s1QWV DVsIhvluOqk6pdS5BJVOGidLD1rAm+Ra9JcMH113SLCOVG6gWP2hdBOjBgNsUt80bphG LbGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RSrQdn/bX63ggDVrCdEzTLh2BCZytP9HBj8phJjyRTs=; b=PN1oEf+DjPp3n/iczkvn9aEMf8a/2H5q/R+b7gNvCOEfJQuxJJzXctIW04PzCL1Pvl N2fDGDYGothf4ib9mD59881VASlrRSs84R8q+UG8lMk6wpVLZ4sViUP9EKLbNc/BIdOX BhXJ1zZDndFFXZUp+6IbjbjF8fYJzYi8JU5c97KnaPckqgptHUZGYSkU8fBjakmZ+D8Q T0He/w5LXo3Jljj0tf4eswjxZDs4csuZaIhdlwV+LSNAiNbkOVHebcNS4fgjhersFtRu m0bEmjrUhdEcDQHFAPSbHpCH0fweEkz9FDpAZkZCqTVJ4ykfgQD4KrCj8782+k55R/Nl UC3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=V+ebgBXr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j18-20020a635512000000b004fbd58ce355si7118893pgb.511.2023.03.16.03.36.11; Thu, 16 Mar 2023 03:36:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=V+ebgBXr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230499AbjCPKVx (ORCPT + 99 others); Thu, 16 Mar 2023 06:21:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231133AbjCPKVM (ORCPT ); Thu, 16 Mar 2023 06:21:12 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF843BD4E1; Thu, 16 Mar 2023 03:20:58 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3278466030A5; Thu, 16 Mar 2023 10:20:54 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678962054; bh=zaVPC8a/zjPKkMkKy2u0SknVPayDnrlxaZ88LGSOuPI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V+ebgBXr59zxnfFqZTRha1fbz/sXBfiDuR3wz4sIfqE/TQ4J9AbE3/XQpH2LGrDjk I7OA2HII3H2o9DkwjN98y5HpFsScHJli/w165lcNfVJdfo6E0caSfhbfdSCmCaW7x4 ZsN9by9bR+7sqhKL8hZKStk2J/tnqF0cm9hbBelMEYFTFNzgmfikxiHvhXW3SRx/1H McZoEAyZvv7bwEzcScDFwZHRQsZzz8/t7KbdnhYncpQPPwJfelsXm0zJRfPn4nb4TY zWcejFyTAo0xah/I2OXNetcw+Io8wvB2VWxW+ONsCOKbhOantTDqr5ZidQI5raWz9k fkxEFQntyhYVA== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v5 10/12] drm/panfrost: Add mediatek,mt8192-mali compatible Date: Thu, 16 Mar 2023 11:20:39 +0100 Message-Id: <20230316102041.210269-11-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> References: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760520295528538393?= X-GMAIL-MSGID: =?utf-8?q?1760520295528538393?= From: Alyssa Rosenzweig Required for Mali-G57 on the Mediatek MT8192 and MT8195, which uses even more power domains than the MT8183 before it. Signed-off-by: Alyssa Rosenzweig [Angelo: Removed unneeded "sram" supply, added mt8195 to commit description] Co-developed-by: AngeloGioacchino Del Regno Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai --- drivers/gpu/drm/panfrost/panfrost_drv.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index f49096f53141..45c4accb6a1e 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -656,6 +656,16 @@ static const struct panfrost_compatible mediatek_mt8183_data = { .pm_domain_names = mediatek_mt8183_pm_domains, }; +static const char * const mediatek_mt8192_supplies[] = { "mali", NULL }; +static const char * const mediatek_mt8192_pm_domains[] = { "core0", "core1", "core2", + "core3", "core4" }; +static const struct panfrost_compatible mediatek_mt8192_data = { + .num_supplies = ARRAY_SIZE(mediatek_mt8192_supplies) - 1, + .supply_names = mediatek_mt8192_supplies, + .num_pm_domains = ARRAY_SIZE(mediatek_mt8192_pm_domains), + .pm_domain_names = mediatek_mt8192_pm_domains, +}; + static const struct of_device_id dt_match[] = { /* Set first to probe before the generic compatibles */ { .compatible = "amlogic,meson-gxm-mali", @@ -674,6 +684,7 @@ static const struct of_device_id dt_match[] = { { .compatible = "arm,mali-bifrost", .data = &default_data, }, { .compatible = "arm,mali-valhall-jm", .data = &default_data, }, { .compatible = "mediatek,mt8183-mali", .data = &mediatek_mt8183_data }, + { .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data }, {} }; MODULE_DEVICE_TABLE(of, dt_match); From patchwork Thu Mar 16 10:20:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 70717 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp401473wrt; Thu, 16 Mar 2023 03:32:57 -0700 (PDT) X-Google-Smtp-Source: AK7set8pu+uOpiE3RgBV6JHjTWvOHn3Qeg3TRO95W3QHgJX7/zqUQPYa08LzvBpZaN0N7haV9g+b X-Received: by 2002:a17:903:2850:b0:19a:7f4b:3ef6 with SMTP id kq16-20020a170903285000b0019a7f4b3ef6mr2563537plb.3.1678962777444; Thu, 16 Mar 2023 03:32:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678962777; cv=none; d=google.com; s=arc-20160816; b=sERSSJMGAEcy+rhBI96DDnMI6jeyOEasfeBLXuSYeJJT+QMraije70zgJUSJIE23Xv Xk+QyzZul2JeNGbRiGuM5pdOM/0wLYEJVVUrafCf78RsYnu0ahUAEb3ZIBYKL+95udJ+ 1N0yoWTsGEcVznnHoyU/FFvat1upnNG7rXh4J6/AfLLkVVFB2LCJ5gJsdpUidO45ng7p GZuCIWzCLfYxL9SVmh9Ioh+DrNKujB2rdPY6VZXZXMU4Q5mIPFX1I8339DkxehJv6Lqc Iv/NboM2vyB3jsELsNlFo3OeAWLpKspoFNvNekJnc+0vl1bIzZ08ll8P//sk5mXveOu/ FALA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SkWIcQMfXmIedj0FqFpfLTXOof7ONZKZBfHtu4sGqNI=; b=0tzY9KsnnvrSSEN2SQuOu+0BNGH23BYYTNKxRP/zZBXKiD1ntmtxnrIV4vAYH+zDQC NfDvbvlvCFIAVZS5HduCpadjHqlRrF6Uf0/S1yeMyRzCB1kcraPZnK7Pt/+rOhQvRYwY omYSAjdqw0QMxm4ayh8BFTESryUULLL60ByLKn3LqgVg/9nb2mo4VmPPSCl9whQxkv0V ku+GK0u5mVuy1HPvwGPH7QAqKwBkKJM4KQ/F8lLMktbm0zsdBd3CEv8UjL4dQtaecLQn qwyvqaMmucf9NEDGDSHNds5oLx6ioksZcIAoJm9+EMqvOv5TT5wXxRXdwAgCfrjomnvj /AOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=CmOentXJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d15-20020a170902728f00b001a05a1735d5si7713458pll.403.2023.03.16.03.32.39; Thu, 16 Mar 2023 03:32:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=CmOentXJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231326AbjCPKV4 (ORCPT + 99 others); Thu, 16 Mar 2023 06:21:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231137AbjCPKVQ (ORCPT ); Thu, 16 Mar 2023 06:21:16 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E4AABDD08; Thu, 16 Mar 2023 03:21:01 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1797366030AA; Thu, 16 Mar 2023 10:20:55 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678962055; bh=lEySQxwP+CBzmjLe1Ez9oQHJ1wF/3PthJcz2r8dmYDI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CmOentXJT+KPr7n9fi+2MDCN9eA3JjDJSnGJbJ06B2ipD5GxazaCZ7c16Tyt+ReGM 9tzHzUTQuPdYS2V8jfwVebQYT4RuEWgeHQA04tqgXFiWjD7+sDOnp8JixJEB/ohvbj GmU2FbIAxbYAnDCHUXxsJmunQoB9ASfx5JI+1iQK1XMJOmcXvO/1AAavxHMVKRjx86 qeu+X/HAomJ8hEobxCUh1rIgN5SaatpYuJcQydfB5MwXh0D0/fAvdXXhjN8APoSx7f SwijZdQomMhXJkuoXC8bGoyTwbPwGvU/tiYbgyuX233UWEPyK//40tOGx2geBELVfO f3PRz1uFlrtWw== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v5 11/12] drm/panfrost: Add new compatible for Mali on the MT8183 SoC Date: Thu, 16 Mar 2023 11:20:40 +0100 Message-Id: <20230316102041.210269-12-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> References: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760520072999837042?= X-GMAIL-MSGID: =?utf-8?q?1760520072999837042?= The "mediatek,mt8183-mali" compatible uses platform data that calls for getting (and managing) two regulators ("mali" and "sram") but devfreq does not support this usecase, resulting in DVFS not working. Since a lot of MediaTek SoCs need to set the voltages for the GPU SRAM regulator in a specific relation to the GPU VCORE regulator, a MediaTek SoC specific driver was introduced to automatically satisfy, through coupling, these constraints: this means that there is at all no need to manage both regulators in panfrost but to otherwise just manage the main "mali" (-> gpu vcore) regulator instead. Keeping in mind that we cannot break the ABI, the most sensible route (avoiding hacks and uselessly overcomplicated code) to get a MT8183 node with one power supply was to add a new "mediatek,mt8183b-mali" compatible, which effectively deprecates the former. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai --- drivers/gpu/drm/panfrost/panfrost_drv.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index 45c4accb6a1e..4f39b410302c 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -647,6 +647,14 @@ static const struct panfrost_compatible amlogic_data = { .vendor_quirk = panfrost_gpu_amlogic_quirk, }; +/* + * The old data with two power supplies for MT8183 is here only to + * keep retro-compatibility with older devicetrees, as DVFS will + * not work with this one. + * + * On new devicetrees please use the _b variant with a single and + * coupled regulators instead. + */ static const char * const mediatek_mt8183_supplies[] = { "mali", "sram", NULL }; static const char * const mediatek_mt8183_pm_domains[] = { "core0", "core1", "core2" }; static const struct panfrost_compatible mediatek_mt8183_data = { @@ -656,6 +664,14 @@ static const struct panfrost_compatible mediatek_mt8183_data = { .pm_domain_names = mediatek_mt8183_pm_domains, }; +static const char * const mediatek_mt8183_b_supplies[] = { "mali", NULL }; +static const struct panfrost_compatible mediatek_mt8183_b_data = { + .num_supplies = ARRAY_SIZE(mediatek_mt8183_b_supplies) - 1, + .supply_names = mediatek_mt8183_b_supplies, + .num_pm_domains = ARRAY_SIZE(mediatek_mt8183_pm_domains), + .pm_domain_names = mediatek_mt8183_pm_domains, +}; + static const char * const mediatek_mt8192_supplies[] = { "mali", NULL }; static const char * const mediatek_mt8192_pm_domains[] = { "core0", "core1", "core2", "core3", "core4" }; @@ -684,6 +700,7 @@ static const struct of_device_id dt_match[] = { { .compatible = "arm,mali-bifrost", .data = &default_data, }, { .compatible = "arm,mali-valhall-jm", .data = &default_data, }, { .compatible = "mediatek,mt8183-mali", .data = &mediatek_mt8183_data }, + { .compatible = "mediatek,mt8183b-mali", .data = &mediatek_mt8183_b_data }, { .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data }, {} }; From patchwork Thu Mar 16 10:20:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 70712 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp399293wrt; Thu, 16 Mar 2023 03:27:16 -0700 (PDT) X-Google-Smtp-Source: AK7set847WKiV164dk3WjBs2T3sIlOClG48GpHW7nvS4kFJPf4WEDHpTrn4qRj4DYvMuFua7cfhu X-Received: by 2002:a05:6a20:6711:b0:cb:f565:1001 with SMTP id q17-20020a056a20671100b000cbf5651001mr3076364pzh.15.1678962435741; Thu, 16 Mar 2023 03:27:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678962435; cv=none; d=google.com; s=arc-20160816; b=doLjjaGs1i4CI7Ef6/sCuJ04I9c0B2CcT9qtB+pvQ0n5KhP6s8ED0y1GE8gTT5BKyJ C3fBD4sReVakErPzO9bYzkgyOTvjdXdJ4AlNLp5uV8b3hEFEPzVxSRJ+RICi2yeKr/GA v6JgWSTZiGfbQQiQ+SHQxe1itAySSy0A0oMT2CDBkqmC0s8YQqQlVRl+2s/5W1ZxofQs nshIL6JxA6MwATUuOaf13HvrgPIpUj5COJ9wLwGeNvbnZKQC+p4w7/hJJQr7l8yeRHGS 966lHAiUqRaUwJevM1vqSFMg4J4MLVWUqVHz0kkv5V/BKzI0BJMRDlNeSJNOr5oin12R Xw2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=uYF5ZMV5YSmFW35EGOiHVFrm/JH0vcqvy+bl9OjTjGE=; b=wFU3SNA+H3Cxk+WtK/LYJDCUmdJqPLo1sIWKZdFhkAzOATHB2a51D1b48xibm+L4iz PTgfalCiIqA/i8TvFnatuOEFYFvyeacAuBtGpwoWWypHLY6cCX5uAItM9zqY1rA230QS QoVL+eQNs0cvQGd1qOo1HvlIO3D+vsUTNiy9+iB019kab5zoF/QyDaw0/KyRLrEE6ym0 3SbrAIf0J5p6OsRPAugLKjY9G7cJuShwkg2Y4iUDdH4GtiO7hspvfGYjqG3n61rJS1LH 8kMbccNn1IC6/uJbjYEK5Yd7AqOl7qzefO/V78he8MeoSJumkPDKA29ptAM7eYWVEvwt Sviw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=MbXRKWlm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h9-20020a631209000000b00502d825633asi7367934pgl.639.2023.03.16.03.26.59; Thu, 16 Mar 2023 03:27:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=MbXRKWlm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231332AbjCPKV7 (ORCPT + 99 others); Thu, 16 Mar 2023 06:21:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230447AbjCPKVQ (ORCPT ); Thu, 16 Mar 2023 06:21:16 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0953CBD4E6; Thu, 16 Mar 2023 03:21:01 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id F1A0F660309D; Thu, 16 Mar 2023 10:20:55 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678962056; bh=6DBVKIIHG8WZZ3ntbG1VNgOpsrN60zwSXj2PzGrIUrQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MbXRKWlmiz0cDiInj2vV5mKScoT/lZkY25h1C8iu8wTWzLudoPjB68uvEUYSKXkjD HHP+smP827Gc38cqEDXPjAAaPU5jBbNNqcwkuUXn4/v7lgtXUjARhXTePEPi7JFfyl kfhIOYrGcMrLKaz/TN2mf1XJHRu8kaEKB3Ncn3kJd6o/asHXUrbnIt1x6yIVWUepG8 ckMf9jds4JjYEQNWDZepYz63jS2tg0UyF5gcDtrK0KYOR+77EWKqsY1PIEJMzBW+8X nMpYv7dvDbHG6av2kGdWh+DAlqs8gTyIEiB59yGF5+4GzsjvR/Ucq539rfqGztng6b nNOUIvNpnRYUg== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v5 12/12] drm/panfrost: Add support for Mali on the MT8186 SoC Date: Thu, 16 Mar 2023 11:20:41 +0100 Message-Id: <20230316102041.210269-13-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> References: <20230316102041.210269-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760519715155165684?= X-GMAIL-MSGID: =?utf-8?q?1760519715155165684?= MediaTek MT8186 has a Mali-G52 MC2 2EE (Bifrost): add a new compatible and platform data using the same supplies list as "mt8183_b" (only one regulator), and a new pm_domains list with only two power domains. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai --- drivers/gpu/drm/panfrost/panfrost_drv.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index 4f39b410302c..bbada731bbbd 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -672,6 +672,14 @@ static const struct panfrost_compatible mediatek_mt8183_b_data = { .pm_domain_names = mediatek_mt8183_pm_domains, }; +static const char * const mediatek_mt8186_pm_domains[] = { "core0", "core1" }; +static const struct panfrost_compatible mediatek_mt8186_data = { + .num_supplies = ARRAY_SIZE(mediatek_mt8183_b_supplies) - 1, + .supply_names = mediatek_mt8183_b_supplies, + .num_pm_domains = ARRAY_SIZE(mediatek_mt8186_pm_domains), + .pm_domain_names = mediatek_mt8186_pm_domains, +}; + static const char * const mediatek_mt8192_supplies[] = { "mali", NULL }; static const char * const mediatek_mt8192_pm_domains[] = { "core0", "core1", "core2", "core3", "core4" }; @@ -701,6 +709,7 @@ static const struct of_device_id dt_match[] = { { .compatible = "arm,mali-valhall-jm", .data = &default_data, }, { .compatible = "mediatek,mt8183-mali", .data = &mediatek_mt8183_data }, { .compatible = "mediatek,mt8183b-mali", .data = &mediatek_mt8183_b_data }, + { .compatible = "mediatek,mt8186-mali", .data = &mediatek_mt8186_data }, { .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data }, {} };