From patchwork Thu Mar 16 03:28:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Chancellor X-Patchwork-Id: 70557 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp269951wrt; Wed, 15 Mar 2023 20:50:34 -0700 (PDT) X-Google-Smtp-Source: AK7set+YvWX3ZEro/kdMXZmsdT8PmEmnOkmdaTd/aFE/Lju+wZIJZkZB6ybQQlyBWOh8hpNFFumG X-Received: by 2002:aa7:9591:0:b0:625:290:e303 with SMTP id z17-20020aa79591000000b006250290e303mr1959719pfj.14.1678938634155; Wed, 15 Mar 2023 20:50:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678938634; cv=none; d=google.com; s=arc-20160816; b=aafub4kbNiZ66Rlfj5W5vX6CHPwT4ZRgLMiXi2sBu5mNAJhSG/gIcF8mzkLp3phfuN nLZipZeZy3zCyHGYYcJl9SKy92+zrnV0XdiT0DjNGqasmMQ0O8hMeNlpaEvIc325cIam SXINxnwxX01LW7E+JPGR6XmGXsjiRW6blrrBHCq2343+6gIQGg08/KsNp9WxXDZGcLp/ n7FAavUh6/gwyhxopijPCHVgAO/u+0EhHIgFRDkUOHmYt8qOGd3k1zZIgGF24jwv/L7v 9yPND+ZXJaR2xhFLj85wY2O2MMaMW4iFIRvu4ulk6gov/PejgKTlT8t6wyMpsnZgx42R jwpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=lHCYvdXV3Jt7J9svxe6DFH9rhVe5V56bEeL30eK3U04=; b=0Pfok3g3mlVz+2lMUAmp6ljHdG7o9+Q2RvZ48oIZzgRRs555WiDupP+u1eEgax0YSZ mzDUj91RiXUPJcgGWHH721gLaPGS5DSGSReBl3IJ2HxvYZXDCLmD3YI+LCYIhwJ5NOxT Nd5n30IT2/iumIO+W9Eobjcp/nNG4ehLnc6QxkSS0kNjltyLm+DOZbv0a345TthJ3HPu CasoQp8Yta2B5co5UQe9xiKwv8NAdDK/gTn1pmNnuGL6vgD/RTWPfcyt308IBnSn23ya d5MtntVkscnJutTs50Wa/EaDbB5v2LrmSODV+Fp2OmJlATWRqcJwYHUer2248bIxlOO5 TICA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dK5puxNu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w188-20020a6262c5000000b005ecf91666b8si6505748pfb.184.2023.03.15.20.50.20; Wed, 15 Mar 2023 20:50:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dK5puxNu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229987AbjCPDaj (ORCPT + 99 others); Wed, 15 Mar 2023 23:30:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229707AbjCPDaE (ORCPT ); Wed, 15 Mar 2023 23:30:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA3BD12BEA; Wed, 15 Mar 2023 20:28:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4D61561EFC; Thu, 16 Mar 2023 03:28:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15F79C433EF; Thu, 16 Mar 2023 03:28:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678937322; bh=oPPbw/PBxWk4Q1egWNZu46IiHqVVJx0VcMlY4jCe0r0=; h=From:Date:Subject:To:Cc:From; b=dK5puxNuRC2Gzse9fmdtPqVr8NzvsDuYp6512mAIgwsKgwKmeOxp7CJB2R9+9Ou9G uDEds2QwFKgzfWUV+9kK5cPn2wVl2uFcB1kjc3V4Q2/qI5JSqh/kNSN8clftqpKSMu eTnrKC33xE+p45afNDUgrWvi57bhk02jzPq3DIsCps2AIN3yzT7MQjbQvCb1b2i48O BSKXIRGO8L3iiE2L82s4bMKiN0VGGMC89mp0vN6vefzjHwE5zspvVSe0vCVAaqMLoX n2zeCs3phymkgJR/NQtTT1Q3TPjCdPOar7oEiAnd5YuKZJB8m1XhbcVF2JFhPmLOIO QVvcqHXfGOAww== From: Nathan Chancellor Date: Wed, 15 Mar 2023 20:28:29 -0700 Subject: [PATCH next] wifi: iwlwifi: Avoid disabling GCC specific flag with clang MIME-Version: 1.0 Message-Id: <20230315-iwlwifi-fix-pragma-v1-1-ad23f92c4739@kernel.org> X-B4-Tracking: v=1; b=H4sIANyMEmQC/x3N0QqDMAyF4VeRXC/Q2jmKrzJ2kbqoAe0kkSmI7 766y5/DxznAWIUN2uoA5a+YfHIJf6ugGykPjPIuDbWrgwu+QdmmTXrBXnZclIaZMKX7I7jGR44 RCkxkjEkpd+NFZ7KV9RoW5cL+b0/IvK/wOs8f9BH5yoMAAAA= To: johannes.berg@intel.com, gregory.greenman@intel.com Cc: kvalo@kernel.org, nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1454; i=nathan@kernel.org; h=from:subject:message-id; bh=oPPbw/PBxWk4Q1egWNZu46IiHqVVJx0VcMlY4jCe0r0=; b=owGbwMvMwCEmm602sfCA1DTG02pJDClCPS9PBIRVTCzMT7V6Mm3FHN+FF6zv37l7/IPU+Z4uA etNSxhSO0pZGMQ4GGTFFFmqH6seNzScc5bxxqlJMHNYmUCGMHBxCsBE5r5iZDg5LzOr07ladcb9 mv9Lr/qGtUinP1rvWV/ktijzIaenaQIjw36LA09lr220P9kmfLDULGrDya/MM9ia7k55fSzX+1a 4LgsA X-Developer-Key: i=nathan@kernel.org; a=openpgp; fpr=2437CB76E544CB6AB3D9DFD399739260CB6CB716 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760494757094735119?= X-GMAIL-MSGID: =?utf-8?q?1760494757094735119?= Clang errors: drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c:15:32: error: unknown warning group '-Wsuggest-attribute=format', ignored [-Werror,-Wunknown-warning-option] #pragma GCC diagnostic ignored "-Wsuggest-attribute=format" ^ 1 error generated. The warning being disabled by this pragma is GCC specific. Guard its use with CONFIG_CC_IS_GCC so that it is not used with clang to clear up the error. Fixes: 4eca8cbf7ba8 ("wifi: iwlwifi: suppress printf warnings in tracing") Link: https://github.com/ClangBuiltLinux/linux/issues/1818 Signed-off-by: Nathan Chancellor --- drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c | 2 ++ 1 file changed, 2 insertions(+) --- base-commit: 4eca8cbf7ba83c3291b5841905ce64584036b1ff change-id: 20230315-iwlwifi-fix-pragma-bb4630518e88 Best regards, diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c b/drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c index c190ec5effa1..e46639b097f4 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c @@ -12,7 +12,9 @@ #include "iwl-trans.h" #define CREATE_TRACE_POINTS +#ifdef CONFIG_CC_IS_GCC #pragma GCC diagnostic ignored "-Wsuggest-attribute=format" +#endif #include "iwl-devtrace.h" EXPORT_TRACEPOINT_SYMBOL(iwlwifi_dev_ucode_event);