From patchwork Wed Oct 19 14:02:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 5536 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp345104wrs; Wed, 19 Oct 2022 07:04:52 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6CYyaQoOpG6m3f9wvaLgnxGmn1XtBUZ9hNNs7HzW+gygSthSkzKV+Pxx59vbWMi1NH+Vmj X-Received: by 2002:a17:907:da4:b0:78d:4bc9:2497 with SMTP id go36-20020a1709070da400b0078d4bc92497mr7040852ejc.183.1666188292840; Wed, 19 Oct 2022 07:04:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666188292; cv=none; d=google.com; s=arc-20160816; b=i3clXJW9NuQcGooec2OGrwfyo25vKrFmznAsqgFmIZv9FaABmjYeBLqVFQHqtbUD5I VPhC/m3PDdRlaAiWfwb2GlHakUkKS12wPWSXvC7s57MqXi+9mSvqDOQjvR2bUc6A5RxL 6LsKqyzVxFVka8lACE/z/x2vi0Axzw5CTZizDKh1JZX3Hw+2O5O7hGJntZr670l2AUrM ZZ6EmPcDlWXdeQE0dU0g6NVhpCQHOMr1MU2HcTGqqx/JwojpAKsH8fasXq+oMlQXV+9N ByF1bEpqDJoWkag+OMBcWGPXI1hhHuhtyUFUMTi2Ag+O2JUJ0nVQQxcqsdpHiHkZRPvo +D2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=m5DF2F8azQhkfjzzbAcSfAUOFvzUUOqupxnRAFtBigc=; b=yyXtUTP/gCqizkSSKJAxj04JC5lhmpf76VqFzeZgoOK+uvf7tfofdaAAnqI+GCRjNu J1ZN+/h2SIIRSjQxlWEbvdAh5cLaCgSwAKHz/+mylIa+UvnJM57YNWUwEYaHHf0sJWdG GcPUuIq2HpOfzpyistfdqWiT2jqj8l+fcHMP/oMVgxCkryAFqxVOD4jRX7ZWvkNYx5uY cPs2b8bZaaGjWNXk6dJtWWadJj9PMzvfreJ0afl9V61rcz3ayOOdbjJJcxhI97tLks3R wKrzSLWZH5jNqVVe+Lk8WgPOnQZGRvDlhSpbDTWHqcTxMfFydriljJ/tWXQqN2ni7Nrw nN9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=vyJacxbf; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id s18-20020a05640217d200b0044ab43cbef1si12395943edy.450.2022.10.19.07.04.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 07:04:52 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=vyJacxbf; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D1B633858029 for ; Wed, 19 Oct 2022 14:04:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D1B633858029 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1666188291; bh=m5DF2F8azQhkfjzzbAcSfAUOFvzUUOqupxnRAFtBigc=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=vyJacxbf+eRH0qceas1BX8e7VCEG40yCWxCBaQpZ2qwCNGPjXZRRfOURMO9I7cNPT jkoGPgUyQRC/SSvhnPvDy9fTTp71HbJ5J8EMyAO4bEL0Th0kMVz0meBov8jOPrjWYF rdO4XBgQQ6NIZmTJNx8tQr/lkmoLhvdg6HLGhdE4= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DD0BF38582AD for ; Wed, 19 Oct 2022 14:02:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD0BF38582AD Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-452-hoRNQrCVPLOfgUl0Waw95A-1; Wed, 19 Oct 2022 10:02:27 -0400 X-MC-Unique: hoRNQrCVPLOfgUl0Waw95A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7FBE2833B00 for ; Wed, 19 Oct 2022 14:02:26 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.194.255]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 240B34048D84; Wed, 19 Oct 2022 14:02:19 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 29JE2GY8044814 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 19 Oct 2022 16:02:16 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 29JE2GLM044813; Wed, 19 Oct 2022 16:02:16 +0200 To: GCC patches Subject: [COMMITTED] [PR tree-optimization/107312] Make range_true_and_false work with 1-bit signed types. Date: Wed, 19 Oct 2022 16:02:12 +0200 Message-Id: <20221019140212.44796-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: Aldy Hernandez Reply-To: Aldy Hernandez Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747125055141501634?= X-GMAIL-MSGID: =?utf-8?q?1747125055141501634?= range_true_and_false() returns a range of [0,1], which for a 1-bit signed integer gets passed to the irange setter as [0, -1]. These endpoints are out of order and cause an ICE. Through some dumb luck, the legacy code swaps out of order endpoints, because old VRP would sometimes pass endpoints reversed, depending on the setter to fix them. This swapping does not happen for non-legacy, hence the ICE. The right thing to do (apart from killing legacy and 1-bit signed integers ;-)), is to avoid passing out of order endpoints for 1-bit signed integers. For that matter, a range of [-1, 0] (signed) or [0, 1] (unsigned) is just varying. PR tree-optimization/107312 gcc/ChangeLog: * range.h (range_true_and_false): Special case 1-bit signed types. * value-range.cc (range_tests_misc): New test. gcc/testsuite/ChangeLog: * gcc.target/i386/pr107312.c: New test. --- gcc/range.h | 2 ++ gcc/testsuite/gcc.target/i386/pr107312.c | 11 +++++++++++ gcc/value-range.cc | 2 ++ 3 files changed, 15 insertions(+) create mode 100644 gcc/testsuite/gcc.target/i386/pr107312.c diff --git a/gcc/range.h b/gcc/range.h index 8138d6f5515..ba3a6b2516f 100644 --- a/gcc/range.h +++ b/gcc/range.h @@ -50,6 +50,8 @@ static inline int_range<1> range_true_and_false (tree type) { unsigned prec = TYPE_PRECISION (type); + if (prec == 1) + return int_range<2> (type); return int_range<2> (type, wi::zero (prec), wi::one (prec)); } diff --git a/gcc/testsuite/gcc.target/i386/pr107312.c b/gcc/testsuite/gcc.target/i386/pr107312.c new file mode 100644 index 00000000000..b4180e3bd7d --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr107312.c @@ -0,0 +1,11 @@ +// { dg-do compile } +// { dg-options "-mavx512vbmi -O1 -ftree-loop-vectorize" } + +void +foo (_Float16 *r, short int *a) +{ + int i; + + for (i = 0; i < 32; ++i) + r[i] = !!a[i]; +} diff --git a/gcc/value-range.cc b/gcc/value-range.cc index 90d5e660684..511cd0ad767 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -3437,6 +3437,8 @@ range_tests_misc () max.union_ (min); ASSERT_TRUE (max.varying_p ()); } + // Test that we can set a range of true+false for a 1-bit signed int. + r0 = range_true_and_false (one_bit_type); // Test inversion of 1-bit signed integers. {