From patchwork Wed Mar 15 18:18:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70359 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp53906wrt; Wed, 15 Mar 2023 11:31:13 -0700 (PDT) X-Google-Smtp-Source: AK7set//yjQ9QAWXXFlnzJek4MGThhKs1amYjXh7IQgWCGfJcAsZOyX02xkRZEL0LFuV/uzYdDP+ X-Received: by 2002:a05:6a20:69aa:b0:d5:6e91:f019 with SMTP id t42-20020a056a2069aa00b000d56e91f019mr841669pzk.33.1678905072808; Wed, 15 Mar 2023 11:31:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678905072; cv=none; d=google.com; s=arc-20160816; b=b9Wwkwupbnsqaw+6QK9s4Fkmqw3xbAvG1s2gZ8bW9Fm0kRuqK3JSNfK8jxCOdj+HGB VzOH0NavScgn63Xm8uEPdpQGvX0+nhfWawjBQXcpjYMENJEk3DAex8s7qpftbNsE0I9y 0hZrUcLSlU6zQfY6yKeXXjaxKzQXA6tFn+MRhY0RCxN43UOoF+Tqg3clQCtNJpe11OJ2 dYDMlR6HaalPHK9qRHgi9Y1TuKj+JTDr410ZMYhbbztcKKb11TksO0+FZSmGwxfYHtVr PgS7he+lhlxiEzZAcUYEOnfWcesCqawGR0Q+7YCQdhZZ0C4sje/lgpj6j65imLj4WAai EdHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=GgzilRrDZzjZzGZPzVxtA7dkKR8Cud+QjJJNSSQFpD0=; b=RfRjbitzAm1+RXGB9A2t+bKoSMZGsd/R/f2Zp3ID+JDmSSRi3gTSmXHCwvXanjULQb yLcCOK/3Uizl6cXlmHAq/dcJw0AVgFq8nTgmHHkS3Rp6/hXmyBig4RlkYAsoiTFv2Mqj yomZ3P7mydQbmUUfbV6lWvAx0FuELAC/p98r9iJiTI8vr7VHBi0CgGyYzdbfKDETjA5y HAoFsym1v6zCjpLqMky8jqE9U5TGBKo/zAKY4gQiD5XoTA2OTS+0Q/PtQuV685ij5SDf +NzdQI3KhPZttYk/cDcKjEEMvjJtzQvESqGg44gpftXejGnMWmxLjG7li20Hwp2H5dLg cCvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=aeF1GaiT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f189-20020a6251c6000000b006257e7e5bbesi3698375pfb.325.2023.03.15.11.31.00; Wed, 15 Mar 2023 11:31:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=aeF1GaiT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232323AbjCOST3 (ORCPT + 99 others); Wed, 15 Mar 2023 14:19:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231680AbjCOST1 (ORCPT ); Wed, 15 Mar 2023 14:19:27 -0400 Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47A735BCBB for ; Wed, 15 Mar 2023 11:19:26 -0700 (PDT) Received: by mail-qt1-x82a.google.com with SMTP id r5so17220464qtp.4 for ; Wed, 15 Mar 2023 11:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904365; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GgzilRrDZzjZzGZPzVxtA7dkKR8Cud+QjJJNSSQFpD0=; b=aeF1GaiTWV2z10A11VbsrsakE7qKYNyoR2nVgFLI3d6N8gJEjje/zzswtN2TGFln6U SlbpWOL++D9xe66W2i+I7sjdmACU7jeLTJNedgxGtjL2iQs0D2V2ErxDWeH77FfhlQ7S B9eXRQAjYlyuksBs4ic13nFMImugk9I19BUXI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904365; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GgzilRrDZzjZzGZPzVxtA7dkKR8Cud+QjJJNSSQFpD0=; b=ZXQgQpLgin8+6oEOsBmWvDkvlXGDJzVMbHO+fsllFjaChqPdkkDWNSUHUB6JfXkGZl tWMaA1ng3J2bopjvWOljENYlCDei4aAT7juhzwXkAMiCRit4hcOLEtzrwhB40yONFOQT +0aJ8mETlZlN+fSG6lfEgyquljdzRFzOSnFceP9Fv4TO91hOAig1yC9veZIzaSC9J2UP NYBM/bL2Hgit8rZdH+GiFhUX2aX0vBRFhjP+2nU94FMw698AG1PcmSwjkS9T5/IyqPUA K2ooL0MjRBEyVaHAPL7Rw0U/KMMVQikVveIiDTZtAs/iXJhdkvdwdLiQreM/eetkZLRq V0mQ== X-Gm-Message-State: AO0yUKVQF+zpDvW5TE5pyF5Nb1UXAfvAK3ejkuwb7vGGJFjmR2iDprRk A3bUSe0WQ13PvI6OdpsJLRtCww== X-Received: by 2002:ac8:5cce:0:b0:3bf:c266:fa6f with SMTP id s14-20020ac85cce000000b003bfc266fa6fmr1378818qta.46.1678904365367; Wed, 15 Mar 2023 11:19:25 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:24 -0700 (PDT) From: "Joel Fernandes (Google)" To: Philipp Reisner , Lars Ellenberg , =?utf-8?q?Christoph_B=C3=B6hmwa?= =?utf-8?q?lder?= , Jens Axboe Cc: "Uladzislau Rezki (Sony)" , "Paul E . McKenney" , Joel Fernandes , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 01/14] drbd: Rename kvfree_rcu() to kvfree_rcu_mightsleep() Date: Wed, 15 Mar 2023 18:18:48 +0000 Message-Id: <20230315181902.4177819-1-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459565761121906?= X-GMAIL-MSGID: =?utf-8?q?1760459565761121906?= From: "Uladzislau Rezki (Sony)" The kvfree_rcu() macro's single-argument form is deprecated. Therefore switch to the new kvfree_rcu_mightsleep() variant. The goal is to avoid accidental use of the single-argument forms, which can introduce functionality bugs in atomic contexts and latency bugs in non-atomic contexts. Cc: Jens Axboe Cc: Philipp Reisner Cc: Lars Ellenberg Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) --- drivers/block/drbd/drbd_nl.c | 6 +++--- drivers/block/drbd/drbd_receiver.c | 4 ++-- drivers/block/drbd/drbd_state.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index 60757ac31701..f49f2a5282e1 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c @@ -1615,7 +1615,7 @@ int drbd_adm_disk_opts(struct sk_buff *skb, struct genl_info *info) drbd_send_sync_param(peer_device); } - kvfree_rcu(old_disk_conf); + kvfree_rcu_mightsleep(old_disk_conf); kfree(old_plan); mod_timer(&device->request_timer, jiffies + HZ); goto success; @@ -2446,7 +2446,7 @@ int drbd_adm_net_opts(struct sk_buff *skb, struct genl_info *info) mutex_unlock(&connection->resource->conf_update); mutex_unlock(&connection->data.mutex); - kvfree_rcu(old_net_conf); + kvfree_rcu_mightsleep(old_net_conf); if (connection->cstate >= C_WF_REPORT_PARAMS) { struct drbd_peer_device *peer_device; @@ -2860,7 +2860,7 @@ int drbd_adm_resize(struct sk_buff *skb, struct genl_info *info) new_disk_conf->disk_size = (sector_t)rs.resize_size; rcu_assign_pointer(device->ldev->disk_conf, new_disk_conf); mutex_unlock(&device->resource->conf_update); - kvfree_rcu(old_disk_conf); + kvfree_rcu_mightsleep(old_disk_conf); new_disk_conf = NULL; } diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 757f4692b5bd..e197b2a465d2 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c @@ -3759,7 +3759,7 @@ static int receive_protocol(struct drbd_connection *connection, struct packet_in drbd_info(connection, "peer data-integrity-alg: %s\n", integrity_alg[0] ? integrity_alg : "(none)"); - kvfree_rcu(old_net_conf); + kvfree_rcu_mightsleep(old_net_conf); return 0; disconnect_rcu_unlock: @@ -4127,7 +4127,7 @@ static int receive_sizes(struct drbd_connection *connection, struct packet_info rcu_assign_pointer(device->ldev->disk_conf, new_disk_conf); mutex_unlock(&connection->resource->conf_update); - kvfree_rcu(old_disk_conf); + kvfree_rcu_mightsleep(old_disk_conf); drbd_info(device, "Peer sets u_size to %lu sectors (old: %lu)\n", (unsigned long)p_usize, (unsigned long)my_usize); diff --git a/drivers/block/drbd/drbd_state.c b/drivers/block/drbd/drbd_state.c index 75d13ea0024f..2aeea295fa28 100644 --- a/drivers/block/drbd/drbd_state.c +++ b/drivers/block/drbd/drbd_state.c @@ -2071,7 +2071,7 @@ static int w_after_conn_state_ch(struct drbd_work *w, int unused) conn_free_crypto(connection); mutex_unlock(&connection->resource->conf_update); - kvfree_rcu(old_conf); + kvfree_rcu_mightsleep(old_conf); } if (ns_max.susp_fen) { From patchwork Wed Mar 15 18:18:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70358 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp53696wrt; Wed, 15 Mar 2023 11:30:52 -0700 (PDT) X-Google-Smtp-Source: AK7set+1Cd0fj8l0j4hvBbv3g0mm8S3opKXVcbFs00T+kH81sH6nANW/+ZQRPYYu2YKiiQYMcHF0 X-Received: by 2002:a05:6a20:7f8c:b0:d0:e4b:29b3 with SMTP id d12-20020a056a207f8c00b000d00e4b29b3mr779182pzj.27.1678905051781; Wed, 15 Mar 2023 11:30:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678905051; cv=none; d=google.com; s=arc-20160816; b=fEvnG392P4fXz+TXUtZsRmO4qELIMhr6UPmyacWGqZ/3l45YoBSsLiiImloddgQefG cKj8eCiyZ0OtvYM5lrkIxTISjn4qHQhNYl6ve1D8b9kxTyEqEU5BRomEKnH2z8VuQqmD 6geHSp42+vpUVy8nIHKCFtsnVNvtIcEOir6OkeWjIzDVi6Q8TPZe6Gzlfx999/riNaxz 4zrfk0HusEEO9g3wsGwfVWkULxln70Z/5FLZ2dmYzkyC1lFahJIni2DKcZCtKkTyeJBm Hp3Mm/y6uOFuGJrW7XTNWLiv5h/tnNrzAMl8SYh7cdcuVbhLOO5ZOate6imUsomn0qXx +sTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5YoraG+JWZgu+kk+Xa2MTR2qA9SqyCgWV2tOJOVp0+M=; b=PXVkyRqahEb8a+rlYraVOfTIXRkhaU+n/7ChN7wvF/+DH6p5Y/DkQggGODZIzqFBEQ BNhsTGWmjbaEIL6Nkm0rXSH2G5qlTIPY4TiDTwwa0eKR9XpQyolUlQ2RvZ87VO/oQ32i 7YHlLe9t7qL/Sg7OYBOeaFg0SyyTddwILt0TjJ/UX+jcm69Ayo1U8xCj9QpR0zQVuPGV 0AfrkGhzYlX54OM3dS9yAisA9lDL36XtOHFzzjQiVbKRe8JVCUtx/WrOorQRnw0LEkXY Exq9MC5CZ6xl5SCAEm8tH2T32IiOvThSRTonM0/OcJNlOBW8qdfR7qBkAFdlKsZFycfv qBMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=LsXDP75T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e5-20020a636905000000b0050beb3fe627si226818pgc.459.2023.03.15.11.30.38; Wed, 15 Mar 2023 11:30:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=LsXDP75T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232473AbjCOSTc (ORCPT + 99 others); Wed, 15 Mar 2023 14:19:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232049AbjCOST2 (ORCPT ); Wed, 15 Mar 2023 14:19:28 -0400 Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CBEF5C11F for ; Wed, 15 Mar 2023 11:19:27 -0700 (PDT) Received: by mail-qt1-x833.google.com with SMTP id n2so1064979qtp.0 for ; Wed, 15 Mar 2023 11:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904366; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5YoraG+JWZgu+kk+Xa2MTR2qA9SqyCgWV2tOJOVp0+M=; b=LsXDP75TPp1/BeAMrrtNNlSCXEZTraBIYhcq4T8bXJIWOd+0vXrJVidQFpgB9zXDcF 3PiRZl7gPpXYXDamtsnNcFeOnYE/9Ys+NVsjJHlohESQVA/85+T1nDqpA07cWaF/kqUy ymjgcXuvXl8NineaVhH7XFQWwxYRuortcgTaY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904366; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5YoraG+JWZgu+kk+Xa2MTR2qA9SqyCgWV2tOJOVp0+M=; b=OSff1WgZ38L9Xfof+OPccMtYqk1taix2ojxo9f4eRmmeV0OK165ENUOE3BmGxn83ob vRPlHiwjcdtXGpHBts/ZqG6JVm0Gz4PQ9UTXp8Pp68TQjbkJUTToyeibBz1uFgpiwEb8 D73ao3Bx3UgHvGEsURl1BxLIfLm8S1movv7TnKpYf0Ccbmvbc4Nn8xXAFla5rKYYUfsR 4hKsGuM8x9V75TE6svhjUvZM+DuN+R/XKhBqIIIbQmzL8fk4Ynhfc1LddW9c4HoN5jSi s0KBBnv9qsU9sMOOVL1zbG9xxLw3qlOAYP9LXbdx6vjIlYtnSwZj/Vco7tncIaqlAQoO O2qw== X-Gm-Message-State: AO0yUKUwL/mmeQHSlWFuady1QlKluqBWxDh+hBIWmw3TPaikxDpI7YSG 35Ok0PhMyo6XFxlYP/lsakEQMg== X-Received: by 2002:a05:622a:1109:b0:3bf:b08f:1dcd with SMTP id e9-20020a05622a110900b003bfb08f1dcdmr1397234qty.38.1678904366467; Wed, 15 Mar 2023 11:19:26 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:26 -0700 (PDT) From: "Joel Fernandes (Google)" To: Bryan Tan , Vishnu Dasa , VMware PV-Drivers Reviewers , Arnd Bergmann , Greg Kroah-Hartman Cc: "Uladzislau Rezki (Sony)" , "Paul E . McKenney" , Joel Fernandes , linux-kernel@vger.kernel.org Subject: [PATCH v2 02/14] misc: vmw_vmci: Rename kvfree_rcu() to kvfree_rcu_mightsleep() Date: Wed, 15 Mar 2023 18:18:49 +0000 Message-Id: <20230315181902.4177819-2-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459543853791420?= X-GMAIL-MSGID: =?utf-8?q?1760459543853791420?= From: "Uladzislau Rezki (Sony)" The kvfree_rcu() macro's single-argument form is deprecated. Therefore switch to the new kvfree_rcu_mightsleep() variant. The goal is to avoid accidental use of the single-argument forms, which can introduce functionality bugs in atomic contexts and latency bugs in non-atomic contexts. Cc: Bryan Tan Cc: Vishnu Dasa Reviewed-by: Vishnu Dasa Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) Acked-by: Greg Kroah-Hartman --- drivers/misc/vmw_vmci/vmci_context.c | 2 +- drivers/misc/vmw_vmci/vmci_event.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/vmw_vmci/vmci_context.c b/drivers/misc/vmw_vmci/vmci_context.c index 172696abce31..f22b44827e92 100644 --- a/drivers/misc/vmw_vmci/vmci_context.c +++ b/drivers/misc/vmw_vmci/vmci_context.c @@ -687,7 +687,7 @@ int vmci_ctx_remove_notification(u32 context_id, u32 remote_cid) spin_unlock(&context->lock); if (notifier) - kvfree_rcu(notifier); + kvfree_rcu_mightsleep(notifier); vmci_ctx_put(context); diff --git a/drivers/misc/vmw_vmci/vmci_event.c b/drivers/misc/vmw_vmci/vmci_event.c index 2100297c94ad..5d7ac07623c2 100644 --- a/drivers/misc/vmw_vmci/vmci_event.c +++ b/drivers/misc/vmw_vmci/vmci_event.c @@ -209,7 +209,7 @@ int vmci_event_unsubscribe(u32 sub_id) if (!s) return VMCI_ERROR_NOT_FOUND; - kvfree_rcu(s); + kvfree_rcu_mightsleep(s); return VMCI_SUCCESS; } From patchwork Wed Mar 15 18:18:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70351 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp50293wrt; Wed, 15 Mar 2023 11:23:45 -0700 (PDT) X-Google-Smtp-Source: AK7set8fjRW/CBhb2ApPlwkzJu99QrNAlU9Li7wKgw7+oqTf0y7fpSdGtUCLhova0LlkkBfIXlDq X-Received: by 2002:a05:6a20:2a03:b0:d4:e688:c6da with SMTP id e3-20020a056a202a0300b000d4e688c6damr629732pzh.36.1678904625396; Wed, 15 Mar 2023 11:23:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678904625; cv=none; d=google.com; s=arc-20160816; b=b+4E7l6X6AUda8BdeT1AovaRm14/8+uC3pB49HRHEbepxYsoFRkBHFhpEq2cbIInUW Lxg7lYVSadBwdvb/tQX4vtt9RQdjZKnxQHQk3W8/ezdtnTHwCt7+2W9nFwkCP36sOFqA nlSrjYaWH1H/fqa4lcZWdOFiX4HmtUrXNW9f/+zGQheNya5aVXfYL1J2zk6yroG5CJRA h4mNJuV3+Gvt8Y2rhK7oEUnUlgCvuwwsGVCbVQ9ARiKgQKg+wTviNSy85s+ygmOhVI4p jq2D6I+z4WBHvRDbjLVa51hzzt9LNGwInfbLIg+lBL7HWh2VX29yxoQ7Fl0ii2LzVfml 99Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8z1V24My5EukKvP2tBVF8l+SikUfpmtGJWjB50uVIOg=; b=AkboxBWs5I2+AqUQbRc9xR/mJND7Iuf/YWGVDZOooN1mC05mi4KAtPO7pqlcpjKJ1Z XV7Tbu5usaww3jisyiCQ9zjCWQ+KXawYzw+V7m0VZqnLccjBpdHRoGRs8ohIQ75Y0yzd 7ibxo5GOu7GAIKpT7815bFmvTQ2qBD6z8UnX3QpfWJXiCdeDyMY26lf5pV/5PMRxIPVi vOn09GIWLi8/usi8W3NYO8gXf2yVV2g5yHIg4bzWTZct7f7oObq6JMae1m9RMBxSL6D1 tcWvsinchHilm+gWSHuJdbXIgsEOsK1eXqdUi/9OcbowU0+Tv++3EtHUA9Hrtrcry/vi lpBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=gJL6xjY5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t71-20020a63814a000000b0050be692a718si1083628pgd.530.2023.03.15.11.23.32; Wed, 15 Mar 2023 11:23:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=gJL6xjY5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232503AbjCOSTf (ORCPT + 99 others); Wed, 15 Mar 2023 14:19:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232433AbjCOSTa (ORCPT ); Wed, 15 Mar 2023 14:19:30 -0400 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 884BA5D250 for ; Wed, 15 Mar 2023 11:19:28 -0700 (PDT) Received: by mail-qv1-xf32.google.com with SMTP id x8so2127366qvr.9 for ; Wed, 15 Mar 2023 11:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8z1V24My5EukKvP2tBVF8l+SikUfpmtGJWjB50uVIOg=; b=gJL6xjY5J2VB+tgs7f4PKBmC6aJ6vF1TWCTHcKQSQeXddqkVkKHy4ky/vJZtWMfi1o uOBvR7syUfnwN1QoGa1eAGsFwODy02Qau5v8CRaDi+6RCsH9b1haKNaZ+fbdnRhLv0Rx VZK+iIEW4txFkIEOJqJ11RttHfWWpcIa5GTPw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8z1V24My5EukKvP2tBVF8l+SikUfpmtGJWjB50uVIOg=; b=YdlGMU3buENL8fxHiVv68m3Em6JAZAZvcojfTDCrjsSG3mGh2FhrudQX0MJNlHwdAn x2rfKuya52IKeAoLcUn2n2mbGiN//bGMM0Oh4UDcStNLDO7L4mlOWco9PlTTdd8Np9B4 4noJoggIt2o4uXdmk3SUSLE9E377xmUXG6SfLFJdeqd3ghXS3ho3GH8FX2PzmKRumax4 jdYkBNaWtCTA4WgM/E9TPVNbbI3msqVrpfwmSsArjYoxS1G+n8J/nALHsfJGg0ouJA8U iehLAryAxYLYXt2A79FrKrQuOwCea2m8tLmtLqp6XCxIia8lFhF6mUEvcOXywJ5g0Da5 XoOw== X-Gm-Message-State: AO0yUKX3x25m98Mu3XU6pvYU+tfE7AImW4IygLWgK/BuWmL2BlhJH+JW 8l/Ee2qq/Kt1+3y0T2b11goudw== X-Received: by 2002:a05:6214:1cc8:b0:5ac:58cc:69d1 with SMTP id g8-20020a0562141cc800b005ac58cc69d1mr12603637qvd.31.1678904367609; Wed, 15 Mar 2023 11:19:27 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:27 -0700 (PDT) From: "Joel Fernandes (Google)" To: Steven Rostedt , Daniel Bristot de Oliveira , Masami Hiramatsu Cc: "Uladzislau Rezki (Sony)" , "Paul E . McKenney" , Joel Fernandes , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH v2 03/14] tracing: Rename kvfree_rcu() to kvfree_rcu_mightsleep() Date: Wed, 15 Mar 2023 18:18:50 +0000 Message-Id: <20230315181902.4177819-3-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459096242079783?= X-GMAIL-MSGID: =?utf-8?q?1760459096242079783?= From: "Uladzislau Rezki (Sony)" The kvfree_rcu() macro's single-argument form is deprecated. Therefore switch to the new kvfree_rcu_mightsleep() variant. The goal is to avoid accidental use of the single-argument forms, which can introduce functionality bugs in atomic contexts and latency bugs in non-atomic contexts. Cc: Steven Rostedt (VMware) Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) Acked-by: Daniel Bristot de Oliveira --- kernel/trace/trace_osnoise.c | 2 +- kernel/trace/trace_probe.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c index 04f0fdae19a1..f68ca1e6460f 100644 --- a/kernel/trace/trace_osnoise.c +++ b/kernel/trace/trace_osnoise.c @@ -159,7 +159,7 @@ static void osnoise_unregister_instance(struct trace_array *tr) if (!found) return; - kvfree_rcu(inst); + kvfree_rcu_mightsleep(inst); } /* diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c index 20d0c4a97633..2d2616678295 100644 --- a/kernel/trace/trace_probe.c +++ b/kernel/trace/trace_probe.c @@ -1172,7 +1172,7 @@ int trace_probe_remove_file(struct trace_probe *tp, return -ENOENT; list_del_rcu(&link->list); - kvfree_rcu(link); + kvfree_rcu_mightsleep(link); if (list_empty(&tp->event->files)) trace_probe_clear_flag(tp, TP_FLAG_TRACE); From patchwork Wed Mar 15 18:18:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70350 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp50274wrt; Wed, 15 Mar 2023 11:23:43 -0700 (PDT) X-Google-Smtp-Source: AK7set9T0yhlM++vBIJoM+OYAlF2XvuJp3h4tQJikT8tuCeaFC7SDfy7DVG1zp8927zPx2TXMyQR X-Received: by 2002:a62:1b04:0:b0:61d:e10f:4e70 with SMTP id b4-20020a621b04000000b0061de10f4e70mr539646pfb.0.1678904623477; Wed, 15 Mar 2023 11:23:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678904623; cv=none; d=google.com; s=arc-20160816; b=DE9nskc0QsrbSru799BG8XGHy0Vyqo8BSWiiplajf+dS15vrgMRlMItML8FNUUqhLL orFiFkAASAIOxJ6rKSBND8K6qLukf/hbwTshkbdWaE30h2DRaUY1PDwajuJqepEngnWU 9Qh8bjuyHfGmq8fiQw/cTYJnil8LYixHTc/Q2thsoEdR/dqX0mYRSr0kmOueAyKwOvXy tTU5VLSbfiYx2nPT3omW4yUUr2CBt5GvAiCUM4mMRsnbsufu1F8zS+zn6FNAMw0e++Bu bn9SMHQtHzgaQ2xl+eHqMpqNi6JK9ZnSkMyL+v0Q+4LLmQ2IhZRf9JMMLcaH1bHu0Iud 66Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=8211cyBB4kTZ+AoCUX/adSsmWMNuX2PRJRyfmzY6D90=; b=vhDWVebb8EIlcg4yprqciVaUcTE9/+98Jq7wcgRm64LzLxNh9Ba4oYM3n8I/HhxnsG CQHqDEuHIQmKelxj3l/ywVE/xVnBAOOeBAvo5K08Drx8bA/bjnHy5tjoNdkZEm5uGNBL y9C/sSVIR+PFMhXsyRZHsVsdeNiWDnrJMX/HGygSCOwNUE+jXY7UCqhAPwKsE05wrZmq Pe25SMKyFJLgW6Ak1kedGdsQfwGNAorQcFEvVMjAVJ2Zih3qV8qES8iM1WGmHf9omT0l lpAN4DG4hMBuuEqBEJwP0hO4ImEkVeFhrCDaRskcYtsWtzGV6V9WEAikUJhml3iG3m48 H03A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@joelfernandes.org header.s=google header.b=gWHdyoQf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s185-20020a625ec2000000b0058dc3db12fasi5053227pfb.351.2023.03.15.11.23.31; Wed, 15 Mar 2023 11:23:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@joelfernandes.org header.s=google header.b=gWHdyoQf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232513AbjCOSTi (ORCPT + 99 others); Wed, 15 Mar 2023 14:19:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231199AbjCOSTb (ORCPT ); Wed, 15 Mar 2023 14:19:31 -0400 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63DE95C11F for ; Wed, 15 Mar 2023 11:19:29 -0700 (PDT) Received: by mail-qt1-x82f.google.com with SMTP id c19so17158418qtn.13 for ; Wed, 15 Mar 2023 11:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904368; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8211cyBB4kTZ+AoCUX/adSsmWMNuX2PRJRyfmzY6D90=; b=gWHdyoQf2y0I1HPFYIar0tUQRiVknNSQwaBNxnbH7Qfl1No9xGKFXwNubvPdNvRyLo RvW+m4q92o6a8CkGIzEqSvjJ8KB/P8vzXqIUgN+zAPeGACWv9hbrGIEwBmK8Wpv17Hvn d0TsWzvSpDnCZHNNzd0Wg4zo8RJrZAhpKWq+g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904368; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8211cyBB4kTZ+AoCUX/adSsmWMNuX2PRJRyfmzY6D90=; b=rPA3w8UWkUkyTDICJ3ASTRCNpubMr9mzerA2OaRavEm+T1N7bOU6V76CRz15FurbZd qoiWWHprO/Ced54+cCZQCe4kz+9BdIyRUPz5nvNmPr9mCQR8kZgTCt3drbdCKgeYcJX2 KkWw8487+s0W+K2y1N9CaTvCqcGY/7sUbyhAb/l9i7nKLnl15rXPKTiFgN4QQBeLvt19 1TRdOT7D8sSkVJ5FGm20pmE7QXp2UtGA29CuEBsvZLYGodEWQ4T3Cn+W3d3ZPtWBxjIA SJ9jIEvzx9tdu9HXN1dms3AuZz4v7q9AGmoDMvmClKsj/DH0FhcLrbLzdF+ujLhvmSUT Soyw== X-Gm-Message-State: AO0yUKXuMEyJV37SZs+/gnFrbXnNdsVV6uIH5hnb9v5OPdo93YOyzg3C 2bqlAdDF8yJEmGbICLDKhB7rfQ== X-Received: by 2002:a05:622a:1a88:b0:3b8:588c:40e9 with SMTP id s8-20020a05622a1a8800b003b8588c40e9mr1502647qtc.19.1678904368531; Wed, 15 Mar 2023 11:19:28 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:28 -0700 (PDT) From: "Joel Fernandes (Google)" Cc: "Uladzislau Rezki (Sony)" , "Paul E . McKenney" , Joel Fernandes , linux-kernel@vger.kernel.org Subject: [PATCH v2 04/14] lib/test_vmalloc.c: Rename kvfree_rcu() to kvfree_rcu_mightsleep() Date: Wed, 15 Mar 2023 18:18:51 +0000 Message-Id: <20230315181902.4177819-4-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459094334991278?= X-GMAIL-MSGID: =?utf-8?q?1760459094334991278?= From: "Uladzislau Rezki (Sony)" The kvfree_rcu() macro's single-argument form is deprecated. Therefore switch to the new kvfree_rcu_mightsleep() variant. The goal is to avoid accidental use of the single-argument forms, which can introduce functionality bugs in atomic contexts and latency bugs in non-atomic contexts. Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) --- lib/test_vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c index de4ee0d50906..cd2bdba6d3ed 100644 --- a/lib/test_vmalloc.c +++ b/lib/test_vmalloc.c @@ -334,7 +334,7 @@ kvfree_rcu_1_arg_vmalloc_test(void) return -1; p->array[0] = 'a'; - kvfree_rcu(p); + kvfree_rcu_mightsleep(p); } return 0; From patchwork Wed Mar 15 18:18:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70347 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp49813wrt; Wed, 15 Mar 2023 11:22:46 -0700 (PDT) X-Google-Smtp-Source: AK7set+RwS+VH+6yS/jPZMnGdf5VMUCkObCMMzOHPja7jTEonKjSF1tYLn1RQsgN2n+Eco7tu83R X-Received: by 2002:a17:90a:1a01:b0:237:d44c:5861 with SMTP id 1-20020a17090a1a0100b00237d44c5861mr763518pjk.12.1678904566133; Wed, 15 Mar 2023 11:22:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678904566; cv=none; d=google.com; s=arc-20160816; b=VfDr2BuyrOkwdF6eVJrwLZSPLft8D2xyXPv6fErV8x4wHy/F32m1bPPHUTvkCB+eaj c0o27CXnTawxv88EcxZHyeuCT6XoB3tUwo5e5TB6y9i/P9JPu7N1+4cgnYAqKvz3k1Ac yGI2Txvsg+dRyOHMSFfzGqVSiB8g2jbVDClMGNyHGs4qIy7O6wgvOTILjbX/wd2xoUuo v4RByl8J1EFN/nBDWXU7E0EqfYubKLETj9+dNQkXoUs4+ZdqTsDiW/XljAEedXKKS2RF 0Xf48Q+fHZpYdFnrG9Wmcwz1BC56VIz079QbnVECSdfdTSOS20Zv+0bQUbpPYnfdsmz6 EkLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8YdMRWrceqxooe4gtO91XUx2+IJg5yOZzB8eltDBQHc=; b=qjehivnhZ+naMN3L2M3IrXbH9mVYv9EJP6cygRmfaysFUPI+EnC930P+5tmQUe0BXI be23qk+lHLdz6ZNVVQRw22rdd9iYIfZbx8tLRssHAvS5eAJXLxziyaGdvlAmTIpJMeWh 0sRcchBgbDwbdUdjv1/f+JikHUMSHiS3vjVherq1bSet9UjUbMjZKehLaGdipkjfcrLS iMGU71ElKvR/DfnygRbL9W+17j+X4S7+Z5h02urSt9zoPmGhmMk21mkmsN1sgf/KXrt7 MTBd8EGbZvhcUdEydo/Gkf+tdcrkqSbjjsKuxa/L0UYPpsj6ns7ZotH/MZmbJ/k3Nvc/ KXtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=Y6dmHBBx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w12-20020a17090a4f4c00b00230c82c6284si2166784pjl.19.2023.03.15.11.22.33; Wed, 15 Mar 2023 11:22:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=Y6dmHBBx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232559AbjCOSTm (ORCPT + 99 others); Wed, 15 Mar 2023 14:19:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231871AbjCOSTb (ORCPT ); Wed, 15 Mar 2023 14:19:31 -0400 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C7CE5D47A for ; Wed, 15 Mar 2023 11:19:30 -0700 (PDT) Received: by mail-qv1-xf32.google.com with SMTP id x8so2127437qvr.9 for ; Wed, 15 Mar 2023 11:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904370; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8YdMRWrceqxooe4gtO91XUx2+IJg5yOZzB8eltDBQHc=; b=Y6dmHBBxuRL29N0TD32sk5Q46SZkvb+Cz7joxJNYQa7VcRhTrhsl+leDpu6VzvnEPD nP4GzafsDqwcbrFtRQrR0TIEqr/isk3MbcwjMbp7p2wI58NJmBzfsFfLMoIzrSJ0hxf1 ucc4ysYK0e6PziMi8ddBKUqNJVFM9vedX72fo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904370; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8YdMRWrceqxooe4gtO91XUx2+IJg5yOZzB8eltDBQHc=; b=hOxz/dMsJV2CSfCoKuHqS13FwL7iBr7NUv0Cb9de8rXLqlutiPkU3ywxWsMuGvFFRG 4mJs4q1FqekFJRAbdpR2hf+EcyESjGpkvrG/nmfHtL99PuS121WzR/SNgwd6GRw3gb+P TV8oIQSZly2jAOhHp3Go/Of7Ja4b/XFZHsgCHSd7Pu3Zy3pyl2JmCpdONWg2RgKeu5e3 jajFCqdtFpwH2+Ve/3yjT7iWWQS0ZfbWA8nHgfMW+5uyfI3TMVjQgH/MhxjnYO25tuCK qm2qAF1rPc/RzGa+NiRgySuqWbr26CYSQhl30+9EWYKEcrw8imnO+yuvs0WG35fyCSzW mBeA== X-Gm-Message-State: AO0yUKV0uP6iLiyGmJmRMvDzXorDYVxFpF2nkOSUXtuu1ryioGCgTBZU W0qKJ3+6kWylRQBltdzEHRE1n9i7FmN/nGd+PoU= X-Received: by 2002:a05:6214:1d01:b0:577:5ffe:e0d8 with SMTP id e1-20020a0562141d0100b005775ffee0d8mr34099870qvd.24.1678904369778; Wed, 15 Mar 2023 11:19:29 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:29 -0700 (PDT) From: "Joel Fernandes (Google)" To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: "Uladzislau Rezki (Sony)" , "Paul E . McKenney" , Joel Fernandes , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 05/14] net/sysctl: Rename kvfree_rcu() to kvfree_rcu_mightsleep() Date: Wed, 15 Mar 2023 18:18:52 +0000 Message-Id: <20230315181902.4177819-5-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459034458254762?= X-GMAIL-MSGID: =?utf-8?q?1760459034458254762?= From: "Uladzislau Rezki (Sony)" The kfree_rcu() and kvfree_rcu() macros' single-argument forms are deprecated. Therefore switch to the new kfree_rcu_mightsleep() and kvfree_rcu_mightsleep() variants. The goal is to avoid accidental use of the single-argument forms, which can introduce functionality bugs in atomic contexts and latency bugs in non-atomic contexts. Cc: Eric Dumazet Cc: David S. Miller Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) Acked-by: Jakub Kicinski --- net/core/sysctl_net_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c index 74842b453407..782273bb93c2 100644 --- a/net/core/sysctl_net_core.c +++ b/net/core/sysctl_net_core.c @@ -177,7 +177,7 @@ static int rps_sock_flow_sysctl(struct ctl_table *table, int write, if (orig_sock_table) { static_branch_dec(&rps_needed); static_branch_dec(&rfs_needed); - kvfree_rcu(orig_sock_table); + kvfree_rcu_mightsleep(orig_sock_table); } } } @@ -215,7 +215,7 @@ static int flow_limit_cpu_sysctl(struct ctl_table *table, int write, lockdep_is_held(&flow_limit_update_mutex)); if (cur && !cpumask_test_cpu(i, mask)) { RCU_INIT_POINTER(sd->flow_limit, NULL); - kfree_rcu(cur); + kfree_rcu_mightsleep(cur); } else if (!cur && cpumask_test_cpu(i, mask)) { cur = kzalloc_node(len, GFP_KERNEL, cpu_to_node(i)); From patchwork Wed Mar 15 18:18:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70348 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp50005wrt; Wed, 15 Mar 2023 11:23:12 -0700 (PDT) X-Google-Smtp-Source: AK7set8uA0JieLfyoZ2mYUsO+GMIBAgOtaYTkswbNBd41mkC4BwLiKnXAB6QdJL78lTE90FiJ5Fd X-Received: by 2002:a05:6a20:1613:b0:d6:c92:9925 with SMTP id l19-20020a056a20161300b000d60c929925mr794578pzj.31.1678904592589; Wed, 15 Mar 2023 11:23:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678904592; cv=none; d=google.com; s=arc-20160816; b=q9l6c/kaBDl+BtopYd7lTw/GvYrgWgkMxz2MHKq1/EvcjJ3T8unxKHCt3d4Zrvc06B guKYh6rM6CDaV3F5xb+09FQkrTvhAAZhrmVvtKF0eayYByZaHHzHldRkRW3lKsOfhKvI 1ILJxhmseb2wVIJBPI9lep0mq3wGnOpC/0x7x39CPQXNq2EuLyi21vtCGiPBWZxyM2v6 om5Bkky7WewIOnYnDROvRRcGKI0TO0aQXIRdvxeA+/0r1b1vZeRRg8X6lsPsyxaHK3JS He0qZkp22Y/G21rknjV/d0hqFBIhtAQoxD34REFiVztE0I9BPyfxb9ojHoLNo7uBrL3q OQiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Y6P3avYFLfmZWtirttMewFieZIFd8qLJc55Dm6AWaNQ=; b=VreuAwa4scyfasT9g3ndNwGGazn8+wQ4sERsNWxjtZTPFxKZb+cFCePMy31tmrb84j ixtbaDWiQhDMPHKyIcyS8qstT5P9ZtZ2d7NrWLiJg2ykKfu7ijfmtErQJ2BL7ueiNc7B vPszLKS35mMAgfv/mCHFI6Ei7iB3CNiqYUTRI8pvfy/R9P+wxjnlm8R7asuc7IFEvEEK Gei4eG82MAYmxCGQNX6Xybfo0RGvf3gmSyG8uhjPXmj8cXo6D2eVeUExPywm45KQciXp 258YRcR6pyvb/Cv1dlwgIp/oDnEqBDDf4+Bn51h0sEt/X0HKEZ6hICpswsjh6Em1NzEL kfxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=AfJO3WF6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m13-20020a6545cd000000b004fb95253a18si5549944pgr.376.2023.03.15.11.23.00; Wed, 15 Mar 2023 11:23:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=AfJO3WF6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232670AbjCOSTr (ORCPT + 99 others); Wed, 15 Mar 2023 14:19:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232536AbjCOSTl (ORCPT ); Wed, 15 Mar 2023 14:19:41 -0400 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73DFE5BCBB for ; Wed, 15 Mar 2023 11:19:32 -0700 (PDT) Received: by mail-qt1-x831.google.com with SMTP id cf14so17177557qtb.10 for ; Wed, 15 Mar 2023 11:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y6P3avYFLfmZWtirttMewFieZIFd8qLJc55Dm6AWaNQ=; b=AfJO3WF6GZ+yRdTZNjn5moqlE0pcfcwzJyR8ecGuewfHyPT8CvRJVgvhX9FiypD/QW 4t/r8YuGdxUFqFX4s51NsQEsnlk7EzA/hmPFQFKgHtdisgnd9MzLrJ6+3B7j282f7ItC f4V0U1tDhWGzVLkggiaSkFqTi3L4T7gF+mFrc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y6P3avYFLfmZWtirttMewFieZIFd8qLJc55Dm6AWaNQ=; b=G6vhlN/oI6lyUiTsrr/wpfu42S5hBofd5EI0H+/u1GyBNaLU78RkL00eAF2ESJE/HM xQvWKy57X2YqAE+kiUe3YSoklXwPDDuMJnPFF1ZroCPKUkrm2Nd6iWNyx1aKwr3qlJCT RzGj/O8IMZptI9MqVb6vqOr1AOOpqlkQRnPxAvskYR+yY4aMWd8pC4FzMW0jULa2Vy0T 901eUBGrBx1OiJo6NIC4+8Oyhing3SnvcizHxEhQhrQHiWNd43jKEIEMzzak2fH772Cq 94T8Z97qtLNm41cRYiBxU75gd3dCgvHPzseww1s6ILRgWDGY7X3a5R1Sf26+YQGxSYmN Cuvw== X-Gm-Message-State: AO0yUKWOZ/oud6PxPNbgG9v2kBpE3pG3M04oAsDNN40FSpV37HQZwxnw X/LVOt55qV0cDz8hwfeERUb+9g== X-Received: by 2002:ac8:5e0c:0:b0:3b8:6a20:675e with SMTP id h12-20020ac85e0c000000b003b86a20675emr1472979qtx.29.1678904370959; Wed, 15 Mar 2023 11:19:30 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:30 -0700 (PDT) From: "Joel Fernandes (Google)" To: Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Boris Pismenny Cc: "Uladzislau Rezki (Sony)" , Ariel Levkovich , Vlad Buslov , "Paul E . McKenney" , Joel Fernandes , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 06/14] net/mlx5: Rename kfree_rcu() to kfree_rcu_mightsleep() Date: Wed, 15 Mar 2023 18:18:53 +0000 Message-Id: <20230315181902.4177819-6-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459062258398536?= X-GMAIL-MSGID: =?utf-8?q?1760459062258398536?= From: "Uladzislau Rezki (Sony)" The kfree_rcu() and kvfree_rcu() macros' single-argument forms are deprecated. Therefore switch to the new kfree_rcu_mightsleep() and kvfree_rcu_mightsleep() variants. The goal is to avoid accidental use of the single-argument forms, which can introduce functionality bugs in atomic contexts and latency bugs in non-atomic contexts. Cc: Ariel Levkovich Cc: Saeed Mahameed Cc: Vlad Buslov Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) Reviewed-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c index ca834bbcb44f..8afcec0c5d3c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c @@ -242,7 +242,7 @@ mlx5e_int_port_remove(struct mlx5e_tc_int_port_priv *priv, mlx5_del_flow_rules(int_port->rx_rule); mapping_remove(ctx, int_port->mapping); mlx5e_int_port_metadata_free(priv, int_port->match_metadata); - kfree_rcu(int_port); + kfree_rcu_mightsleep(int_port); priv->num_ports--; } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c index 08d0929e8260..b811dad7370a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c @@ -670,7 +670,7 @@ static int mlx5e_macsec_del_txsa(struct macsec_context *ctx) mlx5e_macsec_cleanup_sa(macsec, tx_sa, true); mlx5_destroy_encryption_key(macsec->mdev, tx_sa->enc_key_id); - kfree_rcu(tx_sa); + kfree_rcu_mightsleep(tx_sa); macsec_device->tx_sa[assoc_num] = NULL; out: @@ -849,7 +849,7 @@ static void macsec_del_rxsc_ctx(struct mlx5e_macsec *macsec, struct mlx5e_macsec xa_erase(&macsec->sc_xarray, rx_sc->sc_xarray_element->fs_id); metadata_dst_free(rx_sc->md_dst); kfree(rx_sc->sc_xarray_element); - kfree_rcu(rx_sc); + kfree_rcu_mightsleep(rx_sc); } static int mlx5e_macsec_del_rxsc(struct macsec_context *ctx) From patchwork Wed Mar 15 18:18:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70357 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp52994wrt; Wed, 15 Mar 2023 11:29:32 -0700 (PDT) X-Google-Smtp-Source: AK7set/x7i31Og8w0rrobeID5via+ZMORkPU3JzItFdFgntE0JY4GD8v+nmBOOGHlo9SsdYsmFMi X-Received: by 2002:aa7:97a2:0:b0:625:d5b5:1e9d with SMTP id d2-20020aa797a2000000b00625d5b51e9dmr424199pfq.1.1678904972597; Wed, 15 Mar 2023 11:29:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678904972; cv=none; d=google.com; s=arc-20160816; b=MCHOySKf8vNxW8A844xxL1CHoXO1LiWLj7ixwTi6lFFxYdCHYEBUZXzKSADZaONwgh fRg0anl3lpB00vhOxuKSh7RqmbbrZCIJ+FlozbfZiIHucchDLED3+dGd+YmYq1sCJ9P7 GOqATfHy4Lts23fRD680SHU8xsnjVIopx5zqL68Z+ueQM5CsFx7xlZfLxUDyKv4CWTeO km1k7IREtG5Jqf2Ts4oCw9qlnfI+c9ywLYZmkIILvaAX4FFmEqjLaIoKCQF/D4vle9vt 5qrpK9U/45s6/C3bj+AzR7daeSmc3SJ2pTwnn5WPVT2xYsC/lyrMQJslNbnwCNJJkjGd ceXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zopkQ37OTbb3jqgpfO1W4/ZEQgiXwNommG9IMZvT2rg=; b=u/Iawg/eyN/CruuKuif3v6dgwzl3wKSxX6NIK4dWOR28tmxEdsXDQgwdWgvDhPgTeA e1n0QBvSCJa8ZBJJan2V90/74CBk/eVeufcBYb2VqaQjfrRL4WgxaT+SJ8SPBNXhkCQG tZk1QJFdU6TVYqxG8WohEh9dNg24ghpytX2SAtZ/LtfyjlGwWkwuPQ0r14/bcPx/YO5R m4sTww7OGNi2VKf5Wf7XeFEo3ZmpER0INTDn834R6+XSc6U0yu5dXsKSNKo/mHP0iw7N Y4phshOUCoEoZa3XcTx1f6swa+riAUKBEqqSwncLX+2GGOS6aSwesWuW3rI06/pnoQwS qD+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=TLYClVd+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e5-20020a636905000000b0050beb3fe627si226818pgc.459.2023.03.15.11.29.19; Wed, 15 Mar 2023 11:29:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=TLYClVd+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232622AbjCOSTp (ORCPT + 99 others); Wed, 15 Mar 2023 14:19:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232524AbjCOSTk (ORCPT ); Wed, 15 Mar 2023 14:19:40 -0400 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA2717C3D3 for ; Wed, 15 Mar 2023 11:19:32 -0700 (PDT) Received: by mail-qv1-xf2b.google.com with SMTP id m6so8269023qvq.0 for ; Wed, 15 Mar 2023 11:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904372; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zopkQ37OTbb3jqgpfO1W4/ZEQgiXwNommG9IMZvT2rg=; b=TLYClVd+VJLKTpszbcY+j5Cmv4IE4AGWIiTfyq5wjafEITguH3DeszdQNA3wA+fTJP Iu1VSWCUseU8K3SHSlfuwq9B/N9dua+Daz7K8vnKt4UH++qSDzv/Q6FTB8oS7N7seNRM 0uau9GpCOhyskfAsaKnRFlCO4F1KMLe6iOvig= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904372; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zopkQ37OTbb3jqgpfO1W4/ZEQgiXwNommG9IMZvT2rg=; b=lqxFh3hkxibgJCsOmiUWpRiM2Le9SGiVsCKVjFlt6ZU/up1SMoXKybcaMm8weloWU/ xYhkg9D/wAwAY5+E9Su47D/2gsPJ5KjkaahAu5/GheSX3iA5NmLNm7GemCGyO16ItcXj D7FhzxPa34SpFhumPJaINWGoHqfjpaDkWFPkJJZqeCy0ArExVQDyrMZ4yR1SOMFTkTnb BOTt7oyKh4yWd9SjL5WXQlG4aJeZNFM3enjw0OhKY8TtbzQjQc8Vl0IrvisA3EX3guhG kJfrWn5f/UIqEHtyNRqlHbxI3ennJcTpsnzWu3E0xtcugd1PsaI1aMx4yfdASFe1BR8w H4fg== X-Gm-Message-State: AO0yUKXgm0E1GB9DmNGR175vJn1LDfhpBLHWHL9lhChzV6O8uoetFiVA RuYykeTVDz8pgeS8un5t5k6R4A== X-Received: by 2002:a05:6214:d89:b0:56e:ac97:85da with SMTP id e9-20020a0562140d8900b0056eac9785damr26734276qve.30.1678904372039; Wed, 15 Mar 2023 11:19:32 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:31 -0700 (PDT) From: "Joel Fernandes (Google)" To: "Theodore Ts'o" , Andreas Dilger Cc: "Uladzislau Rezki (Sony)" , Lukas Czerner , "Paul E . McKenney" , Joel Fernandes , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 07/14] ext4/super: Rename kfree_rcu() to kfree_rcu_mightsleep() Date: Wed, 15 Mar 2023 18:18:54 +0000 Message-Id: <20230315181902.4177819-7-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459460647823099?= X-GMAIL-MSGID: =?utf-8?q?1760459460647823099?= From: "Uladzislau Rezki (Sony)" The kfree_rcu() and kvfree_rcu() macros' single-argument forms are deprecated. Therefore switch to the new kfree_rcu_mightsleep() and kvfree_rcu_mightsleep() variants. The goal is to avoid accidental use of the single-argument forms, which can introduce functionality bugs in atomic contexts and latency bugs in non-atomic contexts. Cc: Theodore Ts'o Cc: Lukas Czerner Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) Acked-by: Theodore Ts'o --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 88f7b8a88c76..405a66b47311 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2500,7 +2500,7 @@ static void ext4_apply_quota_options(struct fs_context *fc, qname = rcu_replace_pointer(sbi->s_qf_names[i], qname, lockdep_is_held(&sb->s_umount)); if (qname) - kfree_rcu(qname); + kfree_rcu_mightsleep(qname); } } From patchwork Wed Mar 15 18:18:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70349 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp50244wrt; Wed, 15 Mar 2023 11:23:40 -0700 (PDT) X-Google-Smtp-Source: AK7set+mGfsKWkCpUU9CfWAlCNy4ggvPTL+raTKS530VYZi8lJE1eFxisyzX6VLLr1pvRBKmlZKS X-Received: by 2002:aa7:949d:0:b0:624:ac1a:a9dd with SMTP id z29-20020aa7949d000000b00624ac1aa9ddmr326441pfk.31.1678904619892; Wed, 15 Mar 2023 11:23:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678904619; cv=none; d=google.com; s=arc-20160816; b=0wifu6wypVLz6lVIYzfgii+Udvb0qx9h5cww3Yoq6wKk8Ps5zE8m8wKQZ/4ttfJOVA ggOIUMEsYzkyS8TeqSx2PiwqXAQLY9stPwWpivSNAnlXW5mh4UCaHgw0Vm3j7O/GIu3S RgJ4PKaVDCvfzjtoTw9g797F+cIW/qVg8I6WRkROibf4POZs5iuInqE4igzgNRNrpBZo CCzoDHfjZ8PPqqoM+OkuNn6Rt9xatxF5PXRW9c2isG+1rKC/EGHMXP1ZXsC6TsbPLBXk 9+OKxGJLnTGZJx/VkrUnVfgolAt5t2HsZXFtZmHLd0IAtnptgQ61EHO+1n2q7cyCjowV aBtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/Bvd7KqU+0UJPbIZv2ZisqXKCDIddIzWkPhDnOppke0=; b=XaP2a868bi+Hngf56wX+/QLE1SIiXNc9J7kVAcURaTEFK7Sq35FMDiBtTMWT6mb5lH bfq0jackLUzKr+EeSAnrxDygSmPb/rf8aVhV8ZPJXonl8XAJd04i28mg3pLPOXRkOarg BBuz/hc+/fO8ZVnih5nfovYS9IDvZC3uP1CYsfJP6fJp6iIytnk3atosuIcK4S1c93X9 HKAuWAvvbV4LckdP53+law97JhoOOMm4JGr1s2981KKf+xVbr2BZnidhfBSa0sjs8v+s 1a+7190Jm4uroJj+Na4A+XN4sqqSb4uXa/Jo97ZcXoiNviSvwbWcrkKgtEYeptkr8YFt ZgdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=Bj88++U5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b28-20020aa7951c000000b006254213ed4csi5559811pfp.91.2023.03.15.11.23.27; Wed, 15 Mar 2023 11:23:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=Bj88++U5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232524AbjCOSTz (ORCPT + 99 others); Wed, 15 Mar 2023 14:19:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232547AbjCOSTl (ORCPT ); Wed, 15 Mar 2023 14:19:41 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 629D07DD13 for ; Wed, 15 Mar 2023 11:19:34 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id y10so17247502qtj.2 for ; Wed, 15 Mar 2023 11:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904373; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/Bvd7KqU+0UJPbIZv2ZisqXKCDIddIzWkPhDnOppke0=; b=Bj88++U5M+bx+xrI+ueEqEmtvkt/BQxGm9alRbvENUNQgW/XLsUqKg+0i9rYjVwo/U xCkd8SkXbBn5uwMwDpOTp4ud+QYb1pA6hKv6CViFcxzUXknbgDo+WJAOH8ZGPY5Q4kih eJkADceCNkzHpKA9rKi6gN8oC5ABQXKSF5mo8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904373; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Bvd7KqU+0UJPbIZv2ZisqXKCDIddIzWkPhDnOppke0=; b=wIoGRHouKPatvMVZJmxLr6zBjugOkkGkPMbRoXeLyAzFCsrSioPgW5yew28ob5Nc1F j0dq5yX3R7huFVRZ02GBsAFByH/wh4xzutFrxXbfeP6VrjboRlK3lSUXgjqp+yPwTPbo Ss95wd0s85ReOPDvatVydSwaaAlNnY9e9jeZnnsCmCu9rO+f4I6ptcyvtTurSAI1BI1t LX4e/O15pxqlIXqZu7AUKVQph+z1QKn13easgb02BIbf6quGaa6Vh98HH3re/pSEYw+o ZsQLlEruBeYOgShYb+06ZyhT1oAp5pkfxzcQAhTYtjZzVY3KWleuvf8r2/m0zz4w+PIc lNKA== X-Gm-Message-State: AO0yUKUTyo3Pzbkvpac1lWH4JJc60fYmS2b84oFYtzoawxwce3CdKasA TnlNc4gS820FFwAOWeYh3RMVmA== X-Received: by 2002:ac8:7c50:0:b0:3b8:4adb:c604 with SMTP id o16-20020ac87c50000000b003b84adbc604mr1513701qtv.14.1678904373115; Wed, 15 Mar 2023 11:19:33 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:32 -0700 (PDT) From: "Joel Fernandes (Google)" To: Davidlohr Bueso , "Paul E. McKenney" , Josh Triplett , Frederic Weisbecker , Neeraj Upadhyay , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes Cc: "Uladzislau Rezki (Sony)" , linux-kernel@vger.kernel.org, rcu@vger.kernel.org Subject: [PATCH v2 08/14] rcuscale: Rename kfree_rcu() to kfree_rcu_mightsleep() Date: Wed, 15 Mar 2023 18:18:55 +0000 Message-Id: <20230315181902.4177819-8-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459090814078056?= X-GMAIL-MSGID: =?utf-8?q?1760459090814078056?= From: "Uladzislau Rezki (Sony)" The kfree_rcu() and kvfree_rcu() macros' single-argument forms are deprecated. Therefore switch to the new kfree_rcu_mightsleep() and kvfree_rcu_mightsleep() variants. The goal is to avoid accidental use of the single-argument forms, which can introduce functionality bugs in atomic contexts and latency bugs in non-atomic contexts. Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/rcuscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c index 91fb5905a008..98b75995b680 100644 --- a/kernel/rcu/rcuscale.c +++ b/kernel/rcu/rcuscale.c @@ -716,7 +716,7 @@ kfree_scale_thread(void *arg) // is tested. if ((kfree_rcu_test_single && !kfree_rcu_test_double) || (kfree_rcu_test_both && torture_random(&tr) & 0x800)) - kfree_rcu(alloc_ptr); + kfree_rcu_mightsleep(alloc_ptr); else kfree_rcu(alloc_ptr, rh); } From patchwork Wed Mar 15 18:18:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70360 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp53990wrt; Wed, 15 Mar 2023 11:31:22 -0700 (PDT) X-Google-Smtp-Source: AK7set8TxHCKvY9S4MT/Zn7NBa8aB7xPCoDqFRbDHnS+W31odjHhBgNKxlrRcASL+kHua3aqM3Ay X-Received: by 2002:a62:5251:0:b0:61d:d253:eeff with SMTP id g78-20020a625251000000b0061dd253eeffmr436544pfb.9.1678905082464; Wed, 15 Mar 2023 11:31:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678905082; cv=none; d=google.com; s=arc-20160816; b=wcQTOuST9exnIRryBHsfIOBv0t4+KSRzWfvh0BKQCY/LRNVRooUjw+BB0pQ8jvGIPA zSu6eqFHAA6V6XOyMjmzQE/PAXPt+zJcsgORK6je2SOFS2UZEketPG6zs0qVuyXPJT1U 8hoM+m8xVos7YPftcmal6NdYDN++SSdsp77KZOROf1VGIN8HmAQ/RjZ7T/rdALlF+I5q VYY/j1R23IIc48PKTudivyqUJ21N/gXDyMc7/9uBS/r5Cek2SF4xeAPWJbjehytO2d2y G3HquLwLj0RNIHZUhjVG8pBnIkoV1tfHBkJI0REHktxYwxGL5wwQewPARcg0VBkPhSUW uU9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lSsc7hzk/lL5hF/xvXJ1JSJwgr8pnxi74tQwwkfBkI4=; b=I+qTopK3Zf4LAftZ4dx5TCtDVa2zrD/UGYUlC1ycSM3LKgd19Y5A4eKhSgeVvF1yoW 2hHZcYagtVB2xtbBpumb0KcrjVijZW3XHRAnk80ZsTrgZamkHU5MR+ICbV+SelfpE0H4 X7nnwuhsjXxaep450rIzf8QqBJkKJll4DSm6+Pky2pWSbidEFsz0A3MZ82dM02eNaQSt WmOwr7tVn0OBYtsG5yTH+WEnu9nWP0jGRlxI8X1aoXmeXbv0L/KWOub7pgAiVMqw4pTS Ti14+ty5U7E0Mo6SKoyTmdYXId9xWbV1XVrEAL7FDS9J3r3BgE9+m4NlFD61MHxCHf67 uVmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=PqxQOwNl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h3-20020a056a00218300b00625d5128683si807042pfi.15.2023.03.15.11.31.08; Wed, 15 Mar 2023 11:31:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=PqxQOwNl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232661AbjCOSUE (ORCPT + 99 others); Wed, 15 Mar 2023 14:20:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232589AbjCOSTm (ORCPT ); Wed, 15 Mar 2023 14:19:42 -0400 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8C017DD24 for ; Wed, 15 Mar 2023 11:19:34 -0700 (PDT) Received: by mail-qt1-x82f.google.com with SMTP id c19so17158721qtn.13 for ; Wed, 15 Mar 2023 11:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lSsc7hzk/lL5hF/xvXJ1JSJwgr8pnxi74tQwwkfBkI4=; b=PqxQOwNl8FLQlZ0wb/ZC52nN9ZdX6CCNAYQcZPAXaYrpYU0hoWExe1OhVcwOi1H5n/ tohphBPoVr0QvcXjNSUxMn9KZ7gpbKM+U6MnHgj/YBjDbP7VpaVzoTMaQ6DzfIFXxWKt s150z+ZCa5wg6JrUs4FzWZglQlefFPSLnrV6M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lSsc7hzk/lL5hF/xvXJ1JSJwgr8pnxi74tQwwkfBkI4=; b=xDxUkrWG/bbuwKcF+F9+WNHUIhKhTIIHljDiissU+R536+NuPwH3hSWVk0emYVy8Ai uIy5wyAwJ448rNQkLkROwQDbUboLkDVp/81vLm+Nef/xKr63CB0JyFXsmUauJfGktobL Qf3KkSYfVOw6ahUaXp6mQJ/nDP4j+PVOI6SDVYtx6N9cfS7h4v/ucPvkKd8Ywit1igNX VcJcT/dRXd1LLnSbgSYouETXqVEwd6MTGhytfpElAJhWajRFLzgGYIJiWdR9PhKNIj+l 3Nt5KiaiBd0pATmnhFfeq3DRTM+a53YPcoPvfB49s2+DFpTiuDH812ObHxJ+jcfjUhqK syPA== X-Gm-Message-State: AO0yUKUtpPv4X1Uij55Bclgny6AJL3knHmOyNqMRPJ9amW3Woac/2+dW C8/o6C2zfcDoxWFJkvJ4ZZBgpA== X-Received: by 2002:ac8:574d:0:b0:3c0:3b79:9fb0 with SMTP id 13-20020ac8574d000000b003c03b799fb0mr1372546qtx.47.1678904374217; Wed, 15 Mar 2023 11:19:34 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:33 -0700 (PDT) From: "Joel Fernandes (Google)" To: "Paul E. McKenney" , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Shuah Khan Cc: Joel Fernandes , rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 09/14] torture: Enable clocksource watchdog with "tsc=watchdog" Date: Wed, 15 Mar 2023 18:18:56 +0000 Message-Id: <20230315181902.4177819-9-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459575701506870?= X-GMAIL-MSGID: =?utf-8?q?1760459575701506870?= From: "Paul E. McKenney" This commit tests the "tsc=watchdog" kernel boot parameter when running the clocksourcewd torture tests. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) --- tools/testing/selftests/rcutorture/bin/torture.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/rcutorture/bin/torture.sh b/tools/testing/selftests/rcutorture/bin/torture.sh index 130d0de4c3bb..5a2ae2264403 100755 --- a/tools/testing/selftests/rcutorture/bin/torture.sh +++ b/tools/testing/selftests/rcutorture/bin/torture.sh @@ -497,16 +497,16 @@ fi if test "$do_clocksourcewd" = "yes" then - torture_bootargs="rcupdate.rcu_cpu_stall_suppress_at_boot=1 torture.disable_onoff_at_boot rcupdate.rcu_task_stall_timeout=30000" + torture_bootargs="rcupdate.rcu_cpu_stall_suppress_at_boot=1 torture.disable_onoff_at_boot rcupdate.rcu_task_stall_timeout=30000 tsc=watchdog" torture_set "clocksourcewd-1" tools/testing/selftests/rcutorture/bin/kvm.sh --allcpus --duration 45s --configs TREE03 --kconfig "CONFIG_TEST_CLOCKSOURCE_WATCHDOG=y" --trust-make - torture_bootargs="rcupdate.rcu_cpu_stall_suppress_at_boot=1 torture.disable_onoff_at_boot rcupdate.rcu_task_stall_timeout=30000 clocksource.max_cswd_read_retries=1" + torture_bootargs="rcupdate.rcu_cpu_stall_suppress_at_boot=1 torture.disable_onoff_at_boot rcupdate.rcu_task_stall_timeout=30000 clocksource.max_cswd_read_retries=1 tsc=watchdog" torture_set "clocksourcewd-2" tools/testing/selftests/rcutorture/bin/kvm.sh --allcpus --duration 45s --configs TREE03 --kconfig "CONFIG_TEST_CLOCKSOURCE_WATCHDOG=y" --trust-make # In case our work is already done... if test "$do_rcutorture" != "yes" then - torture_bootargs="rcupdate.rcu_cpu_stall_suppress_at_boot=1 torture.disable_onoff_at_boot rcupdate.rcu_task_stall_timeout=30000" + torture_bootargs="rcupdate.rcu_cpu_stall_suppress_at_boot=1 torture.disable_onoff_at_boot rcupdate.rcu_task_stall_timeout=30000 tsc=watchdog" torture_set "clocksourcewd-3" tools/testing/selftests/rcutorture/bin/kvm.sh --allcpus --duration 45s --configs TREE03 --trust-make fi fi From patchwork Wed Mar 15 18:18:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70353 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp50883wrt; Wed, 15 Mar 2023 11:25:00 -0700 (PDT) X-Google-Smtp-Source: AK7set+EOMmhJSlq/HJsNgQ9IrrJ9IBETNfs41atbGGKD6HeD9jbvIfKX3uG9kwpnbX0i17iA8b+ X-Received: by 2002:a05:6a21:7884:b0:cd:1ccf:246b with SMTP id bf4-20020a056a21788400b000cd1ccf246bmr694413pzc.57.1678904699873; Wed, 15 Mar 2023 11:24:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678904699; cv=none; d=google.com; s=arc-20160816; b=aQZ3hBD9I01VFtfoB+dhfi7yBojUx1fNcFNV4u0t7DU4Gzf/s+/6S9TOCDfQjcuAje ySXUFNFYQq1V1wI2E4rgk59wg662sESeZI5509GCKNHt0dLqeutU/ydwaoexJzendJaC TJpyQjiGWSkTI4kSjht5Ol7YtvGEypoRxD6b40RNVyJbGYAMDCfMdISpcSy8m67c4LxM BoVtvMd57BGgTd0H5opuQO+5JDE3EvHsBMfNOpMSnJtzC1Pp945CMjyi0a+1gJfInaMG FfSthNedg57+05Q38N6aYxKZMWwWbybCX0MGka8iqV5y1/i/46MieVeD+vs884M3qm4x cQrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=j5YdSl/dl9DoJC+jKcZh9kCRHqYQQP7O2cdVc7Sb2ak=; b=hju60L8l7jmSgECtgklyrLpSDhtJRmqLj+K7klzOuwGBZYFeut5q9IdsKzeXH8QTjG Dmh04bVpAd1Xw26g/tMqxv5h+4QYnrmIO90pZTFm3WfwqEw9SBvgJjhiqBDJo+1Jh8zZ fRyyoCFp1nIZ9Is0Kjpb4bSAuO4dfyQb/F+6bqMPoUAOsA8o/nG4KWmeB+uQD69jREf1 THnLjdbLOj8BAiRDQy0X0MbqpfVu0CJvDJ4qcIHmv1J4modD37fk83vYgfMsQKcGU8tg +aHZoIGxn6kosOe5RXAaTCF7BSjzsTP0oCZ+O4CMhVyVPgBVZZSrT5Ozd6vyEnssJugz 5crA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=RsVsQ4s1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g19-20020a635213000000b0050b1a0068d3si5502368pgb.102.2023.03.15.11.24.47; Wed, 15 Mar 2023 11:24:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=RsVsQ4s1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232580AbjCOSUB (ORCPT + 99 others); Wed, 15 Mar 2023 14:20:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232593AbjCOSTm (ORCPT ); Wed, 15 Mar 2023 14:19:42 -0400 Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C973D7FD50 for ; Wed, 15 Mar 2023 11:19:35 -0700 (PDT) Received: by mail-qt1-x82a.google.com with SMTP id r5so17221010qtp.4 for ; Wed, 15 Mar 2023 11:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904375; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j5YdSl/dl9DoJC+jKcZh9kCRHqYQQP7O2cdVc7Sb2ak=; b=RsVsQ4s1t13v0tdqWA51fkEfKF52Wabe0BT7RvouKtsN3SK0//3iMefFvaIvGSPk3y SMfbIluc3bKhAJGiA56yuTxrMPHfSZ3IYJfnGbhREPp5HrIbhQ48sEbDHHmB5GOlCPs6 ibsxdEx3Lz1874eR10BibIZlrij+HeWqH43x8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904375; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j5YdSl/dl9DoJC+jKcZh9kCRHqYQQP7O2cdVc7Sb2ak=; b=jFx2IYgkLRo1g3mjn8fwmN8WFB4wX6vSPY2DmPgycDMc6MvjvMdOi/Pv7EVnj00W75 GmfRkJJqB0Ue6X6LFthAiAZp4Y4Ysbl82Sk3sTyWGxV6hc25jhFyah+bh/5HV6+qF4MB URCmQmbuQqhRBEv/y1yxVNPjhOen1KyM/dP83JuLwjL3Sv0IVnmqjPL1pJV/XlKH+obf wiM8MVCRyCFOSfsVdpccUYj/WGTP8rLx36QfoUEONNVWomRxAOVaq28J1bjnva52s2wV eyFr4R+jbMdVbEVMw982gu7Y64FQW3yu9vpySWueTVnpOz16qRubcziP3ln8T1qzUlBK HqPg== X-Gm-Message-State: AO0yUKUeyd1C2hZM1Ifw0uzW0MAK6zvghfsQRPqQhoKGt3SnnrDHATPy QbsKZtUkeGXWqifEX4lVK0TXFg== X-Received: by 2002:ac8:4cd9:0:b0:3bf:cd81:3a31 with SMTP id l25-20020ac84cd9000000b003bfcd813a31mr758797qtv.65.1678904375328; Wed, 15 Mar 2023 11:19:35 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:34 -0700 (PDT) From: "Joel Fernandes (Google)" To: Davidlohr Bueso , "Paul E. McKenney" , Josh Triplett , Frederic Weisbecker , Neeraj Upadhyay , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes Cc: Zqiang , linux-kernel@vger.kernel.org, rcu@vger.kernel.org Subject: [PATCH v2 10/14] rcutorture: Create nocb kthreads only when testing rcu in CONFIG_RCU_NOCB_CPU=y kernels Date: Wed, 15 Mar 2023 18:18:57 +0000 Message-Id: <20230315181902.4177819-10-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459174284540671?= X-GMAIL-MSGID: =?utf-8?q?1760459174284540671?= From: Zqiang Given a non-zero rcutorture.nocbs_nthreads module parameter, the specified number of nocb kthreads will be created, regardless of whether or not the RCU implementation under test is capable of offloading callbacks. Please note that even vanilla RCU is incapable of offloading in kernels built with CONFIG_RCU_NOCB_CPU=n. And when the RCU implementation is incapable of offloading callbacks, there is no point in creating those kthreads. This commit therefore checks the cur_ops.torture_type module parameter and CONFIG_RCU_NOCB_CPU Kconfig option in order to avoid creating unnecessary nocb tasks. Signed-off-by: Zqiang Reviewed-by: Joel Fernandes (Google) Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/rcutorture.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index 8e6c023212cb..83870c4ae1b8 100644 --- a/kernel/rcu/rcutorture.c +++ b/kernel/rcu/rcutorture.c @@ -3501,6 +3501,12 @@ rcu_torture_init(void) pr_alert("rcu-torture: ->fqs NULL and non-zero fqs_duration, fqs disabled.\n"); fqs_duration = 0; } + if (nocbs_nthreads != 0 && (cur_ops != &rcu_ops || + !IS_ENABLED(CONFIG_RCU_NOCB_CPU))) { + pr_alert("rcu-torture types: %s and CONFIG_RCU_NOCB_CPU=%d, nocb toggle disabled.\n", + cur_ops->name, IS_ENABLED(CONFIG_RCU_NOCB_CPU)); + nocbs_nthreads = 0; + } if (cur_ops->init) cur_ops->init(); From patchwork Wed Mar 15 18:18:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70352 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp50837wrt; Wed, 15 Mar 2023 11:24:52 -0700 (PDT) X-Google-Smtp-Source: AK7set9SBgSdCbbpU0XeBLHrBynO37CtwYDAeCH65ym7HxyFF98oKXWgHmCR0A1x48k/zYj99w6y X-Received: by 2002:a05:6a20:4918:b0:d4:53ff:2ef5 with SMTP id ft24-20020a056a20491800b000d453ff2ef5mr704548pzb.26.1678904692655; Wed, 15 Mar 2023 11:24:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678904692; cv=none; d=google.com; s=arc-20160816; b=S9fxUW2kvyHnk+dZiLfk5mFgrC8nY2vYXK5m7O+UVf5nco2c2jM/X9nxCw130/2yxA S4raolY4SsbC2Jp5Qp2Vnmr3czQZQM33d0qdFv4/TV8W9n4Jyzv8bSFmFZZp9yG1CMd0 RQkZlE96efWGQ2bEWXzqQzuDRZ9BimuFu/ndw3BWpOlkyHvs0xF/SY5k3L1QKAtwb45z l5nyJ4Rt06hyLu7djs8KpDDiLaW8l018c/gSFAwxrtrYw+DLj8xARdg76Ghl6P5zVdNH 1zt1wrDdKvA7C3LwoDvm7dY1OYYN6Kr3646M0RXAkphVB84OdwxQpmlQ4m1iDNuB/wV9 4oKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6C875UW3frLz1lRISgaVupsCOUcY7ixEg8V710uhHfA=; b=vZreffYNCiXz2uH7BFxDqWqwvU/GWd0FycmoNWivPU0anKhPM9EhTrX/y3CAAWuYuf UZ/ADini9JbDpSdnqk0fifKSke8JE9flbZC3tSMg3ghugaqGrHNva79c4vqTGvRrwc3f IRoS6DZ7JUpw03r+AkXdZKbdo0uMwC4pd0ox0AabO3JuvQVPo8SinVYQQnzzgm7i/uqE E13+IhMCZLjL2pPS1VzfE9Kbl+G4nVvCZltMADYF3mN4DLOFWFM/mp4/cBxC8wMPrrb4 nCf9NTHQhgs1NIa+CTB8p1G10r4urKMB56sB3rX/gCLQiKwsHJVPHD6TZQhMVkaMZI7x rmiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=DPSkv5Uu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r28-20020a63515c000000b0050bc150235dsi5689945pgl.104.2023.03.15.11.24.39; Wed, 15 Mar 2023 11:24:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=DPSkv5Uu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231971AbjCOSUX (ORCPT + 99 others); Wed, 15 Mar 2023 14:20:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232730AbjCOSTw (ORCPT ); Wed, 15 Mar 2023 14:19:52 -0400 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1CC47E79F for ; Wed, 15 Mar 2023 11:19:37 -0700 (PDT) Received: by mail-qt1-x836.google.com with SMTP id c19so17158849qtn.13 for ; Wed, 15 Mar 2023 11:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6C875UW3frLz1lRISgaVupsCOUcY7ixEg8V710uhHfA=; b=DPSkv5UuukMQB08VeLhWDOZpTsKRs7XRm8Z7PYEO2J1A3Fp78UTsApYrFQwlOxMViU KlIZY+sUHHk4B22w99eFw5THO2D8yPtupryB73gk56KlbQQEhhQukLDCu+ytVgTy+DM+ V819OE0WU+vOdwSGrLQboPd96Y//tbADX9h2Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6C875UW3frLz1lRISgaVupsCOUcY7ixEg8V710uhHfA=; b=OIpQR+92zV2nGpuGOYG75tThZo6I4jsLZ7PbHnlKWtiMx3W2KKhrfVgGct2B6cfFts Aam1pgBfPMe/ChWgxMPmS3e+oA4fSu6sG58L4HWtLoYDgZMsYGgQiCsDquDHyLmM+3gt YqdyO8ToeQNPiz2sAmlK9ywyXTQpN9UCT2lAnvvEOKyfHVlQpULz8CEZA0USy/EXMIpC 5mJd37JlWrTWR3GfDf8QVwqxb/AzDkXepYJ7ZtOUze8s6LUecq3dyS0V184ZGwCuRPUw 7c/9xnnsQrrEr+jLiyNRcbq+Re09m057Xt/k27vWKXJzB+a6EB3fRseBxLhQ5i92Jo7w NpmA== X-Gm-Message-State: AO0yUKXpINRJ4KpwdAdSOS0cA+nOjfuRMjPM0keG313Jf8QgnCfqlqBH 24pP2D11bvX+Zg7jM9n2tfjK4w== X-Received: by 2002:a05:622a:14c8:b0:3d4:6185:72eb with SMTP id u8-20020a05622a14c800b003d4618572ebmr1282272qtx.34.1678904376337; Wed, 15 Mar 2023 11:19:36 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:36 -0700 (PDT) From: "Joel Fernandes (Google)" To: "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes Cc: "Uladzislau Rezki (Sony)" , rcu@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 11/14] rcu/kvfree: Eliminate k[v]free_rcu() single argument macro Date: Wed, 15 Mar 2023 18:18:58 +0000 Message-Id: <20230315181902.4177819-11-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459166827008189?= X-GMAIL-MSGID: =?utf-8?q?1760459166827008189?= From: "Uladzislau Rezki (Sony)" The kvfree_rcu() and kfree_rcu() APIs are hazardous in that if you forget the second argument, it works, but might sleep. This sleeping can be a correctness bug from atomic contexts, and even in non-atomic contexts it might introduce unacceptable latencies. This commit therefore removes the single-argument kvfree_rcu() and kfree_rcu() macros. Code that would have previously used these single-argument kvfree_rcu() and kfree_rcu() macros should instead use kvfree_rcu_mightsleep() or kfree_rcu_mightsleep(). [ paulmck: Apply Joel Fernandes feedback. ] Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) --- include/linux/rcupdate.h | 29 ++++++++--------------------- 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h index 094321c17e48..7571dbfecb18 100644 --- a/include/linux/rcupdate.h +++ b/include/linux/rcupdate.h @@ -957,9 +957,8 @@ static inline notrace void rcu_read_unlock_sched_notrace(void) /** * kfree_rcu() - kfree an object after a grace period. - * @ptr: pointer to kfree for both single- and double-argument invocations. - * @rhf: the name of the struct rcu_head within the type of @ptr, - * but only for double-argument invocations. + * @ptr: pointer to kfree for double-argument invocations. + * @rhf: the name of the struct rcu_head within the type of @ptr. * * Many rcu callbacks functions just call kfree() on the base structure. * These functions are trivial, but their size adds up, and furthermore @@ -982,26 +981,18 @@ static inline notrace void rcu_read_unlock_sched_notrace(void) * The BUILD_BUG_ON check must not involve any function calls, hence the * checks are done in macros here. */ -#define kfree_rcu(ptr, rhf...) kvfree_rcu(ptr, ## rhf) +#define kfree_rcu(ptr, rhf) kvfree_rcu_arg_2(ptr, rhf) +#define kvfree_rcu(ptr, rhf) kvfree_rcu_arg_2(ptr, rhf) /** - * kvfree_rcu() - kvfree an object after a grace period. - * - * This macro consists of one or two arguments and it is - * based on whether an object is head-less or not. If it - * has a head then a semantic stays the same as it used - * to be before: - * - * kvfree_rcu(ptr, rhf); - * - * where @ptr is a pointer to kvfree(), @rhf is the name - * of the rcu_head structure within the type of @ptr. + * kfree_rcu_mightsleep() - kfree an object after a grace period. + * @ptr: pointer to kfree for single-argument invocations. * * When it comes to head-less variant, only one argument * is passed and that is just a pointer which has to be * freed after a grace period. Therefore the semantic is * - * kvfree_rcu(ptr); + * kfree_rcu_mightsleep(ptr); * * where @ptr is the pointer to be freed by kvfree(). * @@ -1010,13 +1001,9 @@ static inline notrace void rcu_read_unlock_sched_notrace(void) * annotation. Otherwise, please switch and embed the * rcu_head structure within the type of @ptr. */ -#define kvfree_rcu(...) KVFREE_GET_MACRO(__VA_ARGS__, \ - kvfree_rcu_arg_2, kvfree_rcu_arg_1)(__VA_ARGS__) - +#define kfree_rcu_mightsleep(ptr) kvfree_rcu_arg_1(ptr) #define kvfree_rcu_mightsleep(ptr) kvfree_rcu_arg_1(ptr) -#define kfree_rcu_mightsleep(ptr) kvfree_rcu_mightsleep(ptr) -#define KVFREE_GET_MACRO(_1, _2, NAME, ...) NAME #define kvfree_rcu_arg_2(ptr, rhf) \ do { \ typeof (ptr) ___p = (ptr); \ From patchwork Wed Mar 15 18:18:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70356 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp52965wrt; Wed, 15 Mar 2023 11:29:28 -0700 (PDT) X-Google-Smtp-Source: AK7set9c3XU5f0NMKioYfzP8tIL/DZ6zTICh8dRIKcifhTCX5p58ilgUo3ZYBd38ZXWav+rY46Cx X-Received: by 2002:a17:90b:3a83:b0:23a:6d16:8e36 with SMTP id om3-20020a17090b3a8300b0023a6d168e36mr629956pjb.12.1678904968599; Wed, 15 Mar 2023 11:29:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678904968; cv=none; d=google.com; s=arc-20160816; b=HbVUgI/xuRCpSEB3esODxg64YUFlaQjHAaOoFXnrSjIQvH+2AKLZaerhHeFLfw21mz Y1AkvCUAppZtU3TXbVp2DIsBS+YDn0VGhtZBs3utL8Z4pXNtRrCjs7THEfTtyzAASx7P kx7Rwc1MW4ZBswqtp9wRXFQYVoms6pxct506P6wxuQVApuO6/z4TyeV1TuTyYyT3QP2y M1Xcb5O2pVExgXs/ZB/Pfl163egd7t1KB89i+wzrTiolRGagzwfwck+59+xnf4Me2L0c Q8oYCct2YLDiin7+tcGLDGGn7i8f7nVokuOQP8vnzPtTtCG7oT3TZt9SyPmQ9n6AxoE5 UvTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2CvInQkgrtFswN6a5J7y2T4rUDkhwlp0YkwDUjcLdMc=; b=Cgj9PTo8yTOkFYtf+RpFzglIEbrP0GGQhysYtRZi24CcJoxB4sNqH1B1Am3Un3WkVC UQMP9WaU3HJZeoO7gktvjU9ZslalhXZF0SxDCx8UhsrG736tfDMWI4Xmvr0EeENX3HwX i/1DeGaytBBVPrQIRl3p/QhYlHHNkKVIOS6h3CrabKK7yBhDSM+TtzOC5KrlCieyO1Y/ YVr3EJek1hr7TrwmQrhvoXj2gg0Lvt3dOgK0wPYK9lSD+rOuVXwd5noAQ8yCNQJtAeb9 w7HwiTNhVq0epG2EA56xczMqx0YQ0xPQqhpmZxjBBxotLyK5P5XhxqNAHT2CbYqikfEK aPWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=KnGZSFdq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n16-20020a170902d2d000b0019cb419df45si6477541plc.401.2023.03.15.11.29.13; Wed, 15 Mar 2023 11:29:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=KnGZSFdq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232728AbjCOSUT (ORCPT + 99 others); Wed, 15 Mar 2023 14:20:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232733AbjCOSTw (ORCPT ); Wed, 15 Mar 2023 14:19:52 -0400 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCCAC8480F for ; Wed, 15 Mar 2023 11:19:37 -0700 (PDT) Received: by mail-qt1-x834.google.com with SMTP id d7so17152619qtr.12 for ; Wed, 15 Mar 2023 11:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904377; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2CvInQkgrtFswN6a5J7y2T4rUDkhwlp0YkwDUjcLdMc=; b=KnGZSFdqJfe5cBkq4aueaxEmiLAtr5exCnajnLei2Srqi9rxmdUuZI63NoOHKdJ2+o zHIUImu4xXpy20R3uMo162yktC1I33Kf0ShmUAEpgNBOOhn4IjHGJR07QliUY+ctVwZQ HWm3wiihMoB3X4nUyfx7NPhrp6HpBq8pnQ1lE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904377; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2CvInQkgrtFswN6a5J7y2T4rUDkhwlp0YkwDUjcLdMc=; b=Hfm5Hw8tDTFpcFvlItCWOWZe9Ew9aBBMkxPo0/31HPCL7jbBAJRNvf4GWXg4DoBIIu 9oZWIIwk++Lu5zVOJlI8dmLNWQjvGqGFjC7KQMrlIyWMtcHokOCi1rgqVq8wC3xbqxJ1 aXz6qGTRJqXd8pVnpB/7c+0wlfd+4kXTNwct6gMtRhzxFAXMQM3GjIMqfZ1tenHm6Ujc Z3CCKQ8vDbBdpkUdRDOMLZRmJj4MKVs/uHUsH58Vm/IMLdy65gbi8csMzipqTQ1S06NH wUcQEHjQJ6r8crBvT+cEeGMJWJkpBhTO5xwvggAQvOiOnAG6Euc/AgwoDTfYuJb0oX1B oKhg== X-Gm-Message-State: AO0yUKUrQrpiRnsP2EEOvXZGd68TlwhkE5sVuSYheM+a35DE19wzyvjJ NeWfvsAO6DuYujtfjKBVIjRIMA== X-Received: by 2002:a05:622a:50c:b0:3d3:33bd:a29 with SMTP id l12-20020a05622a050c00b003d333bd0a29mr1523968qtx.16.1678904377358; Wed, 15 Mar 2023 11:19:37 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:37 -0700 (PDT) From: "Joel Fernandes (Google)" To: Alexander Aring , Stefan Schmidt , Miquel Raynal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Girault Cc: "Joel Fernandes (Google)" , "Paul E . McKenney" , Alexander Aring , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 12/14] mac802154: Rename kfree_rcu() to kvfree_rcu_mightsleep() Date: Wed, 15 Mar 2023 18:18:59 +0000 Message-Id: <20230315181902.4177819-12-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459456059243848?= X-GMAIL-MSGID: =?utf-8?q?1760459456059243848?= The k[v]free_rcu() macro's single-argument form is deprecated. Therefore switch to the new k[v]free_rcu_mightsleep() variant. The goal is to avoid accidental use of the single-argument forms, which can introduce functionality bugs in atomic contexts and latency bugs in non-atomic contexts. The callers are holding a mutex so the context allows blocking. Hence using the API with a single argument will be fine, but use its new name. There is no functionality change with this patch. Fixes: 57588c71177f ("mac802154: Handle passive scanning") Reviewed-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) Acked-by: Stefan Schmidt --- net/mac802154/scan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/mac802154/scan.c b/net/mac802154/scan.c index 9b0933a185eb..5c191bedd72c 100644 --- a/net/mac802154/scan.c +++ b/net/mac802154/scan.c @@ -52,7 +52,7 @@ static int mac802154_scan_cleanup_locked(struct ieee802154_local *local, request = rcu_replace_pointer(local->scan_req, NULL, 1); if (!request) return 0; - kfree_rcu(request); + kvfree_rcu_mightsleep(request); /* Advertize first, while we know the devices cannot be removed */ if (aborted) @@ -403,7 +403,7 @@ int mac802154_stop_beacons_locked(struct ieee802154_local *local, request = rcu_replace_pointer(local->beacon_req, NULL, 1); if (!request) return 0; - kfree_rcu(request); + kvfree_rcu_mightsleep(request); nl802154_beaconing_done(wpan_dev); From patchwork Wed Mar 15 18:19:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70355 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp51396wrt; Wed, 15 Mar 2023 11:26:05 -0700 (PDT) X-Google-Smtp-Source: AK7set8vhWoWxlWP1y7FMPKaZ48JwZN582gejx3+4mOREiEAlEL5IONo0f5rBGXgKXrvyybPRPaS X-Received: by 2002:a05:6a20:394e:b0:d6:9939:b0a9 with SMTP id r14-20020a056a20394e00b000d69939b0a9mr618261pzg.25.1678904765622; Wed, 15 Mar 2023 11:26:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678904765; cv=none; d=google.com; s=arc-20160816; b=kmDle0LSe5vLE/5JVupMupo5dJRrARNIp7jIDfIj3FYAQCwbF1LXkFCPXcDwo3zoui DLtFasXWLEDWSvddr4Lwb64wnfc01QfRFAlAkjaqyhNqu6Kw1/rF2mJQQfx8ToO1Xh/f 6CiOdT3QYbp7jnlxHK0FrJTOatrOxGgVmBysducZ3uAc5zVUeDmDUPIe1WcXzb65T/C4 Hta6mtGv0HZQ9ayJZUrEK2dC1T9VMI6M+y9Kf3gaTYphmHOzyHAzPjWzd7RZEO7EDJgj 1LRt/ECxsaGqMS6XKoYzeupgWSNXB61ZhueYrzUvAgUOoHPrYsNxWu/6PPmdFj167KHE SO6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GhODMKtcWK0LfRf2wdwwZPjRN4HzxNzq88wVUem7HDw=; b=U4NgNfmjsBf2JKqqcIQj51ADF9OCY6VfrJMTbwBx/GLuGoWXfmLW+/4K8b73fUK9XM lkIOYdU4lVZ/NiXtl7zMBRrzeJxB4ipXzzxf4jF5jK6hsuQxTSMrTKtCSf3LCJzHlwP+ FoUCmcJYE6Hn0CYvQQyArkHZqFf926ykiKkE86Bc4V0k0yMsPnSZNjaeREc9+izIXT39 9QIXxfVMdEs5LjqD7+Xq4GzjatcDblQ2tdZPWuqmCRK6K68TviJMkgaXKbyc2nHhihqn stllxdaI3mUFSYEvl3KJsDsqJNnMApDvWMNtA3gKAdM1XtENQiNF94mch9364aIF8M4k DgAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=C+Y304uK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m13-20020a6545cd000000b004fb95253a18si5549944pgr.376.2023.03.15.11.25.53; Wed, 15 Mar 2023 11:26:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=C+Y304uK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231721AbjCOSUn (ORCPT + 99 others); Wed, 15 Mar 2023 14:20:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232666AbjCOSUQ (ORCPT ); Wed, 15 Mar 2023 14:20:16 -0400 Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE62480E25 for ; Wed, 15 Mar 2023 11:19:40 -0700 (PDT) Received: by mail-qt1-x82d.google.com with SMTP id c18so17223806qte.5 for ; Wed, 15 Mar 2023 11:19:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904378; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GhODMKtcWK0LfRf2wdwwZPjRN4HzxNzq88wVUem7HDw=; b=C+Y304uKNIZZWLzEXOsgwjwy501pin0efMM4+4pHeao5pW4Ygdkr844rvREG6JIZNj iHQD4/NBc1VPJlaADkXXuSvNj3OPEv50FU4eSIPGznLD+pOeiJxte4UfTehUiPjQx3Tp Y8vGh4AYquFTIee4Aqt2jKebubt+RqDwdAlr4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904378; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GhODMKtcWK0LfRf2wdwwZPjRN4HzxNzq88wVUem7HDw=; b=QRcl2/SvSeEOKgcYYb2Kfh0PFo/CayHpJsGKRGQb5M2zM0wf8bFL0y9cC4wNgFxwk+ yGfKngJ1t5q96UqjhGYXHcthXrFBI6aPq1e0qUHa9CsDb7EJH2XkuJm5TyrjwiPV2znq w7cM71ymCSp22XeoKzeMTlNUvUF1ngZFTLXmOvqgIUgN0BKzKBJu4sW/rIw7vuS+ya65 Uelrdybh2OC9Up3owEVfnnvM/nXBrzGSYaklgrz9dvU6FoF3uyYfCUHFfiCKTOAHy2vv sQqd0tPb885XDZwvO7AbOcH3UrexG+3YKK/ke7CtbdlkKEohjKy+hPkp5oL34gJimYeo Usww== X-Gm-Message-State: AO0yUKUnoSoO2eL/9LlRvLiX2xkf87C04OpOeb77nmdGzozoeHDC3p5x HBI6dvXZJXXMEjD89LTcQEKQLg== X-Received: by 2002:ac8:5dcd:0:b0:3d5:f1a2:13f7 with SMTP id e13-20020ac85dcd000000b003d5f1a213f7mr1412046qtx.12.1678904378370; Wed, 15 Mar 2023 11:19:38 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:38 -0700 (PDT) From: "Joel Fernandes (Google)" To: Zhu Yanjun , Jason Gunthorpe , Leon Romanovsky , Devesh Sharma , Bob Pearson Cc: "Joel Fernandes (Google)" , "Paul E . McKenney" , Zhu Yanjun , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 13/14] RDMA/rxe: Rename kfree_rcu() to kvfree_rcu_mightsleep() Date: Wed, 15 Mar 2023 18:19:00 +0000 Message-Id: <20230315181902.4177819-13-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459243333114915?= X-GMAIL-MSGID: =?utf-8?q?1760459243333114915?= The k[v]free_rcu() macro's single-argument form is deprecated. Therefore switch to the new k[v]free_rcu_mightsleep() variant. The goal is to avoid accidental use of the single-argument forms, which can introduce functionality bugs in atomic contexts and latency bugs in non-atomic contexts. There is no functionality change with this patch. Link: https://lore.kernel.org/rcu/20230201150815.409582-1-urezki@gmail.com Acked-by: Zhu Yanjun Reviewed-by: Bob Pearson Reviewed-by: Paul E. McKenney Fixes: 72a03627443d ("RDMA/rxe: Remove rxe_alloc()") Signed-off-by: Joel Fernandes (Google) --- drivers/infiniband/sw/rxe/rxe_mr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c index b10aa1580a64..ae3a100e18fb 100644 --- a/drivers/infiniband/sw/rxe/rxe_mr.c +++ b/drivers/infiniband/sw/rxe/rxe_mr.c @@ -731,7 +731,7 @@ int rxe_dereg_mr(struct ib_mr *ibmr, struct ib_udata *udata) return -EINVAL; rxe_cleanup(mr); - kfree_rcu(mr); + kfree_rcu_mightsleep(mr); return 0; } From patchwork Wed Mar 15 18:19:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70354 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp51316wrt; Wed, 15 Mar 2023 11:25:55 -0700 (PDT) X-Google-Smtp-Source: AK7set8Cixms++Sg54IfCsXfItwE76IrwiDrkjGE3VxM1irt2DMG7cnuVZE7Q1uxPdi3kX25ApAf X-Received: by 2002:a17:90b:4f87:b0:234:d1c:f112 with SMTP id qe7-20020a17090b4f8700b002340d1cf112mr877489pjb.0.1678904755619; Wed, 15 Mar 2023 11:25:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678904755; cv=none; d=google.com; s=arc-20160816; b=hlx7iPvcO0JmIDFaGCRGSIim4/+PBG0Xc3xSivA7A0ZehqNog1hgkLDfqcODU8+q4T bgAgEB6nVUcgetaFzOh31uMyba5Rn3LDXuQmyEMHmmcqcKgjWg5OfemfXAxPI1Z9TglZ xuYRYm90ZbtRY8e2Ha94XMk5OMjnZTWpmNV2LngnQgXrIQwhn3F0l9Wq7MJyJe3OwE9r 2LaISB0PRnlwCEC3eJn2BcmYw9hqswQXPiFCr5Sb7mN0QscgWjK1SaYQUcxmmcwxl0hJ 7S4sa17fB8ybxpPKID/kU6bY0DnK2L/iTQks54n4RbKV8U8KBby2CtFoIZCXXa5u+vwJ ZGdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xmvH53QQmvyr82/tblOMveznsjZSWtMQ0eLvrELgokY=; b=o2J9PR1/oxkPREeVC+uZ56XbAPVTTL1F2ERgfXh4DJNVR5EXXSOrOKgjbwMIgxIPKg Se01uiX4CpXbr0g/0T+5fWfhwzezpwJVcW2hrse/OVg711Z3LxpIAJF5FkidB0gsM0x1 x1BfASjQ3b/NOkxE6P08PqH7uyS19f2VhC2hPwjxnK07HBom38NiwlT2g06GH4U/GtOY OBnj7e1q7UA/ka1ri0QJI6iVjnlUrpuavguOsD70tpVINoPaiSFKEz4UE4I7qCar/Fy4 x40zX6LxNdLYJ3Hh2jPomggXzjv//5Cx9B0A7KA5ZavFotiluOkUhc6steQrwOxERQI7 DIZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=AiMp38QX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 77-20020a630050000000b005030163c358si5759157pga.363.2023.03.15.11.25.42; Wed, 15 Mar 2023 11:25:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=AiMp38QX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230044AbjCOSUf (ORCPT + 99 others); Wed, 15 Mar 2023 14:20:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232618AbjCOSUP (ORCPT ); Wed, 15 Mar 2023 14:20:15 -0400 Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDA728534A for ; Wed, 15 Mar 2023 11:19:41 -0700 (PDT) Received: by mail-qv1-xf2e.google.com with SMTP id cu4so13487152qvb.3 for ; Wed, 15 Mar 2023 11:19:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xmvH53QQmvyr82/tblOMveznsjZSWtMQ0eLvrELgokY=; b=AiMp38QXMO7TX9Ex53Fqj+qKtuIf9QDHoK6g5kf7FPb5LvDRL9lR4q3pABkjYygPCd xtrgLXSwyEtrQ5IoNv1WRYyW70egsO6RItBE5A1UbEY1r98si1HoY87B2WSsumwlNUtx hQ7yFbbOynQHjABcQPhpXvu+p5HgybXNekw1s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xmvH53QQmvyr82/tblOMveznsjZSWtMQ0eLvrELgokY=; b=YAH01F0nen99gmuqqqT++g9JAwx1ASjLIPTB3NQAUMd/EltdSnNS9RfLB3jruBHSnR a4E5Z6Q8VCE6qPDdzma8IvGPC+sp6avL+MbprUfPpzvVNw6fAN0P0Xj43OaJGXaVCX/E PI5OZ6aNXozN0/MT+G5Xxv5mFckdPsA2E06EMxBSENNjYkooK4MbUBWMb/HCcEGxpqKY nZ4uBdmwrb9xbHuhGS4kHvtTmUEgvBWKF37cUs23uVK2wIyABaygGyS31V4Cdv4d+Zgw gza4YUJkuKeIBhv+5rYpIi+QimTR2AcyupMtIYmdMFMGgzTe/IxWn5hehEZWr229hTAW 95Mg== X-Gm-Message-State: AO0yUKWrwcQe3JHOS/Af18x2pqFtVFb86D+q2Q6YbbLIrkOPuMvCqMvx HGX3DIButjiLvw6VCOVNoFZrPrMkyS5dCMqZcho= X-Received: by 2002:a05:6214:2389:b0:56a:d94d:6deb with SMTP id fw9-20020a056214238900b0056ad94d6debmr23706425qvb.25.1678904379286; Wed, 15 Mar 2023 11:19:39 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:38 -0700 (PDT) From: "Joel Fernandes (Google)" To: Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn Cc: "Joel Fernandes (Google)" , linux-kernel@vger.kernel.org Subject: [PATCH v2 14/14] checkpatch: Error out if deprecated RCU API used Date: Wed, 15 Mar 2023 18:19:01 +0000 Message-Id: <20230315181902.4177819-14-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459232941890912?= X-GMAIL-MSGID: =?utf-8?q?1760459232941890912?= Single-argument kvfree_rcu() usage is being deprecated [1] [2]. However, till all users are converted, we would like to introduce checkpatch errors for new patches submitted. This patch adds support for the same. Tested with a trial patch. For now, we are only considering usages that don't have compound nesting, for example ignore: kvfree_rcu( (rcu_head_obj), rcu_head_name). This is sufficient as such usages are unlikely. Once all users are converted and we remove the old API, we can also revert this checkpatch patch then. [1] https://lore.kernel.org/rcu/CAEXW_YRhHaVuq+5f+VgCZM=SF+9xO+QXaxe0yE7oA9iCXK-XPg@mail.gmail.com/ [2] https://lore.kernel.org/rcu/CAEXW_YSY=q2_uaE2qo4XSGjzs4+C102YMVJ7kWwuT5LGmJGGew@mail.gmail.com/ Signed-off-by: Joel Fernandes (Google) Acked-by: Paul E. McKenney --- scripts/checkpatch.pl | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index bd44d12965c9..9da0a3cb1615 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6388,6 +6388,15 @@ sub process { } } +# check for soon-to-be-deprecated single-argument k[v]free_rcu() API + if ($line =~ /\bk[v]?free_rcu\s*\([^(]+\)/) { + if ($line =~ /\bk[v]?free_rcu\s*\([^,]+\)/) { + ERROR("DEPRECATED_API", + "Single-argument k[v]free_rcu() API is deprecated, please call the API with an rcu_head object passed, like: k[v]free_rcu(object_ptr, rcu_head_name); " . $herecurr); + } + } + + # check for unnecessary "Out of Memory" messages if ($line =~ /^\+.*\b$logFunctions\s*\(/ && $prevline =~ /^[ \+]\s*if\s*\(\s*(\!\s*|NULL\s*==\s*)?($Lval)(\s*==\s*NULL\s*)?\s*\)/ &&