From patchwork Wed Mar 15 09:09:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 70091 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2229114wrd; Wed, 15 Mar 2023 02:41:09 -0700 (PDT) X-Google-Smtp-Source: AK7set9mAcvjVhgS7WTlsjzz4DiTEi2jpjhNJGe/ECtF/ALItuOTFYnd//WVoHzr9T5cpaSuO8pB X-Received: by 2002:a62:6583:0:b0:5cd:81a7:4094 with SMTP id z125-20020a626583000000b005cd81a74094mr30070543pfb.5.1678873268877; Wed, 15 Mar 2023 02:41:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678873268; cv=none; d=google.com; s=arc-20160816; b=GQ5PcHN1EpOCCssznDTg9Wdbap9z88rCtkxEwxjHMKBRiYPs7/fcc9xQKpf30ga2ou il2ubDrNmoAUWeR29q+PKEZLZg0zT4ms81cPXlrnJ/xXDsrnjL+cww3J/WsvnzixGrvs zxSoz7dc7EQAMy9SSc6zBA2RFVFqiPRzGqq58R4uDH/mxOr+z5LEbxL14dXylQ/oXJYP MjC5CplgyMC4x/G5Occ02ZJ0b30p7ZGkoNq5gXg19AIEAUdARJtZxgpt89LVdfnW7Oqc mxkxqZb/6Eu8wDU8SXJfTvtmRwEcI5RRGMHcM1T+E6aRFnpMsmDljgsqMSM8tuQLn7H9 rrgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MP1L1kZAaysXUeL2NiJnvDJlsldUV5D8hJj4fTXBLAg=; b=nXMGQOrZ0syTPE2hPQRXhmaXu8A9DjoJfONA3K6XBoP04HZUhgvEMBRp59rygaTM+o TIRhwOj0mOOpu/aeOdpCVwfEPOBW8vM5LmHPXArlFF482Yo6x9fyRGDoQDjvyc5z/Wvn MmbAQA3oDiy6rPFN48Snnlx0NMYRhjxBI9PIkzVcWQMLATyFnwQ0Z0W7uFimtLFFcZUg 9g5pR53ukiSbcYm+DZrdNryMmvBbuhRfCHzDzFMbNUQzEcYqOy+JkgLEISl4a0U/kkdB 24TiqS0zZcemfBmPUjbxVAVFFRHBPrIN3O8AG6FCCK2rfhvRzYnbKyjJVdPwxhGaYgGo +KxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b=qQQ5QxU+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f20-20020a631f14000000b00502eff7faadsi4615450pgf.118.2023.03.15.02.40.54; Wed, 15 Mar 2023 02:41:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b=qQQ5QxU+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231768AbjCOJKW (ORCPT + 99 others); Wed, 15 Mar 2023 05:10:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232005AbjCOJJ3 (ORCPT ); Wed, 15 Mar 2023 05:09:29 -0400 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 146D42739; Wed, 15 Mar 2023 02:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=MP1L1kZAaysXUeL2NiJnvDJlsldUV5D8hJj4fTXBLAg=; b=qQQ5QxU+RKTbYCtFpC0w+eFvfiiZ1Pyh1M9Ae2gLl2Ok0pqCc4Ky/Inp dLr2R5L0fCkrKQNYqc+OhyQ22tvtp4oZDxypnnQTY9TK4d7dUuIgcYQvI 7h0eKZjVeoGnAFotV9NqybWdyOdU4rbAIs4wJVNleOa9apZsxgsIHtywz g=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=Julia.Lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.98,262,1673910000"; d="scan'208";a="97303132" Received: from i80.paris.inria.fr (HELO i80.paris.inria.fr.) ([128.93.90.48]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 10:09:09 +0100 From: Julia Lawall To: Mauro Carvalho Chehab Cc: kernel-janitors@vger.kernel.org, Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] media: atomisp-mt9m114: adjust macro parameter name Date: Wed, 15 Mar 2023 10:09:04 +0100 Message-Id: <20230315090904.20092-1-Julia.Lawall@inria.fr> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760426217144104194?= X-GMAIL-MSGID: =?utf-8?q?1760426217144104194?= The macro parameter name, sd, captures the field name in the third argument of container_of. Fortunately, the argument at all uses is actually sd. But change the macro parameter name anyway, for a little added safety. Signed-off-by: Julia Lawall --- An alternative would be to make an inline function. drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c index 0e5a981dd331..b47d0882041b 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c @@ -35,7 +35,7 @@ #include "mt9m114.h" -#define to_mt9m114_sensor(sd) container_of(sd, struct mt9m114_device, sd) +#define to_mt9m114_sensor(s) container_of(s, struct mt9m114_device, sd) /* * TODO: use debug parameter to actually define when debug messages should