From patchwork Tue Mar 14 05:37:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 69306 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1582243wrd; Mon, 13 Mar 2023 22:50:27 -0700 (PDT) X-Google-Smtp-Source: AK7set8777h17kf7PyusxqI7oK7eeYqgaiuPhENflBprTWv2/SXJcttf9GAvkEwa9RXqPdE66UlY X-Received: by 2002:a05:6a20:3549:b0:c7:49c4:c298 with SMTP id f9-20020a056a20354900b000c749c4c298mr30437694pze.26.1678773027427; Mon, 13 Mar 2023 22:50:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678773027; cv=none; d=google.com; s=arc-20160816; b=g/WhV5Oky1HnKAuyqTGGc+brj1JvKTkpUR5DB2Qyx9KOjC1yRWvVjR66cZ4lGrjDLt eJ0pkEzWDlBLPXAGhb/BjeGr2vYRS9YKjHImdXoPiJ/hRAeRIz17n60S3ETP9ITcktZI FTzDWbpUCen7gWuSF0VyvTYo1bMRztTwD5X79Ii5O6MSFNd0hIFzIHQAxwLOWMOUvuNK tYi127Cqi2nXGnaA7LKpstdLy/WcdUYW36TowIYdgJ879Zc3xz4/wbrSU/MtDTJRdH6t 9vqcnNh6eFbceROhFtP17IT1if1U7drNchY0Y9ZCG4tUJkYK3QaoiBX4SJotAN18v/D2 ieQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=e2qLWiEu+kwQHNuuyN9RiYgLYwjEZFKFrGhRPUZl538=; b=X2y/bMWbLo8WLhKDqoywIzbSO2+PpLODFauYQtvfwvcwf0FRhrFor+naNEYgPExVRi zTS/zbgNKQJHN/qy5BW9IwMFU2dzgnPW+hbyJDymq3lm7X6PNMIET9v0scCr+8q98cXb MixJUVTVbf4kkrYN7l8wgZxdHgMiJ3XSomuf54JKdyODkvW6aK6HBxsR9qqJEOWx0i6u hT60JlZ4DSQkQzj2vvA7H14sea6yanGAGx09SPR7hWCZp24pR6Ignqm7pI2ahf5vXpyT GhaCEcs8KdFq09W0rx855QZar4msrHgu0mwmDS5jblzj5y/KhMyKt5TNskM4hAz3kY1U /fYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BxxSAemi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 124-20020a630582000000b004f22f5297b4si1451365pgf.742.2023.03.13.22.50.12; Mon, 13 Mar 2023 22:50:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BxxSAemi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230039AbjCNFiE (ORCPT + 99 others); Tue, 14 Mar 2023 01:38:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230063AbjCNFiB (ORCPT ); Tue, 14 Mar 2023 01:38:01 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0A1982379 for ; Mon, 13 Mar 2023 22:37:40 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id gp15-20020a17090adf0f00b0023d1bbd9f9eso3790157pjb.0 for ; Mon, 13 Mar 2023 22:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678772260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e2qLWiEu+kwQHNuuyN9RiYgLYwjEZFKFrGhRPUZl538=; b=BxxSAemif3HMqEBDGRssBokbkkaHm51vUuIzdJK/3H++ZYNX9HnjmVXIIgCVNGJ4xB 4JbzAw5ygYQFgdkjMPKz7Cqupde1QscsZt1N28G8TkGyd/ZNg5hhyEw6Uo0ggqBezmVB uDYxWI7yt5SO7kwY91lKEVf0+uWmjbBsAsmt9ObcXmF6tYQXI6zRbgjWlJx0PKsus2YW 5k8r8Vlv4cfKjbAsSgkXKYBv9Bm+9pvKFNBcDYKsXurGSxp4W58YRjERsu9b4IaWGQHq 2xPs3EB9OBpNz13YCaLeWBP+DlPcTUGEz90Ju0StX8bodB8jJr+dmErzLt6fuFN0F55v kLOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678772260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e2qLWiEu+kwQHNuuyN9RiYgLYwjEZFKFrGhRPUZl538=; b=e+0p5Q4w6s57fyFSvyeTuFNlbPn50qnxDY+4w4TOXbxEI0VSzu5wo5/ZGk4mMbIpFY 08K2DdsOVMsTgRGhaz1UCUgreTrEg4KBHX6wtqEq59XORy/4Pp0s78n0jVgrfJb09lBp VqEG/UqpQNgFBvhdIB9ZvlwVjD1H7XJ0njQxlb89j7jV06NW+j9tSLeWeG6Mfa0zgBWa i5PevfQXGKR4BdLTEcntlnDTvDYfSQVo3e6vQ0hryF1HafcfaJM6LWnCgXgvIv8y4z49 ak6r+2ZFKAYLIT+luHPZlkSHq2GDF7mL9jFKpOhycDBM5PSwMbU/WFbflZHHYUR6cLX8 ockg== X-Gm-Message-State: AO0yUKU/XTuLkRya4lmJaS7d3LbCfpqouT3+eN+xE7PewvBKLO32FIwr n1JAn+WwKPiqHJI6173ocazr X-Received: by 2002:a17:902:a986:b0:19d:297:f30b with SMTP id bh6-20020a170902a98600b0019d0297f30bmr28982374plb.19.1678772259922; Mon, 13 Mar 2023 22:37:39 -0700 (PDT) Received: from localhost.localdomain ([117.217.177.49]) by smtp.gmail.com with ESMTPSA id n126-20020a634084000000b005034a46fbf7sm675093pga.28.2023.03.13.22.37.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 22:37:39 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, Manivannan Sadhasivam Subject: [PATCH v7 01/13] dt-bindings: arm: msm: Update the maintainers for LLCC Date: Tue, 14 Mar 2023 11:07:13 +0530 Message-Id: <20230314053725.13623-2-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> References: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760321106116672565?= X-GMAIL-MSGID: =?utf-8?q?1760321106116672565?= Both Rishabh and Sai have left Qualcomm, and there is no evidence of them maintaining with a new identity. So their entry needs to be removed. Listed Bjorn as the interim maintainer until someone volunteers to maintain this binding. Signed-off-by: Manivannan Sadhasivam Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml index 38efcad56dbd..6570b808fd0d 100644 --- a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml +++ b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml @@ -7,8 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: Last Level Cache Controller maintainers: - - Rishabh Bhatnagar - - Sai Prakash Ranjan + - Bjorn Andersson description: | LLCC (Last Level Cache Controller) provides last level of cache memory in SoC, From patchwork Tue Mar 14 05:37:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 69317 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1591276wrd; Mon, 13 Mar 2023 23:17:59 -0700 (PDT) X-Google-Smtp-Source: AK7set8NOs5CbDF5p47QqPoA9pkl645nFoeleAQHoWIEmU341HAMZ/TE8E6TDoMPGNaaQDIublkI X-Received: by 2002:a17:902:e744:b0:19c:d169:cb3f with SMTP id p4-20020a170902e74400b0019cd169cb3fmr46106327plf.21.1678774679461; Mon, 13 Mar 2023 23:17:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678774679; cv=none; d=google.com; s=arc-20160816; b=g0M9F5oB9jIR8xNTkRzMLkpZSC+5TYFpPY1+yL2b+FowjBfn9oJWVUPd1H/zBU0nYo 70zS8C3RvWvTxr5qDevuv8cXDTEVccenPDXWPMKPtKIq/fgLLUhCeVp6VDpDXjWbp9nF je+toJKTfmC/zVYJQXXvEGF8aG+H5/VfDd9fqxiTmftFiH0shA63nnX7uzleysMJmWJ8 3JuVLQMtbKoTgUspoYlOTusHE0VmQiAHZqe/0v2VLPiq+jph/7hfnatgCfvPO0Ydto1h VUeasdFgOom/9LkxPvK1SMaF7I8UY6+CnCylvgO/0ZLjXgJsRVzBmihHssrdRVwVkuks mHWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=E3ynFMYwQcpfXg1vBUZGiwqSjOZbWEHjnhI8PWp4GCE=; b=rfvBcCO9Jsiefh420pZ2hGMXG3C9rv5g0HClsxCPGvMdYVM6SfquCBYqEBbOK9ZurA KTN36puaJqHpDgNCh0FjZ66T1KYtXFxwm0+/NGOxJmn+Mlbnbzms8jHCk8HxLC6/kRMN OcXgIGK1nAK7UZ07SZI5y9xmB5rHYNzljLXp9VaSvWa9lxEt8Jj8SnUbayS8qc69BYJm bI0aNyQl2n/l/nsfi/rmO0GEr0CBcAIudIkG46CiZ5LHDpQoJkBvdwEjkbY1SIE4kKM/ lytY7sfRgRwIOCZXaV0Zy1cERNW5dCBaZL5J/xAbasnu1VesUbVIqOD1mpEu1wEIR9Tq Ijrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CKgY+Md7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jz5-20020a170903430500b0019933d90390si1555230plb.618.2023.03.13.23.17.45; Mon, 13 Mar 2023 23:17:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CKgY+Md7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229709AbjCNFiH (ORCPT + 99 others); Tue, 14 Mar 2023 01:38:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229902AbjCNFiF (ORCPT ); Tue, 14 Mar 2023 01:38:05 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C866281CEB for ; Mon, 13 Mar 2023 22:37:45 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id a2so15430296plm.4 for ; Mon, 13 Mar 2023 22:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678772265; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E3ynFMYwQcpfXg1vBUZGiwqSjOZbWEHjnhI8PWp4GCE=; b=CKgY+Md7XM2Dq1AiLHTRelpqNfgoCLeHgyr5CE0eZGmaoLW0paAx3qE3HR67mx8o27 RaIdjBQdHGMuUMEWzPyUHya+yzGzgiN6mGSgYqMGb4JwI6wom4ahnePuf+Z9IeoD9+dU Lx1L/umvPfmE8LUfWULFgO5dfdDt4by0lxqBnUJ7ILNB1Gvltg0UabJITh+k5VcWOtT8 +EBQbVhUYEiWj3faoMjM7lZdW2Vn4f03oWYISD4ZL3kCLQiMk5JzgCpY5fIF7/jP5Aqa IAa8s5P1mIxzGKyNNpZUbJzkqPhYZTDsY0ykLduyKMAe56pRLRog6fb7kow+lHI/Q2Gz cvaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678772265; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E3ynFMYwQcpfXg1vBUZGiwqSjOZbWEHjnhI8PWp4GCE=; b=K37QX2oCMHgUytOezQFARRzAxF7RNozdCPURhGfXHfLBfZ/1NDLGP9OaVLH1k4QlMU 2L84UX6Ibva4kNAk8vRwA0Px80/DvnQvu1M44zNcQSmjjjp0E2tA2Z7YMylgt/+AjnFN kH+mTyjVNJo/rwLwdWXVdEhBDQfB7JTJIYnnrZmNY9FhWwFRZaC8dItCifZZHW/KU4M6 0W1/tOtvsKTNyJn25ZQT+vUKXUJmXY6WX5mMPZzRrUzzRLz2Mrx+WcWD+W3HYGvdOyWV 89WIylviYzIIwVXbpFiLn7ZAKEEei5SjTjcMSOMNSiQmUxNLG089KYA5LIbS3AmyJl21 jTcw== X-Gm-Message-State: AO0yUKUwswXssJrlWE3ol3ZabazZpheeyNTTju4t17nftPyvLiARjliI pARWaxC58nkaLHNeSbF1aYOf X-Received: by 2002:a17:903:1309:b0:1a0:5d0b:c31e with SMTP id iy9-20020a170903130900b001a05d0bc31emr2332917plb.44.1678772265234; Mon, 13 Mar 2023 22:37:45 -0700 (PDT) Received: from localhost.localdomain ([117.217.177.49]) by smtp.gmail.com with ESMTPSA id n126-20020a634084000000b005034a46fbf7sm675093pga.28.2023.03.13.22.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 22:37:44 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, Manivannan Sadhasivam , Krzysztof Kozlowski Subject: [PATCH v7 02/13] dt-bindings: arm: msm: Fix register regions used for LLCC banks Date: Tue, 14 Mar 2023 11:07:14 +0530 Message-Id: <20230314053725.13623-3-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> References: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760322838031651468?= X-GMAIL-MSGID: =?utf-8?q?1760322838031651468?= Register regions of the LLCC banks are located at different addresses. Currently, the binding just lists the LLCC0 base address and tries to cover all the banks using a single size. This is entirely wrong as there are other register regions that happen to lie inside the size covered by the binding such as the memory controller and holes. So this needs to be fixed by specifying the base address of individual LLCC banks. This approach will break the existing users of this binding as the register regions are split and the drivers now cannot use LLCC0 register region for accessing rest of the banks (which is wrong anyway). But considering the fact that the binding was wrong from the day one and also the device drivers going wrong by the binding, this breakage is acceptable. Reported-by: Parikshit Pareek Reviewed-by: Krzysztof Kozlowski Signed-off-by: Manivannan Sadhasivam --- .../bindings/arm/msm/qcom,llcc.yaml | 125 ++++++++++++++++-- 1 file changed, 114 insertions(+), 11 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml index 6570b808fd0d..93b977428a14 100644 --- a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml +++ b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml @@ -33,14 +33,12 @@ properties: - qcom,sm8550-llcc reg: - items: - - description: LLCC base register region - - description: LLCC broadcast base register region + minItems: 2 + maxItems: 9 reg-names: - items: - - const: llcc_base - - const: llcc_broadcast_base + minItems: 2 + maxItems: 9 interrupts: maxItems: 1 @@ -50,15 +48,120 @@ required: - reg - reg-names +allOf: + - if: + properties: + compatible: + contains: + enum: + - qcom,sc7180-llcc + - qcom,sm6350-llcc + then: + properties: + reg: + items: + - description: LLCC0 base register region + - description: LLCC broadcast base register region + reg-names: + items: + - const: llcc0_base + - const: llcc_broadcast_base + + - if: + properties: + compatible: + contains: + enum: + - qcom,sc7280-llcc + then: + properties: + reg: + items: + - description: LLCC0 base register region + - description: LLCC1 base register region + - description: LLCC broadcast base register region + reg-names: + items: + - const: llcc0_base + - const: llcc1_base + - const: llcc_broadcast_base + + - if: + properties: + compatible: + contains: + enum: + - qcom,sc8180x-llcc + - qcom,sc8280xp-llcc + then: + properties: + reg: + items: + - description: LLCC0 base register region + - description: LLCC1 base register region + - description: LLCC2 base register region + - description: LLCC3 base register region + - description: LLCC4 base register region + - description: LLCC5 base register region + - description: LLCC6 base register region + - description: LLCC7 base register region + - description: LLCC broadcast base register region + reg-names: + items: + - const: llcc0_base + - const: llcc1_base + - const: llcc2_base + - const: llcc3_base + - const: llcc4_base + - const: llcc5_base + - const: llcc6_base + - const: llcc7_base + - const: llcc_broadcast_base + + - if: + properties: + compatible: + contains: + enum: + - qcom,sdm845-llcc + - qcom,sm8150-llcc + - qcom,sm8250-llcc + - qcom,sm8350-llcc + - qcom,sm8450-llcc + then: + properties: + reg: + items: + - description: LLCC0 base register region + - description: LLCC1 base register region + - description: LLCC2 base register region + - description: LLCC3 base register region + - description: LLCC broadcast base register region + reg-names: + items: + - const: llcc0_base + - const: llcc1_base + - const: llcc2_base + - const: llcc3_base + - const: llcc_broadcast_base + additionalProperties: false examples: - | #include - system-cache-controller@1100000 { - compatible = "qcom,sdm845-llcc"; - reg = <0x1100000 0x200000>, <0x1300000 0x50000> ; - reg-names = "llcc_base", "llcc_broadcast_base"; - interrupts = ; + soc { + #address-cells = <2>; + #size-cells = <2>; + + system-cache-controller@1100000 { + compatible = "qcom,sdm845-llcc"; + reg = <0 0x01100000 0 0x50000>, <0 0x01180000 0 0x50000>, + <0 0x01200000 0 0x50000>, <0 0x01280000 0 0x50000>, + <0 0x01300000 0 0x50000>; + reg-names = "llcc0_base", "llcc1_base", "llcc2_base", + "llcc3_base", "llcc_broadcast_base"; + interrupts = ; + }; }; From patchwork Tue Mar 14 05:37:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 69320 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1591358wrd; Mon, 13 Mar 2023 23:18:20 -0700 (PDT) X-Google-Smtp-Source: AK7set/935AA/IqiKRAitYx4zMrVgVYVWLIffaxTkt6B/6oJcQDMOYbKH0yRSfFxNLGQIXvmJlZp X-Received: by 2002:a17:902:a986:b0:19f:2332:d2ca with SMTP id bh6-20020a170902a98600b0019f2332d2camr8311895plb.52.1678774700196; Mon, 13 Mar 2023 23:18:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678774700; cv=none; d=google.com; s=arc-20160816; b=D9MQKE9A5gBySBcka1/u6+8ixgXp1a6B9dmNQ9RFSsLdZwi0BWTL04LODP6OYgnecO kMOJOUgf/vA2TbcURQF7kr1lx5IsEymagf1FcfhjZCu0wBfW115i0FFd3V8+PWfywmNu 1r765gOMNMzNNi7J9IVpp+1oFpEeEbGtmsq8vqLNUmmdbjWxkJVJWT1ixh06j69HGbYH Gj0DDLFB5AqIdOFVevd/2q9kKCdsexEEcnuNtDiq0fiYguc8yVRKLAgX1BG7tF/jkrWG 9htMvDlWEmHg28QjuimQ7kQpLc6gu+FAk4LA66Xqsz3XQFbZAiVQdqXFSsdBclxF8g1q ykIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4tE4o5E5NxTGWs0FFcIpd5GaMpz3q7yKukVUL4nRPNs=; b=vCzKuz3ZYyIL44fj44nV6DHFMYq0RrDDlGQ8rlbG6qBmJDZ7SwppnyqJeEfPtmRr+G vHFn06eiAiDB62fJTBh7SrffOJHUxYLmo4cjNVCDmDOns2RA8JfSjYWpJcyqM5WkM2J8 YIp2CWkRalVxx8tVutPuW5vp9OC9eozfm+Ddidp2Eu1JyYRfYPiuWPnuutLaNb6P7nUZ 3NkVHjaqoBPGpkzec6sIL4Ey5wJNzdl+6RSWVlwo5Sjjf/TtAcx3uAt4c++213Fmw7Zl 5hb/FsThhHJiJZ+S9bpZp0VtTiTrIDxvz1oEmE77XC0F/+5AYXWcIx0fkk4PGdbN+0GW RFHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wmJqBLe3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id li6-20020a170903294600b001a04bd0a85dsi1545137plb.474.2023.03.13.23.18.05; Mon, 13 Mar 2023 23:18:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wmJqBLe3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230105AbjCNFiL (ORCPT + 99 others); Tue, 14 Mar 2023 01:38:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230051AbjCNFiG (ORCPT ); Tue, 14 Mar 2023 01:38:06 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B8637D0AB for ; Mon, 13 Mar 2023 22:37:50 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id h11-20020a17090a2ecb00b00237c740335cso14001244pjs.3 for ; Mon, 13 Mar 2023 22:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678772270; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4tE4o5E5NxTGWs0FFcIpd5GaMpz3q7yKukVUL4nRPNs=; b=wmJqBLe3PPzAtxKqvtVbRBPMaWvTNHEiPth7RWQgJ6zLBaUAo27PEc0oVrbGavD4dg AfMSFVO+t6s1kScrp/8cp6dCvU41Dckn9S83/o3f6tTMsDANGYlEevDegEjHXPgg6O6P 543ezXPnfrkENqcb+YmM1OpdXpyZw0u4EEIqjlBTpzn1IqHD7vFiHiLKMVAsLWKCOMzb w9zJOIloYL7lIkHmOuYninQuszhZ/PxkNwBArQt2KZmVxrCQgyp7Grkstfo7BiAOi0Jw Iyg9VsspxkJNc1wo64rbpjPI9UPa9wReMhvasEmnv2pSF0jvwRlvXxHTViyOtVCt4jPN xfiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678772270; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4tE4o5E5NxTGWs0FFcIpd5GaMpz3q7yKukVUL4nRPNs=; b=QQV77Ue/W6BgDPqs/8s2cDGVRe5rxYdjZgAFfDevbfh7Xl341FmE0O3sO1+o1TvbzG Xlb30/+zovXi9ZUQ5iFFohrq640lZc1t83HVylUvxb/ptgMu7ta2HPmuq3xnEstkvCH/ EYDXDtf9BJWHUdR0E1iuaEYAndyKuQ1YC2J2vG7Ws9ByQXum0SLJonIsum+vFvgGeRf6 Wnv5yw3SbPsHZ8d0F8NVO8/G7TM1pwESFy4dLvChgiAzve600q614ePr3t/KqdBIoMVa OkGyWakKR1MHnWMof2uzSOBCnfgvXjUcVbqi/TochQ1J+6quv8kNCo3SAEUVye9483Yv zgag== X-Gm-Message-State: AO0yUKWPQZmEWg6UCRylKnWDSXQ+FoKXeXP6EgteuL3oJp2sdamflB9k LzeKDEPUJw0aANUDetdq9Z/S X-Received: by 2002:a05:6a20:8f09:b0:cb:cfb1:5009 with SMTP id b9-20020a056a208f0900b000cbcfb15009mr46167648pzk.34.1678772270021; Mon, 13 Mar 2023 22:37:50 -0700 (PDT) Received: from localhost.localdomain ([117.217.177.49]) by smtp.gmail.com with ESMTPSA id n126-20020a634084000000b005034a46fbf7sm675093pga.28.2023.03.13.22.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 22:37:49 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, Manivannan Sadhasivam Subject: [PATCH v7 03/13] arm64: dts: qcom: sdm845: Fix the base addresses of LLCC banks Date: Tue, 14 Mar 2023 11:07:15 +0530 Message-Id: <20230314053725.13623-4-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> References: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760322860204538815?= X-GMAIL-MSGID: =?utf-8?q?1760322860204538815?= The LLCC block has several banks each with a different base address and holes in between. So it is not a correct approach to cover these banks with a single offset/size. Instead, the individual bank's base address needs to be specified in devicetree with the exact size. On SDM845, the size of the LLCC bank 0 needs to be reduced to 0x4500 as there are LLCC BWMON registers located after this range. Reported-by: Parikshit Pareek Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 479859bd8ab3..3bf95a12ebb9 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -2192,8 +2192,11 @@ uart15: serial@a9c000 { llcc: system-cache-controller@1100000 { compatible = "qcom,sdm845-llcc"; - reg = <0 0x01100000 0 0x31000>, <0 0x01300000 0 0x50000>; - reg-names = "llcc_base", "llcc_broadcast_base"; + reg = <0 0x01100000 0 0x45000>, <0 0x01180000 0 0x50000>, + <0 0x01200000 0 0x50000>, <0 0x01280000 0 0x50000>, + <0 0x01300000 0 0x50000>; + reg-names = "llcc0_base", "llcc1_base", "llcc2_base", + "llcc3_base", "llcc_broadcast_base"; interrupts = ; }; From patchwork Tue Mar 14 05:37:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 69310 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1585850wrd; Mon, 13 Mar 2023 23:03:06 -0700 (PDT) X-Google-Smtp-Source: AK7set+w7z7AssAABK20Jy9W1VMKyNJYARoJZzTT5K1+ibRSS788BRWlJd+JX2CacmkTO7wdxSVu X-Received: by 2002:a17:903:22cc:b0:19c:d5a5:1f52 with SMTP id y12-20020a17090322cc00b0019cd5a51f52mr42909172plg.18.1678773786000; Mon, 13 Mar 2023 23:03:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678773785; cv=none; d=google.com; s=arc-20160816; b=0t3T5YiMZ+fPG7Nl2wLyRQuUYtU9aYnjNJ2veR7RX/qr/FLzxerF/eOUE5DCIL8Pxz yf9X45ZaFj9eJFxyHI1MQ6J0YVFDbee81GKB72pHJyJdxVxDQGUCRw7ZzwtLafBHV7gQ V2Ha87w2uMB+zTovbWr83dEPteCvmNRileJSNdR2Mfq1O1taKyr11LHrgOVd9y/Fm6Hc WNPsljHs+jZseKky2cJe0pl2wxP7sX6s9yU4Rg/vf0ZO6zvM+D0H29+xJC/ZnbvggvIh UjaKb+HByfYsznNxYpPhu5VyG/y/GeS6xTpy6reUlHK/LEOfTMczs0tl+Is/s0TdT8i9 fUEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5/ORW+ZG5QT+TPocYHNFiE88/XBOJZ36UEuAeSGiS3k=; b=oWVJhXb9zPv1ncsW45TSyBcR/ZJ0QPUlhV00PAhXdI1fpevgNmBjoF0vXq0ytW/6Ht zsBvj47DRbRVQrwmCB4j+e126iEO78iQ8Pxyw7T6MhNHCyy1qYtFANgTVJ8gxCDvBFcU 3QXPuJwIGW8/+RTIpz2H5ymIuggdAR2XPCcGtZXMEVsWbARtjLLlYIhcyWsRVBGSICAF AXdhy2LeHsFlQniTH8WX8IQz6emOf8N5/w051pgN+skS6s6sKgoEwrjB1I6KwGop7wek 0szjT8pbScHmUCKTVEWdL7dzua4wguGJ4I7pGj3HG17SznUw/PEqntjNR20nObFtQ67z cPsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KgC3W5ID; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p2-20020a170902eac200b0019e698b3cefsi1669256pld.311.2023.03.13.23.02.47; Mon, 13 Mar 2023 23:03:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KgC3W5ID; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230117AbjCNFiN (ORCPT + 99 others); Tue, 14 Mar 2023 01:38:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230035AbjCNFiI (ORCPT ); Tue, 14 Mar 2023 01:38:08 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 636E7567A2 for ; Mon, 13 Mar 2023 22:37:55 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id d10so8213472pgt.12 for ; Mon, 13 Mar 2023 22:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678772275; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5/ORW+ZG5QT+TPocYHNFiE88/XBOJZ36UEuAeSGiS3k=; b=KgC3W5IDzN4LUdbRT3iFN7d0cAncrE4n8ln/gf+4ncvZddm2JS9mfUvfgLPL/FXDH0 YQpXC5an/SOmxd+w9D63Th+6q0X2rbD8JRL9W8t6Bs8TRsqcZF+UaneG/qXuxKngLkjT 0c65N4SjLlCgGEsmbgUOll4b54vbIFmkTjmwJ3ZVkR2NWnspsczsGtkTdjw9Hg/9Yb2O ijJuyLzi7FEoConmYfLnmjSxknrXksP6K2RDG/Yi8SIia2xyTqHx37ppbXvU01sr45Jq +UO6gJgBexQ6SnagtqQp7cKP+6K/KE8UbRktjMinGIsmWmlAz2sEEduIJ+zMu0RuX+7M mYSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678772275; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5/ORW+ZG5QT+TPocYHNFiE88/XBOJZ36UEuAeSGiS3k=; b=x1pLK5JntqhPgoue15B8o1Gea7qzhcDf/Cz7w2PYKtYy4A54rsX0hLu3SkGr2+H4+Y 5Y1SAqBkpZAw9R7wZAHeX/gVo3maXf81BzyXxpYe7I0d9O8sI8oKDfI5QJaoNqv93hU/ vDp1q9XuiWv6EqQilFrq/VpcqeXrnQHox562ZpqD3wgL+FbLlohcz6RBcCH8qxmRspIF QhW+vSao/61546gQXg3CEAupIOrSGw80I/ObWFpg09Vq6rR79wSlC93WYZYvhdFwonIg 0+D0GdYG363189xKxDGJeLkQ1bcaDvDYJxV1ScrHfz5LrOdE3zCyFD2/sLhz1sUb/GpQ r1yA== X-Gm-Message-State: AO0yUKUxdHOjT5e1MZDThNKD1sH5bpAGvJuDJ3PViDOzLTCrgIccfj6j /ZL1R6sqw3XqWkuTk1rPH7Db X-Received: by 2002:a62:3142:0:b0:5dc:ecea:f650 with SMTP id x63-20020a623142000000b005dceceaf650mr27802545pfx.19.1678772274844; Mon, 13 Mar 2023 22:37:54 -0700 (PDT) Received: from localhost.localdomain ([117.217.177.49]) by smtp.gmail.com with ESMTPSA id n126-20020a634084000000b005034a46fbf7sm675093pga.28.2023.03.13.22.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 22:37:54 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, Manivannan Sadhasivam Subject: [PATCH v7 04/13] arm64: dts: qcom: sc7180: Fix the base addresses of LLCC banks Date: Tue, 14 Mar 2023 11:07:16 +0530 Message-Id: <20230314053725.13623-5-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> References: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760321901351002682?= X-GMAIL-MSGID: =?utf-8?q?1760321901351002682?= The LLCC block has several banks each with a different base address and holes in between. So it is not a correct approach to cover these banks with a single offset/size. Instead, the individual bank's base address needs to be specified in devicetree with the exact size. On SC7180, there is only one LLCC bank available. So let's just pass that as "llcc0_base". Reported-by: Parikshit Pareek Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index ebfa21e9ed8a..62cc9eb4882d 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -2760,7 +2760,7 @@ dc_noc: interconnect@9160000 { system-cache-controller@9200000 { compatible = "qcom,sc7180-llcc"; reg = <0 0x09200000 0 0x50000>, <0 0x09600000 0 0x50000>; - reg-names = "llcc_base", "llcc_broadcast_base"; + reg-names = "llcc0_base", "llcc_broadcast_base"; interrupts = ; }; From patchwork Tue Mar 14 05:37:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 69307 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1583284wrd; Mon, 13 Mar 2023 22:54:45 -0700 (PDT) X-Google-Smtp-Source: AK7set/eVjqyPGI6vC9aD5IlAX0P5YcwIyFPSf868YoKzbb24+Ofw0C+5LZixK+0oZlcJecdADEf X-Received: by 2002:a17:902:f54a:b0:19e:6e00:4676 with SMTP id h10-20020a170902f54a00b0019e6e004676mr44270210plf.61.1678773285381; Mon, 13 Mar 2023 22:54:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678773285; cv=none; d=google.com; s=arc-20160816; b=bgJ6LI5ggj3fHg3k0IeURkFo00FLtbSwJhkISo4/U7cBDK7HhWvX4shTKT74jy8Rfy trTGYDFl7Ke44u6EZ8a4EIa0ivriKuaxlI+wPoye15aOynBHwAgrxOK8L3TJ6CFBsx+6 hHqDVC3DgEjhtyKp9rQMx4dPWgdhhUkQVGr6a1Blvj153ayEKq++dAX/6HFY8OgBMgki qTvqQvA3ZJw01CkDOiTf0k8B6zrFxmnX5IJ0AEIGbE+kXd9VSbzqEsQXXGNJsKZbm7Gy D9vwqNV8TZ97pnlANloCwHBZjSIYZ59vu2VDbBuhtbeYxTgWIvo/EQCoaEDWVzVyDRhp r7Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=H3jjAvyClxqCSaG5sOi6OveXFyY33UJ9o9fFaRGOIoU=; b=g4X40TeZEFgwhm7xUGVvwQcYB4nQ8Cl8YfJAKGDC3r/VZJz71L1trC48WuFQKBV1PZ wGeF1XbMhV0/ONDIO4AlfgNRPpSpdrGtQz6LSZykKA2HvASEWZoEN4ioIJH86nS0lm6L kfpYSevEuWuNKccLKJBQEc7dy6qnc7bcjIufQDjeK/UdXNk65lkkOj89qiJq2oZ+s5Hc sw2NmHDEJre2EkA31dEN7UFCk31TYDzJHH1eUe51b1VK67fQFYM7SHQyhZ3NeiQPl/XJ MLzqynhHi4kZr+TlqcRNm+UBDlJA82hsaDbSsqPcGfZW9PTyv55xqDSiQpu5ZsuAHr6K KyzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pTopKsVk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kt8-20020a170903088800b0019f24ac470bsi1602011plb.559.2023.03.13.22.54.30; Mon, 13 Mar 2023 22:54:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pTopKsVk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230164AbjCNFiX (ORCPT + 99 others); Tue, 14 Mar 2023 01:38:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230077AbjCNFiT (ORCPT ); Tue, 14 Mar 2023 01:38:19 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0862413531 for ; Mon, 13 Mar 2023 22:38:00 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id cn6so1698446pjb.2 for ; Mon, 13 Mar 2023 22:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678772280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H3jjAvyClxqCSaG5sOi6OveXFyY33UJ9o9fFaRGOIoU=; b=pTopKsVkrmcnJWqtjzZETiBVVfzs36mxPQet1SSc4HmcKIl/9QrxEYG8b3LT4J9hxb S++6m5piyCfxh/s+J3V0YdwSE7c+YYV23iZ0mGgr/YL01LCbOCZMEo0vcy/0O/xlytSc LagXJ0g5iUX9DCWADWV+i3Zk/rk+wLcMSsytrT5KbHQvuHvToADbxLtkT7wJM4EprV58 HTOVaBE6y7rMUumLYRa/w/fNNySH2+SlPtDX3hI+f8x5aDoIBVak6k0JWY74QCeore1g 2gHtZjtXDBo0bmCMlmh4B2iQnapr2JSJss5eKGyKGfIgjDxJ3I/lxtYx4ZRTXx2zTiFk lVPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678772280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H3jjAvyClxqCSaG5sOi6OveXFyY33UJ9o9fFaRGOIoU=; b=nOyzN69bCdZfuAshqjqb3KFPtxmedDAG4UjF+h6YnI1FhH6nPEyANSFmiv/Mcb4w6A 76bR8LgEk2b2T1cbjyDyW3Ndvhpj7J5pCgNgjG4VdEzFckJvx4hMA9w/t+IRq70M32Ha sN0MZIu6GIRAELXDyiGcULu7cT9QSwAJUOOHKxGb4sTUfzUGGgIbMDIV6ruB52PYurxw D3RCSVGOzWEtjzyzgQxtGjQl0QPsVz12GUddPQyvE80XMw4Elz9kRnyswcDMTw8Tvmaj OOOyeRNx3cwwL60/HvMSUG6VC6cqsM0dG0IJ7K/nzx+G3wVYl5xa1MWwFk4QVKMZw7ay lhcA== X-Gm-Message-State: AO0yUKXH6gfT6emhoaEs45byivGDcv+Mau+HinZ0aYVfXsepSfXdvULU 8wyNNvUooHKbyy3PYw26iAVp X-Received: by 2002:a05:6a20:b919:b0:cc:7f86:a804 with SMTP id fe25-20020a056a20b91900b000cc7f86a804mr32705451pzb.6.1678772280120; Mon, 13 Mar 2023 22:38:00 -0700 (PDT) Received: from localhost.localdomain ([117.217.177.49]) by smtp.gmail.com with ESMTPSA id n126-20020a634084000000b005034a46fbf7sm675093pga.28.2023.03.13.22.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 22:37:59 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, Manivannan Sadhasivam Subject: [PATCH v7 05/13] arm64: dts: qcom: sc7280: Fix the base addresses of LLCC banks Date: Tue, 14 Mar 2023 11:07:17 +0530 Message-Id: <20230314053725.13623-6-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> References: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760321376213964273?= X-GMAIL-MSGID: =?utf-8?q?1760321376213964273?= The LLCC block has several banks each with a different base address and holes in between. So it is not a correct approach to cover these banks with a single offset/size. Instead, the individual bank's base address needs to be specified in devicetree with the exact size. While at it, let's also fix the size of the llcc_broadcast_base to cover the whole region. Reported-by: Parikshit Pareek Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index bdcb74925313..afe74db1f5ae 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -3582,8 +3582,9 @@ gem_noc: interconnect@9100000 { system-cache-controller@9200000 { compatible = "qcom,sc7280-llcc"; - reg = <0 0x09200000 0 0xd0000>, <0 0x09600000 0 0x50000>; - reg-names = "llcc_base", "llcc_broadcast_base"; + reg = <0 0x09200000 0 0x58000>, <0 0x09280000 0 0x58000>, + <0 0x09600000 0 0x58000>; + reg-names = "llcc0_base", "llcc1_base", "llcc_broadcast_base"; interrupts = ; }; From patchwork Tue Mar 14 05:37:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 69311 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1585972wrd; Mon, 13 Mar 2023 23:03:25 -0700 (PDT) X-Google-Smtp-Source: AK7set8VSFTPczaFylmppBweI+grnUDRrllotth27jorluJAgjN+JA6/HmPyuz7auxl6Y3ewVNr6 X-Received: by 2002:a62:1c87:0:b0:622:dd9b:e2d8 with SMTP id c129-20020a621c87000000b00622dd9be2d8mr5870467pfc.3.1678773805004; Mon, 13 Mar 2023 23:03:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678773804; cv=none; d=google.com; s=arc-20160816; b=WUWPiLn4L3vfurqttYa4/Z3ySJlj16yhpH8Fuud8bVMaeNrP/EuiD1ryj1Rn+s2uGM StMSv79eGEUU7scUfYZDKqcaIO2tvc+ioAaGnkAqnoZuoxm7qLttV+tgZoHEUVI3PW0h sZYr3lYPC2PqAhzU71+LWxhf0X3qAYZLhtOaaaXKWYm0Oc+nNQA57PLy9E5pjDAgKtcA FRVMDIfq/imd7Cj7TUQg0YcDXdtlUQnMnyIQEegdTId2I4CMv1ddqGB+UtHtHIy70EAS BQbSdsxl5eRf8vi6Oupb+8Vqp1uG/XLYP7Kk+fK18MgxeaGdFpItbyC2zDg9DlWqrjHP vnFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FI19SzWU19Jvwkg3ef2zRaEcka9BD7PAMWjZH4lQqmU=; b=BSZafkTOPvdtTCoUGojXyfEZWL5G164n3n21gm5TzazmrR4hu0FFZuJORmQUP75gL1 Xg46PGUVHvbQdzdbAXwBXHU4uuf4ERQfH1RafHtCism55hBOZExsTQHPXxvKRLt8yIBG 3Mg+vk9u+FIrHInLvNnLb6MDFvaUQEQWM/UQPVxIm6GwEkQtuiJADd6gX4bGVwUnISgo O378PWe4CI/RKPOkfRUUSp/DaLfZRr+iNsxVW+oS3f42z07gXVTtyPnZTbGq1Dt7QM89 P41+kckkyQsJKPeghNHUF0vkewbUNOKf1p3/wqTlZueILJ5oaZ7lSBM0hdMGedoegqMV hXhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VehbRZ9H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d75-20020a621d4e000000b005f84d1beff9si1391500pfd.253.2023.03.13.23.03.11; Mon, 13 Mar 2023 23:03:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VehbRZ9H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230146AbjCNFi2 (ORCPT + 99 others); Tue, 14 Mar 2023 01:38:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230152AbjCNFiV (ORCPT ); Tue, 14 Mar 2023 01:38:21 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC10180E20 for ; Mon, 13 Mar 2023 22:38:05 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id i5so15436122pla.2 for ; Mon, 13 Mar 2023 22:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678772285; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FI19SzWU19Jvwkg3ef2zRaEcka9BD7PAMWjZH4lQqmU=; b=VehbRZ9HI2q25B4xg7E8Jfa/ygNAp+s0KAwxKx+kKk4J4Vl3IQB7eaQMNY10EVQ7sf N+PnFR8ojSrT36Tji5CIyMz7uzVRX81HaLIewO8I/jL5XdAUTtScqS/MbScm1f2eFCIY Al0ZYjLlnURB8MR+kWkchaULqd3u4Z3SV3kyfxHR5ptJI/LuJ/BPij+UAlt+y6thDUNz imqZcK3EEnImSqiY2HXUHTSAHm5SVeGTvMLW/OGdOBaHikByZVPH0hKWWBwoi8O8L4bh U2KDwF/CQkphEGgN0cqVb4eDmwdOkDn1pT+P8tAain2jdbCtuC+VKWcMabZr68dbr+yI PfFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678772285; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FI19SzWU19Jvwkg3ef2zRaEcka9BD7PAMWjZH4lQqmU=; b=lBdmiFb2wOMR1xE12hUNjuuxk/p6/xe1Bhb+/S+biQje43YMQ/qAI71V2MAczVyMan E5mE4i03p/NzESMlKJiUjzODDWFLVWNxmR9uYO5ghQOhveirzR3J1mYGTpZKu+9wJeJH j+fV4t0GCuCXM5O9Xyncsai5uHPQ+QTrtLNVPXWPH6I75yxUnIzVmwgrdKbDFAFpztQr 1P7QyrWpCTzHKs2nm/2ndeFbeLrEElgN1RYqTmeRbFj3YIGbbKSgYGkeiylq+UNcJhq0 lKv0QfJIuPLFIBjgXWjdJH35/rkJbpXNW+dlLGsooPgOj5/9BT/lbtfGRlskD6bhWlzZ cizg== X-Gm-Message-State: AO0yUKWc32yI5LVJAIOy2zFcoeqUgWnkU+Ux7Eetyvqt9MIRKFyN9Zuy 2l7zZoGFgTZk5sFdc5EycJsZ X-Received: by 2002:a17:90b:4a04:b0:233:d10f:5236 with SMTP id kk4-20020a17090b4a0400b00233d10f5236mr38003944pjb.28.1678772285127; Mon, 13 Mar 2023 22:38:05 -0700 (PDT) Received: from localhost.localdomain ([117.217.177.49]) by smtp.gmail.com with ESMTPSA id n126-20020a634084000000b005034a46fbf7sm675093pga.28.2023.03.13.22.38.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 22:38:04 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, Manivannan Sadhasivam Subject: [PATCH v7 06/13] arm64: dts: qcom: sc8280xp: Fix the base addresses of LLCC banks Date: Tue, 14 Mar 2023 11:07:18 +0530 Message-Id: <20230314053725.13623-7-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> References: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760321921055273291?= X-GMAIL-MSGID: =?utf-8?q?1760321921055273291?= The LLCC block has several banks each with a different base address and holes in between. So it is not a correct approach to cover these banks with a single offset/size. Instead, the individual bank's base address needs to be specified in devicetree with the exact size. Reported-by: Parikshit Pareek Tested-by: Steev Klimaszewski # Thinkpad X13s Tested-by: Andrew Halaney # sa8540p-ride Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index 0d02599d8867..f5262ac64a36 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -2983,8 +2983,14 @@ opp-6 { system-cache-controller@9200000 { compatible = "qcom,sc8280xp-llcc"; - reg = <0 0x09200000 0 0x58000>, <0 0x09600000 0 0x58000>; - reg-names = "llcc_base", "llcc_broadcast_base"; + reg = <0 0x09200000 0 0x58000>, <0 0x09280000 0 0x58000>, + <0 0x09300000 0 0x58000>, <0 0x09380000 0 0x58000>, + <0 0x09400000 0 0x58000>, <0 0x09480000 0 0x58000>, + <0 0x09500000 0 0x58000>, <0 0x09580000 0 0x58000>, + <0 0x09600000 0 0x58000>; + reg-names = "llcc0_base", "llcc1_base", "llcc2_base", + "llcc3_base", "llcc4_base", "llcc5_base", + "llcc6_base", "llcc7_base", "llcc_broadcast_base"; interrupts = ; }; From patchwork Tue Mar 14 05:37:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 69303 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1580404wrd; Mon, 13 Mar 2023 22:43:41 -0700 (PDT) X-Google-Smtp-Source: AK7set++D8Sth3ziV+UiJa0IWGLIyhi/+dw/PZorC7krPoQgkeCqb4LMCEh2fdbyCL0cO2CGquEP X-Received: by 2002:a9d:4913:0:b0:697:a381:a8f8 with SMTP id e19-20020a9d4913000000b00697a381a8f8mr281285otf.3.1678772620722; Mon, 13 Mar 2023 22:43:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678772620; cv=none; d=google.com; s=arc-20160816; b=sSB+FV2Ijz1vjvE4dtQeDhzV6k/SEFBk3l4Z+zMJx1g7M2gJ4caIlgRML5MTA56Gzi krq6Jw7xCm3YVp5jf6UOb03M7tMKTGPPnBbHQkONJtnXqHNyIHb5mqrsg1ZW/E43MI7t tOm/7W3NZJIX/XQ/C2GxTEFNEa9wyk8vvFY7NFfiYuKwIU3SschQlFqDFAXNLKoGBaIt Vwmd0q7c4xypqZTGVBZQn8RdT2mSp4LCz2lC+cuFXjxsqxJrkIVJlXNcQQ9S10o68Obj VWLusC/uj4RNp/NoKZ209LP6TYaTl0qioxnO+PBNy1IFc/7xIal7Egbxu3yDMOBc5OK0 2d0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cI9fzySm6xkOQqRMGGXIyCN4K6R+WsFVLi5pzorIgXU=; b=U2Zr7Mek6gpNemKVvYozP7l7QA32ndxNAjN0ef3rnkJMNM+2f8RRJz502tMWzDYRtV haXPN+LptVXfFwN4XZgS6odSPhv1/p6qhWnquPo5hdkLt/eCXI9jfUa3Pi+ZaU7XZ1nx +PECwWfSf5kH1QUmcwB6hI1mfsCHpISATXAk3G/O46nGWqZbtETMopdmduEk1rPNpz3Y TH9/f33ESVkBLUK/diBnTKVo9JsPdgK7YsJv4B9Xu8Ww+Yrm67QablU95kq3RLbzGgQL e+QgR+xjt5+Lq/9bT+k4GeLTDsatSaU52hbB2BmL1HgG1i42PaEx8Jou9eSh5CmKNXdf Bj2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d5ZQV2yd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a13-20020a05683012cd00b00684c064b008si1555309otq.3.2023.03.13.22.43.27; Mon, 13 Mar 2023 22:43:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d5ZQV2yd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230176AbjCNFie (ORCPT + 99 others); Tue, 14 Mar 2023 01:38:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230125AbjCNFi2 (ORCPT ); Tue, 14 Mar 2023 01:38:28 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89EE695E23 for ; Mon, 13 Mar 2023 22:38:10 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id x11so15395110pln.12 for ; Mon, 13 Mar 2023 22:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678772290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cI9fzySm6xkOQqRMGGXIyCN4K6R+WsFVLi5pzorIgXU=; b=d5ZQV2ydVI01geYXvAQj5/TBBA2ySilK/UW1mFJZI52HJwmb5qN7pKHiQNdc7IPu5j RG9DJpQlvLpxHzOU4kTTbWEEhpUqQuooannpDsO/wLrC550dFviQSQxM4g/5Jd9f4gr2 VWjsndOhKVT2ZaCBsG2seVjWUOkqD3K7Lhh5BMeHU/Mn8wqGJ3qbSphVuoaMxRteWAbg eQYr51+IxLDVnUh5xqK8MMp37SkDMy5UCXMLhKtao1OOi9R1YedrBCwz1ahP1znhCFsk DWliHgFf6GSHAHfQdH5Xg/HUNImvg9DE+uEL5YXLuRp37ndPYwPseU45gcUYUC9Cp4cV +oVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678772290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cI9fzySm6xkOQqRMGGXIyCN4K6R+WsFVLi5pzorIgXU=; b=cSfBOyOctu8KEadya7mdg8qQquzesyNOQklxgZedgv/H6iIb7Cefmb/EisDAV5rIhM BMHNe8UhhgqnJ3OoZJKWWOmaBtYG7GMCp6cOddINr6cvfGLk/jQZpN9LU/vAW19zTG/A OmX1kNHX664e2W6lYuEJobzV224d9e2BSgm1JLuBiavuqJLZX6c+GrkF7dKFV6artvqo 09Tj+H8YtAUV1NTSRkxOGhimizDsDopvAZJZC42nS4K8gwqfd4+F8NWvHjjym2J9AhRA osOOm/ibAlGoDzNMgcj2xVOPWNncani9XO3Ms8gSQ5yGvTHavkErB98Q6kjWWsuiUeY+ Y5gw== X-Gm-Message-State: AO0yUKXDsMv7+L9rQYdGCe/ewyM3TXlVQo9mBHa9G4W6b0+tDO2EeKT1 8rkrUR8792osopZ8GTDD2Rai X-Received: by 2002:a17:902:d50a:b0:1a0:5652:6168 with SMTP id b10-20020a170902d50a00b001a056526168mr4292773plg.58.1678772289881; Mon, 13 Mar 2023 22:38:09 -0700 (PDT) Received: from localhost.localdomain ([117.217.177.49]) by smtp.gmail.com with ESMTPSA id n126-20020a634084000000b005034a46fbf7sm675093pga.28.2023.03.13.22.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 22:38:09 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, Manivannan Sadhasivam Subject: [PATCH v7 07/13] arm64: dts: qcom: sm8150: Fix the base addresses of LLCC banks Date: Tue, 14 Mar 2023 11:07:19 +0530 Message-Id: <20230314053725.13623-8-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> References: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760320679277840064?= X-GMAIL-MSGID: =?utf-8?q?1760320679277840064?= The LLCC block has several banks each with a different base address and holes in between. So it is not a correct approach to cover these banks with a single offset/size. Instead, the individual bank's base address needs to be specified in devicetree with the exact size. Reported-by: Parikshit Pareek Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index fd20096cfc6e..e316a4e4b5aa 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -1772,8 +1772,11 @@ mmss_noc: interconnect@1740000 { system-cache-controller@9200000 { compatible = "qcom,sm8150-llcc"; - reg = <0 0x09200000 0 0x200000>, <0 0x09600000 0 0x50000>; - reg-names = "llcc_base", "llcc_broadcast_base"; + reg = <0 0x09200000 0 0x50000>, <0 0x09280000 0 0x50000>, + <0 0x09300000 0 0x50000>, <0 0x09380000 0 0x50000>, + <0 0x09600000 0 0x50000>; + reg-names = "llcc0_base", "llcc1_base", "llcc2_base", + "llcc3_base", "llcc_broadcast_base"; interrupts = ; }; From patchwork Tue Mar 14 05:37:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 69301 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1580013wrd; Mon, 13 Mar 2023 22:42:41 -0700 (PDT) X-Google-Smtp-Source: AK7set9LiTnnB5X/h6qahZXQj3kPETfJ82GnOXHrWu62gnZ7Y9cz3vV7K7pJe7EpuwGkmUzIlB9a X-Received: by 2002:a17:90b:46d1:b0:23b:7188:4b88 with SMTP id jx17-20020a17090b46d100b0023b71884b88mr6458989pjb.46.1678772561544; Mon, 13 Mar 2023 22:42:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678772561; cv=none; d=google.com; s=arc-20160816; b=mRn/3k0Gcxq6gQuJfCK9KrSZtk3Jmv7vwl9SkhHbyJfeenLrxLyWv4QyCF+zNTSY1j 8HSaIT1mhui2bB8Qjo1uYDDytZyihPUauObhdrGs81oxJwxt5jjfU8jSXA9lwPUJQy8L 3F7PmoalVA/G1q7sIQH3nKWvrLUGFVjF93QG01X/qrmcOZ3eJ1oi+/dslTYQa7b19+/e z69+Dk2fDTfGgt6mFTGi3QeJEFtVr2EAApD1DUePc4NYeU3uSs6ZQOkmz/N6FZHFfz/v NY1LVRHnIsh14nS+P6SX5P31OSP6QGPwCJ0CIKHT/OrS5vWPS4uH+DWNARHHYyRii4cc fYCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KbEuZ8x9epY4wczXQcJX335FU4iMuAmx2Igvv4w4MY4=; b=nnfazSsErfgCZDMfPHBLaERmk1JemAFogBofrP70RXJ0txsI7TWxn92LHwmV/BhslV MRzX9Ff2o/FJieOeXAuzjtk6DQdFe5nFHW0jlVL7CKZq+30gymleeSTAFHQLCZRhEXnU i97CI5VQXT9UHswAwr9gSO5qCb5lVtup/gcE54WVoRBv6T0uImMMP6t6MOIIRngAr+8C 60MW0kxydiqxgEW9DmS2nFJIjUbKtcExtpW2+djuykyZVdys92+jRX5rlnQGzX4XV2Y5 seGZCZOOat37ACHMlkoChVf4lokdcr+eDR8RO7HCrKhP5Zt4fXnobbx9s6bba+YI3ppf 27iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yA43PiAK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e15-20020a17090a9a8f00b0023d282930e7si1699960pjp.76.2023.03.13.22.42.29; Mon, 13 Mar 2023 22:42:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yA43PiAK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230139AbjCNFil (ORCPT + 99 others); Tue, 14 Mar 2023 01:38:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230194AbjCNFih (ORCPT ); Tue, 14 Mar 2023 01:38:37 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9BDC95E2D for ; Mon, 13 Mar 2023 22:38:15 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id u5so15414868plq.7 for ; Mon, 13 Mar 2023 22:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678772295; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KbEuZ8x9epY4wczXQcJX335FU4iMuAmx2Igvv4w4MY4=; b=yA43PiAKeBNB8a9B6Y9lwaxQHQDbCrpQuXRvkAKWd3GnsAjpNQLvvd86Sw3jpAlIhi YUAWNcQJYsrpiLBRZWuxQyGFY3pSGoOvbzw30iINyA2iZrPnYCfJOvYXewyxt6a+A208 hnNdiJcdBR27i3K9Ght+Hhyklf08p/yrCdUGTkf3QtH5VKEA52Hme4euS81EWeXotQWH sEkIRZZgcLbbj0rMN66m9CGeUAAd2Yf1pehASAvozn328yR9qNbUYZ9GS6djpHNuO/Mf xdzzzp2nn5hss7+A65tSlr0czbPvOKcY6r72hg9RxqDYEqe19zXQV+uKZWUfUVrPYCS8 2jsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678772295; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KbEuZ8x9epY4wczXQcJX335FU4iMuAmx2Igvv4w4MY4=; b=vl+wDUlN3HLI8PlsFYmmdt7CbqygBQjSUeOMimTATVypwZIiU0JFlcXHQLr1j7iP3p y+986qqckJrBsd7d+CujXulWr9qHyeZxx2LtZqkLWdjs+SApCvwKv0GwqWyl0dWTZQbz Wf/MvfpE0IB/nBdc/uRu+Y9A8LNfP5aXBHa8UOAUxVMlfHdo8Agm7ZLdBlirUZFMJ5Q0 KQYN9nYewt7xEdZ8ufjZPRR+UDZzIvc82jKXsfyonC3zo7vQuvk4gSy/KwyGTJdL/jJ/ JwqC43obVq/daWeaXGe+MiLO7ekXwLowoOy39o18EJP5IQaUnSuc2oqXPgdn6cIN/nD9 xEXA== X-Gm-Message-State: AO0yUKUghsV4ngoM7ufizV0WBJ9rGrkzeJUJ/5a//y6djWMseiV28FZO gX1xzJK5JA3NClFOIPf3xBKj X-Received: by 2002:a05:6a21:6da6:b0:cb:e8c6:26a0 with SMTP id wl38-20020a056a216da600b000cbe8c626a0mr48838687pzb.11.1678772295257; Mon, 13 Mar 2023 22:38:15 -0700 (PDT) Received: from localhost.localdomain ([117.217.177.49]) by smtp.gmail.com with ESMTPSA id n126-20020a634084000000b005034a46fbf7sm675093pga.28.2023.03.13.22.38.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 22:38:14 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, Manivannan Sadhasivam Subject: [PATCH v7 08/13] arm64: dts: qcom: sm8250: Fix the base addresses of LLCC banks Date: Tue, 14 Mar 2023 11:07:20 +0530 Message-Id: <20230314053725.13623-9-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> References: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760320617860211666?= X-GMAIL-MSGID: =?utf-8?q?1760320617860211666?= The LLCC block has several banks each with a different base address and holes in between. So it is not a correct approach to cover these banks with a single offset/size. Instead, the individual bank's base address needs to be specified in devicetree with the exact size. Reported-by: Parikshit Pareek Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index 2f0e460acccd..a13cf98b1ac3 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -3559,8 +3559,11 @@ usb_1_dwc3: usb@a600000 { system-cache-controller@9200000 { compatible = "qcom,sm8250-llcc"; - reg = <0 0x09200000 0 0x1d0000>, <0 0x09600000 0 0x50000>; - reg-names = "llcc_base", "llcc_broadcast_base"; + reg = <0 0x09200000 0 0x50000>, <0 0x09280000 0 0x50000>, + <0 0x09300000 0 0x50000>, <0 0x09380000 0 0x50000>, + <0 0x09600000 0 0x50000>; + reg-names = "llcc0_base", "llcc1_base", "llcc2_base", + "llcc3_base", "llcc_broadcast_base"; }; usb_2: usb@a8f8800 { From patchwork Tue Mar 14 05:37:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 69314 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1591099wrd; Mon, 13 Mar 2023 23:17:21 -0700 (PDT) X-Google-Smtp-Source: AK7set8t0eGnyFpiHqAfrb7Ct/rsMlT+7nAlp9GSXvEszwZDr8FpBlAe7YEft1CE2FSK6k/LHy5g X-Received: by 2002:a05:6870:1197:b0:17a:a3f9:9f6e with SMTP id 23-20020a056870119700b0017aa3f99f6emr744490oau.59.1678774640937; Mon, 13 Mar 2023 23:17:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678774640; cv=none; d=google.com; s=arc-20160816; b=Bt2d1jmJH4Zfwa3hBBt3ZUBQAFvHiwJx4DKkpm4Ji4V2vbHHdmeJSo3681aiPIA75V 8uT3mvYUuTNTfzTSrExAFrSIjc6aEWze0qd51XjhmIhIgCMU0WOCA43JO7ybPRHqQfHu 3INuBhQQltKoH+YEqA8ICda/jx02jxubXnqacKVUcUfH8lSPSg2P73Oa+3GSbpF7sK2X Qzww6FdQ9/g/mgrLW0gjFn1usge/WefgPKW/xdyL9QkP48WZDkasTfrOJetoVziu4lpP Mxe4UKWe783MNzm8Yq33OMvI8k/fxJ82OXsTeylFcxXSri/GrZOiLa7dUZpsHq9MkOg3 dnCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WM/W3mGHWee04PiGhWaePDSEFLq+5Xz9JBoWs5RSs+4=; b=E8uncgcXQNEUls1lPnHxMOGGlrBB/bpAV2xpyQ9Ukocv6hEP7AyOjEl4/AoOG/6N83 JulKLNGya5OZGqcvf+GgNYTm+N6QOqYZK/rVXlt6dGOKIW0M58sGD3l4cdLNH2obbX1F 8OcHiqGiySrpIinDdOxtyKtsQt94fSVT7WKHcASv9IVppF8chNAQVNQejPnDeGnRM6Gw 1itPO7w0vKzo0c9rQ+UDGS1eJGzco8a3cZgxs7XTkTfiJsyje3nUcqcG3RZoketDI32w ewF/ixS2+816Lj0XLbuHOg5zbpjYhUAteYgFxt4a4zXzldhPtNw7tjD1NKC4K8uNKbis bqiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JzMSob1P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k23-20020a056870959700b00172a86692b0si1746634oao.99.2023.03.13.23.17.08; Mon, 13 Mar 2023 23:17:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JzMSob1P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230080AbjCNFix (ORCPT + 99 others); Tue, 14 Mar 2023 01:38:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230188AbjCNFir (ORCPT ); Tue, 14 Mar 2023 01:38:47 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 599C918B1A for ; Mon, 13 Mar 2023 22:38:22 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id h11-20020a17090a2ecb00b00237c740335cso14002235pjs.3 for ; Mon, 13 Mar 2023 22:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678772300; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WM/W3mGHWee04PiGhWaePDSEFLq+5Xz9JBoWs5RSs+4=; b=JzMSob1P4e3VwB0wL6lNs4Pa+MXu0mZYABvUByRuQD9G3tRF3fed1F70Df/U+C5rnt /vjrHfiOXf0cnrJUD+3UiCGbQdM3S2nSrUVZ70QaRO5cUW/xSpS6M9VGjlrB5Hx5txG6 GjZI+B78ehVktIWhsjYQfYVYNVl8jOp01zhoy5wi+7EkchQkvQ18ZabH5aF2H83kTezH ixGX4dRqpYzid8VAn395TqP3IpDv5GdfePsNFytWEnddGeUB5TVWwyEQIBXrDFNQY6G4 gCzNU2WgUtbhG1pYKg5B7CPJLStTgaDmGHqeSDO9LYsBut6u1qzK9eqbUifxkUNY+1oi bZ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678772300; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WM/W3mGHWee04PiGhWaePDSEFLq+5Xz9JBoWs5RSs+4=; b=m2YLeHLtoXFEUMqNVcKB96NzoAevnmeQi5vWwxW8tK3ASxhEaG6y4XuONSAkz0NMd2 sO4YWoPg4Kyz+EaqHC46vG8BfeX9laHyouYS7M4fqgWUgOMPrTG91aVbmf5X85eRejY9 MbKboHYitPIpmJvCnP/vJbu07zex7IEONf90hXm8v+7gHewAAo7+QaZiMyn18nOGI4e6 lMeYBSAY9kiEgt0/QMOU+lBAR3gr/sUViVz5rc5IVlXcBcOWSj0FRIgCTYWBu+YRyWZC +8YGv5UYXApdsVqU+puWbnxVP/i7z42loICDDf2ZO7aE9FNCcGwhDF/NR2MC92aF6SIP 4w9g== X-Gm-Message-State: AO0yUKX+j8l4NP3UVUkAV3MTjY4/pF+D0i02WYcWKsfbTHEFTEHFoIs9 HVoEPpuKXlNIEduyurCvopg9WoSuyrRktdnkBA== X-Received: by 2002:a17:90b:1b52:b0:22b:b82a:f3a2 with SMTP id nv18-20020a17090b1b5200b0022bb82af3a2mr37908027pjb.11.1678772300272; Mon, 13 Mar 2023 22:38:20 -0700 (PDT) Received: from localhost.localdomain ([117.217.177.49]) by smtp.gmail.com with ESMTPSA id n126-20020a634084000000b005034a46fbf7sm675093pga.28.2023.03.13.22.38.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 22:38:19 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, Manivannan Sadhasivam Subject: [PATCH v7 09/13] arm64: dts: qcom: sm8350: Fix the base addresses of LLCC banks Date: Tue, 14 Mar 2023 11:07:21 +0530 Message-Id: <20230314053725.13623-10-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> References: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760322798056443496?= X-GMAIL-MSGID: =?utf-8?q?1760322798056443496?= The LLCC block has several banks each with a different base address and holes in between. So it is not a correct approach to cover these banks with a single offset/size. Instead, the individual bank's base address needs to be specified in devicetree with the exact size. Reported-by: Parikshit Pareek Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi index 1c97e28da6ad..3fefd8cbba6d 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -2204,8 +2204,11 @@ gem_noc: interconnect@9100000 { system-cache-controller@9200000 { compatible = "qcom,sm8350-llcc"; - reg = <0 0x09200000 0 0x1d0000>, <0 0x09600000 0 0x50000>; - reg-names = "llcc_base", "llcc_broadcast_base"; + reg = <0 0x09200000 0 0x58000>, <0 0x09280000 0 0x58000>, + <0 0x09300000 0 0x58000>, <0 0x09380000 0 0x58000>, + <0 0x09600000 0 0x58000>; + reg-names = "llcc0_base", "llcc1_base", "llcc2_base", + "llcc3_base", "llcc_broadcast_base"; }; compute_noc: interconnect@a0c0000 { From patchwork Tue Mar 14 05:37:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 69312 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1586289wrd; Mon, 13 Mar 2023 23:04:05 -0700 (PDT) X-Google-Smtp-Source: AK7set+YAIpPIhP3d6jTwTePqfHCaj0PMuVdD+8G4Xay7V5YJ6zu1qs3eQSM/f8EyXG6gnXFxAh+ X-Received: by 2002:a17:90b:4a04:b0:233:d10f:5236 with SMTP id kk4-20020a17090b4a0400b00233d10f5236mr38071603pjb.28.1678773845321; Mon, 13 Mar 2023 23:04:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678773845; cv=none; d=google.com; s=arc-20160816; b=k+86f5yDlcdPA4t7OYpXs5nPFior7CL44yhqVdkdxudeSiALe9nZDpYR7Y9hO38ZtT FZmlWCFYjhw816oJXYercZQoCo96Ik4NXbypw7gNWM5MAazq+0UnxesrFY9t8yNnQEx9 8eF1ucPceUAF2P1HzfjbOO57vHv0bjfbFJCOo74+RiS7CAT5Y2Ym0qxYPkiFkn7KyGwC sMhvQtTru8tVEl2NK9PGyfXAdcfCA6qT8ZDohzEEiItPCGcRY/n4r4koKNuCmFJBy58g ClXbC05kwBrAJPCUzN9iA+Q2qZOg1R1K46NRSsHkrmyIrKc+bnODltYPCUI5BVI0KhV5 qFJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yqwK6TcGjAz04KGXLoszY4ospGxs4tGDAzQeGyANDbE=; b=V97L2BOL/fopUCoJ9YEp7AFKXDYEWEXSagKGQeV1cCsaFHicttV7bOyTLizGfD0teM G8IG6VvGA1KlCXQgGg/nAtcAxylfsGEoEqbXlezVTGT3ytI3CdXF4OQfXUvMnJSfH4hX nBoBZnWooCoDq1m3eftlW4iaetXD7ippD7wMHJJ2aMxHUEwuP+WCdNbWU5E2lbRvlKd4 DxTot4lTO6LIxFQFoQxE6xb+kDhqs9p9Vu9iODpZos1zMmHf737zXxm+kW75iTuNPASq QmJLLBHBCrjbGRv+elgS45fDa8l10rPop8GFPBDoq2pxFhp2snXYFClZCW1K0w/9a2ot Vgsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZdG7vKoq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lr15-20020a17090b4b8f00b002369d39671fsi1839401pjb.160.2023.03.13.23.03.53; Mon, 13 Mar 2023 23:04:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZdG7vKoq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230212AbjCNFi5 (ORCPT + 99 others); Tue, 14 Mar 2023 01:38:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbjCNFiu (ORCPT ); Tue, 14 Mar 2023 01:38:50 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8D7859FE for ; Mon, 13 Mar 2023 22:38:25 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id u5so15415141plq.7 for ; Mon, 13 Mar 2023 22:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678772305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yqwK6TcGjAz04KGXLoszY4ospGxs4tGDAzQeGyANDbE=; b=ZdG7vKoqgh7TLFE5DkTjS8lZMZZ4fYvaX+ZAa5JUaX7njeWUBsK0TwE9uu4jPM/k6M MRsIUbyomZdq12tYQPcfd0u4jRRxzSYfKlepDEv5yJ7xQ/NyTbrVTHBk0HJBb2rrgOHQ h4TXpL8f8nRKOYYgE0pQtKzpmNomchpoLCqMXl86YKUnIFjuW91rSAv41SnGZFv5WB8k bSJqBrit69KKWEHJErhWCmmhoXtZna+xDxzj4YNfV/Yv1c+s45YgtDWhX+/g/7icbtFU ZuQP0Xep8MpIva7udnuc84/wWudb4TmMDbKQ5ryQkic16bzvNqFTwn3upia/x+sdW42N VS1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678772305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yqwK6TcGjAz04KGXLoszY4ospGxs4tGDAzQeGyANDbE=; b=r6iGxWHXxl67oGORYDNajGGLPKGUogykUNnWkrcUNYQJcm80wjfoUUU9O5H3N33zrm HzvQcj5F8hLPHSjTTar4fzJh7VxMYxI3+nq5bD8xJxbTBLarSF0Fdf6r1+eXDm6A3u8q befsi3LvhPuVuYhMmle5NTjBCj0ET/q9dS3afNc28POZ2UTAiI5wPdaIn/isB11KCWD/ 5R+n0eFX4wuhLMDTh/ksXMCgI1lELdwkchs4YWx9MzkKsH4agGAOcRTXFZYms+xeBiw4 RmNgdeNiYRlDZsBNlUafWD26V76SAcLBwHgBb6NAgLxkrXW3+Gf7vj9T/+W0QGhdUGE+ qabg== X-Gm-Message-State: AO0yUKUiDuz1r4Vy/DVIQVI8qmKIsG/bgeNtizvfU4+NNxhrAwVCDu5k rKSy6Niex3isUx8HsH1VsNhI X-Received: by 2002:a17:902:ecc1:b0:19d:ee88:b4d7 with SMTP id a1-20020a170902ecc100b0019dee88b4d7mr45413170plh.25.1678772305294; Mon, 13 Mar 2023 22:38:25 -0700 (PDT) Received: from localhost.localdomain ([117.217.177.49]) by smtp.gmail.com with ESMTPSA id n126-20020a634084000000b005034a46fbf7sm675093pga.28.2023.03.13.22.38.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 22:38:24 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, Manivannan Sadhasivam Subject: [PATCH v7 10/13] arm64: dts: qcom: sm8450: Fix the base addresses of LLCC banks Date: Tue, 14 Mar 2023 11:07:22 +0530 Message-Id: <20230314053725.13623-11-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> References: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760321963721696056?= X-GMAIL-MSGID: =?utf-8?q?1760321963721696056?= The LLCC block has several banks each with a different base address and holes in between. So it is not a correct approach to cover these banks with a single offset/size. Instead, the individual bank's base address needs to be specified in devicetree with the exact size. Reported-by: Parikshit Pareek Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index 1a744a33bcf4..636dc6823d4c 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -3981,8 +3981,11 @@ gem_noc: interconnect@19100000 { system-cache-controller@19200000 { compatible = "qcom,sm8450-llcc"; - reg = <0 0x19200000 0 0x580000>, <0 0x19a00000 0 0x80000>; - reg-names = "llcc_base", "llcc_broadcast_base"; + reg = <0 0x19200000 0 0x80000>, <0 0x19600000 0 0x80000>, + <0 0x19300000 0 0x80000>, <0 0x19700000 0 0x80000>, + <0 0x19a00000 0 0x80000>; + reg-names = "llcc0_base", "llcc1_base", "llcc2_base", + "llcc3_base", "llcc_broadcast_base"; interrupts = ; }; From patchwork Tue Mar 14 05:37:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 69319 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1591295wrd; Mon, 13 Mar 2023 23:18:02 -0700 (PDT) X-Google-Smtp-Source: AK7set+H4OlI0sx++xfw4b+3yNyv7sLz4Jeny9AkLdYnHqB425HMSEowxRap2QBSZ9fwcV4hkDKD X-Received: by 2002:aa7:9f44:0:b0:622:844e:80a8 with SMTP id h4-20020aa79f44000000b00622844e80a8mr7179520pfr.26.1678774682626; Mon, 13 Mar 2023 23:18:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678774682; cv=none; d=google.com; s=arc-20160816; b=mylv4jrokuSt7hnKFpEUSB55peaUfUYiZda4VLy3JboapDsbs/5idIc4d7+MJ8d7b/ COsZEi1Zrpaa60n85YizflsSy2QZNsoI2VYzJk8SRXtHmqZIzbf5vgyM2ho+y2d5v28S ImpvFhNzYfHjGRkz9poYI6L/9bbtEFCbEEzJWdBdh7sK6fkGRhUa+TvPC4Ql1m72g2tw 5IZztsTxOTwD+df1CZ/hkoTRrTuLvt7+GJgi4NGv7/xJ+2xF0K+TiEheQw0qH+XBNcnG yaJNsOABd5ZcORx8zCw5X5CvSe3QkvjWQQMLRJXuQhPjl/IO+zRFQCxHAYU7YK6kyS1O /+BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sggevdgcbKkipnWP4TBoy7JyP1Clj0YxXKdQjrw2BUc=; b=bbLGeAFamg38ED4hvtZXEOpT7HcXiplg6VV0BWfsBcPQ1lRJC6e4JtFRkfFJG+GyP9 sse0NOJcJQtTY4Ho2qzdM+KyGszA9DNo0G3XFigIeEq+QzefO0a5pU/8wGDXRsk7lV6V VecobBXkWvpqom51OCCTT1lnSHTrfhusQvSxZkEv5LWXM2E4FHoj4Z0/FU/2eNBN0Qx4 2DDZuq5/w3JRBtjc3NEgBPac4M/sKk6rxlVYPWmgjMzgn8VLi4I5UjK9DZkmv14CBs9/ dDWLzJWAoLbOOEfKDyGOXBKWNs4AeItrX0vszd89pSxdG7egwiHm/hpwpHbR7hc/zyIs aAqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yt8ROJAi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q20-20020a631f54000000b00502fd16cd1csi1451757pgm.367.2023.03.13.23.17.47; Mon, 13 Mar 2023 23:18:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yt8ROJAi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229869AbjCNFjH (ORCPT + 99 others); Tue, 14 Mar 2023 01:39:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230211AbjCNFi5 (ORCPT ); Tue, 14 Mar 2023 01:38:57 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CFD795BE0 for ; Mon, 13 Mar 2023 22:38:32 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id cn6so1699339pjb.2 for ; Mon, 13 Mar 2023 22:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678772310; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sggevdgcbKkipnWP4TBoy7JyP1Clj0YxXKdQjrw2BUc=; b=yt8ROJAiLtl01UPND6vY+ee9uaQi/8WI/fmaFZjd+WARpr5QhAwJlxkaCLRVUsV45J a/Im2ar7+D6BWDGaYyDPOQYIuvjqwu/lMDtXS6HYLpkOTK9SlaJorjDwY4AiBfuixPgK n+Rrc7U4EyZhLQD5bK8QzEIXujYC7WctbXNgznPZM0GnLDjV+bJeU9+GZTysKDloY9ot 84UquxeZdLt/QYItlA4PEQBvSstAkEaizAiEXJys9iqwHBkANYNFC5UzdTGNtdiun+kN SvOY+stsGovsfH2kC7y74gY7l6XnlJeRuepqSZ8nvcWiIu8+IRjJtfqTfjErVoFSveiE 8c0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678772310; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sggevdgcbKkipnWP4TBoy7JyP1Clj0YxXKdQjrw2BUc=; b=lSurftw1S4ZSrrAXURuXx4AFvsHgYshlGeS2JZ/+b4eSucoLJFIcldEhqaPV2NgCBO lZMWPzrREWYN/9dHG2d9FV/sFYc7FhyyIkfZTIfRsFFrOLJauEFZhzdKurQ22r1dIDcw SL35gUdy0A70SqAi9KM4gpjVkcSe90GbUa8vuycjp1YiVn6HuprWmvtDJkgV9SYG5qx0 clhyOZ8sd9tyso2mlplIKexz/Uth/SJVt0eS/ZVpJZJmw6K9+fFSKQQy5AaCdT7NbZeJ wvosrLN8OjXRaxp3QkECgA+wUyuQjX2dYeJmQkFleiVoMJ3lCjjMA1E8tk+O07qN5NCB xkig== X-Gm-Message-State: AO0yUKWc6GWZ6dHmto00zrqwlqTUHLINIBjQ08/pJvQC3arTkIzCo785 JZTeQz2xyiorBs37D2XkolPd X-Received: by 2002:a05:6a20:4c2a:b0:d4:b5dc:2909 with SMTP id fm42-20020a056a204c2a00b000d4b5dc2909mr3342007pzb.28.1678772310119; Mon, 13 Mar 2023 22:38:30 -0700 (PDT) Received: from localhost.localdomain ([117.217.177.49]) by smtp.gmail.com with ESMTPSA id n126-20020a634084000000b005034a46fbf7sm675093pga.28.2023.03.13.22.38.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 22:38:29 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, Manivannan Sadhasivam Subject: [PATCH v7 11/13] arm64: dts: qcom: sm6350: Fix the base addresses of LLCC banks Date: Tue, 14 Mar 2023 11:07:23 +0530 Message-Id: <20230314053725.13623-12-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> References: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760322841084673490?= X-GMAIL-MSGID: =?utf-8?q?1760322841084673490?= The LLCC block has several banks each with a different base address and holes in between. So it is not a correct approach to cover these banks with a single offset/size. Instead, the individual bank's base address needs to be specified in devicetree with the exact size. On SM6350, there is only one LLCC bank available. So let's just pass that as "llcc0_base". Reported-by: Parikshit Pareek Tested-by: Luca Weiss Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi index 1e1d366c92c1..63e55579e9c4 100644 --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi @@ -1348,7 +1348,7 @@ dc_noc: interconnect@9160000 { system-cache-controller@9200000 { compatible = "qcom,sm6350-llcc"; reg = <0 0x09200000 0 0x50000>, <0 0x09600000 0 0x50000>; - reg-names = "llcc_base", "llcc_broadcast_base"; + reg-names = "llcc0_base", "llcc_broadcast_base"; }; gem_noc: interconnect@9680000 { From patchwork Tue Mar 14 05:37:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 69308 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1583357wrd; Mon, 13 Mar 2023 22:55:04 -0700 (PDT) X-Google-Smtp-Source: AK7set9iBjokEGqCMVWvbTE/07S/k+4+2dKWT096S8NpozaaMbgrOdKKwLzg6se6Apmo3HHqyky7 X-Received: by 2002:a05:6a20:549e:b0:d4:faa7:be99 with SMTP id i30-20020a056a20549e00b000d4faa7be99mr3015788pzk.16.1678773304479; Mon, 13 Mar 2023 22:55:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678773304; cv=none; d=google.com; s=arc-20160816; b=kCd7ebx6hoUc30NHNQ6UfOZfWQmLYhpGWXdJ5EbP97jIdzRV+XeUCP96EDspFKEkeF Qup7ZpHFZ9gQdqTDgN84QwgM/gR8KSLcBokJ//tr4/6XQ71LgDKQx+l2EwCISixLHwtw mgTLwki2oofn3qP/WgkEbS4iM4zKwyVksQb4NnufQnoZv/maB5+laHCeJQOw9aWNwV5a G16nonX1AttzfHk2j0dlON3t5ZeJnBjV3+/927rTUHFwhYh4r5sOwzT4IIBMUf5BUyCR ysaYW0DJd0zsD1H57HIKPKKowS8k2NPBxnFUJrtG9zrSvqJ+kec0Opl+SeGVEmOri29U 4QEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nUusDRy45tnE3HpdbouewJfbkC176V5vp9gS5W4zqOI=; b=CV1pJ1ALx9+8jtAaTsv1fWddAQpk815ZjLY5C4UV36i0x7J4sPvDagalLEyhxxAz4r 9CplqR8uFsHPL2ud2EbrvP2Q5NsxOD8yKvuPE0GltdaOv/Bt8i8VPD3JigH4VMZ9RjLe i47FmZZ3JfVVO5/NSO6DgyUhVEnGBsx4er8HCY2AGDYEkdhDurAtCPOpK0VSrEtvuRnA NXVV3SvpogN/QP9oKydXo2Ro2jsslziHVAxvaI6TMEdEqYs4KMxVsDbi1GZKMZXzxGeM 2n0sT2x0IRikvLlU26xbNVqUenPb1EUIRnmWa/EVQoLx1NbXu6fJRX7DWFGl5VAli8RC dZJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zhrN1SRO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 9-20020a631949000000b004fb165e159bsi1349662pgz.794.2023.03.13.22.54.50; Mon, 13 Mar 2023 22:55:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zhrN1SRO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230228AbjCNFjJ (ORCPT + 99 others); Tue, 14 Mar 2023 01:39:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230190AbjCNFjA (ORCPT ); Tue, 14 Mar 2023 01:39:00 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C78048F736 for ; Mon, 13 Mar 2023 22:38:35 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id x11so15395827pln.12 for ; Mon, 13 Mar 2023 22:38:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678772315; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nUusDRy45tnE3HpdbouewJfbkC176V5vp9gS5W4zqOI=; b=zhrN1SROlXfEfmMz3cmRtkdT5LoRkXRh9pIauzB1JbeA0hM22fZtSOsxUkuZSvwEyA PWEnbpxRU0HPqyxr9Dnrt8hxyyoDkYRLEI+5ygY+9gY2tqbz6Tx0FvFExjl4gTwjGpjx cZC/8/s2lO9UxWGSMLEaP6+zLCc5M1fSrB28cnVpYdWoydHfkT9nCke/mq9PAonbFY8k dgqxPfMFsJZ4+AItj3oPe1HatJbdFBGj2zlpSNq/sRALULo+SliAfk+ZEoi7ybUNN0JC BZ5qtB/4QfdAsJ0aWN7NEJSN4Eyz+fkHafKWgzga5OUkiFNxb0roY/TGnYjVhhkfELM/ jACg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678772315; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nUusDRy45tnE3HpdbouewJfbkC176V5vp9gS5W4zqOI=; b=Q16EjnQh3hHhpqqu4ZMaEnAKMyVhkFkau7W3kjCXU+gUUPcYEc/I13Srfg2kzTj1+0 AsrJY6Uybj2l9tucNReaFxOI1TjaYT9aeqNzb+21jFCgOVhpLA7f6ABmO/YB6zK+oCdv eDVjKfsDgTaPP5HwdXR7CqI3c6wCS556yQfWnLOfwKdsJ4vbEpTblouNXVDjBi7n8prk Zrt7TAu2XLg2K6H2rS1YImuXmgZkeztZasb55aT/WdFeX06jjb72v4NjePwSlqL1RXvJ /HVvGWvqjHq2X9e/Vfa5jN6RFVArvFFBKJYr/dm9OB0D7UNGNN5yHsvw8VFHWxnsDCTH 59GA== X-Gm-Message-State: AO0yUKU0aM5QQCrGUUQqpq2mIe1G6ce3GU3YomL1rJ+mpq4GZrVlwAUl I0c9fMgQoiXHS/K5SwpKR/4+ X-Received: by 2002:a05:6a21:338d:b0:cc:491e:1a1d with SMTP id yy13-20020a056a21338d00b000cc491e1a1dmr13652750pzb.22.1678772315357; Mon, 13 Mar 2023 22:38:35 -0700 (PDT) Received: from localhost.localdomain ([117.217.177.49]) by smtp.gmail.com with ESMTPSA id n126-20020a634084000000b005034a46fbf7sm675093pga.28.2023.03.13.22.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 22:38:34 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, Manivannan Sadhasivam Subject: [PATCH v7 12/13] qcom: llcc/edac: Fix the base address used for accessing LLCC banks Date: Tue, 14 Mar 2023 11:07:24 +0530 Message-Id: <20230314053725.13623-13-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> References: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760321396573527947?= X-GMAIL-MSGID: =?utf-8?q?1760321396573527947?= The Qualcomm LLCC/EDAC drivers were using a fixed register stride for accessing the (Control and Status Registers) CSRs of each LLCC bank. This stride only works for some SoCs like SDM845 for which driver support was initially added. But the later SoCs use different register stride that vary between the banks with holes in-between. So it is not possible to use a single register stride for accessing the CSRs of each bank. By doing so could result in a crash. For fixing this issue, let's obtain the base address of each LLCC bank from devicetree and get rid of the fixed stride. This also means, there is no need to rely on reg-names property and the base addresses can be obtained using the index. First index is LLCC bank 0 and last index is LLCC broadcast. If the SoC supports more than one bank, then those need to be defined in devicetree for index from 1..N-1. Reported-by: Parikshit Pareek Tested-by: Luca Weiss Tested-by: Steev Klimaszewski # Thinkpad X13s Tested-by: Andrew Halaney # sa8540p-ride Reviewed-by: Borislav Petkov (AMD) Signed-off-by: Manivannan Sadhasivam --- drivers/edac/qcom_edac.c | 14 +++--- drivers/soc/qcom/llcc-qcom.c | 72 +++++++++++++++++------------- include/linux/soc/qcom/llcc-qcom.h | 6 +-- 3 files changed, 48 insertions(+), 44 deletions(-) diff --git a/drivers/edac/qcom_edac.c b/drivers/edac/qcom_edac.c index 3256254c3722..1d3cc1930a74 100644 --- a/drivers/edac/qcom_edac.c +++ b/drivers/edac/qcom_edac.c @@ -213,7 +213,7 @@ dump_syn_reg_values(struct llcc_drv_data *drv, u32 bank, int err_type) for (i = 0; i < reg_data.reg_cnt; i++) { synd_reg = reg_data.synd_reg + (i * 4); - ret = regmap_read(drv->regmap, drv->offsets[bank] + synd_reg, + ret = regmap_read(drv->regmaps[bank], synd_reg, &synd_val); if (ret) goto clear; @@ -222,8 +222,7 @@ dump_syn_reg_values(struct llcc_drv_data *drv, u32 bank, int err_type) reg_data.name, i, synd_val); } - ret = regmap_read(drv->regmap, - drv->offsets[bank] + reg_data.count_status_reg, + ret = regmap_read(drv->regmaps[bank], reg_data.count_status_reg, &err_cnt); if (ret) goto clear; @@ -233,8 +232,7 @@ dump_syn_reg_values(struct llcc_drv_data *drv, u32 bank, int err_type) edac_printk(KERN_CRIT, EDAC_LLCC, "%s: Error count: 0x%4x\n", reg_data.name, err_cnt); - ret = regmap_read(drv->regmap, - drv->offsets[bank] + reg_data.ways_status_reg, + ret = regmap_read(drv->regmaps[bank], reg_data.ways_status_reg, &err_ways); if (ret) goto clear; @@ -296,8 +294,7 @@ llcc_ecc_irq_handler(int irq, void *edev_ctl) /* Iterate over the banks and look for Tag RAM or Data RAM errors */ for (i = 0; i < drv->num_banks; i++) { - ret = regmap_read(drv->regmap, - drv->offsets[i] + DRP_INTERRUPT_STATUS, + ret = regmap_read(drv->regmaps[i], DRP_INTERRUPT_STATUS, &drp_error); if (!ret && (drp_error & SB_ECC_ERROR)) { @@ -312,8 +309,7 @@ llcc_ecc_irq_handler(int irq, void *edev_ctl) if (!ret) irq_rc = IRQ_HANDLED; - ret = regmap_read(drv->regmap, - drv->offsets[i] + TRP_INTERRUPT_0_STATUS, + ret = regmap_read(drv->regmaps[i], TRP_INTERRUPT_0_STATUS, &trp_error); if (!ret && (trp_error & SB_ECC_ERROR)) { diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c index 23ce2f78c4ed..72f3f2a9aaa0 100644 --- a/drivers/soc/qcom/llcc-qcom.c +++ b/drivers/soc/qcom/llcc-qcom.c @@ -62,8 +62,6 @@ #define LLCC_TRP_WRSC_CACHEABLE_EN 0x21f2c #define LLCC_TRP_ALGO_CFG8 0x21f30 -#define BANK_OFFSET_STRIDE 0x80000 - #define LLCC_VERSION_2_0_0_0 0x02000000 #define LLCC_VERSION_2_1_0_0 0x02010000 #define LLCC_VERSION_4_1_0_0 0x04010000 @@ -898,8 +896,8 @@ static int qcom_llcc_remove(struct platform_device *pdev) return 0; } -static struct regmap *qcom_llcc_init_mmio(struct platform_device *pdev, - const char *name) +static struct regmap *qcom_llcc_init_mmio(struct platform_device *pdev, u8 index, + const char *name) { void __iomem *base; struct regmap_config llcc_regmap_config = { @@ -909,7 +907,7 @@ static struct regmap *qcom_llcc_init_mmio(struct platform_device *pdev, .fast_io = true, }; - base = devm_platform_ioremap_resource_byname(pdev, name); + base = devm_platform_ioremap_resource(pdev, index); if (IS_ERR(base)) return ERR_CAST(base); @@ -927,6 +925,7 @@ static int qcom_llcc_probe(struct platform_device *pdev) const struct llcc_slice_config *llcc_cfg; u32 sz; u32 version; + struct regmap *regmap; drv_data = devm_kzalloc(dev, sizeof(*drv_data), GFP_KERNEL); if (!drv_data) { @@ -934,21 +933,51 @@ static int qcom_llcc_probe(struct platform_device *pdev) goto err; } - drv_data->regmap = qcom_llcc_init_mmio(pdev, "llcc_base"); - if (IS_ERR(drv_data->regmap)) { - ret = PTR_ERR(drv_data->regmap); + /* Initialize the first LLCC bank regmap */ + regmap = qcom_llcc_init_mmio(pdev, 0, "llcc0_base"); + if (IS_ERR(regmap)) { + ret = PTR_ERR(regmap); goto err; } - drv_data->bcast_regmap = - qcom_llcc_init_mmio(pdev, "llcc_broadcast_base"); + cfg = of_device_get_match_data(&pdev->dev); + + ret = regmap_read(regmap, cfg->reg_offset[LLCC_COMMON_STATUS0], &num_banks); + if (ret) + goto err; + + num_banks &= LLCC_LB_CNT_MASK; + num_banks >>= LLCC_LB_CNT_SHIFT; + drv_data->num_banks = num_banks; + + drv_data->regmaps = devm_kcalloc(dev, num_banks, sizeof(*drv_data->regmaps), GFP_KERNEL); + if (!drv_data->regmaps) { + ret = -ENOMEM; + goto err; + } + + drv_data->regmaps[0] = regmap; + + /* Initialize rest of LLCC bank regmaps */ + for (i = 1; i < num_banks; i++) { + char *base = kasprintf(GFP_KERNEL, "llcc%d_base", i); + + drv_data->regmaps[i] = qcom_llcc_init_mmio(pdev, i, base); + if (IS_ERR(drv_data->regmaps[i])) { + ret = PTR_ERR(drv_data->regmaps[i]); + kfree(base); + goto err; + } + + kfree(base); + } + + drv_data->bcast_regmap = qcom_llcc_init_mmio(pdev, i, "llcc_broadcast_base"); if (IS_ERR(drv_data->bcast_regmap)) { ret = PTR_ERR(drv_data->bcast_regmap); goto err; } - cfg = of_device_get_match_data(&pdev->dev); - /* Extract version of the IP */ ret = regmap_read(drv_data->bcast_regmap, cfg->reg_offset[LLCC_COMMON_HW_INFO], &version); @@ -957,15 +986,6 @@ static int qcom_llcc_probe(struct platform_device *pdev) drv_data->version = version; - ret = regmap_read(drv_data->regmap, cfg->reg_offset[LLCC_COMMON_STATUS0], - &num_banks); - if (ret) - goto err; - - num_banks &= LLCC_LB_CNT_MASK; - num_banks >>= LLCC_LB_CNT_SHIFT; - drv_data->num_banks = num_banks; - llcc_cfg = cfg->sct_data; sz = cfg->size; @@ -973,16 +993,6 @@ static int qcom_llcc_probe(struct platform_device *pdev) if (llcc_cfg[i].slice_id > drv_data->max_slices) drv_data->max_slices = llcc_cfg[i].slice_id; - drv_data->offsets = devm_kcalloc(dev, num_banks, sizeof(u32), - GFP_KERNEL); - if (!drv_data->offsets) { - ret = -ENOMEM; - goto err; - } - - for (i = 0; i < num_banks; i++) - drv_data->offsets[i] = i * BANK_OFFSET_STRIDE; - drv_data->bitmap = devm_bitmap_zalloc(dev, drv_data->max_slices, GFP_KERNEL); if (!drv_data->bitmap) { diff --git a/include/linux/soc/qcom/llcc-qcom.h b/include/linux/soc/qcom/llcc-qcom.h index ad1fd718169d..423220e66026 100644 --- a/include/linux/soc/qcom/llcc-qcom.h +++ b/include/linux/soc/qcom/llcc-qcom.h @@ -120,7 +120,7 @@ struct llcc_edac_reg_offset { /** * struct llcc_drv_data - Data associated with the llcc driver - * @regmap: regmap associated with the llcc device + * @regmaps: regmaps associated with the llcc device * @bcast_regmap: regmap associated with llcc broadcast offset * @cfg: pointer to the data structure for slice configuration * @edac_reg_offset: Offset of the LLCC EDAC registers @@ -129,12 +129,11 @@ struct llcc_edac_reg_offset { * @max_slices: max slices as read from device tree * @num_banks: Number of llcc banks * @bitmap: Bit map to track the active slice ids - * @offsets: Pointer to the bank offsets array * @ecc_irq: interrupt for llcc cache error detection and reporting * @version: Indicates the LLCC version */ struct llcc_drv_data { - struct regmap *regmap; + struct regmap **regmaps; struct regmap *bcast_regmap; const struct llcc_slice_config *cfg; const struct llcc_edac_reg_offset *edac_reg_offset; @@ -143,7 +142,6 @@ struct llcc_drv_data { u32 max_slices; u32 num_banks; unsigned long *bitmap; - u32 *offsets; int ecc_irq; u32 version; }; From patchwork Tue Mar 14 05:37:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 69316 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1591226wrd; Mon, 13 Mar 2023 23:17:49 -0700 (PDT) X-Google-Smtp-Source: AK7set8qYmKbG4youAVLIYdaUmWAdR7VPGzoUIiCb7xsDHvr4GMahPz3PpC2gG4M5LUZDArMPqgy X-Received: by 2002:a17:902:ab4b:b0:19f:9414:97be with SMTP id ij11-20020a170902ab4b00b0019f941497bemr6360897plb.9.1678774668852; Mon, 13 Mar 2023 23:17:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678774668; cv=none; d=google.com; s=arc-20160816; b=0jxhltUSvD56csI9pilA6ixpOSI/hDyvl71kZygBGPmZH/QLlDhbde+KIs3+XjylrG Qh5ebP+OE3rqjFM7TQUZoTdeIWRE7Na/Mc87cD5+YSZ62ayw80g9SlnPaBiGjloTvtdF vP1erooAG9DjnJKhR0frk3rxccR9lZt6QhcTqr6Q4FS4rO1m5PBmRW5lbqelZ1ts75/5 EGRcHYUqA8KJ1JKWITwhM5PI79MUpb8HDobZA65JUWw/lmt/itzLUwVEAX39h01IVWnu yzYk0PaDfKd4HwBokSQry7VhovrpFAFLnoeGzSNP40dgqz/tfEgVy+8PNzDjXnSi98pE BWVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HbWxcznp0VOg1xe9D7780m5fL2MnhbImn1BuxXG45M8=; b=jqBk6ZnR2HXGylMied98XjiGuNBDs8e2jYEMgFDlhYYFGNlJrxJZhqrc1E2cwJiMUd UypmDJpSwAIyvoJeZ7xvur18CSk7cb/sLD19bppyF+4Xn7S1cGmXoDLyd529hFJeB9uT fusYwsbgR95Cvveg/2Pmp1WLcMb8maRlvac7Z007mbCWglccZ309o6qAkctjhgZCrdZu fXQxvPfuPS+4tpVLYoQ7YCNclDLwqvIbRHhIUEt5DQU7J2XFiicHnO9Fj3cECabyYlJB uOJBwWu1d8GXXy0dNAUJm39faelo45ZFOu8ASAiISTxUdkhlzHLAiDX/7SuM2h4UqfXy HS3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="f/YuqB9V"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id li6-20020a170903294600b001a04bd0a85dsi1545137plb.474.2023.03.13.23.17.34; Mon, 13 Mar 2023 23:17:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="f/YuqB9V"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230187AbjCNFjR (ORCPT + 99 others); Tue, 14 Mar 2023 01:39:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230182AbjCNFjE (ORCPT ); Tue, 14 Mar 2023 01:39:04 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5194A88D81 for ; Mon, 13 Mar 2023 22:38:41 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id nn12so14281787pjb.5 for ; Mon, 13 Mar 2023 22:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678772321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HbWxcznp0VOg1xe9D7780m5fL2MnhbImn1BuxXG45M8=; b=f/YuqB9VIVepKA5532aWKRLA3ZbUAfvr/OSkm/1RU/RhHYbq/uRfIben/ZZd4SMu8g dFcAnVt6j0yuSjD+Z1t97ZJdmvuarnaCAbTdtRVs9yc8ls6RCArnqUeEhwtUu3LddfyL 3Wr/l3R/dXpJNNxsQDkJ/Jc+Pxrv3YWmlayyGYv+5XiFZV+iq7lzR12QVGJxS2dhbUvn cAfOEkXUyq2sn43d/T8ToV/YsfEmIV7JGvCBXFAykCf5CqiL8OnjXyXU6HtOqd8VkHpW jZBn8yxmaVtF4rKQZjU0mxwoubSnJmJwKwXCocr9adTVQeajNCrp+iIgVwaqPSCPRKtv V/Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678772321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HbWxcznp0VOg1xe9D7780m5fL2MnhbImn1BuxXG45M8=; b=Cs0w0shBE61JkAWux7LpQ8Tqfexivhf8HQHxqE/x3otdZdEnDzGzH3IuElsHCTVM/t BAkVzK2ffLXSndSua0Ct3MSPgMfViH+x5cj+XM3ngeacvD0VXsNpqAbRy8w6tpxogA2Y GnArlktP0ozykUR81uzIpbVvA7fKnOZYCXLu8xYPfWezpTr6t/Vz6SJDYs1KVGAsnl4B p8NlOkQdb6ZNrMRXJ7T5LqHF5WyWKEszZ6RoGHWi+Wwi4LaXSt3i6IZB/VCNxkscpkCG I61j4Ynw9V4GfZbZiEXyynV4VM2LZvQUj1zCKQCyqgTwUxDlZLVosFu3W3JRt4GIkV6J w9IQ== X-Gm-Message-State: AO0yUKWbxmQx5zFUr/pD1ltGSB/ZsuA9fnD1Z6ewgBGaobjisNfnLbOK GPaPz/KIhUKg65twS9DwD5dA X-Received: by 2002:a05:6a20:734e:b0:cc:50cd:e0d7 with SMTP id v14-20020a056a20734e00b000cc50cde0d7mr37105440pzc.52.1678772320993; Mon, 13 Mar 2023 22:38:40 -0700 (PDT) Received: from localhost.localdomain ([117.217.177.49]) by smtp.gmail.com with ESMTPSA id n126-20020a634084000000b005034a46fbf7sm675093pga.28.2023.03.13.22.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 22:38:40 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, Manivannan Sadhasivam , stable@vger.kernel.org Subject: [PATCH v7 13/13] soc: qcom: llcc: Do not create EDAC platform device on SDM845 Date: Tue, 14 Mar 2023 11:07:25 +0530 Message-Id: <20230314053725.13623-14-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> References: <20230314053725.13623-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760322827223739752?= X-GMAIL-MSGID: =?utf-8?q?1760322827223739752?= The platforms based on SDM845 SoC locks the access to EDAC registers in the bootloader. So probing the EDAC driver will result in a crash. Hence, disable the creation of EDAC platform device on all SDM845 devices. The issue has been observed on Lenovo Yoga C630 and DB845c. While at it, also sort the members of `struct qcom_llcc_config` to avoid any holes in-between. Cc: # 5.10 Reported-by: Steev Klimaszewski Signed-off-by: Manivannan Sadhasivam --- drivers/soc/qcom/llcc-qcom.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c index 72f3f2a9aaa0..a5140f19f200 100644 --- a/drivers/soc/qcom/llcc-qcom.c +++ b/drivers/soc/qcom/llcc-qcom.c @@ -120,10 +120,11 @@ struct llcc_slice_config { struct qcom_llcc_config { const struct llcc_slice_config *sct_data; - int size; - bool need_llcc_cfg; const u32 *reg_offset; const struct llcc_edac_reg_offset *edac_reg_offset; + int size; + bool need_llcc_cfg; + bool no_edac; }; enum llcc_reg_offset { @@ -452,6 +453,7 @@ static const struct qcom_llcc_config sdm845_cfg = { .need_llcc_cfg = false, .reg_offset = llcc_v1_reg_offset, .edac_reg_offset = &llcc_v1_edac_reg_offset, + .no_edac = true, }; static const struct qcom_llcc_config sm6350_cfg = { @@ -1011,7 +1013,14 @@ static int qcom_llcc_probe(struct platform_device *pdev) goto err; drv_data->ecc_irq = platform_get_irq_optional(pdev, 0); - if (drv_data->ecc_irq >= 0) { + + /* + * On some platforms, the access to EDAC registers will be locked by + * the bootloader. So probing the EDAC driver will result in a crash. + * Hence, disable the creation of EDAC platform device for the + * problematic platforms. + */ + if (!cfg->no_edac) { llcc_edac = platform_device_register_data(&pdev->dev, "qcom_llcc_edac", -1, drv_data, sizeof(*drv_data));