From patchwork Sun Mar 12 15:34:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 68367 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp770374wrd; Sun, 12 Mar 2023 08:48:19 -0700 (PDT) X-Google-Smtp-Source: AK7set+fxj4OfN0qfttNUtNVS1gIfcX1Hg9HJi6Lf0M12y+X9tLydltLKGT7tx91cP/KA7nQUa3U X-Received: by 2002:a17:903:283:b0:19f:2ae8:54b9 with SMTP id j3-20020a170903028300b0019f2ae854b9mr5440940plr.32.1678636099347; Sun, 12 Mar 2023 08:48:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678636099; cv=none; d=google.com; s=arc-20160816; b=NXA0ujSZd+/lRlX3stEdpTNwghy2BKk6J5iLqahrWece9nH8+eFhw56yOXbyO7A4Oh VLJXk3w+bbHdKDIaqVk2gairrpXjBkcShfSewz/yF6ywtELYY910xqT91upqlUPGx2+H JOxuTjJPzcJZT6S8FTZ1XKGQIkA4koJcqOnTC43n6WJKjfqXTEwZdnLmfFH80Q2jr6My qD72l5lk/66q6Ay5q9ibvvOoPMiKGWTCa6msjQEBh5GDwFecNyExaDc8j57rXyP6k3iZ w+yciiH8i5V42U/7VMlrJogvg/4g7UPQ5/i6rEWaaMKR3aJPioWuFJDgKcoGA0Av+pEk q5Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ksvn1qLyFWFuPBY6uKwSYze+p9CmBi8BDb68DqvsMsE=; b=IzLEUzzddLXPWgRmMZi3Y29UkjLglJRbfUx5BrD0RIIDGndmxhMLpt0K7OnKMTn6kQ jbW0k+sOyjK3/vB7HWivwdC2yFZmx8DNIPyZBPsWUtc8NtCsFXs6xTD/WNpGVH+xB8Jz zVdKK1XJtvouZOdicYIYKuaMvKHZJn88PqH4UEPCQugvqwxsvL01I6dBJ59BA/zJnERW A7Rf6fUSOAsIA/3rw34jR7TAGbR5TzqW1qX6G+PkIPpI5bpAOYPFDMyPh2wq6M6zdaED l7bwCg2qQZqu2DqWQ/xlsasEzGOj805BD6F0YUVQtQd5PEYhF1zWHKgu6ohlRPUBaQHZ P3Hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zMvjqsjY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jl17-20020a170903135100b0019ac00d1874si4651089plb.81.2023.03.12.08.48.04; Sun, 12 Mar 2023 08:48:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zMvjqsjY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229743AbjCLPeg (ORCPT + 99 others); Sun, 12 Mar 2023 11:34:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbjCLPee (ORCPT ); Sun, 12 Mar 2023 11:34:34 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A97A16EA9 for ; Sun, 12 Mar 2023 08:34:33 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id ek18so8132324edb.6 for ; Sun, 12 Mar 2023 08:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678635272; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ksvn1qLyFWFuPBY6uKwSYze+p9CmBi8BDb68DqvsMsE=; b=zMvjqsjYAeUA+vFEKA2/S732aWQkr7mHojBdCbfp/P5tAsIjgg263Mt5bn49sSZBb7 rGG/9cDUlNCf2mNlK5HFAS7wmKZJKWNY3mPm0nGZQg+DywTeXevUP/PLnDpf1GNnX/U6 XnxuMLELqmdZkD5saATcNR2nAKYbzQjGYyj/K0jnSfmmfaTqxWKGLX/tiqZ6rQJkfbln 3Uc080pwtvAvkd4P+a6XFK5qn43ieR6RzIhSJQPJbLYchWsUgzYtmwS13oq73r0SnZkI zCYhvu+cuelx4XbGAbNynjlfWd6nK8umC2+1NZzP7hMSj/vYvi94ehBepn2ua80hPJmR w6aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678635272; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ksvn1qLyFWFuPBY6uKwSYze+p9CmBi8BDb68DqvsMsE=; b=NFmpuySeJIHNrKiIIgaUWZl9WfPRln2LEKMkLZQjN0ix7wOu33hqq+ZBdGg0kqn6Rk VjEN10hvzJsPgYeiz1LzX5fH7Ic8X277wF0LKM09iPfe6sl5Zd9S9/8faqvDVvnYBXL1 XDcMLalBtf3i5uUt8gNArlrYFsUZG0EEWPzLNt1+rB+RC45TG0X2GT7ubwErHA2cS95W ypqy8ofaFzzz1f7A5L7AjTUnvXzXBn0RbNNOTKkqlQM9bX7BDrA675gcAZKMCGqxw4y9 WkMeooBcStqCPpKinRj/zaKbiONk2RdTTnaoXMkr0PiOqjqYQ4TxgStHHGznBxUcisME w1bw== X-Gm-Message-State: AO0yUKWWlCVD9tNf8CubgNOrYel3E1wbQtSlN+CDIYKUJ2+KhQmhyLF8 533n0q/CE0/239mzjzMN3CScjg== X-Received: by 2002:a17:907:8746:b0:8b1:7fe9:162e with SMTP id qo6-20020a170907874600b008b17fe9162emr35320405ejc.47.1678635272168; Sun, 12 Mar 2023 08:34:32 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:d9f6:3e61:beeb:295a]) by smtp.gmail.com with ESMTPSA id z2-20020a170906668200b008e0bb004976sm2312723ejo.134.2023.03.12.08.34.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Mar 2023 08:34:31 -0700 (PDT) From: Krzysztof Kozlowski To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Robert Eshleman , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 1/3] iio: dac: ad5755: mark OF related data as maybe unused Date: Sun, 12 Mar 2023 16:34:27 +0100 Message-Id: <20230312153429.371702-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760070742661221446?= X-GMAIL-MSGID: =?utf-8?q?1760177526537491870?= The driver can be compile tested with !CONFIG_OF making certain data unused (of_device_id is not used for device matching): drivers/iio/dac/ad5755.c:865:34: error: ‘ad5755_of_match’ defined but not used [-Werror=unused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. None. Although Jonathan expressed need of changes here, they are a bit too invasive for me thus I am resending it only for completeness. I understand therefore that patch might not be accepted. --- drivers/iio/dac/ad5755.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c index beadfa938d2d..a6dc8a0bfc29 100644 --- a/drivers/iio/dac/ad5755.c +++ b/drivers/iio/dac/ad5755.c @@ -862,7 +862,7 @@ static const struct spi_device_id ad5755_id[] = { }; MODULE_DEVICE_TABLE(spi, ad5755_id); -static const struct of_device_id ad5755_of_match[] = { +static const struct of_device_id ad5755_of_match[] __maybe_unused = { { .compatible = "adi,ad5755" }, { .compatible = "adi,ad5755-1" }, { .compatible = "adi,ad5757" }, From patchwork Sun Mar 12 15:34:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 68372 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp782226wrd; Sun, 12 Mar 2023 09:15:59 -0700 (PDT) X-Google-Smtp-Source: AK7set99FG3RICeQj20e0H6CYU0zVSJcKPa4H8w0QvAaArlfGl7qfQSffy7dasJYXWjdjNNRD5Rp X-Received: by 2002:a17:90a:b704:b0:23b:3699:b8a9 with SMTP id l4-20020a17090ab70400b0023b3699b8a9mr4736082pjr.17.1678637758979; Sun, 12 Mar 2023 09:15:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678637758; cv=none; d=google.com; s=arc-20160816; b=Peo5r03rStMiHBN5PHXu2f3ihq6YM5TTKZANMUg1nXaVOMwKhekEQZmNPhYIoHOAVH 79QKp3fOqSfPbDq1iENDY6t6Yj9SbhUABaIE7L31APzMnPIuccrIfdfnq38gmd58nQcl gziEfskYJ34tuY1NJgjFiiqEnf/gf7fRlQiFUOYisEph3KuBeIO3/F8O6uAHic3KfMdF wVK7wH1W1mFjU1Dud5XoV0iS0DkRO5/cYKldcyMzBs69vb2SjsUcitWBYsCcZdc+0yPC FuIKPjyBUGlvweM7Q62waw7zsSbDBEO0HlUA8fjyjU4diofHK4ioBgjGCd4jcowpdUYI F5FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Jo2NqS2zRnOmFXuAfigU28D6znKyOMxuJ/PtqM8xL/o=; b=MAjKak900dXtN5dtC7pLFVfc29hFlRvwEEvjHShYghZTX1r++ItC2WEUb2bVROC25a /x9UlwZSO31vo9Py6FK73YTgB5Dddsip6P1edsx1T1Ma15ucUN1AKOA5YZDp5wlRAbJ1 zbK5rLj/giF9LXXwzazig2qxjZXOd6gIbkiFBvx+UP+vpR2r8yugZwY/AyCHLInW5II9 bnk7e1+/v5KFEvAehLd8PCVo6OU7qnjzR7npx68J78IqfZQdgUmkLOLbMfcwRv8RSizr dPF1SlEvcI7OU6xwObp6fMupeQJfgy+b8e7O9XvXnR7zNd0VVEQf3GCQtLiW/Tinba+L UrUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mWDprQhs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b7-20020a631b07000000b004fb47ad7ff5si4448589pgb.200.2023.03.12.09.15.44; Sun, 12 Mar 2023 09:15:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mWDprQhs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbjCLPei (ORCPT + 99 others); Sun, 12 Mar 2023 11:34:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbjCLPef (ORCPT ); Sun, 12 Mar 2023 11:34:35 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74E6C41B5F for ; Sun, 12 Mar 2023 08:34:34 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id er25so11128059edb.5 for ; Sun, 12 Mar 2023 08:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678635273; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jo2NqS2zRnOmFXuAfigU28D6znKyOMxuJ/PtqM8xL/o=; b=mWDprQhsa9VdEHPAceKFNkoijx6mTG37ZiUg/JljzXlRXxx4JM8rWKVoJ4HbgFbtjv rxn5Ck7IOVo7IXIZg83E+GmK+SMgTlNWePAPn4ErAYdu9aLt/37x0jhal6wSFRFf35Ef 2EkuVZpEjy7A2YNK5HGbdB3fjrbf5Nme5LjFGG63ie8Qx0aRgCtaqZCoTwB3VPygWR3i rww28efnI0bNJSVuRTObqeQ5p0q1JKGfJM7agGrgndPJrqb8T99UM7louhioa5K3He19 jzbdSq8EvDyK6Td71EAjuVBsHNXzVNNYDfQf4tIjOgfD8GgSgsjtQLM4/Jci6BHGepXI pkWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678635273; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jo2NqS2zRnOmFXuAfigU28D6znKyOMxuJ/PtqM8xL/o=; b=DYXaHU3JpCdokol1hL3H9jX1HVDydjJmi8Wlm8RPM7t9pcZ40e9LW9HafRKqSAkMrp e8+6yFyroeZ3EJMcWjrmdKs8xwUy7qudu3pM40QagQYRGArxOutBnariAlFgD2GLON4D 8arbfh4s7hMMHkuEemYZD5pUKzuMdmgyIMron1cSldC2gQhBroZl3dQKtnc8/7F6ZjHw k7WslfzR4XUAF2rJPJrfI+G7utNF4C9GcPmNOrvMy4xzbcmvDVxIX2ddfuDrONFPJyep J1cYQjm/jBu95N0yxnEto8qM9NmpdNEaqkruc6paKJDY+rzFKezp2rvxap5sK4MfkbOn 49tw== X-Gm-Message-State: AO0yUKV4A2kQIhNkGTkhZgxyQV1U5sD0IMvPW2o9T4XbfiHPFy9eI7dE ci882Q0KmrZLiMz7IcxPO8U2Sw== X-Received: by 2002:a17:906:99d4:b0:8ed:5aac:6973 with SMTP id s20-20020a17090699d400b008ed5aac6973mr31069426ejn.35.1678635273004; Sun, 12 Mar 2023 08:34:33 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:d9f6:3e61:beeb:295a]) by smtp.gmail.com with ESMTPSA id z2-20020a170906668200b008e0bb004976sm2312723ejo.134.2023.03.12.08.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Mar 2023 08:34:32 -0700 (PDT) From: Krzysztof Kozlowski To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Robert Eshleman , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 2/3] iio: light: max44009: add missing OF device matching Date: Sun, 12 Mar 2023 16:34:28 +0100 Message-Id: <20230312153429.371702-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230312153429.371702-1-krzysztof.kozlowski@linaro.org> References: <20230312153429.371702-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760179266434473024?= X-GMAIL-MSGID: =?utf-8?q?1760179266434473024?= The driver currently matches only via i2c_device_id, but also has of_device_id table: drivers/iio/light/max44009.c:545:34: error: ‘max44009_of_match’ defined but not used [-Werror=unused-const-variable=] Fixes: 6aef699a7d7e ("iio: light: add driver for MAX44009") Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Drop __maybe_unused/of_match_ptr --- drivers/iio/light/max44009.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/iio/light/max44009.c b/drivers/iio/light/max44009.c index 3dadace09fe2..176dcad6e8e8 100644 --- a/drivers/iio/light/max44009.c +++ b/drivers/iio/light/max44009.c @@ -527,6 +527,12 @@ static int max44009_probe(struct i2c_client *client) return devm_iio_device_register(&client->dev, indio_dev); } +static const struct of_device_id max44009_of_match[] = { + { .compatible = "maxim,max44009" }, + { } +}; +MODULE_DEVICE_TABLE(of, max44009_of_match); + static const struct i2c_device_id max44009_id[] = { { "max44009", 0 }, { } @@ -536,18 +542,13 @@ MODULE_DEVICE_TABLE(i2c, max44009_id); static struct i2c_driver max44009_driver = { .driver = { .name = MAX44009_DRV_NAME, + .of_match_table = max44009_of_match, }, .probe_new = max44009_probe, .id_table = max44009_id, }; module_i2c_driver(max44009_driver); -static const struct of_device_id max44009_of_match[] = { - { .compatible = "maxim,max44009" }, - { } -}; -MODULE_DEVICE_TABLE(of, max44009_of_match); - MODULE_AUTHOR("Robert Eshleman "); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("MAX44009 ambient light sensor driver"); From patchwork Sun Mar 12 15:34:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 68368 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp770634wrd; Sun, 12 Mar 2023 08:49:14 -0700 (PDT) X-Google-Smtp-Source: AK7set/KP3EeLubWN8HEISwqbmIqPYzQIIIOxy6UEoD9uWDVfZjthKX6pMhzoLi9p2ZeWYIjVxYm X-Received: by 2002:a17:90b:4d11:b0:23a:4875:6e07 with SMTP id mw17-20020a17090b4d1100b0023a48756e07mr31252249pjb.40.1678636154487; Sun, 12 Mar 2023 08:49:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678636154; cv=none; d=google.com; s=arc-20160816; b=loBGAp7WEPH4qTH2vMRoMLiO/lP5J0bsLMx0fU5PQ1tzzTqUgDvzMokjVretoBlfWO +473uDTQfMfigcAvrOdUGOVqnEqiOTuyebV7MjhyatpF7qgp1M2Xx/0wPbTMrbKKnukX MLtdWVRoOvu9sAAur3JX3SJDIDeqZjk0JNgaXZAlg2N/qvM538G3KTTr2mMZKXSJedAA 0SS26vRaoCAjyJXEYFtsEJ1u1/pF5L594GRNyWvC9TM0tdkFWoDD//G4AVbx3m7Q1X+V 19ujqwa6jiyRtsHvo7cnHbw8RfWDrgANBqnk4Rwl0b/Zg1qVyDj9Zx8HY+lJe8hN1uzT K/aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9kvgcMUGd07Xd3eyILFDk+DeCEWHO2H7A73K4YH9RZs=; b=dtB7eHvaTOHLn/FnTKmRFwd2mSs0kcN4RuoPD5iKlEXsfLEI3aNPy1X8vU6TjcUJxb 1BRXfEWAsnz40d2PXJgxgkBakydsUpeZoDfrsZ/cSgIRz7Tzw5mlYnYGIeVFC1ApLoYB Bc2hL8YB6Zapcq6LT+hJvyDcyEExdIjLgGnjhcKi3Tls81iQRvY6wXx/+uPFyMhZomMf KXtiyJtcJbIMfWSSMh5yw3jpceNmnkmy9zgQNXs/WF/GZCA5FqbLF0LVJrmqj2l/N6mG 4yy4saMQ4tfyaX9h8jTE4/EK5UQPK6PlAipa+gHJIXgwpREFc6nJWAB3MPqxeNlqwimH UzKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sckQnzxq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a8-20020a17090a854800b0023b3a60296fsi3442986pjw.71.2023.03.12.08.49.00; Sun, 12 Mar 2023 08:49:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sckQnzxq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229784AbjCLPek (ORCPT + 99 others); Sun, 12 Mar 2023 11:34:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229876AbjCLPeg (ORCPT ); Sun, 12 Mar 2023 11:34:36 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F3374109B for ; Sun, 12 Mar 2023 08:34:35 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id cn21so9071789edb.0 for ; Sun, 12 Mar 2023 08:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678635274; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9kvgcMUGd07Xd3eyILFDk+DeCEWHO2H7A73K4YH9RZs=; b=sckQnzxqcVD2P6n4wKlXn+PAO+hZd6wQwdAXljCJPORmWzShV8Qd5/kZDRX1renVoL fnBpY7NEDz/8oI5+i4ueiTdw1ognJLr9nbZt+uEKQb5x+pW6nuNjLiYE3KT0DgH4x4cU vxeZ6pzIiEtUZE0VpBj75JnCEiEhuDDZSMEQ4HRU9cY126iixAzAyPG5l+Dg3traNquP 0o7gY3znMx2YHGO6VTIxRSPnj6p+wYhXbVMHbiXlM4aNjbW2OJwYd/kqXSNWIOz23BEf JyS9th1vnVGmxr/W6A1YNu+S3EsKc/KjNRxlGGU65YaIo7p1lk4K382W2V6eV1bAvXAf AvuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678635274; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9kvgcMUGd07Xd3eyILFDk+DeCEWHO2H7A73K4YH9RZs=; b=Oq5Euc7tJRB88Qs8v9dB4aOyDhbttayO7CyviWy3ZSfPu53TZ1QtGbqh8L1M6sQS1x 8svyuLqRLy/R4+JEMvtYmb3Xk52WlHmbcfQUKftK37NH9ebhkg1btJayrd7lBThjmHrb tnYHMpR0TNvYOkxqKZaeZYFXUANOcEOjpNnJhoVizl1JR52N24brFTtm0X2EsGH1c+bt Naj7YkUMaSlbYC09BJCt4eLX7GApx+Lq7rQy28T2pbrxtcgNmB5OL78nn0Gfi4HXdbUi yQ/4Sv2fT2eFVWNchpRMIxlwyWX2rxxc7HaZimxT+2xAD4HSMWTNI/nRVKprZn3tbA35 y4nA== X-Gm-Message-State: AO0yUKWLt7+dDrNjdm/HoSJRhWKOwrGlmJQIxj6hRf241D7D02FdVGfo oyvOaghrHmopN34sl3elSMMgRQ== X-Received: by 2002:a17:907:94ce:b0:907:183f:328a with SMTP id dn14-20020a17090794ce00b00907183f328amr39131550ejc.65.1678635273802; Sun, 12 Mar 2023 08:34:33 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:d9f6:3e61:beeb:295a]) by smtp.gmail.com with ESMTPSA id z2-20020a170906668200b008e0bb004976sm2312723ejo.134.2023.03.12.08.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Mar 2023 08:34:33 -0700 (PDT) From: Krzysztof Kozlowski To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Robert Eshleman , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 3/3] iio: proximity: sx9500: Reference ACPI and OF ID data Date: Sun, 12 Mar 2023 16:34:29 +0100 Message-Id: <20230312153429.371702-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230312153429.371702-1-krzysztof.kozlowski@linaro.org> References: <20230312153429.371702-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760177584320816334?= X-GMAIL-MSGID: =?utf-8?q?1760177584320816334?= Always reference acpi_device_id and of_device_id tables, as they is little benefit of conditional compiling and OF table could be used also for ACPI matching via PRP0001. This fixes warning: drivers/iio/proximity/sx9500.c:1039:34: error: ‘sx9500_of_match’ defined but not used [-Werror=unused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Drop of_match_ptr and ACPI_PTR --- drivers/iio/proximity/sx9500.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/proximity/sx9500.c b/drivers/iio/proximity/sx9500.c index 8794e75e5bf9..9b2cfcade6a4 100644 --- a/drivers/iio/proximity/sx9500.c +++ b/drivers/iio/proximity/sx9500.c @@ -1051,8 +1051,8 @@ MODULE_DEVICE_TABLE(i2c, sx9500_id); static struct i2c_driver sx9500_driver = { .driver = { .name = SX9500_DRIVER_NAME, - .acpi_match_table = ACPI_PTR(sx9500_acpi_match), - .of_match_table = of_match_ptr(sx9500_of_match), + .acpi_match_table = sx9500_acpi_match, + .of_match_table = sx9500_of_match, .pm = pm_sleep_ptr(&sx9500_pm_ops), }, .probe_new = sx9500_probe,