From patchwork Sun Mar 12 14:23:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 68353 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp744739wrd; Sun, 12 Mar 2023 07:42:01 -0700 (PDT) X-Google-Smtp-Source: AK7set8eYjHHcj6wMpqvnfFEKNcSxCL8KCFse7kceuUvZNNefsiihnStdGF9c53q9O6lO5NDV3wm X-Received: by 2002:a17:902:cf0e:b0:19e:2495:20e0 with SMTP id i14-20020a170902cf0e00b0019e249520e0mr7221629plg.21.1678632120157; Sun, 12 Mar 2023 07:42:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678632120; cv=none; d=google.com; s=arc-20160816; b=sHXwdUEEzwfnCgWzbstmoAsLoa302j8j5pdEZwAMSkLivX+DiszXl+7zBRuLe2uVsJ 99It92ZWsHkkmSlE4iL7m81ByFmc58O5IGKQp0QC5Y8ZHWgH3vg/Ccducv3s3JGaRsdJ POQVAZXrB5ssXjBdjpWxyYtL9NqAK1kf6QJn28ZAH5GjR7DtN6yMPZmbqPgDYl6Nmz36 sWLHEcfbGMtxI6bDrIWVWjDH351RHbAR5Suns0jvq6j/xx5LEPlscbqAec3y2m/ucwex VyRoKZhVbfgrg6P/Zxgra6CFkmJGJFx4kzAH2EgRFd95LbhdAoe95uzB8wNbLP6h73sS UUVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=4ZscuiQPwnHKfbAbpvcHFmQ/w/W3FQBM8Le/KlBVmX8=; b=PGUH6xfe+TKxREFNXhAafpr/FXEehLJFkEQXsyostwRpvn+2OgOX6n4+AQGX+5GIMn QtXwc/BOxfg1wV5lUghrSVSsPK6jWo1aM4+zVNl8eAsSDQ336k1SxMA2A2x0NJv6jFnL YKWMYLVccv1bHMkgL85hFy1/Z0JmQdr3NgeUFdMUl8rEc6VPDTQBBjFI1rfVIDVnLRwM ZD+x7FPRQksmXOboepggDO0yrIv25WoX3w40fNyCizXppFkBmFoqLC5WPi/I4K8ppmH7 Bk0pH5ePSXuXfbbrponqY9do/gA3NgDcDv1FJFYOx32h9ZDNXinkTC5dIkRbvxkP2H/5 OqzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=YQklslgI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w18-20020a1709029a9200b0019e29ce6975si4413886plp.202.2023.03.12.07.41.48; Sun, 12 Mar 2023 07:42:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=YQklslgI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230035AbjCLOYi (ORCPT + 99 others); Sun, 12 Mar 2023 10:24:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbjCLOYg (ORCPT ); Sun, 12 Mar 2023 10:24:36 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.216]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C031D46170; Sun, 12 Mar 2023 07:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=4Zscu iQPwnHKfbAbpvcHFmQ/w/W3FQBM8Le/KlBVmX8=; b=YQklslgIvM7mi1Co4Qh5c 3etl9t3wkCXV3MV5Sw1sG0m35C4r7TC8TPu9ytBAePYuB2hYV8nda1AcjVzlmhV1 MyXmzggw5wRXI/ZsglyTyx6AGK8l6JSqwnJDmLNUmFfRQRdZZwXbsYcTpAOQ+BH2 eiEZxIfCTe/8Iu0+Egtp3U= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g4-2 (Coremail) with SMTP id _____wC3g3x84A1kSDt1DA--.34606S2; Sun, 12 Mar 2023 22:23:56 +0800 (CST) From: Zheng Wang To: sathya.prakash@broadcom.com Cc: sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH] scsi: message: mptlan: Fix use after free bug in mptlan_remove due to race condition Date: Sun, 12 Mar 2023 22:23:54 +0800 Message-Id: <20230312142354.1857371-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wC3g3x84A1kSDt1DA--.34606S2 X-Coremail-Antispam: 1Uf129KBjvJXoWrurykGF4Dur1fWry5Wr13CFg_yoW8Jry7pr ZFka48CrZ5Jw1Iy3WDtFy8AFyrC3WIgrWkKrWSg342vr1FkFyYq340kFy2kw1xXFs5Ga13 Zr4DJFs7GayDKFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zi-eOJUUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/xtbBzg0wU2I0Xm+hTwABso X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760173353908494117?= X-GMAIL-MSGID: =?utf-8?q?1760173353908494117?= In mptlan_probe, it called mpt_register_lan_device and bound &priv->post_buckets_task with mpt_lan_post_receive_buckets_work. When it calls lan_reply, it will finally call mpt_lan_wake_post_buckets_task to start the work. When we call mptlan_remove to remove the driver, there may be a sequence as follows: Fix it by finishing the work before cleanup in mptlan_remove CPU0 CPU1 |mpt_lan_post_receive_buckets_work mptlan_remove | free_netdev | kfree(dev); | | | dev->mtu | //use Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Zheng Wang --- drivers/message/fusion/mptlan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/message/fusion/mptlan.c b/drivers/message/fusion/mptlan.c index 142eb5d5d9df..de2e7bcf4784 100644 --- a/drivers/message/fusion/mptlan.c +++ b/drivers/message/fusion/mptlan.c @@ -1433,7 +1433,9 @@ mptlan_remove(struct pci_dev *pdev) { MPT_ADAPTER *ioc = pci_get_drvdata(pdev); struct net_device *dev = ioc->netdev; + struct mpt_lan_priv *priv = netdev_priv(dev); + cancel_delayed_work_sync(&priv->post_buckets_task); if(dev != NULL) { unregister_netdev(dev); free_netdev(dev);