From patchwork Sun Mar 12 13:39:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andi Shyti X-Patchwork-Id: 68340 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp723270wrd; Sun, 12 Mar 2023 06:47:10 -0700 (PDT) X-Google-Smtp-Source: AK7set/1h6//4I+ruiIH5JZELuD3bSl6HiRIxoUp5x5KJGE5DznQ+Xc5olgQ5AzsLFJem4jLcFyO X-Received: by 2002:a05:6a20:6922:b0:cd:a334:a52b with SMTP id q34-20020a056a20692200b000cda334a52bmr10509240pzj.30.1678628830558; Sun, 12 Mar 2023 06:47:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678628830; cv=none; d=google.com; s=arc-20160816; b=e87qHa6bSRET89iaysdygr8n/+sLcmgxKiKY01CTsur+GjMaldqlCVIWMKqXKGBRSM icVBUNflZQxvh49RKP2KEBzHV1Sv233z/Zj1LyDs/UFB9oDT6+bBdYEBYX2uEe33hqQV URbhCr5FZsDv6JkJ/eakfYQxzkt32OC/RdRlyyIdchWJO5Ul+2heTQxpPLTlb03n8dJ3 0GVssxzKl4dmXGOsiRQVUa2MFkHf4SfumC1M1bVwuLUBTmm49sfPfddlD8xwQXoVNrZb gubNZ0LVPpLMZJ04VzPgHM8XeNoX4N95ZLenKhjmI4rE0K/AVb9xqYsUXIV+oK36E3K5 fjPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=WIUvFh9bAtT2u2N1qAVpK4wXg4XQKPS0MNHdo4Hqpic=; b=cdWhiMTjYi7wtB9ymunXAUdUd8WixzLeo078SnpoTlaW3tJ716dk67rCpgLA3F5YQh 7NzVgEDy9orutK4xI01+L2wcyGvs22DMhT8oWIDbwnUPaphCYiDN/IAXNgtS814REZMK fNSzQ21tqsquPnCxQsnESLFxGIfpt3il+Eaa1vjhZ5BGBmyxAob9fM2bhPaTSkkhoNiB g0sjlPR9aesvu866iy2fAc2GABYY6KoVVIt67wtrOX/0xCUPuarJEKRcJI/01xalpTPK 6R3Ubzg67m+3/1FylwSGw93Wxuld6f5lZhkmrIFR0vPr1W1SrnvNMh8J6y72mAnSFWE7 5Ykw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=heid8DOU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h185-20020a6383c2000000b00502d8757150si4237332pge.10.2023.03.12.06.46.56; Sun, 12 Mar 2023 06:47:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=heid8DOU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229666AbjCLNkX (ORCPT + 99 others); Sun, 12 Mar 2023 09:40:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230256AbjCLNkV (ORCPT ); Sun, 12 Mar 2023 09:40:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D00E724BCD; Sun, 12 Mar 2023 06:40:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 82088B80B18; Sun, 12 Mar 2023 13:40:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D155DC433D2; Sun, 12 Mar 2023 13:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678628415; bh=ke7T1l0eRGRWmebXcI69qvnIV9XLz1cUDufT5C689es=; h=From:To:Cc:Subject:Date:From; b=heid8DOUEl48pfy/rKb5NLhK226OaqMoL/TmdUEE+uWdBXQVmGNsuwIIoYAkjv26t ZfXiLkUl2mq/+sYGdr+M68ObjtOwGvTNR0nZ7hx0Gta4axC/MrsOKg3C9LHG5+KC1Z IHreXPhgRhI25BoqRRWI73rF9AUJzN+po9YD71BjvVKc+wv9Db2ta6CJ3atQsc65hb uaMlhSTiRmHv3irn2ZoQfSn+2KI/98IHqMk323DMmwTI03rTdJuMA08xbw37Avb4c7 7lQllheSgMpt5fO589jeSKNq/0WgPnzzBRGJjGRK5eRogwOGfzWl7NP97jjbB1Xuyv 9zs1y8pfr2TAQ== From: Andi Shyti To: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mark Brown , Andy Shevchenko , Andi Shyti Subject: [PATCH] spi: mpc5xxx-psc: Fix compile error Date: Sun, 12 Mar 2023 14:39:59 +0100 Message-Id: <20230312133959.256855-1-andi.shyti@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760169904730400602?= X-GMAIL-MSGID: =?utf-8?q?1760169904730400602?= Commit 9e21720a4958 ("spi: mpc5xxx-psc: use devm_clk_get_enabled() for core clock") has made use of the devm_clk_get_enabled(), but it actually forgot to remove a couple of goto's, triggering the following compile error: drivers/spi/spi-mpc512x-psc.c: In function ‘mpc512x_psc_spi_of_probe’: drivers/spi/spi-mpc512x-psc.c:518:17: error: label ‘free_ipg_clock’ used but not defined 518 | goto free_ipg_clock; Replace those goto's with actual returns. Fixes: 9e21720a4958 ("spi: mpc5xxx-psc: use devm_clk_get_enabled() for core clock") Signed-off-by: Andi Shyti Cc: Andy Shevchenko --- drivers/spi/spi-mpc512x-psc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c index 77a228f633d1..0b86f1804682 100644 --- a/drivers/spi/spi-mpc512x-psc.c +++ b/drivers/spi/spi-mpc512x-psc.c @@ -511,13 +511,9 @@ static int mpc512x_psc_spi_of_probe(struct platform_device *pdev) ret = mpc512x_psc_spi_port_config(master, mps); if (ret < 0) - goto free_ipg_clock; - - ret = devm_spi_register_master(dev, master); - if (ret < 0) - goto free_ipg_clock; + return ret; - return ret; + return devm_spi_register_master(dev, master); } static const struct of_device_id mpc512x_psc_spi_of_match[] = {