From patchwork Fri Mar 10 16:45:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 67575 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp981399wrd; Fri, 10 Mar 2023 08:55:21 -0800 (PST) X-Google-Smtp-Source: AK7set9GCkqI+y3c/qyS0k62+J1uR2HO/5ZZljPybhZUIVNBlg8E/7Uqae/+/DHRE4AroWORiWkN X-Received: by 2002:aa7:946e:0:b0:60a:dc94:5d19 with SMTP id t14-20020aa7946e000000b0060adc945d19mr4234435pfq.33.1678467320789; Fri, 10 Mar 2023 08:55:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678467320; cv=none; d=google.com; s=arc-20160816; b=yr/qkI/iZTdjqvd2xL2cyYpf3I3tTurGvHhoQGW+Cf4VFaDMs2YuM5mn7SajEbyod3 ZzNqgxh6jiEkKeQdQLz4Eq5+u7gpI5ku38l+Gs//902U6vfbFEiIz1z8a+jaULyGJrMg TCTxG1N196uuy6uq+ZfEgSOezFN8qWv0IG0FU7ADcpEYnihbskZC1yAUi3hMRaVhxTA7 bl+YPIG202myWN4lQKIqiV983efT5rMsKzk0ueWS5GTvvkGbCpNktRezTwx2g5t4un0x xuOfKeIAlcJ0GCyhZIC/lkYcecw/3t3hmH26ZHajRMG+7IBIWZx6t4TzMELiI15mGQhM Ka3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=CveDlvmFaaUDtVx2hcPEX42K1/bHT4iOIRH2A5vSVtY=; b=ONGqXkecatdql6NPVpl8RKtcVXmt8Qqazirlh/lhbSMw45eBBbOP5n4/B8ib5NihYm AdvvgW9PsHsgIPeASADevNW1gX5GdGCnXDP95Rs8RkPi2qsRzcKp+E5FKbrS71HitFBr kLJfneGgQ9QSbsp7vUOjunFev7oxO8mmODNcpJB9BQhDb6M62jr0t5QdWinaq0JwhHhE EXfMjv1IlEM+EhG/SLZFq9yLtR5x9KgLRmbDyOrh+rS2FwhVFmKOw5RPHxWbVm7TjWas qGsTLT7ogTXj3w6we4PSuxIKpt28RI5IBoXfnMdY2vIyVVz5VdSnk6h19UeSS8wSPU3M PNBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q10-20020a65624a000000b004fbacd1a872si167513pgv.853.2023.03.10.08.55.06; Fri, 10 Mar 2023 08:55:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230432AbjCJQtI (ORCPT + 99 others); Fri, 10 Mar 2023 11:49:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230486AbjCJQrw (ORCPT ); Fri, 10 Mar 2023 11:47:52 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D42265AE for ; Fri, 10 Mar 2023 08:45:40 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pafrz-00089n-44; Fri, 10 Mar 2023 17:45:27 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pafrx-003DTM-G3; Fri, 10 Mar 2023 17:45:25 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pafrw-002F50-NG; Fri, 10 Mar 2023 17:45:24 +0100 From: Oleksij Rempel To: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, Peng Fan , Fabio Estevam , NXP Linux Team , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v1] clk: imx6ul: fix "failed to get parent" error Date: Fri, 10 Mar 2023 17:45:23 +0100 Message-Id: <20230310164523.534571-1-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760000549261029979?= X-GMAIL-MSGID: =?utf-8?q?1760000549261029979?= On some configuration we may get following error: [ 0.000000] imx:clk-gpr-mux: failed to get parent (-EINVAL) This happens if selector is configured to not supported value. To avoid this warnings add dummy parents for not supported values. Fixes: 4e197ee880c2 ("clk: imx6ul: add ethernet refclock mux support") Signed-off-by: Oleksij Rempel Reported-by: Stefan Wahren Tested-by: Stefan Wahren Reviewed-by: Peng Fan --- drivers/clk/imx/clk-imx6ul.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c index 2836adb817b7..e3696a88b5a3 100644 --- a/drivers/clk/imx/clk-imx6ul.c +++ b/drivers/clk/imx/clk-imx6ul.c @@ -95,14 +95,16 @@ static const struct clk_div_table video_div_table[] = { { } }; -static const char * enet1_ref_sels[] = { "enet1_ref_125m", "enet1_ref_pad", }; +static const char * enet1_ref_sels[] = { "enet1_ref_125m", "enet1_ref_pad", "dummy", "dummy"}; static const u32 enet1_ref_sels_table[] = { IMX6UL_GPR1_ENET1_TX_CLK_DIR, - IMX6UL_GPR1_ENET1_CLK_SEL }; + IMX6UL_GPR1_ENET1_CLK_SEL, 0, + IMX6UL_GPR1_ENET1_TX_CLK_DIR | IMX6UL_GPR1_ENET1_CLK_SEL }; static const u32 enet1_ref_sels_table_mask = IMX6UL_GPR1_ENET1_TX_CLK_DIR | IMX6UL_GPR1_ENET1_CLK_SEL; -static const char * enet2_ref_sels[] = { "enet2_ref_125m", "enet2_ref_pad", }; +static const char * enet2_ref_sels[] = { "enet2_ref_125m", "enet2_ref_pad", "dummy", "dummy"}; static const u32 enet2_ref_sels_table[] = { IMX6UL_GPR1_ENET2_TX_CLK_DIR, - IMX6UL_GPR1_ENET2_CLK_SEL }; + IMX6UL_GPR1_ENET2_CLK_SEL, 0, + IMX6UL_GPR1_ENET2_TX_CLK_DIR | IMX6UL_GPR1_ENET2_CLK_SEL }; static const u32 enet2_ref_sels_table_mask = IMX6UL_GPR1_ENET2_TX_CLK_DIR | IMX6UL_GPR1_ENET2_CLK_SEL;