From patchwork Fri Mar 10 14:47:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 67479 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp950403wrd; Fri, 10 Mar 2023 07:58:16 -0800 (PST) X-Google-Smtp-Source: AK7set/xMQjc+A5xfVBx7q0UCCAZb+5Yb9jaKGEu1Ga8hv2ewTNudr5C9C4i8d6xxmWBNFIu5jrp X-Received: by 2002:a17:90b:4f4a:b0:237:1f17:6842 with SMTP id pj10-20020a17090b4f4a00b002371f176842mr27389423pjb.10.1678463896453; Fri, 10 Mar 2023 07:58:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678463896; cv=none; d=google.com; s=arc-20160816; b=RlYfuVA1dygUCWNF3/1TepMq8prcxbEQwWKWmTbVUbXW61isBz3pCHJH5Z1HJUyZnD I2vXbvAr4ABbLpYUWlxZAuLWSCT6wg4arFFYA6jN4Qp4W/T/amQ1at7lZm/tUJ1ECSWE CX8VdkffmHeiy5wXsQV86E0cYiWZAsaynQ4v/lMCX893k9ludGLP6E361LzP9XGcjtLE GVB6/ixzb4NgishW74V2do4Rqhz9TwmDFJOXkraXEKrJj60/ke6HZVXw3ef7Rp3wvh2m f7KyZkHmURNRjSKrIcS9a9ygPaWqSezcjDzLUCdqTpTs052A2ZgZAPz9ETAODSlW+v4a kkfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=f2lTtjWUMnJBmccOD7sA1r/lC9FUen1jFS0i++9lx7Q=; b=n5btiBav3hhdP0DXpYafm+vHUwrUweKTLvjxEMCirryMwadewHbztdg7xFHmulnyAF qgaZ0Z7P/8sZCFxILeo9jwhfwLpxSK0GVEB3EeVn2oH2lYtwpAEKfEFcpR1uSZZYi4tH Zkgqk+kC7Ec+FDxi+etfsoYFn9UUffpvINETlifu7Uur0fwqH2Ag6XtgUi3Y+g6BHWr9 Bjil4lcbpjOLYm2flMK9NwAqxFYUWIh1skK2BVlUvOOLrDMMOfK8/as8Eo2bobY1csH9 jLtPNDHUW/rudvCTUkEOoVLRV8b4WF7kn/CHtQCxvUPi/mlVVOJuy2X2XQNdzefgUJgh NQ/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x16-20020a17090a789000b002340f45c0ffsi135394pjk.90.2023.03.10.07.58.03; Fri, 10 Mar 2023 07:58:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233337AbjCJOty (ORCPT + 99 others); Fri, 10 Mar 2023 09:49:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232910AbjCJOsU (ORCPT ); Fri, 10 Mar 2023 09:48:20 -0500 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5F2A10A12D; Fri, 10 Mar 2023 06:47:33 -0800 (PST) Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-176d1a112bfso6058966fac.5; Fri, 10 Mar 2023 06:47:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678459653; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f2lTtjWUMnJBmccOD7sA1r/lC9FUen1jFS0i++9lx7Q=; b=UkIKxn4M53jXCHs42yJQx2FU1sA+NF1K9WoA9fbF2wYFsXubnlNZzWUoumlDGIOw7R ahhr2zXE+KuCxAoOxN2+GIwbSdcoWwO8Uhldk4hERbAlv+HoxQKgwK9Ca18uTJ2ZOZjJ iNGcCV9+tgQGlNT2vrRZwi0dxKPy0SdyB5iFbystR7eJBU9QAyQYErHCBqL3jQLDUEZb xoXS595knYz2UqkDoaQ5AitqixLE24e02IDJzJ4lbRM0KCRmvfWP5LqD8E9MJd5g5XmS 70a4VvDoOrVLPIhdf/XsS4fMDRN/LiN6UrZ1pRQ6SpDQSe/RFWMYnTSrdthfnafvadjt XJAQ== X-Gm-Message-State: AO0yUKWB8zqkaLUthpaLDO/0vuOvwZnNN0eY4fz5/VkLawlr+AdrQ3fk XtuWkaH3tniPVHIeLkdUCQ== X-Received: by 2002:a05:6870:819d:b0:172:21e9:21c7 with SMTP id k29-20020a056870819d00b0017221e921c7mr16014357oae.40.1678459652873; Fri, 10 Mar 2023 06:47:32 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id z13-20020a056870e14d00b00172721f6cd5sm114767oaa.16.2023.03.10.06.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 06:47:32 -0800 (PST) Received: (nullmailer pid 1542798 invoked by uid 1000); Fri, 10 Mar 2023 14:47:08 -0000 From: Rob Herring To: Dmitry Torokhov , Laxman Dewangan , Thierry Reding , Jonathan Hunter Cc: devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH] Input: Use of_property_read_bool() for boolean properties Date: Fri, 10 Mar 2023 08:47:08 -0600 Message-Id: <20230310144708.1542751-1-robh@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759996958551147323?= X-GMAIL-MSGID: =?utf-8?q?1759996958551147323?= It is preferred to use typed property access functions (i.e. of_property_read_ functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool(). Signed-off-by: Rob Herring --- drivers/input/keyboard/matrix_keypad.c | 6 ++---- drivers/input/keyboard/omap4-keypad.c | 3 +-- drivers/input/keyboard/samsung-keypad.c | 3 +-- drivers/input/keyboard/tegra-kbc.c | 3 +-- 4 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c index 203310727d88..a1b037891af2 100644 --- a/drivers/input/keyboard/matrix_keypad.c +++ b/drivers/input/keyboard/matrix_keypad.c @@ -425,14 +425,12 @@ matrix_keypad_parse_dt(struct device *dev) return ERR_PTR(-EINVAL); } - if (of_get_property(np, "linux,no-autorepeat", NULL)) - pdata->no_autorepeat = true; + pdata->no_autorepeat = of_property_read_bool(np, "linux,no-autorepeat"); pdata->wakeup = of_property_read_bool(np, "wakeup-source") || of_property_read_bool(np, "linux,wakeup"); /* legacy */ - if (of_get_property(np, "gpio-activelow", NULL)) - pdata->active_low = true; + pdata->active_low = of_property_read_bool(np, "gpio-activelow"); pdata->drive_inactive_cols = of_property_read_bool(np, "drive-inactive-cols"); diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c index 4426120398b0..9f085d5679db 100644 --- a/drivers/input/keyboard/omap4-keypad.c +++ b/drivers/input/keyboard/omap4-keypad.c @@ -274,8 +274,7 @@ static int omap4_keypad_parse_dt(struct device *dev, if (err) return err; - if (of_get_property(np, "linux,input-no-autorepeat", NULL)) - keypad_data->no_autorepeat = true; + keypad_data->no_autorepeat = of_property_read_bool(np, "linux,input-no-autorepeat"); return 0; } diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c index 09e883ea1352..d85dd2489293 100644 --- a/drivers/input/keyboard/samsung-keypad.c +++ b/drivers/input/keyboard/samsung-keypad.c @@ -291,8 +291,7 @@ samsung_keypad_parse_dt(struct device *dev) *keymap++ = KEY(row, col, key_code); } - if (of_get_property(np, "linux,input-no-autorepeat", NULL)) - pdata->no_autorepeat = true; + pdata->no_autorepeat = of_property_read_bool(np, "linux,input-no-autorepeat"); pdata->wakeup = of_property_read_bool(np, "wakeup-source") || /* legacy name */ diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c index da4019cf0c83..d5a6c7d8eb25 100644 --- a/drivers/input/keyboard/tegra-kbc.c +++ b/drivers/input/keyboard/tegra-kbc.c @@ -504,8 +504,7 @@ static int tegra_kbc_parse_dt(struct tegra_kbc *kbc) if (!of_property_read_u32(np, "nvidia,repeat-delay-ms", &prop)) kbc->repeat_cnt = prop; - if (of_find_property(np, "nvidia,needs-ghost-filter", NULL)) - kbc->use_ghost_filter = true; + kbc->use_ghost_filter = of_property_present(np, "nvidia,needs-ghost-filter"); if (of_property_read_bool(np, "wakeup-source") || of_property_read_bool(np, "nvidia,wakeup-source")) /* legacy */