From patchwork Fri Mar 10 14:47:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 67474 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp949983wrd; Fri, 10 Mar 2023 07:57:21 -0800 (PST) X-Google-Smtp-Source: AK7set+EHC+YvKEY15CyNblECv7mb7q5XCb2h/SHYocZkoyM38RVourGR8cPAS7v0YaHPw6qNdqF X-Received: by 2002:a05:6a20:918a:b0:be:ffb5:e41d with SMTP id v10-20020a056a20918a00b000beffb5e41dmr30136128pzd.25.1678463841332; Fri, 10 Mar 2023 07:57:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678463841; cv=none; d=google.com; s=arc-20160816; b=x34Z9rH7rMdZ4VdPAr63cUy3LXKTNecL4AimF8zb+fBkYnF7MvQLWpE87zd0+3kaGM IBxoXBD1uawPXMs3jMnOUNNtS0+fx1WpVfEZ/nDxG9WEoXgvamSOv5hQ/nNTb37ceilw yczKofc+CGxE6W1g6QHBladbPjqCWYYDtS/pK1+G8lc8nFgp5T0wfWk8Fd4YQXGbC8k0 5BLjfVPsjmKDKdxi9W/WETnccbIDet31u5NddHB5lWVezLGUBL7t+pF8/9QF5zgt6Ac6 UAeVWRA9HFEG19DDcliijui2HrfeTmEJJLMlqOkMPDMGyxk4mWMAr/vK5iXlZCyAv8F5 9enQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=erVHxEOkHulgXr4ymdjMTqBXd4BHusuBykzBB4r+uDs=; b=M2uxrt9VJKecInhoVL1bu4CPnoNmVz3057aVO+5rzkvBKl0BFy3oEiLh+srTTgIp6t AIm/lXRdAUTpnWH04igQn3+XD+K3Fu0XoqIZERp31VzM2CqiqzNLYc8SSwjVePZUnpsY g93c49AY4IPYKwkKGRT5+8SpBet26S/4eRqRtxApsZtirETQP4G8KCkb9POFz16TomhE ZrvOffGrbJT1OPwziWHE6w75U3JxRb5ILpRcJr4G35DbEdc7caD3yZyMzkEKUkKuKUnr If492tqX4Db5eTME6G1VyAVw2p2MBcOtxiZiM/cmCdvqbWSI0l6ZRtbn4tezzn00XEt/ M6bg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 140-20020a630492000000b00502f49f43easi128694pge.338.2023.03.10.07.57.06; Fri, 10 Mar 2023 07:57:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233048AbjCJOsh (ORCPT + 99 others); Fri, 10 Mar 2023 09:48:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233042AbjCJOre (ORCPT ); Fri, 10 Mar 2023 09:47:34 -0500 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35039105F13; Fri, 10 Mar 2023 06:47:17 -0800 (PST) Received: by mail-ot1-f43.google.com with SMTP id e26-20020a9d6e1a000000b00694274b5d3aso3045188otr.5; Fri, 10 Mar 2023 06:47:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678459633; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=erVHxEOkHulgXr4ymdjMTqBXd4BHusuBykzBB4r+uDs=; b=Max5u5lz6ur0UdQinEXDDb/xvgpN0N4F9TO143fM7oMuE+gA6OfsvAO8gaOV7ng/NW P3vQJ/YzcSmAl8NQfXKvslbwU2W3INEjovvIuyWrWVIIzBL4SG0rQo87ViRPwkgXAnVJ /0H+TjJhs7BUOSvujBRFVJX94WiISrwCa98GCDBfCfMNIkx8pVi91R7oV3w1R0kLvn8x 3XlYObNixfJ1a71P7MX7EH6FqAVrY3e2a/+kmHKTgFCogL8XI39jgXmBhf12hzwz/Okv zzqm4OuNhX+v1iXCs7XD8/yxXkJRmuTCRqb4uALPeIvQ4f5S2IPVs1PDJvQJHiQPET19 66aQ== X-Gm-Message-State: AO0yUKVBWNcUgLcu4VH3gKr47XtHIn+t1HqeCjII56eGtu7ECsZe25NZ FceojoQqAMGrpcFgwSXT3g== X-Received: by 2002:a05:6830:43a1:b0:690:e7d0:7918 with SMTP id s33-20020a05683043a100b00690e7d07918mr16287581otv.8.1678459633357; Fri, 10 Mar 2023 06:47:13 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id q19-20020a05683022d300b0068bd20cf07dsm114512otc.48.2023.03.10.06.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 06:47:12 -0800 (PST) Received: (nullmailer pid 1541845 invoked by uid 1000); Fri, 10 Mar 2023 14:47:03 -0000 From: Rob Herring To: "Rafael J. Wysocki" , Viresh Kumar , Michael Ellerman , Nicholas Piggin , Christophe Leroy Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] cpufreq: pmac32: Use of_property_read_bool() for boolean properties Date: Fri, 10 Mar 2023 08:47:03 -0600 Message-Id: <20230310144703.1541819-1-robh@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759996900908657698?= X-GMAIL-MSGID: =?utf-8?q?1759996900908657698?= It is preferred to use typed property access functions (i.e. of_property_read_ functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool(). Signed-off-by: Rob Herring Acked-by: Viresh Kumar Reviewed-by: Michael Ellerman --- drivers/cpufreq/pmac32-cpufreq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/pmac32-cpufreq.c b/drivers/cpufreq/pmac32-cpufreq.c index 4b8ee2014da6..7ec6d1bb4592 100644 --- a/drivers/cpufreq/pmac32-cpufreq.c +++ b/drivers/cpufreq/pmac32-cpufreq.c @@ -546,7 +546,7 @@ static int pmac_cpufreq_init_7447A(struct device_node *cpunode) { struct device_node *volt_gpio_np; - if (of_get_property(cpunode, "dynamic-power-step", NULL) == NULL) + if (!of_property_read_bool(cpunode, "dynamic-power-step")) return 1; volt_gpio_np = of_find_node_by_name(NULL, "cpu-vcore-select"); @@ -576,7 +576,7 @@ static int pmac_cpufreq_init_750FX(struct device_node *cpunode) u32 pvr; const u32 *value; - if (of_get_property(cpunode, "dynamic-power-step", NULL) == NULL) + if (!of_property_read_bool(cpunode, "dynamic-power-step")) return 1; hi_freq = cur_freq; @@ -632,7 +632,7 @@ static int __init pmac_cpufreq_setup(void) /* Check for 7447A based MacRISC3 */ if (of_machine_is_compatible("MacRISC3") && - of_get_property(cpunode, "dynamic-power-step", NULL) && + of_property_read_bool(cpunode, "dynamic-power-step") && PVR_VER(mfspr(SPRN_PVR)) == 0x8003) { pmac_cpufreq_init_7447A(cpunode);