From patchwork Fri Mar 10 14:05:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 67452 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp946143wrd; Fri, 10 Mar 2023 07:48:50 -0800 (PST) X-Google-Smtp-Source: AK7set/9jmh2BNbcVE9V20PlpAEKmEaJdWSZ18lppvjHadXNNRpra4ODeIIpS8PX801wPpecWVly X-Received: by 2002:aa7:8683:0:b0:5a8:e3d5:d7d4 with SMTP id d3-20020aa78683000000b005a8e3d5d7d4mr1851785pfo.7.1678463329989; Fri, 10 Mar 2023 07:48:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678463329; cv=none; d=google.com; s=arc-20160816; b=mGNRgcxr8FaB/reJKtfm66VKi8P9ziSa19gKBixdwAO+BhJiVyAsMwWujxvmBRYR1N llESIjmtYsXkQfzdsUkhsuIx9AyESXBzEh2eJ9ieL1eUjkFHDxdiaOMkcVe5rz+6BAKh +UIH4m85n0xRfw+RdRk97FZUiYQGWDFlS48TQZcDxjAFm4+EUY++7OidTBLSo/DHP3V1 NEZGv1Z7pMZXM/N+e5Icr786LhzE4EqRzBj9aaADHR0F4yrQeTmuXOz9Sn2mtEtkP30S HHUmw4CchiLLlUEZH6C4QPLC5vGZg/qsrUxPeW5+yWBtZuWAUJVU9bG+uOeVJpAKAOlU EdlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=16WWhagwMO72GxVXlF3l1Nyrh0nDGNGh7svpDbPfFgg=; b=Bucu92MOSSRWa+CFoskBvYbDlIo6aQsei8eH1H8/kpquvfBk3Zx3fe3ubBOFhr9HSp kc9A7//sZ8ueqzNjtIAaBTVI4w7U1SLZiVhBXfUw3SUQ+Hw7TtuWAXDhy1Tg4+8++bdW 2zEYlxLlBwHmqVaxUs4SpJ+tXjvNL/t6ZEopv7fVKQ5/hyBoCf3ghFBgUEONjD5xBymD yJWT342aS2QJIb9s6ITehcbB/4NRtKC1xfEb4/YlUtVTToUoBRsB0UKXnOgck9qhqAZy XLgsei0D7BpgeSVIvOPZbsrEztzT7O72AGQ5iscULHhfuG1qflH0HySbZ6Z22yNGRMBb Ha2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dFVYpgzf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l188-20020a6225c5000000b0058bc7462962si14407pfl.80.2023.03.10.07.48.37; Fri, 10 Mar 2023 07:48:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dFVYpgzf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231792AbjCJOGy (ORCPT + 99 others); Fri, 10 Mar 2023 09:06:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231613AbjCJOG3 (ORCPT ); Fri, 10 Mar 2023 09:06:29 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C799116C12; Fri, 10 Mar 2023 06:06:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 10EC5B82291; Fri, 10 Mar 2023 14:06:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D4E3C4339E; Fri, 10 Mar 2023 14:06:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678457170; bh=qaQcJQhx6nov9VzSU4N70ibWYjj88HenZA1ZKN3hd7I=; h=From:To:Cc:Subject:Date:From; b=dFVYpgzfrXIX6lJvbRPsJKK9ltfpFRMQSrfkSkha+QIXn1FLw6Y2ErRtrNuXbw5P5 DN+dOu1IUgcbR8Cu4U0ZcLnyLJ0kxTHEN7lU5Ib5QyppPRuG8Pj+6N6wYSaz7dmegi Q+Hkb7eYb9X882mw6CUwSCcZihfHp6YPjybCGrm2nFnvVW1ksrCnv4tl+UJe1CUfC3 Qj3FBvSQ20MeALIDpoJF2DZSE7lTxeqoVb+LmwqAtU1VHrRt4FOnvMQoLY8QywHek2 dCGUUt/xnIBZi4rgJvh+sZstsfCk1La94zXatdp54ThtHK+X68kj0EIyZ8pFEGIMp0 WEXP8MvCR9jhw== From: Arnd Bergmann To: Mark Brown Cc: Arnd Bergmann , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] spi: fsi: restore CONFIG_FSI dependency Date: Fri, 10 Mar 2023 15:05:37 +0100 Message-Id: <20230310140605.569363-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759996364993359237?= X-GMAIL-MSGID: =?utf-8?q?1759996364993359237?= From: Arnd Bergmann The assumption that the build dependency was not necessary turned out to be wrong, as building SPI_FSI without FSI results in a link failure: aarch64-linux-ld: drivers/spi/spi-fsi.o: in function `fsi_spi_check_status': spi-fsi.c:(.text+0x54): undefined reference to `fsi_device_read' aarch64-linux-ld: drivers/spi/spi-fsi.o: in function `fsi_spi_read_reg': spi-fsi.c:(.text+0x120): undefined reference to `fsi_device_write' aarch64-linux-ld: spi-fsi.c:(.text+0x170): undefined reference to `fsi_device_read' Fixes: f916c7080d28 ("spi: fsi: Make available for build test") Signed-off-by: Arnd Bergmann --- If possible, maybe just drop the original patch, rather than adding this revert --- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index fd681a668c3c..1a9a7390d595 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -357,7 +357,7 @@ config SPI_FALCON config SPI_FSI tristate "FSI SPI driver" - depends on FSI || COMPILE_TEST + depends on FSI help This enables support for the driver for FSI bus attached SPI controllers.