From patchwork Thu Mar 9 08:07:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 66654 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp162435wrd; Thu, 9 Mar 2023 00:10:49 -0800 (PST) X-Google-Smtp-Source: AK7set8O+T2azU2mPKWpCW+eSt9bUa04qgwcMyZiY2fAji0yMBW87iXK+jkUeAjIId2/WUmaBA1g X-Received: by 2002:a05:6a20:b725:b0:c7:6d29:db39 with SMTP id fg37-20020a056a20b72500b000c76d29db39mr17453165pzb.11.1678349449530; Thu, 09 Mar 2023 00:10:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678349449; cv=none; d=google.com; s=arc-20160816; b=nUWp963zY+ipUkxwKyXmZ/e73sf29MwOu5lkBNRpClHsQihYjFos/Of09UIH9djhGG vIOJ16aCv/36zwUrMH7cG85yckUT7iKqTDNJgLvH2k9LQ3uOh0152fxb5yqGhuxGbloM ZWcLcBCxCCJ4ACt39+8e70Q7WsM5LkoJmbGBh3drYlzOoyra8+EJybwut9mQfVYuFy1c AaRgkJlCBbVg4OSTFiMQpQxVj/8a4KTZ3ra0O/ruyUavGi4EHYqSCgpcYBvsgX0UyPTV 9W9Cyee0u4PP0hhSg8LI95LzSbBHNRW70IGM+WY2+Q6CyLj4wKoJBJngkeE50D1CSmLO RA4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=GBhsZn4FOlfbUQ/o+x7Y5z0f+XdjB+IJXqUnC3AEJ0c=; b=L2sAWGjOCbaX9O3Ki1Jw37HYSWQtsdYwZYAKKARjgi0xsPKEf1FfClYkjczbzHTzR/ OLDukWKRQEQe6tw/OlOoGEjvyif0Zhd1a+lp8iz7MCs6XQBCyle77BS7CJ6gdTTwDzK8 ua9a/as1Lljt2MLkHYr1VWBjsKh+iBzoeQRFb7oR9+e+dJkkeI5yMNzm6fakToLfbou7 CmSH6VdsUkh0Q3v9aaZTgwVVFRAExH6H3aStvFuLqqk3KhajUl7UGzDjlp36klIFBScA e0a7i44OCUF4eo8mGoZ8CE2/p2lMf7yuXSg4Bqgc7B+c+cB9FqK1XunsB2bf7Ka3HQgo qCYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b="kDXK5W+/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n127-20020a632785000000b004e1b5fb0683si19137340pgn.486.2023.03.09.00.10.35; Thu, 09 Mar 2023 00:10:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b="kDXK5W+/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229757AbjCIIH4 (ORCPT + 99 others); Thu, 9 Mar 2023 03:07:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229875AbjCIIHw (ORCPT ); Thu, 9 Mar 2023 03:07:52 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.214]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1893560AA6; Thu, 9 Mar 2023 00:07:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=GBhsZ n4FOlfbUQ/o+x7Y5z0f+XdjB+IJXqUnC3AEJ0c=; b=kDXK5W+/uqDgszSXdY2Bv uHFmyJKBAZ0nZtmCUha6dUUxl+7OI6y5VNllmhatkvWE5MT2X3f/r7/wxnktP09h LJD1IlXf3Qjlfc4/LzQsiAUj1GIi7b8YChd58v+BjfRX4jArxTtBo/KGKCivjxEG GGDwiCe+oay8DHYn7p8NPY= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g0-4 (Coremail) with SMTP id _____wAXH1_NkwlkiA3MCg--.23314S2; Thu, 09 Mar 2023 16:07:41 +0800 (CST) From: Zheng Wang To: marcel@holtmann.org Cc: johan.hedberg@gmail.com, luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH] Bluetooth: btsdio: fix use after free bug in btsdio_remove due to unfinished work Date: Thu, 9 Mar 2023 16:07:39 +0800 Message-Id: <20230309080739.3714610-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wAXH1_NkwlkiA3MCg--.23314S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrurW3trWkGFy3uw4DAryUAwb_yoW3Cwb_ua 48ZryxCFWUGF1IyF15KF4rZrW8Kw1rXws2qFnaqF93X3sruFsFg34jvrZ8Jw1xWr1UtF9x Aw4fXayrJr48XjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRK9NVJUUUUU== X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiGhYtU1aEEgvXMQABse X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_VALIDITY_RPBL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759876952068289391?= X-GMAIL-MSGID: =?utf-8?q?1759876952068289391?= In btsdio_probe, &data->work was bound with btsdio_work.In btsdio_send_frame, it was started by schedule_work. If we call btsdio_remove with an unfinished job, there may be a race condition and cause UAF bug on hdev. Fixes: ddbaf13e3609 ("[Bluetooth] Add generic driver for Bluetooth SDIO devices") Signed-off-by: Zheng Wang --- drivers/bluetooth/btsdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c index 795be33f2892..02893600db39 100644 --- a/drivers/bluetooth/btsdio.c +++ b/drivers/bluetooth/btsdio.c @@ -354,6 +354,7 @@ static void btsdio_remove(struct sdio_func *func) BT_DBG("func %p", func); + cancel_work_sync(&data->work); if (!data) return;