From patchwork Wed Mar 8 22:26:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roman Gushchin X-Patchwork-Id: 66485 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp606673wrd; Wed, 8 Mar 2023 14:28:31 -0800 (PST) X-Google-Smtp-Source: AK7set/6eefFrKC0Zee8UcHgiASAHr0IipIl73avmEu8i0z2/m6kWNOmugo41I8+zUDnkEmnYa/A X-Received: by 2002:a17:90b:4b88:b0:237:2eee:9ae with SMTP id lr8-20020a17090b4b8800b002372eee09aemr20094716pjb.30.1678314510991; Wed, 08 Mar 2023 14:28:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678314510; cv=none; d=google.com; s=arc-20160816; b=Pst4ijRZORwW0VJk9NwzgBNOO5H5U2S8RVFR0RiPALD3WvsXApXC0FlQxtfm24uZ12 pqp8syItXjMtEN+csp82wwCJgXkAfKy77k/1tADc4QZO4VdesDeWSHqQrkvbiFw7sjeI M8ehz0NIad9JT0MUYUjEnJNPj4NSH+IfNUt462cLcCyePrFzEOcsOE4lSmFi35ja+tvf 5j7z8VaHE/CR1Z9qYPKJszFw+9oTJH0QeUBaimWtDwW4I0NI1k8GVWKtH4uBx/EpAqsD Baa6UfxwTdv84AVNWp6jCagk2+JZvWaxWYNGbhRS8QeEzqlQa/sLUqiEerTeP9o/THxa gyJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Hs4AEBNZjkH+RExYCCp6aVEQ+A/qlLemA64cZtw3xtM=; b=B74JoYIDFqurJEXY5b1oX5+uH/djBu2yo+E4mr5gTSFhURzARbC2Lr0wdzO0tL1wdH fdFBujl1IcYP5EfVTTdoxPoLt9LjWK09+P//ysiYqpajTOkGo/QhcktEtOal3+uxYVj4 3JhJpRxD32Wfkdn2o68fCzMcWWldO1iXydkV7UjJhmTedgvJQD5lwu64GMkXHAw0QJwK 3A0CtmUloukiOGZ2syFHqGuyrBqp1h6deVJqJEAWuPbbbQQ7qRD6JHQJFiPvBT4lCtB7 v5yZN2FQ57/4OucjGaI1WjqoOB9udoVRoszoiqTRNt7q1Kr5eho/rtjXa4VZKIThP8w3 qcTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=FknmHWE9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q6-20020a635046000000b004fb3845932esi15215642pgl.576.2023.03.08.14.28.15; Wed, 08 Mar 2023 14:28:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=FknmHWE9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230123AbjCHW06 (ORCPT + 99 others); Wed, 8 Mar 2023 17:26:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbjCHW04 (ORCPT ); Wed, 8 Mar 2023 17:26:56 -0500 Received: from out-27.mta0.migadu.com (out-27.mta0.migadu.com [IPv6:2001:41d0:1004:224b::1b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 640B81816C for ; Wed, 8 Mar 2023 14:26:55 -0800 (PST) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1678314413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Hs4AEBNZjkH+RExYCCp6aVEQ+A/qlLemA64cZtw3xtM=; b=FknmHWE9MOzJ7fhID7Q/WDXHOOZqN5JxXeQSmGXI4Pvhp/VThGQM1TxAEm5XXqph3QvrDc W/tQ9EaSF0wB/QE0uIm67zk4tmYY29vTZgAcb2VbMGbRAm8mGRlOkBX/DqqgBdhcTXWACm nUrVD6ZPY4yZjHFoDwx41baphR9GuuA= From: Roman Gushchin To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Roman Gushchin , Amit Sunil Dhamne , Michal Simek , Greg Kroah-Hartman Subject: [PATCH] firmware: xilinx: don't make a sleepable memory allocation from an atomic context Date: Wed, 8 Mar 2023 14:26:02 -0800 Message-Id: <20230308222602.123866-1-roman.gushchin@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759840316969261717?= X-GMAIL-MSGID: =?utf-8?q?1759840316969261717?= The following issue was discovered using lockdep: [ 6.691371] BUG: sleeping function called from invalid context at include/linux/sched/mm.h:209 [ 6.694602] in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 1, name: swapper/0 [ 6.702431] 2 locks held by swapper/0/1: [ 6.706300] #0: ffffff8800f6f188 (&dev->mutex){....}-{3:3}, at: __device_driver_lock+0x4c/0x90 [ 6.714900] #1: ffffffc009a2abb8 (enable_lock){....}-{2:2}, at: clk_enable_lock+0x4c/0x140 [ 6.723156] irq event stamp: 304030 [ 6.726596] hardirqs last enabled at (304029): [] _raw_spin_unlock_irqrestore+0xc0/0xd0 [ 6.736142] hardirqs last disabled at (304030): [] clk_enable_lock+0xfc/0x140 [ 6.744742] softirqs last enabled at (303958): [] _stext+0x4f0/0x894 [ 6.752655] softirqs last disabled at (303951): [] irq_exit+0x238/0x280 [ 6.760744] CPU: 1 PID: 1 Comm: swapper/0 Tainted: G U 5.15.36 #2 [ 6.768048] Hardware name: xlnx,zynqmp (DT) [ 6.772179] Call trace: [ 6.774584] dump_backtrace+0x0/0x300 [ 6.778197] show_stack+0x18/0x30 [ 6.781465] dump_stack_lvl+0xb8/0xec [ 6.785077] dump_stack+0x1c/0x38 [ 6.788345] ___might_sleep+0x1a8/0x2a0 [ 6.792129] __might_sleep+0x6c/0xd0 [ 6.795655] kmem_cache_alloc_trace+0x270/0x3d0 [ 6.800127] do_feature_check_call+0x100/0x220 [ 6.804513] zynqmp_pm_invoke_fn+0x8c/0xb0 [ 6.808555] zynqmp_pm_clock_getstate+0x90/0xe0 [ 6.813027] zynqmp_pll_is_enabled+0x8c/0x120 [ 6.817327] zynqmp_pll_enable+0x38/0xc0 [ 6.821197] clk_core_enable+0x144/0x400 [ 6.825067] clk_core_enable+0xd4/0x400 [ 6.828851] clk_core_enable+0xd4/0x400 [ 6.832635] clk_core_enable+0xd4/0x400 [ 6.836419] clk_core_enable+0xd4/0x400 [ 6.840203] clk_core_enable+0xd4/0x400 [ 6.843987] clk_core_enable+0xd4/0x400 [ 6.847771] clk_core_enable+0xd4/0x400 [ 6.851555] clk_core_enable_lock+0x24/0x50 [ 6.855683] clk_enable+0x24/0x40 [ 6.858952] fclk_probe+0x84/0xf0 [ 6.862220] platform_probe+0x8c/0x110 [ 6.865918] really_probe+0x110/0x5f0 [ 6.869530] __driver_probe_device+0xcc/0x210 [ 6.873830] driver_probe_device+0x64/0x140 [ 6.877958] __driver_attach+0x114/0x1f0 [ 6.881828] bus_for_each_dev+0xe8/0x160 [ 6.885698] driver_attach+0x34/0x50 [ 6.889224] bus_add_driver+0x228/0x300 [ 6.893008] driver_register+0xc0/0x1e0 [ 6.896792] __platform_driver_register+0x44/0x60 [ 6.901436] fclk_driver_init+0x1c/0x28 [ 6.905220] do_one_initcall+0x104/0x590 [ 6.909091] kernel_init_freeable+0x254/0x2bc [ 6.913390] kernel_init+0x24/0x130 [ 6.916831] ret_from_fork+0x10/0x20 Fix it by passing the GFP_ATOMIC gfp flag for the corresponding memory allocation. Fixes: acfdd18591ea ("firmware: xilinx: Use hash-table for api feature check") Signed-off-by: Roman Gushchin Cc: Amit Sunil Dhamne Cc: Michal Simek Cc: Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/firmware/xilinx/zynqmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c index acd83d29c866..ce86a1850305 100644 --- a/drivers/firmware/xilinx/zynqmp.c +++ b/drivers/firmware/xilinx/zynqmp.c @@ -206,7 +206,7 @@ static int do_feature_check_call(const u32 api_id) } /* Add new entry if not present */ - feature_data = kmalloc(sizeof(*feature_data), GFP_KERNEL); + feature_data = kmalloc(sizeof(*feature_data), GFP_ATOMIC); if (!feature_data) return -ENOMEM;