From patchwork Wed Mar 8 16:45:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 66359 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp446124wrd; Wed, 8 Mar 2023 08:55:31 -0800 (PST) X-Google-Smtp-Source: AK7set+GElHcNClQsCBNWYmX6Q2kpvkWtImaIdLLe6FozU6lbR7jkrGRbV757AeI1VqiURLMqyQn X-Received: by 2002:a17:902:e551:b0:19d:121a:6795 with SMTP id n17-20020a170902e55100b0019d121a6795mr22378356plf.55.1678294531016; Wed, 08 Mar 2023 08:55:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678294531; cv=none; d=google.com; s=arc-20160816; b=kaF9edm+BhaWA46ttZl7OjSmTkvreQVfnNS67CC5VMuskxtoBzLOP6fcc2P9hUvs1e rdj3Ex4fJYSdtl9n4ZXEaXtdlvrliN3jjyNxedtxUGWRkoLtijN6efnG0pRlxTfN+G96 TBSUsjTyyblpHfFSFGKrXKPaA6RuBQa1UWvgQgHWT6W5wXmlNj/6vrmEjrNjEYuyB++v HtYdqU83TaGfnIx834KZbP9+qsqWCJEqmlNR5xyhC3v5+7nllvxFLgtrNujje36QlNjE SByCOuf6mT6obLcRx50UsIf3aW0Rps42Ux1/cmScEukwYT0G+jn3Til9cBJuZCpd2CRy 0XrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LYDzwPaZBIHTa29Hr5kYoaSLV3mHIy4tWwYKipSShZI=; b=Glob8vks8KaxYkvJTJUJuGf03S/2zfzazd9LHXceFdSAWy0BBP7ma+sPqqbQmyK6/W 5V1hKgzwVv+MnyBzIafU4fxhJTrRokbY94IMAxcNi+f1YCX60GuEwkthtAo76oySjAyi MsvrIyJ3GAo2L/UhOlQva9QAA/1aLM4KrJniGXGNXhOFW4G+NinHvQv60D3dFaarTGoI TeMUQZbTlvyhcrPmqslzsAfl4Ps9pL76lorR/QWregEud/Qq//1jFhJoAOCUbvb5eOOt yviDXYDyu/DAZtPa/SU6TWHoATbvispAxIaGPHFAsov6x8KCZeeaqqvs3HNjqWAhjW9A 3f/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=AjdOHJTZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lg14-20020a170902fb8e00b00199051ac8f7si14526925plb.188.2023.03.08.08.55.18; Wed, 08 Mar 2023 08:55:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=AjdOHJTZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229806AbjCHQpX (ORCPT + 99 others); Wed, 8 Mar 2023 11:45:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229869AbjCHQpT (ORCPT ); Wed, 8 Mar 2023 11:45:19 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.215]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8DF31B8613; Wed, 8 Mar 2023 08:45:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=LYDzw PaZBIHTa29Hr5kYoaSLV3mHIy4tWwYKipSShZI=; b=AjdOHJTZTdofO4+vm5g8C FkJC3mdMJlkiJ1GVKX1kQbBoNaDLnkLG3QSeXTDBp/pUuI1OBZxyD0mU2BSwwP37 APJn72/1rI0kXQiCKwCUCP1oOfBg3XwAsgGag6Lk40n9lhqWuXO8hW2kvdmU9GXl C1HgizWDqKtfo0rHzqDu48= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g0-1 (Coremail) with SMTP id _____wCnHQKPuwhk3itfCg--.4202S2; Thu, 09 Mar 2023 00:45:03 +0800 (CST) From: Zheng Wang To: marcel@holtmann.org Cc: johan.hedberg@gmail.com, luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH] Bluetooth: btsdio: fix use after free bug in btsdio_remove due to race condition Date: Thu, 9 Mar 2023 00:45:01 +0800 Message-Id: <20230308164501.2734985-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wCnHQKPuwhk3itfCg--.4202S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrZFyrZr18JF48ur1fWry5twb_yoW3ZFg_ua 48ZryxCFyUCF17tF1UCF4qvry8tFnYq3WvgFnaqas5try7WrsxGr1DZFZ0q3Z7Wr1DKFy3 Ar4rX3y8tw48ZjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRKBMNUUUUUU== X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/xtbBzgwsU2I0XkYj5QABs0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759819365703558030?= X-GMAIL-MSGID: =?utf-8?q?1759819365703558030?= In btsdio_probe, the data->work is bound with btsdio_work. It will be started in btsdio_send_frame. If the btsdio_remove runs with a unfinished work, there may be a race condition that hdev is freed but used in btsdio_work. Fix it by canceling the work before do cleanup in btsdio_remove. Signed-off-by: Zheng Wang --- drivers/bluetooth/btsdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c index 795be33f2892..f19d31ee37ea 100644 --- a/drivers/bluetooth/btsdio.c +++ b/drivers/bluetooth/btsdio.c @@ -357,6 +357,7 @@ static void btsdio_remove(struct sdio_func *func) if (!data) return; + cancel_work_sync(&data->work); hdev = data->hdev; sdio_set_drvdata(func, NULL);