From patchwork Wed Mar 8 12:55:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Duoming Zhou X-Patchwork-Id: 66248 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp339565wrd; Wed, 8 Mar 2023 05:47:13 -0800 (PST) X-Google-Smtp-Source: AK7set/k2+YbMM5zgNKl2nd9QoUuIsRJIIloDnPO8yethrw1tCHS8rUYYWtO95HdEwSMILW1An6W X-Received: by 2002:a17:906:6a1e:b0:8b1:fc58:a4ad with SMTP id qw30-20020a1709066a1e00b008b1fc58a4admr23936460ejc.11.1678283232899; Wed, 08 Mar 2023 05:47:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678283232; cv=none; d=google.com; s=arc-20160816; b=f+pJ220mB0zv3BgI/MLMLLcVoAwMLlqLjztvUlqdTdEdnoU1CTSnj7SCGZtqP/coIT 76fDkVHSEgH/KPLsGcG0cQPJ+ardNrUeb6OSQwoJklN2Gv7ImpcLcO/yJTpRFSUPJeoM l9uWBjIooVcoS2P6Eu/rv7Cks5E0WwH7CWQdreQ6jDFR8sOr+2Le3P25ckc7Cgvxo8kt LavE4rP3KDxfmeHUHOeQueE3JU6P8Y65EUmKqeuwCyxLnVCNNGYKXsosqnYHa4Qb7xbP GIIAJ2wOWTqrzAPbh/TYnldsYQW4dRLN74gPcskzBwzg7QUqrWuy7XI5POOsiHq4jIHw I72A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=2oVB/PDaEsh6Q+QadWc0WrNYoIwegU0vvTaClx87M+0=; b=k0mNQwtjPWd1fEt4KpbXV5A4YqNshEV4bH3XD8N5i+CvorR8bfnUv508CA1K68dZ+5 Id1D94dsgQkG+b27oBteQHqU9m5XBSfPl1NTit/HLZB6+CtPSUs7Mkqs9SNEAipnU6ZB WR9j4C1C7V0YQR3mRTjQBVt4RoS/aGcjv588wAeqbDnIDqTRKRDESxlPSn0znKkL9wOt 0n0ZxrqLfgDr4oLRWvmUSmlJug45yXSLesbPGIjSUIC/NXtXtRiMi5f6UmNrI55aMRhn xV92pOCj4vsYj1zk7K9l5o39Rx2i3SRzwLX6TPeNreew2n7CMMKHuisa4hic8D4SBFyN m5CQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020aa7dcc4000000b004ae08218725si4453480edu.303.2023.03.08.05.46.48; Wed, 08 Mar 2023 05:47:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229937AbjCHNhW (ORCPT + 99 others); Wed, 8 Mar 2023 08:37:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbjCHNhC (ORCPT ); Wed, 8 Mar 2023 08:37:02 -0500 Received: from zju.edu.cn (spam.zju.edu.cn [61.164.42.155]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0BE7B94765 for ; Wed, 8 Mar 2023 05:35:14 -0800 (PST) Received: from ubuntu.localdomain (unknown [10.181.231.123]) by mail-app3 (Coremail) with SMTP id cC_KCgA3uLSzhQhkHKv8DQ--.28372S2; Wed, 08 Mar 2023 20:55:22 +0800 (CST) From: Duoming Zhou To: linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Duoming Zhou Subject: [PATCH] media: netup_unidvb: fix use-after-free bug caused by del_timer() Date: Wed, 8 Mar 2023 20:55:14 +0800 Message-Id: <20230308125514.4208-1-duoming@zju.edu.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: cC_KCgA3uLSzhQhkHKv8DQ--.28372S2 X-Coremail-Antispam: 1UD129KBjvJXoW7CF4kAF45Cw13CF47Gw48WFg_yoW8XFyxpr WkuF1qyFykJ3y2yw10kw1DWr95X34fJry8Ga48Ca93Ars3Wr18Gw4jk347ZFs7C3WDAFs3 Gr1rXFy3JF17GrDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkI1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AE w4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2 IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2 z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcV Aq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j 6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64 vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAKI48JMxAIw28IcVCjz48v 1sIEY20_GFWkJr1UJwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r 18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jrv_JF1lIxkGc2Ij64vI r41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr 1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvE x4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7VUbXdbUUUUUU== X-CM-SenderInfo: qssqjiasttq6lmxovvfxof0/1tbiAgYIAVZdtd-V3AAWsz X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759807519351096914?= X-GMAIL-MSGID: =?utf-8?q?1759807519351096914?= When Universal DVB card is detaching, netup_unidvb_dma_fini() uses del_timer() to stop dma->timeout timer. But when timer handler netup_unidvb_dma_timeout() is running, del_timer() could not stop it. As a result, the use-after-free bug could happen. The process is shown below: (cleanup routine) | (timer routine) | mod_timer(&dev->tx_sim_timer, ..) netup_unidvb_finidev() | (wait a time) netup_unidvb_dma_fini() | netup_unidvb_dma_timeout() del_timer(&dma->timeout); | kfree(ndev); //FREE | | ndev->pci_dev->dev //USE Fix by changing del_timer() to del_timer_sync(). Fixes: 52b1eaf4c59a ("[media] netup_unidvb: NetUP Universal DVB-S/S2/T/T2/C PCI-E card driver") Signed-off-by: Duoming Zhou --- drivers/media/pci/netup_unidvb/netup_unidvb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c index 8287851b5ff..aaa1d2dedeb 100644 --- a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c @@ -697,7 +697,7 @@ static void netup_unidvb_dma_fini(struct netup_unidvb_dev *ndev, int num) netup_unidvb_dma_enable(dma, 0); msleep(50); cancel_work_sync(&dma->work); - del_timer(&dma->timeout); + del_timer_sync(&dma->timeout); } static int netup_unidvb_dma_setup(struct netup_unidvb_dev *ndev)