From patchwork Wed Mar 8 03:45:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 66007 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp123413wrd; Tue, 7 Mar 2023 20:04:07 -0800 (PST) X-Google-Smtp-Source: AK7set+wLznT9ShKv34/hrt6r71RnVtZ8EwmQx2X35A7D4I+R6TbjYcJx+nZUWNvkDpFvurQjYso X-Received: by 2002:a17:906:2cd6:b0:887:2248:efd5 with SMTP id r22-20020a1709062cd600b008872248efd5mr15092021ejr.77.1678248247355; Tue, 07 Mar 2023 20:04:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678248247; cv=none; d=google.com; s=arc-20160816; b=Aki0sAJ7/1urQCTmfrEy9PvY9/UyeBQBFySWJGS2ew8Ky6PIh6QDpivxPmK/vZzHiS 4FwYWWE6N0Jp9dhgtsym6D8OkduVM/yzUScjRVTyP9eGSxM2x6cAQ2AGCuYl3VAJ+Cp3 brXhWjm2fkW7qK5EzoQn34Y2D0+dKPQOEDNb7r67Yd7507i/JPzxdSZmlO5jcpgL/zKc CEdDQ00VLUntYSoDukx6ZI5MZS1kvUVYa78huPeS6OSvZiuw/Q4LtbD313q0vJYPlmas wGuemp2Kr/APDlQFL0tT3gmsEbIkvLYzYk8HRL3fl8dsBoTAv5E1SmDXC8Ommhc0kkE7 qJ6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=cAGQQH4wQyWDGC6FY8VeQxL7CF0wk1r7pps8zKct/lQ=; b=V6nywdBOT1CEJ11nwPzjUpWrHdN/hNtjOBBcAKNE+0Fq2eB9xAM/iRKGYTeK/0q+aV Gkjqy7Rnm0xsPQxjQGgWoHQ5bJmpfor9UKbnuKu+2dPYgeXlpv8KDjD/zLP4qLZxRRrc 7QRwBx8vgqNYWoTaX8AFfkrlGqS8W1U2HM/duy3I9CgDdfI6TA4j3GfQXncwgVdq5rqR 2XKSQU49GTb9wp1xP3px+82gmIW5GwBli72JO78oZh0PanuszysV/xvk3XK0851XezIH bCWrr4RQPEsUWzVyNyXZTOPygVqZX5C9YmhcPbTlzhScT+Vpv6oBBwHRax8DesrHVULp c7Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Js7x8Wul; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s5-20020a1709064d8500b008d214f8678fsi13996635eju.690.2023.03.07.20.03.43; Tue, 07 Mar 2023 20:04:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Js7x8Wul; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229746AbjCHDpK (ORCPT + 99 others); Tue, 7 Mar 2023 22:45:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229705AbjCHDpI (ORCPT ); Tue, 7 Mar 2023 22:45:08 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36D3C1164C for ; Tue, 7 Mar 2023 19:45:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=cAGQQH4wQyWDGC6FY8VeQxL7CF0wk1r7pps8zKct/lQ=; b=Js7x8WulqOLxQ+pRSWSdy/vrLn jgRM0AK53k9TYypy3IWJokVkTZoAtqSGkqlZiQ0jRb8SbyF4heuf2bEww6xrcPa+qhI5Hg2HdLiVv PlR7Ig00ZehMokI161qJdrMbETaTLpCc5L2ccLRMIB+9GyvQVX2+OfqUAuDKp9I+g39NRNLHACYDJ DwwJFfsCuQU31sE727eMfZZdQPwTjwjD22E/+U897cV9xliJKn21KVB3vCYqlDVaBPIjZXV+B4y1B AsbMP4EL8UM309QHKlm1GsEO578u3FcAvGLkmYPZeNK4/YG6sj2CibT4PknoOCzxAhlN3ic5XN8pP Pco2HA4g==; Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZkjh-003MaC-AI; Wed, 08 Mar 2023 03:45:05 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Aditya Srivastava , Joerg Roedel , Will Deacon , Robin Murphy , iommu@lists.linux.dev, Timur Tabi , Varun Sethi , Emil Medve Subject: [PATCH] iommu/fsl: fix all kernel-doc warnings in fsl_pamu.c Date: Tue, 7 Mar 2023 19:45:04 -0800 Message-Id: <20230308034504.9985-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759770834281954865?= X-GMAIL-MSGID: =?utf-8?q?1759770834281954865?= Fix kernel-doc warnings as reported by the kernel test robot: fsl_pamu.c:192: warning: expecting prototype for pamu_config_paace(). Prototype was for pamu_config_ppaace() instead fsl_pamu.c:239: warning: Function parameter or member 'omi_index' not described in 'get_ome_index' fsl_pamu.c:239: warning: Function parameter or member 'dev' not described in 'get_ome_index' fsl_pamu.c:332: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Setup operation mapping and stash destinations for QMAN and QMAN portal. fsl_pamu.c:361: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Setup the operation mapping table for various devices. This is a static Fixes: 695093e38c3e ("iommu/fsl: Freescale PAMU driver and iommu implementation.") Fixes: cd70d4659ff3 ("iommu/fsl: Various cleanups") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Link: lore.kernel.org/r/202302281151.B1WtZvSC-lkp@intel.com Cc: Aditya Srivastava Cc: Joerg Roedel Cc: Will Deacon Cc: Robin Murphy Cc: iommu@lists.linux.dev Cc: Timur Tabi Cc: Varun Sethi Cc: Emil Medve Acked-by: Timur Tabi Reviewed-by: Lu Baolu --- drivers/iommu/fsl_pamu.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff -- a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c --- a/drivers/iommu/fsl_pamu.c +++ b/drivers/iommu/fsl_pamu.c @@ -178,7 +178,7 @@ int pamu_update_paace_stash(int liodn, u } /** - * pamu_config_paace() - Sets up PPAACE entry for specified liodn + * pamu_config_ppaace() - Sets up PPAACE entry for specified liodn * * @liodn: Logical IO device number * @omi: Operation mapping index -- if ~omi == 0 then omi not defined @@ -232,7 +232,8 @@ int pamu_config_ppaace(int liodn, u32 om /** * get_ome_index() - Returns the index in the operation mapping table * for device. - * @*omi_index: pointer for storing the index value + * @omi_index: pointer for storing the index value + * @dev: target device * */ void get_ome_index(u32 *omi_index, struct device *dev) @@ -328,7 +329,7 @@ found_cpu_node: #define QMAN_PORTAL_PAACE 2 #define BMAN_PAACE 3 -/** +/* * Setup operation mapping and stash destinations for QMAN and QMAN portal. * Memory accesses to QMAN and BMAN private memory need not be coherent, so * clear the PAACE entry coherency attribute for them. @@ -357,7 +358,7 @@ static void setup_qbman_paace(struct paa } } -/** +/* * Setup the operation mapping table for various devices. This is a static * table where each table index corresponds to a particular device. PAMU uses * this table to translate device transaction to appropriate corenet