From patchwork Tue Mar 7 21:56:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Brown, Len" X-Patchwork-Id: 65879 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2690604wrd; Tue, 7 Mar 2023 14:12:19 -0800 (PST) X-Google-Smtp-Source: AK7set9ryXqnQ7ZtoR5xrGmHeHjdX4OOv2kDircG9g4VJZIammchSY6BsaatmSe0gLSLRrwYD08p X-Received: by 2002:a17:902:cecc:b0:19d:20f7:daf0 with SMTP id d12-20020a170902cecc00b0019d20f7daf0mr16129281plg.34.1678227139241; Tue, 07 Mar 2023 14:12:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678227139; cv=none; d=google.com; s=arc-20160816; b=S2J78e+WdE79bTFvHKYxvdM3RDJbOx2VYBZzcscgvGLT6j0jzDv6PxlaQ7eEMa9R4a qBce5JRJQurMGNo8AHRVCr/XDdX99sl9j1M9EwTniWHu9h/8EwOCfnDTdvD9nECE6k0p BF8qQ7Kv9nNe9+N8EHvEP0faK0f+VYXWfy7wGIU2HCUpakSAeBfhQSci8vP+QYBKgNL/ wkk91N/mmlxdrS9U5dLnbbEt0MlqpKvD20LvsOmZQIp0zlggqXRduC793lB2K52NWp+V O2+VDvb3Zk4y3LWkd7o5+k5or9Tos1FjiBoXrkNNemlrHQge3K+q5A1m0jOtfWBPQqvg O/aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:organization:reply-to :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=vCwo5YiXH3AXyU9QFP/AypJPE5EcvajwhW1p0gBbwxU=; b=1JqpLQmMu9WG7kOcowWvjDlQKmtDyqxRi0koXk1s0caiSMh81v2lgORB0ckqOdKWQo wWPxpsAspZ+bMwo2A0oY907A3IEf6zL0+FAQN1lT1jtRlLqe5C2A4J/eDsc8jaEFqssl e9Y8TIk77RX5cC7/nLz11FPChDDf/FyZnQmeirwhgtnpxlGEF2zE79hdxnCopLjgfJZU FZMhFO7tiADoToLKGG4FwnsvTu8essw1n8p68tbUKJXIZMeL9WFDYTW0ZgjVrg2O5wI2 Yy9sO50z8h4vJC5MJcnEwtA48ce0v6gI2BH1vp5vSfG3PYDuKa0cq8i4aPwXP0yQ4knl 6NcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="SgSDl/8d"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x7-20020a1709029a4700b0019abec982d2si12450085plv.22.2023.03.07.14.12.04; Tue, 07 Mar 2023 14:12:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="SgSDl/8d"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231601AbjCGV5M (ORCPT + 99 others); Tue, 7 Mar 2023 16:57:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbjCGV5K (ORCPT ); Tue, 7 Mar 2023 16:57:10 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A83AFAD02F; Tue, 7 Mar 2023 13:57:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678226228; x=1709762228; h=from:to:cc:subject:date:message-id:mime-version:reply-to: content-transfer-encoding; bh=8vgY/QVBJu+X9HRFZSvBWKypnSnfRJHbl/eOU7wG2o4=; b=SgSDl/8dCMoCFnDaMC14DGdjo5SGSgtd+eK55VAdU4UN7VJvr8mUDqy7 ttXQoCvybknpF2JXQUvHEHSL5QHvQoF84fM6RC2Gr+CCL+n7ocBMkkwWJ qi4pUGct+GwyWcKV66DhV80evm+uHKg688r0AhdbDNqxnDMkIO2mzC8DU luol4ridf32lOWvCVRAQ9wJlo7B8IdjT6b4G4WtVWhuYT7AZeyYcXaYRu x3w9q1qRUzd+wk0Iahkm5Q4iky0BxAoNrjqjfY8qDzqg5Tp0M2BAfxBzY mJBOxla+ZHMjXUhr57KFV6BZHa+80P8Xdz1GqnVrqTwrxDkS0dQNdS3ih g==; X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="400810562" X-IronPort-AV: E=Sophos;i="5.98,242,1673942400"; d="scan'208";a="400810562" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2023 13:57:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="786853606" X-IronPort-AV: E=Sophos;i="5.98,242,1673942400"; d="scan'208";a="786853606" Received: from kmdehmer-mobl1.amr.corp.intel.com (HELO lenb-mobl1.amr.corp.intel.com) ([10.212.14.112]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2023 13:57:06 -0800 From: Len Brown To: rafael@kernel.org Cc: linux-pm@vger.kernel.org, Len Brown , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/1] hci_qca: do not interfere with system suspend Date: Tue, 7 Mar 2023 15:56:06 -0600 Message-Id: <7687c4239424f2a49c6c596d19eea8dd7ebe8a30.1678226070.git.len.brown@intel.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Reply-To: Len Brown Organization: Intel Open Source Technology Center X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759748700824201088?= X-GMAIL-MSGID: =?utf-8?q?1759748700824201088?= When hci_qca returns an error to its pm_ops.suspend routine, the PM subsystem will terminate the system wide suspend. It is extremely unlikely that there will ever be a justification for hci_qca, no matter what its internal malfunction, should cause system-wide suspend to terminate. Doing so, could result in the scenario where a laptop lid is closed, suspend termnates, the user places the running laptop into a breifcase, not expecting it to be overheating or draining its battery... This is not a theoretical issue. The 6.3-rc1 currently fails this way on the Dell XPS-13-9310: Bluetooth: hci0: SSR or FW download time out hci_uart_qca serial0-0: PM: dpm_run_callback(): acpi_subsys_suspend+0x0/0x70 returns -110 hci_uart_qca serial0-0: PM: failed to suspend: error -110 PM: suspend of devices aborted after 3218.724 msecs PM: start suspend of devices aborted after 3246.859 msecs PM: Some devices failed to suspend, or early wake event detected PM: resume of devices complete after 84.988 msecs Signed-off-by: Len Brown Cc: Marcel Holtmann Cc: Johan Hedberg Cc: Luiz Augusto von Dentz Cc: linux-bluetooth@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/bluetooth/hci_qca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 3df8c3606e93..1795cc527b88 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -2309,7 +2309,7 @@ static int __maybe_unused qca_suspend(struct device *dev) error: clear_bit(QCA_SUSPENDING, &qca->flags); - return ret; + return 0; } static int __maybe_unused qca_resume(struct device *dev)