From patchwork Tue Mar 7 19:26:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65834 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2640946wrd; Tue, 7 Mar 2023 12:18:29 -0800 (PST) X-Google-Smtp-Source: AK7set9pUxG9Fl70kSUIF2NWyOw2HACUV8E3mMieRxKWVtBhkPF+EIxzQaWwnHXskt66m5WpodfP X-Received: by 2002:a05:6a20:1d60:b0:cc:b8b4:d774 with SMTP id cs32-20020a056a201d6000b000ccb8b4d774mr12552887pzb.7.1678220308897; Tue, 07 Mar 2023 12:18:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678220308; cv=none; d=google.com; s=arc-20160816; b=l6xjZOJMIEL3eWGNGM43jEd23rSZp6123WjA5//pMIAuO62JHQ+MuxNiYohzDnLfBR nWtez2b6edr4Mr4hq5EPhVoFc5F1ZW6NsPqh0M9K7VhCpaQ8i4SnN1gS1D32BGwMqBjr hdh0XBkqBHsE+p8q34L3b77Z/sHhx67nHD5EbVmUzxsWkGR0CmWMsOpaVDoW3nOWdKTv 0Sje0b7e8EfwGClKCU+fUNLBDQK8I7IdTHpmbtTvHU3R+8ei5MYn7J6NUUj5tbsd+3qI h0gbnbh7wLotCP1ZUzKzmds8RPglMiE4u+SBYBOpkTvBc5rvf7NQt4BtItmvdSJYGHq+ I7oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mqf+XgKxm0vPygX+idXfBvsl22n6vJBEl0DG+wYn0H0=; b=IyN8T6//6DtEZCaVeovinD+lvc8jDGvKXJObEk+wAoIDO/MckF0GqRdUsfhfIQCh3P FJSzGBtm0gj1H2Kt0sHWdg0fUPQMxdOIW4LkUcEuHpyZoC28lczHJ+lvCgc/llxMirVx +br6jW2jWabucnb7DcS/N6ZSklBiezLrMCrtYOmmlESgAcfMbPuDjYORMEgMoaO9oYL4 cHbk9RxM5DQZ9RLClPBa7z0c2rOYqFg1nH3WbMFutczzU/cu8Khd/7MxQvudyk09P1aj hxQrIWCGiOeJNuwy/zaQronHShLx2ODZiTLD2xQIZp8sqA1dv/6TmX90RPG7Gq7/QW1h Tx6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cVzu7GyB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v62-20020a638941000000b00502f9ffb8bbsi12511044pgd.297.2023.03.07.12.18.15; Tue, 07 Mar 2023 12:18:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cVzu7GyB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230423AbjCGTkt (ORCPT + 99 others); Tue, 7 Mar 2023 14:40:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231643AbjCGTk3 (ORCPT ); Tue, 7 Mar 2023 14:40:29 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEDC9A8811; Tue, 7 Mar 2023 11:27:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0943BB818C4; Tue, 7 Mar 2023 19:27:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0317C433D2; Tue, 7 Mar 2023 19:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678217222; bh=PBKx560qNe8SnH7l569PMqQ0gHZ8kT097OdmdKuoVds=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cVzu7GyBTNvnhQ+BDcyMOBD5vxDwAxhYNF4PydRfeVB2Pt8vRSoZe4DA6MiICz4tG YThKxWvAPjzBDVBMIIz9PnzMKmfHdFXAjCVvR9m6cjgQ2gO3WO+8KsMPofoPB99ROv oNw3Y36IFkH17+/e9/Pywydg546M98tKPyibI6AubtZt1q8JdFHuBJnebF788w276p 6HXLF8vjfLBo2G0v+164zfSgSv64wQe1sRdGDDjWbaa5uCIT5c1x1S4DU35fhL13lM +5NS37WGHUsIxEijS3ucTqNLH4E4DUIlfxXGA1H920CFP5SYkn8xQ6AuFYuXh7jUZu LQTctTZWmT9RA== From: Bjorn Helgaas To: Vinod Koul Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: [PATCH 1/2] dmaengine: ioat: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 13:26:54 -0600 Message-Id: <20230307192655.874008-2-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307192655.874008-1-helgaas@kernel.org> References: <20230307192655.874008-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759741538687502326?= X-GMAIL-MSGID: =?utf-8?q?1759741538687502326?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Acked-by: Dave Jiang --- drivers/dma/ioat/init.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c index 5d707ff63554..6ca62edf47bd 100644 --- a/drivers/dma/ioat/init.c +++ b/drivers/dma/ioat/init.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include "dma.h" #include "registers.h" @@ -1380,15 +1379,11 @@ static int ioat_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) if (is_skx_ioat(pdev)) device->version = IOAT_VER_3_2; err = ioat3_dma_probe(device, ioat_dca_enabled); - - if (device->version >= IOAT_VER_3_3) - pci_enable_pcie_error_reporting(pdev); } else return -ENODEV; if (err) { dev_err(dev, "Intel(R) I/OAT DMA Engine init failed\n"); - pci_disable_pcie_error_reporting(pdev); return -ENODEV; } @@ -1411,7 +1406,6 @@ static void ioat_remove(struct pci_dev *pdev) device->dca = NULL; } - pci_disable_pcie_error_reporting(pdev); ioat_dma_remove(device); } From patchwork Tue Mar 7 19:26:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65844 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2645268wrd; Tue, 7 Mar 2023 12:28:47 -0800 (PST) X-Google-Smtp-Source: AK7set9UhdXvIicPawikiCEbR6k8c+HxyG/NT4WFlmfkzUmxhgVnsNzK71dckfBVLrbdO6vvXLTM X-Received: by 2002:a05:6a20:6d17:b0:cc:7f46:53f7 with SMTP id fv23-20020a056a206d1700b000cc7f4653f7mr13760101pzb.13.1678220927549; Tue, 07 Mar 2023 12:28:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678220927; cv=none; d=google.com; s=arc-20160816; b=f3XmFIQ3WOc97dIMt4sgLXdP3NEcf+UgrL6wH3MamNvwz/BNpm0bW8sTYs1Mw9PSKe ol7f0Bt41+Q+QZx2JhMyE3CC3fRs8AkenseenoIKbOQRm6RjproGsMLczO5P+/aqloez qA7V7Je1Qpq6OzW1cNR2uHDpfFEHSdPBIyegXS6RqfoYFcFL5KkuCxsfGf0Q3qvIXBgI qd3n0fvTHtUaAzkCMbErnkwxUgN3Pgs2QqDVGNdHuuqDje9uBc2bwNBoXp/UmgMcTAS6 6Ve8EaImGaierMeSktWu6JXltNgdDM4YhUFYR5r4Y1rv/a/BVxrGkhr56akq7Qn6xqBW PFbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mEQRV10lV0X8ttCkvcdkwfpm6pQ6jq9KcHcV8kjiuGk=; b=EP40eNB1Wi5ogGAgYmZwcKF8+jgMOdMZL4i0ruuaw1tb7E68LXUiWk4FSDR4fW9m3N 7OZ6VEQBxFZ4G824HnACmrhkREAnLWutrHeUVrIenhTnkBHvxlBUM3xKVH7CUXndvcjg DTThYl3Xb/3B5UBHVcB5Bux1tcxByu7RPuFyQSL36pi+zKyj0WD9gg1ONVY0Z9YUs7mx 2PLJPVhb0eFow2exWmOR8k+TWXdycwNfV1aYtNEVa3E1aFcmJAP9D40H/Fb7UZK2S4Jc a0WCEU5X97fMoSITdFEfRrt9aAxrzFbkPC6OMlFonHK/KfM6LGZwjmunUARMJ+dyZXMy SvPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hvpKij3f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v2-20020aa799c2000000b005dc44c567a0si12869332pfi.24.2023.03.07.12.28.30; Tue, 07 Mar 2023 12:28:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hvpKij3f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232516AbjCGTkw (ORCPT + 99 others); Tue, 7 Mar 2023 14:40:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232036AbjCGTka (ORCPT ); Tue, 7 Mar 2023 14:40:30 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B2EC7E79D; Tue, 7 Mar 2023 11:27:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4743A61518; Tue, 7 Mar 2023 19:27:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DC44C433D2; Tue, 7 Mar 2023 19:27:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678217224; bh=rffBK/cmJusylWS6PUrzcOSzwk1o9RC+zuh589MfdC8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hvpKij3f3hfUhNK4xgM7ZJdiEYz1vvjJdUfn7UuefjWY+t/Dufsy28uHfrOiZoY5J XX21sYnk/Meg3vP198fDFUKJPxvGa9ShQSXe58t3s7yF+tzWeTJEre14ItAAC9JmQL T7LsXgWaP9dJXp/6yT2eA5mJasbLA2PvHItzRiuQ343zzrgMf0cVUjr8TzWbKDz+xe KJ3LycXhy4t6wauyn9yFRSRYeb0cu3ha5s6xcdqO8EuVnvPMuhoSe0JxzVi+iCrfm9 DiRMX2AMPwSzFL1ar+4pfCubTTOMqXcTfnN4ebwQgIgeNppSuJDVLY7aY64eQ3sijd Cd82dIYvYmXmQ== From: Bjorn Helgaas To: Vinod Koul Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Fenghua Yu , Dave Jiang Subject: [PATCH 2/2] dmaengine: idxd: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 13:26:55 -0600 Message-Id: <20230307192655.874008-3-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307192655.874008-1-helgaas@kernel.org> References: <20230307192655.874008-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759742011781213272?= X-GMAIL-MSGID: =?utf-8?q?1759742187419674548?= From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Fenghua Yu Cc: Dave Jiang Acked-by: Fenghua Yu --- drivers/dma/idxd/init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c index 640d3048368e..a85efcda7095 100644 --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -9,7 +9,6 @@ #include #include #include -#include #include #include #include