From patchwork Tue Mar 7 18:19:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65789 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2625647wrd; Tue, 7 Mar 2023 11:44:16 -0800 (PST) X-Google-Smtp-Source: AK7set8afIXSQl1ZbM3X71fM30eB+Vcw20m+9HvTFWJE02w6OAkKSh+F00sGBuQocLXw2VtOqd5Z X-Received: by 2002:a17:906:28d3:b0:8b2:3eb6:8661 with SMTP id p19-20020a17090628d300b008b23eb68661mr14791824ejd.8.1678218256003; Tue, 07 Mar 2023 11:44:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218255; cv=none; d=google.com; s=arc-20160816; b=y60ip3M7zQ7alfeITjKHCzul8sl5e8VmeMdof5TbuOFK0ed2UJUKtXMUukUGMlQICY CzVUd2pj8qeNEJuTB9a4x+JCVz0RhBWsYAe+DGvjdwnqFhgPlqxhqzZ4+aBr9LKIUukl twXf1pJRK6cMaN9yTKx4FtE3J6i0ATpTHRWkelS+OBzQah03OxcslccXD0ByHtK3IDLD Rs/+pI/i/GjjeqVv/B2+xDN5nTdwsGp53/kFqXuFzreJ0dOrtAX6vnXqA7BK0zY95cDL /7jFOz7FCj4lwWAmdySpelRLdV8y3F3MqnE3CmUqfuGDv07kKX9wFa2skb3ioRLt1RBm yEzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=D6JuY3d/LdT1rmPoQ2v89XbFWbXOl8ak742OVIsM+rw=; b=YBRRJWa3831WZigdLVmD2aKxe0gtA++b4aDaoJbnquDcMJ9HWFE+790KdBVWgPOQCn l6hnQfVacwHUAwtgSl48dCKJ4krFw0u7rtaAdrwJg7TPeSBN1HBb3JDK9csaxhhndEXi +a5N68+d6n+Yn/oKuiUitXrHDWUyA0P6NHQ7F6hPkLBfGhxp5PNdnJpIL+OFylCuXbBV bwIrfdgpOdjAQ0NPBgP3gYKQXnhhyxFGw+u+YZSzzAf7NDmHUH3ipzenud4VqsmxLrRN As0/F+eUfaonJ/rVBH7DOtoznCJ0Z2XJCDt6/zEvR4L649GCU870MbavvO+LKdysLo5c 40FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cS8ss2Gp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p11-20020a1709066a8b00b008c9434c4b8asi401719ejr.234.2023.03.07.11.43.52; Tue, 07 Mar 2023 11:44:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cS8ss2Gp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232673AbjCGSY6 (ORCPT + 99 others); Tue, 7 Mar 2023 13:24:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232792AbjCGSYU (ORCPT ); Tue, 7 Mar 2023 13:24:20 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6C639CBF7; Tue, 7 Mar 2023 10:19:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4EFAD6150F; Tue, 7 Mar 2023 18:19:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72D34C433EF; Tue, 7 Mar 2023 18:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213198; bh=5kyhbiBEtsJwMz5HCmxLv5VbTa4UdxUccaqPgY32uh8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cS8ss2GpmOsDF5I8H1FALF4fgvR6vvWwMqBHwvoV3rPKwozyXYj68u9hukliqEYYf 5jliPnkvObXjJfS9jAbwiRZjSo4uSmwl51bZ/MscD5jUX2OfIO8ZHO5oiycrusfGas 8LKp++6SWDThELLs28W4YQzIGNrONDflbIdpmjGHzgshsK+3W+xLQXtAu6mGTr7A4t uHlbk0k5/nkXIo2TBpUQCp8bWwVSV2xaBjoX1OjXzCiky4nA2m1zO/T7XCmnSyvnaM RfeBDqkSsq4v/LKL5eUXGNKXXUdUMnfZhQEPQcqcYOyEGEOdMoK1yWGAzpKgAGcWW2 FpzmLQ4AyAT4w== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Chris Snook Subject: [PATCH 01/28] alx: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:12 -0600 Message-Id: <20230307181940.868828-2-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739386160376484?= X-GMAIL-MSGID: =?utf-8?q?1759739386160376484?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Chris Snook --- drivers/net/ethernet/atheros/alx/main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/atheros/alx/main.c b/drivers/net/ethernet/atheros/alx/main.c index 306393f8eeca..49bb9a8f00e6 100644 --- a/drivers/net/ethernet/atheros/alx/main.c +++ b/drivers/net/ethernet/atheros/alx/main.c @@ -39,7 +39,6 @@ #include #include #include -#include #include #include #include @@ -1745,7 +1744,6 @@ static int alx_probe(struct pci_dev *pdev, const struct pci_device_id *ent) goto out_pci_disable; } - pci_enable_pcie_error_reporting(pdev); pci_set_master(pdev); if (!pdev->pm_cap) { @@ -1879,7 +1877,6 @@ static int alx_probe(struct pci_dev *pdev, const struct pci_device_id *ent) free_netdev(netdev); out_pci_release: pci_release_mem_regions(pdev); - pci_disable_pcie_error_reporting(pdev); out_pci_disable: pci_disable_device(pdev); return err; @@ -1897,7 +1894,6 @@ static void alx_remove(struct pci_dev *pdev) iounmap(hw->hw_addr); pci_release_mem_regions(pdev); - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); mutex_destroy(&alx->mtx); From patchwork Tue Mar 7 18:19:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65764 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2590158wrd; Tue, 7 Mar 2023 10:26:24 -0800 (PST) X-Google-Smtp-Source: AK7set9SLCX2mSljnuydN6XCfzQQdxu5D4m1H9VnDtc7lCU6uznffC1kGymub1YKfAOMwvyCpNVC X-Received: by 2002:a17:906:9f0d:b0:8af:7b80:82c5 with SMTP id fy13-20020a1709069f0d00b008af7b8082c5mr17744993ejc.75.1678213584011; Tue, 07 Mar 2023 10:26:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678213583; cv=none; d=google.com; s=arc-20160816; b=f8YjXvqq9JbTyEniOFh3lCh6gkwZ0oX64ci56PulqnBDNEBhTwPJmVXKhZdVmWFLOG P7NUzfFmM4pn6UnyfILt/V/MvAKSj88Ke7HOQvMdGSeQXrAfXI04E+ebU1pcfmbXN6ks 6gTvueD95VzV2mUcPRpiZloGnf1M3f9lHujkQH/Pk3/KRd0cE0qy30IwDtieaTr7MTQn E+2+z922R+9YpHjkOOVQPM4HTAbG88tz8s/BAjUqd/IouW2TmPrHueePIvyI00hm2n4w XX8Q9bdfRoWXD1RrNxakvg1qFA+7v7POV4niRTe8WmNRYGGeAofOBkQHSN5eJVLq2zoM aR2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tbKNhDc3IC9bjcuUTO3aHQ82DJlv8H8tMNbHXSHoS84=; b=f760ziGQ6iT/Q7Gs2/s51z2DFixIAXjP/CM+deTt9OkA6PrOuefhPzAcLxIvFsMp/k 8B6IUdiez+svshBK/lLksUZCxJ7KFCXeCU88EEtjnH/hFY2h1GqnfNEFONcCRW+2RzZX PGcz7EN8J2w4zW9gSc1TMlUGDyrO/aTRFIVxNKI4Oj+rMVoN303sFFNwJj5ytRrJcgZF STEFWsVt8T3fdc+T5U/vQnGcBK9cEEbM92cbqPFqGPB5hb9yAsJ9nDhc4xcIkI99J6L8 VcppC+AXbcVDi98ANlB6HsJK77F9+/I64n/vdDNTOUL4f7LoZuozYX0HW/qHk4We1JpS 9ztw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SbpnB4++; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hu8-20020a170907a08800b008dd40fa813asi3174039ejc.359.2023.03.07.10.25.54; Tue, 07 Mar 2023 10:26:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SbpnB4++; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232738AbjCGSZF (ORCPT + 99 others); Tue, 7 Mar 2023 13:25:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232701AbjCGSY3 (ORCPT ); Tue, 7 Mar 2023 13:24:29 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62D219F22D; Tue, 7 Mar 2023 10:20:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0B39EB819C8; Tue, 7 Mar 2023 18:20:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B0A3C433EF; Tue, 7 Mar 2023 18:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213200; bh=uTSSQxN9Ng89FUpnr+qHDi5OyXYmSr64uBuRSG1WJSY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SbpnB4++dC2O5b7l/RR11xhePxpzE7uV9WOux3IBs5PRDdEqsIcBIpPzAlMjXEmh7 bt+R34c2CM4D0fLxRhk5mhqxWOH3CW5rL3Zcrl/8okxDnZEztLGOUACTmX+3cBgc7c s3/QXb2hOWYjmHvnFpRRg6g+1IpTKItbJ+DImYpou7I++PYWNlFKKodlpFAoe4Sqjl s0h1sg0p1VaZZlSv8KMKs204F9qp98dcbK1gyKNtPjeDY+yqDtbD/K29TDnbd3AvtX +xIwxrE6riRQVGm+EtwRsfzR3dE/6eXKcOcFtY6ULL8e7Q0v70ZsOjLy/C5ULg1aNX CmbNtwUaAcPBw== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur Subject: [PATCH 02/28] be2net: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:13 -0600 Message-Id: <20230307181940.868828-3-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759734487066551043?= X-GMAIL-MSGID: =?utf-8?q?1759734487066551043?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Ajit Khaparde Cc: Sriharsha Basavapatna Cc: Somnath Kotur --- drivers/net/ethernet/emulex/benet/be_main.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 46fe3d74e2e9..aed1b622f51f 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -16,7 +16,6 @@ #include "be.h" #include "be_cmds.h" #include -#include #include #include #include @@ -5726,8 +5725,6 @@ static void be_remove(struct pci_dev *pdev) be_unmap_pci_bars(adapter); be_drv_cleanup(adapter); - pci_disable_pcie_error_reporting(pdev); - pci_release_regions(pdev); pci_disable_device(pdev); @@ -5845,10 +5842,6 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id) goto free_netdev; } - status = pci_enable_pcie_error_reporting(pdev); - if (!status) - dev_info(&pdev->dev, "PCIe error reporting enabled\n"); - status = be_map_pci_bars(adapter); if (status) goto free_netdev; @@ -5893,7 +5886,6 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id) unmap_bars: be_unmap_pci_bars(adapter); free_netdev: - pci_disable_pcie_error_reporting(pdev); free_netdev(netdev); rel_reg: pci_release_regions(pdev); From patchwork Tue Mar 7 18:19:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65778 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2623698wrd; Tue, 7 Mar 2023 11:39:32 -0800 (PST) X-Google-Smtp-Source: AK7set9+LpgsT0Yv9ewvl39mlg8q2VbobdJdKCSH7qgJ78eGpoW3EVAaEfI5IMhsbD9x56s+zdyI X-Received: by 2002:a17:907:6d87:b0:8f6:52c:afa0 with SMTP id sb7-20020a1709076d8700b008f6052cafa0mr18382169ejc.23.1678217972574; Tue, 07 Mar 2023 11:39:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678217972; cv=none; d=google.com; s=arc-20160816; b=zVr3r0Xf/LAzDpq/z8Y4Z6hOFBcPM7M0UmyxMLnuEz8Pw0rlPWLv3v/tCVAlmr3Rb7 J4ahMZHDZoaZUjGUotbw8SklMsw+vZvGZ2i2Nc7kzuov9asjzHgTIi6Lb/K9P7hDuuUe 1bnECTaGkJgpFKm+r58y9f6Fkx+kfa6Sxs5kMQReyMMiwhU3MrhgGDaFhlNeK9kA2dyJ T6KosRb1WJoJqTgoW+ilFsWajIya4Tq/AAL7rrc6Auwg0fZB0KB76mjm1O75z8Ujm22Y dpPGXYNAZFkYhmyjixxEMY5Z1Uz5O2rU2CNHNn1J0qzHxPb7toNa4BQp/B56SYA2wm2b 3itQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=X2LjsENAN62J+hz5KYiz2q9eyXADonBwNRXul34/EqE=; b=uEhIPormEqoDo/Nfsu/BC4t3+5MNqyfE7mqPKyVMYHpxpBD/lwelnaCyzQdSqYQ9UT Avz5uKbD09rCe82mxA8Xv86kCo44gWw3b8T6ItsyxSc9F+ElUUUXzyNmMHIODkqfB0HB BGJfW+H1Z0BOS0px9wvAr/jUaBHatlPJyLI8bEXHRTRbTpXr/W3xy2LDSj1lP8QSFeea YbN0QYJ3XsJu3KP0SYQJ9ZBitBgGxeS2xP5cXgsqVsFhHrmDZvV4vKQM7QdT2+EQ98Rx sr6NRzx5RRUbkKjezOlWYPUID73twTX/8BiAYNeQroxfsqQv8+HMpYZCTFud5O5FGzbA gPog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RKSnXDxr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j14-20020a170906278e00b008f8929efcf4si1543561ejc.108.2023.03.07.11.39.07; Tue, 07 Mar 2023 11:39:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RKSnXDxr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232878AbjCGSZI (ORCPT + 99 others); Tue, 7 Mar 2023 13:25:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232430AbjCGSYb (ORCPT ); Tue, 7 Mar 2023 13:24:31 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DCE39F230; Tue, 7 Mar 2023 10:20:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2546B61501; Tue, 7 Mar 2023 18:20:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F9F9C4339B; Tue, 7 Mar 2023 18:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213202; bh=gyAIiE+ZKIR9obu+1KTy/40lPs3yvZTMSEbedscpsvs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RKSnXDxrYqcm+9W1g2vCqvRqRSNH1I2Rw2s/rXg/QlZTV197yJLGV9jB3m96UNT9V ii7nhEChM/lBK4ZpvoZygFd8qW89tkLA/FSJVw0xekI7Ayh6ynfUSYX2app24FjcBb ksVnOUWMc4Sc7GUwMJktiqams1nI956RCbcfyk9L3TbVg3HTKqSweLa3StBA2MuRwl tSnZMvKjkHT41b6Lq75JE/5lnVkvvRJFeUZL/Ec2mOKVLb0w3cJZicvrzbFgiVrF/m M8iHkYt99ckHEnZHcoCHtI858pdhcYuV6UpzOLWhzJTxOHn6TA0Ci9MBN9BL/u4SyX N9oK60FRDOybw== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Michael Chan Subject: [PATCH 03/28] bnx2: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:14 -0600 Message-Id: <20230307181940.868828-4-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739088514607132?= X-GMAIL-MSGID: =?utf-8?q?1759739088514607132?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. cd709aa90648 ("bnx2: Add PCI Advanced Error Reporting support.") added pci_enable_pcie_error_reporting() for all devices, and c239f279e571 ("bnx2: Enable AER on PCIE devices only") restricted it to BNX2_CHIP_5709 devices to avoid an error message when it failed on non-PCIe devices. The PCI core only enables PCIe error reporting on PCIe devices, which I assume means BNX2_CHIP_5709. Signed-off-by: Bjorn Helgaas Cc: Rasesh Mody Cc: GR-Linux-NIC-Dev@marvell.com Cc: Michael Chan Reviewed-by: Michael Chan --- drivers/net/ethernet/broadcom/bnx2.c | 21 --------------------- drivers/net/ethernet/broadcom/bnx2.h | 1 - 2 files changed, 22 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c index 9f473854b0f4..a66137b8d1a6 100644 --- a/drivers/net/ethernet/broadcom/bnx2.c +++ b/drivers/net/ethernet/broadcom/bnx2.c @@ -48,7 +48,6 @@ #include #include #include -#include #include #if IS_ENABLED(CONFIG_CNIC) @@ -8093,7 +8092,6 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev) int rc, i, j; u32 reg; u64 dma_mask, persist_dma_mask; - int err; SET_NETDEV_DEV(dev, &pdev->dev); bp = netdev_priv(dev); @@ -8176,12 +8174,6 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev) bp->flags |= BNX2_FLAG_PCIE; if (BNX2_CHIP_REV(bp) == BNX2_CHIP_REV_Ax) bp->flags |= BNX2_FLAG_JUMBO_BROKEN; - - /* AER (Advanced Error Reporting) hooks */ - err = pci_enable_pcie_error_reporting(pdev); - if (!err) - bp->flags |= BNX2_FLAG_AER_ENABLED; - } else { bp->pcix_cap = pci_find_capability(pdev, PCI_CAP_ID_PCIX); if (bp->pcix_cap == 0) { @@ -8460,11 +8452,6 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev) return 0; err_out_unmap: - if (bp->flags & BNX2_FLAG_AER_ENABLED) { - pci_disable_pcie_error_reporting(pdev); - bp->flags &= ~BNX2_FLAG_AER_ENABLED; - } - pci_iounmap(pdev, bp->regview); bp->regview = NULL; @@ -8638,11 +8625,6 @@ bnx2_remove_one(struct pci_dev *pdev) bnx2_free_stats_blk(dev); kfree(bp->temp_stats_blk); - if (bp->flags & BNX2_FLAG_AER_ENABLED) { - pci_disable_pcie_error_reporting(pdev); - bp->flags &= ~BNX2_FLAG_AER_ENABLED; - } - bnx2_release_firmware(bp); free_netdev(dev); @@ -8766,9 +8748,6 @@ static pci_ers_result_t bnx2_io_slot_reset(struct pci_dev *pdev) } rtnl_unlock(); - if (!(bp->flags & BNX2_FLAG_AER_ENABLED)) - return result; - return result; } diff --git a/drivers/net/ethernet/broadcom/bnx2.h b/drivers/net/ethernet/broadcom/bnx2.h index a09ec47461c9..315b08c64edd 100644 --- a/drivers/net/ethernet/broadcom/bnx2.h +++ b/drivers/net/ethernet/broadcom/bnx2.h @@ -6808,7 +6808,6 @@ struct bnx2 { #define BNX2_FLAG_JUMBO_BROKEN 0x00000800 #define BNX2_FLAG_CAN_KEEP_VLAN 0x00001000 #define BNX2_FLAG_BROKEN_STATS 0x00002000 -#define BNX2_FLAG_AER_ENABLED 0x00004000 struct bnx2_napi bnx2_napi[BNX2_MAX_MSIX_VEC]; From patchwork Tue Mar 7 18:19:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65811 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2629377wrd; Tue, 7 Mar 2023 11:53:45 -0800 (PST) X-Google-Smtp-Source: AK7set+JniPtNXQcsYIwVq8PmKmKPtR2s3DbNfAgJvt7Kf2u76xGJVqEb3mU6ATU6l8te5674ClY X-Received: by 2002:a17:903:2349:b0:19b:fed:2258 with SMTP id c9-20020a170903234900b0019b0fed2258mr18873533plh.41.1678218825475; Tue, 07 Mar 2023 11:53:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218825; cv=none; d=google.com; s=arc-20160816; b=eKPE8Mo1QrfsnrZvKC2/q6U0+qROIfx5hHpWEKiClQYHSKQzxo2dZ4/hf1UnEtXVbJ M9mT1MWR7P4u8aBHX02eFwQHVPvWlIjEG5Yb6w5P4+V9o0/45HXzmL/B7CEPMXrNTN+s wkQQku/IUAcDNObVTEA6Q4yoy/nNwtBmyW5HmwKjvF4J009qxK0/L//0XPtF+eQ0DYpz JnD3eOrxXspM927wdGBvuPhq85F1WPmYA0chj951LK0JhlsSowmXLE3kbK7s3+yAZKxn 2g5wxRCzJb4F7HGn8LNIxHbUJzS4loDaNjkndJNYxs782pMlYGt87BqJB6FIWb7Ycr1r rtXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VNqR9FOnZN6d+CM2XVKoL8m1DZQhk6HUQGKtlNkDWoE=; b=JzkOnjRv9X03RNeCqX5eD+5BvGRmBDr3TpfW/QszwjSky9bxkZeISiMtUtnZZtxNYd usGdf7tUY42Tgvd93y4Acaffb64WVUVft6UBeKwRt6AAiiD+GiU2Pu2xjxtzw0y02eTs 0SHeGy55YluA2P8AiRWm2gSMXRI+ysiKyU32ctIOE2WBcIkPz32GuDzAV7MEjY7P8zNa Cplx/S9Yxg8fyWnFDkZ/sjsNpW8I4sXhTvPVzKa4aekQC9oMeR0uIAKSNyb0eFqp8kbI v4Kt1XO/+T59B9nbHEqoFbTMpSfTk/5aQD8Pz3aqgeYdb/aT/L7U+b2ix1xy08Doy1AB 9JhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="S/3da3zW"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b17-20020a170903229100b0019ca7a76d2fsi14462837plh.41.2023.03.07.11.53.31; Tue, 07 Mar 2023 11:53:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="S/3da3zW"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232430AbjCGSZO (ORCPT + 99 others); Tue, 7 Mar 2023 13:25:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232539AbjCGSYc (ORCPT ); Tue, 7 Mar 2023 13:24:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 733F4960A4; Tue, 7 Mar 2023 10:20:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 030C56153E; Tue, 7 Mar 2023 18:20:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 383BBC433D2; Tue, 7 Mar 2023 18:20:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213204; bh=GFoO0oJn14FI99xGEuLIehsG9zk7o7c2DkNHWJzWB+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S/3da3zWVpPbxUf6yK383AW4n7voT7UkVrzUBG1yePxcG71xF+bZWqbxVYKFa/zER co4JB2E6RO7gucVXCoz7RX+3jS5rjC6yCEql6bEMYs2och0iCRje1SXAOXbfOFoCbN KlEpJIrisGullr47AMhNaa4D17cChRSmJ2bbTRcsvwTlUIWBTgKY+VNEPpl0/Z4sQG HgDy5agjCxq0oFAbQ0NNJUvtKVLAACl2frduZg30qoz65225gzDQk2a8x14Q6pA1JB x+z7oZohHNX4qRK041xosrZWP7+xqg3eANx3QUloouXwchHy9cUwNlGHh298qQdtam j29u4lgi4qmiA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Ariel Elior , Sudarsana Kalluru , Manish Chopra Subject: [PATCH 04/28] bnx2x: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:15 -0600 Message-Id: <20230307181940.868828-5-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739983375699934?= X-GMAIL-MSGID: =?utf-8?q?1759739983375699934?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Ariel Elior Cc: Sudarsana Kalluru Cc: Manish Chopra --- drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | 1 - .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 19 ------------------- 2 files changed, 20 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h index dd5945c4bfec..8bcde0a6e011 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h @@ -1486,7 +1486,6 @@ struct bnx2x { #define IS_VF_FLAG (1 << 22) #define BC_SUPPORTS_RMMOD_CMD (1 << 23) #define HAS_PHYS_PORT_ID (1 << 24) -#define AER_ENABLED (1 << 25) #define PTP_SUPPORTED (1 << 26) #define TX_TIMESTAMPING_EN (1 << 27) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index 5d1e4fe335aa..3bb5ea570c87 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c @@ -29,7 +29,6 @@ #include #include #include -#include #include #include #include @@ -13037,14 +13036,6 @@ static const struct net_device_ops bnx2x_netdev_ops = { .ndo_features_check = bnx2x_features_check, }; -static void bnx2x_disable_pcie_error_reporting(struct bnx2x *bp) -{ - if (bp->flags & AER_ENABLED) { - pci_disable_pcie_error_reporting(bp->pdev); - bp->flags &= ~AER_ENABLED; - } -} - static int bnx2x_init_dev(struct bnx2x *bp, struct pci_dev *pdev, struct net_device *dev, unsigned long board_type) { @@ -13157,13 +13148,6 @@ static int bnx2x_init_dev(struct bnx2x *bp, struct pci_dev *pdev, /* Set PCIe reset type to fundamental for EEH recovery */ pdev->needs_freset = 1; - /* AER (Advanced Error reporting) configuration */ - rc = pci_enable_pcie_error_reporting(pdev); - if (!rc) - bp->flags |= AER_ENABLED; - else - BNX2X_DEV_INFO("Failed To configure PCIe AER [%d]\n", rc); - /* * Clean the following indirect addresses for all functions since it * is not used by the driver. @@ -14020,8 +14004,6 @@ static int bnx2x_init_one(struct pci_dev *pdev, bnx2x_free_mem_bp(bp); init_one_exit: - bnx2x_disable_pcie_error_reporting(bp); - if (bp->regview) iounmap(bp->regview); @@ -14102,7 +14084,6 @@ static void __bnx2x_remove(struct pci_dev *pdev, pci_set_power_state(pdev, PCI_D3hot); } - bnx2x_disable_pcie_error_reporting(bp); if (remove_netdev) { if (bp->regview) iounmap(bp->regview); From patchwork Tue Mar 7 18:19:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65771 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2621893wrd; Tue, 7 Mar 2023 11:35:28 -0800 (PST) X-Google-Smtp-Source: AK7set9MeoNhcCMr+D/g3RTpW24j1YO1YkQqhTgiOFaoq1Qp2E8wF9QhrSiZCbH6rIRDFh1bB7H/ X-Received: by 2002:aa7:c318:0:b0:4bf:c590:3c57 with SMTP id l24-20020aa7c318000000b004bfc5903c57mr13592836edq.2.1678217728539; Tue, 07 Mar 2023 11:35:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678217728; cv=none; d=google.com; s=arc-20160816; b=DjhAphRSZt2lwZoaxsQj+xiuz0ceOZhED5uHak/pa2QFYicGcNhsIfqZcptbpCjj/6 ZT/P7XwHEgUst1mY0VgBE7TxcIflD/5em06Wcag+BRq5HmURsaREpG5P7bZZIzNBFq/0 +JeVRpSsHq6ktvuTuxraY9XmnqM/w7mDx3UdRCKhxnB4CsQP5S3QLHrXCVFO2Raikbuk vkiMf0PgYzhmtHx494dzyPAI4SqhFQulJ3ox1gU9FleqO3oh/aQD5c9iOyReQgSh1g3u RErk8b9HTy2l9ylVV/jB/EMN/PL+hYmcuK+EDyKQua/xNWJlbTvLTMKK+kokTU1ws7bZ h2Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WdKY3vD50XV3M5Oi3k17Ah/rlOMfrzZwdSIuGjj0w7Q=; b=M3yAcXNv996bSD49Tc1XOfL+vHp7fkApCkfSQ/TUzCgTmWsmNvsu+A+RRhaTygb4Tg SObXgOHfYFDYqzQgbXpsZwXN/fBukMG5eC3u6dz6mwtrblJQNjc6zOS1eem7wHc5uv2m vWE1b2gyuXz4WcoleKg/TjW2728eyymX1UPK3lEzHneWipBXVaT1y1zlZIP02vp41A4l h6hWRyb/8vpoEty808COHJ7z/efzG2vZcErN9sB+tJJ32uI0U2DwIXuv5DAtYf0AVEHk vqVoehjPehWTVyjqqhjELcodoZ8OkrQQJxnyasNA7MmfavzGRKxABWxhrCHFyuoxi9Pm VWnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pjGP5Jg3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kg8-20020a17090776e800b008c5418ac5d9si9027380ejc.495.2023.03.07.11.35.04; Tue, 07 Mar 2023 11:35:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pjGP5Jg3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232887AbjCGSZS (ORCPT + 99 others); Tue, 7 Mar 2023 13:25:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232802AbjCGSYd (ORCPT ); Tue, 7 Mar 2023 13:24:33 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B32F59FE4F; Tue, 7 Mar 2023 10:20:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6F368B819C2; Tue, 7 Mar 2023 18:20:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03A1DC4339C; Tue, 7 Mar 2023 18:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213206; bh=s4Z5SneGnLA3UHvVIg+sNkMWzINirxbbbRYKROhaFH4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pjGP5Jg36iyH9IhbzJWBKbfbXiU8B9+cX9V081gQ8GNKQcA/rBHOculzG3oa1Le2z Hjurwn2jwQhwbTcU7a5DzP9VhFblvGKOzEBZBdMkNobvrUF1PgL9Mq0p8jsqfIYL8L H7ufXLnqZqO3nNnTQhQpZ2w8enoH6ZTKiZ4sOFrvx6qE0qtUW5IYZ7/RQiWC3d+OQZ hr0HZ3xsxSg8AKBjsZhBmOI0ve/gva2rh7c5j+BZ1TOXMjQl+00ilKfqe0gb2kY3U9 E5ZnBsoKpzMbxMjG4ETwOqEAnEhAOhqTxm1GUl9HTa9hvbX8CRVDOBnt9fHTGMlurW 3Db4aSDT9eEfA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Michael Chan Subject: [PATCH 05/28] bnxt: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:16 -0600 Message-Id: <20230307181940.868828-6-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759738832993373519?= X-GMAIL-MSGID: =?utf-8?q?1759738832993373519?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Michael Chan Reviewed-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 5d4b1f2ebeac..7245fee13ad0 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -48,7 +48,6 @@ #include #include #include -#include #include #include #include @@ -12706,8 +12705,6 @@ static int bnxt_init_board(struct pci_dev *pdev, struct net_device *dev) goto init_err_release; } - pci_enable_pcie_error_reporting(pdev); - INIT_WORK(&bp->sp_task, bnxt_sp_task); INIT_DELAYED_WORK(&bp->fw_reset_task, bnxt_fw_reset_task); @@ -13187,7 +13184,6 @@ static void bnxt_remove_one(struct pci_dev *pdev) bnxt_rdma_aux_device_uninit(bp); bnxt_ptp_clear(bp); - pci_disable_pcie_error_reporting(pdev); unregister_netdev(dev); clear_bit(BNXT_STATE_IN_FW_RESET, &bp->state); /* Flush any pending tasks */ From patchwork Tue Mar 7 18:19:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65801 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2627503wrd; Tue, 7 Mar 2023 11:48:45 -0800 (PST) X-Google-Smtp-Source: AK7set+N4eqpDZaa0cv02wlHeZNxe2Xo1Y9KYMJkz8fkWps1E084BiRBshBh6uRTD4Ncinl6sW5M X-Received: by 2002:a17:906:8396:b0:8b1:1f2d:ecf1 with SMTP id p22-20020a170906839600b008b11f2decf1mr18057112ejx.67.1678218525732; Tue, 07 Mar 2023 11:48:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218525; cv=none; d=google.com; s=arc-20160816; b=vMNtok+XDh1SHf7HlE7/ZqrRHZED6KXZkA85d8dkP4Vw224kGf/JbbAyHQh45EaVc2 CYzhuBkf9BI9ZDb+qnoC2V4BqzV9h+SYxymTGJgYkfuqUIS861Xyh7tbvVyXvUETuIa+ AZ969saiFk2BwAx6Um0Ctgu6ZmExtFgKmukhOptcdQoLJvbeulib6ACo4Mk/uzF/lohb ypf8F/RJQiKjHq3om+/Job5YCo0Zj7gTeIgTl7iQUljavMiZsYmLi0AwODAwLxC3sczs 0UegbU/op336G9GjmImN2RYGo1dHNlUufjBgEUNR0KTj9zYcjjuXWWlar2ND8ELG3lu9 quaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zKEswKtawRF1m07hDbIRh86aTCeBEdsCsDGj3BofcpI=; b=k1jMfKRBvVQS7plWYBjAKubgQTNer8Kt2Cdm92Fyg3S4QbgXsNi3ATjARfO6rPmQZp XkgPj9hJZDnhyM1eEi3uJNtQ0EMr8XR9Twg+rhtZ44xnWxXuRO2dFhajW9YRpCsoSgV8 lwCKTy8mfGxgw2Uj7FjGGk1HUg/sh66ehuSo5iQCriLhv8mILCDPtHpYSaPWLs3L3jjA dQZNk1ufvY9THpFcbcD21C2nTYaTx+U/kzcXwaTABA1piADnR74JKlWzZJXMAyVq2hOw Ns/QMyMaDCbXaV9DyBuDVNap+t+dSAzzCWEh8ZkgNbj9k+hC1QqPBdD3e2x3MMMTpHIl 6SXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iURIuRfs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f25-20020a170906049900b008df5a5088cesi2889037eja.163.2023.03.07.11.48.21; Tue, 07 Mar 2023 11:48:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iURIuRfs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232892AbjCGSZ0 (ORCPT + 99 others); Tue, 7 Mar 2023 13:25:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231354AbjCGSYe (ORCPT ); Tue, 7 Mar 2023 13:24:34 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24BF59FE51; Tue, 7 Mar 2023 10:20:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8C14F61546; Tue, 7 Mar 2023 18:20:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4513C4339C; Tue, 7 Mar 2023 18:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213208; bh=pFPJ8Gf/UKoAjq3MFpPQ7R9lpnJErmcP6SLaIvSooH0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iURIuRfsXJMsXQrZ4QCQUds072j/cgGQfquLTdhMQstz7xlhx2Zide0H8KZmYc6ub k+lwuRDfJ97HKLzcWEMRt8a20On+a2FOUPBBMTNx4h8wlZOjpP+Dc+N9Pt6qxIFdck 2m80egoZjIif/CC9ZMNGsXnE7oq33ST4hz9CYj+NsE/KK/TzdZ9+ZW+zszzv/1fIpP N+yC75cd9xY8iQLEKiN62Yom0AsoRNpMijy1CNgvYeXkbHi8v1rrkrSQfeofMbxlOF znLThsDmQOryFf/GGPIbcW139M51iH1OLFGqk/gn4lv7/q2dUuFnONGTXHAz53MsV4 Qzjl0qJfPGFNg== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Raju Rangoju Subject: [PATCH 06/28] cxgb4: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:17 -0600 Message-Id: <20230307181940.868828-7-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739669032532782?= X-GMAIL-MSGID: =?utf-8?q?1759739669032532782?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Raju Rangoju --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index 7db2403c4c9c..f0bc7396ce2b 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -51,7 +51,6 @@ #include #include #include -#include #include #include #include @@ -6687,7 +6686,6 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) goto out_free_adapter; } - pci_enable_pcie_error_reporting(pdev); pci_set_master(pdev); pci_save_state(pdev); adap_idx++; @@ -7092,7 +7090,6 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) out_unmap_bar0: iounmap(regs); out_disable_device: - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); out_release_regions: pci_release_regions(pdev); @@ -7171,7 +7168,6 @@ static void remove_one(struct pci_dev *pdev) } #endif iounmap(adapter->regs); - pci_disable_pcie_error_reporting(pdev); if ((adapter->flags & CXGB4_DEV_ENABLED)) { pci_disable_device(pdev); adapter->flags &= ~CXGB4_DEV_ENABLED; From patchwork Tue Mar 7 18:19:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65814 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2629751wrd; Tue, 7 Mar 2023 11:54:42 -0800 (PST) X-Google-Smtp-Source: AK7set+abOxVT0tuuYSr3OsoM2zP9Bvd4o2EJvchYC7gwZwHNTNTeB+RZJ6Ppl6qdWLIOTqls5V8 X-Received: by 2002:a17:902:f691:b0:19d:1fce:c9ec with SMTP id l17-20020a170902f69100b0019d1fcec9ecmr19676683plg.37.1678218881861; Tue, 07 Mar 2023 11:54:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218881; cv=none; d=google.com; s=arc-20160816; b=sqRIrJP6p6IDOcFMRILCKpMs0P65GcL483wVKifik+hB0toIDCxVKqBdkRr7E2gkxE uO7s5uDdtcelELb9LUNQE5f307v9o3IelLQtgzJ2jm/BjA5wUnuCi106y5Tqe97cmNUk bEYV6YwlLOnpPV7xkVFy+8efTSY6tq2m65APUWVghH9UZiI4hF8nyqBv+QXbje5oOdKe gQa+dC4aGZrl1D7kzmTfR7byHZT5cjh73ATmhNhb0JOsP6YuZ/TaF1WgV8BqBKrmG1Ie U2D+qGAXA7IbWXVSF2Fz+vHHehNWUP6yl2NDJP3yplWECUNIe9QVNWcBAZj4EQCYnRNl ItRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Sn2fxt+0EJv5lIvLbNUL8ejRVCplbfRFG2MTH+GQqqo=; b=fzqkHLJ1QxjlzrNWHU1HHEXPfQ5XyXoa8W4xHMvNFRVGMMS3uAn92wYrMx1u7IrERC ODOl0lpWMzE/5Vym+J2fIRvl9ubV+vjKft4fb4ysmkkTAyQ2/NgRXzzcPMuU+S7jb1bk cQgqwxSPg2Bshs+xilfR62HinX//K2OspbeXtxhdnNM3pK/zpgoomgrvKhHIoKQYCBFI zc4wkrpt32UZHaTj3BspQ+D9KqwVO6mmKZig6VegkRqODUQ3UT5ap3JG3K266HorkNOP T4MeFavYM0lJvOA3A5krC/utGJLc64qcpTLamKfaZgx7qn0kB8Gj3Ky36WQLzA+PiqGD xTFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kyNeenAR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h193-20020a636cca000000b004fc1da19518si13028832pgc.1.2023.03.07.11.54.29; Tue, 07 Mar 2023 11:54:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kyNeenAR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232903AbjCGS0C (ORCPT + 99 others); Tue, 7 Mar 2023 13:26:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232812AbjCGSYj (ORCPT ); Tue, 7 Mar 2023 13:24:39 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C24BBA4023; Tue, 7 Mar 2023 10:20:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 521C06154C; Tue, 7 Mar 2023 18:20:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F4B7C4339C; Tue, 7 Mar 2023 18:20:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213209; bh=LbCwYJ20y8eWkgkIiA04QacuVyTv59uOi6c3cF4SrJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kyNeenARGKJlqG3HD8EnysYP8c51Ld33M6PWizLGt8ypsiCtcUuossg80YghysKLN zBdbdOiz1ORJt8/CRSnBHrJIM52Hdgs9cQmDfZz4g8g7rmRwplEYzB1WV8QyZSpfkr 9yZD0xNCw032IjlfyIJiaKpBc0H4zN4b7AvrG0NipBsXlxcHnIUQMoi6G5OFw09WrO sebTljQ4yfzf14ka11TlzF7JjLHnaCuV6FM68ybWPUgKKhCoYjm6qT3XT2Mjw2IwyH 0GFegLnlSQ9xenDfva7lMyNmCMWTT3gnrdDrMWFvYR9ZIfUB0BjYp+++8yb+4h0Ap0 fe0JN2OjYrflQ== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Dimitris Michailidis Subject: [PATCH 07/28] net/fungible: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:18 -0600 Message-Id: <20230307181940.868828-8-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739282447185729?= X-GMAIL-MSGID: =?utf-8?q?1759740042074306403?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Dimitris Michailidis --- drivers/net/ethernet/fungible/funcore/fun_dev.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/fungible/funcore/fun_dev.c b/drivers/net/ethernet/fungible/funcore/fun_dev.c index fb5120d90f26..3680f83feba2 100644 --- a/drivers/net/ethernet/fungible/funcore/fun_dev.c +++ b/drivers/net/ethernet/fungible/funcore/fun_dev.c @@ -1,6 +1,5 @@ // SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) -#include #include #include #include @@ -748,7 +747,6 @@ void fun_dev_disable(struct fun_dev *fdev) pci_free_irq_vectors(pdev); pci_clear_master(pdev); - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); fun_unmap_bars(fdev); @@ -781,8 +779,6 @@ int fun_dev_enable(struct fun_dev *fdev, struct pci_dev *pdev, goto unmap; } - pci_enable_pcie_error_reporting(pdev); - rc = sanitize_dev(fdev); if (rc) goto disable_dev; @@ -830,7 +826,6 @@ int fun_dev_enable(struct fun_dev *fdev, struct pci_dev *pdev, free_irqs: pci_free_irq_vectors(pdev); disable_dev: - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); unmap: fun_unmap_bars(fdev); From patchwork Tue Mar 7 18:19:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65817 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2629970wrd; Tue, 7 Mar 2023 11:55:13 -0800 (PST) X-Google-Smtp-Source: AK7set/++5NiaT7EKSqd1yDvuZE2GmXxapnCyZCmOdOBsQ90MRccCF+OFxv/42KaJ3uyezJb9kpm X-Received: by 2002:a17:906:4f94:b0:8ed:e8d6:42c4 with SMTP id o20-20020a1709064f9400b008ede8d642c4mr14667917eju.12.1678218913793; Tue, 07 Mar 2023 11:55:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218913; cv=none; d=google.com; s=arc-20160816; b=NQYfQ6N/3CJKUZixw9LX3zPd4SQdLYEIrJFE0AtZIJcQ0BTNBU35AgMkWKOGLOmXA0 /DXNKzLHjfj/wPpPLh5sKKLpNvMYPzqvIQ13p1RfZMYlruDpbG+sDgQj2yA7HHIisN0L UaGZRgJlQUskLixziRTvgB4RsNDHnML7tev1hHsHlBfQ8zAAI9Mrz78kVxBG1ZTMVRv4 sWoGgHyLGcw7Zw5oHpnGfgNXgdANp2yoZSVoxgHAaL5RtWG6rdasMnQ2+Uch3JgUshjd JyLFKnW5jKvmOJ7BbRTWKvxWKtkHtgam8cIZ8Ucz/GwD8/4TVAC7pGdKbhcefnPsPzLA KypQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SQmg/Q4rHRMVb3PQsaYWbcxBdVE7+4OvWNKYENPhpkU=; b=JGAhmFx0S194q3Ga1NYhqdP+rK94XX2YUvGQqUHNuWc51ZbfiXWV4IaJ5TAN2jO68k dqvws51IBkJrGjKyn4SsVFM16Ohg/5uJsA3WCfL1a7IjdYKXWOhS3xH8eR8ky26mh6u2 23EYTvs48xyFDpE0BJG07hUGAWPUlhFVCVAeGcikdt9uLsy6kj37gnv7cJ6vaTexeHZ3 4LvP2pBpAXDFG6bMxC0GEVEDGTukLMBWfSjTUdA0V3KgjxIxBlC6Y0q8+1Kaif3irJCP 06VDDFLuXuvupO7UyQX0HKUfOVQbWPrDsQLf7B/LU+MdVqV22K+cFCu7e/r7I5S/CjsT QLUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WKh3ilgE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa7-20020a1709076d0700b008b9b135aee9si2284222ejc.350.2023.03.07.11.54.48; Tue, 07 Mar 2023 11:55:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WKh3ilgE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232862AbjCGS0R (ORCPT + 99 others); Tue, 7 Mar 2023 13:26:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232844AbjCGSYw (ORCPT ); Tue, 7 Mar 2023 13:24:52 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21FEFA17CE; Tue, 7 Mar 2023 10:20:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C637BB819C8; Tue, 7 Mar 2023 18:20:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DBE9C4339B; Tue, 7 Mar 2023 18:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213211; bh=0ernidC3WHANesMpJRzZFG2rHwt5UJnwsTY6wU8GmKc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WKh3ilgEITf4V+9GPFzQj6/xSj6dY9x1MvbUYNhnBVd0A9JY2ZisIIJSvGxAUGr+H duzfDn1CuzTKFZdAtBX1QIQWUWdv9ql0vqeY1eFFTdN8Fo0Xz8mfgW1FLbgk8bAeNj 46ISxexD/Gr0l0RQNr0yv1wgc49iajLCDYDOYJHWfO7t+Y/ebj8EnJmXjFUH8ZI6Vv UJ/pb5NIzRG/LT3P7GwAwoM09ehRQQgap4cHFrEZMXmbnYI5kXzynp+OV3+1Fu84ww LvFouxSEAofZj16nsx/+irNXDEtZOGiwEADrli5MLVH4qnQHuQT3X4kbrRmi/5roR4 +x8zQB2X2+fhw== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Yisen Zhuang , Salil Mehta Subject: [PATCH 08/28] net: hns3: remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:19 -0600 Message-Id: <20230307181940.868828-9-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759740075431886363?= X-GMAIL-MSGID: =?utf-8?q?1759740075431886363?= From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Yisen Zhuang Cc: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index 25be7f8ac7cd..5caea154362f 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include From patchwork Tue Mar 7 18:19:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65773 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2622562wrd; Tue, 7 Mar 2023 11:37:00 -0800 (PST) X-Google-Smtp-Source: AK7set9pzg2MOYd56SDsJvxDTXQ+1CHW8jGbRrmgJOn4l41GLGll+7kkqgpFXIhbB6l8ggyhFXXS X-Received: by 2002:a17:907:7f9f:b0:889:1eb1:7517 with SMTP id qk31-20020a1709077f9f00b008891eb17517mr19583823ejc.30.1678217820644; Tue, 07 Mar 2023 11:37:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678217820; cv=none; d=google.com; s=arc-20160816; b=ScwzoA5UV9ax11vLjFOoFQ64056ks8kEvSmkYqXedm1zwJuVpx7FKDa0aUIEBOayyD Elg9iwiQMJXsEYqdUe1AZkLKnV3tymLoTxNMERLisCkDd9ChFgSF9i1qaXgX68zRdGTx sWDJcv8cq3ai5pN+xM4NuaSnulXKe/xZI5x2JyUgJ6qTlk2dxag0ga5Y8cE40NndCk2f 4UN2FCNKncRfo9gkVjjsWBydqRJ3d/izeI80hBi/2VMeTfkHcxy2/AXBPdUBSgJaQcD+ GEZYlowKif0n1XNopNhDGc9UmerEYqJXalmKdyywcD3llHBSJBF8Vg/BgKIjcaJrIkPC 2iUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cio+X22vyuFBFAzzvHQ/iWLDcIPQs1BjM7NRU4dvm+A=; b=Q9NFkZnGG4qsvDDvlbOrsuH1wsBA1u/EhyKgmuecWaCSbJxBgDxCF1lRU9AWiJg4cC k67X2Jw0iceIqkcYPHh2UfSUuTKMFk2CWDrJUmeyJF/T7WR5HlPeOVpczo0Di38/6WN/ 5CnGI/Jeeun3VydJlOqVDO17fklooMd2uxsbOzrOVTvNh1FgCtTJ0f8fQcq0KB1eWN0p Wi3XGnlsPrrH1S/jtIYxb12Fmls1w36XrsnpuFzkV3YPxu/AIb6pL/Z3aCXZQIyxsTTJ 8zjSkD3WvZfgU4oYd3+hS4zjA/hzP0bShB9jhXs52ngBLMRwmHkUUL6U2880Riz4uxt4 cDJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tRnUrsPu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l9-20020a1709066b8900b008c5cdeef470si2347341ejr.560.2023.03.07.11.36.35; Tue, 07 Mar 2023 11:37:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tRnUrsPu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232840AbjCGS0O (ORCPT + 99 others); Tue, 7 Mar 2023 13:26:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232850AbjCGSYx (ORCPT ); Tue, 7 Mar 2023 13:24:53 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABE37A80C4; Tue, 7 Mar 2023 10:20:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 16E2661501; Tue, 7 Mar 2023 18:20:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C344C433EF; Tue, 7 Mar 2023 18:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213213; bh=f2vDXDF6d70nczotU5xFMm8fkVvPCcrdAaiTn10Iyl0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tRnUrsPuNk+5S46oLbNEqQe9aTovqlD45J+8hXGeZDlNrPkHEsr/i6cBUHzO/A+yp CpboaFpgpThprgVtfS970fS7spbUwedUzYIW+MdqLwNCGa7gUShcfuZo+VzcCM7siz fL3bFEvFjDN6bKah7zK1qrXXgXZG/zbpAwQPr1Jz/5ZYcnKc13So5WRVO33OnjFlxr 6IgFl1Ov1Q94ls+5blZ7VetzcaFyHcISVsNwKV86KGAljoFfUnRUycAHPZDB0RCd2Y eeqnzI04lr7XL0l1vwMRKiUEj7Ijp+CelZuTwsSvRARqUPplZBxNGiQKNrLwPeGDhq oiZRzU7O9O72g== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Manish Chopra , Rahul Verma , GR-Linux-NIC-Dev@marvell.com Subject: [PATCH 09/28] netxen_nic: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:20 -0600 Message-Id: <20230307181940.868828-10-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759738929440966844?= X-GMAIL-MSGID: =?utf-8?q?1759738929440966844?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Also note that the driver only called these for NX_IS_REVISION_P3 devices, so since f26e58bf6f54, error reporting has been enabled for devices other than NX_IS_REVISION_P3. Signed-off-by: Bjorn Helgaas Cc: Manish Chopra Cc: Rahul Verma Cc: GR-Linux-NIC-Dev@marvell.com --- drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c index de8d54b23f73..59d0dd862fd1 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c @@ -18,7 +18,6 @@ #include #include #include -#include MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Intelligent Ethernet Driver"); MODULE_LICENSE("GPL"); @@ -1464,9 +1463,6 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) if ((err = pci_request_regions(pdev, netxen_nic_driver_name))) goto err_out_disable_pdev; - if (NX_IS_REVISION_P3(pdev->revision)) - pci_enable_pcie_error_reporting(pdev); - pci_set_master(pdev); netdev = alloc_etherdev(sizeof(struct netxen_adapter)); @@ -1603,8 +1599,6 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) free_netdev(netdev); err_out_free_res: - if (NX_IS_REVISION_P3(pdev->revision)) - pci_disable_pcie_error_reporting(pdev); pci_release_regions(pdev); err_out_disable_pdev: @@ -1659,10 +1653,8 @@ static void netxen_nic_remove(struct pci_dev *pdev) netxen_release_firmware(adapter); - if (NX_IS_REVISION_P3(pdev->revision)) { + if (NX_IS_REVISION_P3(pdev->revision)) netxen_cleanup_minidump(adapter); - pci_disable_pcie_error_reporting(pdev); - } pci_release_regions(pdev); pci_disable_device(pdev); From patchwork Tue Mar 7 18:19:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65772 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2622319wrd; Tue, 7 Mar 2023 11:36:27 -0800 (PST) X-Google-Smtp-Source: AK7set+bBrhF9W9hPpEdj9SKoXbMOQpq7BQx8RLQOnG/GECGJ1TCiH359wlCdoc9CUGhfbHpFXL2 X-Received: by 2002:a17:907:787:b0:8b1:7de3:cfb0 with SMTP id xd7-20020a170907078700b008b17de3cfb0mr19868626ejb.2.1678217787537; Tue, 07 Mar 2023 11:36:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678217787; cv=none; d=google.com; s=arc-20160816; b=d77NIWrKAGTf44dEQUiJq+IQnXqXcUGu4TvekmtTk5NTKFB/V0QZJXZedpniYUciYX RUNgdpCKO5nAtVAdzuqwtagKn0OEDYw0TLza3jAh1FCIUoWSxcZtM9n3fARnZNuCic5D sNI1+Y0iztfHzrI6iN6vKKd3SVfQP3zRXFKjBUc0c7gtnlyMqd466M38K8CNmE3nMqbA +9afjxWNLZ7eZOc91kiccCouH/d92VmuXUucRtF5KW50M8JwZ94hKjx10CurXI5/ADkN paiOJrkcwKhH1SBWeASyW3NGnqpmxlrcHgOBIZI0xAVp2fF6s1W55iayJvw+Hh1Wglbv f4nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eYbdSpRaS9ua6J7cmmlFhC7lc8UgjnN03p16LGO24/I=; b=CM0HSMIu63BpOX56PAN496qh2caDWKB220Oi6Z2E+G/Gh1q5GmcRhvAZDNGkOnPMiR GPxhtO8IOPiB0+cqkjD2NEc450CcpWnDMLbeIl3p5tOx+oIttoiBqe2W/n/cI0A8SJLH N67fNgY1epW1JgGmIiKKbTMNRuG4vKCdAfNVP3yP4pCEnACpjsb9XFDzEl+2uVdEOnO5 hUH1kHBM0OYVJ1H5+hfua8zMBZkztRiM7ITebR8LXPZyvjMBQWOmAXxvAPgrUhf7/buU NxwU312snq8ME4vrsKqI6AhL1Thgr1r0XhocU65AxR6xqRdwTMjOVZ3tX107MfBrNzgW 2ZpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ko+uUQc9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f13-20020aa7d84d000000b004acc6c2a27csi15241927eds.53.2023.03.07.11.36.03; Tue, 07 Mar 2023 11:36:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ko+uUQc9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232923AbjCGS0m (ORCPT + 99 others); Tue, 7 Mar 2023 13:26:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232674AbjCGSY6 (ORCPT ); Tue, 7 Mar 2023 13:24:58 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0124B9E07F; Tue, 7 Mar 2023 10:20:17 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A3189B819CA; Tue, 7 Mar 2023 18:20:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DA27C4339B; Tue, 7 Mar 2023 18:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213215; bh=93zuo2kl6zHOilprDZc5m0GhVopCd4gNUJYuchTiEY4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ko+uUQc94uPwcEVpwuRsVJiAbkjor+5PSV+nzZXkf3hxd9/IZOQcAlg8MTrFnC5yj aR07D0LlmHcMbENz1E9G3tMu3T2wwVAlqiyOE6UXiaXQrsKcsqeo4O1wtRK6UBhxav 8IA6KOPQ4sgDctnHyKQbx0f7KAOm9sA+iE0LlyQYjn3Ne7n8suhLI6QKb81DZxFFmV qsjxjhlbiEb6BeFBPPbAhTItlq3vgkh44cKDbmkekcTlQ6+sVoYd0GLow1xfNwch8K nTd7UQywXajTfcubGcLM85HEBX2EKQ91T1i51N/5fyLAJ72x3GQmAJka/uwqU6h/Yy 6E9XDYSrpiOtA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Veerasenareddy Burru , Abhijit Ayarekar Subject: [PATCH 10/28] octeon_ep: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:21 -0600 Message-Id: <20230307181940.868828-11-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759738895074275057?= X-GMAIL-MSGID: =?utf-8?q?1759738895074275057?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Veerasenareddy Burru Cc: Abhijit Ayarekar --- drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c index 5a898fb88e37..fdce78ceea87 100644 --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #include @@ -1050,7 +1049,6 @@ static int octep_probe(struct pci_dev *pdev, const struct pci_device_id *ent) goto err_pci_regions; } - pci_enable_pcie_error_reporting(pdev); pci_set_master(pdev); netdev = alloc_etherdev_mq(sizeof(struct octep_device), @@ -1106,7 +1104,6 @@ static int octep_probe(struct pci_dev *pdev, const struct pci_device_id *ent) err_octep_config: free_netdev(netdev); err_alloc_netdev: - pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_regions: err_dma_mask: @@ -1139,7 +1136,6 @@ static void octep_remove(struct pci_dev *pdev) octep_device_cleanup(oct); pci_release_mem_regions(pdev); free_netdev(netdev); - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); } From patchwork Tue Mar 7 18:19:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65806 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2628691wrd; Tue, 7 Mar 2023 11:51:50 -0800 (PST) X-Google-Smtp-Source: AK7set+jeYGcMhHldEmZJTF8TmAt73FJpCTYHIFAyA+ynStoqgsAVNq6AqoiwWJv0qbLKUoV78Fs X-Received: by 2002:aa7:d153:0:b0:4ad:f811:e267 with SMTP id r19-20020aa7d153000000b004adf811e267mr20834344edo.12.1678218710217; Tue, 07 Mar 2023 11:51:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218710; cv=none; d=google.com; s=arc-20160816; b=jMUaXbzVFnma3bJne9uPNw/0gKA/QpDLm9Zdjz8gEqZRgOFAiF1HqNOWIgukUdi2HC kapBARn3fS2RRq7fdwQJoAFKquc+YH+IQyDW4a5ZPlIVoDgGv0ZfsOhYSbgL0N+isCZt hdLcpBc6jXnDc7wURcQKUt7YOsyjsOy2nhqRUZtdGAAwnkE4na0dQlu2ioUYiwLp4G4c QCSBQTp1hZ4Nb4jAUZXXTEc9jpgHl3A1JlQDIMuZq424EicCyaf3w6C4P84r81qVf0NX 2jw3I22YvBz51lY/PZIvFp86wFQYxS8NcAtbXKdYHOCbE667KnT2RcXKKikP7gVqfDnm 8ydQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tkijDyz88gGuaBzYHYV7DL5Xx/TX3Xa6AANmo0nSPbw=; b=oSoBM4j/vqMVg3NmkL5vNu6p6bFNyk4+q0SVW3CJ4CX5ggD/Kc+9mcs9jUBLRE1XQD 4Dth9j9hiuyM5EJ8X3aUuSFHIx6qPGDG32kGAYm3U8OvIwtI74JJln7pojDCn4VexQ+F MpSD9SZmJsq/w8SzaQLzc2bYw1M7wibk23fyWBtBuv3z8DP5NZE7LMB9IixR1ZxUKlut liUA24ognHAuYShsn3aNz3gxMG62rzRDY6snmg3h8abB7dlI9OV8yivSseSVhz1pQL8g KNzgktAik7F4bUhDgi/K3o+eMWp38l32UNwnrkrVsV4EdIO0z1bSLS62yu4oxmmxNoUy mhXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tbVVdSND; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m6-20020aa7c486000000b004acd42c5911si847027edq.241.2023.03.07.11.51.26; Tue, 07 Mar 2023 11:51:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tbVVdSND; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231354AbjCGS0q (ORCPT + 99 others); Tue, 7 Mar 2023 13:26:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232753AbjCGSZC (ORCPT ); Tue, 7 Mar 2023 13:25:02 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0BC19F222; Tue, 7 Mar 2023 10:20:19 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8BBA2B819BC; Tue, 7 Mar 2023 18:20:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11B48C4339B; Tue, 7 Mar 2023 18:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213217; bh=tD/0BL32SiQcpNBmJHR6772uCW+5TraI1VbasTgz7rU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tbVVdSNDnyNV49AyShaP6RIuX1dc5dxxhIePy1arx73pACarVWRbwCfM1jfpqnXQu 160kKUUktsg7XBwBwusGMhIyVMTuBc4j5yq8pknrVfUG7/g6+WzDlulcM56zHr1Fdd BZmfK0IGTd2iiQTrmZJZRxNI12ecHDoKgWt03lqBelb3xw0FZQRiwNAsJKGkrTbssp opCb+2SGJ2a5M/my0pxbUbT9Ln+2xNJffl0yj7MKKnSYnIF9p5rlxWol3NUNZc8isl D/tr/imA2CMJu2WJRxn7pHLTFvPeQ2TQAr0CfXZPXhKDCNxgliFqSbfC9Eeb8e/eFA gBfquTrK3fw5w== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Ariel Elior , Manish Chopra Subject: [PATCH 11/28] qed: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:22 -0600 Message-Id: <20230307181940.868828-12-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739862307153286?= X-GMAIL-MSGID: =?utf-8?q?1759739862307153286?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Ariel Elior Cc: Manish Chopra --- drivers/net/ethernet/qlogic/qed/qed_main.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c index c91898be7c03..f5af83342856 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include "qed.h" @@ -259,8 +258,6 @@ static void qed_free_pci(struct qed_dev *cdev) { struct pci_dev *pdev = cdev->pdev; - pci_disable_pcie_error_reporting(pdev); - if (cdev->doorbells && cdev->db_size) iounmap(cdev->doorbells); if (cdev->regview) @@ -366,12 +363,6 @@ static int qed_init_pci(struct qed_dev *cdev, struct pci_dev *pdev) return -ENOMEM; } - /* AER (Advanced Error reporting) configuration */ - rc = pci_enable_pcie_error_reporting(pdev); - if (rc) - DP_VERBOSE(cdev, NETIF_MSG_DRV, - "Failed to configure PCIe AER [%d]\n", rc); - return 0; err2: From patchwork Tue Mar 7 18:19:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65797 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2627250wrd; Tue, 7 Mar 2023 11:48:12 -0800 (PST) X-Google-Smtp-Source: AK7set8Php6joFCgWwDD+bzVwoj+kUquSZtdlyKakEdPbNskvMNy8avS9KrKzQNogYK8j0Cx3jkT X-Received: by 2002:aa7:d714:0:b0:4a2:5f73:d3d2 with SMTP id t20-20020aa7d714000000b004a25f73d3d2mr12653086edq.41.1678218491924; Tue, 07 Mar 2023 11:48:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218491; cv=none; d=google.com; s=arc-20160816; b=HNk/EhWSEpMxnN37gNgCrnueTXQ9qcewsz6kNkffHHWlP5d8AwSq/4550Ani4Jn0MZ 6jDlPozzdofcJudf+K5F0e5/8jm2iQxlOwf0nkr8r4KDIR5c1r02sgng3D9MYQhEsAOn TSgQhSS2hKlNGsmtJCPZ1gcCMHicnwLQVJNd9c3UDe6J2nA+6wJBbvYF35HhQPFS7fYj MbfkTvZM1gLlNdWdAVbUu0XPl/8RirbRBHDObE8B+pYWDpsrM3Ch0ZXLOV7Wah/w4wKQ nMfgBw2AOHvJScZxM4FhN1Lv3rhItqdI0BDxg2h3KFOu5N9iusNV0PruRVf/Er+c8D31 Nzkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=q0lXnNRnCpKVT54GDtGK05Ni3mNhmMPcjIPQkVi7zCU=; b=KIpzxOV9n8nGUPkZYvF2h2XTfAWIDIhQVh0bU7f2Q3hhT4SEexzs8G88JVSCLp0IWp Dlh45z1yST4tlI8pqRK4O80bK/89VD+oSJjQEAYd2CTkzjKTnjsGcvcdi4mcEBK+c9cI CCeDZ4byyiMBqi3xsw2HArvCXNLcsg2pHzmpk3cgvfUX14QhM8oQ/PlHnBbXOZR42Jkd kquqgfRIaZqvOP8ml9tApJMp+LQ3iTPJjOkPSzjTdwXlm6ODcLHInFokmBYFEz18+FZT 5SZskfwi6ho0KAPOTWcylFxRfHozIstS6WdAdaD0o5UzzmQhA491vDdrfix4u1ZMQdYp NUFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MiduEHmu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e7-20020aa7d7c7000000b004eab3b519b4si4529764eds.207.2023.03.07.11.47.48; Tue, 07 Mar 2023 11:48:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MiduEHmu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232942AbjCGS0u (ORCPT + 99 others); Tue, 7 Mar 2023 13:26:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232796AbjCGSZD (ORCPT ); Tue, 7 Mar 2023 13:25:03 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 166719E06E; Tue, 7 Mar 2023 10:20:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A6A4B61547; Tue, 7 Mar 2023 18:20:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6101C433D2; Tue, 7 Mar 2023 18:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213219; bh=3XOqJB30BJgwfczGzN1h2VGhOkqWll+o8F8lUQkfxtU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MiduEHmuL9TPEds9Mi8QibiWXzCXEUKMMF9zyTW3XO3CfudMIl54AZZU0VhAT+ISb TWj5afUVPz02pDsz+D0SAKkfL0RGJiTUFFiuwIPp/HiL00X3VaZwEWO27gLWg3Mk1w cnNDPGkNhTjqSgZwYnr1aQDZZnrn0m8vS8zeZgJyidDryghzga9r74FLRywivZjnBy UzCJi8B+yo3A2XGnurGSF/CL+sNl7I2qIv0X18ruED+rBCBS1D7T9cofuiNC4nZYsa Gnv5pLvyOFr85+42aoiHLAWb8EgISKifXwWQYw0CIrZADMa5fX1s/Bazh7X3cM6Bi0 4xvfLxeEaiikA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Ariel Elior , Manish Chopra Subject: [PATCH 12/28] net: qede: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:23 -0600 Message-Id: <20230307181940.868828-13-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739633689490979?= X-GMAIL-MSGID: =?utf-8?q?1759739633689490979?= From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Ariel Elior Cc: Manish Chopra --- drivers/net/ethernet/qlogic/qede/qede_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c index 261f982ca40d..4c6c685820e3 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_main.c +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c @@ -35,7 +35,6 @@ #include #include #include -#include #include "qede.h" #include "qede_ptp.h" From patchwork Tue Mar 7 18:19:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65783 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2624640wrd; Tue, 7 Mar 2023 11:41:38 -0800 (PST) X-Google-Smtp-Source: AK7set/Igum4PLxk9ZrNRBmDb15DeQPvw1t8x74DvIl93MA89i0PLiT9/QOphcWQhLU5oFXC5q0j X-Received: by 2002:a17:906:6882:b0:8b1:75a0:57fa with SMTP id n2-20020a170906688200b008b175a057famr15268875ejr.43.1678218098787; Tue, 07 Mar 2023 11:41:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218098; cv=none; d=google.com; s=arc-20160816; b=EkBUGl+mqlO5wp25VQc8IMAn0A5twEaM+yz4Re/js4MBaS9JQLKop720eAIZCkDHF2 P4ZRaNHH0TuMDeBnfTPHkTZJ5iwxfUOUJnNkpC5SUkd2OXUeq/YsNOPo+yEL0nwTqhS/ EyF0NvtM5VHOiBOp89bHebRK7W4nO6bq8HODvRWhDbfyFzdi7Wza7b5aZ9DPutOxOInB OZ7lq1b5adOv/kEEp81NnWH5d1crPLMTFs1dWR96ZZcV9yE71eGnxHNMmakPldp93iHt Q1nG180LS342dXAnx3m4PFfMnV5hMkMt3zM8HSyAoV4bGew7Mq6ZtRk/5Xmsf0rrZbnJ liyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=h9rw/zutkdnBDp5gXiOieOfo7ykSModMZ0r6RDDsJqM=; b=WFqfcyENsj2aWlKcJWPNbMPhfntwAFIxgMtD/+ucFzepnC1qdC8AiQKNQr7MsF6FLi 9kFA3z5GYAPHz25s11bmeI1pldLpKAT+8Owyj2X6ZUyeWksPJjVg+atKF61sPn7rWEX4 Wb0nfbM/khHHYhlbEH0zV1zSnszmeTcknEe/3GAwNU48E4YC11ilroGDt298wFSBVJJa Bwd1uJtBWNfSy7mQ6y00BzTsyS7wBdjc0A/jrbvsiJ9gX5APIEu0+BFhviW6rZUWZcFY FgstOzmm4Odn6Ti11WIFOJJ0KBZzDG066FPVI7J8I855BInyydjN2LAoAjPNmw2zRZCx zSqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NotFv3R6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd17-20020a170907629100b008d0d82ecd2csi18342605ejc.353.2023.03.07.11.41.15; Tue, 07 Mar 2023 11:41:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NotFv3R6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232955AbjCGS07 (ORCPT + 99 others); Tue, 7 Mar 2023 13:26:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbjCGSZo (ORCPT ); Tue, 7 Mar 2023 13:25:44 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 642419FBE2; Tue, 7 Mar 2023 10:20:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id C64ECCE1C83; Tue, 7 Mar 2023 18:20:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCD57C433D2; Tue, 7 Mar 2023 18:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213221; bh=L40C2NsmiT5sjeEnSWj72p21BipE9CnM7NZNqckWFdI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NotFv3R6nlW7TCPqWDdY++YMdVT5NNa6K3LpUqhjc9F15D09eae85fK2IH7rxRvOF EoIEWTJdKaQ1sD/+c9bz90rBjuM5AURrPtAM1s3eGbg0zWJyan4JLJR+k6Ds576KwR eTW1Qn5CFfp8cICZ9up6ubCga1a2/wAOs1TYYnrLM2lWxGHAAVtD0C/01BtTR1bH5H do5sH5r1gzpIFPT6N2YUFIIJAQkWfU9ZThVYwmWmjvdneE7blwmHfsLdRcLMkFqQF4 WvrdReCZOFIftgVA+q1Ud/VrX+U38z4VAUSFS+GDejUSLKUBlePDNS/1RW+WVqjsOL KfC6hziMqAr/w== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Shahed Shaikh , Manish Chopra , GR-Linux-NIC-Dev@marvell.com Subject: [PATCH 13/28] qlcnic: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:24 -0600 Message-Id: <20230307181940.868828-14-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739221148176418?= X-GMAIL-MSGID: =?utf-8?q?1759739221148176418?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Shahed Shaikh Cc: Manish Chopra Cc: GR-Linux-NIC-Dev@marvell.com --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 4 ---- drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 1 - 2 files changed, 5 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index 44dac3c0908e..90df4a0909fa 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -2445,7 +2444,6 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) goto err_out_disable_pdev; pci_set_master(pdev); - pci_enable_pcie_error_reporting(pdev); ahw = kzalloc(sizeof(struct qlcnic_hardware_context), GFP_KERNEL); if (!ahw) { @@ -2675,7 +2673,6 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) kfree(ahw); err_out_free_res: - pci_disable_pcie_error_reporting(pdev); pci_release_regions(pdev); err_out_disable_pdev: @@ -2757,7 +2754,6 @@ static void qlcnic_remove(struct pci_dev *pdev) qlcnic_release_firmware(adapter); - pci_disable_pcie_error_reporting(pdev); pci_release_regions(pdev); pci_disable_device(pdev); diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c index 5c2edb715d3e..74125188beb8 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #ifdef CONFIG_QLCNIC_HWMON #include From patchwork Tue Mar 7 18:19:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65808 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2629079wrd; Tue, 7 Mar 2023 11:53:00 -0800 (PST) X-Google-Smtp-Source: AK7set+voBD3Xdd+aGAAIe/FngMB+3lajmwgqb/mJVurZOc/JmKdcydGP0Tv5crzycY6g/nBqRSe X-Received: by 2002:aa7:d7ce:0:b0:4da:3362:23b4 with SMTP id e14-20020aa7d7ce000000b004da336223b4mr9292254eds.7.1678218780267; Tue, 07 Mar 2023 11:53:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218780; cv=none; d=google.com; s=arc-20160816; b=saRi+fOxcBlk4pUf6PFgVPvAvatTNFNSUW7WDxepj4WfvzVRi0QwhPWBxI9Y7bfWVY 0AiYWpz5TP901Bde7stksar16spVO39Hak2MjFAjpcO3ayfQonzeKAyMa33k2XsfV/MS pgoY3j7G08SISXnCmocE0ySKpfcCKgLFTK6wLG90Iuq5/CuSAJHr70vxkgDlZuPUef3h ho+9f5eB+Q2hiosCPKqFPWzpJuVMpjCDxHDFtAZDWn//MdY2084xtGD4l/VYvigNV/in lnLCHff5hxORZlyP/OqoMFSCXGokkCNGdPNYNO2wytmPg4LEDod+5uuZeWgRD4XSpP35 HKaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=otW3xB6bz1mZh/D3I+DyNMplThuMnLabnu19mHvAMF4=; b=JFObT1hyixOI/9eQyA7JRZs3FqT9R+7Jl6lnlDdoo7WoKHEjkFEQY6f6q9h3FEOdhM nTSlRGawR4LlTVQ4+rC1RNueqAtorcC1mAYbKg3xCQsDkNdoyRwRlEgODF3z05OjwljW u9QME5K9Cjj/JcCRM1Fi4mIvK/AZ/dIDAOXs6e3zOLHybJujuQMJShpNkVOAYsbgKJNF FxlUX8z8LNTudwaxUye/1ZsN1x+0QAgSumZfRbxC8cF3piT0/1ZbtB6JK7t2gd3qyLqq aTjtRCuIpAXoaIHGtPJptz3OzC4ZOJP/91Ahl4mC5skp92PaT+A3GvgvO2t0IDM4mTxS PMoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JV20MAJx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i25-20020a056402055900b004adbb59bc8fsi836056edx.16.2023.03.07.11.52.36; Tue, 07 Mar 2023 11:53:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JV20MAJx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232950AbjCGS0x (ORCPT + 99 others); Tue, 7 Mar 2023 13:26:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232802AbjCGSZT (ORCPT ); Tue, 7 Mar 2023 13:25:19 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1534AB887; Tue, 7 Mar 2023 10:20:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5C329614E8; Tue, 7 Mar 2023 18:20:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98D86C433EF; Tue, 7 Mar 2023 18:20:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213222; bh=QMLEgpaw8nuZ6gGVRznNtZSpSJ+P4AUFwKxnyhEIEx0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JV20MAJx1+Mp0pF7KL5BlWv1VBpcsNNpK+9ewQz9hnI1Zn5ZLJxQ2zDgEdN88HKjR OitjgHN44LH/rYijVX21kHE1BU7qFGNn5nSubeZrCAEkbvvyx/T2lrkmWJiap4Y+qg Gt7ei5QGLGmfDvCCaPnwZE7kOeH+cRWkhltyGJf8WZdhgGe9bk8VfoE3S8lCPXBFmx XMNdgLABg9ivWoB50njnROAY6hmg+GgitTIcLp6XMOO5zQjuNMwxLLTLY4LByp/C0u uC+ipSjJvDXp5bpfky1Ggbu3Kx761rC2wS45eXtNjVsn/WPRsmMhfjfj56KxTWd72o LRAn/dAytZ1YA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Shahed Shaikh , Manish Chopra , GR-Linux-NIC-Dev@marvell.com Subject: [PATCH 14/28] qlcnic: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:25 -0600 Message-Id: <20230307181940.868828-15-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739935889403856?= X-GMAIL-MSGID: =?utf-8?q?1759739935889403856?= From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Shahed Shaikh Cc: Manish Chopra Cc: GR-Linux-NIC-Dev@marvell.com --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c index 2fd5c6fdb500..bcef8ab715bf 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c @@ -8,7 +8,6 @@ #include #include #include -#include #include "qlcnic.h" #include "qlcnic_sriov.h" From patchwork Tue Mar 7 18:19:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65800 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2627441wrd; Tue, 7 Mar 2023 11:48:39 -0800 (PST) X-Google-Smtp-Source: AK7set87V94VVDEgverQay7GkpoZL+tekqIOz6q0mAer1jrMZtYyCv+25Hy5koSCjooCRfC7Gf6W X-Received: by 2002:a17:906:a08f:b0:8f8:35c2:1357 with SMTP id q15-20020a170906a08f00b008f835c21357mr13985994ejy.23.1678218519290; Tue, 07 Mar 2023 11:48:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218519; cv=none; d=google.com; s=arc-20160816; b=xqYNmNOOlkVrEjp96mRUkisBU84GZH84d/2pDDT8Vf4wbpX2TVMMUmxdyfP9hQzfmf YifZqH/QNwW3qV7hvE0zuHou5I085mYv+GHltKX7C+mhieJJ77fMG2V0LAA8cRGQ+nLc 6eRiKGKeNx4CSWqDCFpnNZMRxXik2aRBVoqqDAbYSYH3iJ5c2fcAZQYBWF+t4gHUeSY/ P3NJXVPJulmnwHCnIEew4lEZTfL8tRXojAvjTNrzjxWh9UxlkVxL63EdxPjAaK12iAN2 AAglHmympVd1TjLca3tQD/8+sYCDAxMC41qSZuODMX++6ju2cRFyZUZ9+WZwb7l6f+Hd DT7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=K4O6LjBOkW9xu/Evs1nbmxX6sqlCi5DoY43f1x9aKqw=; b=YJRwclyj/xBIrGo+0O8LVvCjjmKdXBa9hhOvby+5HsLTvfkZCcLy9ifFkrUAM6YLhO OM1X+DUU2qlAXIqhwhTWd1YjAIypNXEefUVzt5uiK8Vqi7Y8qKSeEdXNbwBPH6FUZonY ydAgjfuIpfdU8dt5MPlUxLRcl99Ly5M6F9XjLheiElaqbwXF/IqYjqiRxxr842WJRZox bCp/qYOm0snJO4uG8kMTHYmE+uaqIRFgOqqPIaUKxsje3TGkJYOgLvJ8FLCCs2TfnpR6 gtef/Xsm1jSx21pBQb61n0PsAowY5O4inMxUn9N5kXQfrwR27aGSmVITDxtfjD+9SSwq w36w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="JQdBO/Vo"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k23-20020a170906055700b008e10c06e930si12455372eja.549.2023.03.07.11.48.14; Tue, 07 Mar 2023 11:48:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="JQdBO/Vo"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232966AbjCGS1Y (ORCPT + 99 others); Tue, 7 Mar 2023 13:27:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232759AbjCGSZ7 (ORCPT ); Tue, 7 Mar 2023 13:25:59 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42F93A92ED; Tue, 7 Mar 2023 10:20:27 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E7C27B819C8; Tue, 7 Mar 2023 18:20:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64066C433EF; Tue, 7 Mar 2023 18:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213224; bh=R3qhJIRBpujHIxRFlynDnmucTd3u0pBuUk2cqVlrcQY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JQdBO/VodaUeYxo9roFtmtJ//orvmW8XFYRtfFtrYAh4dq05C9J9VWZ/NKLbQAEU5 2fNXtH9thudx4KsqU+3+Ry0Vt/fHx6r5GJzLRg6vqxeNJ/NH4Y0htjfEwVAbKwcO40 MbyevcC2iw80VCIXqVarhgTxPuKPjxiOHcPcWWsrXQ6PjLK3Ce1dKzjK0a9KDgXxTz rExNzLW8lLrZuNUPpnyJG8s0NC7nrW24ubAef0PiEpCTKiicbsa+dE8gR2MW8vJ6Q6 Q96N4xCmovWntbI1A/X7jOg/25Z/ODNB3Y0Vs6eWEwuQIG2fAhKgrHtEBr/KO0HRY3 g8nyZdqMwIHHw== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Edward Cree , Martin Habets Subject: [PATCH 15/28] sfc: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:26 -0600 Message-Id: <20230307181940.868828-16-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739661913022285?= X-GMAIL-MSGID: =?utf-8?q?1759739661913022285?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Edward Cree Cc: Martin Habets Acked-by: Edward Cree --- drivers/net/ethernet/sfc/efx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index 02c2adeb0a12..92c390ec4735 100644 --- a/drivers/net/ethernet/sfc/efx.c +++ b/drivers/net/ethernet/sfc/efx.c @@ -18,7 +18,6 @@ #include #include #include -#include #include #include "net_driver.h" #include @@ -892,8 +891,6 @@ static void efx_pci_remove(struct pci_dev *pci_dev) free_netdev(efx->net_dev); probe_data = container_of(efx, struct efx_probe_data, efx); kfree(probe_data); - - pci_disable_pcie_error_reporting(pci_dev); }; /* NIC VPD information @@ -1126,8 +1123,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev, netif_warn(efx, probe, efx->net_dev, "failed to create MTDs (%d)\n", rc); - (void)pci_enable_pcie_error_reporting(pci_dev); - if (efx->type->udp_tnl_push_ports) efx->type->udp_tnl_push_ports(efx); From patchwork Tue Mar 7 18:19:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65802 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2627802wrd; Tue, 7 Mar 2023 11:49:27 -0800 (PST) X-Google-Smtp-Source: AK7set83xTDMxL/rS0JDBsbDDHW6ZNOE7QWx+l11nlgS6Jy1+QRGOjROpTiju4p8ov9t0XJhXOWZ X-Received: by 2002:aa7:d8c9:0:b0:4ae:e51e:6956 with SMTP id k9-20020aa7d8c9000000b004aee51e6956mr14979394eds.13.1678218567548; Tue, 07 Mar 2023 11:49:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218567; cv=none; d=google.com; s=arc-20160816; b=WeSSfiGaZ3WYk9F3o8crRbm0GtA8as7RYpcD11UZQy9upr1Jw+zjjoPQ2L+sL0ZkIb ObKar043qXHfCkoHVbbdwiRJdRxyJFh5Udv2PQD9hJCC2x+45JMVytSUBZVIirUxNPZw FRqUfeRDiBQSI0gj2Zr9ArGEWrQo0psGlhxA2oHqXhIIQmtCxxQiN8vyJicA1usDGoS/ cjH8D6/rJ32/iP1PwObDT25WMtZIdjCY1rqjOWT3WZKe2dJ290fAS+Jt3F0nCZN+HiEa Uh6xb3HzryUsAY2IznbBMS/lrLHwengWRhJD14WNbAKTAOX+O3onYu7yX6UYgghD/Byy 6Xzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4rQ/0rShzypEvADtwRPrKnHQUzAJ2MlPath0pOHexmo=; b=rlZpo8hJxXr85n0Hbt0q3NvEk+dL9TsC6g4reZW9Icvu3YoAWLjVVYAzSKHW7Un/Cp /4QjX9hIJj5FV/wWAHmon0o5z6LoG/nvoRSO14VQm3PXAxfk6rzI+yTqG5pC9IUTFbKt m9il7o2S3A/+7+tVo2C0jY/ulPdiOsDpRKowmd9gt5PA4FRlH2WxFmRPcAKqxnX3KuEr dY3piHQpvUZX3/hc8pE8o9IbwdypXnMcM8FRfAaJLst1JAU6k0lCu1mpiKm9hWw1h8Ty 8OjfXhNMVVNwCRG5qpAY2R4BjtZ8Efe1Cj6MAkxnX8rDpOUvhnEPIDytxUCRVVa/DNGQ IYAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="U/iNN/ME"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i25-20020a056402055900b004adbb59bc8fsi836056edx.16.2023.03.07.11.49.03; Tue, 07 Mar 2023 11:49:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="U/iNN/ME"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232976AbjCGS1f (ORCPT + 99 others); Tue, 7 Mar 2023 13:27:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232823AbjCGS0B (ORCPT ); Tue, 7 Mar 2023 13:26:01 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70252ACE37; Tue, 7 Mar 2023 10:20:29 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 14678CE1C84; Tue, 7 Mar 2023 18:20:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38645C433D2; Tue, 7 Mar 2023 18:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213226; bh=ZhMyDhUa2wqpQV2qFzBJe9Bn0s90CRl6l0idvIIy614=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U/iNN/MEM38r3TpbO3a32aOojVUyAcscuHqhahJvXh71+RHJpwweWGVD6q3Mg+o2F Z9wcvNU9fqx+RTValM70vDw5VNi8ne/7TEQJouBFnInEI4hJ1wTrEGlZJomfWYFNGV FyYO6TRnZTxA21V6nVdVNsXF3RRMBWEhzhJPb/V9EMMguj5xcp5RXTvQeH0BB77ASV 9VHzI0VkN3omP/++/0W7ZT/KDCO+9ilYihy6IK79Up/8mAgXRH4mGLR7qkwgPkALX7 SwE+641OrY4irDI3OXyMtWJX91xbtUGUUL60KGtDdXy4hQ3JkeAqOL1CmiO5EyY9K1 sG/apuFGQmhdA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Edward Cree , Martin Habets Subject: [PATCH 16/28] sfc: falcon: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:27 -0600 Message-Id: <20230307181940.868828-17-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739712693434665?= X-GMAIL-MSGID: =?utf-8?q?1759739712693434665?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Edward Cree Cc: Martin Habets Acked-by: Edward Cree --- drivers/net/ethernet/sfc/falcon/efx.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/ethernet/sfc/falcon/efx.c b/drivers/net/ethernet/sfc/falcon/efx.c index e151b0957751..e001f27085c6 100644 --- a/drivers/net/ethernet/sfc/falcon/efx.c +++ b/drivers/net/ethernet/sfc/falcon/efx.c @@ -17,7 +17,6 @@ #include #include #include -#include #include #include "net_driver.h" #include "efx.h" @@ -2765,8 +2764,6 @@ static void ef4_pci_remove(struct pci_dev *pci_dev) ef4_fini_struct(efx); free_netdev(efx->net_dev); - - pci_disable_pcie_error_reporting(pci_dev); }; /* NIC VPD information @@ -2927,12 +2924,6 @@ static int ef4_pci_probe(struct pci_dev *pci_dev, netif_warn(efx, probe, efx->net_dev, "failed to create MTDs (%d)\n", rc); - rc = pci_enable_pcie_error_reporting(pci_dev); - if (rc && rc != -EINVAL) - netif_notice(efx, probe, efx->net_dev, - "PCIE error reporting unavailable (%d).\n", - rc); - return 0; fail4: From patchwork Tue Mar 7 18:19:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65818 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2630469wrd; Tue, 7 Mar 2023 11:56:24 -0800 (PST) X-Google-Smtp-Source: AK7set8fzO+3QXeXq9LPkG59w9bpX1wtaeZrWji0RZslj8cn0MC8JdBe2taekFGhcmJGjoyTTb9V X-Received: by 2002:a17:907:2be2:b0:860:c12c:14f9 with SMTP id gv34-20020a1709072be200b00860c12c14f9mr13462480ejc.40.1678218984679; Tue, 07 Mar 2023 11:56:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218984; cv=none; d=google.com; s=arc-20160816; b=DQZLFKrOaJZ33e3/tH1UHuYTDP64daWv9QGIrYWlHSs/lxhujHABkLznHmk2Qhh4NC 3bXgXfWG+m9NVHvzqnPqPHWQFMg46kynyECxpDDi32dIbCbW7FVLHngaHXLyoDRFGHi+ hY/3tOspWJaTrSSUOLQwczpjGSHI1/fLOCqX2VwAvYUOEwZqAdYFg6sVlsKSzxU+C/dS XpqPKkHp6yRMXlmwsYe/RELCeeQEzufSG8y11JI5EH15rqWBY4P747gbOF1oLNYkeqbi yCN+bHedLVGLeMtWTYaig3RHAkF5J+t56Kua4XKeLRUf79Y0AdhBdJfHXRVSXZtCRjUN GFTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xzGdnZxHmKOE5i/G7hwvwNIRL9DmrKyxGqJE4hCfGoM=; b=HO4bJ6aPQZzYdtIjQeSn1E9p2QkWCkWfFubxiirl5YcNzzIlrm4qlJrrLZ4KDchN4h 32kKUyOZFd46xCjtbFxYGRsl+n8yHZ8Ec3biwxWsDWjBctZ7VYzwnR0aWyshTq3q+Cdb OT7Zwi5sfNRt4tv59jEhXakoPnvjpkeDPZJXWTLCftIcyg9p1Z993JCSJmED8/Gd8x6n T/GKvNX/ePbsQIvQvXIRMzYUrXs14Apyczf+Fjn2AJWelU1iW4gfocLw2lVY6nHfub0f 1wHiMOfYURtOfHXpt3jTwuNPfQoj6aSUjNq96H1bZ4bdmpKsaaXjrSEsa/nwIjMyQK31 2ERQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qCkGvFle; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kd2-20020a17090798c200b008e5082870a9si2164913ejc.574.2023.03.07.11.56.01; Tue, 07 Mar 2023 11:56:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qCkGvFle; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232993AbjCGS1j (ORCPT + 99 others); Tue, 7 Mar 2023 13:27:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232900AbjCGS0B (ORCPT ); Tue, 7 Mar 2023 13:26:01 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2F1DA92EF; Tue, 7 Mar 2023 10:20:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 875A6B819C5; Tue, 7 Mar 2023 18:20:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19035C4339E; Tue, 7 Mar 2023 18:20:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213228; bh=PO6YJGQP/E2abwSNE1uA5K3WGNLi+m5nTKH5md2eNqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qCkGvFlev3wtOuj6vmcxP/ryEytiA8D4qpywAn0hCDzUoVADw7OotaO+NXtxiuJoO 6Hc/0Cq2RAU+xrZ3KyB2mA+/zUQ9SIiPUNC24KU7xjXTQYMmnbeK3S25uw5vO8DnZC paJ3+7y2igLXwYlRYNtTLwbOMYdNLtwgbwABxekov0F+JSaB4BjqjRYRZ0iOhaIAQm lv10wxYE3C18AG8C+v6kaE13zqvozBT7riwL8lSyY5dVOe+BLHnWQFR5/qq4ojwhv4 zsthNfxMqY7/dyU3O1MYPosqjqjihO3Wn70d3CzPGJHpgWGbi4pWgMGs3oJh+1cMWE zQVXpTayVzqyQ== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Edward Cree , Martin Habets Subject: [PATCH 17/28] sfc/siena: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:28 -0600 Message-Id: <20230307181940.868828-18-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759740149917630812?= X-GMAIL-MSGID: =?utf-8?q?1759740149917630812?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Edward Cree Cc: Martin Habets Acked-by: Edward Cree --- drivers/net/ethernet/sfc/siena/efx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/sfc/siena/efx.c b/drivers/net/ethernet/sfc/siena/efx.c index ef52ec71d197..8c557f6a183c 100644 --- a/drivers/net/ethernet/sfc/siena/efx.c +++ b/drivers/net/ethernet/sfc/siena/efx.c @@ -18,7 +18,6 @@ #include #include #include -#include #include #include "net_driver.h" #include @@ -874,8 +873,6 @@ static void efx_pci_remove(struct pci_dev *pci_dev) efx_siena_fini_struct(efx); free_netdev(efx->net_dev); - - pci_disable_pcie_error_reporting(pci_dev); }; /* NIC VPD information @@ -1094,8 +1091,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev, netif_warn(efx, probe, efx->net_dev, "failed to create MTDs (%d)\n", rc); - (void)pci_enable_pcie_error_reporting(pci_dev); - if (efx->type->udp_tnl_push_ports) efx->type->udp_tnl_push_ports(efx); From patchwork Tue Mar 7 18:19:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65788 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2625612wrd; Tue, 7 Mar 2023 11:44:11 -0800 (PST) X-Google-Smtp-Source: AK7set88uzlgXYgLxd/QU8Negp+OrZ065wCHwUHRIa+0Ahn8SAiN6bXXOvCy8QbW7kgTU0srbHrw X-Received: by 2002:aa7:d60b:0:b0:4bd:94b9:b8a8 with SMTP id c11-20020aa7d60b000000b004bd94b9b8a8mr13404675edr.26.1678218251319; Tue, 07 Mar 2023 11:44:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218251; cv=none; d=google.com; s=arc-20160816; b=T+j7HAu6lCmnbTJcVrFaB38IP6pHckefj7KR7z4ahEghScATh8Yz/0TIH2DpT3O8qG i6aaB3vtNJzsbdS0cW25kPtP6+2ipw4RfWoqlfSzJOfTh3Z93chhwlhAmnSpNHkA6J66 MO4KVAqpNMpS9JD7wDpmtRI7N59jqj5xC7gXYJ5Az7Lr4ulnY/rUYsAFiPgps9b8z4ap M4H7nKBubGh7yxtCj7n51TNVXNV7OMeW+IbRPSU2x63KnkUKUtcTwve+Ry/AECh4w0D7 1MRWVU4K0vlVQFpK4AzUobfPyO8DQv1v2Dz+OcsAdzA102c+21b+ImAdgTDEJo9AY/Mu /X+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Lhk3DKu486ZkygOpVPiCzVMgY9OCPPQwgXnoJuEzzNc=; b=KUbl5NLYdwiBiC0VB2Dp5FFK8vqY65D4wvMUYhq59du1pBjgbRlhYfLi0+sONRPelv OsMjoCJAYmm27udhdt08MKN47U0momXl5vdiSkVisKO4WzoARbXxRhoDwikk4tnjOFmf NhAkbq6ZcMDpogkCLLSkBBzNHffpZrVenWp1ifQJEk8Ic2vsTGVb7z26gYqwFkMlrPxH 5uT1y2Nu5FqeejQmT6Ne3qnhXAwpRjw86+AXcYonZexfEJZKJuzTmV4fIwM4yjzA6mB1 HejRvmA14Is/zbp0jttcxOB9B21gJ63kDY+/YfyvzFzXEdgMwx7vXf/EMe+wS1yZD1xC uPsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kQYvDfn3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i25-20020a056402055900b004adbb59bc8fsi836056edx.16.2023.03.07.11.43.47; Tue, 07 Mar 2023 11:44:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kQYvDfn3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233014AbjCGS1t (ORCPT + 99 others); Tue, 7 Mar 2023 13:27:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232831AbjCGS0D (ORCPT ); Tue, 7 Mar 2023 13:26:03 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F67FA92FF; Tue, 7 Mar 2023 10:20:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A452FCE1C81; Tue, 7 Mar 2023 18:20:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9034C433D2; Tue, 7 Mar 2023 18:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213230; bh=nZWihkCB3+64Nvms7t3o5MvdKzSCnCMWUPwklzyFewQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kQYvDfn3TwVSoLlYr0Fli6KVLssSRynOqK7WfDIh1Fjs7cmSNir8VTvzfVL8rbwx6 KGwz3Ue5obr5LHMOYcAMhNuC8xTiXTNg/cGZI3tGQUO/F4q1IrAIpKxnCJEgugJXdM 5uAVhnruzYqFo4qLg1cjdmuctc/itLePLhZ34VcvZbCplgXAo7w9sXRt4Eq9Kvoqdt QoCIlKmG54H8SC2FvbtBcOqG++V2HZls0hUlW/pLIquLRRXW5dZ/7hNDyjx7GoxxCo dfnkLg9FvZO6lMy3mb6/QcE95iouWRbBS8R8OV0DzC/WRHkFqgj6W1jsZxc3StZwH7 lFD1zplDLQ8xQ== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Edward Cree , Martin Habets Subject: [PATCH 18/28] sfc_ef100: Drop redundant pci_disable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:29 -0600 Message-Id: <20230307181940.868828-19-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739381059941589?= X-GMAIL-MSGID: =?utf-8?q?1759739381059941589?= From: Bjorn Helgaas 51b35a454efd ("sfc: skeleton EF100 PF driver") added a call to pci_disable_pcie_error_reporting() in ef100_pci_remove(). Remove this call since there's no apparent reason to disable error reporting when it was not previously enabled. Note that since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core enables PCIe error reporting for all devices during enumeration, so the driver doesn't need to do it itself. Signed-off-by: Bjorn Helgaas Cc: Edward Cree Cc: Martin Habets Acked-by: Edward Cree --- drivers/net/ethernet/sfc/ef100.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/sfc/ef100.c b/drivers/net/ethernet/sfc/ef100.c index 71aab3d0480f..6334992b0af4 100644 --- a/drivers/net/ethernet/sfc/ef100.c +++ b/drivers/net/ethernet/sfc/ef100.c @@ -11,7 +11,6 @@ #include "net_driver.h" #include -#include #include "efx_common.h" #include "efx_channels.h" #include "io.h" @@ -440,8 +439,6 @@ static void ef100_pci_remove(struct pci_dev *pci_dev) pci_dbg(pci_dev, "shutdown successful\n"); - pci_disable_pcie_error_reporting(pci_dev); - pci_set_drvdata(pci_dev, NULL); efx_fini_struct(efx); kfree(probe_data); From patchwork Tue Mar 7 18:19:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65804 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2628283wrd; Tue, 7 Mar 2023 11:50:41 -0800 (PST) X-Google-Smtp-Source: AK7set/5okA2ISII+MAaz4myEib9QJke+cQffSDfDvJQ53gYSsKR+aX80fhYUuO4EawkcGPu003I X-Received: by 2002:aa7:d29a:0:b0:4af:69b8:52ba with SMTP id w26-20020aa7d29a000000b004af69b852bamr14721951edq.25.1678218640938; Tue, 07 Mar 2023 11:50:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218640; cv=none; d=google.com; s=arc-20160816; b=1JVlATXaRjs1YcQAFHDeMZAUN8xViP42XR5mi7ELYaHqUC5chHm4B/J2/MZaZTyJnB WdvL+p8wx1EvWtBLj//8BeRvMoLPfLKm3xZFnOn7mD3dHDpz24J7uLxP4jCvw0s8xTN1 TpMB+Mpkx/4mVjHRQO8WV4aZlvl9SNh8QgYXDGpUUVC2Qk11FzOhymbOaSd/ZL/YlX4x nwhNmTTYgUwF9CKGdY+xNY98NzRtKBw1x+7ripK8M6VrmcgblBX50Sbm0gEtGSChsE5E 2F8KW5yHsC+ai0oBEMxsq96gJCVJRQkz7UQRc5Dr6nH62eR8Tes/tZiq6+E6lq8Wc+nC fWVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=uf1D4eLdUuBwTTNrWXc+psUnYgWbY1srLa55xvnCOQY=; b=Ui47mKQuDUZWPGv0e/MLXsGFq3o920Lai4N+hFy03EqCrUScLWoDn1eJhurJuuPR4G NwlNZ15TufS46HwHurI6gX9SGYAhuWL95I99yia5XMX25T4Q8DtHMsnb6LY8XtTxxa6r HR9HO1D1ngBKaoUBsZvo0Gb0cE6LoWWqUJWJ+CXo0w3moagzBo2SPh7YtO90uBH7Bxn/ DoUxb2Sq24+fvmlQaxKyKDU0iwNlV6VozzCty/d/q80GoRKOvNf81u1eIlUZh4TH/zWJ yNdlLkbHzXb7OujFdegD6aqShSsAagiydiMDNW2chCWNnPD0D+dRF+qKuQi23r/FOXsa ry+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fhQzKHoZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z22-20020aa7c656000000b004acdd3b83d2si9016038edr.14.2023.03.07.11.50.17; Tue, 07 Mar 2023 11:50:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fhQzKHoZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231164AbjCGS1o (ORCPT + 99 others); Tue, 7 Mar 2023 13:27:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232908AbjCGS0C (ORCPT ); Tue, 7 Mar 2023 13:26:02 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B44EA92F4; Tue, 7 Mar 2023 10:20:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8F1386154C; Tue, 7 Mar 2023 18:20:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBA61C4339C; Tue, 7 Mar 2023 18:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213232; bh=rAktUskhPO1ybz9A1n3ZxmMrMb2ek7EimkMYj7ZSxHA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fhQzKHoZbVHMkFOXq35GSopr3Xw6Ebqdt2NFeKsF0uGBvJ0hUziTwRIJ6nGujaiKr gvTSyF1x4v3NboSWZsHM0WKjfHoiz0eBzO8NHRoAPV7ZIPjI2kxnBMHhBit0sgiNN7 UH2ElbegdHpdtMoghcTN0m7bPDoq/7unJ8PqK+j77YC7pg8YR30O0jJFzdQECzdBu7 i0q0XMxxrZtrDjsHQzAA7HVpN+T8NsPuTfbk6ZfX6lZ1Rd+5hZmrTm+s+zbUkCKbFD IZ/FUTLLMHAdvhIdh71n0By9jT6FjNCfSdJizy2/ZUhrk3ZYehMxkbe+PRmNbAfpUe gqfxJ0lCugAtw== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jiawen Wu , Mengyuan Lou Subject: [PATCH 19/28] net: ngbe: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:30 -0600 Message-Id: <20230307181940.868828-20-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739789918105911?= X-GMAIL-MSGID: =?utf-8?q?1759739789918105911?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Jiawen Wu Cc: Mengyuan Lou --- drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c index 5b564d348c09..0e4163e1106f 100644 --- a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c +++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c @@ -6,7 +6,6 @@ #include #include #include -#include #include #include #include @@ -520,7 +519,6 @@ static int ngbe_probe(struct pci_dev *pdev, goto err_pci_disable_dev; } - pci_enable_pcie_error_reporting(pdev); pci_set_master(pdev); netdev = devm_alloc_etherdev_mqs(&pdev->dev, @@ -669,7 +667,6 @@ static int ngbe_probe(struct pci_dev *pdev, err_free_mac_table: kfree(wx->mac_table); err_pci_release_regions: - pci_disable_pcie_error_reporting(pdev); pci_release_selected_regions(pdev, pci_select_bars(pdev, IORESOURCE_MEM)); err_pci_disable_dev: @@ -698,7 +695,6 @@ static void ngbe_remove(struct pci_dev *pdev) kfree(wx->mac_table); wx_clear_interrupt_scheme(wx); - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); } From patchwork Tue Mar 7 18:19:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65765 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2591250wrd; Tue, 7 Mar 2023 10:28:37 -0800 (PST) X-Google-Smtp-Source: AK7set8b4g8RdWPCyxhZXXkmNPqXZJg4sFHeN/jm45jn2410QsrfjIAGMS2s+EG8+oT/RgWZqhVg X-Received: by 2002:a17:90b:4f4a:b0:237:8417:d9e3 with SMTP id pj10-20020a17090b4f4a00b002378417d9e3mr16310458pjb.15.1678213717523; Tue, 07 Mar 2023 10:28:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678213717; cv=none; d=google.com; s=arc-20160816; b=Dcg0JisQgCbrq80/s91mtXlohxrEcO3mWsWW3kk8B80g9y/gfga4WF3slARGIYXYbG 6tNNZQI/bzHjl4DgIS4FrEGqiYDIsxF93RrBR8U12BPkL/mXjVvN9gQZ5x8/sdaWVoLA VjfsV0xP/SX9GMoLEPLJFZMDrqbevqCWDBL7BXLr23kvm3waarr7m/6KDNBjQ2wvD9cQ Uy1KhbBbyjPW1+M04lKJJejyb4D7L4WmITxRZJuTtkkJ2+YuPczLhx0aGBY2DreYp0hC JPsW+8FS6+l8Tmm4mWz2AZOwr2pp0VdVTNHFsUHpqQQWgWa9BelVwHF3DKLI0HXOVgo7 jRyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iYK6wXvgPXI/6NOXqX2mWTuMCtUsHRXIfHFFvCl4OVM=; b=Cp9qrJftCBiIfcfzw+EhCgzoh9c272hZGLX+srlPWTd8AlLl2DhWf49L/amivjjPor 0HsdX3OjDZ/RJ7KgDctSmZ1XR4BwIsHNrWugUTO2jAXyt1hGmpFCk7RjV5jaH1eiYSqQ qxCxzj53+/39sgEeBkCv5Z9z6ap5Kuqxz8RRdAL+vlAV+NxOjw/2dERbVr29CpzjMJdQ bzN0OLaUNQIK4F26N4QwBjg2uZ5LffS7iU6OaST3A5EoUMrxF51stokys2R5chVfFrfg Z/Pgmwq+ZmTrw8r4X5g6x8QP87KZFLZO4sZ+kwuztEqPkzfdnaEPH5K0vwnT1p1oDzH2 Nq0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OL7VNPNR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e65-20020a17090a6fc700b002376d8568e1si15717345pjk.114.2023.03.07.10.28.23; Tue, 07 Mar 2023 10:28:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OL7VNPNR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233024AbjCGS14 (ORCPT + 99 others); Tue, 7 Mar 2023 13:27:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232613AbjCGS0E (ORCPT ); Tue, 7 Mar 2023 13:26:04 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDA2DACBB2; Tue, 7 Mar 2023 10:20:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7904F6154D; Tue, 7 Mar 2023 18:20:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE61DC433D2; Tue, 7 Mar 2023 18:20:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213233; bh=MunmSilf1uIvYwkUne62rZ2OB+MTJPaCa6o/fBaY2ww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OL7VNPNRmW497PB7a+2AZN+2qDuYEp2t6VwUwfrSnPlxUH9CH8RIfXh3QIn1tFtsc 4IXPWVzGdx0Q4cw84ny1sEEgnA734DOVvoxC99FDPZ4hz21SYxobqRORsY131PUaGS Mx4a2gOJ1zFs6UiR3c9RXP6WWw5hKso9cKjTawtZobVlHLGiTUcnrJMRq9UJ+wgcb7 7MSvm87neFbyoQwvOZXFfxSWTgirSoERrJ+vtPqwq/iiyfrvsQMUMeJmZ7YgJa08kF kxg5D3zHX4+Jxjh+3OscgiXT+h/pCvQLda3Jl/p/4S62PcEc80eyfX7BOpDQP+aUmr +EGoDvfy/avJA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jiawen Wu , Mengyuan Lou Subject: [PATCH 20/28] net: txgbe: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:31 -0600 Message-Id: <20230307181940.868828-21-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759734627431651667?= X-GMAIL-MSGID: =?utf-8?q?1759734627431651667?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Jiawen Wu Cc: Mengyuan Lou --- drivers/net/ethernet/wangxun/txgbe/txgbe_main.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c index 6c0a98230557..859feaafd350 100644 --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c @@ -6,7 +6,6 @@ #include #include #include -#include #include #include @@ -538,7 +537,6 @@ static int txgbe_probe(struct pci_dev *pdev, goto err_pci_disable_dev; } - pci_enable_pcie_error_reporting(pdev); pci_set_master(pdev); netdev = devm_alloc_etherdev_mqs(&pdev->dev, @@ -698,7 +696,6 @@ static int txgbe_probe(struct pci_dev *pdev, err_free_mac_table: kfree(wx->mac_table); err_pci_release_regions: - pci_disable_pcie_error_reporting(pdev); pci_release_selected_regions(pdev, pci_select_bars(pdev, IORESOURCE_MEM)); err_pci_disable_dev: @@ -729,8 +726,6 @@ static void txgbe_remove(struct pci_dev *pdev) kfree(wx->mac_table); wx_clear_interrupt_scheme(wx); - pci_disable_pcie_error_reporting(pdev); - pci_disable_device(pdev); } From patchwork Tue Mar 7 18:19:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65790 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2625870wrd; Tue, 7 Mar 2023 11:44:51 -0800 (PST) X-Google-Smtp-Source: AK7set/05x+yPLIcT2nt/7nrAaGMaLKadG62RBui6lOfPO6IB1DKb9efN0KudogaTx8sDV9fDcFZ X-Received: by 2002:a17:907:a44:b0:8b1:7b12:2917 with SMTP id be4-20020a1709070a4400b008b17b122917mr20494792ejc.12.1678218291771; Tue, 07 Mar 2023 11:44:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218291; cv=none; d=google.com; s=arc-20160816; b=r3IRQ75Th2y++R+dcraCGhJmppIaQY8TrttVytIugYWpQfmhS/W19oWHJeNi7g033c lAVuU7cReS6h+XVPxhyVvhPESo2gkdxtJ0b14HeHyGJ98GxpXXIdNd2pIwNhd0ey2ggL des8plUQGVsR5HCJHY9I/LXmnxkt/DFpoi5SgmDbgk5B7o7+6EQrRu/vrVyBlPIsYc7O w0xFCFhuGIQzN9nIVyVrdpp8MPVC2omIFoapx5Pm5LDcVoyi+iIY4nlwiIFVpnyocJ2g gjOREwhdAPbwgGUMvfQrcuD0yJhC3+y3IcOdh6/EbSh6JqcdBsfyc0OiZ0lcwX84eVpH h5jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Pdzum5QRrskBgkZwefXtOrKFURZ7TWIdpiq7dUVlwlM=; b=Y4r5Nmg1kBNkUEJdtnp8BozaUUhNX4aaLc5gqMf8XciTE3EU8sNcgjO7cm7fEB55ES DlmGFB4vVoz/yZHPnJ7wFis4ZdMqplXeP14UQr6q0ghT7PvQvUfAO+zd/vaM6Mgv9RDb TcXgD8+fPvP+aYehepKc9BSyuId4a6BdCfET4AxuvL5te8x0Xt7V01vHxgBme6fzTXbt 4u9P0PEYaVCW0EoGexjcwhk2B6kuZVdBTEupmY+Y7EQ9xnaB0z25En0MdysypzffI040 330eKNQYtQnzq1ZIu+b8uRd5K6rtiziKdvRKvvXroWQIYLKrsp2alAk4gxB6O/rx9Ai4 ObXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oWtSEFrh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xd7-20020a170907078700b008b3b05ca5ebsi2293831ejb.40.2023.03.07.11.44.27; Tue, 07 Mar 2023 11:44:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oWtSEFrh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231370AbjCGS1y (ORCPT + 99 others); Tue, 7 Mar 2023 13:27:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232861AbjCGS0F (ORCPT ); Tue, 7 Mar 2023 13:26:05 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB56B9EF56; Tue, 7 Mar 2023 10:20:36 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4782061501; Tue, 7 Mar 2023 18:20:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F9C8C4339B; Tue, 7 Mar 2023 18:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213235; bh=+SVjmFeoitwY56tf4BRMZdfwmTz2I/jifxLbrlbtKKI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oWtSEFrhzjXt8a/O6k9UqI2r94s4dtqMqsGeDqcDGF6HDuPRhrT7Ue8KM8CmZkcDI oV0qhrG0+bs+IVbsU41k8j+IFyOk08/SIu6F7CKfRtQ4CAwmz73uzBnuiVNeRNPWTL 6gu8q1A/uyZYW4YAs9E0+fh0OxArW0VUdR7AZAeBZ/VRAfJmavh8t59IvSsHHtcTnC lcamH9SIsLJS1PcnmWThfdwWj2Oli9qGdyimJjb/Cg97kIuUauyyxRz2jxOmicwxaa 6Je6hdFkLnEClEDU1O9thFDxKPYn3OGMVXsv4y0CDPSPdqshl1/CRmkJOMltz2Y33C Qb8QsU919Vt3A== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen , intel-wired-lan@lists.osuosl.org Subject: [PATCH 21/28] e1000e: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:32 -0600 Message-Id: <20230307181940.868828-22-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739423747162688?= X-GMAIL-MSGID: =?utf-8?q?1759739423747162688?= From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen Cc: intel-wired-lan@lists.osuosl.org Tested-by: Naama Meir --- drivers/net/ethernet/intel/e1000e/netdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index e1eb1de88bf9..6f5c16aebcbf 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include From patchwork Tue Mar 7 18:19:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65785 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2624938wrd; Tue, 7 Mar 2023 11:42:20 -0800 (PST) X-Google-Smtp-Source: AK7set+tTImcly0bNh8uzE0pznPZ/rKB0o15/c3F+H0wzt5GRrgNeGWO8pABfqYCfv9zsf+oJaaJ X-Received: by 2002:a17:906:cccf:b0:8b2:c2fc:178e with SMTP id ot15-20020a170906cccf00b008b2c2fc178emr13363964ejb.74.1678218140389; Tue, 07 Mar 2023 11:42:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218140; cv=none; d=google.com; s=arc-20160816; b=DKJoTC2ycfBwLRYjOds3wG+4KRDD/LcHHJmimRN5noD1gMYI13NOhA3426E3m2r2/T we5e+DrlHBsa2wtM0ubaDNiH6Gs+risBxOjCWANL+znI1zCbWbbYPwL2mp3wIEVO+ECJ 6EUoXuIpPQxptAUpEzdBLc1HnChJP0cJGHbvqu+uEh0+wMHhw3g3ejKJSpdvsYnkZA+x uYeFXLUxzmdKa0Or/+HQzxCC0TwGT2+iPkFnb4KctDSjDPcGpQL2/kNxLYgXIX3gCi0j KGM2M1yOEQo2pLIXz5viIJuhXeeslMeBHuTbpXMFQJqGeHhcctdmXuKAW08IACNkctRO x4zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5ywifiiRioX/oef7vtOlFQvcftFMAN6N28p/mxvXEUk=; b=mYgcL8hI1IAq8Pzr1TExZhjecO4e1JsUQZHn7znm+43riG37KXWcmLBcDMDhvwuMuv oXIV3RdivQj1EEqBBny+5WhB6C2oFuNLQzqb6KzXBWJjWnJDSCY0vS3AZDyQ5zvxwBmv B3cJ1XHMOChQ17/fR80/zjvxDMWxVsQD6TbkckyxrzjeDLeaPJ4bEWyKCNG4DcErTqWU 3DpZlrqQL/svUyw5bOj86dsT+BKMEF2ZiAk+ckWU+TirYxXM7Lmy5k365rNc6VAoSBUd AHrcb4RGRC4Tn+g4+Inpm5qr4Rm8MuXSCj0RTtAZSLQBqvA5iiFPbDwp1GirKWD73ZFe CjLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="XUo/07cF"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id um12-20020a170906cf8c00b008d4d102a7bcsi104073ejb.216.2023.03.07.11.41.56; Tue, 07 Mar 2023 11:42:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="XUo/07cF"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233037AbjCGS2C (ORCPT + 99 others); Tue, 7 Mar 2023 13:28:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231965AbjCGS0c (ORCPT ); Tue, 7 Mar 2023 13:26:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 868F59DE15; Tue, 7 Mar 2023 10:20:38 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2601B6154E; Tue, 7 Mar 2023 18:20:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61E8BC4339B; Tue, 7 Mar 2023 18:20:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213237; bh=xZeCbayYrVhu8ichVDtPhdqLO81L+GFGIOk8oMP+2DE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XUo/07cFEWvAjxyWxduBiLutX3WEM4TKC2hVQDuBmJePgKmBfdMI8tkKWewBZuIGN anG+98OsZI0huduLILIowWc//50OUGkWqUhZUHQaRVeZh4Cv0l1Ses70zeew7h2auw B/wHXbS+hQy8H6N6ieywODw6aef4cZgvhkJTbqXy0BFLzQIo3B3VOxrZT1b2Ub18X8 zygEfI91JelgNMj5PkTV6tlr4BwxBhhj7ESM24977mVptkIN4D3uo8Dbc0nrQ4hcKF F+VLulD5nlze/YwSuktn+3h/wmbSxDlFOieVW2j9eznpcFOFp8CHAcwAXSY5JHlqGs VGzTTDmlhNYHw== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen Subject: [PATCH 22/28] fm10k: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:33 -0600 Message-Id: <20230307181940.868828-23-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739264896855214?= X-GMAIL-MSGID: =?utf-8?q?1759739264896855214?= From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen --- drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c index 027d721feb18..d748b98274e7 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c +++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c @@ -3,7 +3,6 @@ #include #include -#include #include "fm10k.h" From patchwork Tue Mar 7 18:19:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65819 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2630553wrd; Tue, 7 Mar 2023 11:56:39 -0800 (PST) X-Google-Smtp-Source: AK7set+TlFNryXmlptqbfZW4MkYmQ/yh1gJKHVlbWEB987pJo0SghWFz/5wAgQouaEkBGlJhXPUh X-Received: by 2002:a17:907:7f09:b0:8b1:7e21:f0e9 with SMTP id qf9-20020a1709077f0900b008b17e21f0e9mr19636757ejc.18.1678218998927; Tue, 07 Mar 2023 11:56:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218998; cv=none; d=google.com; s=arc-20160816; b=xE9baQw2yPCuopdZ320XCVm7JgfssFf3oY+vOQS039t7TeNh9y5GPUo4urrGf59EEw J2gvNCFyPa5L0XnBkFIf8RQFujnXFKRZzD2c8KSw6+XajuhL697HmrPC65rt3YzcQlaT 6Oxb6CiNYPPrGcB+J2zqNjhGUIBmeOkE+COj+0u+88dq04vgOfX87cFpLfKecAsuUwfQ kIVPFHEJ5R1aZfWYTMO+EtJQmWoy+XPvgiwtEqZf41S8cUQW/9PBubk7ztHZeFqPRneu j4lHKKOW4Wer4n6ErCrRMBdcEhHlnpKkkLyDXYTVW+D09uR4w+FThGUZPnVeOdsAX5cx luSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZGji6plVxsylxqWCEeRR9oA096idXMQkDvqCStRNqgo=; b=GmC1+ctAJIV3zCWN3TWONgxmu5l2Bqn3ByeLALXT2yyboPru/LcOWyfRPtp8yyvcso u/HxXS2F7sjWjlEm3IeSeGRGPoG1iUyjulXliyjPrHNowawJaCMt5OfH1BiAq2c3KUEp zgBHPHY40fy0Y/LeM+1oBmfOwdOh/IwhInDeVGpIabCQXF7nW7Lvb7EAb5ffwrZ3mRqL LBKMvj0SecvoLUGPWEi6avHedztr5pvMf96y7yOOEJwfnh0lQ7KvO9RZ2U9YSipzm3aB Zp/Lie6NGL2kr3dDhFrUcwB+MreU0iapZJ2VyocCeYZiCKn5ord3IxfCQRfG9Dc7yjCc qC+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nLJa18E5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lc27-20020a170906dffb00b008b17e235ac3si597964ejc.924.2023.03.07.11.56.15; Tue, 07 Mar 2023 11:56:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nLJa18E5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233044AbjCGS2E (ORCPT + 99 others); Tue, 7 Mar 2023 13:28:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231384AbjCGS0j (ORCPT ); Tue, 7 Mar 2023 13:26:39 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A91D8C805; Tue, 7 Mar 2023 10:20:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C53C0B819D2; Tue, 7 Mar 2023 18:20:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4597FC4339B; Tue, 7 Mar 2023 18:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213239; bh=TljbBfxVOqKVnxlRPxJh7wfvgBgvno87gbT8Pk/fdoM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nLJa18E5GfrF6pP384PHVfh8oe+OOxkwbv+32yIGw0SQjqXmUtY6jt3VvN1GPSKMV H7lgOgmYuPktGtKoUMzG6lzjdihCOWzuihwAJ5Onu5pJ1upxPPtqzjSay+S47T/jdM lMLmT9tqCwzi0/LEbReV2XQr0yEu83MVQDwHIm0+6WwJHnGA8vMZlCO6F+JQaTgnBi zvkdMHD7XQZIe+C/3xdc3b7UUlx6w/RNA6mUBEYf84GscKPjhiAL6/6qOilHDDihEO aySfDTZ/MQN3ddWiLBNWYB7FBS9OV2SWK6O9DiqTGke9Dtt1kSfaK2UjDHRqM51kAw Z4lr9A/4VEpAA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen Subject: [PATCH 23/28] i40e: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:34 -0600 Message-Id: <20230307181940.868828-24-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759740165136511066?= X-GMAIL-MSGID: =?utf-8?q?1759740165136511066?= From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen --- drivers/net/ethernet/intel/i40e/i40e.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h index 60ce4d15d82a..6e310a539467 100644 --- a/drivers/net/ethernet/intel/i40e/i40e.h +++ b/drivers/net/ethernet/intel/i40e/i40e.h @@ -10,7 +10,6 @@ #include #include #include -#include #include #include #include From patchwork Tue Mar 7 18:19:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65767 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2621333wrd; Tue, 7 Mar 2023 11:34:18 -0800 (PST) X-Google-Smtp-Source: AK7set91u154tpWMokdaRxHJ0ye8Pgb24QUDf7XjBn3th5gVAsyi+Tan3bMdJI4qO5NI+lhc+avQ X-Received: by 2002:a05:6a20:4285:b0:cc:5f8f:4f7a with SMTP id o5-20020a056a20428500b000cc5f8f4f7amr18095756pzj.27.1678217658421; Tue, 07 Mar 2023 11:34:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678217658; cv=none; d=google.com; s=arc-20160816; b=iOp3TgqYGjaC15Go1ZwzntP4P/FKEqEn+LJAIlZyPjJY453k1KV0c3EWWnmlOM1SC5 lKQD6f+qtMQFmj8fqRzi8Q9NdomVCfL0+NHiuKKC4TN9Zg/pjhXrQz8t8TJye8LmB+j6 QyVEglgh5SHqqLSW2hlQSuz6fEfbUZUQfkR4jj/dqoI1tmyU7kqH1/oXu7b5l4XpNwua 8HyiQVJ/Ltw3CJuqJFdriIYwHMBtXElKoXRO1VOScJpMf8PVi6BrqVNf+dqc1aL/le9A azGqSHZfcMRDApAWEzBgY/6yhocYPhv9ZlZxVmIKwMrLWygfWtQreTgXfgqHdR3FCXXh VTmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2tFLl7CdvovucKyN1WB+Pzg06Ep3nSWXkGwSGOY9SFM=; b=ezx59aPLeykL34syfZFBWDlcvIfCTteOHZBUxzf36Q9PhjiJZMsikO6n32FuTHDF8C JfglKCD6jdmKSz5HgDZ23Ue3+JGvTAWjtAup6MYfmppWk4IDRsH102qUW7pWKv5mU6lF 608myBbxy3c/qNQh4ZGhxfUV6vtPO+fvafzrYde3G7HjMQmLN+ZjYGYm2i4Ro58H4x4Q OVduH4Q8vY+1c2Hz5k6Tq3muG17tN/Z7rg7YwUj3MijO4f/sKdLSgfTvmw6RXAVDwqbV 9wCy1dwgDV57sBZVl2cdPGVTY+QvJlBAKCOlf41dTpJ70kxRXAtKAfNPNfP/YycD48WF ScyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Utqngn8F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i184-20020a6387c1000000b0050320fcb11esi12684634pge.594.2023.03.07.11.33.33; Tue, 07 Mar 2023 11:34:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Utqngn8F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233056AbjCGS2I (ORCPT + 99 others); Tue, 7 Mar 2023 13:28:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232871AbjCGS0l (ORCPT ); Tue, 7 Mar 2023 13:26:41 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 830F6ADC04; Tue, 7 Mar 2023 10:20:44 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id EEBAACE1C79; Tue, 7 Mar 2023 18:20:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DB87C4339C; Tue, 7 Mar 2023 18:20:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213241; bh=DE92hw8t8/0nODEhiHkEnnlsRI/SWQU/hTMJS+17V8U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Utqngn8FnD1QnkNMyz105aMZWZvoOdgvgFmcIVsgKcD5AdXJc2DStIs/ktxW+sLe+ r/VsowUTdpMcIUhzozJxqJmvvZV+zh8rtUNF/4/LdpWjfFp5+jSK23u7xq6CJRMD0H FyIj9XEzXItwjHZGittnP0uzi/r1ZeJ5OzhoKNj56q95QC5wR5RxKQPTNtbI2Dtvmh CUgdJT7jpQ+Q5wLpCZITVc53nN8ZOIMlAQmzc2PE6jiKY4fUPz5A1g0qJNB6JHwE5D JG9uzdfgLZz30yrSRglBnn+BWsrsyKi8Zq+Tz/1Iy/fzK84RJXv+EbRcZW4OmvOd2r 2WwWZo5zchL8w== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen Subject: [PATCH 24/28] iavf: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:35 -0600 Message-Id: <20230307181940.868828-25-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759738759612654245?= X-GMAIL-MSGID: =?utf-8?q?1759738759612654245?= From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen --- drivers/net/ethernet/intel/iavf/iavf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf.h b/drivers/net/ethernet/intel/iavf/iavf.h index 232bc61d9eee..2cdce251472c 100644 --- a/drivers/net/ethernet/intel/iavf/iavf.h +++ b/drivers/net/ethernet/intel/iavf/iavf.h @@ -6,7 +6,6 @@ #include #include -#include #include #include #include From patchwork Tue Mar 7 18:19:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65777 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2623545wrd; Tue, 7 Mar 2023 11:39:14 -0800 (PST) X-Google-Smtp-Source: AK7set8TDVxxHs6UQdDp0QTn3jWQwS//ejWNe6s2FA7iYOQsjF8YeOh8ey5VSlSBCZs3bjlSUR1Q X-Received: by 2002:a17:906:9f0b:b0:8de:e66a:ee68 with SMTP id fy11-20020a1709069f0b00b008dee66aee68mr14293312ejc.35.1678217954169; Tue, 07 Mar 2023 11:39:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678217954; cv=none; d=google.com; s=arc-20160816; b=GO5AdOZC1TGCP66k6qBjWxNuAm+y7tMIVdPlPMlsM5zPurfTGz+QlHsw8WHdKxBCQm kOXuHxE0uJHe+Avoa16EpcctnufzR9zUHR8Sj2G9weiulNvAlavwZrwhTz5y31cYIQ4b XSdtW6Gp86Edx7xSXpsWkrr7B3n2ZXpVI4QUEKMCORfuqkwXW9Vfy2y6m8LMXbwKQa0h sjsETd3gfHhhQTlK1HS9UDUTNVOE4YxzWSFFPy7obHeLPyFa+izz45VNhKPR6cvd/eV+ 2IxI1y4pHwzFztRmJr7RoIIUQpj3zYJdgm71BXaM9wnhBkLotpNAh1XWMlowMZ31deBS +yYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SAXJqaMt3/shIL36QlUNFIjtukSliJxDSsLOFTRwP6Q=; b=rM14ZU6kNn2QPri4Ig1S4+tjKTBtgJvFHnbJWGJnA0wM2ss/kl6Sgoiyr/CgfEdLt9 AdCbF9E8CKfWoOaMMXO4iG4j7LhkVaKhSAP3PKS/ZHup4zW7SZ/XAV3J/Ls0ma+60BW0 werSQRgM5cxuOo8HlqNrFJczBUcu7QoNpQeh98wiNyl3IxzilIkwU/ZHDpiEBFD6wEU0 CZkb4BwL7emtVcsKrPrVaYluuobtCw9RbA1iyOm8ihAhpYHsvV0lHL5LTWODg/FQWh1s TTR6W7LPNuBOUgNwPLNBFbFYpjMmEvAZIdijVbBE5vtQYhW4UUhbL+yty2T1J6LRqI3N p3og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C1fCVlZu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xd7-20020a170907078700b008b3b05ca5ebsi2293831ejb.40.2023.03.07.11.38.50; Tue, 07 Mar 2023 11:39:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C1fCVlZu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233059AbjCGS2L (ORCPT + 99 others); Tue, 7 Mar 2023 13:28:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232918AbjCGS0l (ORCPT ); Tue, 7 Mar 2023 13:26:41 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ED3B9FE75; Tue, 7 Mar 2023 10:20:44 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9EDC5614E8; Tue, 7 Mar 2023 18:20:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCAE3C4339B; Tue, 7 Mar 2023 18:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213243; bh=9iCFzc2QqDeX+XEzEK67hx5JvvMn4Tky3ek230eHt58=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C1fCVlZuEjlME/3MHfneKNMrZpZPMBpAR54NxEVX9f9z9SBbJY5ThjOaSsZtd0hjm 7ABLWkyDbB5p5gU+wEYQBijE7HsIxdm12esRd2gAbMz63Mqr+BEIuf52d0VjJRCvO/ /soT7vjH7mBIxwxXk5SHQDldKVKGmOBKzoLHBku0ePxEX2fnvhi+CKJxYFdFPf+p13 6PXBzT2iYQ50VyeiHY6xOTNhLFNujTcbS7bIEHplIEtyd9vr8yAMaI5OXUjtHDszZN LVMrHo/+924GJVNvM2+DOwlyefYAWk9HR5po9rHlhcfSUxQhLzqYz73fL+aoFwNgqp IosK++mBocb0Q== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen Subject: [PATCH 25/28] ice: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:36 -0600 Message-Id: <20230307181940.868828-26-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739069234737615?= X-GMAIL-MSGID: =?utf-8?q?1759739069234737615?= From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h index b0e29e342401..d79a48d27f1a 100644 --- a/drivers/net/ethernet/intel/ice/ice.h +++ b/drivers/net/ethernet/intel/ice/ice.h @@ -20,7 +20,6 @@ #include #include #include -#include #include #include #include From patchwork Tue Mar 7 18:19:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65812 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2629518wrd; Tue, 7 Mar 2023 11:54:08 -0800 (PST) X-Google-Smtp-Source: AK7set8w9RHMNdsAEgbJHEi45cvZOQ0FhJYXqkfxx7mfRP8Y69L34PYaxBV7yIkcuc590BJFwpak X-Received: by 2002:a50:fa83:0:b0:4c7:269d:ed8b with SMTP id w3-20020a50fa83000000b004c7269ded8bmr13506897edr.18.1678218848069; Tue, 07 Mar 2023 11:54:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218848; cv=none; d=google.com; s=arc-20160816; b=Kz3LRo38ToHAvpFXOzmUckPSRXOXtBuB3G1eJxWWUcL9TmOZvR2n2rpWE8DbLOFI9Q /c7RzWcHyazKclEXCvO3wTdjI+DyeR4nnS6EIFyJErjMK8Dh7z7cODdwhqmmtvhQqz2D f8UAhm9qRz2Nc1cdWxeJFMil4CnVY3md+gjuHQq2lRk502zkexORqbl3oHTB9taKeG05 oSL/LLJELbQRUmjEJvvzMIAOKhO0Kt+oXPbqSyluSnde5WJIVozu0aRqfBtMaWdWxwlj bBhxbsaIJAi8WkeEnQ0tM8mT7TdxWCHd/v6X3dx/nCzRNYSVO1AEhQWKMrUWgUq/DiPA OUSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=irQ2eUJjgOfiRG9Zr3Go/H1WFq9QMURdo6pUIM0gffk=; b=rNLUtsej5VTd4vYUctsEkNfzMlmvKwLF/ORnRlbvxJruCGDFrk4JMDBMFRjyIXIiyu SPDSAV115bRiZUajl86S0aHEEAQNNAEAfarZu1bsi+CxP0PaNKZUqDQbhURfhJ/Z1Qs2 jvJGCzUQIkuZFAv+TNjpCg0+lPpk3zY2MTAm+C1RG5pIIU5Un3isVkHXZMUw++Ljd7m8 rqSFXmtcrp5UB74Lr4pZ8ylDGlmXnM3D1MwpgB0Er734DipjM6sc8W40ZAgiXS2fSrwv PZN28YGN8P/nuubAp9ufGUvD3mkH7FMT15zvWzPoXhfBdm9QRKJzAWMybi9RZ6w/kXOr P4qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AREF4cET; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e18-20020a17090658d200b008b194cc10acsi17510958ejs.381.2023.03.07.11.53.44; Tue, 07 Mar 2023 11:54:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AREF4cET; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232943AbjCGS2S (ORCPT + 99 others); Tue, 7 Mar 2023 13:28:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232921AbjCGS0m (ORCPT ); Tue, 7 Mar 2023 13:26:42 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83ABD9FE7E; Tue, 7 Mar 2023 10:20:45 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6297C61549; Tue, 7 Mar 2023 18:20:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A189DC4339B; Tue, 7 Mar 2023 18:20:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213244; bh=B4VcwYAM8bIrgPqF9a1HoFkWWXvHnK9JzfKrJBVVkrk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AREF4cEThPeBwKNSseOGHlvfxoR0rEQndHAbN2MwMZ8bbR/lhvFWmNTuP2wRwW4nn wGP+QacNy3JQNFgZHbnYV+d/1rn6UqxuoOwGEF+vkddmqrPrps/dEI/hpM2r1w9YMm q5tASJwLRdTaOp6LLLP4ivtmY0Yps7xheOQVlET0cSCszuRieZcEHl4opod7Ys/fiA rRXm+EI8yamLqOBdjAXsh5bFJb74OeFLUsR7tP0t/iK7hXki7jFr0uTAKw9WADFPFf sZGfkntTOtdpLWPO361RNNrxbNdB78dtrQzoEf75REJbJuF1sZgH2m6vPQ7z7xeq/Y VUelKPnwgl4iA== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen Subject: [PATCH 26/28] igb: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:37 -0600 Message-Id: <20230307181940.868828-27-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759740006627788406?= X-GMAIL-MSGID: =?utf-8?q?1759740006627788406?= From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen --- drivers/net/ethernet/intel/igb/igb_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 03bc1e8af575..a2914298dd69 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -28,7 +28,6 @@ #include #include #include -#include #include #include #include From patchwork Tue Mar 7 18:19:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65815 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2629834wrd; Tue, 7 Mar 2023 11:54:51 -0800 (PST) X-Google-Smtp-Source: AK7set9Hc/hHUVJB1VeGiCKeMgT/fDJ+gIIGCitQKZwll+IVAvuCVEia5GMWFiZDuYrHDGb89ix3 X-Received: by 2002:aa7:ce05:0:b0:4ac:bab1:feee with SMTP id d5-20020aa7ce05000000b004acbab1feeemr12591277edv.24.1678218891616; Tue, 07 Mar 2023 11:54:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218891; cv=none; d=google.com; s=arc-20160816; b=b/wr429uvwcsG8J0fyLYxnmudANPPuUFos5dxDYmIvXCMdJuKROgYxCZ0XCr8rUbVH g7Gp46mVn5GK7YepMOM90r7SIzLRyE35C30FcfXjrvL8B5GpBxpCCwXdTnYJfVrL6ov/ wo4ZGyjay6Jilm/6Yt9b1oXLosIWdFkZ6P4h3PYwoB5PJwR/qzKRIkmhL7acmTYBErZF mT7X9uE4jj0s+nPYvcBX1nDyjZm95RR2RVBAtYCqR/73BfvmuJpsDkluttIXxszCwesI FZ0MFXSTUQzRoKxf52D2ll+i4rgYRkogWExi9bCbg9dHWFwERJRE4IL3tNE0JeBw/5sz 9vTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=f79Tz9Qfx3hF8Q3UBJh6N0TV1EFX2WoahzpZTboH/RY=; b=UlJmRcYSO3slL+CRRij1r+7z7GNMWVPlXH+vBaZavRNlVKZcxba0F2Mi/l4EBBBkrU teq7vCT1+cVs9qStfTQV+BaV5YtOaq6SfAVdUIBozjKCu4ECImzAW54vr+OY9oFeYAQF 6UxwwRZ5CeP0kD17PgzSpXMXfAU5z/nouL4/gFS4XdydAxaE1ipppNOw9chuZC9ZEWCx rUVPDT1ODo+eUnwo/zbOd1BHBzg/nvIk5zGklsPpZcEFQvrTRSKeneDOlGETsoKKLvYF DVbcl0/tfxC86i7jDGFSXaBUFouFztBnVFOR/vBXjiGXZSAzO6dP1/G289RztfQ57iiR K1HQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FK4V3NNM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e7-20020aa7d7c7000000b004eab3b519b4si4529764eds.207.2023.03.07.11.54.27; Tue, 07 Mar 2023 11:54:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FK4V3NNM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233073AbjCGS2V (ORCPT + 99 others); Tue, 7 Mar 2023 13:28:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232927AbjCGS0n (ORCPT ); Tue, 7 Mar 2023 13:26:43 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8245BA2F0D; Tue, 7 Mar 2023 10:20:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 506586154A; Tue, 7 Mar 2023 18:20:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84A4FC433A7; Tue, 7 Mar 2023 18:20:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213246; bh=5kvX7HRO05Aqml11yDkUPLOoDba6HFrNQVxp5lmDDUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FK4V3NNMm3OmmicVSOfFo5G7t1hG8HSWU2y2l8IZBlHXe54s9gGhWvdB9z0BiisX4 oxArsMFWaWeWzsBJQ2JRgSTNNi5GW9DM/DgGWesgfBDn703ldoyna4auED7QRfPICM qe47K41avRIjFxUZJ1xp8Ks6aMf2V+nGmngAP8tEsVlFESKaY/7R5wLo0Uni1pR+AU 6WZtQfJEqeqIc7OOcsasLTkXlaokiYjAbDXVtv380HMwi4dKLucxqN55gLa4f0Pv6Y XaOfbJoHAml01pQB9x242M+QP2bYqTOlsiPpVkfSrUCEOtxZnbnmclxsAexaLR13O9 iPbSeGpBsFgzQ== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen Subject: [PATCH 27/28] igc: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:38 -0600 Message-Id: <20230307181940.868828-28-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759740052304816193?= X-GMAIL-MSGID: =?utf-8?q?1759740052304816193?= From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index 2928a6c73692..d7ee06d28b50 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -4,7 +4,6 @@ #include #include #include -#include #include #include #include From patchwork Tue Mar 7 18:19:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65782 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2624508wrd; Tue, 7 Mar 2023 11:41:16 -0800 (PST) X-Google-Smtp-Source: AK7set9Rp1vcpOR9s870nCqTZ/zb9fD1aYs/dufybM4JP84ilj5JFdnf+c9M/ERdTqBobGHSPgYt X-Received: by 2002:aa7:d60b:0:b0:4be:d5b8:c007 with SMTP id c11-20020aa7d60b000000b004bed5b8c007mr13834894edr.25.1678218076069; Tue, 07 Mar 2023 11:41:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218076; cv=none; d=google.com; s=arc-20160816; b=jJigZh/aLCDnAKCQK0FTr4GDpC4TyKIgLAKCXogTLjZp74iQkaqDue+3C7lqev70bB PoUP7nQYLDUj31y50pi8WJ+QaPhkDPmXrAzC8GeBIwM3gGtRskNDunbTgSTibSOzl7TN hBGzzbUGrjAKYyPgiAzAEFHM+sShw+WSH2AtDP3dm2F3Ebtqwp3Mat95gp+w1EDF6/jR 40Ijna1Kj1jji9I232YSkRNqFNQu3t3tjaQMJ41quUz4QwiQypI3w82MPWLavEWREN27 GyCGGkH2R0MHHFfdTBvKEp0Yi23JjGc8q0JeTjte29VZpPu3sOr1xOOZN3Fo0F7DOfzl E86g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=T4PhExXrQyJ3V1PKjhtHEjCPING0n8l7c6Z4pX9yEJI=; b=pfhG61rUIO9j3IkyeeY+LDehOywt2hEBynwfIAI0rio2Ztryq5ort8dRtqkZ8a0Vxa pMJ7/Vxg7AsQUx26g8ZUhyIs8/hI5KaINW5QtdbPAObYUkYk9dQVA4LzEeSQO8wKAkhi OXbRpIb40mQF445JL/Ab0nIuHRZ+vkbruDd6xm3ffW0D92uYhiSrGpSBkOOBh7kfgu2h ZcolAdbeiQfLp0ZGOL48H7xgLDnoFLDWeu2fyEcKvUqPSGqJuA5Xhc0SSoTEt0N3l/2t o7tmzJei1eQTn1zfs/XgH6qNzC/kVTTF4PFAUp7W/FYVTryfklBeFLysSQQnPHRr8XpW hHmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aAnO2XEy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z22-20020aa7c656000000b004acdd3b83d2si9016038edr.14.2023.03.07.11.40.51; Tue, 07 Mar 2023 11:41:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aAnO2XEy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231219AbjCGS2Z (ORCPT + 99 others); Tue, 7 Mar 2023 13:28:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231942AbjCGS04 (ORCPT ); Tue, 7 Mar 2023 13:26:56 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 328EEB06E1; Tue, 7 Mar 2023 10:20:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BFB81B819C5; Tue, 7 Mar 2023 18:20:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58D7EC433D2; Tue, 7 Mar 2023 18:20:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213248; bh=+/3xSbuw/CpH0rA4rIXLVesO5yLlQvOJu29BU7PVVoc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aAnO2XEy5qZvJxmDdRFRtFW4oc5onWVDPLMtG2u/zbdf9AS+1k5d8FRe1IVYemhJH CrtZU3AizKsrYNKmer+v86N0ejAkseLmfChJJa0NkJCg6PfmVN+t8IRzNGXupdkcNq g28NWJ4I5mDDwWIwkoqzalvfH/WTBJc20FqKd/YsWHOLFjugygkaql6exqSU9dekhX lH/+XJk+ognGipPn9IWB8imwUqMhdRTgarzzJ70RD2hITCOeza3+aju6izuyIT7n8S ktL2Z9XTAd/6BDdlewRzvOQhxzwRHSxXb6jgFDQPftTTMeN1/wziRB/6COeBxXSogE l4kYlvA/XmXig== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen Subject: [PATCH 28/28] ixgbe: Remove unnecessary aer.h include Date: Tue, 7 Mar 2023 12:19:39 -0600 Message-Id: <20230307181940.868828-29-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739197020635607?= X-GMAIL-MSGID: =?utf-8?q?1759739197020635607?= From: Bjorn Helgaas is unused, so remove it. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h index 8736ca4b2628..63d4e32df029 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h @@ -9,7 +9,6 @@ #include #include #include -#include #include #include #include