From patchwork Tue Mar 7 15:41:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 65681 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2527902wrd; Tue, 7 Mar 2023 08:32:00 -0800 (PST) X-Google-Smtp-Source: AK7set/ESAYjiqSY7JSXzisGaVg0DjK9Y66MC52/KYOeaUHNtHMGemvSoxP9h+rB2hzvt9gdA6qi X-Received: by 2002:a17:906:1643:b0:871:dd2:4af0 with SMTP id n3-20020a170906164300b008710dd24af0mr15890739ejd.26.1678206720632; Tue, 07 Mar 2023 08:32:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678206720; cv=none; d=google.com; s=arc-20160816; b=pzlwXTwVNhHot4BWMmda55Cdp+AfkpR05lwrnLjP3fsN96ED24RA1V5DkmrajFTp+R 49gyYpz7/IyC6kzb6/fmzqlYxh3JoN4GSHP4k5nsERPpQ6HZG0sAEB9xLJ+/IyRToGo/ D6w3XCIic2ds1vYeS0fivWFwXX/hwTNq/7zzUnGWB97ZQC5XXXAcCjynFrZN7FBBubKG uslKgC9qVtsylVWcwZ5Bk9XQdtTWvdVW5Qj1/F7SNTeEbVvivKYYzmsetreQoyYzeVHO dcrtE7YHtAKd3DR7vZ1Z/SBzQHzThbDaEXregptk4W3ayWDo+9b384CXBg9Ye1Kz0Kth kZkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=sUgc1Ip6cph68cI1VgRBJ11BMagx1vc6BYllZnRAv3w=; b=dMGQ7/v+FanVA+J42RlzveOyOxYdAASC2GDghnI7kBIobX4D+OfSIVneEODi0ALQYt ZDcRV2EJY8sGzlpbodCcsR0kfebSwcZIL34Hd3BaMsngXNJ2++HgeWM7BYQeOENlHM98 o6+eNIs7nCFNhhQEN9wWjx2Avx/HHs+A9AI/ApwPuDVeB0OZTzWD+VaGTjdh4A5F4Phl dUYlaWJk6jRx5V0GyIV2I6IE7VZLwAHz71R18v3E4xAusOCkPk35KAMs/lCw0zMcTUTN JBErVrbABcRmOaXekP04RMUQykGrsAQLORpWFEN7PfsH4SAaZlS4ZSaqzi8yYxrQ++l0 rSfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=WyvczoL1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw22-20020a170906479600b008ccc0fd3d13si9071087ejc.348.2023.03.07.08.31.36; Tue, 07 Mar 2023 08:32:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=WyvczoL1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230214AbjCGQCC (ORCPT + 99 others); Tue, 7 Mar 2023 11:02:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231521AbjCGQBe (ORCPT ); Tue, 7 Mar 2023 11:01:34 -0500 Received: from m12.mail.163.com (m12.mail.163.com [123.126.96.234]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F29B897B4A; Tue, 7 Mar 2023 07:59:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=sUgc1 Ip6cph68cI1VgRBJ11BMagx1vc6BYllZnRAv3w=; b=WyvczoL1xuThhrxy0sLmV ggpzJmFx998EVhMmDw2cJPLllv24/k9rLP7GuUMxht55hhronISquD/Y8c6it3Rg SKBPLmkQ8XE4ETluHitderHr0BXJ3wTO4y6pJq7tFS/KWvYZDGhn3VXlAfdwX521 UQGOFWcpxw5ptqZeV4vQDU= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by smtp20 (Coremail) with SMTP id H91pCgDnsbZHWwdkkSMIGw--.40718S2; Tue, 07 Mar 2023 23:41:59 +0800 (CST) From: Zheng Wang To: ezequiel@vanguardiasur.com.ar Cc: p.zabel@pengutronix.de, mchehab@kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH] media: hantro: fix use after free bug in hantro_remove due to race condition Date: Tue, 7 Mar 2023 23:41:57 +0800 Message-Id: <20230307154157.1184826-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: H91pCgDnsbZHWwdkkSMIGw--.40718S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Wry3Xw4kJw47Jr4rWr4kZwb_yoW8GF4rpF W7trW3CrWjqr42gFn7Jw409ayrCa4agF4xWrZruw13AF9xtr9rGry0y3W8AF98JrZ3ZFWa qF48Kr48X3y2vFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0ziID73UUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiXBErU1Xl52W08AABsC X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759724997007995964?= X-GMAIL-MSGID: =?utf-8?q?1759727290301133371?= In hantro_probe, vpu->watchdog_work is bound with hantro_watchdog. Then hantro_end_prepare_run may be called to start the work. If we close the file or remove the module which will call hantro_release and hantro_remove to make cleanup, there may be a unfinished work. The possible sequence is as follows, which will cause a typical UAF bug. The same thing will happen in hantro_release, and use ctx after freeing it. Fix it by canceling the work before cleanup in hantro_release. CPU0 CPU1 |hantro_watchdog hantro_remove | v4l2_m2m_release | kfree(m2m_dev); | | | v4l2_m2m_get_curr_priv | m2m_dev->curr_ctx //use Signed-off-by: Zheng Wang --- drivers/media/platform/verisilicon/hantro_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/verisilicon/hantro_drv.c b/drivers/media/platform/verisilicon/hantro_drv.c index b0aeedae7b65..80bd856a4da9 100644 --- a/drivers/media/platform/verisilicon/hantro_drv.c +++ b/drivers/media/platform/verisilicon/hantro_drv.c @@ -1099,6 +1099,7 @@ static int hantro_remove(struct platform_device *pdev) v4l2_info(&vpu->v4l2_dev, "Removing %s\n", pdev->name); + cancel_delayed_work(&vpu->watchdog_work); media_device_unregister(&vpu->mdev); hantro_remove_dec_func(vpu); hantro_remove_enc_func(vpu);