From patchwork Tue Mar 7 15:51:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 65673 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2519553wrd; Tue, 7 Mar 2023 08:15:51 -0800 (PST) X-Google-Smtp-Source: AK7set9eYIP1RnlC5fv9t93DLJnEiRMM0kqPe3kBxw2RpszpSMaM/mY2n+wiMtBfAvLQsY1mhJyh X-Received: by 2002:a05:6a20:49aa:b0:cd:53b0:960d with SMTP id fs42-20020a056a2049aa00b000cd53b0960dmr12126537pzb.10.1678205751001; Tue, 07 Mar 2023 08:15:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678205750; cv=none; d=google.com; s=arc-20160816; b=GpOXpz2CZ02MYvUNDqsNqqXMihXSNMPW128pNzeVtk8BO0yntz92HLNmGJS929cMVw NBhbF1Z/cZurBtQmEx0FW38jGW/Mbax5MZjsGyWE3K+HSQpP7mLrljpPEEnAsLAT2wBB bZ8I5Ti2gEN4m3lpXnIfryEIxO7qr+pi0tNZQOmc+onai9TWxbskNJ9qpQW3T/XtnikU aTtRNm7TlVcXXE/at0WST8iTTn/SLz5YJoFsk4wTzOE/0SOMpPdaP2t8EpVRAnrCWNct TyKJHBwS8R1NRjtfUZ/vM6uKEXDBENbS8yz0I1ZDxcfgscwsfec8WCh0iOAphDNhSzsh oqlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=yaCugjNm/G2Z6PUshJITW/CcWRfLta4oMrbycqzUiTw=; b=WtUsh1lw9cv0rowAW3cGR/NbGxvpkzQOlV+6jh9oE7oILj/nEK5TDeGfp7ClK62tF8 SQuHWFWD2jrlwl6uiPRVCQUHmJhl1o9fmzwviV8CiMtNOn03DaRZHZzAdrMmin+/NYGR EUqlIHle5vySzC35icK8vlgWsI9uHlem3P2cRsfuN8aTj30+6PO0RSh0h2+dtnGawicW Gxt406aLQfb4eGWKWMuNdyCJr1BTFv+CLLXuj7jYAcIvwTkzsAPDppC26j4IqUq9uE8o bc2KpeAeuSry4CrSYsxHzspDjNPsyba760jpIXneNXuCxe7f/Oqbqs9VoZU47jTa+rJv fPvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ofWVW8v5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r22-20020a632b16000000b005033b0e1c2fsi12272809pgr.697.2023.03.07.08.15.36; Tue, 07 Mar 2023 08:15:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ofWVW8v5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229748AbjCGPvT (ORCPT + 99 others); Tue, 7 Mar 2023 10:51:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229624AbjCGPvR (ORCPT ); Tue, 7 Mar 2023 10:51:17 -0500 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A95448E21 for ; Tue, 7 Mar 2023 07:51:16 -0800 (PST) Received: by mail-ot1-x32f.google.com with SMTP id e26-20020a9d6e1a000000b00694274b5d3aso7381944otr.5 for ; Tue, 07 Mar 2023 07:51:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678204276; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=yaCugjNm/G2Z6PUshJITW/CcWRfLta4oMrbycqzUiTw=; b=ofWVW8v5IS/sfA2wpQoe3EPCDzB6NbRGvZfG/XP5+Rgr2hhIxEHlRTtgPHdftwvUmN V+4dLMf0bX3Qtj7+LeSTS1X576ZrS+iOxNml5NFce7UsaBKtgmOeXldVQwZrloheumYa 1EnC/9u7bbFYEzYJluPMGfBAALrjxz5dZFVWlf6CgQ9LhKi8qBFy8ZKYIi886g9AZxN5 9nQLu/EslJ3R0E+dCly00J/aWgyyhIX06tQgO2UYfML/MMtqNdpr2ArH7ySZ8BDEyn+a LUEqyjRwJ1XQ6sxvxt9xhIn/1hafWFK6DhzqLToSds8v3TVrWzS/N/9aTxREMpitQJ+F 911w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678204276; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yaCugjNm/G2Z6PUshJITW/CcWRfLta4oMrbycqzUiTw=; b=cwXZwAQ6M0MxnO6F4AzETbIFm+D+DU4GCYgPH0la5L2LFU7shnxmQAtm7WwI3roWtN v0jcIOdUNCOwgoGlAogdynMpb8HVYC3IowK5NpRqgp1dCp+EguOKGjpD1IbtTKrxNy0X JjJuMrATyQc8qadfbmkkWgWCVELgsOsRlsNb+GdERTrhanewX5eqcehuVTcmd6KpQ5ML X4pim5a3GUm/2UQBJUqYD+/iDsbuPCRD0mjwZQkHr8zR3A8sHhFN0rViZL6eOtAOJ6EL 5T+NGny/l0ciXfG/jfHcxEC4lCo8kxhePV4IZDLoy4lmtQAPeuJYv6g8csfIFodI7SkB L7TA== X-Gm-Message-State: AO0yUKVbgPPekuI2tbQsdClZ0n4fLf152v1kIbsRma7RMCggbzwIrDaq QUZsBfBEAU4/2BeLUAYrPzv1NJZ3OY0= X-Received: by 2002:a9d:17cd:0:b0:670:885e:f8ff with SMTP id j71-20020a9d17cd000000b00670885ef8ffmr6011313otj.8.1678204275839; Tue, 07 Mar 2023 07:51:15 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id b26-20020a9d479a000000b0068bcb44e7f5sm5417243otf.68.2023.03.07.07.51.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 07:51:15 -0800 (PST) Sender: Guenter Roeck From: Guenter Roeck To: Support Opensource Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Guenter Roeck , David Rau Subject: [PATCH] ASoC: da7219: Initialize jack_det_mutex Date: Tue, 7 Mar 2023 07:51:11 -0800 Message-Id: <20230307155111.1985522-1-linux@roeck-us.net> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759726273434045733?= X-GMAIL-MSGID: =?utf-8?q?1759726273434045733?= The following traceback is reported if mutex debugging is enabled. DEBUG_LOCKS_WARN_ON(lock->magic != lock) WARNING: CPU: 0 PID: 17 at kernel/locking/mutex.c:950 __mutex_lock_common+0x31c/0x11d4 Modules linked in: CPU: 0 PID: 17 Comm: kworker/0:1 Not tainted 5.10.172-lockdep-21846-g849884cfca5a #1 fd2de466502012eb58bc8beb467f07d0b925611f Hardware name: MediaTek kakadu rev0/rev1 board (DT) Workqueue: events da7219_aad_jack_det_work pstate: 60400005 (nZCv daif +PAN -UAO -TCO BTYPE=--) pc : __mutex_lock_common+0x31c/0x11d4 lr : __mutex_lock_common+0x31c/0x11d4 sp : ffffff80c0317ae0 x29: ffffff80c0317b50 x28: ffffff80c0317b20 x27: 0000000000000000 x26: 0000000000000000 x25: 0000000000000000 x24: 0000000100000000 x23: ffffffd0121d296c x22: dfffffd000000000 x21: 0000000000000000 x20: 0000000000000000 x19: ffffff80c73d7190 x18: 1ffffff018050f52 x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 x14: 0000000000000000 x13: 0000000000000001 x12: 0000000000000001 x11: 0000000000000000 x10: 0000000000000000 x9 : 83f0d991da544b00 x8 : 83f0d991da544b00 x7 : 0000000000000000 x6 : 0000000000000001 x5 : ffffff80c03176a0 x4 : 0000000000000000 x3 : ffffffd01067fd78 x2 : 0000000100000000 x1 : ffffff80c030ba80 x0 : 0000000000000028 Call trace: __mutex_lock_common+0x31c/0x11d4 mutex_lock_nested+0x98/0xac da7219_aad_jack_det_work+0x54/0xf0 process_one_work+0x6cc/0x19dc worker_thread+0x458/0xddc kthread+0x2fc/0x370 ret_from_fork+0x10/0x30 irq event stamp: 579 hardirqs last enabled at (579): [] exit_to_kernel_mode+0x108/0x138 hardirqs last disabled at (577): [] __do_softirq+0x53c/0x125c softirqs last enabled at (578): [] __irq_exit_rcu+0x264/0x4f4 softirqs last disabled at (573): [] __irq_exit_rcu+0x264/0x4f4 ---[ end trace 26da674636181c40 ]--- Initialize the mutex to fix the problem. Cc: David Rau Fixes: 7fde88eda855 ("ASoC: da7219: Improve the IRQ process to increase the stability") Signed-off-by: Guenter Roeck --- sound/soc/codecs/da7219-aad.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/da7219-aad.c b/sound/soc/codecs/da7219-aad.c index 4a4f09f924bc..e3d398b8f54e 100644 --- a/sound/soc/codecs/da7219-aad.c +++ b/sound/soc/codecs/da7219-aad.c @@ -968,6 +968,8 @@ int da7219_aad_init(struct snd_soc_component *component) INIT_WORK(&da7219_aad->hptest_work, da7219_aad_hptest_work); INIT_WORK(&da7219_aad->jack_det_work, da7219_aad_jack_det_work); + mutex_init(&da7219_aad->jack_det_mutex); + ret = request_threaded_irq(da7219_aad->irq, da7219_aad_pre_irq_thread, da7219_aad_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT,