From patchwork Tue Mar 7 15:35:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 65642 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:570d:b0:a1:2e52:cf23 with SMTP id h13csp1973320dyk; Tue, 7 Mar 2023 07:46:14 -0800 (PST) X-Google-Smtp-Source: AK7set9Q3nDTWMfRtqdJqYe0QGM28sTrB8ie+AufjfbK/oslQr1tuPDJIT9qxAa2HBWs94rJ74ye X-Received: by 2002:a17:902:e744:b0:19c:d169:cb3f with SMTP id p4-20020a170902e74400b0019cd169cb3fmr19843021plf.21.1678203974603; Tue, 07 Mar 2023 07:46:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678203974; cv=none; d=google.com; s=arc-20160816; b=hhUgQv07qipFseazfzGALfZCfKeI730dwKqcGrCnJZbG17IZQ5jHxb5tzPnZb9b4A/ 6NO8lCwv82U8c9ugrwspO8C3bS1MLysRojO0qnUy5u17ewtlx8FWgyBLORZS87qA1ZlI SoOG41xdEcuDBpwdM24wytk/XDpEf7jvNTOuzoG0ScLUu98y3GqWZtii0KnYXTqxnjHb CLCmEQi08U5KL7LukK9DK9dCVFiI0Ot1Y1zEgDThIJfL30Mth50Art7UG5gnLfL1+wsi uEtakNOV7HsQFyqatKVnOrnrOwvEnoVVWnw+mwsrJgv7YbqImHhh7Lvcj7cf/WBdo26V +b/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iL0BA0gE4EmKLeYtSSOEBUD0N390Hz2s7HW1XrquUFw=; b=CjuTk8KUyZwJqwsNjmVZLEwfxXOnQBOi3e/A3FpYK0ID0q78Xb3aoVbJFq8/vJongK uT+kYRn8sL3ohbLiRyJEw/w5greDEeWW6qPIzf3hNjUHpnZu4LNVJ6kN9qXKdFoqHJdb 0EBwuzUfRTc3PBV4sYvmUEAcTMrrNLZVj7r9wcgnj/eqXQBbXUXXa8GHRZvslkHFrzPJ 1kH/ZFEKiVGRDiLVMwRyLaG5rLQtWXyMu9XP+04VdTYUDLRr7xOfLwB8hLWCLRIW3XPc VrDnO2POxgUkIAPI1hMWo4AIZB+aoD9pjHQSIFdrdV9IyIo8W5wF62H3o03A+689pR3c zq5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=BoNuXBr1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h22-20020a170902ac9600b0017f7faef235si12085822plr.148.2023.03.07.07.46.02; Tue, 07 Mar 2023 07:46:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=BoNuXBr1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231466AbjCGPhq (ORCPT + 99 others); Tue, 7 Mar 2023 10:37:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231467AbjCGPh3 (ORCPT ); Tue, 7 Mar 2023 10:37:29 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.216]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 43EC78093C; Tue, 7 Mar 2023 07:36:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=iL0BA 0gE4EmKLeYtSSOEBUD0N390Hz2s7HW1XrquUFw=; b=BoNuXBr1Y5eer5pvkhVcA LBwFwIfMzogGFEbGCTI3atjdmrC+c8i6c9Tg3NtyRAn03LR/7oYbEcqQmu9OTR1a y/gwPpVN+o065CVRdYkm63SH66BpRDmFFzYAbKIY5oFKM036X4cZ8apvSf5rG2KP G5xpPkfbuL5wCD1RUNi/t0= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g2-2 (Coremail) with SMTP id _____wD3LifPWQdkZzrLCQ--.14702S2; Tue, 07 Mar 2023 23:35:43 +0800 (CST) From: Zheng Wang To: ezequiel@vanguardiasur.com.ar Cc: p.zabel@pengutronix.de, mchehab@kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH] media: hantro: fix use after free bug in hantro_release due to race condition Date: Tue, 7 Mar 2023 23:35:42 +0800 Message-Id: <20230307153542.1178065-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wD3LifPWQdkZzrLCQ--.14702S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Wry3Xw4kJw47Jr4rWr4kZwb_yoW8GF13pF W7GrW7CrWjqF42gFnrJw409ayrCa4YgFW3Wrsru343AF9xtrnrGrW0y3W8AF9rtrZ3ZF45 XF48KrWrX39FvFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zi-eOJUUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiXBErU1Xl52W07wAAsc X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759724410782863805?= X-GMAIL-MSGID: =?utf-8?q?1759724410782863805?= In hantro_probe, vpu->watchdog_work is bound with hantro_watchdog. Then hantro_end_prepare_run may be called to start the work. If we close the file or remove the module which will call hantro_release and hantro_remove to make cleanup, there may be a unfinished work. The possible sequence is as follows, which will cause a typical UAF bug. The same thing will happen in hantro_release, and use ctx after freeing it. Fix it by canceling the work before cleanup in hantro_release. CPU0 CPU1 |hantro_watchdog hantro_remove | v4l2_m2m_release | kfree(m2m_dev); | | | v4l2_m2m_get_curr_priv | m2m_dev->curr_ctx //use Signed-off-by: Zheng Wang --- drivers/media/platform/verisilicon/hantro_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/verisilicon/hantro_drv.c b/drivers/media/platform/verisilicon/hantro_drv.c index b0aeedae7b65..cf00ccaa7829 100644 --- a/drivers/media/platform/verisilicon/hantro_drv.c +++ b/drivers/media/platform/verisilicon/hantro_drv.c @@ -601,6 +601,7 @@ static int hantro_release(struct file *filp) * No need for extra locking because this was the last reference * to this file. */ + cancel_delayed_work(&vpu->watchdog_work); v4l2_m2m_ctx_release(ctx->fh.m2m_ctx); v4l2_fh_del(&ctx->fh); v4l2_fh_exit(&ctx->fh);