From patchwork Tue Mar 7 07:30:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dongliang Mu X-Patchwork-Id: 65311 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2298683wrd; Mon, 6 Mar 2023 23:49:36 -0800 (PST) X-Google-Smtp-Source: AK7set/qKtm3W27mCCv1Dkx/VcS5v/ZiI0Y30OXSS4J5lxlqZO/6AHxUZoytHznhZLU30CWEGWzw X-Received: by 2002:a17:902:da90:b0:19c:e405:4446 with SMTP id j16-20020a170902da9000b0019ce4054446mr16103387plx.30.1678175376316; Mon, 06 Mar 2023 23:49:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678175376; cv=none; d=google.com; s=arc-20160816; b=LftKXClqwx9nPyChZiXdBFhOhs3seN/CCvWdxmlZzhkWVNZc4uGHgm082JoFCtVGZx wMqVo34+plKY2ysAAmzm97Wmw9e3WWzNUsoB4qJ6mc1HH8TTRhuOalFHd2Q/mhDrB7qU gRSWDP4AIfRkxBUgKO7OXJPAQEMrXxDTHTPxbqo0zQT9KqBI9/3hSnISCMXb1ofxxPUC voIWX2xFETw4+gexLd0Mk1REVT2TEKRGyiRgqbQ+TWmFa8sQ/+8sVRvQuDTnKmgO/Bue d85xwOZrhWuW/VIAsvKgZPWcFdumFKS1Z8GUzE9dnp0nlHxbRAT9zLCOYQq2CgLH8DoQ JKoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=axcHpB1O5LRntnOEx733oBkfW5mEW0ifZ2goNC5+VDg=; b=BYr8McSx9szXAGl57H1PGNF30nVAhfQwSDkDrYP+0Phr3T8ZxOyIrqhanYPGL9ZP18 v3737zqo3FO2J7NcA8qb+H15GfLwUF57eKl6YZIyOnyIzKgydV0JXMHySnsjIv4Jx9D/ MHY4X/EJ+D0LhPTzIED/HYzbUroLFGiAILzFC6EW2QIrLUfRDolV56Hu3qI31qEsulU3 xR3qzxEpiZj7NyDkSnb1U5ULdCxPAMhWyaJdXeIOLYfEg8sAzNk8flBVNJo/TpxfV3w2 ISYkXrgMvrjTmk8sA6KgBTcEyacZ+aFvNxOn88Hg2PlFpzAFhG4ubFHQ+HA/SN/ToL+5 LeiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c7-20020a654207000000b004f288fe9a47si11218318pgq.520.2023.03.06.23.49.24; Mon, 06 Mar 2023 23:49:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230293AbjCGHb6 (ORCPT + 99 others); Tue, 7 Mar 2023 02:31:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229582AbjCGHbz (ORCPT ); Tue, 7 Mar 2023 02:31:55 -0500 Received: from hust.edu.cn (unknown [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 419944DE2D for ; Mon, 6 Mar 2023 23:31:53 -0800 (PST) Received: from pride-PowerEdge-R740.. ([172.16.0.254]) (user=dzm91@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 3277U5pJ009289-3277U5pM009289 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 7 Mar 2023 15:30:10 +0800 From: Dongliang Mu To: Alexander Aring , Stefan Schmidt , Miquel Raynal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Dongliang Mu , syzbot+bd85b31816913a32e473@syzkaller.appspotmail.com, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: ieee802154: fix a null pointer in nl802154_trigger_scan Date: Tue, 7 Mar 2023 15:30:03 +0800 Message-Id: <20230307073004.74224-1-dzm91@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-FEAS-AUTH-USER: dzm91@hust.edu.cn X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759694423429150212?= X-GMAIL-MSGID: =?utf-8?q?1759694423429150212?= There is a null pointer dereference if NL802154_ATTR_SCAN_TYPE is not set by the user. Fix this by adding a null pointer check. Reported-and-tested-by: syzbot+bd85b31816913a32e473@syzkaller.appspotmail.com Signed-off-by: Dongliang Mu --- net/ieee802154/nl802154.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c index 2215f576ee37..1cf00cffd63f 100644 --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -1412,7 +1412,8 @@ static int nl802154_trigger_scan(struct sk_buff *skb, struct genl_info *info) return -EOPNOTSUPP; } - if (!nla_get_u8(info->attrs[NL802154_ATTR_SCAN_TYPE])) { + if (!info->attrs[NL802154_ATTR_SCAN_TYPE] || + !nla_get_u8(info->attrs[NL802154_ATTR_SCAN_TYPE])) { NL_SET_ERR_MSG(info->extack, "Malformed request, missing scan type"); return -EINVAL; }