From patchwork Mon Mar 6 19:55:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65085 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2042775wrd; Mon, 6 Mar 2023 11:57:50 -0800 (PST) X-Google-Smtp-Source: AK7set/sXZefybV7yNf4GA322mfbwh6iE3wef3OKr/2QLyneLkwQffe/kvH9c5o8Y1mA9KIK3k4U X-Received: by 2002:a17:907:c28b:b0:861:4671:a834 with SMTP id tk11-20020a170907c28b00b008614671a834mr11462840ejc.71.1678132670613; Mon, 06 Mar 2023 11:57:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678132670; cv=none; d=google.com; s=arc-20160816; b=07M/QcYUKU2EKmRDB8Y+eG6rck3gM30rFVkobFqekgXagJmWt/UAbA+lOMZiKWMJRJ D3UoPRFsm76Ze7GnhmWp9uJ9ldDHAKFtUbyRTx35/b3VM+Hg/zssxxwRyc9hB/szCYUd NV2UGZtUgM5lJcCw5kJm9/LV7rl5WCWzWogUa6agwUoSzr0kgrIDt+qTnYh2yuS7KqPw +aHsuKkFsM6QW159461vRtSfsEfKksRNef0ga8Hu7dwuXYF/Fux8U1wYJMdYjm3x5Zn0 ULYvakf4ya8dSq6bFh1WCivIAVhkeW/+Rua3M5SioNN7qf8bhV57XVD2nwNIBGWMBi3C upZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JStrp9vmE+9A7yS6nNr5GDoR4bn7OVOmvRcL18PDVZ4=; b=RazXlqrwG2F861veDjLaetbIX+4iY+CTHiq7Mi+Wa36Cqu0ZLlBTMxDLxioSethUIc WsTJy+6q8I3RXuzcoq6i11gAl6aVOL5eGSlSc9ucftHZupkOqlY+j2Y1xS4pzq3ujfAx 5asH6F82Sb+YZ21eKdbST08/GxDlRxpReQEw+A0e4UWMNva6OH35fNC1UAaXw5YNSSFf E4PMpE8/C+8k3Wyj3SkUgBbp3HnGXNPYFOc6uKjGJSVFCJnHblSFEnjq0WZC/bgkxSYB bAips9TBQMwwh6yG8n4KPxiXDafDe5cmzVoIbAizxt5m4AOQ8g2halqScYCI4CAPoIyE jLcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gAKe6b7s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rn8-20020a170906d92800b008d3be841cbbsi6571659ejb.442.2023.03.06.11.57.25; Mon, 06 Mar 2023 11:57:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gAKe6b7s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230173AbjCFTzk (ORCPT + 99 others); Mon, 6 Mar 2023 14:55:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230031AbjCFTzg (ORCPT ); Mon, 6 Mar 2023 14:55:36 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F4E967015; Mon, 6 Mar 2023 11:55:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132534; x=1709668534; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8ZrKn/GVsbCbQusAgr1EBS9ndoJY9gSV2vmluFfDt5o=; b=gAKe6b7sIh15P7c7vUId1A069KlEP95UVSND0VQcq3rtgZibCklAvLdz PETqpbBZ8a34iHB1LaY1SR7DTHxu5lwT2453IRA8iOGz2uzxsRN9EgX30 IaCTbOsfhU8684PTnKnauK6yNPKfG/nQe8nWROcyWmbVnZdXjcypwlRFx ZR2lUVVrvxEcRPc1glCi8PN+PduK2dgcaX8WVSEgJDudAASuM6HnGyU+i xGFvAlZhfCiyFa2ralWomq7fjO45BxlgtJPMkSi6nQ12LdnGjgifINOfq 4C7hhQOUDJj9mjFvfhZrYv1tMD9CJh7/DJGTpfPhNqAhYruiVhDD8PEzo A==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="400483867" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="400483867" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="1005549560" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="1005549560" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 06 Mar 2023 11:55:28 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 491E9154; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 01/16] lib/string_helpers: Add missing header files to MAINTAINERS database Date: Mon, 6 Mar 2023 21:55:41 +0200 Message-Id: <20230306195556.55475-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759649643271608232?= X-GMAIL-MSGID: =?utf-8?q?1759649643271608232?= The header files string.h and string_helpers.h are missing in the MAINTAINERS. Add them. Signed-off-by: Andy Shevchenko --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 20544cbdace9..ee157981c4cf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8615,6 +8615,8 @@ F: drivers/input/touchscreen/resistive-adc-touch.c GENERIC STRING LIBRARY R: Andy Shevchenko S: Maintained +F: include/linux/string.h +F: include/linux/string_helpers.h F: lib/string.c F: lib/string_helpers.c F: lib/test_string.c From patchwork Mon Mar 6 19:55:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65103 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2050524wrd; Mon, 6 Mar 2023 12:13:41 -0800 (PST) X-Google-Smtp-Source: AK7set+FHi9WwJJSb03ns2kbRN997H4YqBHNZ46RBgM2sPsn9ZdCHnUq+2K33gwzBHhAR5OHF5so X-Received: by 2002:aa7:db53:0:b0:4ab:15d9:2dae with SMTP id n19-20020aa7db53000000b004ab15d92daemr11917794edt.14.1678133621198; Mon, 06 Mar 2023 12:13:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678133621; cv=none; d=google.com; s=arc-20160816; b=FdLwIJMbll1ag0HoZR7b8wOwpz0dxyKtr2/uRZh3Dv9L44P2siwoOF0DPrJ63ze2za QNeBKqICjmnl83oCDaaxP1RrXJLzeF0Y7AUpTcSctrxO94zZtB/sOhJUMsRm7szz4e9y 1U0sB+iZWQa6BeocckGwo1MV/o770SyZyXvPkAXjmepknaA42bb58IFste9jZxOyzpCr hHUOVaczFfRKJHCJOosnaAibvjUNlh8Ief1oIo8HZQsnXlj3lgebzEP5/NGOsRDYS7jZ SkLvdFPZHlPktkMe7YXDqqnVYCyOgNvLk8yqFxiiQlMxPsnJNbLKr4Ouz8kvWdBktHlx u1Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0aaaPCGXjtKb6VKzvmbdizST9KzGixK2rrOzfYoxX1k=; b=eqRityvS0rDrYdPTRKOnWIvtZwQq+eekBLzFTRIKY1FGAULGsNXZbBo7wlCppl5SX0 wmwaCzwQh+sHm4/uv0AJuemSW5WcFoTm3vYc41QTaUP8NakmTnkia12U0DCKlma7J3Hv hzQ01gvuuRVqM2AoxdaHwnCRZ3ElBT/Hm4Mtvj96HFa7h/pFxNeQrUI1+DjwslCRxe5x /LkfF6EDT2Y2MEshUsrKwjEi6eCAUFGtlqllo09nZf+I/Lunym8DB7HntDOX+Z7bHNVd zu23lvqyrYg8l8WXCYNsBjLAp0ZipXiq/6cBKUAPrt32AHTJ1AL7Z8/hJnXCFEwvIRQt iffQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XfhWqvcy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w22-20020aa7d296000000b004c0cee0afb2si11797847edq.536.2023.03.06.12.13.16; Mon, 06 Mar 2023 12:13:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XfhWqvcy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229849AbjCFTzm (ORCPT + 99 others); Mon, 6 Mar 2023 14:55:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230158AbjCFTzh (ORCPT ); Mon, 6 Mar 2023 14:55:37 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCD4A6A047; Mon, 6 Mar 2023 11:55:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132534; x=1709668534; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=oNHVpcFZrYbfI1Ngidi0XIrUh6MQDoXmEl3L94PnfHU=; b=XfhWqvcyPsRKzmhAdVrKDvjnA2LlpiSOVcEuIaWKqEo1O8yQhG7giLOT IQ3W8lvAmA9eC3DJaOOP20WK5SS1Yzh0Pu7+x3vSmG1AdJDcV+nXJ4x38 l5HZrIIIDxVLKbhCZdRBAmJWRY6rLKRjqYbwVO6RmFxiDwA/llLZCzbkq OQ1GDi0c0yL6vxEa4syE5myMRP6ydF5WRtxkVuFuzGtOzH8va3wZITDC+ dgp+xyYqRY+LY3wsqkmRrdQlQ+2Tt0dW2h0qV8Jn6VfOrN2UycCeJjfcH D/VBSxWTjXneCmPsvyd8RluMTkSpmaOIFYQ/iR0tKE7zEVa4g58/u/eOD w==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="400483882" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="400483882" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="1005549561" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="1005549561" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 06 Mar 2023 11:55:28 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 57F61354; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 02/16] lib/string_helpers: Split out string_choices.h Date: Mon, 6 Mar 2023 21:55:42 +0200 Message-Id: <20230306195556.55475-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759650639498057799?= X-GMAIL-MSGID: =?utf-8?q?1759650639498057799?= Some users may only need the string choice APIs. Split the respective header, i.e. string_choices.h. Include it in the string_helpers.h for backward compatibility. Signed-off-by: Andy Shevchenko --- MAINTAINERS | 1 + include/linux/string_choices.h | 32 ++++++++++++++++++++++++++++++++ include/linux/string_helpers.h | 26 +------------------------- 3 files changed, 34 insertions(+), 25 deletions(-) create mode 100644 include/linux/string_choices.h diff --git a/MAINTAINERS b/MAINTAINERS index ee157981c4cf..64f19e200191 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8616,6 +8616,7 @@ GENERIC STRING LIBRARY R: Andy Shevchenko S: Maintained F: include/linux/string.h +F: include/linux/string_choices.h F: include/linux/string_helpers.h F: lib/string.c F: lib/string_helpers.c diff --git a/include/linux/string_choices.h b/include/linux/string_choices.h new file mode 100644 index 000000000000..b7e7b9fd098c --- /dev/null +++ b/include/linux/string_choices.h @@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _LINUX_STRING_CHOICES_H_ +#define _LINUX_STRING_CHOICES_H_ + +#include + +static inline const char *str_enable_disable(bool v) +{ + return v ? "enable" : "disable"; +} + +static inline const char *str_enabled_disabled(bool v) +{ + return v ? "enabled" : "disabled"; +} + +static inline const char *str_read_write(bool v) +{ + return v ? "read" : "write"; +} + +static inline const char *str_on_off(bool v) +{ + return v ? "on" : "off"; +} + +static inline const char *str_yes_no(bool v) +{ + return v ? "yes" : "no"; +} + +#endif diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h index fae6beaaa217..0f2255738940 100644 --- a/include/linux/string_helpers.h +++ b/include/linux/string_helpers.h @@ -5,6 +5,7 @@ #include #include #include +#include #include struct device; @@ -113,29 +114,4 @@ void kfree_strarray(char **array, size_t n); char **devm_kasprintf_strarray(struct device *dev, const char *prefix, size_t n); -static inline const char *str_yes_no(bool v) -{ - return v ? "yes" : "no"; -} - -static inline const char *str_on_off(bool v) -{ - return v ? "on" : "off"; -} - -static inline const char *str_enable_disable(bool v) -{ - return v ? "enable" : "disable"; -} - -static inline const char *str_enabled_disabled(bool v) -{ - return v ? "enabled" : "disabled"; -} - -static inline const char *str_read_write(bool v) -{ - return v ? "read" : "write"; -} - #endif From patchwork Mon Mar 6 19:55:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65089 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2043486wrd; Mon, 6 Mar 2023 11:59:47 -0800 (PST) X-Google-Smtp-Source: AK7set+qIx2Mmr1ibRAx2ST2QNakAJZd4XhwROO3U81ytLZ42EyR9GYN1aTtXM4Hgh7nUL7tMCq6 X-Received: by 2002:a17:906:dac3:b0:8a9:fa2f:e440 with SMTP id xi3-20020a170906dac300b008a9fa2fe440mr15777443ejb.55.1678132787694; Mon, 06 Mar 2023 11:59:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678132787; cv=none; d=google.com; s=arc-20160816; b=FrPRUfUYRzJLRXw3qvtDXVKk0qsIZJlID1UVIkVD9P2RJh+Q72giydShL4uT4yu4gQ LkQVwI1e5GXHWje3ylq1F0uZNRPB553S71hxuOeXuohkMlinOK7AgLib/AxATP0APuhP bAMPQHucRkhxbU4bMETrxPt22x3LBL4tBhS6rVnGExNQsHA647xQgvTpng3fjEJm3zA9 gaVgIE1WUREIwvfY03/8NAn6P3otjO+IGCoSojJnHZd0CP1tAG4uZ42yI+l+oF+s1vTv onrQVzsLMP6eYBoPsdzVLFnu0/QlatrI7N5IePVU9GVdW0Z1zwVVWOv4fcb4rlnyr0jj texA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dHjEZYW/3mkHo7wTv6lwmV2wtoxDgXMhkfHjwstp0Pk=; b=0OhYU333YN+c0zK4W9jEeD+VEXIsAgoxMsr5dWjxHbb5ywOAB4kumaXd9EiFMPZq28 3xxJPhhdwtfy65U0ZckkJXULYS7GePNL/95th5jY+umJQQRnLxey3w6gJKIuCNNCo5GI zFTCWKDr7tSBhTGrjoGFuTk80ctu8RM1G4zbRJXgl/cITsmxsUD2qO8HBA1mgkAHxSbR uKxfLuM/c1S/iyNTBhJ8mg9qmb/kLN+Rj/WBcLkr+4RqEuZQrmqdQ6mpGRY6t1N6+ezJ e7owIbvkQkzPuo7YRDG6JR9g9jw6qhcP8KXSfXhZFiR4lQtavBtsP5+ULpG0UsEOpSWF MQjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=M8oDdntv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bw1-20020a170906c1c100b008b743d946f1si10709483ejb.706.2023.03.06.11.59.23; Mon, 06 Mar 2023 11:59:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=M8oDdntv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230240AbjCFTzy (ORCPT + 99 others); Mon, 6 Mar 2023 14:55:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230163AbjCFTzk (ORCPT ); Mon, 6 Mar 2023 14:55:40 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA65256522; Mon, 6 Mar 2023 11:55:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132539; x=1709668539; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kqgmkF6/LXf8ZTPjacKEJCrkdjdR/gKDvDdM5DRJJDo=; b=M8oDdntv+9UpQtYk5qzoJH7JFWjdMGIAbklgz13ZXpmCoKTW7YSLPwcO jsEetOsNV35aA0aIoQTMSqX56fHK5j7AKKUvMZjoH/ji/30rUQUgtVexm l//OVMAuJIXLy2FdThuKuIvUH9GIwOGCOXVh2cX3ejQmkJfMJcaLiiBl3 Pa6dEreOcBtPOGtl3UMg+VYjVhe7AsXTdnOI4CwEr7fELSXsiCZmh6bwM Dm1/vfULvwGHGnXvaybyq03aWecIGf8XnK6HDKl0qyymYy9ReUGwYNdvw aDny+kmEL+kPzCpYIKFxCxP6FM0VlixffyVQazILUVm7NSwh8H+I9wWKH g==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="398240771" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="398240771" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="819423553" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="819423553" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 06 Mar 2023 11:55:28 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 61EF6367; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 03/16] lib/string_choices: Add str_high_low() helper Date: Mon, 6 Mar 2023 21:55:43 +0200 Message-Id: <20230306195556.55475-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759649765554902056?= X-GMAIL-MSGID: =?utf-8?q?1759649765554902056?= Add str_high_low() helper to return 'high' or 'low' string literal. Also add an inversed variant, i.e. str_low_high(). All the same for str_hi_low(). Signed-off-by: Andy Shevchenko --- include/linux/string_choices.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/include/linux/string_choices.h b/include/linux/string_choices.h index b7e7b9fd098c..48120222b9b2 100644 --- a/include/linux/string_choices.h +++ b/include/linux/string_choices.h @@ -14,6 +14,18 @@ static inline const char *str_enabled_disabled(bool v) return v ? "enabled" : "disabled"; } +static inline const char *str_hi_lo(bool v) +{ + return v ? "hi" : "lo"; +} +#define str_lo_hi(v) str_hi_lo(!(v)) + +static inline const char *str_high_low(bool v) +{ + return v ? "high" : "low"; +} +#define str_low_high(v) str_high_low(!(v)) + static inline const char *str_read_write(bool v) { return v ? "read" : "write"; From patchwork Mon Mar 6 19:55:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65102 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2050505wrd; Mon, 6 Mar 2023 12:13:38 -0800 (PST) X-Google-Smtp-Source: AK7set/kE3YdAx+VDvNvSrl+U4m8BZqsY2pHs4zUsx2C4zdyhPafTDis89VGNRtV0usc3aXJu2LZ X-Received: by 2002:a17:907:80e:b0:885:6a2e:f941 with SMTP id wv14-20020a170907080e00b008856a2ef941mr15260989ejb.54.1678133618400; Mon, 06 Mar 2023 12:13:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678133618; cv=none; d=google.com; s=arc-20160816; b=YPgoa7FjvGgzH5VvsmcNlJbGHo1/jWQRKAOSZbmTCNB2Y4HgSP/tHngnuhtnIEt2Qn gsJbGcvHGbrqo5cEOFbmWFc+FyL/6rVgzi3qnalTVLwa+zWt0JCaSvEGJqTlIhC195OO ot5tsejG2zoFh3gfwqlw+mi9IzS45vPD0Ba3QzXcOSPTCnr8WvDYam+dv8cMpCfJ/YFy AQVKghWVD7xpTSyCp8QFy1qA4dbv07y+SepVp/NO9sjmKaK1rR6vVgGIkTIsO6USIi1U ERNhHMs9s52rh8KA1a2qExO3pfmLiLvb5dWxdSEoz7cRN6c46mRnMKkZTpEXc+FmXJHs KjmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EVmPjNTcqTOxUZn76bORaWOvwWOpnA+lrkmsJyUdEac=; b=SDLFppxIm8sqYluYSk6Zlw9HGni6R0eJ/N1j/5Fz6tFGPznvrL+7TnvQek5gAez+2L ueMJeRnIzRmJ3R0rGI4UGnKgSoxryWjktgQbiIGmrNewR/WaHdROaSYhsX3O+QjVjqlL /of5q6SdH7Fa/NuI5dOJ0B2VZ3X9BTFB70oyJgU4l7eL8WCAbwSAEurke0Jjl23D9eQ7 k6LxNpIe8+9kyPuSE+/fw7IG3hHO+A0xsPnwqfjqwy5qQYZ6GzoSg6MW3/bBZH5BPpmc 7xOJbx/6hrPufOTIokEpUFObJficRYLoxfdmrwTHyzq7m/DA32qjC+jknZgzk1OcOADW Z/ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="cMryF/q2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g1-20020a170906538100b008d2606e4158si7826387ejo.1001.2023.03.06.12.13.15; Mon, 06 Mar 2023 12:13:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="cMryF/q2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230194AbjCFTzr (ORCPT + 99 others); Mon, 6 Mar 2023 14:55:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbjCFTzh (ORCPT ); Mon, 6 Mar 2023 14:55:37 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A77A64A93; Mon, 6 Mar 2023 11:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132536; x=1709668536; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=x77bSH20Ou4EihSoiJQDgs4+5OFy75brI2gUDSEqixA=; b=cMryF/q2DkCkGdjn36ecf/XF5C/Kdn/qJO3rQFe5iTgajiG6nR5bLnlJ pgA5t5nWmhjnQLHfBGmau/ZeYXdMrQKxh491XwFjlKqzfyb/BU+o/PCDv oUQ2B8N22aJh0yF4wWDoSWG4hSRZkjtHARIMv4blbIjTCRbTmhEm8rdix adiWN0u4mfDQzWas5FerAK/fBnGfBMSVkSUKRbF82hp+Z57y8Cm4HUSFz teN6rr9gStnG8Pjv4NDmditY057hyrt0+VwRgz7iyLpZPZgK+9ijInGvS ckR7VRvvq54Kko+G78+LQuK8iKq+CRgYuuayM3VBBSbqcqAg2WzIlQzqI Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="400483892" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="400483892" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="1005549562" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="1005549562" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 06 Mar 2023 11:55:28 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 6B292398; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 04/16] lib/string_choices: Add str_input_output() helper Date: Mon, 6 Mar 2023 21:55:44 +0200 Message-Id: <20230306195556.55475-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759650636827435378?= X-GMAIL-MSGID: =?utf-8?q?1759650636827435378?= Add str_input_output() helper to return 'input' or 'output' string literal. Also add an inversed variant, i.e. str_output_input(). All the same for str_in_out(). Signed-off-by: Andy Shevchenko --- include/linux/string_choices.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/include/linux/string_choices.h b/include/linux/string_choices.h index 48120222b9b2..ad345df325ec 100644 --- a/include/linux/string_choices.h +++ b/include/linux/string_choices.h @@ -26,6 +26,18 @@ static inline const char *str_high_low(bool v) } #define str_low_high(v) str_high_low(!(v)) +static inline const char *str_in_out(bool v) +{ + return v ? "in" : "out"; +} +#define str_out_in(v) str_in_out(!(v)) + +static inline const char *str_input_output(bool v) +{ + return v ? "input" : "output"; +} +#define str_output_input(v) str_input_output(!(v)) + static inline const char *str_read_write(bool v) { return v ? "read" : "write"; From patchwork Mon Mar 6 19:55:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65093 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2043850wrd; Mon, 6 Mar 2023 12:00:25 -0800 (PST) X-Google-Smtp-Source: AK7set/juV7KZDFObNIZYHsVh3PJpTnF3gdcZkZ1xOwS0opOszGLSo29AmiyHEe9Zs1kYqX0WIRm X-Received: by 2002:a05:6402:6cc:b0:4af:7dff:7b8d with SMTP id n12-20020a05640206cc00b004af7dff7b8dmr11548231edy.17.1678132825218; Mon, 06 Mar 2023 12:00:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678132825; cv=none; d=google.com; s=arc-20160816; b=BQxkRDlnj687n5LOAGdWCxM/8FUvlyeEjmqB7WnsS42pg3dC7TSXBhiNMD77oPGego hOZ2AQJ/tPlORRg+aUTr9qWJJHDJlhxqWensCyPJqVGEa6cqW96kmmdM1C7QBEiSm/G2 IlJY22Fs/NL/SyhjLwDRCUda9vquMcg/eLOhkAWmG2bpbzn2e7avpWFTEZYS67q4sbaG DXSH1Wi8mQ+9U+joLAUPzMyHRunpTdfra/bPrCf5ZZxr9e1EYAap6KLVqFFevpf7iBAi VcHgNSvojTlWaPzL3EF3RlkXUv7FrqV9XZ/Smup195qALBGoGXkXV2gzp0NOTuQjQ5Dx vHkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Y/PIICcPyvKCJoeIeaw4l0R5zBI4aRV6nXI7n+MunjQ=; b=xnYcTAdNta5Oi6eRDiySFuT/qstna2q84c8JZYcwZ7YYlfjy+OgCqjoKlPK74aiNxi KPkK7xT/yWezleNqGVW5Js/YHMtebYUXDPQwMESw1uPCxAhQS13I1bsv9YhJlArHvc+3 7vCkAlRN572d0zuDEt2cEGpvxERNTB4enLosx1CKrH9nXXEw8hC6SIHinwEanu2MkSAS flKlgIT/sL1gGYWDCPpPqqJvVsj+Lxw+BXX3oIWezLy8T2YfvZoQ/UK8qTqqJQpuWYGi 9isxTCXcdKrYVJbKIk0QqGHSxRZYJuLyMiQw0NCf9e9JgK8VUiNgnkFv2szYbzu4hU7x Fb9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=f+3A19+S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n23-20020aa7db57000000b004acb85b9c41si10772173edt.328.2023.03.06.12.00.00; Mon, 06 Mar 2023 12:00:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=f+3A19+S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230280AbjCFT4E (ORCPT + 99 others); Mon, 6 Mar 2023 14:56:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230180AbjCFTzq (ORCPT ); Mon, 6 Mar 2023 14:55:46 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE8F169238; Mon, 6 Mar 2023 11:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132541; x=1709668541; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Dt4pdLMszFVaAbdqwI08UXnnW0vBxyo1Sqmq45vpnHo=; b=f+3A19+Sb1OHKZkOqtkN6wV8qFdXllCAYLRw2MPd1v98muXw5HMOfJTn qBT0tuwqpF4pWrYRhzD8otAeR55A7uYAfnS4EYrk/XLt8pE7TCqYllvzX 1WUHIIQXcXlq3tSPLBpEauCAy0wFYx4VhaLvez6DNMiqLiOZK66sB2xdo eGKq7mtUJ2N31g1c0mFgjjCyDCDMk+zF1uvML5yiSzmIbJ/AM2rjXq3v/ FmZ/MeGZJHmToWnGtVxSr9TGvncDE2DWHUZbq/qB+9ULTCxn+hcoc6Jsf f7cVQjKfvyo09tqrdL4GZCJpsL8OrL5FHNTN68VXqb3A7IzpNEPsYIgr0 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="398240789" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="398240789" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="819423558" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="819423558" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 06 Mar 2023 11:55:29 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 7A2E93CB; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 05/16] gpiolib: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:45 +0200 Message-Id: <20230306195556.55475-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759649805606197025?= X-GMAIL-MSGID: =?utf-8?q?1759649805606197025?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. While at, utilize specifier field for padding the strings where it's required. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpiolib-sysfs.c | 3 ++- drivers/gpio/gpiolib.c | 13 ++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c index c1cbf71329f0..54dc53b74dc4 100644 --- a/drivers/gpio/gpiolib-sysfs.c +++ b/drivers/gpio/gpiolib-sysfs.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include @@ -82,7 +83,7 @@ static ssize_t direction_show(struct device *dev, mutex_unlock(&data->mutex); - return sysfs_emit(buf, "%s\n", value ? "out" : "in"); + return sysfs_emit(buf, "%s\n", str_out_in(value)); } static ssize_t direction_store(struct device *dev, diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 700195a1faae..b554ad435245 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include @@ -4198,6 +4199,8 @@ EXPORT_SYMBOL_GPL(gpiod_get_index_optional); int gpiod_hog(struct gpio_desc *desc, const char *name, unsigned long lflags, enum gpiod_flags dflags) { + bool out = dflags & GPIOD_FLAGS_BIT_DIR_OUT; + bool hi = dflags & GPIOD_FLAGS_BIT_DIR_VAL; struct gpio_chip *gc; struct gpio_desc *local_desc; int hwnum; @@ -4218,10 +4221,7 @@ int gpiod_hog(struct gpio_desc *desc, const char *name, /* Mark GPIO as hogged so it can be identified and removed later */ set_bit(FLAG_IS_HOGGED, &desc->flags); - gpiod_info(desc, "hogged as %s%s\n", - (dflags & GPIOD_FLAGS_BIT_DIR_OUT) ? "output" : "input", - (dflags & GPIOD_FLAGS_BIT_DIR_OUT) ? - (dflags & GPIOD_FLAGS_BIT_DIR_VAL) ? "/high" : "/low" : ""); + gpiod_info(desc, "hogged as %s/%s\n", str_output_input(out), out ? str_high_low(hi) : "?"); return 0; } @@ -4509,10 +4509,9 @@ static void gpiolib_dbg_show(struct seq_file *s, struct gpio_device *gdev) value = gpio_chip_get_value(gc, desc); is_irq = test_bit(FLAG_USED_AS_IRQ, &desc->flags); active_low = test_bit(FLAG_ACTIVE_LOW, &desc->flags); - seq_printf(s, " gpio-%-3d (%-20.20s|%-20.20s) %s %s %s%s\n", + seq_printf(s, " gpio-%-3d (%-20.20s|%-20.20s) %-3.3s %-2.2s %s%s\n", gpio, desc->name ?: "", desc->label, - is_out ? "out" : "in ", - value >= 0 ? (value ? "hi" : "lo") : "? ", + str_out_in(is_out), value < 0 ? "?" : str_hi_lo(value), is_irq ? "IRQ " : "", active_low ? "ACTIVE LOW" : ""); } else if (desc->name) { From patchwork Mon Mar 6 19:55:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65086 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2042889wrd; Mon, 6 Mar 2023 11:58:10 -0800 (PST) X-Google-Smtp-Source: AK7set8Z5d+3k/yd1mEn8g8Rx++TALDrch+rqNrK5BZ9d+iJgj4VKsDeA0gOEEn/OP0ITGeAVuT/ X-Received: by 2002:a17:906:5948:b0:8b0:26b6:3f2b with SMTP id g8-20020a170906594800b008b026b63f2bmr10383918ejr.53.1678132690562; Mon, 06 Mar 2023 11:58:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678132690; cv=none; d=google.com; s=arc-20160816; b=QgOopzaSDEmyBRMdmJcpzqTD8QLB4l11T3y9nvfjPqBhCt3udCyjLRtY4q0+twxg7u zPM8LARWkzy6KWYJeHU4TUrD5wE8747OARqajpaiufY9U0FkCeEfxVHbmPM6T/EDNjC+ 0I2g5XK7sNVvI5XTxM4LOFbUYcNZsAKConkFDJ5W1we9DnurYG6coz+ZNZew6kk6YZwO 5kub9e9icMUN5NMmvRXNvtkRNNUhtuvpWcKSUx923h7aie5cx/dYe25shmjVBYO1VIfb ZL9EUXCAp2t9/7EIhcviaaqe8wiUukrRyQHWBNChPmmNpZ7rsO96iGELuMGCTdiH1SYF 4XZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sAjKwIe3SPXTNMRGll0P0U7CbXTPDyHTky6Tt/+kgUQ=; b=fQMtaGYJYg+SbtS2PdaH29fCsTOZd31PmIGSGAkaNJUpuUDDRDah/UWfMOrQU+5Rb7 hgTi4112JGBh8fikW2yrmF7TbSwe4KGAaRaxulBxJQ+31rBifx5Dzoeff6CxSOcUHNvU Z8ZeQEh0TMAz3ZhRp2dDgAUrGMgpic3m+1WO9tjUDnZVQm9QHbImqrpinceYxLHFHt+O loYH0bEv5geAqJlh2mHDxrvHLILfWNUYlB/ItbA6hExAC1MFoImv5CvB6oKpNxirNtE5 V/9bi31AFh+Ek9qYLATanN40lavlJQH6bcHed0VOF4/wfOCyPfo2gco1b7b1GhlvK9nA pA6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iWklsGNC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x12-20020aa7d38c000000b004a08f621badsi7830340edq.284.2023.03.06.11.57.47; Mon, 06 Mar 2023 11:58:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iWklsGNC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbjCFTzv (ORCPT + 99 others); Mon, 6 Mar 2023 14:55:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230160AbjCFTzh (ORCPT ); Mon, 6 Mar 2023 14:55:37 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C681664C6; Mon, 6 Mar 2023 11:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132536; x=1709668536; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tShFWIVCdDeqrNoh0yuO5Gnio4e4ieLf0f/Lj6I9KNA=; b=iWklsGNCdF7Ojl6Kg8e0oXm2Nx7aPDdgCHsQh1fJKxL2Lh07gg47Kq2d 8VFTbdrUsY+CgTuyiHJjAfsTEsKMEdWtODqG18yOTPLl0y3/klNgkON2K tx91bJ0jUUXz0eZ91VDs8cSwEvvTaWoCvt5V8P1+fIqgc8/G8hMi1bf0b DHAH5CdwLW4rSqvf91WpJYwMbI0Re5I7sLtOYFXoDG7T9HPyG4VRhYKrQ riZgxayVbjdEHRGLIijYZB17T8YZSitikw8Hbn4XUI9iP0jTdpCgL0etm 18IKiTRXw7QZxzpiHTdeeHFPd7sYjRHNtB34bLPBu9ZJvye5npleBB/Vb w==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="400483899" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="400483899" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="1005549565" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="1005549565" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 06 Mar 2023 11:55:29 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 8366246E; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 06/16] gpio: adnp: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:46 +0200 Message-Id: <20230306195556.55475-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759649664505612014?= X-GMAIL-MSGID: =?utf-8?q?1759649664505612014?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. While at, utilize specifier field for padding the strings where it's required. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-adnp.c | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/drivers/gpio/gpio-adnp.c b/drivers/gpio/gpio-adnp.c index a6439e3daff0..823cad855ee8 100644 --- a/drivers/gpio/gpio-adnp.c +++ b/drivers/gpio/gpio-adnp.c @@ -11,6 +11,7 @@ #include #include #include +#include #define GPIO_DDR(gpio) (0x00 << (gpio)->reg_shift) #define GPIO_PLR(gpio) (0x01 << (gpio)->reg_shift) @@ -211,25 +212,12 @@ static void adnp_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) for (j = 0; j < 8; j++) { unsigned int bit = (i << adnp->reg_shift) + j; - const char *direction = "input "; - const char *level = "low "; - const char *interrupt = "disabled"; - const char *pending = ""; - if (ddr & BIT(j)) - direction = "output"; - - if (plr & BIT(j)) - level = "high"; - - if (ier & BIT(j)) - interrupt = "enabled "; - - if (isr & BIT(j)) - pending = "pending"; - - seq_printf(s, "%2u: %s %s IRQ %s %s\n", bit, - direction, level, interrupt, pending); + seq_printf(s, "%2u: %-6.6s %-4.4s IRQ %-8.8s %s\n", bit, + str_output_input(ddr & BIT(j)), + str_high_low(plr & BIT(j)), + str_enabled_disabled(ier & BIT(j)), + (isr & BIT(j)) ? "pending" : ""); } } From patchwork Mon Mar 6 19:55:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65104 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2050531wrd; Mon, 6 Mar 2023 12:13:42 -0800 (PST) X-Google-Smtp-Source: AK7set8OApCDFFgvgAz474DaPN5WmQ4N6pHcHlXG1rfo+EJnt6H5HV4O50J2COl1LKVkj2JrivSs X-Received: by 2002:a17:906:a882:b0:8aa:a802:adcd with SMTP id ha2-20020a170906a88200b008aaa802adcdmr11239115ejb.30.1678133622122; Mon, 06 Mar 2023 12:13:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678133622; cv=none; d=google.com; s=arc-20160816; b=o3a3rOMW5h8x9FfbzM4s8OylQyFhtD9i2pcgBpS+4DA0tn4Ml3wCg5fgXR46kjBal8 gBxWPa967V/aJGvqcqdmh0xf7Ze2X9vAc93+IJwXtaLTVKemr3/Tp3w3iy7xdYPq6V4f 9lo6mhwA49pdHykXEtjH2gJe1NI9Vfd7t2QhKB4iyy+ANRPLhCHRKfu2pzA5d2BpyTLc Vy3m19TA7DSkD/y7Wfx/kto9v2FQ9ahhO0V6fL6p0k7CA1mSpwPxwOLHGg2zPAwMc2tZ r+o/0r69c9rvbl1n56TgOg+o12BO36VOrZTIKN8qr5IR+AqR1kCHWtgNePRg8iQDOE0+ 2KAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2fwrPHzh2STaAnJw9d1b58+GXTn3BbFcUuibdgQvSu0=; b=bjPq3maqSSeSaYRIgBQCiSp8ACyRBWuzM/u4UX9CcQLvvzXLtySt/XhOovp4XuVnYl U0+/n9LKfrhxs8/QyH/apXdmw/85Z2kFlawgm+yIJWbCL9wJOTWsyhvMF63IZEgh8llz jPYU1pOaN5cPi7rg75pE2HVmsoXPzLHOmMi0jJCuAFhioXIugzpLqta7ztGuUFRcHQ74 A5RrZcTvplbJ3jyS2u7Cris1nPJ6Ku6jIBzx/UxOk89tATFysNBhUSlpovNsrK2hEWmM gglpqb3myj+ME+2otedw0Pxy+5Brdt/BPh4+/zE/i+nrTVcK71BFa31Zn/PognVusQNn mLmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=V36p920U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p18-20020a17090653d200b008d02052ed2asi10538266ejo.637.2023.03.06.12.13.17; Mon, 06 Mar 2023 12:13:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=V36p920U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbjCFT4Q (ORCPT + 99 others); Mon, 6 Mar 2023 14:56:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbjCFTzv (ORCPT ); Mon, 6 Mar 2023 14:55:51 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1A9067008; Mon, 6 Mar 2023 11:55:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132544; x=1709668544; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6SFgifrqhkmsPANQZmuCQE2iTgDgwx3gMBtOgb0D6EI=; b=V36p920UqBS5EVvio5dFDx77kcRqDNpKHT2LwEabVWd1gLF2gYd3Kn4j qhHOUjzq4nB/IZA+Dk8GmcINgA+dBueFtoRETbUVRHHq+p2aSGJjBgMqJ D8xrqLqVR1ihRcSg9ptBpq2Yi8jooVLEbb5ykwUzxSCCvdXVmn+0WBoVo kSG9X5kE2Uitjov6TsB40kr2d3p8EV25cSM1WfZWLZwiYRTzyca2m7/Wa dXyCaBmcrJvwOWk3rzzjr6dCx5At2oUuAA9tjsEY1cp/mnM8M29kUtTt2 P2fGAn4xLpbH22gV5BIc/TKwD+Kf9kkTEPpOWgwf1UWITgDrrS5CNI1Lo w==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333129000" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333129000" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745185192" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745185192" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2023 11:55:34 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 8C9B5484; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 07/16] gpio: brcmstb: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:47 +0200 Message-Id: <20230306195556.55475-8-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759650640779812539?= X-GMAIL-MSGID: =?utf-8?q?1759650640779812539?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. Signed-off-by: Andy Shevchenko Reviewed-by: Florian Fainelli --- drivers/gpio/gpio-brcmstb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c index c55b35da61a0..a0535be1201c 100644 --- a/drivers/gpio/gpio-brcmstb.c +++ b/drivers/gpio/gpio-brcmstb.c @@ -9,6 +9,7 @@ #include #include #include +#include enum gio_reg_index { GIO_REG_ODEN = 0, @@ -225,7 +226,7 @@ static int brcmstb_gpio_priv_set_wake(struct brcmstb_gpio_priv *priv, ret = disable_irq_wake(priv->parent_wake_irq); if (ret) dev_err(&priv->pdev->dev, "failed to %s wake-up interrupt\n", - enable ? "enable" : "disable"); + str_enable_disable(enable)); return ret; } From patchwork Mon Mar 6 19:55:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65094 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2043853wrd; Mon, 6 Mar 2023 12:00:26 -0800 (PST) X-Google-Smtp-Source: AK7set/FWGVfHQx5Abm9Uq8oTOnUkg3I6/FXgSPWIZHcETRDKMZCYO3oP4WeWtIknaM0EP7naXlv X-Received: by 2002:a17:906:829a:b0:907:89d1:1ba9 with SMTP id h26-20020a170906829a00b0090789d11ba9mr10416778ejx.51.1678132826102; Mon, 06 Mar 2023 12:00:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678132826; cv=none; d=google.com; s=arc-20160816; b=PECCuklSrFiz4PRszjZ4VtAszVZqMFwm56WN/HujSwGrBsv4q32YCuEhl8QavXNuvl 6MHV9PVNxUetAVDO7cE3JtJJE9fHCkoGp+ocOsLaHz7d3s2a7/NSjUmI3fGIVjZofQgD 0So9v1hjqxpIpfS2SKYQY9Hp/OyPkGwALsM6lAX4jxqjzXyMwPltlpD1u7dWgkWZS+6j 1JGHgp8TcnYIs+0byalaA1J0x9/538ffpzZYvybf4aSc0HBlw9ZxCykApFAqO7elquZX kL3BzoHedFkfaeQUWxomxEUWrsUuk2JDOimSfzogPI28v7V4Doyeh3ZP3ZSg3LSvXmny dH8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TrHOu1LDnfGUnMIsEjYcY/Q3sdINFzIjbwuTOVI1lU4=; b=h91LNw9H3ymmGJ/xbRYyzPo/XCek6Q2fnwK/r+3+z3KPLbHPbgbGQDrU9axHvgGgS6 x81tah7DDiFqOkXKFI+xM0yOqX/50jAWgaV44FMuG/2JEpxXtc6FZbjE+MgIU8BSuEB7 bBqwWVShyMNuQktgyDKHvJwTJ9BdGzWyP3aR4ylf7FJbABHgD0VVvcEHOQMxOdvY2sPN ZJGV7uJbzaEJuzkiN/Bdw/WUNu/GuXlEhtREl63Ixkpm/2XtWg46k+bZM2MkLIY5rV2z Us179oyfzjOa/AcHvPA/emLKrtvj1HRzr4mnXMcezhKfEGnMo63gqFIwks9RUgDixVA6 iPjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bQFBSjbA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kl12-20020a170907994c00b008d2060ebc71si7134456ejc.1009.2023.03.06.12.00.02; Mon, 06 Mar 2023 12:00:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bQFBSjbA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229746AbjCFT4H (ORCPT + 99 others); Mon, 6 Mar 2023 14:56:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229646AbjCFTzr (ORCPT ); Mon, 6 Mar 2023 14:55:47 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47CE96BC3E; Mon, 6 Mar 2023 11:55:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132542; x=1709668542; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QkJilS+dwGD4FvKKeEiSHbIXGMw2cebK2jx0ihhp9MY=; b=bQFBSjbA1O63VyFiqxH+Re8QDSlT8fBH1nIv+NjCSeX3c394RVIDXOj9 lfWEuPhedLMWHaqz8+yhckHMBLWfhMc94a6owa0Uo8udgbNjk0Sbh1Lt9 i9l5u2uZHfAIwidDQ/rE8td+O8Hvs06k08smCKSMyW26o/k9AXB8xFhA0 9kTSnK0iDEPzUHCTzRM0jXUcHjN6LXtWMVBxDDq0pIVoQpTRYlNfZqVbH ikQWHLAUNQgHFozG+P8LvC9s6B743/CdrYJEinirOzE28xmjFlDzHzmr2 Y300ZykWeRbIDXOiGTgn5xJfssBV/5dadz2OJNkSqFKvU4oxrfsJURh94 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333128974" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333128974" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745185191" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745185191" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2023 11:55:34 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 95E3959E; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 08/16] gpio: crystalcove: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:48 +0200 Message-Id: <20230306195556.55475-9-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759649805864040469?= X-GMAIL-MSGID: =?utf-8?q?1759649805864040469?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. While at, utilize specifier field for padding the strings where it's required. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-crystalcove.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c index 1ee62cd58582..56d628b18397 100644 --- a/drivers/gpio/gpio-crystalcove.c +++ b/drivers/gpio/gpio-crystalcove.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #define CRYSTALCOVE_GPIO_NUM 16 @@ -315,15 +316,15 @@ static void crystalcove_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip &irq); offset = gpio % 8; - seq_printf(s, " gpio-%-2d %s %s %s %s ctlo=%2x,%s %s %s\n", - gpio, ctlo & CTLO_DIR_OUT ? "out" : "in ", - ctli & 0x1 ? "hi" : "lo", - ctli & CTLI_INTCNT_NE ? "fall" : " ", - ctli & CTLI_INTCNT_PE ? "rise" : " ", + seq_printf(s, " gpio-%-2d %-3.3s %-2.2s %-4.4s %-4.4s ctlo=%2x,%-9.9s %-9.9s %s\n", + gpio, str_out_in(ctlo & CTLO_DIR_OUT), + str_hi_lo(ctli & BIT(0)), + ctli & CTLI_INTCNT_NE ? "fall" : "", + ctli & CTLI_INTCNT_PE ? "rise" : "", ctlo, - mirqs0 & BIT(offset) ? "s0 mask " : "s0 unmask", - mirqsx & BIT(offset) ? "sx mask " : "sx unmask", - irq & BIT(offset) ? "pending" : " "); + mirqs0 & BIT(offset) ? "s0 mask" : "s0 unmask", + mirqsx & BIT(offset) ? "sx mask" : "sx unmask", + irq & BIT(offset) ? "pending" : ""); } } From patchwork Mon Mar 6 19:55:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65090 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2043792wrd; Mon, 6 Mar 2023 12:00:20 -0800 (PST) X-Google-Smtp-Source: AK7set9+nIZU1267ptDvE42vhdSig4BEb2aXu9wF6hwFaqB4hRVutRkEQJBNG5Ae7sV45yjj92+O X-Received: by 2002:a17:906:a195:b0:8e5:2a12:8ec0 with SMTP id s21-20020a170906a19500b008e52a128ec0mr11302369ejy.31.1678132820046; Mon, 06 Mar 2023 12:00:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678132820; cv=none; d=google.com; s=arc-20160816; b=nYX4PIK2jUoVl1AwdZHnSxVRZQsvJALMI7zvjX3uN6PQYGlx9a/PaPUHp5+TG+aihS woM+1IOJrl7lk6XYuKTfN36lDYEZlSFeKY4Fn44odDaj1dlTbk0NfLtm7va+vNPrL33O QZ1QykGV4ILui6wEAyJ64ZvouJP/9mjoOZRP1SN5DTOCli+5tJ1hCUkOCFWIvc7i+hez T702TejJRKdoTNllcx01MYKElRHJ8FohojLYBeL7kAvedml+dHy7niTvjWst0I24YZaZ eig4et9ibAUuWfou50GVwRulNr4bniWBamVWvl9stv+a3tD9ZGFqFKv7GAytJtN9m+8c TnSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cZ3oAvjRDghcqdkO3PQX7TVzfshYo9NNHltGMfq2+Cw=; b=EEeCyAl7e4BQDxcttIxkV22lYFZl5iXkPD7Xzy5P0rjRNuSMcWKE6Ey1ddlW8GdKFC C+HtJgWGxmGMws7+P8L8iK9gKbT6kpQg1+YyzKAACyrfL1x1Otba0dTTWEVaD6cbePxu Iz+2TpsAvQMF+p4TZMK1oWcrI/+G3CTkYgTOYIsXjmwYbA6HPv4idNYKRVBBCkMJkfX9 V2WURrHsY+4Tqdlgyx07QA7qyb76ULK7R7dVfCFh34zyRpMSER3K7BWhWf2GQw44xYZ/ 7t6TLrLJYI3guYsybC/bI0WYKkW1g7osXQjDPpiBSRx8WKEdUCFK45YXaubrFMr1VaBZ oFKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DaT3ANVO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho14-20020a1709070e8e00b009098077cf89si11575493ejc.57.2023.03.06.11.59.56; Mon, 06 Mar 2023 12:00:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DaT3ANVO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230262AbjCFT4A (ORCPT + 99 others); Mon, 6 Mar 2023 14:56:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230168AbjCFTzl (ORCPT ); Mon, 6 Mar 2023 14:55:41 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0980E65118; Mon, 6 Mar 2023 11:55:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132541; x=1709668541; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=89ohLboU1a/2JdE0Dw4HbVrvYKShu90dTe4vbBA2XKY=; b=DaT3ANVONlrbjp1EzScXqyEpFCqBwVhuB/axhzLXc/DJpR0xF4epipTa hxgxR5V3ckFe+g72FDAtXOZTVlnlXnVE2rfQBuWCiKOwrNca1SkyS+P86 KSq/4tIP0ZWk3om27DojiOipmEBhzDx1Uk2+Qx5KX4omOKsUlp4DKd5yY 6y2BBu5xt7nJGRhI6sj9YRlS4xACrcFGrGGzcOBVth4M2j7WH/x4r55u9 EbNVivj/sGWUo2ZX0hICmk2ecxGPDoVPt+zhQlrSLZTtYP0ZlGMoKNhku d+mWVXtEEQP+PA2yj11Mp56CibJ3bUZAYwAqlIYtnC+/DYqFW3U2APNB+ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333128953" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333128953" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745185190" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745185190" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2023 11:55:34 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id A15835A7; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 09/16] gpio: grgpio: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:49 +0200 Message-Id: <20230306195556.55475-10-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759649799998045752?= X-GMAIL-MSGID: =?utf-8?q?1759649799998045752?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-grgpio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c index bea0e32c195d..ccd942109f6a 100644 --- a/drivers/gpio/gpio-grgpio.c +++ b/drivers/gpio/gpio-grgpio.c @@ -30,6 +30,7 @@ #include #include #include +#include #define GRGPIO_MAX_NGPIO 32 @@ -426,7 +427,7 @@ static int grgpio_probe(struct platform_device *ofdev) } dev_info(&ofdev->dev, "regs=0x%p, base=%d, ngpio=%d, irqs=%s\n", - priv->regs, gc->base, gc->ngpio, priv->domain ? "on" : "off"); + priv->regs, gc->base, gc->ngpio, str_on_off(priv->domain)); return 0; } From patchwork Mon Mar 6 19:55:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65092 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2043803wrd; Mon, 6 Mar 2023 12:00:21 -0800 (PST) X-Google-Smtp-Source: AK7set8K4yRmQ4pDWit5YGjTpiJApgwMx+f+FI4fbNDQnDU5v4yn9X1ektjrbtNLH4dyaXg3eTu+ X-Received: by 2002:a17:906:2189:b0:87b:1be:a8c2 with SMTP id 9-20020a170906218900b0087b01bea8c2mr12102608eju.73.1678132820802; Mon, 06 Mar 2023 12:00:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678132820; cv=none; d=google.com; s=arc-20160816; b=CbJqIz2StqbwEnYqtix1BWZ5xEx04FIPGN2Ce5JGu/w+CgjkdLkW6+AamZfYLz3q3l 6QOAWSkZUX36tCBwRJnvXCR5NpBy8CaroXxUglGY+V92T4saRTWlTdfhguz0j1Qmzj+S 4TAvatfThbEf7ZqM+gdrZEioedi7pe+k1jPiJ9YEH5BMejAV2mhFY2vS5NXsO4QG0gvk a2P49keKQUWVmPhBdnndDIJ44X+HBsfcjTsaAF9Z5T66AGvu/D1D8kSuLd19MiX8ZM3C PSI80qprqnL63nEY8KnSAWi1r7IdWFgAvyNg7fNFm1r7yWux1l+20tQf4V5Adfdys6DO B+2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=phFrYENM5zyRnInbjfJ97JnmDWhn1V9XrBJJtWbIHXQ=; b=0F8BR4yW/Trlwvn8pMEUllkvoBr9te5vP8o4FkF8zgeTyuOCxmGSPBmAfPM6zak3TD 30lI1b2cj2OtcDw4wNqnpjMSk73zNwBLiOl1soQ2dV3c3Nti1YIP7smg99Q71sqab7QL ra+Li2mieU5WRcR9IHL49K1VsobmLpgnPxtfyJP8Zj2Z5u/WMATpOjtkMy9zxodCCyhe zdzWzIDlb3/XsHIO5kQPJiC4CzwGgSp8pvchZXiC8XYHzAWx5G/Vte3u4DmLdqdfpN1x EOYSImAtMdMmBwoUrvkviCo1FlkJZZstImKfoqL08cENx0u+lM/chy0GjG1jKcyC2Jpb Z8ZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ID1AJ2P8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp3-20020a1709073e0300b008dbb5a2ea5asi14341409ejc.55.2023.03.06.11.59.56; Mon, 06 Mar 2023 12:00:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ID1AJ2P8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230268AbjCFT4C (ORCPT + 99 others); Mon, 6 Mar 2023 14:56:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbjCFTzp (ORCPT ); Mon, 6 Mar 2023 14:55:45 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5DB566D03; Mon, 6 Mar 2023 11:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132541; x=1709668541; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eW58SfrFEF8kWU8i6jmdX+uDYLVUH74J/iJvZmyuLPI=; b=ID1AJ2P8jY4AqR7ZT1IypnLatK4OUlNCNNtsS7iHS2sdWLj7UGN2XroD 72d9T4JndoF4bV40nzh9GAIT92bL/7xP5Y/jxtw+dYlrB9m7RILKR/yC9 AE49h4ggQDKnlslXkN+LjA39BNZblQbRjOM7XH+2ciu5yrSBxsB761ObE IReKFSWbI7tURVD4Ybv4ZHF5nrRxRb4X1O13aoBZ9r9R4QL77xBcdjHXd EFG4mySsqSl6BHFfoh2T8P/vu95Sc2vemKnaZSb0FOLlkZAucLR0bujJV nhWTGsPsclCATNha3322BkZ2JVQ2/yJphO6PBnWvWYnSoSlCnqcesrhlV g==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333128988" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333128988" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745185193" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745185193" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2023 11:55:34 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id ACE8F14F; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 10/16] gpio: mvebu: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:50 +0200 Message-Id: <20230306195556.55475-11-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759649800669520124?= X-GMAIL-MSGID: =?utf-8?q?1759649800669520124?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. While at, utilize specifier field for padding the strings where it's required. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-mvebu.c | 27 ++++++++++++--------------- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index a68f682aec01..f2bbe928577c 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -48,6 +48,7 @@ #include #include #include +#include /* * GPIO unit register offsets. @@ -897,32 +898,28 @@ static void mvebu_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) lvl_msk = mvebu_gpio_read_level_mask(mvchip); for_each_requested_gpio(chip, i, label) { - u32 msk; - bool is_out; + u32 msk = BIT(i); - msk = BIT(i); - is_out = !(io_conf & msk); + seq_printf(s, " gpio-%-3d (%-20.20s) %-3.3s ", chip->base + i, label, + str_in_out(io_conf & msk)); - seq_printf(s, " gpio-%-3d (%-20.20s)", chip->base + i, label); - - if (is_out) { - seq_printf(s, " out %s %s\n", - out & msk ? "hi" : "lo", + if (!(io_conf & msk)) { + seq_printf(s, "%-2.2s %s\n", str_hi_lo(out & msk), blink & msk ? "(blink )" : ""); continue; } - seq_printf(s, " in %s (act %s) - IRQ", - (data_in ^ in_pol) & msk ? "hi" : "lo", - in_pol & msk ? "lo" : "hi"); + seq_printf(s, "%-2.2s (act %-2.2s) - IRQ ", + str_hi_lo((data_in ^ in_pol) & msk), + str_lo_hi(in_pol & msk)); if (!((edg_msk | lvl_msk) & msk)) { - seq_puts(s, " disabled\n"); + seq_puts(s, "disabled\n"); continue; } if (edg_msk & msk) - seq_puts(s, " edge "); + seq_puts(s, "edge "); if (lvl_msk & msk) - seq_puts(s, " level"); + seq_puts(s, "level"); seq_printf(s, " (%s)\n", cause & msk ? "pending" : "clear "); } } From patchwork Mon Mar 6 19:55:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65099 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2050106wrd; Mon, 6 Mar 2023 12:12:49 -0800 (PST) X-Google-Smtp-Source: AK7set++KWX0KNsKLbY2/MO3uayAv/UYDB+CG9McQIrwd0IbYRGWfJEaB2MMCKIH0+5n+1Ko/1Jn X-Received: by 2002:a17:906:5dcb:b0:8b1:7eb7:d53d with SMTP id p11-20020a1709065dcb00b008b17eb7d53dmr13490517ejv.49.1678133569220; Mon, 06 Mar 2023 12:12:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678133569; cv=none; d=google.com; s=arc-20160816; b=nPCJJE/WA/xfWrtLfKbdMjmOj20RzNXsDT2V0tFGgLMvLr2fyx4WZEUysBcj9TqnOx 5250suCjQec0nWOyeX/vbtsbET6klt+qCJxNZ4StlS4jdrViYby8Ma3IqWb0RpgvF0D0 qRXtPTBPEiOoRR2NvS8Y/nklQm62gDGwwbn4GgEy/kEzYOpxtYu9ZmZZb+7WKqwo5BEk XH1a5doZYY+C/HmgSREBAAepG/A60nxK0x+ruKxoX9mKz414Fuo0cG65JuSX2Sv4lhsi MEh4CffWyupPVcEamzy6HFFm9TH8+KRUdhUrJ8J0wGats8hMQjyf8eKF09izHCHD9A8l daLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ejVRKYAtBl21io7tyklIQUu1u+uj2dqWxxjN2JJ74yE=; b=G+Bi41mR4C6uXserRG2CvNYntlEULJFxuCn1iGx8I/VuhHEOKC0yAvM7Xjx0hCsZc2 TNmVIMyaYP7uLHyqApfyj/oLpJ6wd1T3MlVMRqhaTw+18HJWTvo6rf/Qs7xz8A55F3Q9 y4ABrZOpaR82h45qAhKsOO2BkRy1VdgCvSf/HtCSQ3J++YBGt5wrbm8Q97xT7lkg+H+m 46+tUJGMIwrkqwfvjwYMdLMPXA39eXP07CuCTAog1zM7UIShdlbPs/CZLxVeGEtudWmb JG6eirCyQSaPdCbgqxJeaZX5B8Gu0pQOmTM/yfkg6H5qmzUCgnVdN5B/RIDeafCldwIr nAuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=k3CVGC5x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h16-20020a170906829000b008cc17a6e394si10373932ejx.779.2023.03.06.12.12.25; Mon, 06 Mar 2023 12:12:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=k3CVGC5x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230400AbjCFT4e (ORCPT + 99 others); Mon, 6 Mar 2023 14:56:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230233AbjCFT4P (ORCPT ); Mon, 6 Mar 2023 14:56:15 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4D1874A61; Mon, 6 Mar 2023 11:55:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132550; x=1709668550; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jf/vTVPAzC30zKR0ZUsN6jr/4cQFfkw43STBYea8M0I=; b=k3CVGC5xyALFHyqjoLIKUI5rjXyvajzGt757PmOi2FvcyaYlrfr/YSMS 2PXTsLn05NprAm3X35oYjDVhGiyqFNOjwlF6D41EbrOf+8PUBkk5/x6C5 FgjFiCD+94x40oTuXiXOMXBLfu+iUTt0/uOE/JL2Ugh3ljhAoEjskStx9 qVeX1iUHL86fmHZJI7gkUkcSJyzCcpQBLo0iSpCwCZzgBLg5Iszlz0Yky mcD2icMW2voY1vCPNeEil1CsnzR7ZnsWWLiqVjq8oiAzttT6Eg+PUGxlF NSjKd9DlB6mtMTwBTDiRSDW3NOmAJ1ywkZ75J2Rf2e4mK1d7qksiuonsw A==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333129033" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333129033" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745185196" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745185196" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2023 11:55:34 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id B81905B3; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 11/16] gpio: pl061: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:51 +0200 Message-Id: <20230306195556.55475-12-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759650585315686537?= X-GMAIL-MSGID: =?utf-8?q?1759650585315686537?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-pl061.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c index 9fc1f3dd4190..99e71b4490a1 100644 --- a/drivers/gpio/gpio-pl061.c +++ b/drivers/gpio/gpio-pl061.c @@ -25,6 +25,7 @@ #include #include #include +#include #define GPIODIR 0x400 #define GPIOIS 0x404 @@ -165,8 +166,7 @@ static int pl061_irq_type(struct irq_data *d, unsigned trigger) gpioiev &= ~bit; irq_set_handler_locked(d, handle_level_irq); dev_dbg(gc->parent, "line %d: IRQ on %s level\n", - offset, - polarity ? "HIGH" : "LOW"); + offset, str_high_low(polarity)); } else if ((trigger & IRQ_TYPE_EDGE_BOTH) == IRQ_TYPE_EDGE_BOTH) { /* Disable level detection */ gpiois &= ~bit; From patchwork Mon Mar 6 19:55:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65091 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2043794wrd; Mon, 6 Mar 2023 12:00:20 -0800 (PST) X-Google-Smtp-Source: AK7set/gUTSY7bBypMvPF+nXYryNjYv/FGxCTB2HS538ma6cOXbp3tVKGdlcI061OWdnqWaduwzQ X-Received: by 2002:aa7:cd10:0:b0:4d4:9f84:557d with SMTP id b16-20020aa7cd10000000b004d49f84557dmr7780825edw.9.1678132820062; Mon, 06 Mar 2023 12:00:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678132820; cv=none; d=google.com; s=arc-20160816; b=iwB+3tQFtPiVxYLPeDiO8e77vBSds2f+//vmgX7QE3vpMyf2lSIbvfN/m85TVDdJ3E aa6Sd7Al1QQo9XxLYY7MEujtbUi6n2OMouH2lx3pGmglo31CFzDOx0oOamLn0QPE898J cdRCeup9U9ixntG4mHhCjN5VAL+iG3/4ddYhhmMbmKGT74RidWfrpVOzpl6EfWEJh3m9 yCb/Az+HZhGyK41I9hUzihg0wwx4AqTeCouiwLIdQVjJWa7RWelhCXw4VSpT0vGwfsGA YEzTdJPhW4nfXxExqDJlgU0cBEycxrBVu3wz2dgEN3EfpV4/wa3SkjBegtKWRtbco43U MeYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HNcSSk55iWEaFq2mUvdSI2qFCnt+rhJphSh7hkQq4K0=; b=kWLYlan/e1uZTKjR+js7HPbzGzBxoALXSexhPfEDG6FFOkVNhJW6ILL5PlNtplgl06 r7BENaqiNNs2XpNocdSSL8MAfA0V9e9CMwwbLIhC1Kh0JIO8beroqgOvHAHOHwlpAo1o VxUC7+r8t5Wgw6YJOoLUqlqMg/316zctWeE+NduP7uUZiGmD2te0x5A1XF291D5s6BZ9 nsk9vSUURdtKbvJ2UCX4zAPBeCgpKzy+RXRdz5/K0c6OkaEnQBTKhru5izpmqAzFiKU4 goVx9Ku8CieTJyQvfUMtMdN9sOckoTNMsXsLLJmRdCNIx220zDhDUGXLJmRUA5XyD87y Ln8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=elBBbmFO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r10-20020a056402034a00b004ad8da3f37bsi8398188edw.323.2023.03.06.11.59.56; Mon, 06 Mar 2023 12:00:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=elBBbmFO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230248AbjCFTz5 (ORCPT + 99 others); Mon, 6 Mar 2023 14:55:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbjCFTzl (ORCPT ); Mon, 6 Mar 2023 14:55:41 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E898D59427; Mon, 6 Mar 2023 11:55:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132540; x=1709668540; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EDvZyVrBDVc7Nwzs9i+qoHy3DJw3++NSTTOOF+lSAxI=; b=elBBbmFOveSrjoKIlVza1kPML3XJ5AJUUtkLgfZNLpnRkRuHjhVbfdJe rQctpexiGsmUo6FV68vzAAFz6RyIULnAlT5M8Zg2MhcfaMA9aS43upntQ abIg7o/rcOYiGhqQwSgc2y04OZyYbp9IykiEbWtxG1sjthg04FHkw8QNE d3LxlNLJgFxLi0/gAHzpDCqTF5IvPdfm7gbKl+QAHeV+Xq4t0mDfi0Gip gLLfI45hSwTDMeksA80JlY3Cy/wXS5PMP4e7JFqj/sJlh2buhUNuNo+uu 9Y8M0YwrtogbtbwZY5uwW+mwkRuD3ga5XZt3wO7ooqHIOMAUQBHXNi2JJ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="400483922" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="400483922" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="1005549582" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="1005549582" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 06 Mar 2023 11:55:34 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id C33FB5F8; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 12/16] gpio: stmpe: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:52 +0200 Message-Id: <20230306195556.55475-13-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759649800358669316?= X-GMAIL-MSGID: =?utf-8?q?1759649800358669316?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. While at, utilize specifier field for padding the strings where it's required. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-stmpe.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c index 0fa4f0a93378..ca8a98b252c2 100644 --- a/drivers/gpio/gpio-stmpe.c +++ b/drivers/gpio/gpio-stmpe.c @@ -14,6 +14,7 @@ #include #include #include +#include /* * These registers are modified under the irq bus lock and cached to avoid @@ -264,12 +265,12 @@ static void stmpe_dbg_show_one(struct seq_file *s, ret = stmpe_reg_read(stmpe, dir_reg); if (ret < 0) return; - dir = !!(ret & mask); + dir = !!(ret & mask); + seq_printf(s, " gpio-%-3d (%-20.20s) %-3.3s %-2.2s ", gpio, + label ?: "(none)", str_out_in(dir), str_hi_lo(val)); if (dir) { - seq_printf(s, " gpio-%-3d (%-20.20s) out %s", - gpio, label ?: "(none)", - val ? "hi" : "lo"); + seq_putc(s, '\n'); } else { u8 edge_det_reg; u8 rise_reg; @@ -336,11 +337,9 @@ static void stmpe_dbg_show_one(struct seq_file *s, return; irqen = !!(ret & mask); - seq_printf(s, " gpio-%-3d (%-20.20s) in %s %13s %13s %25s %25s", - gpio, label ?: "(none)", - val ? "hi" : "lo", + seq_printf(s, "%13s IRQ-%9s %25s %25s\n", edge_det_values[edge_det], - irqen ? "IRQ-enabled" : "IRQ-disabled", + str_enabled_disabled(irqen), rise_values[rise], fall_values[fall]); } @@ -351,10 +350,8 @@ static void stmpe_dbg_show(struct seq_file *s, struct gpio_chip *gc) unsigned i; unsigned gpio = gc->base; - for (i = 0; i < gc->ngpio; i++, gpio++) { + for (i = 0; i < gc->ngpio; i++, gpio++) stmpe_dbg_show_one(s, gc, i, gpio); - seq_putc(s, '\n'); - } } static struct irq_chip stmpe_gpio_irq_chip = { From patchwork Mon Mar 6 19:55:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65087 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2043055wrd; Mon, 6 Mar 2023 11:58:43 -0800 (PST) X-Google-Smtp-Source: AK7set8hLAPxGz3Vty1tbZ4w8rkdyF8xiCFuL/uZbeD/l8fwXuHrvquJZFeCuRbaugKIaosoHYo5 X-Received: by 2002:a17:907:9694:b0:881:f2f:6633 with SMTP id hd20-20020a170907969400b008810f2f6633mr14901452ejc.50.1678132723284; Mon, 06 Mar 2023 11:58:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678132723; cv=none; d=google.com; s=arc-20160816; b=TkQHyyneMRm4+z2bUOQBhOptwE5EooW+B8d6cyvTfLlH3N7/PWQ4U5aeww1RlrAisC N6ro/riBBySC4AP4vIOOVsMob2OtWiW/V9gdeu0hxH0aEeZUvKZEAYre9FPwdkT6dKhy Mzd5DOdd8f5tplUM0R8K1PumROMafSIQrK4dm0wqKeeSjqB/BEEOMai/COsF1ggKLax8 kOCwwFAUqRiqji0p2UiBZ7UIg83KURd5Fe39Vkim6AJJyZDtzOB+YJhhn9Sar5yyO+jf EnSB9Fuo72WCBulbgBA5R9Ncy/m0Ce7czTtZgoP7ffuZLL2Q6Hk7dG8DiYLexIdkGlS9 mDuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4Y3DXCGV2kW0jbzvCxh6rSWFTB5q/wBRQLvMTmJtZfM=; b=bPsIPV2J5LTRoqzL3OlhBoKjVOw+1OT4HD9CbkxByd/sYmIwr8UkgGtm8vb5AvvNuv SB2EkPfvXoHKf3jBDkJx0sA6HJ6tyI/05rn9g1kG0yomtTTwjwF276kOfsV1iqoceqjD aLI5dt2WHqudd5S3l8ws1b1lcLFofd5vbwzsxcYFM58UuGeF/NjEqqkwK6NE/vT4cTmO C72cN0+X1GcvQAa1f3NbpcHLzCov55jVrsDCteCCHgs2NpCjsL+aPrGpZyzzx4rU4qev REmAEjtq3hFMdHGnkFiB7/RcRfNadGd09R9QXpxviyIogy68l2Yw7b8eY75zFnjMp4mP /23A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=AXwMHazS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b22-20020aa7cd16000000b004acc68a5878si34849edw.274.2023.03.06.11.58.19; Mon, 06 Mar 2023 11:58:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=AXwMHazS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230368AbjCFT4W (ORCPT + 99 others); Mon, 6 Mar 2023 14:56:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230296AbjCFT4G (ORCPT ); Mon, 6 Mar 2023 14:56:06 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0DD96A047; Mon, 6 Mar 2023 11:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132546; x=1709668546; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uanU4QaIMKCYnVoRuj1LvDKlEUvFT3OubkE3zS0A1GQ=; b=AXwMHazS3PNUp6GHomch8z6bRBb+8YkVRL4dNibvlqQvY6O/rKh0N7x9 PzKn99ZUfoNuilMyc6Ou88SrOBZ6/JjF11wKpch3aWo5uaapJf4DydnJ/ 6pJBGEF+RjCbGm9nc7aGouBT6yELNYJRfsDzsTPPCkudh+JJTUibhAvfE 5++dzkSXBzjAODfo8bXP0DcqupESS4ahlUjpm4vK3GfxHnTHXbvMpDJHP XqE3PmZE7PmccWUtSDElFgBSH90XSCrXQnDYBd028758ITZUXoi6tIXO1 KRkFRC+H6WTu0GPoVtofYJBs1FMWmKkFLlb/uxSvMfcD8lZdyhQ03FCOv w==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333129019" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333129019" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745185198" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745185198" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2023 11:55:34 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id CE4C8609; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 13/16] gpio: wcove: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:53 +0200 Message-Id: <20230306195556.55475-14-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759649698614701860?= X-GMAIL-MSGID: =?utf-8?q?1759649698614701860?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. While at, utilize specifier field for padding the strings where it's required. Signed-off-by: Andy Shevchenko Acked-by: Kuppuswamy Sathyanarayanan --- drivers/gpio/gpio-wcove.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c index c18b6b47384f..8d30fd04dede 100644 --- a/drivers/gpio/gpio-wcove.c +++ b/drivers/gpio/gpio-wcove.c @@ -15,6 +15,7 @@ #include #include #include +#include /* * Whiskey Cove PMIC has 13 physical GPIO pins divided into 3 banks: @@ -391,14 +392,14 @@ static void wcove_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) break; } - seq_printf(s, " gpio-%-2d %s %s %s %s ctlo=%2x,%s %s\n", - gpio, ctlo & CTLO_DIR_OUT ? "out" : "in ", - ctli & 0x1 ? "hi" : "lo", - ctli & CTLI_INTCNT_NE ? "fall" : " ", - ctli & CTLI_INTCNT_PE ? "rise" : " ", + seq_printf(s, " gpio-%-2d %-3.3s %-2.2s %-4.4s %-4.4s ctlo=%2x,%-6.6s %s\n", + gpio, str_out_in(ctlo & CTLO_DIR_OUT), + str_hi_lo(ctli & BIT(0)), + ctli & CTLI_INTCNT_NE ? "fall" : "", + ctli & CTLI_INTCNT_PE ? "rise" : "", ctlo, - irq_mask & mask ? "mask " : "unmask", - irq_status & mask ? "pending" : " "); + irq_mask & mask ? "mask" : "unmask", + irq_status & mask ? "pending" : ""); } } From patchwork Mon Mar 6 19:55:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65105 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2050726wrd; Mon, 6 Mar 2023 12:14:10 -0800 (PST) X-Google-Smtp-Source: AK7set91wFxVrDftkXIGhcgKN4GdVOb2XsPJpbGgaGSwrbEfcQQRgKe4c+7zVLqWXdXpo2vTotgm X-Received: by 2002:aa7:c489:0:b0:4af:6409:30ea with SMTP id m9-20020aa7c489000000b004af640930eamr12453049edq.19.1678133650610; Mon, 06 Mar 2023 12:14:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678133650; cv=none; d=google.com; s=arc-20160816; b=utKl4yLbCQdabXM7GxdGMcC3ZeuuIOWc1uVUr2TmZ5E31WbEHx+cqw20IdsPN1f6Qz fFdzwjV2SBe33vDL9JGMne1QZT4+TAqrLg0FvAQDOzlLUMShtggfaaToBzWcYV+4iJzA MzohAKyilHO6EBoYIOnz4dHiPn31flIFu7063RK3GU+iX+klq+8oAPHYsP8/0PfRj06n 9CLW2B0ljTcC0YQreVzRIcgJXCNE77SQxOytWWIejs81NOQuy72P4RoBti8TCgYXk0sw WQwRNRbUVi17H9AuxWyZSrpN4i1pmde05bsJIsoDRfuXcPa0reNk77IFjdw9NqGn8ksJ Ba3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8loi2Q20TT7JrkUUaL0WE77eVEwuIMbTOXN79ShyZFQ=; b=e+XbsD6OQBjt7AyKi+cjLtM7IlfFvrUOe/fR9ghsqq9iTl0GNUXoS+uw4luCsMpMop 4tVRjjio3WrvDfcf6uJ/jShKS7wN5ENG9XODudtEbJWm6BuZV9s46Jwf+A/JkTmFscsP 1/JMuvzoD2Rs3d8VehtsUhbP3XH2NVzbIZV2NYrY0QrdLth3WEDPiCzbJUp0khIBtyI2 HuI5QL3Os6kAb73OoJLMAf7jRAErqxwzSABonuVMDgkXa0xlyZOuIpSsDPa8ACLJ2CZ3 scAGs63jep5I0PZLu2nlLRGNWNWLeUvAj9BQ1PiwP8VOCfBZz0Wafnix3qU3o+tCsLws q4Yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FwAUEpaS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m11-20020aa7d34b000000b004bc8b19b76csi792065edr.188.2023.03.06.12.13.46; Mon, 06 Mar 2023 12:14:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FwAUEpaS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230363AbjCFT4T (ORCPT + 99 others); Mon, 6 Mar 2023 14:56:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230227AbjCFTzv (ORCPT ); Mon, 6 Mar 2023 14:55:51 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 730AE7585A; Mon, 6 Mar 2023 11:55:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132545; x=1709668545; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5nB1Cjf4Z6soJzkyRCy4W4jPVtCrh+QSwebJoZzzTHU=; b=FwAUEpaSGExn5eC9NtNZP3rmPDDCbVPRnA04unX4cNxt6BF+5RgMmS/z aiVpd8KAoipbYjLJik9KfdN3CmOVc1jYc5ImuP5Fk678lXXam+r4WWEAX 7TKec04RhLFu2TAdzhjKoegcM/iwGCDDeuH1UsraB2E+jzp38k5DZY+oL MLOL31JGoUgrUoL6vlenYMUddU8eWDPmOhB7vo8ncU/lhJ8rIT+CKFWVL iKpXoDUA0T8hFBWKwjjk/3+i1qRD+lu69DdEqvFf2y+qnO1BUR/aTrayO 1lDU/6dgau1OcfrDFpwgDm38tX0QjH76sP+79YdqYmztuPj6aVgPSzgJ8 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333129031" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333129031" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745185197" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745185197" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2023 11:55:34 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id D96A063E; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 14/16] gpio: wm831x: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:54 +0200 Message-Id: <20230306195556.55475-15-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759650670944328413?= X-GMAIL-MSGID: =?utf-8?q?1759650670944328413?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. Signed-off-by: Andy Shevchenko Acked-by: Charles Keepax --- drivers/gpio/gpio-wm831x.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-wm831x.c b/drivers/gpio/gpio-wm831x.c index 7eaf8a28638c..5456485ce801 100644 --- a/drivers/gpio/gpio-wm831x.c +++ b/drivers/gpio/gpio-wm831x.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include @@ -229,8 +230,8 @@ static void wm831x_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) seq_printf(s, " %s %s %s %s%s\n" " %s%s (0x%4x)\n", - reg & WM831X_GPN_DIR ? "in" : "out", - wm831x_gpio_get(chip, i) ? "high" : "low", + str_in_out(reg & WM831X_GPN_DIR), + str_high_low(wm831x_gpio_get(chip, i)), pull, powerdomain, reg & WM831X_GPN_POL ? "" : " inverted", From patchwork Mon Mar 6 19:55:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65101 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2050360wrd; Mon, 6 Mar 2023 12:13:20 -0800 (PST) X-Google-Smtp-Source: AK7set/rWct0oCcl71I4LRHu06VeKeXAglQH9bjxZABm7oX2+H7170fSCjn2vPPzqfQSwPocAZeQ X-Received: by 2002:aa7:d952:0:b0:4aa:a280:55b5 with SMTP id l18-20020aa7d952000000b004aaa28055b5mr11508242eds.20.1678133600208; Mon, 06 Mar 2023 12:13:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678133600; cv=none; d=google.com; s=arc-20160816; b=aWJUv8HRliybElNu3iaDyP/wID0h9p/RgljZSmW0BhIz35NWToZ5kAiu5UAnIFj/FB /bFlh6qk+P5VTQiVXbmlgBKEKWiqBYqmeq59BnDbCkUGgtYKzGrHIO2zdjSLg6CrAgCQ JGbrhuvbZlSJWoIUxuXvDcQpBfoteRdWOrmIkMIgg4fNBcn1HL7Wz8qvc6v5mr+sZJg1 QEcpr374wNZ4ZRvGKLlQW3rXYZTpxkPUc0D6M0zxWWcMFZnlFa/MYgRTj8OMOroKh0Pb 1rUua7JCHZGtDtNxinfuc608gQdC9SsVOcIPCHRty1DSVYWcO5QtnFZYM/kdBZ5aDpLT cw3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=c+nUD+jN/oPKzjhb+GBp6UDwk/GwQiRVP7QziDWpjLo=; b=pW7a9eQBoHwPqayM9JCLt78LGLgR009ie/DLQ3U+5G4mcHvdbwUobvc7YMgNLrh2ue JFUKDOVdZDKBvaba4weadkJrrHQChlWc9asvKNSSu0DjKIWnc/BtK+6GqojUPa00iJId 8le8886IHXjWQEuHoB0L4y0/AhablZJrfYzQ1S3RHDokyGQ2jFoXUB7eVf841ri3JrfO wrLHvc11qKMcH9urn5Tderu8rnO98SrXXqXvbJpg+HWgL7nfpehkA7wQHanyKdcRGVUf vlKFpttcOFYF/k8Co9AAUOiaCDhaIAtygYJVBD9J7tx84BC+GqkyOr8ML+tJJxy0lwYo 7Jhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mlDz2Wr4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q16-20020aa7d450000000b004ad02c77d40si9050018edr.29.2023.03.06.12.12.56; Mon, 06 Mar 2023 12:13:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mlDz2Wr4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230382AbjCFT4q (ORCPT + 99 others); Mon, 6 Mar 2023 14:56:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230381AbjCFT43 (ORCPT ); Mon, 6 Mar 2023 14:56:29 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A71247C9E4; Mon, 6 Mar 2023 11:55:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132554; x=1709668554; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RK6y2QSRrHDRA5pznFKjVWh2L43LhEIXd/tLzjqoka0=; b=mlDz2Wr48JwU8k7+WTZtzMU/7jeuhVJXqN8wTq6TMP0Wlai2U/pnpw3l CO8OEf2q2V4QQSYXiUMzd/CMW4M3WwGbP6eZ/9n5nJnxWWsH+QGt90kQS opUTUaF7Y3HPDM07L+DGfeM7Qlv0k6PJKMR6nWlXIxDn9fMxQNGGnXhyD NlkBm6wmrultP5UplLPIA1ymTJpoOmavca2ejKBSidk7Y7QeTZEhUx+Yk wYxT2Rr4yuE5c9406WGvJX6JSaRy0XLLCf3UpSLLbj+RhZbZYaNQet5rE 2vsbrhrxcrk//aaZ/ZslRrIFk7Z/eSjyTvPpZEGDB2Vve+CoXUJg5pMUR Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333129051" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333129051" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745185204" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745185204" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2023 11:55:36 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id E54AF65A; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 15/16] gpio: wm8994: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:55 +0200 Message-Id: <20230306195556.55475-16-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759650617610452902?= X-GMAIL-MSGID: =?utf-8?q?1759650617610452902?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. Signed-off-by: Andy Shevchenko Acked-by: Charles Keepax --- drivers/gpio/gpio-wm8994.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-wm8994.c b/drivers/gpio/gpio-wm8994.c index f4a474cef32d..15757d94448a 100644 --- a/drivers/gpio/gpio-wm8994.c +++ b/drivers/gpio/gpio-wm8994.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include @@ -215,10 +216,7 @@ static void wm8994_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) continue; } - if (reg & WM8994_GPN_DIR) - seq_printf(s, "in "); - else - seq_printf(s, "out "); + seq_printf(s, "%s ", str_in_out(reg & WM8994_GPN_DIR)); if (reg & WM8994_GPN_PU) seq_printf(s, "pull up "); From patchwork Mon Mar 6 19:55:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65098 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2049707wrd; Mon, 6 Mar 2023 12:11:54 -0800 (PST) X-Google-Smtp-Source: AK7set/Ux+6gEO1fCR613VnUFxOsSs/OmsSjFMnTymESMzzCqj/m75Yrfv01Po1RGiOWaIS8fto2 X-Received: by 2002:a17:906:b007:b0:8aa:c038:974c with SMTP id v7-20020a170906b00700b008aac038974cmr11458902ejy.54.1678133513915; Mon, 06 Mar 2023 12:11:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678133513; cv=none; d=google.com; s=arc-20160816; b=UZoyvLY4Xq8czlWcsToKyvotOn3Rlbu2zDkEIGG7tXwHekjvCGdANmir5ntUMouKIf XWoSRMj3kFSEwOlJ7ssLcbkuqhDYEpNmKfz4DQmsAqo7jJTVr3O1Ejko3qxPFGHWIKKN zBpWNzd6g9ChKoanaJ3StBpaJt+QtMNHhU7Toh+k5x5UdXvrzudgFHHVih3ZF2/7KawM AILMrpr9QvhQu8UK7tx2CbRPF+CjOQLEY0Sz7KHa0hsE7k7FdqNzyFOL9+4udg1i/aNS wrrc80ekn4o4vRC+qohUa0wwJEETIsO1lEpX6BO2tW62QxjzkCXx13Zg3129fYu+XxIK JUEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+po55Fpho6SfKTHiIqp5YKPGyjpda/u+CJ46KtMzcWI=; b=aK2NNZMd8RlWZHzp19NUtKcCU6tfMbK2VXE/X6xUYpsPJRD6LRGpDxNXTb49NPh1Y6 N7QtnFV1R0Zmu/qNeR+HFOOd32/QwP/Iu1/ZgNa8IC52BhzEofpgWLRQPgPU0KAttODU +7j55+dJp+sRvRLzcY3jphirUfj0FQVN5W6NAvrsqyEMQt3Iaes91sPz9yqKiJZH9hLf f2dLXjOfkeFE9lgcyj2q24xD3OraiAo5krcqZdrxP90VxYMAGHRGn+jTIHj2fJxDEcGk RWMcGeEdGyZ43hpzA0CQtT7xbe0tpHfftHsJHGk4G6NFa5zRFkml9JEMMryXC8faUrqL LlDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Ih5XHDYM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p12-20020a17090653cc00b008b17bca9226si10613687ejo.312.2023.03.06.12.11.29; Mon, 06 Mar 2023 12:11:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Ih5XHDYM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230298AbjCFT4h (ORCPT + 99 others); Mon, 6 Mar 2023 14:56:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230096AbjCFT4Q (ORCPT ); Mon, 6 Mar 2023 14:56:16 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C8D7664C7; Mon, 6 Mar 2023 11:55:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132552; x=1709668552; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=z9mXunzTxFtyQxWYx0D3ZdzQzJ0LQXRYVBzePKOyr2Y=; b=Ih5XHDYMjtD0cz0TMSQiXyHKSDKfnufpV//bJv0nhLgh5Wbn6VNAkcXw bpYN+QoLmOa9H7/Lm0940umiZUNAJZIwFQaJ2HcreJpdGOzM5fFaYOHem xiV8QTV28OLCjWT14GoTtXIx4bd4TdYV7Sg7/86jtGwC4CWWa8NCDiwbz 3MAGB+5ke+hfAaTIchNwV/1+nfWWu08UXf9sxQpWekfdAfnQliH+Ohy+R 6I4g1VUZ4hqLFOk69zK60pfoUz11VVNM32ZIvrk5DENmn9wNxUYOWAB1x 2r7bC38Wq2lUyO+R1d64CHuzasZKvhYqHGi6LJ+vXOXjhZBvPIvCRV/68 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333129039" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333129039" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745185205" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745185205" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2023 11:55:36 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id EDC5787; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 16/16] gpio: xra1403: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:56 +0200 Message-Id: <20230306195556.55475-17-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759650527703709449?= X-GMAIL-MSGID: =?utf-8?q?1759650527703709449?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-xra1403.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-xra1403.c b/drivers/gpio/gpio-xra1403.c index 49c878cfd5c6..bc17beaba9e7 100644 --- a/drivers/gpio/gpio-xra1403.c +++ b/drivers/gpio/gpio-xra1403.c @@ -15,6 +15,7 @@ #include #include #include +#include /* XRA1403 registers */ #define XRA_GSR 0x00 /* GPIO State */ @@ -140,8 +141,8 @@ static void xra1403_dbg_show(struct seq_file *s, struct gpio_chip *chip) for_each_requested_gpio(chip, i, label) { seq_printf(s, " gpio-%-3d (%-12s) %s %s\n", chip->base + i, label, - (gcr & BIT(i)) ? "in" : "out", - (gsr & BIT(i)) ? "hi" : "lo"); + str_in_out(gcr & BIT(i)), + str_hi_lo(gsr & BIT(i))); } } #else