From patchwork Tue Oct 18 16:49:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 4253 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp2060468wrs; Tue, 18 Oct 2022 09:59:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM75y1WQeDg2sfqeA+ZtWLqBnt2o2ePIfhycOOX4w2MMsJMPQPhIHNOvnCoiIikPgcccsRM2 X-Received: by 2002:a17:906:2681:b0:783:6a92:4c38 with SMTP id t1-20020a170906268100b007836a924c38mr3264415ejc.75.1666112371772; Tue, 18 Oct 2022 09:59:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666112371; cv=none; d=google.com; s=arc-20160816; b=RPdn5hrL8TDjdSNE27mtvfEi1wQrucGpG5hQcH8aFdemuU0X0SeQ6QcoLDksNyuVp4 YFfYmPzKHA3a7mQLIfd3WsyEnpRuxvV8aqDAgF3RF58M9OTH4eywb4n3m2a7wwrUshM1 /AnbklUzySCU70ZI5jiEP64kxqsg4yRKylOwoSEVShpMTCfolC865yQlry1peHu3a/ys QqOOv/PzYHkyqJmdRf6+YkX+HGa5oYkhoedCOPDxzFcVTgdjfH9VJpkZmBm+XSeVJvzf iN4HCUaJb8r38Wo9pzNEUQvivoTfoH3tjK40v3vY8gHk0LZFipUyVU4FZ8jSVsDnq5Qm K2jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=f1tkQTVciyk4khfV0GIzuiPCCx1oHlOa5bWZ+7j7T6c=; b=aPJxIb5R0sv5do6qZE223lP29GPmHDxMWujF+oRufeNaeTPGC18NmTXNHGfh8vER49 skAy+s2XcpK0q3GpiuGIrnh4RXjZ5L/s3z1bLlL6+aG7GDgFhpN//ewIby5glMhU5CUI 12bWzYukCyQUCwsNW3iEwtjR5whq2illiXyvJzD7nIv9OV3EKssSp7VarsI6Dbohi0Lv 6UM67oVtLLXF22o95HpMKs29/nsEqbYTI3ZHZ8MzVibXQg/KDTdZboPnzYzlBlkHWPAz XGdrw1QRcSN1Z1zaIiVq4nPUfQj/TjIcTjW7vCkA1/VsjcxAWif+lFo4Tul0s35w1piG CKmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=UEFpHrb3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a21-20020a1709066d5500b0077082e784easi9008812ejt.957.2022.10.18.09.59.06; Tue, 18 Oct 2022 09:59:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=UEFpHrb3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229901AbiJRQtl (ORCPT + 99 others); Tue, 18 Oct 2022 12:49:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229832AbiJRQtj (ORCPT ); Tue, 18 Oct 2022 12:49:39 -0400 Received: from msg-4.mailo.com (msg-4.mailo.com [213.182.54.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 302EF1CB20 for ; Tue, 18 Oct 2022 09:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666111765; bh=95DJzNS4+6BSZN3k/buGJ1S6mzvcYAfN1v5sPyYssJA=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=UEFpHrb3UaPdjOef6bdxjh6GwfQyQjSXod5Q2YDHUUSGXK2o2bqaD7czq9+yTwqjA xwOQsktIpWtL4lOhFyTxd8mHZMVQZrJsa0HpjKaTxA6LhTt9IxniR4z6GYxMYioVdN gwchKIwMeZalhgogxz1TE9KsZ0WH6p5yQoWEgCVY= Received: by b-6.in.mailobj.net [192.168.90.16] with ESMTP via [213.182.55.206] Tue, 18 Oct 2022 18:49:25 +0200 (CEST) X-EA-Auth: AAY4Oxui4nDXgDCRsm/XGiBKJS7WRerNUVMI9i/EcClgwoeDP7Yk6QLaTD4baMGpA46r8R6g3gC6m1YaWP/GSvI5gi2oEDRl Date: Tue, 18 Oct 2022 22:19:21 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] staging: most: dim2: read done_buffers count locally from HDM channel Message-ID: <83fd237d2ac157d234e9c7cce1206904c2d8773d.1666105876.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747045446535835581?= X-GMAIL-MSGID: =?utf-8?q?1747045446535835581?= The function dim_get_channel_state only serves to initialize the ready and done_buffers fields of the structure passed as its second argument. In service_done_flag, this structure is never used again and the only purpose of the call is to get the value that is put in the done_buffers field. But that value is just the done_sw_buffers_number field of the call's first argument. So the whole call is useless, and we can just replace it with an access to this field. This change implies that the variable st is no longer used, so drop it as well. Signed-off-by: Deepak R Varma --- PLEASE NOTE: 1. I have only built the module on my machine, but have not tested it. I am not sure how to test this change. I am willing to test it with appropriate guidance provided I have the necessary hardware. 2. This was a standalone patch earlier. It is now combined into a patch set with another patch for the same driver. Hence I am carry forwarding the change log for this patch here: Changes in v3: 1. The patch log message is further improved. This revised verbiage is as thankfully provided by julia.lawall@inria.fr Changes in v2: 1. Update patch log message to be more descriptive about the reason for change. Feedback provided by julia.lawall@inria.fr drivers/staging/most/dim2/dim2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.30.2 diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index ab72e11ac5ab..4c1f27898a29 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -259,7 +259,6 @@ static void retrieve_netinfo(struct dim2_hdm *dev, struct mbo *mbo) static void service_done_flag(struct dim2_hdm *dev, int ch_idx) { struct hdm_channel *hdm_ch = dev->hch + ch_idx; - struct dim_ch_state_t st; struct list_head *head; struct mbo *mbo; int done_buffers; @@ -271,7 +270,7 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx) spin_lock_irqsave(&dim_lock, flags); - done_buffers = dim_get_channel_state(&hdm_ch->ch, &st)->done_buffers; + done_buffers = hdm_ch->ch.done_sw_buffers_number; if (!done_buffers) { spin_unlock_irqrestore(&dim_lock, flags); return; From patchwork Tue Oct 18 16:49:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 4254 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp2060686wrs; Tue, 18 Oct 2022 10:00:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM76Nh92NeBTMGtuVTBIQ9IsJu4P4KG8ow4Edj/nl4klBSVGbaIzGUqFHSsJxAphWUFwNk2P X-Received: by 2002:a17:906:9bf8:b0:78d:41aa:5eea with SMTP id de56-20020a1709069bf800b0078d41aa5eeamr3155806ejc.137.1666112404857; Tue, 18 Oct 2022 10:00:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666112404; cv=none; d=google.com; s=arc-20160816; b=OAuVFiqRPdnNFvM4uKSahkjKL7Aiem8AzHLs1FcyK3NtblwGMrYV3ZjUcqkWE3pNjl FVmaR6CG0vovEjy5+WOfW9n5dt7IFHXAcdpGrqu8m1rDbO/lJ/5GX26KiSc9dh46Ue7u YcFdkuyE/J5gZXevThz/UOpS/BpwakIG8+mkJZGg7yMvr2NcMAaEp/DcLRtgPvr3e2Bq 9NzP4GwQYpS0YRMANoy2YuBOYMNAf+ZcJrETO469jRpm+EEcKVqrv/KCS33ZoO/vYThI cjqBEEl3o5YDfuuZinPfmqTxC+UZoqTBK7wuXmrY+/qL8mmMgMYbiZC+1k+Cb14nfrGl llgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=oBEkadem7e/fpLP14GiSboSMqehMPwF/rSSD1wGPxbM=; b=Zbr9bDAZbjNuEbSd6l9Eq2danAU+uQ5h62vge2kZIwIgAR5dEF4gm4mOdpXyXWg/92 iAj6KReMfrJAq8kTen+OqnElYKA8l+2cO3M8QBCqzHRvaU5Z0Yvj0VV9EzyLRhQa9ZWD Sznn/LoRi4zgeotYp6w9Sj+Uii1ua8yBet2jv0/1zSgYCPKvPvq5E5EeQ7sRK7FzX5om A6nrYnAKiFKPTA4aPYFZ92alPz4zUeobWMgRfZevPVI3tKIwRcVXUvbUrpzeDnyjtYZA raMd12uhv6qgdicUh6Vpyvrl/D2DwqZLTL4I8J0sRo8Nf7NoNEh/UP3gfxbci1RZn46X 9MUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=UPLnrygJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n14-20020a170906700e00b007330c08fe49si9604094ejj.206.2022.10.18.09.59.40; Tue, 18 Oct 2022 10:00:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=UPLnrygJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229832AbiJRQuZ (ORCPT + 99 others); Tue, 18 Oct 2022 12:50:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229979AbiJRQuU (ORCPT ); Tue, 18 Oct 2022 12:50:20 -0400 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F9205FAD4 for ; Tue, 18 Oct 2022 09:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666111802; bh=29EY3/OiWd3iMrUC+Z221n8xSKWT7a3/meFzR6wx6Rg=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=UPLnrygJi8azATBCFME5W5GsJbaeoA2OVblhpJfki8SQOcVKfFEWESmga62Ey2ytx LuNp1ndjOjtGbIj5A41is56guQzzBqdCOWoBbMeBkrb9M9pK4cT1kpMgWjFz47kJbf bD22xvPhZWZyxZQGG1TDLRFd6yBcpMi4VmN7pKMk= Received: by b-2.in.mailobj.net [192.168.90.12] with ESMTP via [213.182.55.206] Tue, 18 Oct 2022 18:50:02 +0200 (CEST) X-EA-Auth: 5QBNPiTmqvSkx2+BFed9ahndmwwx34D1YnmITye6VjENxrhxM3zeqiAUbZ0O2WCA6GhZFj4dswD0e80vzqrdRU5pK1CpxAVg Date: Tue, 18 Oct 2022 22:19:58 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] staging: most: dim2: correct misleading variable name Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747045480674748063?= X-GMAIL-MSGID: =?utf-8?q?1747045480674748063?= Correct misleading struct variable name dim_ch_state_t to dim_ch_state since this not a typedef but a normal variable declaration. Suggested-by: Julia Lawall Signed-off-by: Deepak R Varma --- drivers/staging/most/dim2/dim2.c | 2 +- drivers/staging/most/dim2/hal.c | 4 ++-- drivers/staging/most/dim2/hal.h | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) -- 2.30.2 diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index 4c1f27898a29..a69a61a69283 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -161,7 +161,7 @@ static int try_start_dim_transfer(struct hdm_channel *hdm_ch) struct list_head *head = &hdm_ch->pending_list; struct mbo *mbo; unsigned long flags; - struct dim_ch_state_t st; + struct dim_ch_state st; BUG_ON(!hdm_ch); BUG_ON(!hdm_ch->is_initialized); diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c index 65282c276862..a5d40b5b138a 100644 --- a/drivers/staging/most/dim2/hal.c +++ b/drivers/staging/most/dim2/hal.c @@ -943,8 +943,8 @@ u8 dim_service_channel(struct dim_channel *ch) return channel_service(ch); } -struct dim_ch_state_t *dim_get_channel_state(struct dim_channel *ch, - struct dim_ch_state_t *state_ptr) +struct dim_ch_state *dim_get_channel_state(struct dim_channel *ch, + struct dim_ch_state *state_ptr) { if (!ch || !state_ptr) return NULL; diff --git a/drivers/staging/most/dim2/hal.h b/drivers/staging/most/dim2/hal.h index 20531449acab..ef10a8741c10 100644 --- a/drivers/staging/most/dim2/hal.h +++ b/drivers/staging/most/dim2/hal.h @@ -27,7 +27,7 @@ enum mlb_clk_speed { CLK_8192FS = 7, }; -struct dim_ch_state_t { +struct dim_ch_state { bool ready; /* Shows readiness to enqueue next buffer */ u16 done_buffers; /* Number of completed buffers */ }; @@ -87,8 +87,8 @@ void dim_service_ahb_int_irq(struct dim_channel *const *channels); u8 dim_service_channel(struct dim_channel *ch); -struct dim_ch_state_t *dim_get_channel_state(struct dim_channel *ch, - struct dim_ch_state_t *state_ptr); +struct dim_ch_state *dim_get_channel_state(struct dim_channel *ch, + struct dim_ch_state *state_ptr); u16 dim_dbr_space(struct dim_channel *ch);