From patchwork Mon Mar 6 13:25:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Bornyakov X-Patchwork-Id: 64663 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1847659wrd; Mon, 6 Mar 2023 05:44:12 -0800 (PST) X-Google-Smtp-Source: AK7set8XSz7+rqU5avWaPKIWqTRaNJxGWwgQzxLbRCalgFJxC7Zv6HncUGEGFZjmSnvBRGOezn36 X-Received: by 2002:aa7:df13:0:b0:4ac:be83:2044 with SMTP id c19-20020aa7df13000000b004acbe832044mr9449241edy.3.1678110252371; Mon, 06 Mar 2023 05:44:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678110252; cv=none; d=google.com; s=arc-20160816; b=jv/ygWRcilBE47mTMt+6IRGvwrTsNlfVf750Z4njmZK6WDCyMxbdFHRQFBOlobSx9U 1hX3Z89xAOJcsEu1DxjnTbH9MfvgCYN/odJSEto2GKlYnZownZqZZy4z0o29rBE4+U6b SIs/7/AXyllCN/8olmxCiTQOxkICN8vB8/5D7YOqQWqXMztQHBWtUGckFShgvbLHqC4m wTfIo8drQdL++HpsHbG1hYcqBys6DdHCweGQTjMCCNn4G/KTWQcsPSCWG1kyomsgj+RQ 7nmHKCRKRzHdCRGJbwHjmMZxEfz44wp2UCD6jWYdHXlqEHajLED+XQfc8CCqMGygaVng /fvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mx2HZbhnlnwkG9XKGHpn6/60Ok8QWspO/v+POGMmpEw=; b=z14nzxsy7gwZHN9GtDrII+b40onVJChi7Pz4gbSNVzNUNeJRLmHpEDSlTsE/Tuti3+ yHg286KWwiSlGY7Df1iQRwCfdOxehCDtcvnwOVvu7Dqd1jHwWP3qJDCrimNJJJsjJSIr kURDVNv5W5Y+3fGjZAG7efvsUuM6vSs45WoD2MS8riuwLqGAeERG2AoXyWj5M96WGD91 usgvhMKxukvPEOEQz1pQImZdBB7rn3AKwiWBJYp066NggkrkiCaVEN1+94BUTAVADEen LbKXYQ1YLSbKvHGuUMC5bt7rggEDnA8MHMieT0lorvp5QlzV5IGexNQO49XWj3djyhFH lkyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@metrotek.ru header.s=mail header.b=Qf1gsh12; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m14-20020aa7d34e000000b004c2405cad2asi3775627edr.640.2023.03.06.05.43.48; Mon, 06 Mar 2023 05:44:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@metrotek.ru header.s=mail header.b=Qf1gsh12; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbjCFN01 (ORCPT + 99 others); Mon, 6 Mar 2023 08:26:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbjCFN00 (ORCPT ); Mon, 6 Mar 2023 08:26:26 -0500 Received: from mail.pr-group.ru (mail.pr-group.ru [178.18.215.3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4FCF2A6C4; Mon, 6 Mar 2023 05:26:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=metrotek.ru; s=mail; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding: in-reply-to:references; bh=82L4rewpG2uOVMVD/V2rJNYXu1V6/Kk/AXQ5nwFZis4=; b=Qf1gsh12D3AUCtrRvSFF4wwXtvJahU5rtctPk5vU8J3rZsyrsUekZa7tu+ZswfsHBd3OOiEhtrZrA i0gn8MAPu85QlTZiV+Q/svH5qclVzxru2FERgHcDdSdDKZTNkUW6yGjbSI+0p/1LOxLNEAxg4hbFMD OQ9gohfpEol9jQNR8R9nWxpAKnSAiIrtJml41RqUyUU95ZLUkCX5GRCghl3ffokBhhOiopxR0MVGoY fDjjRDDxrOWppNtKD10qAj648ypnD7P4L72MrtX+63+VEmcACsjU9SleAiHJBy/SPUmv5+zIfs+w/B G58t6JL74xi2akSUgNyeLGkO2IIauRA== X-Kerio-Anti-Spam: Build: [Engines: 2.17.1.1470, Stamp: 3], Multi: [Enabled, t: (0.000009,0.008115)], BW: [Enabled, t: (0.000025,0.000001)], RTDA: [Enabled, t: (0.091709), Hit: No, Details: v2.48.0; Id: 15.jzm45.1gqrhjk9o.h54; mclb], total: 0(700) X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: X-Footer: bWV0cm90ZWsucnU= Received: from localhost.localdomain ([78.37.166.219]) (authenticated user i.bornyakov@metrotek.ru) by mail.pr-group.ru with ESMTPSA (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)); Mon, 6 Mar 2023 16:26:05 +0300 From: Ivan Bornyakov To: linux-imx@nxp.com Cc: Ivan Bornyakov , shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2] bus: imx-weim: fix branch condition evaluates to a garbage value Date: Mon, 6 Mar 2023 16:25:26 +0300 Message-Id: <20230306132526.8763-1-i.bornyakov@metrotek.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230306060505.11657-1-i.bornyakov@metrotek.ru> References: MIME-Version: 1.0 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759599201079538640?= X-GMAIL-MSGID: =?utf-8?q?1759626135835551095?= If bus type is other than imx50_weim_devtype and have no child devices, variable 'ret' in function weim_parse_dt() will not be initialized, but will be used as branch condition and return value. Fix this by initializing 'ret' with 0. This was discovered with help of clang-analyzer, but the situation is quite possible in real life. Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure") Signed-off-by: Ivan Bornyakov Cc: stable@vger.kernel.org Reviewed-by: Fabio Estevam --- drivers/bus/imx-weim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ChangeLog: v1: [https://lore.kernel.org/all/20230306060505.11657-1-i.bornyakov@metrotek.ru/] v2: * add "Fixes" tag * add Fabio's "Reviewed-by" tag diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c index 828c66bbaa67..55d917bd1f3f 100644 --- a/drivers/bus/imx-weim.c +++ b/drivers/bus/imx-weim.c @@ -204,8 +204,8 @@ static int weim_parse_dt(struct platform_device *pdev) const struct of_device_id *of_id = of_match_device(weim_id_table, &pdev->dev); const struct imx_weim_devtype *devtype = of_id->data; + int ret = 0, have_child = 0; struct device_node *child; - int ret, have_child = 0; struct weim_priv *priv; void __iomem *base; u32 reg;