From patchwork Mon Mar 6 07:34:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 64493 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1717393wrd; Mon, 6 Mar 2023 00:12:09 -0800 (PST) X-Google-Smtp-Source: AK7set9LYKPshWQkw26s5xYMimw7eKCDS+NP/0g5dh5Trj0dy/NFarjyK/7XbB0TpZojU2ysj7wb X-Received: by 2002:a17:906:64d:b0:8b1:77bf:3be6 with SMTP id t13-20020a170906064d00b008b177bf3be6mr9596246ejb.10.1678090329120; Mon, 06 Mar 2023 00:12:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678090329; cv=none; d=google.com; s=arc-20160816; b=csWxa5ZQ1jI9FwpaNPSsdCzuPcJAVdNhgaOaQPWEdL47oVeWxi7mL2DXMrFJK/gNBK J4Fg+dYfCiGm82zuqExVc1OO+tn75X5U/+swYrx2IlM3LCpCAMwQ5opp/ARylsEBIA45 d0EQBHNiQhqn3Az5H6IM/PJoYPFQy+93EZylZ1r6AlpR92z8pr/81vPq/hFu+hoRgMkC 27a2H/Db/TZF8jNIhxD2pPAkNHk1827wDtoKugSmJmKMdABUnwB1MU8Pe3obx8aKe3HD w0W1lIxn6HU7RTIZPZxM/qXTbWytmD0Qv3DPDQlm7jUSAmOnD+GBhmQTkwp2wLUIAHqM CVnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=B3UeH5evaz+7XcEMsDNomAcaowUl3DQFsIsRNBIT85w=; b=LwY8COq/kjooUGB48vFqjqpa9AzmFOEN02W5UQkbZUr/bK1lgCYF6hpWbfIp4HIqku agDeWVOKo4x7CL8mZKkfsx3vDipeZH5ZvQuk8l0GTRcajHp+8Hyh7iYZ6gMlXz6Vtdjd +bgdA7ZQqOC7EqncnyLD+6ItSMLKxHna05T6BG/zK/OYJMSofW8Lsf4h7qqiNVCGth5y sZAeLRidMwYKJArliHgGChfPAgh8zQQETAua4l/VZ89B1T4LXVCfi2tmuJ6kq8JOJcVe ev+DGU2RXFYac0vvv8qEePXG2j8SNDt3RveHzqDLljU5xnuMO85F9REJ1u2+okSPE2kZ CJkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dk22-20020a170906f0d600b008cda74a54absi6279751ejb.552.2023.03.06.00.11.45; Mon, 06 Mar 2023 00:12:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229663AbjCFHfI (ORCPT + 99 others); Mon, 6 Mar 2023 02:35:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbjCFHfD (ORCPT ); Mon, 6 Mar 2023 02:35:03 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37322EB63 for ; Sun, 5 Mar 2023 23:35:02 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZ5N2-0008Ot-6m; Mon, 06 Mar 2023 08:34:56 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZ5N1-002C0p-Iz; Mon, 06 Mar 2023 08:34:55 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZ5N0-002bap-Ts; Mon, 06 Mar 2023 08:34:54 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Mauro Carvalho Chehab , Stephen Boyd Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 1/3] spmi: hisi-spmi-controller: Convert to platform remove callback returning void Date: Mon, 6 Mar 2023 08:34:44 +0100 Message-Id: <20230306073446.2194048-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> References: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1769; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=x46iUoVgDIkav2eWjEW3fVwWqvRPWVkTe9JpC8hEs6g=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBZeKumnzDEGS3cNKpPSgFIsbr4ESrKdUuOXs/ wj2cK5zxUaJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAWXigAKCRDB/BR4rcrs CaeNCACNimmydFtC9/L6aAebZ10gGzFctSiRYpMUXHe6JH2e9I6Ol6C/p0Ijg4HjV1NAYeud/A0 9UQWbay91553sz82s8dXIQaJ5bLBYFgVMThRG6JupwkhpF+b4Tiyt7iSocLK6dMqPKut3Vs+JDt pifCSelGFKjbCAcSPqtLi2uSSuBKwowm+xutjSH6SoGjCQgJfEuPg/3qPoWXRmQUoVfk9j1a1Gh L2em8drjYf1bnOC5zOwlMorTI2sAClCBaz1ToIdH7gvs9vFWyPMg8WxtcoD9PQGKrZ8fAYudzrK Q8tjIgpWXxvGg3rVV+vDQaE7AVmPHDspR7NrCVOvU7b8m8mS X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759605245243840099?= X-GMAIL-MSGID: =?utf-8?q?1759605245243840099?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/spmi/hisi-spmi-controller.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c index 5bd23262abd6..9cbd473487cb 100644 --- a/drivers/spmi/hisi-spmi-controller.c +++ b/drivers/spmi/hisi-spmi-controller.c @@ -324,13 +324,12 @@ static int spmi_controller_probe(struct platform_device *pdev) return ret; } -static int spmi_del_controller(struct platform_device *pdev) +static void spmi_del_controller(struct platform_device *pdev) { struct spmi_controller *ctrl = platform_get_drvdata(pdev); spmi_controller_remove(ctrl); spmi_controller_put(ctrl); - return 0; } static const struct of_device_id spmi_controller_match_table[] = { @@ -343,7 +342,7 @@ MODULE_DEVICE_TABLE(of, spmi_controller_match_table); static struct platform_driver spmi_controller_driver = { .probe = spmi_controller_probe, - .remove = spmi_del_controller, + .remove_new = spmi_del_controller, .driver = { .name = "hisi_spmi_controller", .of_match_table = spmi_controller_match_table, From patchwork Mon Mar 6 07:34:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 64481 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1709343wrd; Sun, 5 Mar 2023 23:46:34 -0800 (PST) X-Google-Smtp-Source: AK7set80bcS1M1c2oPrBSeuGoj7JLeF+/HdBlclWB6Z+KThXFJRowFmm3LRuQ67dR8u7CjkL7VyH X-Received: by 2002:a17:907:6e03:b0:888:a72f:1599 with SMTP id sd3-20020a1709076e0300b00888a72f1599mr12563122ejc.11.1678088794583; Sun, 05 Mar 2023 23:46:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678088794; cv=none; d=google.com; s=arc-20160816; b=pG1MjUD3pNk5aEWEcCVXKI5xblgwIcAFi5N01bxcPW4gG6MNX7/x+izldmANvdZ1Me DwhaeWQ5Vwt1QrjLaplRRdGXK8Zz5KLdrWcm/+JrxY+D3Hmp8ztMNbRzIiSR/wcj15pM cme8nrq+Gj46JN1TXXVGHLftTyUdAjOIUBX1sP/y9nqd6BIao3R7fUDYaqVIQa/iYdBK N+M+iL0wVJkyoo5hNl7IIU7CRLg2G5S5DA1XizY/UjVZ4BsH9HqLJ6H8O3Jv5lWosoQM hB24lq0soSbsYqQA6xFpQzFIx3I96vL3em/EL66f6nkH2whNRhchcdMErPSVvU51Q8a6 FT2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=lTWfjSP0roG5sdqQJHUb70dFUyTMFEIue5pDrsyqG8A=; b=GlipTcC2OT3SNfx5lD27RFJ0NKlKI1a4FdeeC+Wy+j1KLfS44FAJ245454xVGCfelm 1tuZ9h25jAdpaGdTfDpLmZpx50f06ePwOqRrQhnoe07gy1V5sQ4dKzSSkGuM+VsHthmu Ru3QtYNzu+NZVvCbc4wWmleZBKVQhNcDKslnr9OIj9wZS8Hz258Dfu2yyJno8HrsyVeU Zm/wqrNrK18kcBfpXw6p4N8Oza0c2eJx4MNWKt79+A94rGTgOTFt3GqksbFl/sDu9bn3 sMenEzfYrk5TLB+0s2T3tznSn3yNxWfVpJY4VIFURRWEJXv68KHOs276HKRAzFUytnkl kjXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e26-20020a170906c01a00b009095e7da640si8759840ejz.627.2023.03.05.23.46.11; Sun, 05 Mar 2023 23:46:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229780AbjCFHfD (ORCPT + 99 others); Mon, 6 Mar 2023 02:35:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbjCFHfA (ORCPT ); Mon, 6 Mar 2023 02:35:00 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC1A2E388 for ; Sun, 5 Mar 2023 23:34:59 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZ5N2-0008Ou-ND; Mon, 06 Mar 2023 08:34:56 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZ5N1-002C0t-Sx; Mon, 06 Mar 2023 08:34:55 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZ5N1-002bas-4i; Mon, 06 Mar 2023 08:34:55 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stephen Boyd , Matthias Brugger Cc: AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 2/3] spmi: mtk-pmif: Convert to platform remove callback returning void Date: Mon, 6 Mar 2023 08:34:45 +0100 Message-Id: <20230306073446.2194048-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> References: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1827; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=5a+AWwYSnblGSgN1CjlLhD5ySXt5UsbCdNXjzOaMDCo=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBZeNw+Op0YHpL7jeNZglJdgk4+HUUAM9Syky4 ZopRHF9SD6JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAWXjQAKCRDB/BR4rcrs CRFuB/4rWilHuRqmsO6Tvne6ucKbjyP6e/oEpCNTWXJi4wAQWy/PA01KR1+U4isqwbFlNKhj7MA 6ZzMRG7JvPk4LMS2YiKoyNCMTsBpibuaptG5ltsCFYUQ+/3PMyp7E9Kcgpec516fuIzGQFHEfRK D+pFr7HQCuxvrtD/bq/M72MaWx3efZecUWPJPYKYSJnoBAuN5hrdJtme7HPk2F6+jZcTIysvkh1 P7gklleW9mNP1MRoeLgwiR4D246K8biZWLVsck6rihhzWDwyqWHpH6Jvsmk7TNtVcPPM6BBNzKm RQcw6r/w9FU222K3hwnXdWfUtd618Wppjt7aJInqUfWyDP45 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759603635728985915?= X-GMAIL-MSGID: =?utf-8?q?1759603635728985915?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: AngeloGioacchino Del Regno --- drivers/spmi/spmi-mtk-pmif.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spmi/spmi-mtk-pmif.c b/drivers/spmi/spmi-mtk-pmif.c index ad511f2c3324..fbcb3921e70c 100644 --- a/drivers/spmi/spmi-mtk-pmif.c +++ b/drivers/spmi/spmi-mtk-pmif.c @@ -503,7 +503,7 @@ static int mtk_spmi_probe(struct platform_device *pdev) return err; } -static int mtk_spmi_remove(struct platform_device *pdev) +static void mtk_spmi_remove(struct platform_device *pdev) { struct spmi_controller *ctrl = platform_get_drvdata(pdev); struct pmif *arb = spmi_controller_get_drvdata(ctrl); @@ -511,7 +511,6 @@ static int mtk_spmi_remove(struct platform_device *pdev) clk_bulk_disable_unprepare(arb->nclks, arb->clks); spmi_controller_remove(ctrl); spmi_controller_put(ctrl); - return 0; } static const struct of_device_id mtk_spmi_match_table[] = { @@ -533,7 +532,7 @@ static struct platform_driver mtk_spmi_driver = { .of_match_table = of_match_ptr(mtk_spmi_match_table), }, .probe = mtk_spmi_probe, - .remove = mtk_spmi_remove, + .remove_new = mtk_spmi_remove, }; module_platform_driver(mtk_spmi_driver); From patchwork Mon Mar 6 07:34:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 64483 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1711055wrd; Sun, 5 Mar 2023 23:52:52 -0800 (PST) X-Google-Smtp-Source: AK7set9eUFHeL+4nLtqJ9CPLWANK7gLFxmscUy8dx0LswPa5UdQRewZ1OfXJZYsLe9wH7O4c8PX1 X-Received: by 2002:a17:906:12cc:b0:8f4:ec13:d599 with SMTP id l12-20020a17090612cc00b008f4ec13d599mr11306041ejb.27.1678089172556; Sun, 05 Mar 2023 23:52:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678089172; cv=none; d=google.com; s=arc-20160816; b=lZRFL3oPQRHPYN94Holp1ZoJZcIirrR+sb8WS+Xqkb/vEZCCcmtF5J4HSf5grSqI8y D7P7jq6xTBW+o70oKhZjDzW+1bF+PiySOoJXIHUTnVJ+m2nYJMNZnPp+PpSObFnzW5rA WUs9MyZwcdzCmUisf62LBkZ5t++a2+h5Ex31l0G1LdY3ul4NNm3EXl7os3pLl6/1IaMN HMCYT5fwwKnsGsh/FVxwWF794audyxzjmrmSwXrB/Itgl0nuI/glX/Nfqw6lvVMFTKhj R7tKXj2/9x20kVNovgedEF608oHwFEQDOvc8+RucqOSQPXj69Q40OsK4l370Znqt96Ia Ldzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=FP9CEH+jFZEeD0HHqef7ZlPL4FNzLI9dtaAJ3uwHa00=; b=gw60siPiImg9y6ql3tnbc78WdY1kLZF9fw63oYtpwM5mo7+ytvNBxarlvuBE5QfJ9E Ag+Dv5AOQgH02enH0qOgl6s1XCbYjzykx7omBuQS4r25s7Y3aXRBKXSxhaeGj1odnxsE 1+8TJvclXvLPzEApwsG1bbUXG7r/b7vp9TplNmQ0NzK6UmmSA2wr4PAAvpW1pTABpgrw E9Dnw9hzNPSTfP7lphv8gTjh/64qB6qEyi9vNTCCAl6xEoBW+S+jvWkWkygFBIir6mUT AMcpRK5/hudeETbbrIPB82ufyTn2weZafbUO8JWP7UE/eBLnyVy7c4tWrPM7p6NJ1lw3 c76w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h9-20020a17090619c900b008b540d6ba52si9332740ejd.227.2023.03.05.23.52.28; Sun, 05 Mar 2023 23:52:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbjCFHfB (ORCPT + 99 others); Mon, 6 Mar 2023 02:35:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjCFHe7 (ORCPT ); Mon, 6 Mar 2023 02:34:59 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B0F1DBFA for ; Sun, 5 Mar 2023 23:34:58 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZ5N2-0008P1-MR; Mon, 06 Mar 2023 08:34:56 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZ5N2-002C0w-2o; Mon, 06 Mar 2023 08:34:56 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZ5N1-002bav-Bi; Mon, 06 Mar 2023 08:34:55 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 3/3] spmi: pmic-arb: Convert to platform remove callback returning void Date: Mon, 6 Mar 2023 08:34:46 +0100 Message-Id: <20230306073446.2194048-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> References: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1945; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=baC8Vc/YYIcpg5sQZ20fOmFcBz45wH3J4Jd35FckU7k=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBZeRp+KOukWfnCDPaNKuarCheUCsR4j1f92CH 4fGT4kzvDeJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAWXkQAKCRDB/BR4rcrs CelrB/90x7/EalnevrxJZcp1D/0ZVT9Qwb22O7hv3KGfzxwXX+MNYARa1UkQRRESCFg/oMaykPC goVnkcez3yqNT8HCqOxInLxi5eI+yC1Rku0v4TevyrGeFGmpIiwb72WfL+A1vEiYJsXHbv1zX3g WwL8W7emEcTfMFnp3TJTtqz9I7r+kiEdCvvSV7lPvwODFyMsa1+kW4N9KnCvt358Y5hMOIbIgPM m65LMVO7D98Ws5pBzj7gACTCTuQvSrOIKhoDuMnEjNwGfa8BrmyQ1OAXXeJGbRTTtQj9ipQPaJ7 uN0IqJWcPIrH/8upCp3LZqB5daygZaQb/Fe03pblg6s9WeuZ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759604032608711520?= X-GMAIL-MSGID: =?utf-8?q?1759604032608711520?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/spmi/spmi-pmic-arb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 8b6a42ab816f..42a593418aad 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -1674,7 +1674,7 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev) return err; } -static int spmi_pmic_arb_remove(struct platform_device *pdev) +static void spmi_pmic_arb_remove(struct platform_device *pdev) { struct spmi_controller *ctrl = platform_get_drvdata(pdev); struct spmi_pmic_arb *pmic_arb = spmi_controller_get_drvdata(ctrl); @@ -1682,7 +1682,6 @@ static int spmi_pmic_arb_remove(struct platform_device *pdev) irq_set_chained_handler_and_data(pmic_arb->irq, NULL, NULL); irq_domain_remove(pmic_arb->domain); spmi_controller_put(ctrl); - return 0; } static const struct of_device_id spmi_pmic_arb_match_table[] = { @@ -1693,7 +1692,7 @@ MODULE_DEVICE_TABLE(of, spmi_pmic_arb_match_table); static struct platform_driver spmi_pmic_arb_driver = { .probe = spmi_pmic_arb_probe, - .remove = spmi_pmic_arb_remove, + .remove_new = spmi_pmic_arb_remove, .driver = { .name = "spmi_pmic_arb", .of_match_table = spmi_pmic_arb_match_table,