From patchwork Mon Mar 6 06:26:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 64467 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1691441wrd; Sun, 5 Mar 2023 22:49:47 -0800 (PST) X-Google-Smtp-Source: AK7set+WKKbZ3lbVBK3G7jMfMhwpf75OzgPWHB3s94Rnj8wfhJVHV/rCQ0MMJPAnyto+8tXBJghr X-Received: by 2002:a17:902:e746:b0:19c:b11b:ffca with SMTP id p6-20020a170902e74600b0019cb11bffcamr14193371plf.23.1678085387120; Sun, 05 Mar 2023 22:49:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678085387; cv=none; d=google.com; s=arc-20160816; b=kOjzpVJ0t7JV2fGKWzC6P4Xf9vTKOr8ILen65budVMc7yqhindzCcF+nCbl6JVqsYW c0Qa+y/dz0UAeIlvoZgeGJTAWw6DEm+YeILv8H+TpFkvGxDu/HKXcYdK8MgkJOYLVqJl QDxcbHjMl3LfoXkAi6MEsCVPNU6vXXywEsHzCW/Z1GoTT2NBhWW7J1ZDx70dvLr4rKlE UYfFHUPEsLxIOIHeMDTX69i6a/FyRZPW8WUtu+2jtKimP1a4z3KPqQcpT++z6PF1IvJy NGO3fhqjQ7rWvnEGiBcipL/ZLbG+od85MeioRzH+UgUZ5EbQQLNB675sD7KQkjFiyxob DaTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=y+5KYJiUtormz/jrT3bvfPhN0fTpLqDXBrS1X7+kgf8=; b=06NJ2pCiNtFf6ZYW6s/q3coZUjGe6ypCExfxski8gDqAob0lGg/Dg4XnNM69LbGx39 R99AFAJP1EEetZgayB/9gOM2aPV6AnCrMofQy58nb3JzK3t80DFs/uglwt8JM3NAcXBv yQ2t6L1yR0Ae92KhninYWsR0J13q8MydTrtEYkHuJCLy0wlauWuNzsKXrEzVrx68w4q4 2MOAkHxOoSCR2Jf82hj0wdt0LChfehfHCrgv3wXn5hdouScMhRAS4ziAOz1j+wUr8ULZ HR2Z/lUsVPuV7qQknpSv6W7cmyB1mJV9Knvx7IuysoVXDLYcWs+tMpBnOJMDEGTwRf0O Mw6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=QRs+RFmt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kp11-20020a170903280b00b0019c3d82e9dbsi8143091plb.427.2023.03.05.22.49.35; Sun, 05 Mar 2023 22:49:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=QRs+RFmt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbjCFG2O (ORCPT + 99 others); Mon, 6 Mar 2023 01:28:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbjCFG2M (ORCPT ); Mon, 6 Mar 2023 01:28:12 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5FD90A5C4; Sun, 5 Mar 2023 22:28:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=y+5KY JiUtormz/jrT3bvfPhN0fTpLqDXBrS1X7+kgf8=; b=QRs+RFmtFj29262cuJfm3 qnUZvbSvRH5p6riP5bN+xrPl5/Efefk8ywOtw3yP/shz+JFzx8TE0l5IMN0biQWP nZ0/AsSiiMaWawwXCZA5n+Rnl/rsVmZf9/O3Jp1DaBa85YLdVaa7MBHtWcEBLg51 drWq+xyBTDn5UEEEL2ADkA= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g0-1 (Coremail) with SMTP id _____wBHf_OahwVk540ZCQ--.40472S2; Mon, 06 Mar 2023 14:26:34 +0800 (CST) From: Zheng Wang To: mchehab@kernel.org Cc: bin.liu@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [RESEND PATCH] media: mtk-jpeg: Fix use after free bug due to uncanceled work Date: Mon, 6 Mar 2023 14:26:33 +0800 Message-Id: <20230306062633.200427-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wBHf_OahwVk540ZCQ--.40472S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7uF17uw15Jr4xtw4xCFy7trb_yoW8Xry7pr ZxK3yDCrWUWrs0qr1UJ3WUAF1rCw1rKa1xWr17uw4Iv3y3Jrs7JryFya48tFWIyF92k3Wr Jr10q3s7GrWDZFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zi-6pkUUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/xtbBzgIqU2I0Xi19SAAAsl X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_VALIDITY_RPBL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759600062864653925?= X-GMAIL-MSGID: =?utf-8?q?1759600062864653925?= In mtk_jpeg_probe, &jpeg->job_timeout_work is bound with mtk_jpeg_job_timeout_work. Then mtk_jpeg_dec_device_run and mtk_jpeg_enc_device_run may be called to start the work. If we remove the module which will call mtk_jpeg_remove to make cleanup, there may be a unfinished work. The possible sequence is as follows, which will cause a typical UAF bug. Fix it by canceling the work before cleanup in the mtk_jpeg_remove CPU0 CPU1 |mtk_jpeg_job_timeout_work mtk_jpeg_remove | v4l2_m2m_release | kfree(m2m_dev); | | | v4l2_m2m_get_curr_priv | m2m_dev->curr_ctx //use Signed-off-by: Zheng Wang --- drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c index 969516a940ba..364513e7897e 100644 --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c @@ -1793,7 +1793,7 @@ static int mtk_jpeg_probe(struct platform_device *pdev) static int mtk_jpeg_remove(struct platform_device *pdev) { struct mtk_jpeg_dev *jpeg = platform_get_drvdata(pdev); - + cancel_delayed_work(&jpeg->job_timeout_work); pm_runtime_disable(&pdev->dev); video_unregister_device(jpeg->vdev); v4l2_m2m_release(jpeg->m2m_dev);