From patchwork Mon Mar 6 03:30:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 64414 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1639125wrd; Sun, 5 Mar 2023 19:30:50 -0800 (PST) X-Google-Smtp-Source: AK7set8Ms0Okj7dXgRgQLkW3sOGEV27taA+HdbztA1O0cwg2RJ3lOcAzaLmNkbxlVVYmeO9zqVcH X-Received: by 2002:a17:907:a0d5:b0:88e:e498:109b with SMTP id hw21-20020a170907a0d500b0088ee498109bmr12493741ejc.5.1678073450098; Sun, 05 Mar 2023 19:30:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678073450; cv=none; d=google.com; s=arc-20160816; b=B0ySS5sMT0vMgApNeZcUTXc2ljM3Zi/qicxrTVzFwluxX7hDc7kJuLaAGzzY5WfoJ5 5k2OH5nt3uJg5pYTnf3SLhumE+hkKiqmPkXAA4OqLde6f01OnYa9cKVqQf1PUfKCkUmO 0Rfd6SmanVBHvm4i94UjLc1W8pdNzOp0bjiFANIrLxrBvAYjcXyfIQ1lQ0XRdKeTsGbB t4iapklpVPu2ADV1/YgARobpnPX78MJ4uB6BEoNsbz+PiLvAtuTDRope0Dp/Ypqo15MP wGKloErteuEd5ZGRWLCtoIB+ZEFaravm0Prv4UQfyjnStabm6YyuqRWozH0GVmRE+EHZ sHUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=+Ca9VPFFqbn2bUShfGqlt4QL0ldeFn6LQ5DiSlb+a/I=; b=JBB7VK/x/y4uIf2i5ZwXLNGDUuHfh4QmC8vS1Y4uWJovsZgCuinvnm/ZDVmsCEkgvP YjVXSdbmrxZkSf7ChkqUXCYxM/gqjq1a9EhrFBr2Qy63fgxKKJcbXYHz31RSfjCyxqWp 4Lby0YeBwFCATQVIVDDolzERfB4aWFwfzhyENJISxlmrtcR+zeogWGhTT+Pmfk2iOV/5 7xKveZUr41RviJwVb7IedEsScWZkxLFS9hSE28WUuecw1MtccWbu7Eg2AY02oC3cx7D/ pVHIQe6qvB908hvMeSJpqCoqO5+mviJ0W46t2kaHOk4EpQyAcSUzlJxPqiTf1pXBqI4M tqbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=xzHwgIXG; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id z13-20020aa7cf8d000000b004af7147d830si9055676edx.195.2023.03.05.19.30.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Mar 2023 19:30:50 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=xzHwgIXG; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DA08C3858C2B for ; Mon, 6 Mar 2023 03:30:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA08C3858C2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678073448; bh=+Ca9VPFFqbn2bUShfGqlt4QL0ldeFn6LQ5DiSlb+a/I=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=xzHwgIXGCdyp4ey86xD0b9MaYyj3hqTP9m0njJ/7y4qXRUpRHDYF+QA5aQPlmPXCM s9aUnku2htz2yT9J7HhLavQNIDKOcbzpUcOGcmQM6pKdiWxYdSZGby1mFTgf3Ek+Cn omm+TWG70RQ9UfAr+VvRt0UaRCGFtQoAIhQujHGw= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id 5F00F3858D28 for ; Mon, 6 Mar 2023 03:30:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F00F3858D28 Received: by mail-pj1-x1032.google.com with SMTP id cp7-20020a17090afb8700b0023756229427so11851948pjb.1 for ; Sun, 05 Mar 2023 19:30:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678073440; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+Ca9VPFFqbn2bUShfGqlt4QL0ldeFn6LQ5DiSlb+a/I=; b=sp0rjSA9sElyQtjV4zxBheuHNh4T1E7t805TM/6LVnkqT4onDDopLaYDFYKvqDJlbL 1jgNgEOgnY58wtzv7JMY/E/ZmrSY62udFD4iBZGQHLEHzAODCt8UsHUC5ULrqqmK0Gux RgAH6dRc9TvVayO4hmRqoOHnuRxiE3IzRcdGBl40ei0xBfwzK8qImpY3P7+P90Nbd7HU PYOsUjjc7IVcGJCrppbpapgqB7YqpLrY3aSv8zdb1F8vhlFCsPAq1xIyjTkT4PrC3qgW S3dZ4vVdO01SftGKDFNqQekeO6gsyJQvCIkAM+2BSbWhCqvVb3SMJGt0AL+VbfSxXCbF ed0g== X-Gm-Message-State: AO0yUKVo1AXdLXEgwn36UgrGhRGzY0dgIyO28F+6VYlNQN4UZbAHCzxZ cieexRqxZOI/unxwoqR1yLp+pceqnq4= X-Received: by 2002:a17:90b:164e:b0:234:944d:dd6b with SMTP id il14-20020a17090b164e00b00234944ddd6bmr10550726pjb.12.1678073440263; Sun, 05 Mar 2023 19:30:40 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id dw4-20020a17090b094400b00230b8431323sm4966778pjb.30.2023.03.05.19.30.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Mar 2023 19:30:40 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id BAFA91140761; Mon, 6 Mar 2023 14:00:37 +1030 (ACDT) Date: Mon, 6 Mar 2023 14:00:37 +1030 To: binutils@sourceware.org Subject: Downgrade addr2line fatal errors to non-fatal Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3035.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759587546145670602?= X-GMAIL-MSGID: =?utf-8?q?1759587546145670602?= * addr2line.c (slurp_symtab): Don't exit on errors. (process_file): Likewise. diff --git a/binutils/addr2line.c b/binutils/addr2line.c index 1fe9ce2a780..afe116a235c 100644 --- a/binutils/addr2line.c +++ b/binutils/addr2line.c @@ -130,7 +130,10 @@ slurp_symtab (bfd *abfd) dynamic = true; } if (storage < 0) - bfd_fatal (bfd_get_filename (abfd)); + { + bfd_nonfatal (bfd_get_filename (abfd)); + return; + } syms = (asymbol **) xmalloc (storage); if (dynamic) @@ -138,7 +141,7 @@ slurp_symtab (bfd *abfd) else symcount = bfd_canonicalize_symtab (abfd, syms); if (symcount < 0) - bfd_fatal (bfd_get_filename (abfd)); + bfd_nonfatal (bfd_get_filename (abfd)); /* If there are no symbols left after canonicalization and we have not tried the dynamic symbols then give them a go. */ @@ -446,21 +449,27 @@ process_file (const char *file_name, const char *section_name, abfd->flags |= BFD_DECOMPRESS; if (bfd_check_format (abfd, bfd_archive)) - fatal (_("%s: cannot get addresses from archive"), file_name); + { + non_fatal (_("%s: cannot get addresses from archive"), file_name); + return 1; + } if (! bfd_check_format_matches (abfd, bfd_object, &matching)) { bfd_nonfatal (bfd_get_filename (abfd)); if (bfd_get_error () == bfd_error_file_ambiguously_recognized) list_matching_formats (matching); - xexit (1); + return 1; } if (section_name != NULL) { section = bfd_get_section_by_name (abfd, section_name); if (section == NULL) - fatal (_("%s: cannot find section %s"), file_name, section_name); + { + non_fatal (_("%s: cannot find section %s"), file_name, section_name); + return 1; + } } else section = NULL;