From patchwork Fri Mar 3 08:40:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xi Ruoyao X-Patchwork-Id: 63798 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp295271wrd; Fri, 3 Mar 2023 00:41:35 -0800 (PST) X-Google-Smtp-Source: AK7set/u4gB5t1Q6/7veRxj77ZoXSk1okoehrOcHOS3Vbsqk4YWMTRmqQp4RDL9XEPgDPeRIaHFP X-Received: by 2002:aa7:d7c5:0:b0:4ae:f496:1372 with SMTP id e5-20020aa7d7c5000000b004aef4961372mr1101010eds.36.1677832895808; Fri, 03 Mar 2023 00:41:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677832895; cv=none; d=google.com; s=arc-20160816; b=l/G2pSsfGcIbKrzA0ONoThzCU6ZTYqjQlV52VU+x+/tB/TXMkZD18KuvePMPbbegEQ 97VpUwxymb2Af1InubcOhe1nMDHTCQkXxONl1UhPWlpXEBb/vhaGK7x7UehesW/YV/8E Sl+y53+qW3/R6sADL/i98fpeingtuWkqbWDeHBjcJNc/nvUPi6awIHJmYLn27CS7jV+c 4CF7p0NUJt7VnZxymYffoEUDAxR11GSxYqhvag1pE6x2MvzpaGqlBSDIiMc+bTu5VAtx Re/VEw2fbed48hKuBZDlLC96oqhrjUgsej0yOH3LGuN05ep4YDcZlS98LGm3Hxt6AkIO OmZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=kr5LWHf8lmRtS9vMloMS+NxndS92MdXsLpNoJzpRmNo=; b=uuRDg+Xw1uK9o8JEEWWl7N5F50is9nyvNlYAVuwJaisd5Vkn5YtdxghQB8iVSU2UkE okEh/swZYKUVNxWxkj4QDRFZhI7TkjUudVaua7r/IxsTJO8tKSZEIKgzVDpbHX/GvswW HqJSlX3t4i8ZApepB6aLLFolNE7cCWUpnTttqiR6gk3PUn5jJACFKfXTRGG3it4VGvkX NlSX2W7UduZ9F2XtwMsF3GkvHNvvL1juYXuvXZQU0VPm1XjhPbYTFGcQqlSzZ+Soik6M BVmLRM+r28H1Y1i5oML87w5G0HTVe+QZPCi9GrYRRLUxoKQSk/VM1MP7ZAWMuxmF4pZf e3nQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="GkE9J/BA"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id w14-20020a1709064a0e00b008d581b1aafesi1625761eju.784.2023.03.03.00.41.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 00:41:35 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="GkE9J/BA"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 20D733858296 for ; Fri, 3 Mar 2023 08:41:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20D733858296 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1677832893; bh=kr5LWHf8lmRtS9vMloMS+NxndS92MdXsLpNoJzpRmNo=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=GkE9J/BAKhhBblF6a0MB0cW7YzUgXmcqZJ79qahcwjiFP59wka77jg1EqijHYvsYL iK5gRLNNOvteDux3M5x77JhGcuLcvFIpYQdqTeW/rETPN5DRt54b96rcSGAzzZbpNa Ey07DpRHOj6fjzZ4NkFHT+vDGPohHvF6LD2svMbc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id D86D63858CDB for ; Fri, 3 Mar 2023 08:40:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D86D63858CDB Received: from stargazer.. (unknown [IPv6:240e:456:1110:7cf9:ec5:fc73:e9ee:ce76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 6778765B98; Fri, 3 Mar 2023 03:40:36 -0500 (EST) To: gcc-patches@gcc.gnu.org Cc: WANG Xuerui , Lulu Cheng , Chenghua Xu , Yujie Yang , Xi Ruoyao Subject: [PATCH 1/2] LoongArch: testsuite: Disable stack protector for some tests Date: Fri, 3 Mar 2023 16:40:10 +0800 Message-Id: <20230303084011.8989-2-xry111@xry111.site> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230303084011.8989-1-xry111@xry111.site> References: <20230303084011.8989-1-xry111@xry111.site> MIME-Version: 1.0 X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, LIKELY_SPAM_FROM, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Xi Ruoyao via Gcc-patches From: Xi Ruoyao Reply-To: Xi Ruoyao Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759335306368813602?= X-GMAIL-MSGID: =?utf-8?q?1759335306368813602?= Stack protector will affect stack layout and break the expectation of these tests, causing test failures if GCC is configured with --enable-default-ssp. gcc/testsuite/ChangeLog: * gcc.target/loongarch/prolog-opt.c (dg-options): Add -fno-stack-protector. * gcc.target/loongarch/stack-check-cfa-1.c (dg-options): Likewise. * gcc.target/loongarch/stack-check-cfa-2.c (dg-options): Likewise. --- gcc/testsuite/gcc.target/loongarch/prolog-opt.c | 2 +- gcc/testsuite/gcc.target/loongarch/stack-check-cfa-1.c | 2 +- gcc/testsuite/gcc.target/loongarch/stack-check-cfa-2.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/gcc.target/loongarch/prolog-opt.c b/gcc/testsuite/gcc.target/loongarch/prolog-opt.c index 0470a1f1eee..e6a64263384 100644 --- a/gcc/testsuite/gcc.target/loongarch/prolog-opt.c +++ b/gcc/testsuite/gcc.target/loongarch/prolog-opt.c @@ -1,7 +1,7 @@ /* Test that LoongArch backend stack drop operation optimized. */ /* { dg-do compile } */ -/* { dg-options "-O2 -mabi=lp64d" } */ +/* { dg-options "-O2 -mabi=lp64d -fno-stack-protector" } */ /* { dg-final { scan-assembler "addi.d\t\\\$r3,\\\$r3,-16" } } */ extern int printf (char *, ...); diff --git a/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-1.c b/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-1.c index f0c6877fc25..3533fe7b685 100644 --- a/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-1.c +++ b/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-1.c @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-O2 -fstack-clash-protection --param stack-clash-protection-guard-size=16 -funwind-tables" } */ +/* { dg-options "-O2 -fstack-clash-protection --param stack-clash-protection-guard-size=16 -funwind-tables -fno-stack-protector" } */ /* { dg-require-effective-target supports_stack_clash_protection } */ /* { dg-skip-if "" { *-*-* } { "-fstack-check" } { "" } } */ diff --git a/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-2.c b/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-2.c index c6e07bc561a..e5e711105ac 100644 --- a/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-2.c +++ b/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-2.c @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-O2 -fstack-clash-protection --param stack-clash-protection-guard-size=16 -funwind-tables" } */ +/* { dg-options "-O2 -fstack-clash-protection --param stack-clash-protection-guard-size=16 -funwind-tables -fno-stack-protector" } */ /* { dg-require-effective-target supports_stack_clash_protection } */ /* { dg-skip-if "" { *-*-* } { "-fstack-check" } { "" } } */ From patchwork Fri Mar 3 08:40:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xi Ruoyao X-Patchwork-Id: 63799 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp295511wrd; Fri, 3 Mar 2023 00:42:33 -0800 (PST) X-Google-Smtp-Source: AK7set/Srl6I/zolj5yxeVavVSWJPURJskA64Rm6tZWGmhxDo+2PMT8dxtp1UPXGHgX4Iy9Q42uU X-Received: by 2002:a17:907:3e07:b0:8b1:2867:380 with SMTP id hp7-20020a1709073e0700b008b128670380mr1029700ejc.22.1677832953003; Fri, 03 Mar 2023 00:42:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677832952; cv=none; d=google.com; s=arc-20160816; b=hQlpW8L5TU+v5ztOAXfyr7rCtWA2o2j779zWajJKcjBrQk//G3e4o1ZBcFDU77Ff5x J/ZaYdt/I/7hQ8HM+QBa+Jk3hKG41mhC25jIeHGA6JuU5EL+nqUyTcSk3fo9VU7gwoKL QSmsTLQ35zuazJYY/KOhpvuNWyBOmt10kfMiBYYmAEbXGDOEuqKbjP+bQV+jxst1rmay HOlKx8dpJ72TOD9JKVsDFr8jXpTrwu9ihuuzPYN4ZoMWPsQ6NXKiRr7jlOQ1g7pfMk1o rpbRMzpvvxvlDL3JOqyBDbFPJ9r1S3GTTeZvBvqmllHhEt7ywgMmDv38wakBQIxMYrfH hjAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=pSDnLq9pgW/PWI36NoWnwKBmiSChA7B9YPvD9MomBHs=; b=Qt+EOxtVvHmr5R5uztod0r41p/k206YoeSvnJCZBITjHGLafSQPFmerx2pIDqvGpqS Ze6rOH4Nf7ag8yLn/fuXgWxVygxs55V3aflQW88oyi7+kAmpH74nqxd/k6WiqG5fqGez fyMLW4Q9u4AYHQCORx6j9Qp/aH84hnKda9aI6D6hbW3mMuPvWXAxcvrQfBtJDCdYGfQp SYgABef1Nh5SuJvzGXpoKs3p1zp8aGOnaqp+XZ7KuwGz5U47bHygIcZlpjVs55sjTUY5 2/MOCYsrZe81mkhvxkYJWDZhacWfyaJ6zS3s60l+YaZhd7W7j+WEy+R8C8qJgoPlTEI7 XFUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=PQElCrD8; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id qh18-20020a170906ecb200b008d518d4bf7dsi1500368ejb.562.2023.03.03.00.42.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 00:42:32 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=PQElCrD8; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C7FE038582BC for ; Fri, 3 Mar 2023 08:42:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C7FE038582BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1677832951; bh=pSDnLq9pgW/PWI36NoWnwKBmiSChA7B9YPvD9MomBHs=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=PQElCrD8PGxpEYThzNJVnX2d739mBBr2aS0nJ3QvVV2mfDE7xO1gClRFdC460+FrQ kv387kqTmorn3BiuQw0EWpsDXna4MqTz2a0c1je1KnZawMI1XgkagwxcmGqL14GCor NfwMNh8uYuXDNCKSgZThgqjx6AqKE33P4ZvhuKP8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 9C32D385828D for ; Fri, 3 Mar 2023 08:40:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9C32D385828D Received: from stargazer.. (unknown [IPv6:240e:456:1110:7cf9:ec5:fc73:e9ee:ce76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id D6A1D65B96; Fri, 3 Mar 2023 03:40:42 -0500 (EST) To: gcc-patches@gcc.gnu.org Cc: WANG Xuerui , Lulu Cheng , Chenghua Xu , Yujie Yang , Xi Ruoyao Subject: [PATCH 2/2] LoongArch: testsuite: Adjust stack offsets in stack-check-cfa tests Date: Fri, 3 Mar 2023 16:40:11 +0800 Message-Id: <20230303084011.8989-3-xry111@xry111.site> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230303084011.8989-1-xry111@xry111.site> References: <20230303084011.8989-1-xry111@xry111.site> MIME-Version: 1.0 X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, LIKELY_SPAM_FROM, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Xi Ruoyao via Gcc-patches From: Xi Ruoyao Reply-To: Xi Ruoyao Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759335366863358495?= X-GMAIL-MSGID: =?utf-8?q?1759335366863358495?= Once upon the time we used to save two registers unnecessarily, costing 16 bytes. Now the issue seems fixed (not sure by which commit though), adjust the stack offsets to reflex the change. gcc/testsuite/ChangeLog: * gcc.target/loongarch/stack-check-cfa-1.c (dg-final): Adjust expected stack offset. * gcc.target/loongarch/stack-check-cfa-2.c (dg-final): Likewise. --- gcc/testsuite/gcc.target/loongarch/stack-check-cfa-1.c | 2 +- gcc/testsuite/gcc.target/loongarch/stack-check-cfa-2.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-1.c b/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-1.c index 3533fe7b685..cd72154f46c 100644 --- a/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-1.c +++ b/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-1.c @@ -6,7 +6,7 @@ #define SIZE 128*1024 #include "stack-check-prologue.h" -/* { dg-final { scan-assembler-times {\.cfi_def_cfa_offset 131088} 1 } } */ +/* { dg-final { scan-assembler-times {\.cfi_def_cfa_offset 131072} 1 } } */ /* { dg-final { scan-assembler-times {\.cfi_def_cfa_offset 0} 1 } } */ /* Checks that the CFA notes are correct for every sp adjustment. */ diff --git a/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-2.c b/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-2.c index e5e711105ac..3e5ca05b2da 100644 --- a/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-2.c +++ b/gcc/testsuite/gcc.target/loongarch/stack-check-cfa-2.c @@ -6,7 +6,7 @@ #define SIZE 1280*1024 + 512 #include "stack-check-prologue.h" -/* { dg-final { scan-assembler-times {\.cfi_def_cfa_offset 1311248} 1 } } */ +/* { dg-final { scan-assembler-times {\.cfi_def_cfa_offset 1311232} 1 } } */ /* { dg-final { scan-assembler-times {\.cfi_def_cfa_offset 0} 1 } } */ /* Checks that the CFA notes are correct for every sp adjustment. */