From patchwork Thu Mar 2 19:10:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 63522 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp23796wrd; Thu, 2 Mar 2023 11:11:37 -0800 (PST) X-Google-Smtp-Source: AK7set8I4fQAkVqBglwm7ojeR2/xnD6j9FgJrmRbPgMO2KrDowuLUA54mxr3gUL5rQwXIUFsz844 X-Received: by 2002:a17:906:190b:b0:8b2:7564:dfd5 with SMTP id a11-20020a170906190b00b008b27564dfd5mr13418808eje.60.1677784297121; Thu, 02 Mar 2023 11:11:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677784297; cv=none; d=google.com; s=arc-20160816; b=vYWpOtIqlIDPKvKyOIcuQ5LekSyr8cPJptkoQ9Dc+3YI700V8M/lWgwC36FLqyevLE ZVg5qCTUQgMvAj/3ZtIgkkvkkKbQg/KiEW0shevdtX/apTuDOuTkJYnC8f4/+cuz5X7+ /wgLhQJ9VtXkZQU38GmwrPbdQG0c0KIX992+tnDV2IzgfqHtMuIOIYy4nn9Qos88pOCn y5y4yCQzEEmS5CBMSo70JGRzFgiRABhH38+2G9icGW5j8QfAkji0o2UJZu2JeDu4anFk InMthBDQCn6fdfAVj8LM6ZCPjD57YdByz1SJFt7i2zIfEE9C+vGzx+36ux6k3KLCsdRq IS+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=GYOdpUCL/FL6wFvr9klPmpv8oloCttswIm+Fl64qYjM=; b=sUo6mFRUYYvZu1gnugClVEnwBUnBvl3jX1ziaRfCtAJCJ39r6064VheuneIVxDXI3X RduSoNQIcQ7t5j7rSBYtmnPwZgJGfNRPhZ1OZGlGlUZtp6ci5RiIrBjU4lvs/EiFV4Kl wjiatNM2cqJxGWE3YSzjMB724KKmtzdtiSRQd4DVPR18q4cjmVmL/X58OkpGaPSn55iz nvVZuslRJotFSl0GF/b8Hu3paNlsRbu9xiKwGmCOLmpwoumAu9+LhpR+w6ueudun3AVL 5XMN9TJz0YyhpdBcESJYRbueu1i+XcG99aFEdqHmVMyZI4OypKEo4Wv/Gy8atwxLvPNo 8R/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=pXxWIpQm; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id r19-20020a170906281300b008e20d5e7241si30954ejc.876.2023.03.02.11.11.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 11:11:37 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=pXxWIpQm; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 25E39385840F for ; Thu, 2 Mar 2023 19:11:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 25E39385840F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1677784296; bh=GYOdpUCL/FL6wFvr9klPmpv8oloCttswIm+Fl64qYjM=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=pXxWIpQmwitWRJiFdTtpeUBC6/8XXtu08oaWzzrXFpJprGapCLwnGewKyJoiG7Ilm pALL5RBy9XQQgulp2Wc5ywwafnLErHDaosC3Fj+TscNDGiu/zk2GZ/qOmSwb9OuHHw IxlG5lvzZjXWhoJwbFfzBtYP9R6P0zU/ygRljvIs= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 81C783858D37 for ; Thu, 2 Mar 2023 19:10:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81C783858D37 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-596-KkzT9G56NwaqOIuB8qZPHA-1; Thu, 02 Mar 2023 14:10:49 -0500 X-MC-Unique: KkzT9G56NwaqOIuB8qZPHA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6DF763C0E45D for ; Thu, 2 Mar 2023 19:10:49 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.2.16.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46957440DC; Thu, 2 Mar 2023 19:10:49 +0000 (UTC) To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [pushed] analyzer: fix uninit false +ves reading from DECL_HARD_REGISTER [PR108968] Date: Thu, 2 Mar 2023 14:10:48 -0500 Message-Id: <20230302191048.2657370-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Malcolm via Gcc-patches From: David Malcolm Reply-To: David Malcolm Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759284347322725960?= X-GMAIL-MSGID: =?utf-8?q?1759284347322725960?= Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r13-6420-g20bd258d0fa098. gcc/analyzer/ChangeLog: PR analyzer/108968 * region-model.cc (region_model::get_rvalue_1): Handle VAR_DECLs with a DECL_HARD_REGISTER by returning UNKNOWN. gcc/testsuite/ChangeLog: PR analyzer/108968 * gcc.dg/analyzer/uninit-pr108968-register.c: New test. Signed-off-by: David Malcolm --- gcc/analyzer/region-model.cc | 9 ++++++++- gcc/testsuite/gcc.dg/analyzer/uninit-pr108968-register.c | 9 +++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/analyzer/uninit-pr108968-register.c diff --git a/gcc/analyzer/region-model.cc b/gcc/analyzer/region-model.cc index 2187aecbe91..bf07cec2884 100644 --- a/gcc/analyzer/region-model.cc +++ b/gcc/analyzer/region-model.cc @@ -2203,9 +2203,16 @@ region_model::get_rvalue_1 (path_var pv, region_model_context *ctxt) const return get_rvalue_for_bits (TREE_TYPE (expr), reg, bits, ctxt); } - case SSA_NAME: case VAR_DECL: + if (DECL_HARD_REGISTER (pv.m_tree)) + { + /* If it has a hard register, it doesn't have a memory region + and can't be referred to as an lvalue. */ + return m_mgr->get_or_create_unknown_svalue (TREE_TYPE (pv.m_tree)); + } + /* Fall through. */ case PARM_DECL: + case SSA_NAME: case RESULT_DECL: case ARRAY_REF: { diff --git a/gcc/testsuite/gcc.dg/analyzer/uninit-pr108968-register.c b/gcc/testsuite/gcc.dg/analyzer/uninit-pr108968-register.c new file mode 100644 index 00000000000..a76c09e7b14 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/uninit-pr108968-register.c @@ -0,0 +1,9 @@ +/* { dg-do compile { target x86_64-*-* } } */ + +#define STACK_SIZE 4096 +struct cpu_info {}; +struct cpu_info *get_cpu_info(void) +{ + register unsigned long sp asm("rsp"); + return (struct cpu_info *)((sp | (STACK_SIZE - 1)) + 1) - 1; /* { dg-bogus "use of uninitialized value 'sp'" } */ +}