From patchwork Thu Mar 2 14:47:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63450 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273977wrd; Thu, 2 Mar 2023 06:52:26 -0800 (PST) X-Google-Smtp-Source: AK7set/ZNaLiQq72pc31QRMmdA6c5DL5Jlz0VfvriWq9CDTyfbV4O76N7FkRMveLIAN3BvmcqXR8 X-Received: by 2002:aa7:9821:0:b0:5aa:9ef7:4f7f with SMTP id q1-20020aa79821000000b005aa9ef74f7fmr10481071pfl.9.1677768745880; Thu, 02 Mar 2023 06:52:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768745; cv=none; d=google.com; s=arc-20160816; b=UQpmiuHWSQHSwonH+NymgOLPk3lpjmZgnU7m825+ZSBm3MKufRf+kOEET7+xYZ9kto 39EodTUoXww4NWg2nkBoaQhwhLvBCYodOCpx7aibFD4hobzQ404iF8UBC541q08aU100 moLR5huqSfwqqIUAlyeOacycjhpUyk7QGqo9tf/vRpjKgYPqni/yNn1IXd8h5YeIt0Br 9qRAzlZT75fvfKAkjkXy/fTfUd8sGQ1VPazViTRimTzATHsopOxwoLYNYwkKlXOTQa34 dX8u2YhIA/MxzjSlH9bq6Gid16dgPjSXClA0s8OhLI2I8KW9/5WcpUbHRMy3NLFcwbnq XBxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=BY1GjzQdjsCr0AOMmGTtclzcSYTxWYhADMhfvijIXLA=; b=gXCbjEpiMWVTKqklwGW5xofGId9a7bKoLALTg4ABM95An+HRV6FYLto4XGCiawPrdI K1JIYbPTFCJgoR7q8thP7kH7k/Mrey804atA7nc0d1vMqxfWMp4lsSyWQe2b+FeYD9kF MJ4EaiJniPCxzvmXyCbKAbNflIvABwCAiD0i2jiQk36WdZzKlJUELAkjRV/0uTsCenZ5 YM4adsuSwqWN0uZJK+TeJ+c8Ju0BX+txPKWG6LguPRZZgrir3iYxyOm98VvoNEKYkO25 XRMnbk9ldUNP1E5E3xQ1VMJKlG/0CyhCVVYBfzNjDN28zxdLnHZpeLB8q2BRHqk1axXV Pv1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 127-20020a630585000000b004fb359820cfsi1309282pgf.573.2023.03.02.06.52.12; Thu, 02 Mar 2023 06:52:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229494AbjCBOrv (ORCPT + 99 others); Thu, 2 Mar 2023 09:47:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229971AbjCBOrt (ORCPT ); Thu, 2 Mar 2023 09:47:49 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35F7F3E614 for ; Thu, 2 Mar 2023 06:47:47 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDZ-0003r6-VC; Thu, 02 Mar 2023 15:47:38 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDY-001Lqs-Vp; Thu, 02 Mar 2023 15:47:36 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDY-001ZpN-DZ; Thu, 02 Mar 2023 15:47:36 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: "Lee, Chun-Yi" , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/29] platform/x86: acer-wmi: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:04 +0100 Message-Id: <20230302144732.1903781-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1687; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=Bm3IBa63g4dbgofO/bfNR14JENf89OQOoGmeXdiQOJc=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALaFAqKKBbmCSVfcZrLlnzJ+gOTOoySP5usQ4 WnoEH90y2qJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2hQAKCRDB/BR4rcrs CabdB/0cg/Acoa8r2+suMRlOz0PBSjcB5VhhGvP3dYKuJ6A6dX4ci2tjWdyuwCSLSgMfbjT4G2H qKb6IyhR/ePsmIFeOd1uk42EcKfvfQ4foviGVtnN+Ca7oiq8mKAK4wOs9ApfiED0NqIpjZbHMVr r/hgcFtd3wUb8TtGZ/PLXHbHPG0q5PqLK+Doo2pCAFpFnLm8w468D5aRf7g21oDk3uLQdZ09AcJ pg+miSkuaMYOaMdihp2t7QzuqgVP6t7yLsmym+/LtkZMjsJobC6leuiuzFLZU6frDPCBjef9KmN xRqert54tYxk+AqnYb3G1YHhCmFnekROZJvSI3sMktGkxpt0 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268040584672620?= X-GMAIL-MSGID: =?utf-8?q?1759268040584672620?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/acer-wmi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c index ee67efdd5499..377a0becd1a1 100644 --- a/drivers/platform/x86/acer-wmi.c +++ b/drivers/platform/x86/acer-wmi.c @@ -2258,7 +2258,7 @@ static int acer_platform_probe(struct platform_device *device) return err; } -static int acer_platform_remove(struct platform_device *device) +static void acer_platform_remove(struct platform_device *device) { if (has_cap(ACER_CAP_MAILLED)) acer_led_exit(); @@ -2266,7 +2266,6 @@ static int acer_platform_remove(struct platform_device *device) acer_backlight_exit(); acer_rfkill_exit(); - return 0; } #ifdef CONFIG_PM_SLEEP @@ -2334,7 +2333,7 @@ static struct platform_driver acer_platform_driver = { .pm = &acer_pm, }, .probe = acer_platform_probe, - .remove = acer_platform_remove, + .remove_new = acer_platform_remove, .shutdown = acer_platform_shutdown, }; From patchwork Thu Mar 2 14:47:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63457 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4274450wrd; Thu, 2 Mar 2023 06:53:33 -0800 (PST) X-Google-Smtp-Source: AK7set+2r2clfaNB2N/tV/Y0df24QE1FaD/32HyTm5JFaQICYddnoZvPi39fZ3fYjhnCgJTSLGbr X-Received: by 2002:a17:902:8c84:b0:19e:7490:c93e with SMTP id t4-20020a1709028c8400b0019e7490c93emr1482823plo.63.1677768813720; Thu, 02 Mar 2023 06:53:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768813; cv=none; d=google.com; s=arc-20160816; b=gCx7E5lsWfbIzAsz0CIsZBflj42AunCPGIxxHOSdne3lw03oztI+tYDYUs8gDjb98A az/A2mehYTDvEYpNHl0VoF9xWQj3YwV0hWkb94QcZ7YCheYDaXiaRfpPY0PiwASBzDJi a0gUxd0aORRHC8AyJkDH6q3FxlcjeyLMxbeZEOxzrWZZuZaTJVIo77PPq38UqVFb0a62 BN07OFyYIbeWkRIpLWx1wH6LFxtb/Dr0CMqvD6KAKs3rkZMNk4s1yM0i59gVFScRJjMy no2HvUck8J8uSVsNQdUuNOD2bSivL9Hh2PfgULvLgXGjeWKFN89ylMioJBwcnAfjHevo 876A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Hr7m7tomhhPayEGXXw4se/YWXmoh5Eat3OQVj6PqFgQ=; b=hN+WhbZyaxLz1GiZZJ1GyDx9LGj1QA2H3Ay4P3vwENczCpu7B0Jhvc8sr+zyg68fW3 3vYs1q7dgACsEoNP3nb2SMPRcNt3++GHZqweS33LyEOHQgGgxGw/xeVJT1ARz+W94i0v +oqMxC6wZO9ON+AJ3yOeWO/XvhwPCTeVdytGqO558DF7jJkxRxKawfRIjsUzqs7KbEsv q/6JQL2RdIR2C1YjbhIjx5uJSCsSYVoeh0qM/q3fz74QigAl55kbBF9FbXtLl7mYP5ib o2KoY3OGeoOqT1VqVrMpG+nh/BGyCB2KuELnT9abX/OeXElwHEAevsqRsROc7QjmKSiI CWQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kr7-20020a170903080700b0019cd71b567csi2920373plb.451.2023.03.02.06.53.20; Thu, 02 Mar 2023 06:53:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230176AbjCBOsb (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230094AbjCBOrx (ORCPT ); Thu, 2 Mar 2023 09:47:53 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6835C43900 for ; Thu, 2 Mar 2023 06:47:50 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDd-0003r8-30; Thu, 02 Mar 2023 15:47:41 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDZ-001Lqx-AC; Thu, 02 Mar 2023 15:47:37 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDY-001ZpQ-KV; Thu, 02 Mar 2023 15:47:36 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Andrea Ho , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/29] platform/x86: adv_swbutton: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:05 +0100 Message-Id: <20230302144732.1903781-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1713; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=S11c6ENi4+/lxeQmRpXtLc6wBlJ/k8mkXkXP9+wKzJw=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALaJOzTBveIAfTSCwQvRQ6uJZTExOKijXVmnq qFL+oafJ/qJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2iQAKCRDB/BR4rcrs CX4RCACc/Z4VGxknmml3BqrqXgbspWm+mRxcVMhLNbb7hh/TMfV8fT7/KjiKPOSmxTm2fEXQOgB RevAeCjJRHEI1wyf82FUjtvLMHMkp5bFrdcR6VRN7ESVo6G9crT/7BPH/Qbz16EFzSr/A2m3Y8c IerD01wHq3i+loNgoZ4ltSlW/Ts1KEUunXaD4jqOL6wjYtIksSjNBnWmyrQxUIMgE7pR2B2QDD5 ILPE1CDdE/44UGnn/2gnmSkH2dPP/R90vxVJwUlQb0J1MebVM5Cw6bEiNK9nLRdeLspslS9IFqN nZIgSGbdcEf8DI+aFNF8yQCns7WXQtspY5N+d62Y+vGrgMdB X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268111579913894?= X-GMAIL-MSGID: =?utf-8?q?1759268111579913894?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/adv_swbutton.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/adv_swbutton.c b/drivers/platform/x86/adv_swbutton.c index 38693b735c87..6b23ba78e028 100644 --- a/drivers/platform/x86/adv_swbutton.c +++ b/drivers/platform/x86/adv_swbutton.c @@ -90,14 +90,12 @@ static int adv_swbutton_probe(struct platform_device *device) return 0; } -static int adv_swbutton_remove(struct platform_device *device) +static void adv_swbutton_remove(struct platform_device *device) { acpi_handle handle = ACPI_HANDLE(&device->dev); acpi_remove_notify_handler(handle, ACPI_DEVICE_NOTIFY, adv_swbutton_notify); - - return 0; } static const struct acpi_device_id button_device_ids[] = { @@ -112,7 +110,7 @@ static struct platform_driver adv_swbutton_driver = { .acpi_match_table = button_device_ids, }, .probe = adv_swbutton_probe, - .remove = adv_swbutton_remove, + .remove_new = adv_swbutton_remove, }; module_platform_driver(adv_swbutton_driver); From patchwork Thu Mar 2 14:47:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63437 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273427wrd; Thu, 2 Mar 2023 06:51:15 -0800 (PST) X-Google-Smtp-Source: AK7set/HomXwD0D3cD55xl82Q9kioKDJQFdCnYaRVy6d9QVIcbx+aY/vHD0fLjgsh8DCZleSyBN5 X-Received: by 2002:aa7:d959:0:b0:4ad:738b:6706 with SMTP id l25-20020aa7d959000000b004ad738b6706mr2543806eds.2.1677768675377; Thu, 02 Mar 2023 06:51:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768675; cv=none; d=google.com; s=arc-20160816; b=bFUtkHTyWHZ+UVceqpaihVMsy7rW0WLb3Iuu93D3/45Qr5K5L3wbFTnlRtdo4u1kRQ i1pUuQSBv9s20EhX2uMBGJWIhap83Sl1vhVVxZ0+GJykjtKNbF6F7AvEDfDZ+n5ZbSkA 94J1EeUn9uNHFxsF181tJoQF7/hMuGz8KjOQ9RcW6lXHjoMNjxcq03ufigs9TLUit24o Yv0fFlSa2w2iY2GhyiZgubfw5Jk+FBiXZvXAgfU4wfxeAR3RW8c8oQJpgBpCmzL0JJCf 87sO8mb+u1m3DyQ7ggLbtrYpPj6HTT7L2CTlC8/mm7ozn+JQLuwtOJOhdWvN4NAnEf/v lF8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=efiQCCCM/o/zjelvOrQvnpwXOqb9PAWso7ZB9YVO4BI=; b=qbJJjnBoKVynP7aQ39u5JZM24LonV+kVOntp00pmK3iSCXRG2beM0aTMwfi+niKjUS Szx76X8PdmajqGWyq/7I57SzbMYeEeXLmijCOxu3epLoTwBRv1QdIzJQSu+RPRnAmPIf v7Ryz0lK/NrN6X+ZLjZge+W/MKQDMIDtvl7sumSUiFlpDnwzf/cFM0c8Us+yIwxR2Og7 AFYbh0bqnQ7uHpvMxw5fx0JaaKPrcCq9bOmsNpXtHYeGrw2P2y8JhnV9QkQDlYFWIlDw RrXQWa3yib7CjgYN1f1KSWH4ReGj+TvxZ4uV5jwk+eW6B+o1ZzBwrJqnIZF++2iPV15l zSRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a20-20020a170906245400b008f0ba094bb6si16654922ejb.707.2023.03.02.06.50.52; Thu, 02 Mar 2023 06:51:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230195AbjCBOsR (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229990AbjCBOrw (ORCPT ); Thu, 2 Mar 2023 09:47:52 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EA8E460B4 for ; Thu, 2 Mar 2023 06:47:49 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDb-0003r9-2P; Thu, 02 Mar 2023 15:47:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDZ-001Lr2-Mo; Thu, 02 Mar 2023 15:47:37 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDY-001ZpT-RI; Thu, 02 Mar 2023 15:47:36 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Naveen Krishna Chatradhi , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , Carlos Bilbao , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/29] platform/x86: amd: hsmp: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:06 +0100 Message-Id: <20230302144732.1903781-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1461; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=qgD6Fu+TwEiUbD68TORw2X6DDiB/hL0lY5kxPSiVZIw=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALaNEhHeZybd0i9WVR1+OP5V0++Ct8ZKYQXPY SR2dxnaPy+JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2jQAKCRDB/BR4rcrs CQblCACBa4XFyZ4EUSa9UsFxt52M+imRA1OkAW1aKR1jxMnUiTcge54noOrMVuW74wFatFUm4NC 1Q8G6WymgHcOyA8lgiaCEnTRX0CQ+1XixLaF+e2arwIIip0NHBg3BLbkUiz9d63pw26wRnvASeU 2SpxelmAMaY+szOQFdktT0TsizOcP9P52roVXL85e/zjyuRORno1h4XmoKKwNPVn0lZI5tfR0TP fiGLEacB1nOkpS3IoN0ffYQft7CtBooBfAJs38jV2M23JHOrwCStfofeEMw5PJeqkW9ui9n3jKB qgtmpVfYYKak/c9x/8OUs1sLGdLqfTcyJcIHxklaGVrNr2Rk X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267966751243689?= X-GMAIL-MSGID: =?utf-8?q?1759267966751243689?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/amd/hsmp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/amd/hsmp.c b/drivers/platform/x86/amd/hsmp.c index 521c6a229362..31382ef52efb 100644 --- a/drivers/platform/x86/amd/hsmp.c +++ b/drivers/platform/x86/amd/hsmp.c @@ -340,16 +340,14 @@ static int hsmp_pltdrv_probe(struct platform_device *pdev) return misc_register(&hsmp_device); } -static int hsmp_pltdrv_remove(struct platform_device *pdev) +static void hsmp_pltdrv_remove(struct platform_device *pdev) { misc_deregister(&hsmp_device); - - return 0; } static struct platform_driver amd_hsmp_driver = { .probe = hsmp_pltdrv_probe, - .remove = hsmp_pltdrv_remove, + .remove_new = hsmp_pltdrv_remove, .driver = { .name = DRIVER_NAME, }, From patchwork Thu Mar 2 14:47:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63449 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273944wrd; Thu, 2 Mar 2023 06:52:22 -0800 (PST) X-Google-Smtp-Source: AK7set9qa7yk6ynvohy/qiG9x6Qi6tHgz+b6Xh3TUSSEHQ5t9puQSdgG7IWB2BrqvgUHQzFmPFfm X-Received: by 2002:a05:6a20:728c:b0:cc:ce95:7daf with SMTP id o12-20020a056a20728c00b000ccce957dafmr12152326pzk.53.1677768742552; Thu, 02 Mar 2023 06:52:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768742; cv=none; d=google.com; s=arc-20160816; b=YVlRX6+FYPU1LIQQy0LU2kefnfS1cIID5chqf1mj+msgzUgo8Wn7Ai+t79+DdP8MJL G/jDnp16sxe8ax3YzMupJI4zE2smsTOx6Qjj3Az+uO7OKHGVBGoyl/CBbud5PIYpaP3Q 4te3JlnB4vaX7ZiPQvklEtAd5aCQ+TgyOfefzpa3RQMZKOHLs5A9+2uFeopep8I8Obft XpOsCrOcJNLwWehpxUZHKLu99uDyN3EtKSba609FXZ33k8zZDiqyff0leCfB4GzRFJme tRf8S4hOyJhAP8dcbS1QGWJxfzjV967fWMwHv2Yb3JS+bVEQoO219emj0ANnICPQNQng ihMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=mAaAowyCfDoShsyPJOH6UYrq5mShErWiHwWLQuNBLTU=; b=0gvjgl/7RJsixze99MZE20azSqxJ5sjuMabfTirqWBRojrQDFA1TcQJnn2b3sz0esm YjT1NnJvZfWQ2+KffqfxY/hJoCIe/NgV/ovWFtFOIt/JfcZ3rQwZSYtuMkuyEFq20PVA b9vjxSlBtMXCqzGHaHe4JocqbWgf0F0xXTYHrjY+JZqStpRMIYkEueyf30URJZvO3Gur ChBrMChd81lPN0ElPf/wn1En20htLcwk9btCBj2/lZo9EapM8HkTZXZOA+A5xQ96pw3M S35Txs4FNFA9RtYdDOn0HUPZRUXbZ1oJ+aBC8AUkUauj15N+m+YASbHWInANocitYLTA 0eaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e67-20020a636946000000b004fb416b8f0dsi14585259pgc.39.2023.03.02.06.52.08; Thu, 02 Mar 2023 06:52:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbjCBOsA (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230015AbjCBOru (ORCPT ); Thu, 2 Mar 2023 09:47:50 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00BAC4391F for ; Thu, 2 Mar 2023 06:47:47 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDb-0003rT-72; Thu, 02 Mar 2023 15:47:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDa-001LrH-JH; Thu, 02 Mar 2023 15:47:38 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDZ-001ZpX-11; Thu, 02 Mar 2023 15:47:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Shyam Sundar S K , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/29] platform/x86: amd: pmc: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:07 +0100 Message-Id: <20230302144732.1903781-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1696; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=N/5HsQ5hB+LY0fL7yq3qKM6LTsVLQJmEQenXSQKhbOE=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALaRyFlnNiYZtBpEr4pwKkNUqnnDW7udEIyiF a9JWVDchEuJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2kQAKCRDB/BR4rcrs CfP4CACR1mYYMgYbAFfoUr3kO3mz8olRcx2Uw2iMcxDacBjm4LJdvWiY8OySjrvsIM49RCOohrf KnIIPovSEAh4hxHtGZGdX479q1S/AiKaztGLZ0QsWXcPGRkqw2ELLH4ei20WqfvNl6FlTLEWa/U O/Q+rImUgIGtPZ+TAja1MIxLBEmzLHTm/n7e09wGeT/SHzn++Q7ZZRhkDZbE6H7e45f0j1GUS7K mnW9cILhEbQeI8LXxpbRtHIjrD5/xs2eVHPmIHRyoxUr/Td8wlTT/F0jbjlqmwpGthSuPsYr8os kqnU1SW9uQ3N7FjaHzLJQiRoODJ84mmRRIu3uobnosrYYYF3 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268037301876498?= X-GMAIL-MSGID: =?utf-8?q?1759268037301876498?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/amd/pmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c index ab05b9ee6655..2f7b1267c5e4 100644 --- a/drivers/platform/x86/amd/pmc.c +++ b/drivers/platform/x86/amd/pmc.c @@ -1031,7 +1031,7 @@ static int amd_pmc_probe(struct platform_device *pdev) return err; } -static int amd_pmc_remove(struct platform_device *pdev) +static void amd_pmc_remove(struct platform_device *pdev) { struct amd_pmc_dev *dev = platform_get_drvdata(pdev); @@ -1041,7 +1041,6 @@ static int amd_pmc_remove(struct platform_device *pdev) amd_pmc_dbgfs_unregister(dev); pci_dev_put(dev->rdev); mutex_destroy(&dev->lock); - return 0; } static const struct acpi_device_id amd_pmc_acpi_ids[] = { @@ -1066,7 +1065,7 @@ static struct platform_driver amd_pmc_driver = { #endif }, .probe = amd_pmc_probe, - .remove = amd_pmc_remove, + .remove_new = amd_pmc_remove, }; module_platform_driver(amd_pmc_driver); From patchwork Thu Mar 2 14:47:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63435 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273342wrd; Thu, 2 Mar 2023 06:51:06 -0800 (PST) X-Google-Smtp-Source: AK7set+7gSYOwWTH6ESTNMnLN6Z2CXK73IxFy4PFEkRihkb+iCPYbj3i4CMqkBL+h3RkHrf/McEO X-Received: by 2002:a17:907:6d01:b0:8b1:76ca:f228 with SMTP id sa1-20020a1709076d0100b008b176caf228mr12417304ejc.39.1677768666415; Thu, 02 Mar 2023 06:51:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768666; cv=none; d=google.com; s=arc-20160816; b=wuI11uOFPXQrr+rEsStxp5ZXiHI/mnONFwiXbQqCz7/3vm2FM+Xi3m7X6zzhd/bKPu fxACUTy8JY2YSYl2MyNxLstI5kCzbsaFlNIvJqc05y+hwVlGJs5RMzg6MwCzcfCZgdf6 hPQDIVauVnkcCX9bFur3nA0Xcuhjme53jqCFNksEZOSC1wWmQxjMMbL9w5LJOsGWzLaZ PV6tyEvTrCfh6oAmND06hkHE8XDIUAKK0Tu8fUXDQ18zG7KSiS0fZIaGpaamA1o4Q1zq yUhTcPf1JDm/6EVnoX0XUQihcrULvm2xkSg8WNZUcNBdGxOSGrT16rqyk1Fvmc2k+Nxy tbSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zbBGip6n+u68FKN/wYbMxmbnusLqfshDeM5saryOohA=; b=cUlODgP1SRZyLBBnKf1xxRRWW+lm53d35qlGkEwi1wel0ey5xDYAT404KlueAfktPj Glgh7rd+nPZYxHxr9LiHTtZKtuPjGhl9pD85NEwsLLmmLpZiha+0MzcdzJLzxQanXpdi MJAaHXMFuXBM51fWzKpb3CFt68dm3hXZh3/0A2r+P9ZOdLYw/lr221xywlGfYhUEdg3f /5M3pewVIRLWBT2jNaewaEUOC3U4u/g4pYXEzjLVODocyfywMZICSSai05RHZZENyTKr Y5zFN1NmulgnI50zS58BH1Tct/lwGPSzPhpz/JsgyvPV5Gxk07U+p268N9Ce9VuT03PM GMrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o19-20020a1709062e9300b008b17b550d11si2912806eji.382.2023.03.02.06.50.42; Thu, 02 Mar 2023 06:51:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230179AbjCBOsL (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230049AbjCBOrv (ORCPT ); Thu, 2 Mar 2023 09:47:51 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED5C346091 for ; Thu, 2 Mar 2023 06:47:48 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDa-0003rA-P8; Thu, 02 Mar 2023 15:47:38 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDa-001Lr6-0g; Thu, 02 Mar 2023 15:47:38 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDZ-001Zpb-7B; Thu, 02 Mar 2023 15:47:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Shyam Sundar S K , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/29] platform/x86: amd: pmf: core: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:08 +0100 Message-Id: <20230302144732.1903781-6-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1749; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=NLxovv9AqdM9/bwpLuxYogacX4f0kVeQEwMkH3uF2MA=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALaVdEf8Iym4jEzQzhQOe04S9Uf9m2gLZ0/MD dAnrq4FWveJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2lQAKCRDB/BR4rcrs CRpWB/9pbIaMZy87nfOk+7vTzUoPV7iOdFI8iZOP8bZ1BwiUHKqUYQCWNjrPCRQCbmCWv6kEMAU h/cdt0PUc804WzHHwOK03oQAe6cunZA+fKZaw7S+82drmJ4SdfIVOHsnzvS1sT10+WlDYWvKqJ2 zciWXyZ6eAzSx/TIpMgW6hFPWU91S4U1+kJn85DkINmRPHG8dKY/hvfvPmXvKp2aYCFQ5solVEx HckHwDmEd8Ni8KprTu711Vz1VuJqR7rD8dgBe2pqF2MT++gK58rN+Y/5I6OJulOwSiAA2wLMKVt qQ1Fti6zrucbjL+y4WT+Llo6RhgjGzaDVaygHcTZA6sCVcYU X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267957092278022?= X-GMAIL-MSGID: =?utf-8?q?1759267957092278022?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/amd/pmf/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c index da23639071d7..800ca2c998d3 100644 --- a/drivers/platform/x86/amd/pmf/core.c +++ b/drivers/platform/x86/amd/pmf/core.c @@ -402,7 +402,7 @@ static int amd_pmf_probe(struct platform_device *pdev) return 0; } -static int amd_pmf_remove(struct platform_device *pdev) +static void amd_pmf_remove(struct platform_device *pdev) { struct amd_pmf_dev *dev = platform_get_drvdata(pdev); @@ -413,7 +413,6 @@ static int amd_pmf_remove(struct platform_device *pdev) mutex_destroy(&dev->lock); mutex_destroy(&dev->update_mutex); kfree(dev->buf); - return 0; } static const struct attribute_group *amd_pmf_driver_groups[] = { @@ -428,7 +427,7 @@ static struct platform_driver amd_pmf_driver = { .dev_groups = amd_pmf_driver_groups, }, .probe = amd_pmf_probe, - .remove = amd_pmf_remove, + .remove_new = amd_pmf_remove, }; module_platform_driver(amd_pmf_driver); From patchwork Thu Mar 2 14:47:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63440 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273474wrd; Thu, 2 Mar 2023 06:51:19 -0800 (PST) X-Google-Smtp-Source: AK7set+Ktp8yJPLfrJr265++clWC0s3z3Prr5XtV4vaZjcHBNGpRdG3P3VvaXSeRRVYMB0Si4SIt X-Received: by 2002:a17:90a:7a8f:b0:237:8c4c:c908 with SMTP id q15-20020a17090a7a8f00b002378c4cc908mr11917697pjf.26.1677768679444; Thu, 02 Mar 2023 06:51:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768679; cv=none; d=google.com; s=arc-20160816; b=D1JBxI3cwKgaYZLiq4QuY4z1NtnvsyWsnoIcZPHmOv6295BWqIOEeVfr0kPV94PwIu 8zh8HFfr0DCAedQao3SFqqvXN++pQ/byjOGkprkIlpr/TKVXCNgcYxry2M0UwwtITOBd hXN5dq4ZqMzhPkwY8kI+ly26XpfnJs+aBVVP/aNrTnqBupjnP7gcjgt1zxzUL2leB/b/ GC5n/Yb1ANPHK3VVHFLpvOJ9PMKthvXwa/MAnfuoKfrjEHQGjZ7fwRjCrC0y2wubp6yR HDYzrReLLL40KSrGuYRT577MQV7gRcFsKgw5a6123AGmLsgM+p4dP2ztuytULr8+9e9k cToQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=cmNLts5vqPwxZjnoqmJAK5KM0jk9L3qN7mSXGcOYJCw=; b=rQQfooMyocGSJ+HPMZ4nbBtdm2BdtZHkuPBokEpJXyWwHP/bkkmmhevw2PDqNh6L+9 mO0ljoelkNizvTKu3geh0j5Kn09nOVYewSDO3EQ/KlNNSXvDxFn6sd/dKyottI/q3sqo a09K+aMes2l++Ys3jD6UiwQW4WRKEpdl+y1QV6bdIn0NVzpClnD2ZwkNbDoTks3B0k/3 u0caffaZzSWxnBHF2bHr6fLFYupEQMJNW79GAy3Oqj3wl1bQ6SQhUGp+gaVQJ02Awd3e oOmgmj+gu/7qviEYDggS4AvjI3Q347hLb85V2Mqu4QRTEj8dkgjd1swONgwlbNZ8pS7T FDLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nk19-20020a17090b195300b0023670bc014dsi2462146pjb.110.2023.03.02.06.49.50; Thu, 02 Mar 2023 06:51:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230022AbjCBOry (ORCPT + 99 others); Thu, 2 Mar 2023 09:47:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229981AbjCBOrt (ORCPT ); Thu, 2 Mar 2023 09:47:49 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAED841B72 for ; Thu, 2 Mar 2023 06:47:47 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDb-0003rI-24; Thu, 02 Mar 2023 15:47:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDa-001LrA-9m; Thu, 02 Mar 2023 15:47:38 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDZ-001Zpf-Dq; Thu, 02 Mar 2023 15:47:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/29] platform/x86: amilo-rfkill: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:09 +0100 Message-Id: <20230302144732.1903781-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1623; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=A8djoGpUAgNgkbWQ39wAp8VsGIh4VFkpPhaldfySJwA=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALaZ2pVqagkhwomGyOVT91iRR36ZU9e7wuLcT JPIITqf5Z2JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2mQAKCRDB/BR4rcrs CTfKB/95zYHTwLm7M3dAiiZI2Y5CA2UCdwVZr59pVKuWqZJ0rNZ5bUV9ygA/PIwL2AV90a5y6w/ EfytQEvPQhocXUu5Lo+e7yMqsvA5/9aclOMQONCv8MbV4zrudSKGnMXvPjNaUojoWyjDgdfc3Bv 83GB0TOQgKwNlAjktslFxkS0Rz+VrYBtxR8H5U1+S0LbSKUewDWRBJN9Uj4uPekHcllZJdbkd7L FYlTmEQcPSsiWX2IeURMmWxnOdyFIxLnhPz/BJiKrLaWT6m+0K5EwG8qwQDFLMfFrY2XaKmQRVf b3xZ7ijEMIYtc4j6EOrERAbky6dDSgM4tUJvz/SWfn9QQMHo X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267970345989708?= X-GMAIL-MSGID: =?utf-8?q?1759267970345989708?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/amilo-rfkill.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/amilo-rfkill.c b/drivers/platform/x86/amilo-rfkill.c index 3e313c4d538d..efcf909786a5 100644 --- a/drivers/platform/x86/amilo-rfkill.c +++ b/drivers/platform/x86/amilo-rfkill.c @@ -124,11 +124,10 @@ static int amilo_rfkill_probe(struct platform_device *device) return rc; } -static int amilo_rfkill_remove(struct platform_device *device) +static void amilo_rfkill_remove(struct platform_device *device) { rfkill_unregister(amilo_rfkill_dev); rfkill_destroy(amilo_rfkill_dev); - return 0; } static struct platform_driver amilo_rfkill_driver = { @@ -136,7 +135,7 @@ static struct platform_driver amilo_rfkill_driver = { .name = KBUILD_MODNAME, }, .probe = amilo_rfkill_probe, - .remove = amilo_rfkill_remove, + .remove_new = amilo_rfkill_remove, }; static int __init amilo_rfkill_init(void) From patchwork Thu Mar 2 14:47:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63442 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273482wrd; Thu, 2 Mar 2023 06:51:20 -0800 (PST) X-Google-Smtp-Source: AK7set8VEWWfqJh87VIdWxCS/TmcXhU+/Y/iDmjLUBxlC0fxkmeYBRBhhUvK6Ppq0rgQrMs7J/iV X-Received: by 2002:a17:902:f546:b0:19e:2ea1:c0f5 with SMTP id h6-20020a170902f54600b0019e2ea1c0f5mr12820558plf.33.1677768680352; Thu, 02 Mar 2023 06:51:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768680; cv=none; d=google.com; s=arc-20160816; b=Y2IKhckSK948tMlVcMKiEt4MaUZOzEdhVYBeR5APLN7NFZwCI5kyNd84785Mtb5OWZ YCqQM+5K0qoIaur1+zPVjdPqYwdFzg6CKq28oj9p+EL2aEQJFei1McDJJU+s4uqjOkau 54/Xs+f4GISvwuz6QjRFJPWW2MUVF+wHlmhUqzAGnUqc7+giCirAVMKFzUUjEGAGJYIM IESPDOX8PdPbEr2NpScvabK9YWp/3rrj1ee4WuLzSPl5yV5Lad8jwB3vAQLHnywwP6EO 8GfkAxoKjVZjSytNMemXX+2sh9i0nZvnBWVmZ1YPobUN0lizir3oCzQPJdsdAiiBCFSW qjPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=sFB/LA/anL269WLEWVMjYo6E0SSsHjsYWJVeXU0Okb8=; b=XPldYF7pkj57d/otwXZQKegBM2Lcg1ReIGosM7z+5gI75teY65GbycljnKI+wwkSxe c3eMcBCSt/fb6ySBgv9wVtwy7pB3R9sws93zkA33rDvjTUGtxI3k4lNlA4Wg8DbRm+KE rsmF5dbWdtyFjqEsKEnXPKfLRstCZ6qSsDo+csEUql+ar3ewY5Wq7TOun54Z8YvDcrwW O0CtOI87tuAnVzHWJ+qH6dxWQ2IXEwsFeFt2xTQq8yAOhOHhuUdCLQFPfm8m45xKGoBf 37bU10737B5ePv4dqAl94a3sxKNGNb/QGD8lz5P6SD36+iuRNw+RZkMrWIHjZu8XEq5z 3aiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kn12-20020a170903078c00b0019e4124a43asi5706301plb.61.2023.03.02.06.51.05; Thu, 02 Mar 2023 06:51:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230227AbjCBOsX (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229971AbjCBOrw (ORCPT ); Thu, 2 Mar 2023 09:47:52 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 827FE474E3 for ; Thu, 2 Mar 2023 06:47:49 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDb-0003rJ-BC; Thu, 02 Mar 2023 15:47:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDa-001LrC-Bs; Thu, 02 Mar 2023 15:47:38 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDZ-001Zpi-Kt; Thu, 02 Mar 2023 15:47:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Santosh Kumar Yadav , Peter Korsgaard , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/29] platform/x86: barco-p50-gpio: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:10 +0100 Message-Id: <20230302144732.1903781-8-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1730; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=3SITRhRSsSiq5nNlw0cLw6UVXc4FMRsIXWa8cM62MP8=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALade3Gi1p/sJd8H8iXfaMV7bNpT7R16FeAlt mHVTQ9i3e+JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2nQAKCRDB/BR4rcrs CYxWB/0T9N2ZDz5pxanXc2jdn15Ou5okIo+OA378H8eFhJmwvYWT8z4crokjCAlcWEzwa4cv+3P +rZX9fAQRiNbIBH8+1OCOBVoPTZ5k9omOFb0s2QMgmXfEgi/daEjB5wJmBGpaCZVYw92pbn5D7A qKn1YLoQctNI8bhW9gbeLMNaG0IwGNHMGywnxwYb7ruLPvybqYBRSqLRJz7Mcal0jXC/D0djcPz tShBXQRNLFixNR4CiyoKY5vkLOn0YIYt8Wt8cXDxU3SLtxsyUM74CIsVAonZCEdNUeJRGYFVhOy bv6cuIeSpFDjQOK/272o5cD/s88jM+6NiCRI3Wxy0lhvfase X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267971339756987?= X-GMAIL-MSGID: =?utf-8?q?1759267971339756987?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/barco-p50-gpio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c index 8dd672339485..af566f712057 100644 --- a/drivers/platform/x86/barco-p50-gpio.c +++ b/drivers/platform/x86/barco-p50-gpio.c @@ -370,7 +370,7 @@ static int p50_gpio_probe(struct platform_device *pdev) return ret; } -static int p50_gpio_remove(struct platform_device *pdev) +static void p50_gpio_remove(struct platform_device *pdev) { struct p50_gpio *p50 = platform_get_drvdata(pdev); @@ -378,8 +378,6 @@ static int p50_gpio_remove(struct platform_device *pdev) platform_device_unregister(p50->leds_pdev); gpiod_remove_lookup_table(&p50_gpio_led_table); - - return 0; } static struct platform_driver p50_gpio_driver = { @@ -387,7 +385,7 @@ static struct platform_driver p50_gpio_driver = { .name = DRIVER_NAME, }, .probe = p50_gpio_probe, - .remove = p50_gpio_remove, + .remove_new = p50_gpio_remove, }; /* Board setup */ From patchwork Thu Mar 2 14:47:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63434 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273256wrd; Thu, 2 Mar 2023 06:50:59 -0800 (PST) X-Google-Smtp-Source: AK7set+xSaEprqkgTqMJPLkdMH5bodX5u9t1WhV5oqDHg5Qt4aJeMaiePF0GTOe93AWDkZyXYOiV X-Received: by 2002:a17:907:6f12:b0:8ae:f1cd:9551 with SMTP id sy18-20020a1709076f1200b008aef1cd9551mr11526836ejc.76.1677768659230; Thu, 02 Mar 2023 06:50:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768659; cv=none; d=google.com; s=arc-20160816; b=dF0Z9SUWr7u9DOH9jAWwCGZf7FxY6UeonODve56J9m7GJc1kSM1xgkWDCN62VKpiVS TS2pJtAz3suNV4iyezOQ+qwXQ50TiP0XJhDHgN+62jyjD3zH0BbO7JHKpDWaGHSJ9IeU GFywe82MPp2pQGsdLjdGgkBqppRCGeeyTo3mj2+rxqwIYU1gx5UNMeYCZtQBgmhXKlEh z63aSeSNyYkPbTzABZP692th1vnQSwH+nbiOuS41lLTIhyOmKMSXx0mM67aDlzjCA6+f m/NDilTuZSXVhc7peRI3Bo05bTi+/bct6ZsveJYXJjznUcfwW4bKpXlxwbf20JydVuEr cQCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=sHQ1B2Xa0HaPt7bKtCQzNbzgrJAoIdL4oJMpJuY0Czs=; b=OU2ZhuXZFzUwGVplVLJcA3pHo+4Lloo/bb95No+RLcxAL+wu/wgk3T2qGrBXRszgOW SuvQ7jThx8qivzWdi+T1YP0uMhUPVC/FVa3AUgJTps0VuiNot+GgvFBJBV7N+GMKysJK lCJ+lZ23qRYCPmLIfxpqBid+M4h8PK00qY/qlxGfKcLko5cWrI8tI85ZoVQxMYks38A8 tq3s7oPdayMuObCjmz3ErXdQmho6tE1u1aQ5+RQ63r/+D/FAYhV+g6p6EfYNCdlA2q9U SHPIaa95Y1ajjPViwi6QWGIGH2LSiEvecVXI9PpBKd+gP29VlPR141bSTQIZTE3Vwa11 rCjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b26-20020a1709064d5a00b008cec55af403si5808634ejv.832.2023.03.02.06.50.06; Thu, 02 Mar 2023 06:50:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229715AbjCBOsC (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230031AbjCBOru (ORCPT ); Thu, 2 Mar 2023 09:47:50 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A62F46081 for ; Thu, 2 Mar 2023 06:47:48 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDb-0003rU-85; Thu, 02 Mar 2023 15:47:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDa-001LrI-Jk; Thu, 02 Mar 2023 15:47:38 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDZ-001Zpm-R3; Thu, 02 Mar 2023 15:47:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Cezary Jackiewicz , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/29] platform/x86: compal-laptop: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:11 +0100 Message-Id: <20230302144732.1903781-9-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1864; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=2FcRCflJvaecUEGlqoFBbAQbmPoh+cHoMH2b86C4p0s=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALahfyGEbwyFIZ/2N0J3qj3ymTNB0KR+nuX8B LhaekOFqSKJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2oQAKCRDB/BR4rcrs CWw6B/0SqxTeIkpbjeLgeQn8QgLD1ZpxFqsb+bXQ27zzQLCQtd9LZfgQJooPS71cLRZBGxZRj7b oOg2tNB4Kz4YnTB4C2rO4QzPcGUbwTXJAep9yZUPvY+1DSbKRrbfM8VbjT1DctOXnr2T6NVHz24 /WXcZJSHCkeDyVR+6pF05Ya9VEE1MjGnqvhAf2fsef5HSnUoAPK/i5Od/NobCYHal2/lVx+V9Hx 5JXgoNCzyusPjbvAyD8/1whKljMWg6DPkpT/eAvJnltCvBr1bVa/IrkAStsJD/RNmmu/glYLaJP zyYZUFpVOARSzTCTYPDtr+5dnutCmfmaQIFNdtsDMt97C8BJ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267949491549524?= X-GMAIL-MSGID: =?utf-8?q?1759267949491549524?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/compal-laptop.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/compal-laptop.c b/drivers/platform/x86/compal-laptop.c index e10d2f64dfad..61c745490d71 100644 --- a/drivers/platform/x86/compal-laptop.c +++ b/drivers/platform/x86/compal-laptop.c @@ -1003,12 +1003,12 @@ static int compal_probe(struct platform_device *pdev) return err; } -static int compal_remove(struct platform_device *pdev) +static void compal_remove(struct platform_device *pdev) { struct compal_data *data; if (!extra_features) - return 0; + return; pr_info("Unloading: resetting fan control to motherboard\n"); pwm_disable_control(); @@ -1017,8 +1017,6 @@ static int compal_remove(struct platform_device *pdev) power_supply_unregister(data->psy); sysfs_remove_group(&pdev->dev.kobj, &compal_platform_attr_group); - - return 0; } static struct platform_driver compal_driver = { @@ -1026,7 +1024,7 @@ static struct platform_driver compal_driver = { .name = DRIVER_NAME, }, .probe = compal_probe, - .remove = compal_remove, + .remove_new = compal_remove, }; static int __init compal_init(void) From patchwork Thu Mar 2 14:47:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63439 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273464wrd; Thu, 2 Mar 2023 06:51:18 -0800 (PST) X-Google-Smtp-Source: AK7set8IRZ5lZATYd4ebZK++BS1t4HyHClfwraFglD3aSRt/Mz6/Hc8XTLFp70a4i8jESv9uGJpm X-Received: by 2002:a62:3281:0:b0:5a8:b419:9a51 with SMTP id y123-20020a623281000000b005a8b4199a51mr8655643pfy.26.1677768678628; Thu, 02 Mar 2023 06:51:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768678; cv=none; d=google.com; s=arc-20160816; b=d8Qk4gFOBe7VVCUUVFf+KIlRoUTIJe2T9KYywSgS/4dLFf0bvkznnR+O5xAHz94EQV q39VwdlEHvcIAyDSwt7u10AGIfFKn8oe0gawOirFJnEVg86zxnQwSketa1ZOdjUAmD5H /6mnDvPEX+E2Dyr7cj5Cbxrc9n6DltXoIAHpqcF8P9m0/275jOaQP0Ou6Ta8hQo6mD5h O3SdQR0U7bbSjOi/jSJGFhm98n5vyx1RXWNL0oI5vND7G79PVC4KP4tdKutzbKhPV4iM keU/ubADngAHqa03oCVB15wkd9gh2y5eMjc3623rpCwfRPGlddUS3TzScl/+D9sZYz09 ZoCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=au3i0fTw6stwW9A8SxUQgQ2FLW0z8xninP1QnomJDto=; b=oSbFSmTfWwI+Wm+z51qR7MaR80sGPF7hIyc8y8RV7xMFsdbMJOanoHYWJugjkRAlVo oGDINLckoYrsCsVc1YakLEnLXZJ5FAI4HoRRTQRTI+KK6coBj8UaQRDKUi+Ab/H3PVHL hIiaoz5eN0umax5QadXvqNoIxkO1fpmWa1+ipQvgHcYgfOTIrKxrvV4JiTItfmsa2mvP P1ZKfZ9lGUvtzyVVNb3dXklVweKbpYk9PcTZzaIsNcoWwdvyUccZwdk+/CrxQKNuoLok T6rkAPbsBBzhqrFRibRMx3nqOKPzHC93ICmiU2K3FUNaEsPiEAbWG3KVlVXgR7hTi94Y Rw6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z11-20020aa7888b000000b005a911448f76si16311122pfe.43.2023.03.02.06.49.51; Thu, 02 Mar 2023 06:51:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbjCBOr4 (ORCPT + 99 others); Thu, 2 Mar 2023 09:47:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230019AbjCBOru (ORCPT ); Thu, 2 Mar 2023 09:47:50 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0738243937 for ; Thu, 2 Mar 2023 06:47:48 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDb-0003sE-TX; Thu, 02 Mar 2023 15:47:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDb-001LrT-6Z; Thu, 02 Mar 2023 15:47:39 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDa-001Zpp-D6; Thu, 02 Mar 2023 15:47:38 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stuart Hayes , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/29] platform/x86: dell: dcdbas: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:12 +0100 Message-Id: <20230302144732.1903781-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1626; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=zWMnGRQm3Ty/zUvYwolgkenvaIlIv2W9jAYb7LshPlE=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALal8iQzvOAk8kcRYck9HCN5PPyQOMhn4YqQ1 zNd2tx5CJSJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2pQAKCRDB/BR4rcrs CeOaCACCKUaaSpf8mPOFmwqSBnGsfK1pAU9t+R+XcdOeiK7oH7DLlQjM4lsfX9IDAVUpyg86Esf bgF1ndsG5SnGTJLNwxHwgozXPEj/r+fLMtml0IHpd6sQdCGnT9emqgKsYnWCO2oDb0cjs/GwZum C7hKUxmiWtjiTKtGUdurGVHS0YoKrdmVGWIRwfHzzzMfyCkg70M+6fk0bgK4jwpKVukAQJcRAYt hETFxolMfdkaoZ8O1yQhS5iXKL714j3Jx0L1xoA/AMShWEEl4ouKYJB249jbKkhCDp0ZFQ9TQud TcD/9LNcoHt8pPWct25/+HWmVNnad/al2gHPIuRTk/1f5Q1i X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267970063892272?= X-GMAIL-MSGID: =?utf-8?q?1759267970063892272?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/dell/dcdbas.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/dell/dcdbas.c b/drivers/platform/x86/dell/dcdbas.c index 0ecb7b164750..76787369d7fa 100644 --- a/drivers/platform/x86/dell/dcdbas.c +++ b/drivers/platform/x86/dell/dcdbas.c @@ -698,12 +698,10 @@ static int dcdbas_probe(struct platform_device *dev) return 0; } -static int dcdbas_remove(struct platform_device *dev) +static void dcdbas_remove(struct platform_device *dev) { unregister_reboot_notifier(&dcdbas_reboot_nb); sysfs_remove_group(&dev->dev.kobj, &dcdbas_attr_group); - - return 0; } static struct platform_driver dcdbas_driver = { @@ -711,7 +709,7 @@ static struct platform_driver dcdbas_driver = { .name = DRIVER_NAME, }, .probe = dcdbas_probe, - .remove = dcdbas_remove, + .remove_new = dcdbas_remove, }; static const struct platform_device_info dcdbas_dev_info __initconst = { From patchwork Thu Mar 2 14:47:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63444 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273703wrd; Thu, 2 Mar 2023 06:51:47 -0800 (PST) X-Google-Smtp-Source: AK7set8OUAXPfeyJAH4lRQ7DWfiFj52ZTmQsY6a9RW1ksx6GuS+G5Qnh8wRJhWHctDd8yOWhFJUw X-Received: by 2002:a05:6a20:258c:b0:cc:8a62:d0da with SMTP id k12-20020a056a20258c00b000cc8a62d0damr9959573pzd.12.1677768706892; Thu, 02 Mar 2023 06:51:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768706; cv=none; d=google.com; s=arc-20160816; b=bCGojmu0NwtIkqjusJd0sAH+FzxCLQkqLQV1cDi6S15ugIpnViS+OqeloNUhmYk78R whpdXwJta4gQj+V49eWYj2Xp6POnrSCBOsYuOQ3A/7uZqGFbaiYrmsZgATxKXqBsLTPB +0bl5vYVkV8XzkfaSwn8X97YiDwGXjXGpU8733EnwIHFz3pmjYobe7uAvYuJ84A6dSSw yZg5Mj4i2zps2B+XldS05fr4EvU8g0pX0ClBrsz/2+OTBAUI6xXhEkMF8fu57UWDsk5K Paaqj5HarjEe/myDkMwIPANoWtTApRHYcxCrVAZYnrIgHVmHN4E7CUTAsvWTdvygY7tR usag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=t0TZr4Dj7XsCbqyty/g4J9HGeYnxovspAdlQci8mvFo=; b=McBGpWLYGNPsEapF/KyfwhBazc2wNITkczQUxUhFtd5sHhMSYP67PERWl7iUQSdmBg HPoK6e0NQ061cXHQOTVuyOSL+TCLEgNnYIgcerljarKL2/gVCVWXNqQbSLx/tZDhe59r 5yY+ebwoC+DlBaM28TDZIW9y0zE6heuSD7CVkIIPUyWHb5kbiH/sG3gSUSkH+31brEej IdEPSleHG+JD0f/bfGQQE3L7eYe0NQMbL7BsHFt6GpGHu5VMrgBLsafnU6MgoTxUTNMI 90ASw/E9tTsBeI5Zcj+eOFYGy8UuSe2dnb0snaVw85CCi52Ky6nRbEFFpvsmoJXfxDcF eO1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f1-20020a056a00228100b005a8b3c6b5besi16497640pfe.254.2023.03.02.06.51.33; Thu, 02 Mar 2023 06:51:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230234AbjCBOs0 (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230083AbjCBOrw (ORCPT ); Thu, 2 Mar 2023 09:47:52 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0840D498AA for ; Thu, 2 Mar 2023 06:47:50 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDc-0003tr-Fw; Thu, 02 Mar 2023 15:47:40 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDb-001Lrf-Nx; Thu, 02 Mar 2023 15:47:39 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDa-001Zpv-L9; Thu, 02 Mar 2023 15:47:38 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: =?utf-8?q?Pali_Roh=C3=A1r?= , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/29] platform/x86: dell: dell-smo8800: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:13 +0100 Message-Id: <20230302144732.1903781-11-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1798; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=txLMuYR/cP10MBXXBYhoJncjcMTcRGlLrq4hOidzyFc=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALaprgeMkYzTuEyEiQoLcRYpGVSKWkuk6C5Zf EGmg4PzaBCJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2qQAKCRDB/BR4rcrs CbF9B/93h3vJrbwyrN/LyZ4EIyOBZgUqoIvTcY/7dRJS/z0eobnQEmWjBppGl+0P79+VwpzyEJp 87p+mebKkXCLMzSkyIAV6Ln+S1qed/rgakfeeQO09SmO8dheo6JCuk4AKU756i57U9y/ZnobUzv r0pbEBUtblV+gasl70k/DwvYdO6EdeWuR9NA25j4eEj/i0u5W6NpBtWoUQdJo6jK0h/dXFOs9CL x6Ibi9x7nYifDtNDqdVuZqSSdtAmfRyGVW5Xd/qj1jwQKjbnVOR4ky165J79MpQWFcq123kTwqR 3kABcySlvdIz1LoK/UyC+AR6BquPZjKun+dREdYxPWCiElC9 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267999525211098?= X-GMAIL-MSGID: =?utf-8?q?1759267999525211098?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Pali Rohár --- drivers/platform/x86/dell/dell-smo8800.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/dell/dell-smo8800.c b/drivers/platform/x86/dell/dell-smo8800.c index 8d6b7a83cf24..f7ec17c56833 100644 --- a/drivers/platform/x86/dell/dell-smo8800.c +++ b/drivers/platform/x86/dell/dell-smo8800.c @@ -154,14 +154,13 @@ static int smo8800_probe(struct platform_device *device) return err; } -static int smo8800_remove(struct platform_device *device) +static void smo8800_remove(struct platform_device *device) { struct smo8800_device *smo8800 = platform_get_drvdata(device); free_irq(smo8800->irq, smo8800); misc_deregister(&smo8800->miscdev); dev_dbg(&device->dev, "device /dev/freefall unregistered\n"); - return 0; } /* NOTE: Keep this list in sync with drivers/i2c/busses/i2c-i801.c */ @@ -180,7 +179,7 @@ MODULE_DEVICE_TABLE(acpi, smo8800_ids); static struct platform_driver smo8800_driver = { .probe = smo8800_probe, - .remove = smo8800_remove, + .remove_new = smo8800_remove, .driver = { .name = DRIVER_NAME, .acpi_match_table = smo8800_ids, From patchwork Thu Mar 2 14:47:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63445 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273745wrd; Thu, 2 Mar 2023 06:51:53 -0800 (PST) X-Google-Smtp-Source: AK7set9PBJSN7+wGMiXhOO/Zg8BGDbQqQLuY6xK6OJJSDxTNd9lMz5Sbam9I3bmpUjpthZo8bsi5 X-Received: by 2002:a17:907:c68a:b0:900:a150:cea4 with SMTP id ue10-20020a170907c68a00b00900a150cea4mr11379614ejc.37.1677768713702; Thu, 02 Mar 2023 06:51:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768713; cv=none; d=google.com; s=arc-20160816; b=ekIzmtTMIAcbq2ibEIxPdfG8rNBvXiP9FCu1ebWTe4M3EKcDdfmGmvbHBPU6/jpjN+ 7RDwoFqEW18LLUojP5/niCqr19Bnhmk/XDrjVNaj71P8gtxYgNqH9zeI/Ce6ekxLxhFI hW1R7pjV4V8d11EIKXIxlShxJRbSXz6uVRIYpzgkCHzbw3+WRrkpkmtP3Hx3N7xJnoQa vYRa78YWzWRhjlHwkR57uc5rPAbaBeX1miprrVGUUlAWEnBoFTt1TjL3OoWWSVWIihYd 5zf5cGXCfEhOE9KQAV0fxGsWIzyjF/2csRfANBsnBHyJsCeDe70tRQ7iIezgVj2FH8sm OTAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8YZPnn3FISiOTXP9TxVqehds/g3vZa0Q90GRVNuzZmY=; b=OC+n5pzLU9jYl5u3Hd1tF8CSqGUAUyV+koQFnKgpKGJpLVJDDAazNkQm21phQRcGel kpQJV4L45j85Zhff/XOJHu31FsvxhNkzkT7XLY4zoaMu7xmIAd3Ynz+oenEyNxqkx1+S vhc2kZ+rpGvuSmu/kzLv+HYebgvVn4ZC9L5jgKw75kCzM03MYDaW21nifpibgEgLiIom YluCoPsdw0wwhoeN2UtK9C+vmASc61vGFWxbVKDCEo84XJgQO04/oTm3ZIy56RxCMxqf QapCauFdwOyE2ONtwSVlbiABume8HsDbwny1ZSfqKg/B3xyn2kDKT+yVt7N900Zu1KG1 g5iQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gv29-20020a1709072bdd00b008ddf3c18314si724819ejc.372.2023.03.02.06.51.30; Thu, 02 Mar 2023 06:51:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230202AbjCBOtC (ORCPT + 99 others); Thu, 2 Mar 2023 09:49:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230121AbjCBOrz (ORCPT ); Thu, 2 Mar 2023 09:47:55 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF81C40FC for ; Thu, 2 Mar 2023 06:47:53 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDd-0003tO-Hb; Thu, 02 Mar 2023 15:47:41 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDb-001LrZ-Gp; Thu, 02 Mar 2023 15:47:39 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDa-001Zq0-Rm; Thu, 02 Mar 2023 15:47:38 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Eric Piel , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/29] platform/x86: hp: hp_accel: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:14 +0100 Message-Id: <20230302144732.1903781-12-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1866; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=X9kQ4rbY4lv4/tckzYkf30KKQ7sZ/1lbGj8mnGbM7BA=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALatDr6PLBGpno5AQOIzDvVee/jz9769sMvCp 96IWli4YEeJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2rQAKCRDB/BR4rcrs CWAzB/9Tpizdmk32o5fGzhOLxHYbu8RR4wu8CswSQQC6tgaHZpJlXSNaJjOa6x7n4njopchTN8k IZ81sbLnXgTRKCQwzfiinGLyZiiHSuS9hpOokK+0NK55bLZ6qZRBZgFlnsuk5B3oH8WRSgiySnn 9sPzFOWlSnZWrATXrEU+cbeNcl0NByUB/jEngUtbftSY4ylOkWHLW7bnCFiXTt7VoIy77mcBed2 W7/p/2JDmk2X1DEkLfE1xho9s/ge7HHZ8geG7EM23GKChy20CxCJrqsC0ZHk6xAKz9MHKpTXMKe wGBPPIHbvFK2RilOacd1CZeuZ5kHSobmxBYqMwPpj3K1ItlI X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268006464138538?= X-GMAIL-MSGID: =?utf-8?q?1759268006464138538?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/hp/hp_accel.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/hp/hp_accel.c b/drivers/platform/x86/hp/hp_accel.c index 6477591747cf..52535576772a 100644 --- a/drivers/platform/x86/hp/hp_accel.c +++ b/drivers/platform/x86/hp/hp_accel.c @@ -342,7 +342,7 @@ static int lis3lv02d_probe(struct platform_device *device) return ret; } -static int lis3lv02d_remove(struct platform_device *device) +static void lis3lv02d_remove(struct platform_device *device) { i8042_remove_filter(hp_accel_i8042_filter); lis3lv02d_joystick_disable(&lis3_dev); @@ -352,7 +352,6 @@ static int lis3lv02d_remove(struct platform_device *device) flush_work(&hpled_led.work); lis3lv02d_remove_fs(&lis3_dev); - return 0; } static int __maybe_unused lis3lv02d_suspend(struct device *dev) @@ -373,7 +372,7 @@ static SIMPLE_DEV_PM_OPS(hp_accel_pm, lis3lv02d_suspend, lis3lv02d_resume); /* For the HP MDPS aka 3D Driveguard */ static struct platform_driver lis3lv02d_driver = { .probe = lis3lv02d_probe, - .remove = lis3lv02d_remove, + .remove_new = lis3lv02d_remove, .driver = { .name = "hp_accel", .pm = &hp_accel_pm, From patchwork Thu Mar 2 14:47:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63461 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4274587wrd; Thu, 2 Mar 2023 06:53:52 -0800 (PST) X-Google-Smtp-Source: AK7set9umUyn+QiU1t3z78DnVSRBXd7GGnA9JCdfv5dPl3I0TmE/rl5S/ZYtB+h3rKDsqvYnR2+y X-Received: by 2002:a05:6a20:244f:b0:cc:b8b4:d774 with SMTP id t15-20020a056a20244f00b000ccb8b4d774mr13115013pzc.7.1677768832016; Thu, 02 Mar 2023 06:53:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768831; cv=none; d=google.com; s=arc-20160816; b=CclKIm0YE5X8F3cyMqBheTpofjLdGOLJyXpfqCTi6hUM9JYaRHYSxJsBWPzV0cWQr5 RokwOrF6STfqvRSE9hXr8WUiiGGo0ap5vEYIFECmYd+V/rIqGFn99Q+FuNtXghiy4r07 JLx/eKUdHfXBj5Th/tvPwmtkD7v6u3YJks4TUh7G1C2am+LYMjJjpPIxeq0ZM1nF8ty+ Dm2UtibtB7yFW0uxpzA7/hR0p76hgI/pxiJzZlCXtKzudElvp9pigArhpjSpSXzMc8/l aMnxyh8F52hNSZ4fG2mW04QRlIXyraoxk6bLwfRpUlSgjp1KciobuChXo8y0ADuKJ2t0 OwCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=7Z0BIMOgJx9EMbiTX7m0O8m1V8b6SuaSzEsv+TQDL48=; b=Q5zhH1NYVrbB1NUMQCEaAqru4AJbkySZ+iWnJ3VXQDfwhqWgHQjBkTWWTuwBg9ueVF P+ky4AdA60tKc96Zub5vjE9toyUmVYH9zfg17X4bN5wE3nfNRnMrPNb1Gbd049kdnQ53 qtcooqkwdDzvWF76/NGu87zeo1BjqBIoJhlNaZKrWBaywJHQZ8mhJ9ZiDKlEtxEKJFiq OWp2RbnkUWhGVal1is0QUzjYwXVqBBRxTrp11Q8DgE+tq8gw7e9c8pXcnmbZ3sshJNyX ntkMakteBgtrtoJPR085HKWNE/kBPCip6nR0XKirVfMWVMUZ3anxClKmxsK7tUKYVg5c r+qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 74-20020a63064d000000b004fb435b44ddsi15206771pgg.704.2023.03.02.06.53.36; Thu, 02 Mar 2023 06:53:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230312AbjCBOtI (ORCPT + 99 others); Thu, 2 Mar 2023 09:49:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230131AbjCBOr5 (ORCPT ); Thu, 2 Mar 2023 09:47:57 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E13B240FD for ; Thu, 2 Mar 2023 06:47:53 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDc-0003tn-QU; Thu, 02 Mar 2023 15:47:40 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDb-001Lrd-M2; Thu, 02 Mar 2023 15:47:39 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDb-001Zq3-2M; Thu, 02 Mar 2023 15:47:39 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Jorge Lopez Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/29] platform/x86: hp: tc1100-wmi: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:15 +0100 Message-Id: <20230302144732.1903781-13-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1513; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=zAr8lrhzgrTr9284cFGceOvdHiakIwoRNxJOhICKzFI=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALa1jWUOkUSHXnHDU/cF6fh7JSAiKc1ZsJ7uT hFyAxBITMOJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2tQAKCRDB/BR4rcrs Cf6ZCACOlBDPhtsPlbGQn4gmkWFsrmLzqnsN/L+mHDy3NMBRUTpfGepTn2GCSrNSDb1iIN4rC6/ oSHV9ZYUzvpfso4zN1he+to2/M3sI5vm7v2zO/p2BA+f1NfGGE2B2/b8FRskD118uICOCxkNolJ ZkNwv0ErPA0pBruPPVVo/tafq+gloZvYMZEfbjWhm9KqtmNW8ucFa9KgqnkA1UvqHNe917F4g6y kbtp1xwRTeR5e1DuBMXRROH0E0OPrKl9eiPz52Ui4vGvt+TT9KvGU3PODKl1Fng3P0v6QYr7j47 ctHRYBXm3tFEIa33nePri3wndsbHbJnBYF9OG9C8672AwxN1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268130382557001?= X-GMAIL-MSGID: =?utf-8?q?1759268130382557001?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/hp/tc1100-wmi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/hp/tc1100-wmi.c b/drivers/platform/x86/hp/tc1100-wmi.c index ded26213c420..5298b0f6804f 100644 --- a/drivers/platform/x86/hp/tc1100-wmi.c +++ b/drivers/platform/x86/hp/tc1100-wmi.c @@ -170,11 +170,9 @@ static int __init tc1100_probe(struct platform_device *device) } -static int tc1100_remove(struct platform_device *device) +static void tc1100_remove(struct platform_device *device) { sysfs_remove_group(&device->dev.kobj, &tc1100_attribute_group); - - return 0; } #ifdef CONFIG_PM @@ -223,7 +221,7 @@ static struct platform_driver tc1100_driver = { .pm = &tc1100_pm_ops, #endif }, - .remove = tc1100_remove, + .remove_new = tc1100_remove, }; static int __init tc1100_init(void) From patchwork Thu Mar 2 14:47:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63441 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273484wrd; Thu, 2 Mar 2023 06:51:20 -0800 (PST) X-Google-Smtp-Source: AK7set+4Q7Z4UoLJdvs6YTvE9mh73oGpkILzcnDRhB7/tFSa+IRosqEGps2PJUgrDHvw4JM7NOa/ X-Received: by 2002:a17:906:1b14:b0:879:6abe:915e with SMTP id o20-20020a1709061b1400b008796abe915emr11088077ejg.69.1677768680569; Thu, 02 Mar 2023 06:51:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768680; cv=none; d=google.com; s=arc-20160816; b=pmn3GwIPdbWlUCiIFnu4ESZaCVQR/2NLX+HNaP+rFvJjAXpq5xRNUnrU16JTZcOP69 nZvfcmQ3+lIhx6qQhlqrjeaqO8GfORrJEVBY/8ayBREeJ/D7hDLhKa/aykQfqN/VxOfu 4yrxfGSRJ1q8FLAtYT2DYE9U0jXB8PjnaQck7ciEK5Ew06OGQQ110sSA0PpLimEcx4JZ E7RxgwtVOdGZMOKBTnYbOHbsekPYCe/QcJ/E+tslPYjCYmjOOWo/cYgaPVNthIAwcwfG NLw0W2rYJZjsTZm0Z2SioapTgSfWH2CFsIJR9Zwa/923qnsUY1EOtYtcOMY96U7N7OrP 8AZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/tvv9Gr1V3CKyJZJS/47ytyGYj8mv0lfOq+miOjISH0=; b=z1UmzE8YOAHOg8riPbX62d/iw/TBU7duhCqoEkoBh9BKs7xyRAblJq3miAa9j8hTFv GAhoAB2YC56FOSk4DWOKsc5vnVIvi179Mlg9hVera56zG3xQu+3R6KHF/wIfwbarOSLh k37AkHT91QkkUY6omxBnf+whnoAY723qffAi3T6QCD0Bf1nstdEYB+vraZ20fhlWq4sy xdz+xy/V0agQPaUNJPK87DjXdonUduVetHwYuouUoifnpBwsjaNbOz3+5YYMR07jeyRA WzkZwuetbLxFalqYn6CQb0FrXCJ8Ivn6n3tHUvovi3CBAJTqBsOuTAyT1nYI4vn2gIRB KlBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t10-20020a1709064f0a00b008b175a492e7si770491eju.584.2023.03.02.06.50.58; Thu, 02 Mar 2023 06:51:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230151AbjCBOsT (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbjCBOrw (ORCPT ); Thu, 2 Mar 2023 09:47:52 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 818463C7B3 for ; Thu, 2 Mar 2023 06:47:49 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDc-0003uM-L8; Thu, 02 Mar 2023 15:47:40 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDb-001Lrl-WB; Thu, 02 Mar 2023 15:47:40 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDb-001Zq7-9v; Thu, 02 Mar 2023 15:47:39 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 13/29] platform/x86: huawei-wmi: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:16 +0100 Message-Id: <20230302144732.1903781-14-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1747; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=JW33fHxe/kBQW6ZFF7MD4WNhh5dcbkzNNcJmCnfisT4=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALa62P3XEguYN3LFWtRFAPXnn3mTTVM9Ih3OS W2S3s+MZOyJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2ugAKCRDB/BR4rcrs CUG0B/4+91kpU48HWypHlPmj2zLHU604Su/U8sc8tUAY3raE7VC/7zqriN00C9aqji+N3U4ds3d tdMsDO66a4eH+FJv4CKAVTaCCj2zHxoRNWuvw7pvzvsv+T3mg8Xiynjjr/sCvi/599yrdnNvxHA uwNBRlDShBVe7elB5ZP6F0zawQ8b3b6P1tcNoDtRDVMOxqdJwUMpjCHrIqsv8u8zUWB+cgm7Stc lT2Uzb0MQ/gkiPyBEmsf6Q8aGgH1lJ0hmrGQFk3dJ6UoIAESrJRC5rPPEOj4LXRAKau73f2HY3b ByESQh3fWqY1niisUV8udhiTQ6sC64wYvei5t28EjzLC701+ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267972384542274?= X-GMAIL-MSGID: =?utf-8?q?1759267972384542274?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/huawei-wmi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c index 2df1b2d5e3ea..70e5c4c0574d 100644 --- a/drivers/platform/x86/huawei-wmi.c +++ b/drivers/platform/x86/huawei-wmi.c @@ -830,7 +830,7 @@ static int huawei_wmi_probe(struct platform_device *pdev) return 0; } -static int huawei_wmi_remove(struct platform_device *pdev) +static void huawei_wmi_remove(struct platform_device *pdev) { const struct wmi_device_id *guid = huawei_wmi_events_id_table; @@ -846,8 +846,6 @@ static int huawei_wmi_remove(struct platform_device *pdev) huawei_wmi_battery_exit(&pdev->dev); huawei_wmi_fn_lock_exit(&pdev->dev); } - - return 0; } static struct platform_driver huawei_wmi_driver = { @@ -855,7 +853,7 @@ static struct platform_driver huawei_wmi_driver = { .name = "huawei-wmi", }, .probe = huawei_wmi_probe, - .remove = huawei_wmi_remove, + .remove_new = huawei_wmi_remove, }; static __init int huawei_wmi_init(void) From patchwork Thu Mar 2 14:47:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63454 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4274196wrd; Thu, 2 Mar 2023 06:52:58 -0800 (PST) X-Google-Smtp-Source: AK7set9JDlxwg1ljsZ3A5p4IPRB22F8zJuVWytCzB2NTaVBrm7icjKid9keIpGI42hnop9n4KRdJ X-Received: by 2002:a17:902:e541:b0:19c:b4e3:c65b with SMTP id n1-20020a170902e54100b0019cb4e3c65bmr13743063plf.8.1677768778347; Thu, 02 Mar 2023 06:52:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768778; cv=none; d=google.com; s=arc-20160816; b=y9kIOX14LdUbeMEyskcNExyIhEKPKyUMwHve8AQf/wuvyApz+sxggea8w+chBiTJGe 4cbw6v8SbN8nIj3cdxfrR2wm1Bqt++iVuZJ+eJzYnL/qOs3Fuu1zRPLi7G1H1D7ne4RG I3LSZ99HooolA3u/kIQZjd8Jj8QzHtEs32aRGvRddOKyjyj+XWiG3SfN+2M60MBxxbDn X+k8k9efo4ChPn7x3rTRM3AXYQS0su9BS6jX0YMEKFxsG+bEHLKuPbJsbGq4ufeLnRAK AvrY5HunQrH4JB9HMIQosp6nzU3x050TPqXiSZtMpswNtWZzt+NpZJHZQ7W+aVc5cssX 3KOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=CG7UA0O75wiGePLwH2n39njJ9sCDKH1xEm6qVulYbSU=; b=yqplEBW8nhtVKuXEyuZa1SxaRiLkDau0x7TwQtzF4fMhAapT0Zrw357i1q++HoDQzE Z4kJ1Ix4CSrwdxV7It+LW4IuHu1vg9WHrjNYXhSpvMnv4S/s8tRA7xCapFf35MdeBaLp SKSu0gwuOf7VmqCcVjcLB/dkLhVMYT/03S1hkYT0NdQiG38bQTlmQ6Vuew6+/Z6u8xZg e9hU57YWgeJVSXoHg4ulcitfqYpyqTDh93rufuHITWS/7dANPaIIk0iGCquC7H6T3AhE HefMnoqjnYbsw9x4KA4CXCsZ3hzLRMnd71q9SRpfXNM8VH5mllQX35kXZxQB2CRl8l6o E4HA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j64-20020a638b43000000b004fbd23110d5si16079309pge.546.2023.03.02.06.52.44; Thu, 02 Mar 2023 06:52:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230148AbjCBOsH (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230029AbjCBOru (ORCPT ); Thu, 2 Mar 2023 09:47:50 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79AA946080 for ; Thu, 2 Mar 2023 06:47:48 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDd-0003uq-5f; Thu, 02 Mar 2023 15:47:41 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDc-001Lrr-AU; Thu, 02 Mar 2023 15:47:40 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDb-001ZqA-GP; Thu, 02 Mar 2023 15:47:39 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Ike Panhc , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 14/29] platform/x86: ideapad-laptop: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:17 +0100 Message-Id: <20230302144732.1903781-15-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1806; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=pDk7jwubfCsGp7anhhTuGzgHcgasJat6lH0VGQp+ErA=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALa+07KJdRSyk7nfg3tmGNvagCT7Zx6blt9rM yrKEDFTZruJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2vgAKCRDB/BR4rcrs CcFRCACclEPioKPU5ApA2tnEvuiryygWnK4+p6CHzE9W0Rov296G9pkCAcSYHNEKnNJAq33u0cH jMwJr6GJGSl3WNksR7vwutRP4E6TiCDBaTNVIMrrAMaudkVd8hHzjhWCKfYUOz2w8p7AGRy1wMR +fL1++K0uV+wNHu7eyvz/czEwiCgeBcMLACR2D1JkuzF24iKEJst9a0+E7icT6O639hZO/YBIM6 qWcHbDhvF5QXoHEnHODu6s4ohwIGomD8HxxDW+pDFTN6hHr48MRlSX93dvqU7w5egCnYMh1fWR2 WZpQmBzZxeBNnyhuNELTqGvCjmUgcT2gOSsPfaMn5CxjnSWo X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268074614390605?= X-GMAIL-MSGID: =?utf-8?q?1759268074614390605?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/ideapad-laptop.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index 0eb5bfdd823a..b5ef3452da1f 100644 --- a/drivers/platform/x86/ideapad-laptop.c +++ b/drivers/platform/x86/ideapad-laptop.c @@ -1921,7 +1921,7 @@ static int ideapad_acpi_add(struct platform_device *pdev) return err; } -static int ideapad_acpi_remove(struct platform_device *pdev) +static void ideapad_acpi_remove(struct platform_device *pdev) { struct ideapad_private *priv = dev_get_drvdata(&pdev->dev); int i; @@ -1942,8 +1942,6 @@ static int ideapad_acpi_remove(struct platform_device *pdev) ideapad_input_exit(priv); ideapad_debugfs_exit(priv); ideapad_sysfs_exit(priv); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -1970,7 +1968,7 @@ MODULE_DEVICE_TABLE(acpi, ideapad_device_ids); static struct platform_driver ideapad_acpi_driver = { .probe = ideapad_acpi_add, - .remove = ideapad_acpi_remove, + .remove_new = ideapad_acpi_remove, .driver = { .name = "ideapad_acpi", .pm = &ideapad_pm, From patchwork Thu Mar 2 14:47:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63451 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273979wrd; Thu, 2 Mar 2023 06:52:26 -0800 (PST) X-Google-Smtp-Source: AK7set9G9+gjIyHZtLNOIdE4Hew69DVdYAGtzQWB27rP2EsIhLoucrS3SVNlkQFJwuLRwiXTOc/u X-Received: by 2002:a05:6a20:6a0d:b0:c7:1bac:6ef9 with SMTP id p13-20020a056a206a0d00b000c71bac6ef9mr13246369pzk.46.1677768746137; Thu, 02 Mar 2023 06:52:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768746; cv=none; d=google.com; s=arc-20160816; b=giT46VJrfKFLWqN8AVlAYTXcNhXCQWibfJPjxZF4AL5eG0eJRE1MKfN78KTtNw1FM/ udUmzCe4R6yL7B3C10+fhw6im9Jy8Au5VZl+8cwBDa2Ot2AUeZkA4vlBUfiG3C24YBa2 jt4IsR1NHMh48pbPKTNrFXQJ+ESL7qo/fPKm8INU+Bk70Gja5Svl31ZBBJqB3TqiOlej oCrALJqxNM+oPju8vi3I+HOU3LCmQ+n7BAhZXyPFIPiogEXe7+zsU4GR7VOim+0pee5Y otRIHp75ugbMZSW1ZeIVoOa3fXb5wJ+bR9g8HdQfG2OhDfyWUpuIUDEvFkKxGkqfb0iK BYiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=MwYD9XOuCZN88J7Zsa6/UCImLnHbdF73T2Lkgcr1vH0=; b=A9zKLL8a98KFDwwLMD6eYWGX79+ncVriLUNJBiEALd8c6eqOLCB437xY/M8v4nF7q/ aEHLdrxSRVTKEKb3XKJJqiq347Pbuhglj/0EQaA/D9KZmRDJ+i6ULBpI0N0hp5WLsqJ7 NAM3nTgUAyfbKuBGsgdvAe5eGzP4SnGsCAkzR5YKO2H4SyEbQu1L31dcAbl3dZBEk59J 3RuJ9BnuTiexS84eRlf0v1ScwaQzZJZ9TC2V+sbol0mvPrsQMfiN7z2AfUjAlsAeH2Gk fOJShsyZDAigAHsP44n4Ukkj75T1OL0DZkVfKtfdpxOBYehPNfznUrlP7ovdwRfMVgWf NQwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r18-20020a63a552000000b00502f3d1a058si16121144pgu.479.2023.03.02.06.52.12; Thu, 02 Mar 2023 06:52:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229961AbjCBOsp (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229981AbjCBOrz (ORCPT ); Thu, 2 Mar 2023 09:47:55 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E29EE4C6E6 for ; Thu, 2 Mar 2023 06:47:50 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDd-0003wh-QD; Thu, 02 Mar 2023 15:47:41 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDd-001Ls7-5q; Thu, 02 Mar 2023 15:47:41 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDb-001ZqE-Or; Thu, 02 Mar 2023 15:47:39 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 15/29] platform/x86: intel: bxtwc_tmu: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:18 +0100 Message-Id: <20230302144732.1903781-16-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1877; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=6Gq36LIAmzl6zxp6vtsQ1GkeFu+buKYvyyDT0NmxZ90=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALbDzuqo/4A3YztsyXhANHGikIWuz8ooykUIG PFylWg87X+JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2wwAKCRDB/BR4rcrs CQm3B/kBtltAwWOWaz603Bb14l+iccKUyiGRQdRLfyCPKAEH77NxiN2PwwnfXlR0G+A7vhnsq9d DKJfYsdP9cXhHPHXXZQP6dS4aWHk/ygX6bG4VJC/64jKLR5l2HdhjV+Hs515kVeD8IzWKDqrx+P ndUdIBSc/dKC7LpjXofqSv7wN2Bpm8I9N3ZcBq4qDEeN38rJ0Wz26kKL97Vc6RdKLawl7kD74dq A28JQiu/6LTkysCuhW5u7qksbFnKw6jsFunb6wS+2EtkVHdGCBSUGAMT7l1L0purW2lcEsL0xC8 xiv5Jvs9u/vi5T3bpZfKp5cSPg8OeMrOVR9RawLDz6n2LN63 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268040995624812?= X-GMAIL-MSGID: =?utf-8?q?1759268040995624812?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/intel/bxtwc_tmu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel/bxtwc_tmu.c b/drivers/platform/x86/intel/bxtwc_tmu.c index 7ccf583649e6..d0e2a3c293b0 100644 --- a/drivers/platform/x86/intel/bxtwc_tmu.c +++ b/drivers/platform/x86/intel/bxtwc_tmu.c @@ -89,7 +89,7 @@ static int bxt_wcove_tmu_probe(struct platform_device *pdev) return 0; } -static int bxt_wcove_tmu_remove(struct platform_device *pdev) +static void bxt_wcove_tmu_remove(struct platform_device *pdev) { struct wcove_tmu *wctmu = platform_get_drvdata(pdev); unsigned int val; @@ -101,7 +101,6 @@ static int bxt_wcove_tmu_remove(struct platform_device *pdev) regmap_read(wctmu->regmap, BXTWC_MTMUIRQ_REG, &val); regmap_write(wctmu->regmap, BXTWC_MTMUIRQ_REG, val | BXTWC_TMU_ALRM_MASK); - return 0; } #ifdef CONFIG_PM_SLEEP @@ -132,7 +131,7 @@ MODULE_DEVICE_TABLE(platform, bxt_wcove_tmu_id_table); static struct platform_driver bxt_wcove_tmu_driver = { .probe = bxt_wcove_tmu_probe, - .remove = bxt_wcove_tmu_remove, + .remove_new = bxt_wcove_tmu_remove, .driver = { .name = "bxt_wcove_tmu", .pm = &bxtwc_tmu_pm_ops, From patchwork Thu Mar 2 14:47:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63438 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273434wrd; Thu, 2 Mar 2023 06:51:16 -0800 (PST) X-Google-Smtp-Source: AK7set9cEfBzwALA+LYm8nFLrTB/zwHrQUyWBfiRvugJJzh9brD+y7rfxyWWAQ/cGGMCBU+3UmJG X-Received: by 2002:a17:907:628c:b0:8b1:4051:6d2c with SMTP id nd12-20020a170907628c00b008b140516d2cmr13090555ejc.19.1677768676304; Thu, 02 Mar 2023 06:51:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768676; cv=none; d=google.com; s=arc-20160816; b=s3bNRThjUlSdzxmK4jWqIrfPGWE+4R5m48lABth+BpzyWeYbhp8FuROa8g/kQI/v/m pA9Eonjag3ZDkcXW8HdkHoBPf/w4Qu38hNMU1xa5sgoirrjkQI/aF4kyz0s0bagN6SQo Zd7F4S2ALYngiuAOgtnmBaCW7fPeqBz4iLObI8TPWC5g69LQwaWeAU8BmorwS33gCFPt cDAd+Mh1WUdu3QzOq/PeOjYgSyoC4gRfzb8H63L0H8fUvyGXwreHzKwMc3y+Q6YeTXAj 1T7BZ9ikAWGW8sQcEBdgH0w+S538CZTVNGhxbNbQtpdah2y7VQguVBK2jtfgV0Gins5s BaPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=EZm5ljX89IZemSbWAui/fsXCreNwduh7G+WZmvcV5+E=; b=Aeq9varHCQlQUmHbDn84G/J8Oaz9Tf2IzUgc3deOxRRLSgmKkPwaSnWW5USK5D0cR5 d67Z2UWbhWoDtusdLqycbUGemKVQyy55IogLv4hyWMuRBOUkX5f8VZDAtpgd5MNEYjiD oLRIA9soUamkmS2+gTcCKL2fkMSd0OyWf6nugbNSbT6Jgtm9X7kd8pIsbb5dOCYpm5sI fNBOa4CzAeWSMNNYzwIMHp5C2dTh0DecO57331sy3qIeoI731mn5ieco2eu0K9fbImNS x9YL2VVt8DDrjBQkuFbKsr5x/+Khm43zdnQXnO5SVVMSfGFln9sQj7mH9NKwBkZd+J/A GnnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sd35-20020a1709076e2300b009065c2e91ffsi4741637ejc.316.2023.03.02.06.50.51; Thu, 02 Mar 2023 06:51:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230185AbjCBOsO (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230070AbjCBOrw (ORCPT ); Thu, 2 Mar 2023 09:47:52 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F8F74615B for ; Thu, 2 Mar 2023 06:47:49 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDd-0003vc-BQ; Thu, 02 Mar 2023 15:47:41 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDc-001Lrx-MA; Thu, 02 Mar 2023 15:47:40 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDb-001ZqJ-Vx; Thu, 02 Mar 2023 15:47:40 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/29] platform/x86: intel: chtdc_ti_pwrbtn: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:19 +0100 Message-Id: <20230302144732.1903781-17-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1743; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=0FfJsPYwKB4jfuUCcPtgucO0ayHu8PD4oizQzml1AH0=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALbHYN1EOHZvD7l11dIMQJzyoun4YkwBQNCyA 2bvZ8S9P/OJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2xwAKCRDB/BR4rcrs CZF+B/9fI4K2aRPUXCIfLqsznjaTirvwYRUDQhGrKP1fIQPXc+cJ5y6M5+XQVyct0f8sXIIXyH8 Hp4cYQOK/nN2PjVWKDxAn94MI4NKgK2Z19dhQF4hEKFIWZO+yrr92fwNjJMVM+YABrjAWqqDkVM X4zLxJXZ+ZTFXXB+9V3jdRlzLvyMi4P3Htyy9XjhCSuZZ6ZfvkQ/4ww9374sMosD759Dar1K97u NyOO3vbhT0y6vJFVPsjpxr69h5oCscAKq4Yr4RCJWVcFKN3OZh3slLgspdeWsIHwClZ+iIx4G9Y D6wwQWrzAFy+J7+sDD2TOicVX1EVzKWL0TG1fTKXqlR/ECAQ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267967064935436?= X-GMAIL-MSGID: =?utf-8?q?1759267967064935436?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/intel/chtdc_ti_pwrbtn.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel/chtdc_ti_pwrbtn.c b/drivers/platform/x86/intel/chtdc_ti_pwrbtn.c index 9606a994af22..615f8d1a0c68 100644 --- a/drivers/platform/x86/intel/chtdc_ti_pwrbtn.c +++ b/drivers/platform/x86/intel/chtdc_ti_pwrbtn.c @@ -67,11 +67,10 @@ static int chtdc_ti_pwrbtn_probe(struct platform_device *pdev) return 0; } -static int chtdc_ti_pwrbtn_remove(struct platform_device *pdev) +static void chtdc_ti_pwrbtn_remove(struct platform_device *pdev) { dev_pm_clear_wake_irq(&pdev->dev); device_init_wakeup(&pdev->dev, false); - return 0; } static const struct platform_device_id chtdc_ti_pwrbtn_id_table[] = { @@ -85,7 +84,7 @@ static struct platform_driver chtdc_ti_pwrbtn_driver = { .name = KBUILD_MODNAME, }, .probe = chtdc_ti_pwrbtn_probe, - .remove = chtdc_ti_pwrbtn_remove, + .remove_new = chtdc_ti_pwrbtn_remove, .id_table = chtdc_ti_pwrbtn_id_table, }; module_platform_driver(chtdc_ti_pwrbtn_driver); From patchwork Thu Mar 2 14:47:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63455 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4274327wrd; Thu, 2 Mar 2023 06:53:16 -0800 (PST) X-Google-Smtp-Source: AK7set+2qrJdO/HQAoamPADnAcqgw3Cuc0up6mzmVvbtWNW2yoNQfkdbdobnkpk5nYsmBhBwmagM X-Received: by 2002:a17:906:d8b:b0:87a:ee05:f7b with SMTP id m11-20020a1709060d8b00b0087aee050f7bmr9636035eji.24.1677768796156; Thu, 02 Mar 2023 06:53:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768796; cv=none; d=google.com; s=arc-20160816; b=gY2kFT0/HrVSK01gjIWIdY6JPDGBD6BiwTwT6s0IOdKPf01LUedrFEY1X2llQr2f4b FF2eCNijQuKI8uMCXMSA8SZAfqoeyOwPYGi//oLLV8R7aPHKS8vz9XNDsN0cQ9TLFHeu 64F2+zqHUao3qo77AvTYw6Ip1F3qJSQ37RUCT1x59hyV3uTj4hWD8N8IIftdOoZ0ksaC m7HzADubOUFpZ1ihLlEKZHxy4j1mxJc7qifFUPsVeTet53xNH5uDYe0P99idQmO1mj9m deL+KWPTDoif9rY6MRZCTU3jAtuj2Ty3LA3iBVEY2vKsA/RlUly87UP7bgzxL+DJMxyG aR6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=+XgOwOSe8bX3MkRK2CT/UjM7NAaZrhyD92Wm+0BgAvE=; b=DH5bWSG34s++Gn2oZepKDeW/csVST1FRWAS4tqSKwzZTZKt9ezbQTrZUe4TW49M5RV ePY/suzE5tn8uXuQFsKttnZxgqXolgFLEZgUAonJEHls/QaDX7G6Jas9S3V82v0PYb10 8dGzxWxsFU+1rzQwnyBQiF8iuoVRSMVDo7SJ+B6x9lFEl+36MPgU0jrVX3IJFf5oTDLk A2QBYh9uKyDydKOIAlqr6l02syFgA5X2Hl2oFz+I4R1jSnywGHbJRjQ1dwqJ1UG0DHkI IyZWEb/4dh353UmCunDfbY4NCsij9onIImxd4OjibktAJ7EJXVGx0SKGFYNUk2dcKyHO K6XQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g21-20020a1709067c5500b008d49082791esi2330137ejp.306.2023.03.02.06.52.54; Thu, 02 Mar 2023 06:53:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230324AbjCBOtR (ORCPT + 99 others); Thu, 2 Mar 2023 09:49:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbjCBOr6 (ORCPT ); Thu, 2 Mar 2023 09:47:58 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B104C423B for ; Thu, 2 Mar 2023 06:47:54 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDe-0003wI-Fi; Thu, 02 Mar 2023 15:47:42 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDc-001Ls1-QW; Thu, 02 Mar 2023 15:47:40 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDc-001ZqN-5d; Thu, 02 Mar 2023 15:47:40 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross , Andy Shevchenko , Wolfram Sang , Heikki Krogerus , Maximilian Luz Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 17/29] platform/x86: intel: chtwc_int33fe: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:20 +0100 Message-Id: <20230302144732.1903781-18-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1892; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=QVO6dKKemFdskHjiF8vZD9pCO2k/PVTJ/KaR9VN2t/A=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALbM3iGaNjk9rUPjk1X1CVhZ/lW1RT7BMjzm4 WS+CUGLvRiJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2zAAKCRDB/BR4rcrs CdyIB/98Uza7jBnNrGDjo63pDRiw1Bc222LHFRiCTGDDT0Wh/OntnnUftyaWqIQfFJsOxTc25tU K22JLqgJChyTGgjUCj4UOUxsl8OMfe8unXibaATEUHv/d2Y0o4CWxpTiVP2Xu3KfTyNUITkuGHq 8nl7AB/5lD45Fu2cZ4CsFEauvxsaZJKd4szFnmuYHmS9WinC5liaqyNq9WrEwllFqewKaq32fiO QFB7O0AmyTIAhITjl/i1caMfZwEJIwTfn+d5x4xzLQvcTLn3WOFXzAE+1aIElQGGDtZP4lkm1AO qsuksMER3UeqWLX1v1yRPImOMS0d6g0doEOuCO8iJ9CA4SQs X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268093173026929?= X-GMAIL-MSGID: =?utf-8?q?1759268093173026929?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/intel/chtwc_int33fe.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/intel/chtwc_int33fe.c b/drivers/platform/x86/intel/chtwc_int33fe.c index 2c9a7d52be07..848baecc1bb0 100644 --- a/drivers/platform/x86/intel/chtwc_int33fe.c +++ b/drivers/platform/x86/intel/chtwc_int33fe.c @@ -405,7 +405,7 @@ static int cht_int33fe_typec_probe(struct platform_device *pdev) return ret; } -static int cht_int33fe_typec_remove(struct platform_device *pdev) +static void cht_int33fe_typec_remove(struct platform_device *pdev) { struct cht_int33fe_data *data = platform_get_drvdata(pdev); @@ -414,8 +414,6 @@ static int cht_int33fe_typec_remove(struct platform_device *pdev) i2c_unregister_device(data->battery_fg); cht_int33fe_remove_nodes(data); - - return 0; } static const struct acpi_device_id cht_int33fe_acpi_ids[] = { @@ -429,7 +427,7 @@ static struct platform_driver cht_int33fe_typec_driver = { .acpi_match_table = ACPI_PTR(cht_int33fe_acpi_ids), }, .probe = cht_int33fe_typec_probe, - .remove = cht_int33fe_typec_remove, + .remove_new = cht_int33fe_typec_remove, }; module_platform_driver(cht_int33fe_typec_driver); From patchwork Thu Mar 2 14:47:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63456 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4274417wrd; Thu, 2 Mar 2023 06:53:25 -0800 (PST) X-Google-Smtp-Source: AK7set90wc3XuEpQ4bkCmv/QmNLmcm2vRRsTW7jFL9uaSFV9QCZxooDa9afzkyZrHBo15J1SDaNe X-Received: by 2002:a05:6a20:3ca8:b0:cb:f76c:ceda with SMTP id b40-20020a056a203ca800b000cbf76ccedamr13011450pzj.22.1677768805583; Thu, 02 Mar 2023 06:53:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768805; cv=none; d=google.com; s=arc-20160816; b=MuLkgc70xy4OOr7iOPXZ6qIN6ZRbLclQuakt4evU0D8UYqa9QTEMYdzZIvq0vqVAD3 WQy9gGbcHkol7iu1CeV37igKNFTbZGUXzfQUbj4xEKxu7IY0wxHjD7wlqdj7bHb6hs9V vONvmHmKc1txpr+gHHXZdQN2B2xXe8pbsEkk061pH0ei0pqjDVfYFBf8tN18+U7ZZ8Cn Zib4piDVnTMzB9AY1K0uH15JS4pkWAEKeCXFaJhiqBlBgzHc1nNRApMQvFdKgwHNU/p0 Vuw8GmBFnj/WkxkDClGiGQ8pdBuenkAWZqdJ2t5GygCn3M4DMUA5udYKgfdA/PZkqi0b GgDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=IUl1W93ZALM6v1SRLbDsiU1d34IZC22Etw0b1qWvXxM=; b=mR+m0rVOXJ0m43PqLCYQEDaHM9TIIlLW80b5Zw8wqHxZV2VbcSu1QOiDy8a+Aq+w9k WQ6xEdQVlgaMHYVTsJLUq5rWgv3W+5V6JjG6+hQoeMsvnIKP4gzaZBJyUj/jsQJkea51 EkERI5afDAWLyYNUe8+zsetoxLZkNOEmbyDr8QM7XCD+OlqwRQhqa2KrXh5aIi2hrRn5 VO6qLMepfRaFz/r1NjWr6IpXWtbZvKbLSi2aX32z6+6tgaJIAS+tQRDOgS76H8ucAi3x eLsyPsIVvQVyEltDwqN4p2Q/JwphoPJ9H9X4hxE25Mxj28MgHmBqeSCmh8AnERBfUYAl 3sHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s35-20020a056a0017a300b005a8cdb17b9bsi16220745pfg.102.2023.03.02.06.53.11; Thu, 02 Mar 2023 06:53:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230242AbjCBOs3 (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230078AbjCBOrw (ORCPT ); Thu, 2 Mar 2023 09:47:52 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1881E4AFF5 for ; Thu, 2 Mar 2023 06:47:50 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDd-0003wi-RA; Thu, 02 Mar 2023 15:47:41 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDd-001Ls8-6f; Thu, 02 Mar 2023 15:47:41 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDc-001ZqQ-CS; Thu, 02 Mar 2023 15:47:40 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Alex Hung , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 18/29] platform/x86: intel: hid: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:21 +0100 Message-Id: <20230302144732.1903781-19-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1911; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=p4w/9jtnouAyp1eJo+WIbJu5c+ULhR1tWYCbbhAgbEQ=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALbQOhcPWcexTWxY+NygINDuhyhOrXEYL7UuX i8rHZtG85aJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC20AAKCRDB/BR4rcrs CVcZB/9ye3KjcLu2a/DViU2kheftVNv5tc/U1GNDD6KzGERttB0ZaDXLvKKV6Rao1sIUIv92EPD ZhPDsMxLQbTx41TXu++iOuClbFkdLrqcSdQ1KEAfwNN1OAjkC4ISoFXwiwfhS60bzKEaeeV3EXz n59/YK4GC0CcwaWiKStFFMMmd2wHPmLS+OUwYn0eqvOPzD4yGgDGOq0U4hdNCEsbcNcbKGstptg 5urT4R8O5moRmjUn3LQ0e5A7LjS8gNU833MpvaOxiuinScybD4MV9Gn5IwkSjWIBJReTWyMcEee CpIdXq7Dz1u76ekXzZhKLCF9oEzIbnjCxS4vXl/nhYXHj+y7 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268102870494121?= X-GMAIL-MSGID: =?utf-8?q?1759268102870494121?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/intel/hid.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c index b6c06b37862e..5632bd3c534a 100644 --- a/drivers/platform/x86/intel/hid.c +++ b/drivers/platform/x86/intel/hid.c @@ -720,7 +720,7 @@ static int intel_hid_probe(struct platform_device *device) return err; } -static int intel_hid_remove(struct platform_device *device) +static void intel_hid_remove(struct platform_device *device) { acpi_handle handle = ACPI_HANDLE(&device->dev); @@ -728,12 +728,6 @@ static int intel_hid_remove(struct platform_device *device) acpi_remove_notify_handler(handle, ACPI_DEVICE_NOTIFY, notify_handler); intel_hid_set_enable(&device->dev, false); intel_button_array_enable(&device->dev, false); - - /* - * Even if we failed to shut off the event stream, we can still - * safely detach from the device. - */ - return 0; } static struct platform_driver intel_hid_pl_driver = { @@ -743,7 +737,7 @@ static struct platform_driver intel_hid_pl_driver = { .pm = &intel_hid_pl_pm_ops, }, .probe = intel_hid_probe, - .remove = intel_hid_remove, + .remove_new = intel_hid_remove, }; /* From patchwork Thu Mar 2 14:47:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63443 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273695wrd; Thu, 2 Mar 2023 06:51:46 -0800 (PST) X-Google-Smtp-Source: AK7set/cVd1LCmDQ1k23FQBawCaE4xKOREK7pAeDHRVA58vqabbudWCUik8bVk06xK5bK9s+NLKA X-Received: by 2002:a05:6a20:748c:b0:cc:aec0:e9b with SMTP id p12-20020a056a20748c00b000ccaec00e9bmr12483092pzd.19.1677768705921; Thu, 02 Mar 2023 06:51:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768705; cv=none; d=google.com; s=arc-20160816; b=vhubXrO8asjW1QwqX6B28TWrbyjTHaavkE4bYdQjZ8qQE7wGk+2l6yD/4WvS82itCW ZcnbqF+mQM7oAldj+gA4eMHnj54ECwg9GVJgt/Ut/GnJhow4STUPZ2MN/1CTKvCJrhXE v7A0q+Rlt53Hsm+ManNkmjo5j6lFNM5M4nO2CkPtQRtgeeS8i4FlCZtEHZIpsycIqxqN Cmu3GFHzBejU/vw5tL2wCXKN7LBLpddXUCw0W1WQwN8RNH1vqsEiBHhLr1X+Iebrl2ui zMsNAtkMzT0RnGeBz6itvRZlFTPmG4ZfnSPGOdFYa+J9R7sjrrMp9nYhWhuza+x7KL7p qVbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=GvIp0xrQ/5PoLdqi+xmeIgmYlbM6SEWq+jmOHg8M1Kw=; b=tEZkF06vRmitSS55S5FaWzQ8BScbdCOs+O6yboLxcdNHrspMpG4JX3VCrINGM2ljt1 pe09b6ilIW+oRYS16dvzP/RjVfqi68y5+dyGVM38VEevLNaMxHxwzw0oA7MjTkELjf9S DrIePqZdqE0otEkIk3XQCBuOz6b7lY8FZspXFQkKigmZxh90gH3xHAwnyIOjquHmHsOB UtJqPP4T6BcrDQk5tT/QqqCV/BTt+zVDhCcfDa9YY3sjRGPG6KVKhpNeKGVK53tWoVG+ IZjSwf4ioTu1w6d0vegSrRcuLayzyguEy8StTXgkoTAPdvVSm+o7a3amrTQu6OF9yL/g oDHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 126-20020a630784000000b004ce5301edd5si16505766pgh.711.2023.03.02.06.51.32; Thu, 02 Mar 2023 06:51:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230260AbjCBOsi (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230109AbjCBOry (ORCPT ); Thu, 2 Mar 2023 09:47:54 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A30343937 for ; Thu, 2 Mar 2023 06:47:50 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDd-0003wl-Ta; Thu, 02 Mar 2023 15:47:41 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDd-001LsB-7x; Thu, 02 Mar 2023 15:47:41 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDc-001ZqU-LV; Thu, 02 Mar 2023 15:47:40 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross , Sebastian Andrzej Siewior , Thomas Gleixner Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 19/29] platform/x86: intel: int0002_vgpio: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:22 +0100 Message-Id: <20230302144732.1903781-20-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1634; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=iMzvEUqbb2rVuVtUa7k/9sDC9oHzlYpq3RgIdsmfWLU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALbUqZeyydEqf9Lx4bdId4bvO/zQTf+JMBtAL DyBJyhKW+iJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC21AAKCRDB/BR4rcrs CeL8B/wLiJWJ+Cc+G4vGlLIb0gmj6OIjaI3tm75Qj3ZIxPJBm7dK7o7J/6y/PsDTqORP1b0D4t7 Zh0w7lEVWfjU4FYUnjygZFPPZKS7W/MkXmQkeohk2CYGcv6MS6+vd3l08/IIRLRvpHrUMmDFXFz pebUcKlbaNjYnIFDmfTrAAXBXmiKkwEWwTMUeOc5IoOzQuLgPPDm7gN8BerDOFTF7D+PGqtw2VJ e52arbYSVrWi5SBiL+Uka7RklzUtVMF/XvVWmEXZNlfSAqxYF5/ubtnJ52brgcpRD/xV9Lb9aE5 +Jde4XFPLDi8yGH1Akd6cp7KaGiT/9TvzfdwlADpf22HymlD X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267998409578833?= X-GMAIL-MSGID: =?utf-8?q?1759267998409578833?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/intel/int0002_vgpio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel/int0002_vgpio.c b/drivers/platform/x86/intel/int0002_vgpio.c index 97cfbc520a02..b6708bab7c53 100644 --- a/drivers/platform/x86/intel/int0002_vgpio.c +++ b/drivers/platform/x86/intel/int0002_vgpio.c @@ -223,11 +223,10 @@ static int int0002_probe(struct platform_device *pdev) return 0; } -static int int0002_remove(struct platform_device *pdev) +static void int0002_remove(struct platform_device *pdev) { device_init_wakeup(&pdev->dev, false); acpi_unregister_wakeup_handler(int0002_check_wake, NULL); - return 0; } static int int0002_suspend(struct device *dev) @@ -273,7 +272,7 @@ static struct platform_driver int0002_driver = { .pm = &int0002_pm_ops, }, .probe = int0002_probe, - .remove = int0002_remove, + .remove_new = int0002_remove, }; module_platform_driver(int0002_driver); From patchwork Thu Mar 2 14:47:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63463 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4274727wrd; Thu, 2 Mar 2023 06:54:12 -0800 (PST) X-Google-Smtp-Source: AK7set8zFqueQpFFmkwp/m/YVlz6OrIo0pnEwHHbXxWGp8CHnbn97n21xOL/0VFsi7DseiC60bhI X-Received: by 2002:a17:90b:4c0d:b0:234:e0c:caaa with SMTP id na13-20020a17090b4c0d00b002340e0ccaaamr11925236pjb.6.1677768852582; Thu, 02 Mar 2023 06:54:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768852; cv=none; d=google.com; s=arc-20160816; b=UmhFHJJruqWefuFF14YMoopPgQjkkvfPZ+JrlcG+dkRHA7O64qNpgtGdQzK4JSEC7y Jky/th4GvKqPDOWhrKMyKDHxkk1wev5oixHzWZ39fQNjbuB/hlWysywmv+4usXCavGmQ aZq8eHFEnCQ85H26THd1MUa0bifttIXlAXjAKzYyh0JyCrO109U83JzvgzS5m5ZWOA5o R2HdKEPFIrXc/o92Y20KD0F8c9xqh7LOzkcivkwnD2haKlgiffIJpRY1ei8JatniZlMz bDwoYU2xulCTpKgF+3Etz6gH8VEPXIlZowD0G3KYmz7/lRW+QyZxR0EzFgNcFT6xHlIK WFfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=58Ge5WP23FjmyxtXseNcjwbEjmtVSNRL8yYu8soFEBQ=; b=MY5sDm7Whgv4JCWzpozX5rdDObS9vVu45GHEJP+E1BAdWb6R9uGonAn5FOVJ4q36dc M/lAzHQN7l+j8mFDxA2Ygg44d7MfCAxamxtt4ScsXCGumaZcIbhFYXgDlCXsayYQMc9I 6iHCyq+Aw5RhEDbgbMLDyF3OmtmAY5R8foY5w9UG4lkBhARAElceU3Hs6zh7vToQrxTe 8C+qgTWd3FEj/Sn1OPS46U7jxYigcR/qINavSD9g8uhlzJyQSj9/VkIxOq74qwz6FZhH 0ALmdhBAOlZRUJ9pannGwUuwivis7nnQY25Eep2fyak3CAZ2Y8JFupV1nRBdksaWOKBR p5Xw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gb12-20020a17090b060c00b00234b3d276b0si2479424pjb.94.2023.03.02.06.53.59; Thu, 02 Mar 2023 06:54:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230328AbjCBOtY (ORCPT + 99 others); Thu, 2 Mar 2023 09:49:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230088AbjCBOsG (ORCPT ); Thu, 2 Mar 2023 09:48:06 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B881C2D65 for ; Thu, 2 Mar 2023 06:47:57 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDf-0003zW-0v; Thu, 02 Mar 2023 15:47:43 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDd-001LsM-OB; Thu, 02 Mar 2023 15:47:41 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDc-001ZqY-RR; Thu, 02 Mar 2023 15:47:40 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Shravan Sudhakar , Intel Corporation , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 20/29] platform/x86: intel: int1092: intel_sar: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:23 +0100 Message-Id: <20230302144732.1903781-21-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1699; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=0WhBbWaUwjGupEusr4fiMYsWZw2q9sM3XpKt7s0kViQ=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALbY61PKNuhLdthRcF9cFYPCDVTf2JIATQZ3F ZhH35ZrolqJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC22AAKCRDB/BR4rcrs CfTaB/0YWSxxN2MEgUnkqLZ8bB6kqb0wGvTpXbJGzDaRdHNlFe4HLCSihoBgVR0KGiP4faA2cl1 BIEyE9F/I851BQzjcEdCsFmSXaT6DS5ZQTzb7wwBz8Giz1pyiYyi1lTeY/ah3WunJBbpFk2B8zF HTsSKodrXFwVTGuy8nmkGMxxFZWB6x3wMF0hV1nNAiNyVUVhOQazN3cdR/7BEYZ+KDo9gsrvog5 MWbNcs3I9RuNB6BR4MBjgfGU6zXt0SdJABBwjSmvLYYTq/7jGe3XfxnSUpxnfc6ObBkgy65WZKM M3Bfl00b8SdNqNtG1F3Obkc9XPfRz5G8atN2x70YRW4B+WWT X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268152593771226?= X-GMAIL-MSGID: =?utf-8?q?1759268152593771226?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/intel/int1092/intel_sar.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel/int1092/intel_sar.c b/drivers/platform/x86/intel/int1092/intel_sar.c index 352fc4596494..6246c066ade2 100644 --- a/drivers/platform/x86/intel/int1092/intel_sar.c +++ b/drivers/platform/x86/intel/int1092/intel_sar.c @@ -292,7 +292,7 @@ static int sar_probe(struct platform_device *device) return result; } -static int sar_remove(struct platform_device *device) +static void sar_remove(struct platform_device *device) { struct wwan_sar_context *context = dev_get_drvdata(&device->dev); int reg; @@ -304,12 +304,11 @@ static int sar_remove(struct platform_device *device) kfree(context->config_data[reg].device_mode_info); kfree(context); - return 0; } static struct platform_driver sar_driver = { .probe = sar_probe, - .remove = sar_remove, + .remove_new = sar_remove, .driver = { .name = DRVNAME, .acpi_match_table = ACPI_PTR(sar_device_ids) From patchwork Thu Mar 2 14:47:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63458 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4274469wrd; Thu, 2 Mar 2023 06:53:35 -0800 (PST) X-Google-Smtp-Source: AK7set8i6GvYVfIzFDp3+PPZZs5e5vOnFQkKqNDimw14DBI1nF2W33YGvLSZWH++0VDgsRYHrsE2 X-Received: by 2002:a05:6a20:a122:b0:bc:a2a9:1aa with SMTP id q34-20020a056a20a12200b000bca2a901aamr13188324pzk.55.1677768815623; Thu, 02 Mar 2023 06:53:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768815; cv=none; d=google.com; s=arc-20160816; b=kly3P5GWkPB9khZNRvR0vV7vntVqaSq1OX+ktrFm88NFSDWn0GKamCbeAbCA4BpjRQ evdQ1A4YnXBP7rfMNUy+Q5fEn7ionB/NOLGMCZT6uYaZw3KfEwMZasQX0bIdFhVjbJH8 uxXd4eRiAx6RS3QKL7QIUFvyehuJfLtrX+JSU72RSRMVNKpPEjTEF/+9+PPXiZjYmEjx gaiOiexEW+GXLTuU5poaPTNdGi9kYCipxOOo0rOPWYecW9+UOBHwApOhBKmMUC3/rmOO /GKZ8ZDM+SA6GoIk9UkdTkEZmCqqwzRCI6cRNXje/UfPg25TCtuWZ4f2GfLen9JInx5w I4jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=hMqiSOJ4kGVjpNT7tT9MYUg9254SUaL23qWl5fohFss=; b=X5ITVCWsG/sjLD2fPEOv+6xomYjsM8bxdy1e+1bqbDTHv+Y12WULSQDdT5j1w6ZYEH OBk4BnMxqgIxbtrnPPsPRbwBVlJuKHCBixj76PzSObpOXeRS0K+MjAp8yYZKbs/PkuiQ yMP0aebEqbvjytez8dawVQJxd2lwgOXS3Bo2URe4qLUwVvCkNW0dVvqkmpmTN81eFdZ2 pg9GsrwCTy3jENwLw16KjT4Ad65mneICfNst33wm2B+J2OG5TJu1ty9q1MgYpXUvhdR6 qJIMLloSCAFgnMEsqASh2Y9kEVNbTHbX9STYFQoKDzl4sINkluw1T8qk4hl/Ol6qduAY saVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c9-20020a621c09000000b005808bb470a0si13611763pfc.180.2023.03.02.06.53.22; Thu, 02 Mar 2023 06:53:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230094AbjCBOse (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230105AbjCBOry (ORCPT ); Thu, 2 Mar 2023 09:47:54 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3A8FF96D for ; Thu, 2 Mar 2023 06:47:51 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDf-00040h-3B; Thu, 02 Mar 2023 15:47:43 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDd-001LsQ-TG; Thu, 02 Mar 2023 15:47:41 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDd-001Zqc-1U; Thu, 02 Mar 2023 15:47:41 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Daniel Scally , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 21/29] platform/x86: intel: int3472: discrete: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:24 +0100 Message-Id: <20230302144732.1903781-22-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1966; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=UZcNHKDZjEJbsCj/ym4PGZg6gRKQSXlA+HuRGH++vF4=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALbc1iljYRotrm+Rq2yhzl9a/KRtXWqcsLW3s iyn+tlGYCiJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC23AAKCRDB/BR4rcrs CdnWB/99xSk8KJ5WTtdChUxqNX7Nlr9oFUYmlHtxAqOF5m1LtLOHZZ+onMuEJqdS8zDM1MX4B47 i+cokuQiYNkMmt7KhF6lFGRIEGx7cEesi8NcSvvMweGumCsnuZTaI9WyGf72j0vseoSc/RzlyR3 kEu8dtEGYy83oWsjGihFY7lkSnuUFJyxdCEsfb9Z24rwV9iYomnegHQ58HRIVOEhwYAaOJw36gN 8OjD6YVDL+NMROL6PcAaAh1QIFIgeTc9BUua98cOnfFgKV46tidNbJ2IBwvyPAvQdkxOGgAy96c GPrPj8xM1urAI9sA0SuoBf5dWx4LqS5Sb1uJzJEHOMn+bxSX X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268113198298487?= X-GMAIL-MSGID: =?utf-8?q?1759268113198298487?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/intel/int3472/discrete.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c index f064da74f50a..ef020e23e596 100644 --- a/drivers/platform/x86/intel/int3472/discrete.c +++ b/drivers/platform/x86/intel/int3472/discrete.c @@ -317,7 +317,7 @@ static int skl_int3472_parse_crs(struct int3472_discrete_device *int3472) return 0; } -static int skl_int3472_discrete_remove(struct platform_device *pdev) +static void skl_int3472_discrete_remove(struct platform_device *pdev) { struct int3472_discrete_device *int3472 = platform_get_drvdata(pdev); @@ -326,8 +326,6 @@ static int skl_int3472_discrete_remove(struct platform_device *pdev) skl_int3472_unregister_clock(int3472); skl_int3472_unregister_pled(int3472); skl_int3472_unregister_regulator(int3472); - - return 0; } static int skl_int3472_discrete_probe(struct platform_device *pdev) @@ -392,7 +390,7 @@ static struct platform_driver int3472_discrete = { .acpi_match_table = int3472_device_id, }, .probe = skl_int3472_discrete_probe, - .remove = skl_int3472_discrete_remove, + .remove_new = skl_int3472_discrete_remove, }; module_platform_driver(int3472_discrete); From patchwork Thu Mar 2 14:47:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63459 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4274478wrd; Thu, 2 Mar 2023 06:53:36 -0800 (PST) X-Google-Smtp-Source: AK7set9mTliMMS0fvghQgww4jZ46yGn3fq3u4THD6WkXhfERwgvPINpKj6UXtSpRlKE9SiPi7Nbp X-Received: by 2002:aa7:9530:0:b0:5a8:a0df:a624 with SMTP id c16-20020aa79530000000b005a8a0dfa624mr9166693pfp.22.1677768816226; Thu, 02 Mar 2023 06:53:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768816; cv=none; d=google.com; s=arc-20160816; b=L71Cf2+ZwIuUPkWtFLHr7y3mp/FcOgJqq8LXTGt21Pbd+QVbIJinbJIVdqGSoAzIBL JJWTJmUX41Lu1dDAA6MToBLmEbNZCx8cRswj6nG6GJCmltrJO89vJ2J1rUrHwOoT2ABo utDV3j6b82aT7tr4XM8j5q+vi+Dn4cltEsUzllvhc6z+E60BkFgRMoN2pvg4b+2kEdLc 8/UTqqjoNjvuux9xfk0C+zrSK2qafg3V6EFaNqH72M4yPjda99Oyfz/dvCEDprX0k1HS DrZyBNq+EFhgKuwLKWkocyvA8GpBTo15ng8BujYAXSCbCgBoK0lVGYUjRCzu1KRxtfDO O8/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=FS31aWbXLfnzm0y3kH5qaGkuGR4UR6nobSrtjnQw4EU=; b=IaKGG5Y5xgyghJaHqi/nvM9omCTVy4OQ5SEg2awCAAmZEHVuj0j9dU6zQ/+HaJhbVn cliSFFlnxq8B87I2RuS5ofYgsWZyBD0v40kAnDHNYtYDABI0My9PEQDpCurbd04OabEB VODbLGlSvIXGXoQ97aynYoxYNW6XiyWFF6ChFmi1IWEIZ8tHrJwgwpbNKqy80ojm18uN ZwWbKysFYS0CkuG4eE8GjnJUslApGzCB1TtT84kxOw9RP06PrsVmbedonuIIiU5MZ9oF hRGH5jj6LEKZ3jq9Il464hp+yzqQQhb9L5ofNPuwvl+OKs7ZiU59gaWOz6upN2HrvikJ VpsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h27-20020a63121b000000b00503005a4f2fsi14909054pgl.857.2023.03.02.06.53.22; Thu, 02 Mar 2023 06:53:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230264AbjCBOsm (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbjCBOrz (ORCPT ); Thu, 2 Mar 2023 09:47:55 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01D5D126E4 for ; Thu, 2 Mar 2023 06:47:52 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDf-000456-Sz; Thu, 02 Mar 2023 15:47:43 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDe-001Lse-U4; Thu, 02 Mar 2023 15:47:42 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDd-001Zqg-9d; Thu, 02 Mar 2023 15:47:41 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 22/29] platform/x86: intel: mrfld_pwrbtn: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:25 +0100 Message-Id: <20230302144732.1903781-23-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1729; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=OG41i3sS4T3dTQzV9HEPZLUvI3D2MnBGxhm9QPceSMg=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALbg9lEKjeaVD8wtq8wL8UjqxJ46eyp20lTtD SxmsWXcMW6JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC24AAKCRDB/BR4rcrs CfO/B/45kD3W0vEHIuGJdqj5KAIbCyTqJQwNCcmkpfQ2ddVpoxDCvGlVsIDKPTIlc1/f/uuxzUo hJPaNhNuZZRXrzrMV9YFpmRDCkTch8BTjxbNzvLCLlSTSamAJ6HR12FHq2MFa47d25NiSqvnGnT v/QTQ8K6JY//DpGdP8V16Aqk5X+y6DVH/NrykmbJCRre8PgQiUg9dEyOH4iOwD1mID8qDBuT9+o xkaV6NqSXmqhUVleqmOY4EKwY6aWmE17+SwfHiOURWk44d4XHAbtlpe2/Idoc97GMXaKlHr9FWm A+ulnzE5JhONxJ+5eidaNgqCnxIUCMu8Np14DYcKwK0mhoby X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268114299713982?= X-GMAIL-MSGID: =?utf-8?q?1759268114299713982?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/intel/mrfld_pwrbtn.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel/mrfld_pwrbtn.c b/drivers/platform/x86/intel/mrfld_pwrbtn.c index d58fea51747e..549a3f586f3b 100644 --- a/drivers/platform/x86/intel/mrfld_pwrbtn.c +++ b/drivers/platform/x86/intel/mrfld_pwrbtn.c @@ -78,13 +78,12 @@ static int mrfld_pwrbtn_probe(struct platform_device *pdev) return 0; } -static int mrfld_pwrbtn_remove(struct platform_device *pdev) +static void mrfld_pwrbtn_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; dev_pm_clear_wake_irq(dev); device_init_wakeup(dev, false); - return 0; } static const struct platform_device_id mrfld_pwrbtn_id_table[] = { @@ -98,7 +97,7 @@ static struct platform_driver mrfld_pwrbtn_driver = { .name = "mrfld_bcove_pwrbtn", }, .probe = mrfld_pwrbtn_probe, - .remove = mrfld_pwrbtn_remove, + .remove_new = mrfld_pwrbtn_remove, .id_table = mrfld_pwrbtn_id_table, }; module_platform_driver(mrfld_pwrbtn_driver); From patchwork Thu Mar 2 14:47:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63448 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273879wrd; Thu, 2 Mar 2023 06:52:11 -0800 (PST) X-Google-Smtp-Source: AK7set/fmj0nzU5pGm2zifOFWXykBAcCt+iwvO5xcV2XaUP5ZMr1CheRrUrrTfuPKz3RlQmDvKID X-Received: by 2002:a17:906:76c2:b0:8e1:cc38:6ab0 with SMTP id q2-20020a17090676c200b008e1cc386ab0mr9123473ejn.16.1677768731499; Thu, 02 Mar 2023 06:52:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768731; cv=none; d=google.com; s=arc-20160816; b=BtQRpHMr6uAe2SN942uMGq+NFwa8Gk7jA1MFvIRKJISQq6QPHJuPuRCzC3yz6abPv9 Di4Qcgojp4Yt0NW3jvGNS/Bv+NFpskOGFNjJeP7izz21rUF2B2yyTtPeWESzy9mNnK6k 3wJaKDW9XInE1voVwbb7IyL/Gdkx8G6+J5tfXP/L7qWur9VOc9XBQ1TfcAi09ywRSUyv IHGf5Z7uehbrUG8rO3k4VjC0rIMzGmKScdv5mJ0WPSbqV5U1At6BaYUSG9Hu6omhoZco 65BKQeLLAVUIUthsssSoNw5Znhyo0WNfzNRlICyzaIaNWk3zYgfoUXoMIa4N1Vj0ewku LOsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=X+k/Q330lDNp6eOmr2JAlDZ6zA1hxMMuPOBqO+zYBkg=; b=YTLgOV5fML9xqjaB+Y2y1bCn5iXt3fInPIRzLC1D06+R6C5HOqd5ypkgab7b5VzH1j rtykWoRalGfvBmKonmiJAwWxaig4J4MQu87ZI0liNa8iEKvZnhOc0RBA8c9alHioiyLR W+QNCZ7rYlqiM+cpLy7vJBm4yKzD6pJkzw6QXgqDreRCMWJB3m46YZNhawF2YoQj9Dmh qFb+c3qPty+Md07g5uVKLliDke0BIWwSoxrZYzAVy2eF+OhhjxewgiQFIp9X5w3u0Xbw /veJA4Eu5J8x5TyyG5RqCPK+g3MqWdBNWeE3KhdCVNQIdr2BLa45AH6Pv482XG3dOrNM jaKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho15-20020a1709070e8f00b008b17f6bf67asi3760038ejc.283.2023.03.02.06.51.43; Thu, 02 Mar 2023 06:52:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230319AbjCBOtP (ORCPT + 99 others); Thu, 2 Mar 2023 09:49:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230019AbjCBOr6 (ORCPT ); Thu, 2 Mar 2023 09:47:58 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11FCF44B2 for ; Thu, 2 Mar 2023 06:47:54 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDg-000465-IH; Thu, 02 Mar 2023 15:47:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDf-001Lsr-8H; Thu, 02 Mar 2023 15:47:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDd-001Zql-GN; Thu, 02 Mar 2023 15:47:41 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Rajneesh Bhardwaj , David E Box , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 23/29] platform/x86: intel: pmc: core: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:26 +0100 Message-Id: <20230302144732.1903781-24-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1747; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=uAI4ihJxvW4g+0BlsuHpE7TOaB4sZpNOr0yzWOEQmig=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALbk0pATwQt1Fk1UTJsVrARpIaPV4Hnc20cCq vE5tCX27dGJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC25AAKCRDB/BR4rcrs Cb0YB/9hCziSWMMpJxmY/mG+rWnQZ/1jcm9ipG1J8irNinnhipWult0aC+2TVkFPBWp1itAeCWn 0ajIptER5my2NjrMx4CHT8CB7ZZ2pSUHMy9TXK1ptkFTAokFJTf/tzj0YZksbbHn627ol4t1/oS Xvl2Tmsn2RU0OjWigLqZbZvBbVZBNCPpw7qLPTxov1E2maTOWtSto6e6e7grimZvpnVJZHlpGhi 2jeYaixppbyBhrgbcLorQc2XmSWQIqqF8W6xtRroj73vSggNvneMu6FaEvOUCwk/4QghcpK43i9 whtlFi1L3axIHaj2zQ192SNiYpZXe62PdDwyxgspH1MDn+Em X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268025284222530?= X-GMAIL-MSGID: =?utf-8?q?1759268025284222530?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/intel/pmc/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c index 3a15d32d7644..e489d2175e42 100644 --- a/drivers/platform/x86/intel/pmc/core.c +++ b/drivers/platform/x86/intel/pmc/core.c @@ -1149,7 +1149,7 @@ static int pmc_core_probe(struct platform_device *pdev) return 0; } -static int pmc_core_remove(struct platform_device *pdev) +static void pmc_core_remove(struct platform_device *pdev) { struct pmc_dev *pmcdev = platform_get_drvdata(pdev); @@ -1157,7 +1157,6 @@ static int pmc_core_remove(struct platform_device *pdev) platform_set_drvdata(pdev, NULL); mutex_destroy(&pmcdev->lock); iounmap(pmcdev->regbase); - return 0; } static bool warn_on_s0ix_failures; @@ -1264,7 +1263,7 @@ static struct platform_driver pmc_core_driver = { .dev_groups = pmc_dev_groups, }, .probe = pmc_core_probe, - .remove = pmc_core_remove, + .remove_new = pmc_core_remove, }; module_platform_driver(pmc_core_driver); From patchwork Thu Mar 2 14:47:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63452 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4274019wrd; Thu, 2 Mar 2023 06:52:32 -0800 (PST) X-Google-Smtp-Source: AK7set/raYCRSi96/3YbovvED9K0Agdi7BEwVcQ/IiE4docWU0KpKXkd1Cn1sax2d5RGVEPpe0lE X-Received: by 2002:a17:903:41c2:b0:19c:171a:d342 with SMTP id u2-20020a17090341c200b0019c171ad342mr12925194ple.37.1677768752047; Thu, 02 Mar 2023 06:52:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768752; cv=none; d=google.com; s=arc-20160816; b=oTD283tC8mhXaKSqBbAWsbB5aXj9CAflQJcHuBnWLaGi602AW6zgiizxyOKCBAzhgC vGL2aBFYhL0sjCPLOsC9mAflsiGnOp4kNUywp5f2G7d7qgIG+jEuk+cVFr9wNV3qQez7 rw8DaqtCXleNKwXTNDGqG6Mv6V4PmaKOWzxmJghQvRUsMrgKaxHGhWvbU5UMflIyRaI7 5YUParr5pENmuammIzgyC+VM0fA8z7BP5PzMqGQFpCEWlfc3tDjX0nw5MZEVoR+Edlij RNidOA7om+tExXL3kvuF6OCPj5lwItwIk+MTXQm/WHaFnJiKol0dXynNR7j/xarA4j8V rLog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8qanDYWcEfMXbGGB8UHW1QIZooQtjUZszSHo9NfWt/Q=; b=FbCE3O9wYtXRPvTSmBytJ/3UmD/Tf/BTTQYgKPpGjbkI3T8Jt3sjfpUjCljH8qMKcb QH9sSFqlO7sR61HdjmRrtotS93M/wTBUwpjDyI6rShpbnSzmC4tUvPWkGNR4HHUX0mTQ f7qvCyAwy4m4dD5hZtbahCa2p0eDTdU4zAWA+PFKFBkJxtgZstRFZZdkUzcPAUWajPaT zkOD9O536gwuD7KRY2RETlNfhDjpPs6RkU8XIxU3xoyWAXTLErRu4lQmXYnwd2Z6yGZy tTBg5qGMCUMth07sDZX2VcjhNw6bUdihCU9wDMpz2vuRalSdZ5Ait8pxcGFt+nfwrJVu 8ATg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id km12-20020a17090327cc00b00189891763f3si14691378plb.600.2023.03.02.06.52.18; Thu, 02 Mar 2023 06:52:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230326AbjCBOtU (ORCPT + 99 others); Thu, 2 Mar 2023 09:49:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230055AbjCBOsG (ORCPT ); Thu, 2 Mar 2023 09:48:06 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEAB24AFF5 for ; Thu, 2 Mar 2023 06:47:56 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDg-00048A-PW; Thu, 02 Mar 2023 15:47:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDf-001Lt1-RN; Thu, 02 Mar 2023 15:47:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDd-001Zqo-OP; Thu, 02 Mar 2023 15:47:41 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Rajneesh Bhardwaj , "David E. Box" , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 24/29] platform/x86: intel: telemetry: pltdrv: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:27 +0100 Message-Id: <20230302144732.1903781-25-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1536; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=hOir3yXd83a78a0bPOR4SmKCgiiootAaMYiyANLQEpI=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALbpEeUZ2FAWsS9vjuh00XXV+PbA7DK9BvZCw bFvDL9yflGJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC26QAKCRDB/BR4rcrs Cec9B/4kKCwcif2sEiaGMCtMBS7J4kjTOZUvQu09kErcZ4jZGTPc0DiCYDREV7dTPB5wXw4RZTo 265n8tnVihTjLjhdtSO51y48UYb9jcKZ2iVYggvXheuLDdOGVpKu9mBu5DqT97cyi3Zaea92WYs gB8moR2M1skFePwt6DreEGlLQcRkoag4Qnn76W1DgB7ljDa7oJ3oPPH1JAluOFBoOeEghcacXVz 2fJiEXASlquRiXQbZg7E7DIbuR4exRroCEfDabawYbULJPea2GeyUXnYB5f2aMBf1zMUkm7gudH /HZT7d5YDGH9uciLohUgJNZoDQiAv3rO0J6NenKGnJjAqSSX X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268046683896945?= X-GMAIL-MSGID: =?utf-8?q?1759268046683896945?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/intel/telemetry/pltdrv.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel/telemetry/pltdrv.c b/drivers/platform/x86/intel/telemetry/pltdrv.c index 405dea87de6b..06311d0e9451 100644 --- a/drivers/platform/x86/intel/telemetry/pltdrv.c +++ b/drivers/platform/x86/intel/telemetry/pltdrv.c @@ -1156,15 +1156,14 @@ static int telemetry_pltdrv_probe(struct platform_device *pdev) return ret; } -static int telemetry_pltdrv_remove(struct platform_device *pdev) +static void telemetry_pltdrv_remove(struct platform_device *pdev) { telemetry_clear_pltdata(); - return 0; } static struct platform_driver telemetry_soc_driver = { .probe = telemetry_pltdrv_probe, - .remove = telemetry_pltdrv_remove, + .remove_new = telemetry_pltdrv_remove, .driver = { .name = DRIVER_NAME, }, From patchwork Thu Mar 2 14:47:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63447 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273815wrd; Thu, 2 Mar 2023 06:52:03 -0800 (PST) X-Google-Smtp-Source: AK7set+M+UViFsxXCGSVfZQeu7YYSjn1IM/q88dRYx2tHivmuY5s02jeaTgqy5EK3p1lpLL+Mh7g X-Received: by 2002:a17:902:e851:b0:19c:f16c:5cb4 with SMTP id t17-20020a170902e85100b0019cf16c5cb4mr12146666plg.1.1677768722719; Thu, 02 Mar 2023 06:52:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768722; cv=none; d=google.com; s=arc-20160816; b=jT6PaEX0sIj9JEYvXU/NMqnn29f5h5tdoUq0rlTMHqJjawqd5LYZGesH75JDR+QzXs iAOn8HgqOaiIG83xeswFEIhxE8tkCILScF/ZUDpXR2/vNEP89s7/QAgf3ZgkgvnjkjUI HWWHlTAk0uwGXozGb3ukqa7z8Ixia0kJOKAah1QFbUUPDgY/CNmFDbuft65szVm2e0D3 YV+J6P3RKZ9Vprgc+Lj0s7NEw3upk0qMezTYMVQqxFMX5qNOwmEDrEdou8ebRNl61z/K q0YGqUrazlJU/KuzN8Uzh+eLoI6mPL7lfLABot4y2tlZN5T+wqzJu+9Tp2+NmPs7WUTX wJ7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=0+JtW1EDwYJLuN3sG8DhWyTsP524VcWmXeMfSiDUSz8=; b=m5P9gIjmEJqcrmMC473xgxlfRNFaLrpOCDgyvrjZwwE9ee4+ewlGFokoncSV6G9usr nJpyNWxUQP9vYz9+BPKN9/skVWFwpIc0m0qqNxfqYMA9AHIq1Q/Tjjd2W5RwvO6qtCu8 FwaJdHqIaLBvr3ElbaWHFhaUb4Gzqd/Qtg/ImYanqiIjaf823oKu28GMRKNIYkM1mpGL 8R3otHKj2yZHyWjw9+PNXiGCAxcnrWKFUI80tD5m2NrfqAPb8GP8Z8B34u0BjuGMHWvG cDrOmn8aQtd43HvES9nT3nR+THVZJVJV090aL8I7A+7fNKw79cbe75m6Wguwr43+zHaZ Vqdg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e123-20020a636981000000b004fbe5ede678si16050433pgc.3.2023.03.02.06.51.48; Thu, 02 Mar 2023 06:52:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230190AbjCBOs4 (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230038AbjCBOrz (ORCPT ); Thu, 2 Mar 2023 09:47:55 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 424F03C24 for ; Thu, 2 Mar 2023 06:47:53 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDg-000451-8n; Thu, 02 Mar 2023 15:47:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDe-001Lsc-Sl; Thu, 02 Mar 2023 15:47:42 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDd-001Zqs-Ur; Thu, 02 Mar 2023 15:47:41 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: AceLan Kao , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 25/29] platform/x86: intel: vbtn: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:28 +0100 Message-Id: <20230302144732.1903781-26-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1808; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=4FZ1eGAX+X12ziQYLanXNlvTUV1hJsemEvhnUGuqfu0=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALbtPQx7WWOR6o/HDFF3FfDIA4I2AEt1OmhLd At+L54FrseJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC27QAKCRDB/BR4rcrs Cfk6B/42GMBgRTuXwK3tgegTCPgEvh66TJeY3zga6GDbSZDjbOL1VJ4YF8MoNiPjI+2fUe15wd1 pQeyoHXuxGjlRYudlHcx6pmVyBIAjYUaaH8/k5lE9cXwku6V9sPs7hk+McfbSyYHM8p7hLkMl5n 5h+mhDYIHwJ/TrdLMaFeOYxGLauyNEQvaizZVq8zh/Qiid/wz0zefNaTSriAjC3AS+y1fl0SjyE Wht2m4tgxrjOPLthSMuICiwQ6hdzelGYb9ZnLaBIupruRfMM6p61r7+TC5Hry9LIhuh3dhplVkc UYE5lBP5y7xLkXXjAzm2TN8LEUs6lQyNVpsGDByJAM+w1cay X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268016034498207?= X-GMAIL-MSGID: =?utf-8?q?1759268016034498207?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/intel/vbtn.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/platform/x86/intel/vbtn.c b/drivers/platform/x86/intel/vbtn.c index c5e4e35c8d20..6fa1735ad7a4 100644 --- a/drivers/platform/x86/intel/vbtn.c +++ b/drivers/platform/x86/intel/vbtn.c @@ -325,18 +325,12 @@ static int intel_vbtn_probe(struct platform_device *device) return 0; } -static int intel_vbtn_remove(struct platform_device *device) +static void intel_vbtn_remove(struct platform_device *device) { acpi_handle handle = ACPI_HANDLE(&device->dev); device_init_wakeup(&device->dev, false); acpi_remove_notify_handler(handle, ACPI_DEVICE_NOTIFY, notify_handler); - - /* - * Even if we failed to shut off the event stream, we can still - * safely detach from the device. - */ - return 0; } static int intel_vbtn_pm_prepare(struct device *dev) @@ -377,7 +371,7 @@ static struct platform_driver intel_vbtn_pl_driver = { .pm = &intel_vbtn_pm_ops, }, .probe = intel_vbtn_probe, - .remove = intel_vbtn_remove, + .remove_new = intel_vbtn_remove, }; static acpi_status __init From patchwork Thu Mar 2 14:47:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63460 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4274571wrd; Thu, 2 Mar 2023 06:53:49 -0800 (PST) X-Google-Smtp-Source: AK7set/o7yD/FlPt4Ib4EclNf6l0iaBEKR7izwTB+gV+2aupsrmAPF8wW7kFkQtZEtLsyhwMZoRU X-Received: by 2002:a62:6456:0:b0:5a8:beb3:d55f with SMTP id y83-20020a626456000000b005a8beb3d55fmr7808105pfb.32.1677768829416; Thu, 02 Mar 2023 06:53:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768829; cv=none; d=google.com; s=arc-20160816; b=zv2GcLx1mapjFxA3OshYopZUXhJ/xHIJMGBpp79//OrrMdj1QOxf7BVGOkIl0ewHBf zeLaAAuvPrvPV/QU/tiPFjumtGsPpl/2ZxUcOhvN9ZY6Pr+sUdWhIRy53kl32/SzHAQQ lri9fA8r/3tQbUfbDJaVCnAMnGxLLlKjXxIAZZA2JDORycHn25lY5nTJXLO74PB2NYvp EIb1PIQR5K2adUsONhSpr/hlWGkkZtj8qg0hvLi3xkWG4IR8EUAsIRiMPrG8zSw0bWGe YH0Wfj6kNzhbUYxblqZgf3mLwkSdgPQXoG0lp4PXVvqOBpaEkIYzywS3EEBiMisfRZbG jjag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Qj2KD+kxnAsSvOg2SG58sdsuPRYw7/u2h+Cusuz5ZU4=; b=Qd9SBevySMuggMHsZn7b3KLUFeRT68wzrpMCO8S1Y4YMyxYNzHGRGKDw3xKKt+1NeX cGZzfwPASo/kZ+RP7cd3AmJkqTFE8JTQJxjThoNH7wk1Jr5BfGHzDjO2/1Ab1m0NybhC 9QF65KwvfOBYQTnjMA6RNo/+M+1JKRsXbv68e6TE85R8Ackq0a38Hxa6FoqTuN/qrcGY rc60fA22kDmS3lyMNDxlVP4EuLJhAmBLuQHJjrrd+q+MEr9wD+Fq8j0jFeC+il24leEY BnIy22SX3xAQZBKZCzLUzl+sNMO3m1Ucg2vFJIPXDFmbCYf48hAUHuEdAH4JwtouYvzH V/rQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y73-20020a62644c000000b005cba6572e36si13742112pfb.244.2023.03.02.06.53.36; Thu, 02 Mar 2023 06:53:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230309AbjCBOtG (ORCPT + 99 others); Thu, 2 Mar 2023 09:49:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229564AbjCBOr5 (ORCPT ); Thu, 2 Mar 2023 09:47:57 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 974674207 for ; Thu, 2 Mar 2023 06:47:54 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDg-00045R-B7; Thu, 02 Mar 2023 15:47:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDe-001Lsi-WE; Thu, 02 Mar 2023 15:47:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDe-001Zqw-4L; Thu, 02 Mar 2023 15:47:42 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 26/29] platform/x86: samsung-q10: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:29 +0100 Message-Id: <20230302144732.1903781-27-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1631; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=+GOxOWYmv6duofeGht03dZCq2oL/vZ0wyWmPfKijFXc=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALbxZQvm4g0jdxlGvF1cAfRQJNgxIrXIFs7JD 6/CIRehgNSJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC28QAKCRDB/BR4rcrs CblBB/sFtXfcdHErOkkcEQ8hZ49eFrmoJjb63KCPW+FGF2714vGdahbqBDkUlqhs9JJurJ9/KEL QpaH8/JbmF+gYceOJT10k10EU+oOvOxbOWtd5Yoa8p72Pwu5JR89xjLfYT7FFNyFd16Clb+lLG6 XcXu4K8enCI5fh6hTnk18uruU6G51Y3SbQr8KIbTr/insJrWBvl4zaLxke9oQ3SVWN7kwIc2/iQ 3VZtClYPMdpLMo9pNM9ntQEDbkkq06044P+8IFmVXe7yB8wy4qvCO5FtflsOlavbbH1mZ5lh16E k4uvo6NVrVx/Ebej/kuVTIJdQy/SW6J2wfJlUHVR/lKtf4Bf X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268127759241469?= X-GMAIL-MSGID: =?utf-8?q?1759268127759241469?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/samsung-q10.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/samsung-q10.c b/drivers/platform/x86/samsung-q10.c index 6eb08b539311..134e2c3d91ca 100644 --- a/drivers/platform/x86/samsung-q10.c +++ b/drivers/platform/x86/samsung-q10.c @@ -65,14 +65,12 @@ static int samsungq10_probe(struct platform_device *pdev) return 0; } -static int samsungq10_remove(struct platform_device *pdev) +static void samsungq10_remove(struct platform_device *pdev) { struct backlight_device *bd = platform_get_drvdata(pdev); backlight_device_unregister(bd); - - return 0; } static struct platform_driver samsungq10_driver = { @@ -80,7 +78,7 @@ static struct platform_driver samsungq10_driver = { .name = KBUILD_MODNAME, }, .probe = samsungq10_probe, - .remove = samsungq10_remove, + .remove_new = samsungq10_remove, }; static struct platform_device *samsungq10_device; From patchwork Thu Mar 2 14:47:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63453 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4274073wrd; Thu, 2 Mar 2023 06:52:39 -0800 (PST) X-Google-Smtp-Source: AK7set/D1923JzVkjpIp62sNDwmTTWlPKABCV+e6nW90akSbx5svpDIpoz+ueXyTUMtmiC+vm3JM X-Received: by 2002:a17:902:e74f:b0:19c:dc25:dbf5 with SMTP id p15-20020a170902e74f00b0019cdc25dbf5mr11842660plf.67.1677768759371; Thu, 02 Mar 2023 06:52:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768759; cv=none; d=google.com; s=arc-20160816; b=Hb8SX4FiPEeoMMGqhYM8NhS815w9T8PLUiKGyU9RHgcdo1OvaT/7WKCSQg0Zx38PCD CzXjkEw6LEiCE3es9/DbULkrf445nJaJiA0hUY7Y9wyh0zR88GtwXdsJNbSyuIy4fK3F Ae2aIy1O50BPeqTQWdSInuFI4lp4m77hme3qXeonKTSwHXaMmIcKZlCWXffNNPzrqANy jzwOs0LJqIEzwfznlny8pLEXKLEQaqvmcn54Dn56V8ULLFwg/TE5Up0cZKC8lUY4tAHn vNTh/Lgkj1IEHDGse4iHntqhK4eSLd3RRfUbpAdaGaD9a6PTMJdv1Jjt1fFYKP00xReR 98xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=kJvj0y6obLvVX7w1AbeK7y0Np8KEIVB0AXjlpxryh2s=; b=sHDMPVxqdvOSfY+lnUAmpGUj97RxslN0YLq+iz4eyL5ZcKhopxZn8lw90yFcf/6Lbd s3bRhSbXzis+E6YJqJi2mKcZbCCJjVkc3Xi3YQyU9tgZ3ECo21NgMiuiVPELc2aXFahq KoDa+7ALZsQkQQEUrf7Clf3HkNnxj+lDczJCG02mySeJnxEcdXdNwW7j8ZfV7QcaNdta A0dxyYR/6McK5NbH+y4Yehu12jOjq3oSNEjsr05j4iTazU8AEXjMIWi9h735t9fCClok w4GoeocCOgHlnJmu528kOYE/oiAkWAYxAI6Y7raniafeSWosFdzztCrblS+0vIaB14JI eiQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ku7-20020a170903288700b0019cd5aec725si3868505plb.555.2023.03.02.06.52.25; Thu, 02 Mar 2023 06:52:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229562AbjCBOs7 (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230120AbjCBOrz (ORCPT ); Thu, 2 Mar 2023 09:47:55 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B2753C32 for ; Thu, 2 Mar 2023 06:47:53 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDg-00045Y-9l; Thu, 02 Mar 2023 15:47:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDf-001Lsj-1f; Thu, 02 Mar 2023 15:47:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDe-001Zqz-A7; Thu, 02 Mar 2023 15:47:42 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 27/29] platform/x86: serial-multi-instantiate: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:30 +0100 Message-Id: <20230302144732.1903781-28-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1609; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=zZdMBuHYK98FB0/gRnuDVS6LFfhuk4IBzInMCTmznJA=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALb1rvceOGPBsIzcSYQ/ZFLJcwFZMlPe0/ZcU 7fMoesuAWWJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC29QAKCRDB/BR4rcrs CS7/B/0bdPvjYrFNATZEQCmNbthFqiFhuxnRTvZN+E0wDqVtaT2CbcJSjHSy3aohyBK95vdj9/R 7WuH6QrYjEgh2JhkBIABMfcFNX9WW0Bu2vB7CO9Lix4idGxV2eb7BgMrVZoB5Cc21FtRULd9OnZ KmttsreCmRbBoyH5VOyaM89tAtbVBvrhTrXBA/tXOjQRqEHOtnX+WoeJfMXvfGEunRllDOM45H+ 7QpuQlnuwk1B46v2MB0z4MyFg0orhkS5YFbsUIrJ5talKoynhSlIENRpc0n/ondSjv4bmBUL7Nf MQhlA9LWraaOMM7XWp194iNSAvfVQWGF3JpjriASL0NVMcF/ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268054996020717?= X-GMAIL-MSGID: =?utf-8?q?1759268054996020717?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/serial-multi-instantiate.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/serial-multi-instantiate.c b/drivers/platform/x86/serial-multi-instantiate.c index 5362f1a7b77c..cd25125b7923 100644 --- a/drivers/platform/x86/serial-multi-instantiate.c +++ b/drivers/platform/x86/serial-multi-instantiate.c @@ -265,13 +265,11 @@ static int smi_probe(struct platform_device *pdev) } } -static int smi_remove(struct platform_device *pdev) +static void smi_remove(struct platform_device *pdev) { struct smi *smi = platform_get_drvdata(pdev); smi_devs_unregister(smi); - - return 0; } static const struct smi_node bsg1160_data = { @@ -339,7 +337,7 @@ static struct platform_driver smi_driver = { .acpi_match_table = smi_acpi_ids, }, .probe = smi_probe, - .remove = smi_remove, + .remove_new = smi_remove, }; module_platform_driver(smi_driver); From patchwork Thu Mar 2 14:47:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63462 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4274623wrd; Thu, 2 Mar 2023 06:53:57 -0800 (PST) X-Google-Smtp-Source: AK7set8t71rcBxZuRkwDWbhOJULuFTWzUl+YBlqLoBk+8FX38HPRqCNjDgeVKeg00WJ6j+O+w5CX X-Received: by 2002:a17:90b:380d:b0:233:d870:f4c7 with SMTP id mq13-20020a17090b380d00b00233d870f4c7mr11945807pjb.21.1677768837291; Thu, 02 Mar 2023 06:53:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768837; cv=none; d=google.com; s=arc-20160816; b=AR/y0evvUjMuaoMJhjCNmLiuh7Ce42vly80TCO6N130jZiOKK9dzbGDu4UAIxhFHWV d5p67CzrElFghERIxMfw+NIIgNTJGfwUIi0QYp6KEgG2Ww8XHJfRdyniyaQC/dRGdOPg gm4LcGBucOX3Hag70XFRc2ooxuYKxWku3NQMCHM3FczwVJcysE/IzcLMMF05cY9YMaHR XSXhozsxIs2mTpWKJBOCLgLySn019OmeHyMha767wHY/GWSf2mOVPn9txhgqlF9O/f+7 2MHwa3ROMocO6dpliEowTOYASSSnBokL1sUMXqnVe5VgEmFzn77AthLJyc1GkbyNLoMD qKqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8t08oDY0WNxKbi2c/hH6mL38g0yedTCtRnd3w4C2NEM=; b=yh+SvQUdQlh0IQ0Ff7bovYHHgyWpre4E2cEz2QljdLJpCswprZ2N9Eu1rZW+fzIbFD u74fz46S3J8Yi9pEtDhRZixyp/J+xTaCnoTm1juWif8vOIgFG1/S2aZQ5Ed7LY3btZI6 +QGE/PjzkY0+j6AP697X5pkRcdJ8BiojsLgTdYt2Zl1TZtfmNy16WXhe5qdxRbYCy04h ppfDYDYz/TSLOI2IuWZsGGd4YD0mQUWDWasQN4pg5tpSVv5OcsMGjehkvTMIF8J8m7Xa pWyLESysuEDEly4w1aihMDEMFRCaSkyJ1K6LiYG0ZmhgAxtUOpmR8Dj2ksBzUc7vYDmD L1cA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id em9-20020a17090b014900b00233dc512717si2374609pjb.65.2023.03.02.06.53.43; Thu, 02 Mar 2023 06:53:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230315AbjCBOtM (ORCPT + 99 others); Thu, 2 Mar 2023 09:49:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230137AbjCBOr6 (ORCPT ); Thu, 2 Mar 2023 09:47:58 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 978AD4215 for ; Thu, 2 Mar 2023 06:47:54 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDg-00046X-MP; Thu, 02 Mar 2023 15:47:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDf-001Lsv-Ep; Thu, 02 Mar 2023 15:47:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDe-001Zr7-Gn; Thu, 02 Mar 2023 15:47:42 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 28/29] platform/x86: wmi: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:31 +0100 Message-Id: <20230302144732.1903781-29-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1794; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=vINht6ojUFDqgv3t7NnT5jRF+UmY6wpfnULDkHfIdto=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALb6O68NAGyM825FA1GeI2kBnh4ZSeuQ+fR2u yAw6iq7r0eJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2+gAKCRDB/BR4rcrs Cc+XB/4lFYU8LTWGolMf3K0oUcggqVhrI+67SZELHpQlMDMfyWJX+LlcPKRSZmvYs3Q6T2nehtt JIJUBYSnoVPqTE/SpLPCR3cwK3rajXld6eDxKP1jX7ObtBVTaUK9nEuttiC+gsxjIiYp/Xzh9H9 2SncwaWdNIS0TWl5EwEm2mmtNH2mHdSxziFo70KxABJof7BJSBnsh/M9AIQgodLKhZeJ9/9IxOU F1z3xN45EF+Q7ukBSHC8Z5XKpfDJKoWYp/9DPg9WQEePE5MLfXUBKPw7MjooXPou9KX/1KMcf3j zZ1oPMkLQtH8l7H8MyZiUUl+DKDl72tGf8e1+m3sPI3EU3BQ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268136415959405?= X-GMAIL-MSGID: =?utf-8?q?1759268136415959405?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/wmi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 4fe7650dd014..d81319a502ef 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -1369,7 +1369,7 @@ static void acpi_wmi_notify_handler(acpi_handle handle, u32 event, event, 0); } -static int acpi_wmi_remove(struct platform_device *device) +static void acpi_wmi_remove(struct platform_device *device) { struct acpi_device *acpi_device = ACPI_COMPANION(&device->dev); @@ -1379,8 +1379,6 @@ static int acpi_wmi_remove(struct platform_device *device) ACPI_ADR_SPACE_EC, &acpi_wmi_ec_space_handler); wmi_free_devices(acpi_device); device_unregister(dev_get_drvdata(&device->dev)); - - return 0; } static int acpi_wmi_probe(struct platform_device *device) @@ -1468,7 +1466,7 @@ static struct platform_driver acpi_wmi_driver = { .acpi_match_table = wmi_device_ids, }, .probe = acpi_wmi_probe, - .remove = acpi_wmi_remove, + .remove_new = acpi_wmi_remove, }; static int __init acpi_wmi_init(void) From patchwork Thu Mar 2 14:47:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63446 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273807wrd; Thu, 2 Mar 2023 06:52:02 -0800 (PST) X-Google-Smtp-Source: AK7set/BpF2w/DyMuCjSr9KuN9/z3FN1sLIihdxekhivRhMBG/8UtXrAXmEeGJvTdVBHjbXTwGSS X-Received: by 2002:a17:90a:c402:b0:229:2427:532f with SMTP id i2-20020a17090ac40200b002292427532fmr11377810pjt.40.1677768721820; Thu, 02 Mar 2023 06:52:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768721; cv=none; d=google.com; s=arc-20160816; b=k4Tl2GHt7hYIJPyu561hF0IIrhofd3KWA0xbZbqb8Nh6P5NfIGgKlTt84km1yo3XGk LtdLLT5a7D5wJSwN5o3F/f4nMhPRYJ3mt9n+q6u0iVFEv14ZoqObfLUlPPiG0egWlPFM Q3eluSjBZGsuF/x9AuhAtfB6Lg9V4G3Vv1tWc1N44Q0rnAnuQaC3fRUH4MZKoYle2r4j xSQGFK3m2iWlc3i+Kayo3lDXGkd6J+hy+ZKJF6o1inpyULaqzeke4YCJsjCpFPmMpJwA DNYiGns40BOr85ZYCeODLSlCGoxwT/SxymJNLZaaemzbMPSFfk6Bb3KUqXnC88h9o6U9 ujFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=4L0L8ghCSZWApbx2kvJ/01qrkg4azrl2K7hak1CwCvs=; b=pWquxXRO8ZNLfM3zv+I9N0AVTxZxyEMg3+TgWInhxADFOBXV4gI1G00wQz/DPc2ObX 3R1u1ZBrvZK0thy7qHOb2pVIG1Hrs4KgxomkdY4cyNQXKI4w4SGYbYBXQwFxZQVxG4+F QSCu69vWc+rK0YEF/3S5ALWCq1F4QxItWE4x63rxVQk027Ade22F//piOXALuhv3e+3D q8ldVOKQYEH8pKDxMLrAbg8KrF+vP7ALEHsXZbXaEkjmAKx4MwTEBshCyoMWdKIsmDVk 4qT58A+aftXcuiUDMTRNLojTHjXp+GJZVnnaTTbmA37L+PjD+9/Y/CXkZea7xVUwor/d Y6hw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hi16-20020a17090b30d000b00233ebd4c537si2504633pjb.22.2023.03.02.06.51.47; Thu, 02 Mar 2023 06:52:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230274AbjCBOsy (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbjCBOrz (ORCPT ); Thu, 2 Mar 2023 09:47:55 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2098755B7 for ; Thu, 2 Mar 2023 06:47:53 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDg-00047D-P2; Thu, 02 Mar 2023 15:47:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDf-001Lsy-K7; Thu, 02 Mar 2023 15:47:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDe-001ZrA-PF; Thu, 02 Mar 2023 15:47:42 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 29/29] platform/x86: xo1-rfkill: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:32 +0100 Message-Id: <20230302144732.1903781-30-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1613; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=/cHo/OCIZQ5qmf/ucqmCGmO1pyy35MQ6zTCo8fFg0vg=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALb+CScRPFDRsjjCksIWibKoudblETkcH6IrZ Xb/qz0BJV+JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2/gAKCRDB/BR4rcrs CVFdB/90zGKMc6uqyCIs6l3icW8VpmwLQ0oPsoq8vzU3e8rzwoxbZmGuMlA9aeLsDqh4UivkfAq jzRjdEEYrK3z9DuxGFmpqHVgF7DZom3ovHvfEQ/ScVj8RGrWOYuOKZLg4z6tQGzfKC948MaN8VT VlUmToaVFtPkNyl4VG9F3AocSbCEmeurnTE2GtEBIdu9pGx14HkfPRhD2d395XPjujV5N0I1HBe WFxgUGcISQgdcO9A4z+DVCSnX7G1IHR+2+hd9E7eB/a4CgWo2eJTS5iWdzRgdbBeoFnN2NOsVuz Z4vusWPbWzzmmMXYf4xe1K+5KfY/vY6RFIgbj7Kxr7HWPMLx X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268015052902566?= X-GMAIL-MSGID: =?utf-8?q?1759268015052902566?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/xo1-rfkill.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/xo1-rfkill.c b/drivers/platform/x86/xo1-rfkill.c index cb3253c10ef3..e64d5646b4c7 100644 --- a/drivers/platform/x86/xo1-rfkill.c +++ b/drivers/platform/x86/xo1-rfkill.c @@ -56,12 +56,11 @@ static int xo1_rfkill_probe(struct platform_device *pdev) return 0; } -static int xo1_rfkill_remove(struct platform_device *pdev) +static void xo1_rfkill_remove(struct platform_device *pdev) { struct rfkill *rfk = platform_get_drvdata(pdev); rfkill_unregister(rfk); rfkill_destroy(rfk); - return 0; } static struct platform_driver xo1_rfkill_driver = { @@ -69,7 +68,7 @@ static struct platform_driver xo1_rfkill_driver = { .name = "xo1-rfkill", }, .probe = xo1_rfkill_probe, - .remove = xo1_rfkill_remove, + .remove_new = xo1_rfkill_remove, }; module_platform_driver(xo1_rfkill_driver);