From patchwork Thu Mar 2 03:36:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bumwoo Lee X-Patchwork-Id: 63185 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4023173wrd; Wed, 1 Mar 2023 19:44:41 -0800 (PST) X-Google-Smtp-Source: AK7set/wdbTvXE0dkUymiGWdjCKffP0JT5iO2zMy1BNXGgO7TZLU3Q493ug+bpyulfEQH2XZVsVv X-Received: by 2002:a17:906:9515:b0:8b1:781d:f9a4 with SMTP id u21-20020a170906951500b008b1781df9a4mr10664669ejx.21.1677728681538; Wed, 01 Mar 2023 19:44:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677728681; cv=none; d=google.com; s=arc-20160816; b=x1jdrMaypY3kgC7SHZfGpNcdrhXw3SBVLmsVr1xmTFlk6qNIINTnHe/40Ojxlh85Sq UKVBLArzk68lVxEwBnQSmE+kulSvtbtE/5nnjBLC8TFZ/PHhw2877yxuVBkMPT38NGau pJxpiJWh4bHQsHHFBLc2ajAa7efWW5qQz3m6wGzVAK/gIMruaQusoDV+tHsIPZXEqmno 9z7eS+z3AOGIt45g+G3ZYqDeAqXRwiADg6I2eiQaFuAKza70M0dcPkVmvZU2ZJLK6t46 CregvIEy/XIQ19ZpMqtRWMYv9yhxHqbdw662mvyCYpE4CiXaXT2SkGC9A1xwOV7zU+c8 mc8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:mime-version:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=TTV8W6gw3S+wohmFfLikBMFap7zij34yNhu2CdJ/iUI=; b=ZxPpxwR9t+TJMzU6NCjjExJdnGIMEPgYE7FhBxsQH8KJz5s4Vin0fIA1ecdjM8EY8W y8Q2giQdSHgP7Yl3QPW+QCgE6fatd2pi5ynLtwCaAlVfvZWXxDODWwnr9OX7Jz9hxgMr MuPqq6tIQNLFG40xAunTwfPg4A7oN6l4E8X75Kxa2iHmpE81Z9oseH3vKDOOis+zbxvV RHZXrWLJWNHF2x+NmV64FTSb6nbG+Ph93MBupsXKnuiGTrDOID9+bvBHrEyr0OCahBKQ DSdtZ3egR4JIPoK0znc2KGYGMumtmcNoddak2dQ95eg83CAQC6qwgx48A7Z6f5vKORnM siAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=RW50KQdt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kl11-20020a170907994b00b008e41fc88f2asi3871226ejc.385.2023.03.01.19.44.12; Wed, 01 Mar 2023 19:44:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=RW50KQdt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229670AbjCBDhH (ORCPT + 99 others); Wed, 1 Mar 2023 22:37:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbjCBDhG (ORCPT ); Wed, 1 Mar 2023 22:37:06 -0500 Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFC8F3BD8E for ; Wed, 1 Mar 2023 19:36:54 -0800 (PST) Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20230302033651epoutp04397de9bf810302d72508ffc08269ea85~IfOt4P5bN2276622766epoutp04s for ; Thu, 2 Mar 2023 03:36:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20230302033651epoutp04397de9bf810302d72508ffc08269ea85~IfOt4P5bN2276622766epoutp04s DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1677728212; bh=TTV8W6gw3S+wohmFfLikBMFap7zij34yNhu2CdJ/iUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RW50KQdttHWKnUVbDLpAn2Aamn9+A2dWyo+Pz8+oxb8u4ZP1gWLoCaYY1OflOwqzs VaUZUc4Dy6+Vd/gSDyme+HwCvxaYsiDPsm89fvNU5nfv9tRu3XW+iLXqN/Cp8jyCSC VaQg0E6jHbS/2sTRJphNUT/q4yNCVOZAqERf42PE= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20230302033651epcas1p3119e36fd81b3c182c2e73086635400e6~IfOtnF3mB2217022170epcas1p3Q; Thu, 2 Mar 2023 03:36:51 +0000 (GMT) Received: from epsmges1p1.samsung.com (unknown [182.195.38.240]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4PRxc301Grz4x9Q8; Thu, 2 Mar 2023 03:36:51 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p1.samsung.com (Symantec Messaging Gateway) with SMTP id 69.AA.55531.2D910046; Thu, 2 Mar 2023 12:36:50 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20230302033650epcas1p492dbeedda48fc2d18af86cfd0c1f77a6~IfOslVrBa3273032730epcas1p4e; Thu, 2 Mar 2023 03:36:50 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230302033650epsmtrp2aeaa177d0ee2fecf847c50eaf80778c6~IfOsku_BH2079320793epsmtrp2D; Thu, 2 Mar 2023 03:36:50 +0000 (GMT) X-AuditID: b6c32a35-d9fff7000000d8eb-f9-640019d235d1 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 85.90.05839.2D910046; Thu, 2 Mar 2023 12:36:50 +0900 (KST) Received: from VDBS1418.vd.sec.samsung.net (unknown [168.219.244.30]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230302033650epsmtip28e209f832f4b265d527f5197ad012f0b~IfOsWWdbk2452424524epsmtip2V; Thu, 2 Mar 2023 03:36:50 +0000 (GMT) From: Bumwoo Lee To: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: Bumwoo Lee Subject: [PATCH v3 1/4] extcon: Removed redundant null checking for class Date: Thu, 2 Mar 2023 12:36:42 +0900 Message-Id: <20230302033645.23933-2-bw365.lee@samsung.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230302033645.23933-1-bw365.lee@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDKsWRmVeSWpSXmKPExsWy7bCmge4lSYYUg0drrCxOrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUdk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6 hpYW5koKeYm5qbZKLj4Bum6ZOUCLlBTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2SqkFKTkF ZgV6xYm5xaV56Xp5qSVWhgYGRqZAhQnZGes+vWIq+MdZsf35K9YGxmkcXYycHBICJhINPyYw dzFycQgJ7GCUeD/1JCOE84lR4ujnw+wQzjdGifOHN7HDtNxed44NIrGXUWLKuxtQLb8YJaZN 6mADqWIT0JDYc7EByObgEBEolDjcnw0SZhZQk3iwaiPYIGEBT4kjHw4wgtgsAqoSaxZ3gtm8 AlYSGxouMEMsk5fo/veHBcTmFLCW+Pb2BztEjaDEyZlPWCBmyks0b53NDLJKQmAbu8ROU4hW F4kJ3cegxghLvDq+Bep+KYnP7/ayQdjpEiuv3IGK50i8vt/OCGEbS7x7uxZsJLOApsT6XfoQ YUWJnb/nMkJs5ZN497WHFWIrr0RHmxBEibJE94MXTBC2pMTip3egJnpIdF64Ag3oPkaJqXuW sE5gVJiF5JlZSJ6ZhbB5ASPzKkax1ILi3PTUYsMCQ3j8JufnbmIEJzst0x2ME99+0DvEyMTB eIhRgoNZSYR34e0/yUK8KYmVValF+fFFpTmpxYcYTYFBPZFZSjQ5H5hu80riDU0sDUzMjEws jC2NzZTEecVtTyYLCaQnlqRmp6YWpBbB9DFxcEo1MO1bkyuT0vXrbt1Z/8yzOYePMkhcWZJ+ KFfg12MzQ/sPGyqn994LmRLAMu/PValCg8boC6LnrzNrZK2p4RTMWN7IHWGz1WrP9ke3FlTV pf1ymRcTdXy+oqRnPce/GSpVf1afYpux56/fBdXPPjO8r/eEXH69/vH5jGU6EppeD+LU7s5d Yszp8flfn9NcVZGGzAUfuvzOzLZYX93XPm1G2gnf1JL8FX7/xP7ddjnJy6cqu6TBVLerXPlS fr7HLes2hj8WcoFmk48W3Fmd/XlG6h2lBJf7B5gszYNFXsV+1LEND2NSeVD6xHK7uuFUYSs1 x93JAp3KmWz5NwwP7e1uVpS/u81FkKNP2uHJoRPcSizFGYmGWsxFxYkA8+UQe/8DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBLMWRmVeSWpSXmKPExsWy7bCSvO4lSYYUgxv/pSxOrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUVw2Kak5mWWpRfp2CVwZ6z69Yir4x1mx/fkr1gbG aRxdjJwcEgImErfXnWPrYuTiEBLYzShx48gKZoiEpMTZ5Y/Yuxg5gGxhicOHiyFqfjBKHN/S B1bDJqAhsediAxuILSJQLHHhwGIWEJtZQE3iwaqN7CC2sICnxJEPBxhBbBYBVYk1izvBbF4B K4kNDRegdslLdP/7A9bLKWAt8e3tD7BeIaCaPYt6mSHqBSVOznwCNV9eonnrbOYJjAKzkKRm IUktYGRaxSiZWlCcm55bbFhgmJdarlecmFtcmpeul5yfu4kRHJhamjsYt6/6oHeIkYmD8RCj BAezkgjvwtt/koV4UxIrq1KL8uOLSnNSiw8xSnOwKInzXug6GS8kkJ5YkpqdmlqQWgSTZeLg lGpgWnNwUQv/ghfrpqXf7eJ8pM9dszw9WcYk7s20tshHMbbs11IXMDluLjn80NeGieP63HrV M0bSU3I111UZmzhciLDLSRNbIVlv853X79Pebq5vT47r6EnrTRAUPGDYstSjb0mTs4q7wx/5 mWk3jJ6fqizcUi34yNvj0YkvV+7N3BK4br5JQH/cf6Ujb5t/FVhsFZ97fNnC+I4SEYnMGhGv VW8DO9rF9eNV5LXCkx7/Ma2c/46XubDtgOrjfaqtRlNivWfe0rHrP2ar+G8jd9SH6Ne1ci3P jV5mz96+x8244x1nnORuQTnB1l/ioncMFdoWbHA1kytjku8sct1lXR6WLs0SWP01KWihn0z/ bCWW4oxEQy3mouJEAOZGZb+7AgAA X-CMS-MailID: 20230302033650epcas1p492dbeedda48fc2d18af86cfd0c1f77a6 X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230302033650epcas1p492dbeedda48fc2d18af86cfd0c1f77a6 References: <20230302033645.23933-1-bw365.lee@samsung.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759226029907242790?= X-GMAIL-MSGID: =?utf-8?q?1759226029907242790?= create_extcon_class() is already Null checking. Signed-off-by: Bumwoo Lee --- drivers/extcon/extcon.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index e1c71359b605..adcf01132f70 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1012,12 +1012,13 @@ ATTRIBUTE_GROUPS(extcon); static int create_extcon_class(void) { - if (!extcon_class) { - extcon_class = class_create(THIS_MODULE, "extcon"); - if (IS_ERR(extcon_class)) - return PTR_ERR(extcon_class); - extcon_class->dev_groups = extcon_groups; - } + if (extcon_class) + return 0; + + extcon_class = class_create(THIS_MODULE, "extcon"); + if (IS_ERR(extcon_class)) + return PTR_ERR(extcon_class); + extcon_class->dev_groups = extcon_groups; return 0; } @@ -1088,11 +1089,9 @@ int extcon_dev_register(struct extcon_dev *edev) int ret, index = 0; static atomic_t edev_no = ATOMIC_INIT(-1); - if (!extcon_class) { - ret = create_extcon_class(); - if (ret < 0) - return ret; - } + ret = create_extcon_class(); + if (ret < 0) + return ret; if (!edev || !edev->supported_cable) return -EINVAL; From patchwork Thu Mar 2 03:36:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bumwoo Lee X-Patchwork-Id: 63186 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4025039wrd; Wed, 1 Mar 2023 19:51:26 -0800 (PST) X-Google-Smtp-Source: AK7set/Jfcz9dAf+3NY8ITbnEg/MuFEhWcHJyJJBcbCdtn2vHyTUNjrisDkdUVc1LPKgerRe/jp+ X-Received: by 2002:a62:17cb:0:b0:593:d2ab:fdfb with SMTP id 194-20020a6217cb000000b00593d2abfdfbmr8643457pfx.13.1677729086565; Wed, 01 Mar 2023 19:51:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677729086; cv=none; d=google.com; s=arc-20160816; b=fpN0pzb1qL1kTyV0xhVIg3dbdoRwGdYciFNacNZi5gdT0Jq9M80u9plP2Zt0376iPB ccPnq3raGz2H0N8jmY0ByOSntcAeYp4pFpVpIVWyL+BN5u8Wea/us1qbIUDSrhvxS825 wbDCIdyryyrC4MyDGWtCHpp1rzfHg21p69SMehuGuABncchFzOtVfn8jSt+YsyJfXSub tyZAHUoCuUqKGw0Lk4k9+HFnAF1TiFFNp8eAsiM05ntwcG/1LjH36+vFod0zNMVW2BJy x5g/S30JBjVWzhUVFip3qy6BRHaNQ3fpHO0D8EQeh1u3XkIJppjQGsqO4Qxi9Z7fDuBE VIxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:mime-version:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=1cwJno1hlXheXEGAd0wLxvI6V4+ez9OblOIQdaj2Jkw=; b=FAQSkw7TEznHDiANp1ujb/EEPMnEoelfMs0X50CyJ61jbCb0GFImj2jMD3SCZd+30O UyEtfbnQlQ3kQq69SSE/pPfwnXnN24V0kRUFe/ktRipsuadgQQhGOgeRwXfTw8IyNyNj 0u5nX/eP+7g2lMEjP6UYSAaNmK9z/I/s3aCgsfu7zE82DEG+VJx7hcYCMSEgDw2E5p0y R0XtzB3zNNPMjGB1v+KebaEEfJPkGEv2qOZTTJFQkOjEGJmrRhvPTSoTbQLzsXMSNww0 y0lzXaeHZ0uEpkp0TxR+Adl13koPbaAjWYi3Fyz2FB9g9cSJ/3GK3ENyQwov/1GKJzyr 0/+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=GPxLpRVe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b125-20020a62cf83000000b005ecf91666b8si11963419pfg.184.2023.03.01.19.51.11; Wed, 01 Mar 2023 19:51:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=GPxLpRVe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229892AbjCBDhS (ORCPT + 99 others); Wed, 1 Mar 2023 22:37:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbjCBDhI (ORCPT ); Wed, 1 Mar 2023 22:37:08 -0500 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA0A9515EB for ; Wed, 1 Mar 2023 19:36:54 -0800 (PST) Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20230302033652epoutp031148f5e0b51e3d760f64bd94f1269dda~IfOuAMKY21564315643epoutp03h for ; Thu, 2 Mar 2023 03:36:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20230302033652epoutp031148f5e0b51e3d760f64bd94f1269dda~IfOuAMKY21564315643epoutp03h DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1677728212; bh=1cwJno1hlXheXEGAd0wLxvI6V4+ez9OblOIQdaj2Jkw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GPxLpRVe1i9tIuZX30zS8hKAfIfidnTotDLMMb/za+6i0x6Ip9P17rkTllKLXpyyI rW/+qMmpZ8/MIApxKRyWBAnEPBclj8ZzjuV2UeBs8uOv+j9aIpOwhM/lEu1Vp6Fm03 X2uDwhckcVaNJWRaLQ6yo8ktnKzxDEQxSkmtXZdY= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20230302033651epcas1p4b1702e913fe60b1704cb59ff54fcbfa4~IfOtwYEwH3274032740epcas1p4S; Thu, 2 Mar 2023 03:36:51 +0000 (GMT) Received: from epsmges1p1.samsung.com (unknown [182.195.38.250]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4PRxc26PxSz4x9Q8; Thu, 2 Mar 2023 03:36:50 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p1.samsung.com (Symantec Messaging Gateway) with SMTP id F8.AA.55531.2D910046; Thu, 2 Mar 2023 12:36:50 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20230302033650epcas1p4e59c767f76b459c2e6b9969dfe27cda1~IfOsjs3g70855008550epcas1p4e; Thu, 2 Mar 2023 03:36:50 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20230302033650epsmtrp11e7faf8e99a4cac32b5a6ff01d951487~IfOsjGJUw2681726817epsmtrp1_; Thu, 2 Mar 2023 03:36:50 +0000 (GMT) X-AuditID: b6c32a35-d9fff7000000d8eb-f7-640019d22019 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id F9.7F.17995.2D910046; Thu, 2 Mar 2023 12:36:50 +0900 (KST) Received: from VDBS1418.vd.sec.samsung.net (unknown [168.219.244.30]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230302033650epsmtip27d9d65a00886e1dbed3faae1d92302be~IfOsaYUIA2452424524epsmtip2W; Thu, 2 Mar 2023 03:36:50 +0000 (GMT) From: Bumwoo Lee To: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: Bumwoo Lee Subject: [PATCH v3 2/4] extcon: Added extcon_alloc_cables to simplify extcon register function Date: Thu, 2 Mar 2023 12:36:43 +0900 Message-Id: <20230302033645.23933-3-bw365.lee@samsung.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230302033645.23933-1-bw365.lee@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNKsWRmVeSWpSXmKPExsWy7bCmnu4lSYYUgzvHDC1OrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUdk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6 hpYW5koKeYm5qbZKLj4Bum6ZOUCLlBTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2SqkFKTkF ZgV6xYm5xaV56Xp5qSVWhgYGRqZAhQnZGa9uWhU8lqvo2X2BrYHxjkQXIyeHhICJxLfmqYxd jFwcQgI7GCXur38F5XxilNjWdZ8NwvnMKPGoYQI7TMv1GZPYIRK7GCXuzn/ADOH8YpT4cP8f C0gVm4CGxJ6LDUDtHBwiAoUSh/uzQcLMAmoSD1ZtBBskLJAgsevoQjYQm0VAVaK1YQUriM0r YCVxbvE/Johl8hLd//6AjeQUsJb49vYHO0SNoMTJmU9YIGbKSzRvnc0MUb+LXeLnVgEI20Vi 0/UNjBC2sMSr41ugHpCSeNnfBmWnS6y8cgfKzpF4fb8dqt5Y4t3btcwg5zMLaEqs36UPEVaU 2Pl7LiPEWj6Jd197WEFKJAR4JTrahCBKlCW6H7yAul5SYvHTO4wQJR4SP+5mQgKqj1GiY18b 2wRGhVlInpmF5JlZCIsXMDKvYhRLLSjOTU8tNiwwhEdvcn7uJkZwqtMy3cE48e0HvUOMTByM hxglOJiVRHgX3v6TLMSbklhZlVqUH19UmpNafIjRFBjUE5mlRJPzgck2ryTe0MTSwMTMyMTC 2NLYTEmcV9z2ZLKQQHpiSWp2ampBahFMHxMHp1QDU+vGhZ+SHs3UFFjsluMrkyMxac5sjnlz kxct67pa22H8b2aI6bfr+gc3NGrWR/xdsEPsd0K6+oaaSM6nSipLbxyv0Vi37urGV2Fbb1bM uHtuTkl/++LmnZ9uqBm1LVV5uY9p+WU/F7X88ttLFtQoF35MeeMQ/OK5cF6stMEE9zXmlTJn 5zBOtXC1+9S06nnFpRnOK8wcRdgS8p72HLsdJTxlzW62ZLtdXp+f/Dav2Pq1koOn/MgBk/M8 X2dK7HA8YNbQf2vJiv8TnjtXLZ/0LUWJg5EjIEZ9ptXfCR9YZ/idCri+ROYt+4sl5Wc1ArqL el5MeX6Fwzi/++Wnta6h3135f8/8bnvlkPxczs1iUwOUWIozEg21mIuKEwGNbCra/gMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOLMWRmVeSWpSXmKPExsWy7bCSvO4lSYYUg2N/ZSxOrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUVw2Kak5mWWpRfp2CVwZr25aFTyWq+jZfYGtgfGO RBcjJ4eEgInE9RmT2LsYuTiEBHYwStx4/YEdIiEpcXb5IyCbA8gWljh8uBii5gejxIWHO5lA atgENCT2XGxgA7FFBIolLhxYzAJiMwuoSTxYtRFsjrBAnMTj8y1gNSwCqhKtDStYQWxeASuJ c4v/MUHskpfo/vcHrJdTwFri29sfYL1CQDV7FvUyQ9QLSpyc+QRqvrxE89bZzBMYBWYhSc1C klrAyLSKUTK1oDg3PbfYsMAoL7Vcrzgxt7g0L10vOT93EyM4LLW0djDuWfVB7xAjEwfjIUYJ DmYlEd6Ft/8kC/GmJFZWpRblxxeV5qQWH2KU5mBREue90HUyXkggPbEkNTs1tSC1CCbLxMEp 1cCkHLz/e0TkjKSu+dFNZSc7W/g/lLTa5ty86ubgfNmn6shaxxtNiuw/b3hc9epTX6eV8JfJ su63hJa/zf1HL6XCLm3p/u16JTrxz/28y28jVJe2SSuouDHImP66Wv2XZ13OSacZj8Pf7Gvd N+Uk5wuR55uWz6kr9WbVtT9ekiatbyjrtrhSh5kzh/XgGtcpNr0Pltaov/AW3Vi20XXPxtUm Ipvnb94xc338N+8fbccybeUPhJhP4co0PN13MfCPHWtOVpKg6VmlrrZp/95Nln/28MWOp3ny mrcCr/JJvddpmvDk1c2bD/kPsthurGer2+8ssrL+wv15Pfe2KJ57vV5Ton1v+kE1sYa7N1Ze kG5RYinOSDTUYi4qTgQArVOTmroCAAA= X-CMS-MailID: 20230302033650epcas1p4e59c767f76b459c2e6b9969dfe27cda1 X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230302033650epcas1p4e59c767f76b459c2e6b9969dfe27cda1 References: <20230302033645.23933-1-bw365.lee@samsung.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759226454808875340?= X-GMAIL-MSGID: =?utf-8?q?1759226454808875340?= The cable allocation part is functionalized from extcon_dev_register. Signed-off-by: Bumwoo Lee --- drivers/extcon/extcon.c | 106 +++++++++++++++++++++++----------------- 1 file changed, 61 insertions(+), 45 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index adcf01132f70..388a3d906075 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1070,6 +1070,63 @@ void extcon_dev_free(struct extcon_dev *edev) } EXPORT_SYMBOL_GPL(extcon_dev_free); +/** + * extcon_alloc_cables() - alloc the cables for extcon device + * @edev: extcon device which has cables + * + * Returns 0 if success or error number if fail. + */ +static int extcon_alloc_cables(struct extcon_dev *edev) +{ + int index; + char *str; + struct extcon_cable *cable; + + if (!edev->max_supported) + return 0; + + edev->cables = kcalloc(edev->max_supported, + sizeof(struct extcon_cable), + GFP_KERNEL); + if (!edev->cables) + return -ENOMEM; + + for (index = 0; index < edev->max_supported; index++) { + cable = &edev->cables[index]; + + str = kasprintf(GFP_KERNEL, "cable.%d", index); + if (!str) { + for (index--; index >= 0; index--) { + cable = &edev->cables[index]; + kfree(cable->attr_g.name); + } + + kfree(edev->cables); + return -ENOMEM; + } + + cable->edev = edev; + cable->cable_index = index; + cable->attrs[0] = &cable->attr_name.attr; + cable->attrs[1] = &cable->attr_state.attr; + cable->attrs[2] = NULL; + cable->attr_g.name = str; + cable->attr_g.attrs = cable->attrs; + + sysfs_attr_init(&cable->attr_name.attr); + cable->attr_name.attr.name = "name"; + cable->attr_name.attr.mode = 0444; + cable->attr_name.show = cable_name_show; + + sysfs_attr_init(&cable->attr_state.attr); + cable->attr_state.attr.name = "state"; + cable->attr_state.attr.mode = 0444; + cable->attr_state.show = cable_state_show; + } + + return 0; +} + /** * extcon_dev_register() - Register an new extcon device * @edev: the extcon device to be registered @@ -1117,50 +1174,9 @@ int extcon_dev_register(struct extcon_dev *edev) dev_set_name(&edev->dev, "extcon%lu", (unsigned long)atomic_inc_return(&edev_no)); - if (edev->max_supported) { - char *str; - struct extcon_cable *cable; - - edev->cables = kcalloc(edev->max_supported, - sizeof(struct extcon_cable), - GFP_KERNEL); - if (!edev->cables) { - ret = -ENOMEM; - goto err_sysfs_alloc; - } - for (index = 0; index < edev->max_supported; index++) { - cable = &edev->cables[index]; - - str = kasprintf(GFP_KERNEL, "cable.%d", index); - if (!str) { - for (index--; index >= 0; index--) { - cable = &edev->cables[index]; - kfree(cable->attr_g.name); - } - ret = -ENOMEM; - - goto err_alloc_cables; - } - - cable->edev = edev; - cable->cable_index = index; - cable->attrs[0] = &cable->attr_name.attr; - cable->attrs[1] = &cable->attr_state.attr; - cable->attrs[2] = NULL; - cable->attr_g.name = str; - cable->attr_g.attrs = cable->attrs; - - sysfs_attr_init(&cable->attr_name.attr); - cable->attr_name.attr.name = "name"; - cable->attr_name.attr.mode = 0444; - cable->attr_name.show = cable_name_show; - - sysfs_attr_init(&cable->attr_state.attr); - cable->attr_state.attr.name = "state"; - cable->attr_state.attr.mode = 0444; - cable->attr_state.show = cable_state_show; - } - } + ret = extcon_alloc_cables(edev); + if (ret < 0) + goto err_alloc_cables; if (edev->max_supported && edev->mutually_exclusive) { char *name; @@ -1282,7 +1298,7 @@ int extcon_dev_register(struct extcon_dev *edev) err_alloc_cables: if (edev->max_supported) kfree(edev->cables); -err_sysfs_alloc: + return ret; } EXPORT_SYMBOL_GPL(extcon_dev_register); From patchwork Thu Mar 2 03:36:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bumwoo Lee X-Patchwork-Id: 63187 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4025565wrd; Wed, 1 Mar 2023 19:53:18 -0800 (PST) X-Google-Smtp-Source: AK7set8K5m10uNybrLmWcWcp7/9HvdMRwUZaMTl6tWLOp/4YJ6P5PPHdbnUc15EtotEq/lZMEnaB X-Received: by 2002:a17:90b:4ad1:b0:234:1a60:a6b0 with SMTP id mh17-20020a17090b4ad100b002341a60a6b0mr10389065pjb.34.1677729198515; Wed, 01 Mar 2023 19:53:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677729198; cv=none; d=google.com; s=arc-20160816; b=EXdR+vnAw8bxn+GmPnKpr+KwGL3Wk99SNRPI2fIIg2NxZK6BrYWYJP+YYTn1f8+fvo 2eqkBkE9DtJMv8mek1OvXdeyq6NovD+kQuct9N+AgZg0wZ77nFgreE9GcOr3bfPOIyji g1fZhMCoQRXueLjoAxsvHruyNQT2Cp8qZe2A26/BRAsShioN2s8r33xk01dO2uLneCPB kmerLtHDuBsxSsKaIX0pkGjtf6TA3L2QQyxRXNeyKNkFN+KGqybn/pjtH/wxNSVisWEq TdSE2Xcpmc/G/HhcWA8DuJHtrpoEz+E5i5v9WKQ6BBrVAgqobh430NdwBcV6bsTJV5Mm 7LGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:mime-version:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=RlkHcGEoE1hG3usQpYe+zNFdCyZiaVIU2Mr4u85JovI=; b=R20aM+qYg+5LvMT4EzggK0TZrlLmV5nRCJ1B8M73lagn9V54e5vcVS14F3vznA5zeW xKi9bxtpnBUP+MRr2ZfScJwCr2dgDTheVc1QyjMZ+jo5p0959+FZlsObZFrbKS9FQykd kRNTqI5ZqK0ByIe9DCamg68KV5N2tz4X6Oi1uzc2On2z44NCu2Kl2PAIq+5rDoj8tcDk fMdVHXPc8yrYJVeNN5PNQ5/V5XLBVkaEUoRRwImfI7FZpHrsRJ6tIEs0sem3palifouy QYmIYJV/SQbxt9C8d1/EO4ip50WjncErkXlANO2NsfWTx9gKUGNaTm2x/8prXl2CMRIH f+yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=iocjsdUH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a30-20020a630b5e000000b0050017d1b7c6si9657518pgl.767.2023.03.01.19.52.57; Wed, 01 Mar 2023 19:53:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=iocjsdUH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229852AbjCBDhM (ORCPT + 99 others); Wed, 1 Mar 2023 22:37:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbjCBDhH (ORCPT ); Wed, 1 Mar 2023 22:37:07 -0500 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C096D515CB for ; Wed, 1 Mar 2023 19:36:54 -0800 (PST) Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20230302033652epoutp01da5b06316e1a1a95952a8f144abe9844~IfOuMKYmI2023720237epoutp01k for ; Thu, 2 Mar 2023 03:36:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20230302033652epoutp01da5b06316e1a1a95952a8f144abe9844~IfOuMKYmI2023720237epoutp01k DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1677728212; bh=RlkHcGEoE1hG3usQpYe+zNFdCyZiaVIU2Mr4u85JovI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iocjsdUH2v2JbyWF5NU76+cut4I6geF2Ec7Tx0EsJAwNCGoHup8nK8UX/U1PZGuEB U9SljoLronVktk6Mp3VgdD4sx6jVDQ/2gXHmjYojwE+R1pFVGBpcCbRIT4U7kacf1A It8NdZFdsWwcgb5Y4mRYNcWWXmwe6Jyzw4RF2SZQ= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20230302033651epcas1p263c4b0a139e0832f457b2ecead1d18ed~IfOt3akDv0032700327epcas1p2v; Thu, 2 Mar 2023 03:36:51 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.38.247]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4PRxc304Vcz4x9Q6; Thu, 2 Mar 2023 03:36:51 +0000 (GMT) Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id 39.28.54823.2D910046; Thu, 2 Mar 2023 12:36:50 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20230302033650epcas1p4b8a23f7c6a931200a9d0270cd00aaf6e~IfOsrdOw03274032740epcas1p4M; Thu, 2 Mar 2023 03:36:50 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20230302033650epsmtrp18e5a05f02fe044e531565b0b2a83cf61~IfOsq2-j52681726817epsmtrp1-; Thu, 2 Mar 2023 03:36:50 +0000 (GMT) X-AuditID: b6c32a39-a97ff7000000d627-52-640019d2e3a1 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id D5.90.05839.2D910046; Thu, 2 Mar 2023 12:36:50 +0900 (KST) Received: from VDBS1418.vd.sec.samsung.net (unknown [168.219.244.30]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230302033650epsmtip2ea7e7ef29c672c668d8833caaf4598f6~IfOscaBl72452424524epsmtip2X; Thu, 2 Mar 2023 03:36:50 +0000 (GMT) From: Bumwoo Lee To: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: Bumwoo Lee Subject: [PATCH v3 3/4] extcon: Added extcon_alloc_muex to simplify extcon register function Date: Thu, 2 Mar 2023 12:36:44 +0900 Message-Id: <20230302033645.23933-4-bw365.lee@samsung.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230302033645.23933-1-bw365.lee@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLKsWRmVeSWpSXmKPExsWy7bCmru4lSYYUg5UfTC1OrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUdk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6 hpYW5koKeYm5qbZKLj4Bum6ZOUCLlBTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2SqkFKTkF ZgV6xYm5xaV56Xp5qSVWhgYGRqZAhQnZGR/3HWMsmCtf0b7wB2sD4yeJLkZODgkBE4kTpw+z dzFycQgJ7GCUaHh2ixHC+cQocWvuPyYI5xujxMLZixhhWma9uAKV2Mso8Wj/A6j+X4wS13f3 s4JUsQloSOy52MDWxcjBISJQKHG4PxskzCygJvFg1UZ2EFtYIE6i/+9nsKEsAqoS6xdMYQOx eQWsJO5/OsMGsUxeovvfHxYQm1PAWuLb2x/sEDWCEidnPmGBmCkv0bx1NjPIDRIC+9gldm1c AHWpi0TTrHlQg4QlXh3fwg5hS0m87G+DstMlVl65A2XnSLy+3w7Vayzx7u1aZpD7mQU0Jdbv 0ocIK0rs/D2XEWIvn8S7rz2sICUSArwSHW1CECXKEt0PXjBB2JISi5/eYYQo8ZD4eEIdElJ9 jBIt2/tYJzAqzELyzSwk38xCWLyAkXkVo1hqQXFuemqxYYEpPIKT83M3MYLTnZblDsbpbz/o HWJk4mA8xCjBwawkwrvw9p9kId6UxMqq1KL8+KLSnNTiQ4ymwLCeyCwlmpwPTLh5JfGGJpYG JmZGJhbGlsZmSuK84rYnk4UE0hNLUrNTUwtSi2D6mDg4pRqY9i+z3nfn/mXfRw99D54VvH1H aX25eMiVmwJdt+YJNVzZXL9cMb/r526D1vULa97lLWZgijt263tI7dXzHWzfsiuTZjO+NT7u dNZhTn42w75bmzn3H9CuD72/T5s1uUXIxW7tA7UI8V3yv2ZHJS7e4v9LmWvt+umszad2Gk6X VTwn7N2aO1Xf3+aw6Lm8dSz7+C6//HJ6zrxX/s27PZ0DYuy8tmhsnDJvT3tuV3/6trI9KrE9 6eISdR/7pgq7Ta2pSPzSv/23JU+s29b7c67nWuWyprG8PMAmeGi578u3JyVzGW0mnPEPbXhQ UFcc+CZR+MHtn1P1m5c3Xt0w4bH57N2+U86LPbPrXqXXsPThXiWW4oxEQy3mouJEAEeKA2sA BAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBLMWRmVeSWpSXmKPExsWy7bCSvO4lSYYUg5drlSxOrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUVw2Kak5mWWpRfp2CVwZH/cdYyyYK1/RvvAHawPj J4kuRk4OCQETiVkvrjB1MXJxCAnsZpS4t3s5M0RCUuLs8kfsXYwcQLawxOHDxRA1PxglpmxY zgRSwyagIbHnYgMbiC0iUCxx4cBiFhCbWUBN4sGqjewgtrBAjMTFh3dZQWwWAVWJ9QumgNXz ClhJ3P90hg1il7xE978/YL2cAtYS397+AOsVAqrZs6iXGaJeUOLkzCdQ8+UlmrfOZp7AKDAL SWoWktQCRqZVjJKpBcW56bnFhgWGeanlesWJucWleel6yfm5mxjBgamluYNx+6oPeocYmTgY DzFKcDArifAuvP0nWYg3JbGyKrUoP76oNCe1+BCjNAeLkjjvha6T8UIC6YklqdmpqQWpRTBZ Jg5OqQYmhUKTuu19p1ZflpqYOH9ChdkkVc42yxM5Vun8O+7dkVnHH17zumKerumbqW37nzxf bZ2/y+bfsdLmfs7CiY4ayxvk9s/nvBVfadKz5JrqPruHWXKq7wtVmqYdZ37mlOvO4BcSkXVt z59VUz/NfHNo0fdpLidOXJ24oeR2VKrSpk37TFqEwqw+H/1wyXhKzNL1jjFnuDdkvlimF94b qvzBsPLe5rRCdem1OQ+a2oU+Tb9z44PFqv4jybtEb2w5viV93TZN+eYcThc1Zv/sp0s2Zdzs vLYl71x//F7ta3c72fZvf1/ctlzT6tan6pfl+jNu37wotaRcPzGSY92Bw4lLzmtyPJNuKloo rD6nUEclV4mlOCPRUIu5qDgRABII+fa7AgAA X-CMS-MailID: 20230302033650epcas1p4b8a23f7c6a931200a9d0270cd00aaf6e X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230302033650epcas1p4b8a23f7c6a931200a9d0270cd00aaf6e References: <20230302033645.23933-1-bw365.lee@samsung.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759226571931320512?= X-GMAIL-MSGID: =?utf-8?q?1759226571931320512?= The mutual exclusive part is functionalized from extcon_dev_register. Signed-off-by: Bumwoo Lee --- drivers/extcon/extcon.c | 106 ++++++++++++++++++++++------------------ 1 file changed, 58 insertions(+), 48 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 388a3d906075..287cf6568661 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1127,6 +1127,60 @@ static int extcon_alloc_cables(struct extcon_dev *edev) return 0; } +/** + * extcon_alloc_muex() - alloc the mutual exclusive for extcon device + * @edev: extcon device + * + * Returns 0 if success or error number if fail. + */ +static int extcon_alloc_muex(struct extcon_dev *edev) +{ + char *name; + int index; + + if (!(edev->max_supported && edev->mutually_exclusive)) + return 0; + + /* Count the size of mutually_exclusive array */ + for (index = 0; edev->mutually_exclusive[index]; index++) + ; + + edev->attrs_muex = kcalloc(index + 1, + sizeof(struct attribute *), + GFP_KERNEL); + if (!edev->attrs_muex) + return -ENOMEM; + + edev->d_attrs_muex = kcalloc(index, + sizeof(struct device_attribute), + GFP_KERNEL); + if (!edev->d_attrs_muex) { + kfree(edev->attrs_muex); + return -ENOMEM; + } + + for (index = 0; edev->mutually_exclusive[index]; index++) { + name = kasprintf(GFP_KERNEL, "0x%x", + edev->mutually_exclusive[index]); + if (!name) { + for (index--; index >= 0; index--) + kfree(edev->d_attrs_muex[index].attr.name); + + kfree(edev->d_attrs_muex); + kfree(edev->attrs_muex); + return -ENOMEM; + } + sysfs_attr_init(&edev->d_attrs_muex[index].attr); + edev->d_attrs_muex[index].attr.name = name; + edev->d_attrs_muex[index].attr.mode = 0000; + edev->attrs_muex[index] = &edev->d_attrs_muex[index].attr; + } + edev->attr_g_muex.name = muex_name; + edev->attr_g_muex.attrs = edev->attrs_muex; + + return 0; +} + /** * extcon_dev_register() - Register an new extcon device * @edev: the extcon device to be registered @@ -1178,53 +1232,9 @@ int extcon_dev_register(struct extcon_dev *edev) if (ret < 0) goto err_alloc_cables; - if (edev->max_supported && edev->mutually_exclusive) { - char *name; - - /* Count the size of mutually_exclusive array */ - for (index = 0; edev->mutually_exclusive[index]; index++) - ; - - edev->attrs_muex = kcalloc(index + 1, - sizeof(struct attribute *), - GFP_KERNEL); - if (!edev->attrs_muex) { - ret = -ENOMEM; - goto err_muex; - } - - edev->d_attrs_muex = kcalloc(index, - sizeof(struct device_attribute), - GFP_KERNEL); - if (!edev->d_attrs_muex) { - ret = -ENOMEM; - kfree(edev->attrs_muex); - goto err_muex; - } - - for (index = 0; edev->mutually_exclusive[index]; index++) { - name = kasprintf(GFP_KERNEL, "0x%x", - edev->mutually_exclusive[index]); - if (!name) { - for (index--; index >= 0; index--) { - kfree(edev->d_attrs_muex[index].attr. - name); - } - kfree(edev->d_attrs_muex); - kfree(edev->attrs_muex); - ret = -ENOMEM; - goto err_muex; - } - sysfs_attr_init(&edev->d_attrs_muex[index].attr); - edev->d_attrs_muex[index].attr.name = name; - edev->d_attrs_muex[index].attr.mode = 0000; - edev->attrs_muex[index] = &edev->d_attrs_muex[index] - .attr; - } - edev->attr_g_muex.name = muex_name; - edev->attr_g_muex.attrs = edev->attrs_muex; - - } + ret = extcon_alloc_muex(edev); + if (ret < 0) + goto err_alloc_muex; if (edev->max_supported) { edev->extcon_dev_type.groups = @@ -1292,7 +1302,7 @@ int extcon_dev_register(struct extcon_dev *edev) kfree(edev->d_attrs_muex); kfree(edev->attrs_muex); } -err_muex: +err_alloc_muex: for (index = 0; index < edev->max_supported; index++) kfree(edev->cables[index].attr_g.name); err_alloc_cables: From patchwork Thu Mar 2 03:36:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bumwoo Lee X-Patchwork-Id: 63188 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4026322wrd; Wed, 1 Mar 2023 19:56:02 -0800 (PST) X-Google-Smtp-Source: AK7set+HQLtE+LAKHsTCiYgJvJJr2+DH5DeGhvSnFPRAW8UgGZ7mfYR0ywVZpwQPzAbf4JSNo3v2 X-Received: by 2002:a17:903:1250:b0:19a:9406:b234 with SMTP id u16-20020a170903125000b0019a9406b234mr10456198plh.45.1677729362444; Wed, 01 Mar 2023 19:56:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677729362; cv=none; d=google.com; s=arc-20160816; b=tj9c4hYzQGwx5egzUuSJ6Sv82tBPRbPMgpBHLZJkRbeXOdMHxU2WiBvRH5Z1cNb0bX 0GScazSr1UIXyE3WLVNNwvxQyCX5YVlO1PSCoDLIOzcK9gi8ROdwYAjZZVdBTXi4dPYw CdzBAN18qantzx0zTYT1g4dFA9+U2926BVyKpjcuBjsr93HlbNH29Qjp4AzzcZlnbDvM CGKFi9gqzTkZNe75keJlPUQCDblAmK8k1ByRCvNvvlE6FZ0TpUWHKukFTSAhM1FunB/0 6iM/4xypy1x7VpwK6bcp2+aNLUo/dbAORkrywWPhbcCtjlS5YWxCXaTMnXKKdmqv3hqi duhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:mime-version:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=1dHKyuZlL0P4DI+hxJfy4whngOGz/lEMA5DJX2l/rYY=; b=vownS3XV0Px4NKHClsCMvVfrmfYCmbR+qaiNW7tfw6S+4/f0PXIWb4c6bnxigHo6ij lOchtj/oJuTUgVSkuC1sNscc1NOIqA56y2ar5JTCQaP8vDFg5ApDWVYp/RKBSoG50rf9 7d+TYhMhVAK7L4/FSAaTO6VS3izq7G65s8ukBVsZ/Wk5CenASbIuS+V1KuSr+xxOrEms nxYVVwNy7HpKNj8Xy8cm/ZiRiWH8dyOYpk+PnSOwuj+7jEQnaNGZOYbnvdqvJztk7Z/s mSdrh+KvQBhQikh+PzosKRMNiV0D42ivllP3hb7rFXRr34HoAwUk8Eu5qr9wFNbNT8Bo xXRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=oKr0M1AW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kc8-20020a17090333c800b001960922af15si13475681plb.239.2023.03.01.19.55.49; Wed, 01 Mar 2023 19:56:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=oKr0M1AW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229656AbjCBDhK (ORCPT + 99 others); Wed, 1 Mar 2023 22:37:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbjCBDhG (ORCPT ); Wed, 1 Mar 2023 22:37:06 -0500 Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9F7F515E5 for ; Wed, 1 Mar 2023 19:36:54 -0800 (PST) Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20230302033652epoutp041feee088f91e2a7c5f9e18b8403dd4b5~IfOuL3XOD2276622766epoutp04t for ; Thu, 2 Mar 2023 03:36:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20230302033652epoutp041feee088f91e2a7c5f9e18b8403dd4b5~IfOuL3XOD2276622766epoutp04t DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1677728212; bh=1dHKyuZlL0P4DI+hxJfy4whngOGz/lEMA5DJX2l/rYY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oKr0M1AWKo+FdVvyk3OHva46NXjOc5NktlkWULsIXYojhv/f/rZJLC8nkqPuhTFUQ El6O3/eqDNBL78OxYUASGhH+5XjhBXSH8uIubjD3BB2tjJ8azh/RTDe9R6WN0VokdZ o0C1twHk3NS4VHEBve+QV0GRr7PFt+zN+nh2KRsI= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20230302033651epcas1p10ffa4c70fae14e8159a4154392b8bd9c~IfOtz_A2m2270322703epcas1p15; Thu, 2 Mar 2023 03:36:51 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.36.224]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4PRxc31q1Qz4x9Q7; Thu, 2 Mar 2023 03:36:51 +0000 (GMT) Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id 89.28.54823.3D910046; Thu, 2 Mar 2023 12:36:51 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230302033650epcas1p1a158f2722d598b5d8a198aa748d9d27b~IfOsvXyqa2267922679epcas1p1e; Thu, 2 Mar 2023 03:36:50 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20230302033650epsmtrp14016775bdb86c25691841a23aad30839~IfOsutP8U2681726817epsmtrp1A; Thu, 2 Mar 2023 03:36:50 +0000 (GMT) X-AuditID: b6c32a39-d01fc7000000d627-53-640019d34ca2 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 26.90.05839.2D910046; Thu, 2 Mar 2023 12:36:50 +0900 (KST) Received: from VDBS1418.vd.sec.samsung.net (unknown [168.219.244.30]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230302033650epsmtip2ac1e1466aa79ec60fe06ce60c3dbcb56~IfOsjuETd2525725257epsmtip2B; Thu, 2 Mar 2023 03:36:50 +0000 (GMT) From: Bumwoo Lee To: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: Bumwoo Lee Subject: [PATCH v3 4/4] extcon: Added extcon_alloc_groups to simplify extcon register function Date: Thu, 2 Mar 2023 12:36:45 +0900 Message-Id: <20230302033645.23933-5-bw365.lee@samsung.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230302033645.23933-1-bw365.lee@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLKsWRmVeSWpSXmKPExsWy7bCmvu5lSYYUgyevuSxOrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUdk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6 hpYW5koKeYm5qbZKLj4Bum6ZOUCLlBTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2SqkFKTkF ZgV6xYm5xaV56Xp5qSVWhgYGRqZAhQnZGfMuRxZMEa64NX0DawPjK/4uRk4OCQETiSe9J9m6 GLk4hAR2MEr86GyFcj4xSpxZuIwRwvnGKLHw+Fp2mJYFLRdYIRJ7GSV2L9rMBOH8YpTYePc5 C0gVm4CGxJ6LDUCzODhEBAolDvdng4SZBdQkHqzaCDZIWCBB4mXLZyYQm0VAVWLH3/tsIDav gJXE7Pv9LBDL5CW6//0BszkFrCW+vf3BDlEjKHFy5hMWiJnyEs1bZzOD3CAhsItd4srMFjaI ZheJ+b+fMULYwhKvjm+B+kBK4mV/G5SdLrHyyh0oO0fi9f12qHpjiXdv1zKD3M8soCmxfpc+ RFhRYufvuYwQe/kk3n3tYQUpkRDglehoE4IoUZbofvCCCcKWlFj89A7URA+JXfcWQQO0j1Fi W88HtgmMCrOQvDMLyTuzEDYvYGRexSiWWlCcm55abFhgCo/g5PzcTYzgdKdluYNx+tsPeocY mTgYDzFKcDArifAuvP0nWYg3JbGyKrUoP76oNCe1+BCjKTCwJzJLiSbnAxNuXkm8oYmlgYmZ kYmFsaWxmZI4r7jtyWQhgfTEktTs1NSC1CKYPiYOTqkGpg3pwkqzfeZeOiE1RbXEgnlH7YrJ bruO1BW0vTWdKTVFPnfO+Qn9i0Uvs7rd6OGcfDgnouL4VWY++cKdqZ7TmY5aiN1dcyzxw+Fb iQwC5wSW/DNnLZq/c2fQr8XFgZ7GDPG1Mzs+T/07ycs64mD7a48fi25Gxv3qv8j5pkV8a6bx 5eAL9W9re2buEbnMspaJt6V8Wt+ZPQb7Ss6Jl6w4oHuBK3ReNuvFoLuOuqdO5suvaCh8E3iH 8R7L+snGav/cL+XPOZTztXC2qUdP3N4Jyg79UU/3TVpXL+GZXiWuX87S3RW8XnpmxK9eszvn V24v/PPySMX1f9ts5xRHX9mreXTlwWtM626nTrF0dC3l01NiKc5INNRiLipOBAAu5qXqAAQA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGLMWRmVeSWpSXmKPExsWy7bCSvO4lSYYUg2t3NSxOrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUVw2Kak5mWWpRfp2CVwZ8y5HFkwRrrg1fQNrA+Mr /i5GTg4JAROJBS0XWLsYuTiEBHYzSkx5u4sZIiEpcXb5I/YuRg4gW1ji8OFiiJofjBJ3Fu5k BKlhE9CQ2HOxgQ3EFhEolrhwYDELiM0soCbxYNVGsF5hgTiJXScjQcIsAqoSO/7eByvnFbCS mH2/nwVilbxE978/YDangLXEt7c/2EFsIaCaPYt6mSHqBSVOznwCNV5eonnrbOYJjAKzkKRm IUktYGRaxSiZWlCcm55bbFhgmJdarlecmFtcmpeul5yfu4kRHJRamjsYt6/6oHeIkYmD8RCj BAezkgjvwtt/koV4UxIrq1KL8uOLSnNSiw8xSnOwKInzXug6GS8kkJ5YkpqdmlqQWgSTZeLg lGpg2r/r81/x6jMzjYRXNCx8ddDgZ/Kdk88+xP7SOj2ZeWPQpJy5K+OnPt9QYrmm4gf382O3 l86Z3PruUaL32fyljfMcVCuEnvnam2V0rz22qGLCgl+X7255z5Gd1fSDP/jU2dPPp95i6uVh s0r5byYnpvjde0tRUQyblXazqXb7LvGAgyklsmlWFqY+dzq7mvgWcZ/Tbtjeol+eU2+x7W9V 7j4X9kMTRVqu7tkmeeqX0mMej19C1dmPco4UHeXvaZ4xfe3kilvbuyMtLNzyeSfqyWy+VcUZ eMyc8XXBidnTjG72Jy9Q36OcfvNNtvwMqTk3brx/Wb20UKLL/dyp5lsv5BLXpJQevjj3UJH7 +vVP1ZVYijMSDbWYi4oTAZJ+xmO5AgAA X-CMS-MailID: 20230302033650epcas1p1a158f2722d598b5d8a198aa748d9d27b X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230302033650epcas1p1a158f2722d598b5d8a198aa748d9d27b References: <20230302033645.23933-1-bw365.lee@samsung.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759226743525439358?= X-GMAIL-MSGID: =?utf-8?q?1759226743525439358?= The alloc groups is functionalized from extcon_dev_register. Signed-off-by: Bumwoo Lee --- drivers/extcon/extcon.c | 58 +++++++++++++++++++++++++---------------- 1 file changed, 36 insertions(+), 22 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 287cf6568661..f91f4084da6e 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1181,6 +1181,39 @@ static int extcon_alloc_muex(struct extcon_dev *edev) return 0; } +/** + * extcon_alloc_groups() - alloc the groups for extcon device + * @edev: extcon device + * + * Returns 0 if success or error number if fail. + */ +static int extcon_alloc_groups(struct extcon_dev *edev) +{ + int index; + + if (!edev->max_supported) + return 0; + + edev->extcon_dev_type.groups = kcalloc(edev->max_supported + 2, + sizeof(struct attribute_group *), + GFP_KERNEL); + if (!edev->extcon_dev_type.groups) + return -ENOMEM; + + edev->extcon_dev_type.name = dev_name(&edev->dev); + edev->extcon_dev_type.release = dummy_sysfs_dev_release; + + for (index = 0; index < edev->max_supported; index++) + edev->extcon_dev_type.groups[index] = &edev->cables[index].attr_g; + + if (edev->mutually_exclusive) + edev->extcon_dev_type.groups[index] = &edev->attr_g_muex; + + edev->dev.type = &edev->extcon_dev_type; + + return 0; +} + /** * extcon_dev_register() - Register an new extcon device * @edev: the extcon device to be registered @@ -1236,28 +1269,9 @@ int extcon_dev_register(struct extcon_dev *edev) if (ret < 0) goto err_alloc_muex; - if (edev->max_supported) { - edev->extcon_dev_type.groups = - kcalloc(edev->max_supported + 2, - sizeof(struct attribute_group *), - GFP_KERNEL); - if (!edev->extcon_dev_type.groups) { - ret = -ENOMEM; - goto err_alloc_groups; - } - - edev->extcon_dev_type.name = dev_name(&edev->dev); - edev->extcon_dev_type.release = dummy_sysfs_dev_release; - - for (index = 0; index < edev->max_supported; index++) - edev->extcon_dev_type.groups[index] = - &edev->cables[index].attr_g; - if (edev->mutually_exclusive) - edev->extcon_dev_type.groups[index] = - &edev->attr_g_muex; - - edev->dev.type = &edev->extcon_dev_type; - } + ret = extcon_alloc_groups(edev); + if (ret < 0) + goto err_alloc_groups; spin_lock_init(&edev->lock); if (edev->max_supported) {