From patchwork Thu Mar 2 02:53:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anshuman Khandual X-Patchwork-Id: 63179 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4012135wrd; Wed, 1 Mar 2023 19:12:42 -0800 (PST) X-Google-Smtp-Source: AK7set+60zsfBRxACmlSUOoFwyduXPq1po5NtZUn/5BQAJtbbNvBpYvX71NtBa9vbddL5MnWJh3r X-Received: by 2002:a05:6a20:65aa:b0:be:b04d:1c29 with SMTP id p42-20020a056a2065aa00b000beb04d1c29mr8085480pzh.5.1677726762446; Wed, 01 Mar 2023 19:12:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677726762; cv=none; d=google.com; s=arc-20160816; b=iTVCPFTaiiC1V7YHuWLbBnVOqHlNMA4HBb+FQBIhHEsnfkWsKmGnZy1bE1IteMRHbj a3sneHV4yWzajihc1Uz98fqnNutrpV8wVWpJLk2bepUknXwXKCb/z35WphtXDNB7V6pN Y5zkKzbyF6q1rVog6jqBaKyiSlhl1Faw5Iz0QVpj/YcVYHVs8U5qSzkPa8D5uXnKv37a OzUdS7XWia+L1atPHzhdTWXfOtWKXA1A5i/Hs1S6BkvVO1Qa+2m4gnt54nrWv+kEM1mN sgzfCw5CmtOJQxCIcS7WxiFPVwM0KsAOCnkRTn+c/w27QKL52b1snds7/FNJrR7vrh6z pXpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=LYdVFiXyrkB9NcocTarduO727og0tRge5Fc5hlFCSMc=; b=d+zHYSG9E6cq9nIJc0mfKxzZosFGJBtGQf0q7LNl+g2ro7ktTg9xAcrS/MPnhtjlrA alRAbq/qcHa9UzbUL2xIj875GXuJDIwcLgjFKlGbkA3vCg7QQBMPmigb4fCUfc5y2f3J v/NMWZq9GcZA+kkA00SdtenOZDaEBO0c24UAB/1CHmwdHRF2Z8f9bks5UpRC3odQ9tY+ 4Z031GUX8pfpw9sMMQYvDdwTHKhJeIJBOZMd61mfIFpvZNOEFrwZDVIqhyYEIHBoC3W6 MeG51/B3EvAN8oV/gwh9E9sl1SUAlguUnyuw8UspIZ0VB3jm03IJF0ZzgHuF68xQSjPY 4O9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y185-20020a638ac2000000b00502effa34d0si13941170pgd.433.2023.03.01.19.12.28; Wed, 01 Mar 2023 19:12:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229695AbjCBCyM (ORCPT + 99 others); Wed, 1 Mar 2023 21:54:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229674AbjCBCyM (ORCPT ); Wed, 1 Mar 2023 21:54:12 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B68AA474D8 for ; Wed, 1 Mar 2023 18:54:10 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 99FCB1FB; Wed, 1 Mar 2023 18:54:53 -0800 (PST) Received: from a077893.blr.arm.com (unknown [10.162.41.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C7E9A3F99C; Wed, 1 Mar 2023 18:54:07 -0800 (PST) From: Anshuman Khandual To: linux-mm@kvack.org Cc: david@redhat.com, mike.kravetz@oracle.com, Anshuman Khandual , Andrew Morton , linux-kernel@vger.kernel.org, Christophe Leroy Subject: [PATCH] mm/migrate: Drop pte_mkhuge() in remove_migration_pte() Date: Thu, 2 Mar 2023 08:23:49 +0530 Message-Id: <20230302025349.358341-1-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759224017656872463?= X-GMAIL-MSGID: =?utf-8?q?1759224017656872463?= Since the following commit, arch_make_huge_pte() should be used directly in generic memory subsystem as a platform provided page table helper, instead of pte_mkhuge(). This just drops pte_mkhuge() from remove_migration_pte(), which has now become redundant. 'commit 16785bd77431 ("mm: merge pte_mkhuge() call into arch_make_huge_pte()")' Cc: Andrew Morton Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Reported-by: Christophe Leroy Link: https://lore.kernel.org/all/1ea45095-0926-a56a-a273-816709e9075e@csgroup.eu/ Signed-off-by: Anshuman Khandual Reviewed-by: David Hildenbrand --- This applies on latest mainline. mm/migrate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/migrate.c b/mm/migrate.c index 37865f85df6d..d3964c414010 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -249,7 +249,6 @@ static bool remove_migration_pte(struct folio *folio, if (folio_test_hugetlb(folio)) { unsigned int shift = huge_page_shift(hstate_vma(vma)); - pte = pte_mkhuge(pte); pte = arch_make_huge_pte(pte, shift, vma->vm_flags); if (folio_test_anon(folio)) hugepage_add_anon_rmap(new, vma, pvmw.address,