From patchwork Wed Mar 1 19:31:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 63045 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3832379wrd; Wed, 1 Mar 2023 11:48:08 -0800 (PST) X-Google-Smtp-Source: AK7set8HM/uGjSt5BgmvjAi7tfIcaPKWVkKj2/fsr2gr/7BnfXgP3/I8uGd/MEDli+Z+j9MkV/xL X-Received: by 2002:a05:6a21:3391:b0:cd:2952:7b69 with SMTP id yy17-20020a056a21339100b000cd29527b69mr10176463pzb.52.1677700088066; Wed, 01 Mar 2023 11:48:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677700088; cv=none; d=google.com; s=arc-20160816; b=qbdiI0cDUqaNrSw4UgbWKkRdjp4LQ87L/jZRxsvicxTBepHphGK5IINNNb1mxEnVd5 HBQjQ6g5LZwe52Cf05yOq2ueyI6H0kDAnCxEkGwG3qrxKwb8fvy3kTV7ctqpYvNThcne wjx1WX3TCZMJ8ST7tGY9pdbbuVM5OWshIkw0CgPJDAgaLm6M7lkfBa85LXGmfnkWZg+j dvw5YUUwWJNMaGyFQmxgPjRQwwd27ltdAdu32fFsfvAvf1NnvofbySA4QAMR8Y8Q4Yfr g99xCKXsXfbWW2dZCiWHSnHUicXOelGFQer/kBncl/FoAIH+u5DTYomGzX4ggIzxC2na TXNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=lLfI3q+HyPLNpDCJVwP74tGPwiAToiyYbeP/e9kJDLE=; b=sIJpDgz+kJKvkZlR2cjoNFzZzgd6POvScLQ2upLrVlXkCkF080h6ugVoFG8cX5TreE 0dayGGUt+8cCZn6yGLZopnjfnrCdGr3eaYcSSaEj4gPne1MmkOri8eBHUAiLTkBPhOeq bqo/OfXN1zJ0sD+7YtsvHuuDNWzQEbyHYCfOyq9/5bWzVWnHId7pkHtpzjTWrhN+QIK+ Dtm+oJLxmI4bKZSF8WXvq8i2gXBfLJDruEIbd7c7g5jItFtrnKHoVPWQ3KiOh8fLt2Wk RC/AfQs/unAGYVobNrjgMIvNVxaODScK5xuxPkQjB1igEFMqWktOBqWNwp3fUTTs5ZIi KGBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=Bz2FBPq6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q13-20020a63d60d000000b004fba11c5dfesi5915036pgg.250.2023.03.01.11.47.55; Wed, 01 Mar 2023 11:48:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=Bz2FBPq6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229667AbjCATbo (ORCPT + 99 others); Wed, 1 Mar 2023 14:31:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbjCATbm (ORCPT ); Wed, 1 Mar 2023 14:31:42 -0500 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36ADE5FCC for ; Wed, 1 Mar 2023 11:31:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1677699095; bh=ul8usQAbbNJQCZ/MrwvldJUTAiszHlywsZmtfrqpycM=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=Bz2FBPq6j0ogzuNRKFJtiFPIR4V9qUonmJ8vMNizdhH9PoqAAGL5YTRNf+eupjwka FKo64ubX8800EGF0YyodGxmrFML5icKQJI36nO8PIJTfvy3RSJkyHisnJP1Q7OQF1s C8gsKIzUPnuYkzRQ+Do0UBTwnAZPRZsmLgj/Itrk= Received: by b221-3.in.mailobj.net [192.168.90.23] with ESMTP via ip-20.mailobj.net [213.182.54.20] Wed, 1 Mar 2023 20:31:35 +0100 (CET) X-EA-Auth: 6hanWLmy7mT7Pe/X0hDdaRnPJixamWgy+Zw4ZXcjUzhjQX1YSHt5Pime91mPkUL69jOOQ71InQc+xBMupO72LgaySvodfS1N Date: Thu, 2 Mar 2023 01:01:31 +0530 From: Deepak R Varma To: Parthiban Veerasooran , Christian Gromm , linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar , Deepak R Varma Subject: [PATCH RESEND] most: core: Use sysfs_emit in show function callsbacks Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759196047451497807?= X-GMAIL-MSGID: =?utf-8?q?1759196047451497807?= According to Documentation/filesystems/sysfs.rst, the show() callback function of kobject attributes should strictly use sysfs_emit instead of sprintf family functions. Issue identified using the coccinelle device_attr_show.cocci script. Signed-off-by: Deepak R Varma Acked-by: Parthiban Veerasooran --- Note: Resending the patch for review and feedback. No functional changes. drivers/most/core.c | 61 ++++++++++++++++++++++----------------------- 1 file changed, 30 insertions(+), 31 deletions(-) diff --git a/drivers/most/core.c b/drivers/most/core.c index e4412c7d25b0..f9ca6a7d885c 100644 --- a/drivers/most/core.c +++ b/drivers/most/core.c @@ -208,8 +208,8 @@ static ssize_t number_of_packet_buffers_show(struct device *dev, struct most_channel *c = to_channel(dev); unsigned int i = c->channel_id; - return snprintf(buf, PAGE_SIZE, "%d\n", - c->iface->channel_vector[i].num_buffers_packet); + return sysfs_emit(buf, "%d\n", + c->iface->channel_vector[i].num_buffers_packet); } static ssize_t number_of_stream_buffers_show(struct device *dev, @@ -219,8 +219,8 @@ static ssize_t number_of_stream_buffers_show(struct device *dev, struct most_channel *c = to_channel(dev); unsigned int i = c->channel_id; - return snprintf(buf, PAGE_SIZE, "%d\n", - c->iface->channel_vector[i].num_buffers_streaming); + return sysfs_emit(buf, "%d\n", + c->iface->channel_vector[i].num_buffers_streaming); } static ssize_t size_of_packet_buffer_show(struct device *dev, @@ -230,8 +230,8 @@ static ssize_t size_of_packet_buffer_show(struct device *dev, struct most_channel *c = to_channel(dev); unsigned int i = c->channel_id; - return snprintf(buf, PAGE_SIZE, "%d\n", - c->iface->channel_vector[i].buffer_size_packet); + return sysfs_emit(buf, "%d\n", + c->iface->channel_vector[i].buffer_size_packet); } static ssize_t size_of_stream_buffer_show(struct device *dev, @@ -241,8 +241,8 @@ static ssize_t size_of_stream_buffer_show(struct device *dev, struct most_channel *c = to_channel(dev); unsigned int i = c->channel_id; - return snprintf(buf, PAGE_SIZE, "%d\n", - c->iface->channel_vector[i].buffer_size_streaming); + return sysfs_emit(buf, "%d\n", + c->iface->channel_vector[i].buffer_size_streaming); } static ssize_t channel_starving_show(struct device *dev, @@ -251,7 +251,7 @@ static ssize_t channel_starving_show(struct device *dev, { struct most_channel *c = to_channel(dev); - return snprintf(buf, PAGE_SIZE, "%d\n", c->is_starving); + return sysfs_emit(buf, "%d\n", c->is_starving); } static ssize_t set_number_of_buffers_show(struct device *dev, @@ -260,7 +260,7 @@ static ssize_t set_number_of_buffers_show(struct device *dev, { struct most_channel *c = to_channel(dev); - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.num_buffers); + return sysfs_emit(buf, "%d\n", c->cfg.num_buffers); } static ssize_t set_buffer_size_show(struct device *dev, @@ -269,7 +269,7 @@ static ssize_t set_buffer_size_show(struct device *dev, { struct most_channel *c = to_channel(dev); - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.buffer_size); + return sysfs_emit(buf, "%d\n", c->cfg.buffer_size); } static ssize_t set_direction_show(struct device *dev, @@ -279,10 +279,10 @@ static ssize_t set_direction_show(struct device *dev, struct most_channel *c = to_channel(dev); if (c->cfg.direction & MOST_CH_TX) - return snprintf(buf, PAGE_SIZE, "tx\n"); + return sysfs_emit(buf, "tx\n"); else if (c->cfg.direction & MOST_CH_RX) - return snprintf(buf, PAGE_SIZE, "rx\n"); - return snprintf(buf, PAGE_SIZE, "unconfigured\n"); + return sysfs_emit(buf, "rx\n"); + return sysfs_emit(buf, "unconfigured\n"); } static ssize_t set_datatype_show(struct device *dev, @@ -294,10 +294,9 @@ static ssize_t set_datatype_show(struct device *dev, for (i = 0; i < ARRAY_SIZE(ch_data_type); i++) { if (c->cfg.data_type & ch_data_type[i].most_ch_data_type) - return snprintf(buf, PAGE_SIZE, "%s", - ch_data_type[i].name); + return sysfs_emit(buf, "%s", ch_data_type[i].name); } - return snprintf(buf, PAGE_SIZE, "unconfigured\n"); + return sysfs_emit(buf, "unconfigured\n"); } static ssize_t set_subbuffer_size_show(struct device *dev, @@ -306,7 +305,7 @@ static ssize_t set_subbuffer_size_show(struct device *dev, { struct most_channel *c = to_channel(dev); - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.subbuffer_size); + return sysfs_emit(buf, "%d\n", c->cfg.subbuffer_size); } static ssize_t set_packets_per_xact_show(struct device *dev, @@ -315,7 +314,7 @@ static ssize_t set_packets_per_xact_show(struct device *dev, { struct most_channel *c = to_channel(dev); - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.packets_per_xact); + return sysfs_emit(buf, "%d\n", c->cfg.packets_per_xact); } static ssize_t set_dbr_size_show(struct device *dev, @@ -323,7 +322,7 @@ static ssize_t set_dbr_size_show(struct device *dev, { struct most_channel *c = to_channel(dev); - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.dbr_size); + return sysfs_emit(buf, "%d\n", c->cfg.dbr_size); } #define to_dev_attr(a) container_of(a, struct device_attribute, attr) @@ -395,7 +394,7 @@ static ssize_t description_show(struct device *dev, { struct most_interface *iface = dev_get_drvdata(dev); - return snprintf(buf, PAGE_SIZE, "%s\n", iface->description); + return sysfs_emit(buf, "%s\n", iface->description); } static ssize_t interface_show(struct device *dev, @@ -406,25 +405,25 @@ static ssize_t interface_show(struct device *dev, switch (iface->interface) { case ITYPE_LOOPBACK: - return snprintf(buf, PAGE_SIZE, "loopback\n"); + return sysfs_emit(buf, "loopback\n"); case ITYPE_I2C: - return snprintf(buf, PAGE_SIZE, "i2c\n"); + return sysfs_emit(buf, "i2c\n"); case ITYPE_I2S: - return snprintf(buf, PAGE_SIZE, "i2s\n"); + return sysfs_emit(buf, "i2s\n"); case ITYPE_TSI: - return snprintf(buf, PAGE_SIZE, "tsi\n"); + return sysfs_emit(buf, "tsi\n"); case ITYPE_HBI: - return snprintf(buf, PAGE_SIZE, "hbi\n"); + return sysfs_emit(buf, "hbi\n"); case ITYPE_MEDIALB_DIM: - return snprintf(buf, PAGE_SIZE, "mlb_dim\n"); + return sysfs_emit(buf, "mlb_dim\n"); case ITYPE_MEDIALB_DIM2: - return snprintf(buf, PAGE_SIZE, "mlb_dim2\n"); + return sysfs_emit(buf, "mlb_dim2\n"); case ITYPE_USB: - return snprintf(buf, PAGE_SIZE, "usb\n"); + return sysfs_emit(buf, "usb\n"); case ITYPE_PCIE: - return snprintf(buf, PAGE_SIZE, "pcie\n"); + return sysfs_emit(buf, "pcie\n"); } - return snprintf(buf, PAGE_SIZE, "unknown\n"); + return sysfs_emit(buf, "unknown\n"); } static DEVICE_ATTR_RO(description);