From patchwork Wed Mar 1 03:59:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 62751 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3414556wrd; Tue, 28 Feb 2023 19:59:33 -0800 (PST) X-Google-Smtp-Source: AK7set96fFvD3ib5It0B6opaGVQXQFmUUzKWzuNYrtXBXpLGbFInwh0Ijygkn7GsPcVdTjUUAGZE X-Received: by 2002:aa7:db88:0:b0:4ab:15d9:2dae with SMTP id u8-20020aa7db88000000b004ab15d92daemr5607457edt.14.1677643173074; Tue, 28 Feb 2023 19:59:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677643173; cv=none; d=google.com; s=arc-20160816; b=jk5U+tSd1GZgD2T2ADcTZrW90jf90uzPY0ioJjFdLsPFOSwbbUeZSaTV7l2GlPi+zO 8qtXK0A4xIf3fOt/asIb+3qvcXVc464upsbSyCSh+hukOfZr3vToLjkgLUmc9pbwyZfe HFLPWGwobqjclmMkgI32EvUEoXSRrNNxgir1fDpo9rR6ixkweMF7/Jja/PFUzvdIrONX 4/u5I67QKU7DwXMEmiVWFMCko7AXbuetgsY7gNAqhp9TUNvsCwTlRP2zp/2DwlNERSH7 RhvjnvkQBXE4Om7s0uc4J/M7MzGYomklqwUxZVhk1v0j9pEDXSD+pXynDmX0Ajlm4U0o JWZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=SbGAUdp+/oR1ZwS34O4AVXd6iCQuGhdC9mmf6B9Cc+A=; b=rq9JPv9mY9w/HZq+fFReabjrE3xbD95pH/WEAsvuxw7eIEG3S4z+QaF8/EwhtIHt2o jnY0JLZ9uzXEvtuIONWkvAheCPyvSmeOmvRqlxdZkr1iRtkWbbGI97yJ+08AGapVP+dC guRwb1JCTbnKUzi/rcNFQumGt/PKGoDH8RjzwdwR07chTVcnNX/HTlDPTVSFJfhlHFFG n8iWZr9kNoZRbbzHLkGSXpa9i/xcjYdV7mtkJCRoqvIlV6KBemFd6/TBeQEolqnXPlTj +iolMtmWTxLgApt0h8nOoQxZ8xLaSCKFRO4SNuconmsKxULslyPng7GwFgmj309WTdvB 7+Rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=m7fveHLS; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id r12-20020aa7d58c000000b004ab25817358si13038105edq.251.2023.02.28.19.59.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 19:59:33 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=m7fveHLS; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 108D1385842A for ; Wed, 1 Mar 2023 03:59:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 108D1385842A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677643172; bh=SbGAUdp+/oR1ZwS34O4AVXd6iCQuGhdC9mmf6B9Cc+A=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=m7fveHLSdZSyairq5nBfUbosdXlJGnU87IwLP0zxT/+udYbJtIx0UlMtL7K1H2PyL beuTCUvq5dVv7nlx0iP+yYrWUhHU88rBGZtyaj+wanAEBoQjPI7J1dKObu+5upjzZ0 MIOYWz6qSUV65g542M7CYcmznA31uq/6mgTnua6s= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 01B483858D33 for ; Wed, 1 Mar 2023 03:59:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01B483858D33 Received: by mail-pj1-x102f.google.com with SMTP id m20-20020a17090ab79400b00239d8e182efso5081921pjr.5 for ; Tue, 28 Feb 2023 19:59:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677643161; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SbGAUdp+/oR1ZwS34O4AVXd6iCQuGhdC9mmf6B9Cc+A=; b=NBrkboxs62i8tQg9Jpv8ex/1IfEUuL5nCzAL5L4DquGMCe2rRQ6PmX0ul6PH5OKhiY jHI4wCR03I2Odvnuq8kKkfZIIOoA9xpObDWu7lngdVxqwP5RKWhQ71e4aAnwDtallaoO 6/d+xgVrlbc67TN80bN1qdDORM0PBgYlljYidNf41Htc+VsSZzVCOfl6nJ3jgAowjcxY FjftRAaBNhP3g41sA0fjpg7LxwtvnqzYcveelQfvwJz9S2zXpcZAx091z3OLnb8gxqeo /AbDU5DKvIi3pEcElVlwvh30/lt34bU0m+qq0D5Is1TwzQhy6OYuKLg2Ay6pYZzOiila kWpw== X-Gm-Message-State: AO0yUKVp425yNnSElxBvckB67BAowwtSkaf47PtGkMHiyYAPke+XD+hd 2GhPL8pvYVL423S3wPxY/sp7UFCo8LQ= X-Received: by 2002:a05:6a21:6d9a:b0:cc:d514:62cf with SMTP id wl26-20020a056a216d9a00b000ccd51462cfmr7612151pzb.43.1677643161492; Tue, 28 Feb 2023 19:59:21 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id z24-20020aa785d8000000b005a8a5be96b2sm6792368pfn.104.2023.02.28.19.59.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 19:59:21 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 8009D1142C8A; Wed, 1 Mar 2023 14:29:18 +1030 (ACDT) Date: Wed, 1 Mar 2023 14:29:18 +1030 To: binutils@sourceware.org Subject: Memory leak in gas do_repeat Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3035.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759136367737279432?= X-GMAIL-MSGID: =?utf-8?q?1759136367737279432?= * read.c (do_repeat): Free sb on error path. diff --git a/gas/read.c b/gas/read.c index f1099cba1a3..d43584be28c 100644 --- a/gas/read.c +++ b/gas/read.c @@ -3029,6 +3029,7 @@ do_repeat (size_t count, const char *start, const char *end, if (!buffer_and_nest (start, end, &one, get_non_macro_line_sb)) { as_bad (_("%s without %s"), start, end); + sb_kill (&one); return; }